Subject: bug#54801: closed (Re: bug#54801: [PATCH] gnu: lsof: Fix invalid G-Expression.)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 08 Apr 2022 21:08:02 +0000

Your bug report

#54801: [PATCH] gnu: lsof: Fix invalid G-Expression.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
54801: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54801
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#54801: [PATCH] gnu: lsof: Fix invalid G-Expression.
From: Ludovic Courtès <[email-masked]>
To: Brian Kubisiak <[email-masked]>
Cc: [email-masked]
Date: Fri, 08 Apr 2022 23:07:04 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Brian Kubisiak <[email-masked]> skribis:

> Cross-compiling lsof is failing with an "invalid G-expression input"
> error. Fix this by using a quoted list.
>
> * gnu/packages/lsof.scm (lsof): Fix invalid G-Expression.

Good catch; applied.

>               ,@(if (%current-target-system)
> -                   (list (setenv "LINUX_CONF_CC" "gcc"))

Ouch, glad it wasn’t (delete-file-recursively "/").

Thanks!

Ludo’.

Subject: [PATCH] gnu: lsof: Fix invalid G-Expression.
From: Brian Kubisiak <[email-masked]>
To: [email-masked]
Date: Fri, 8 Apr 2022 13:30:34 -0700
List-Id: <debbugs-submit.debbugs.gnu.org>

Cross-compiling lsof is failing with an "invalid G-expression input"
error. Fix this by using a quoted list.

* gnu/packages/lsof.scm (lsof): Fix invalid G-Expression.
---
 gnu/packages/lsof.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/lsof.scm b/gnu/packages/lsof.scm
index be7bf43646..5f413483f4 100644
--- a/gnu/packages/lsof.scm
+++ b/gnu/packages/lsof.scm
@@ -55,7 +55,7 @@ (define-public lsof
            (lambda _
              (setenv "LSOF_CC" ,(cc-for-target))
              ,@(if (%current-target-system)
-                   (list (setenv "LINUX_CONF_CC" "gcc"))
+                   '((setenv "LINUX_CONF_CC" "gcc"))
                    '())
              (setenv "LSOF_MAKE" "make")
 
-- 
2.34.0