GNU bug report logs - #54783
ZRAM default priority wrong

Previous Next

Full log

Message #23 received at 54783 <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 54783 <at> debbugs.gnu.org, Stefan Baums <baums <at> stefanbaums.com>,
 Josselin Poiret <dev <at> jpoiret.xyz>
Subject: [v2 0/2] Clarify zram priority
Date: Tue, 24 May 2022 19:16:29 +0200

Hello Maxim,

Thanks for looking at this.  Here's a v2.

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:
> I'm curious, what does delaying the field buys us here?  Is it to avoid
> printing the warning multiple times when the record is evaluated?

Right, and this would get worse if someone ended up inheriting from
another configuration.  It would be bad UX IMO. 

> By convention, a warning message should not be a complete sentence (no
> capitalized first letter nor last period) and be short.  To provide a
> human friendly hint/message, you could use 'display-hint' (combined with
> a more succinct warning).

Right, fixed!

> The rest LGTM.
>
> Maxim

Josselin Poiret (2):
  system: Align zram priority with swap-space spec to clarify.
  doc: Remove double copyright.

 doc/guix.texi          | 11 +++++------
 gnu/services/linux.scm | 29 ++++++++++++++++++++++++++---
 2 files changed, 31 insertions(+), 9 deletions(-)

-- 
2.36.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.