From unknown Sat Jun 21 03:24:23 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#5475 <5475@debbugs.gnu.org> To: bug#5475 <5475@debbugs.gnu.org> Subject: Status: Archives with filenames with square brackets Reply-To: bug#5475 <5475@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:24:23 +0000 retitle 5475 Archives with filenames with square brackets reassign 5475 emacs submitter 5475 Juri Linkov severity 5475 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 25 12:57:34 2010 Received: (at submit) by debbugs.gnu.org; 25 Jan 2010 17:57:34 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZTBs-0005lc-Cn for submit@debbugs.gnu.org; Mon, 25 Jan 2010 12:57:34 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZTBq-0005lQ-ML for submit@debbugs.gnu.org; Mon, 25 Jan 2010 12:57:31 -0500 Received: from mx10.gnu.org ([199.232.76.166]:40960) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZTBm-0003JV-6s for submit@debbugs.gnu.org; Mon, 25 Jan 2010 12:57:26 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NZTBl-0007Ga-5e for submit@debbugs.gnu.org; Mon, 25 Jan 2010 12:57:26 -0500 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on monty-python X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00, FORGED_RCVD_HELO,UNPARSEABLE_RELAY autolearn=ham version=3.1.0 Received: from lists.gnu.org ([199.232.76.165]:43796) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NZTBl-0007GU-10 for submit@debbugs.gnu.org; Mon, 25 Jan 2010 12:57:25 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NZTBk-0002fw-HV for bug-gnu-emacs@gnu.org; Mon, 25 Jan 2010 12:57:24 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NZTBf-0002Z7-KM for bug-gnu-emacs@gnu.org; Mon, 25 Jan 2010 12:57:24 -0500 Received: from [199.232.76.173] (port=56131 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZTBf-0002Yn-CC for bug-gnu-emacs@gnu.org; Mon, 25 Jan 2010 12:57:19 -0500 Received: from smtp-out4.starman.ee ([85.253.0.6]:34935 helo=mx2.starman.ee) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NZTBe-0007Fw-Su for bug-gnu-emacs@gnu.org; Mon, 25 Jan 2010 12:57:19 -0500 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.30.13.cable.starman.ee [82.131.30.13]) by mx2.starman.ee (Postfix) with ESMTP id 987B53F4106 for ; Mon, 25 Jan 2010 19:57:12 +0200 (EET) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: Archives with filenames with square brackets Organization: JURTA Date: Mon, 25 Jan 2010 19:48:33 +0200 Message-ID: <874omakv2m.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.9 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) When a zip archive contains a file with square brackets in its name (e.g. "file[name].txt") then visiting this file displays an error: caution: filename not matched: file[name].txt For more details please see http://lists.gnu.org/archive/html/emacs-devel/2010-01/msg01161.html -- Juri Linkov http://www.jurta.org/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 26 16:05:27 2010 Received: (at 5475) by debbugs.gnu.org; 26 Jan 2010 21:05:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZsbG-0005IW-Vs for submit@debbugs.gnu.org; Tue, 26 Jan 2010 16:05:27 -0500 Received: from pantheon-po29.its.yale.edu ([130.132.50.124]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZsbF-0005IP-0D for 5475@debbugs.gnu.org; Tue, 26 Jan 2010 16:05:25 -0500 Received: from furry (dhcp128036014123.central.yale.edu [128.36.14.123]) (authenticated bits=0) by pantheon-po29.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o0QL5KOF024957 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 26 Jan 2010 16:05:20 -0500 Received: by furry (Postfix, from userid 1000) id 38115C05D; Tue, 26 Jan 2010 14:05:20 -0700 (MST) From: Chong Yidong To: Juri Linkov Subject: Re: Archives with filenames with square brackets Date: Tue, 26 Jan 2010 16:05:20 -0500 Message-ID: <87eilca86n.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -4.9 (----) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.9 (----) > When a zip archive contains a file with square brackets in its name > (e.g. "file[name].txt") then visiting this file displays an error: > > caution: filename not matched: file[name].txt I assume this is a specific quirk of unzip that it handles square brackets specially (characters like * seem to be handled literally). How about this patch? *** lisp/arc-mode.el 2010-01-13 08:35:10 +0000 --- lisp/arc-mode.el 2010-01-26 21:03:54 +0000 *************** *** 1782,1787 **** --- 1782,1791 ---- (apply 'vector (nreverse files)))) (defun archive-zip-extract (archive name) + (when (string-match "[][]" name) + (require 'comint) + (let ((comint-file-name-quote-list '(?\] ?\[))) + (setq name (comint-quote-filename name)))) (if (equal (car archive-zip-extract) "pkzip") (archive-*-extract archive name archive-zip-extract) (archive-extract-by-stdout archive name archive-zip-extract))) From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 26 16:49:16 2010 Received: (at 5475) by debbugs.gnu.org; 26 Jan 2010 21:49:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZtHg-0005hP-Ha for submit@debbugs.gnu.org; Tue, 26 Jan 2010 16:49:16 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZtHd-0005hJ-4G for 5475@debbugs.gnu.org; Tue, 26 Jan 2010 16:49:15 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KWV00H00HXEEE00@a-mtaout22.012.net.il> for 5475@debbugs.gnu.org; Tue, 26 Jan 2010 23:47:34 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.127.180.161]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KWV009NYJ797QP0@a-mtaout22.012.net.il>; Tue, 26 Jan 2010 23:47:34 +0200 (IST) Date: Tue, 26 Jan 2010 23:47:37 +0200 From: Eli Zaretskii Subject: Re: bug#5475: Archives with filenames with square brackets In-reply-to: <87eilca86n.fsf@stupidchicken.com> X-012-Sender: halo1@inter.net.il To: Chong Yidong Message-id: <83r5pc4jye.fsf@gnu.org> References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 5475 Cc: juri@jurta.org, 5475@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > From: Chong Yidong > Date: Tue, 26 Jan 2010 16:05:20 -0500 > Cc: 5475@debbugs.gnu.org > > > When a zip archive contains a file with square brackets in its name > > (e.g. "file[name].txt") then visiting this file displays an error: > > > > caution: filename not matched: file[name].txt > > I assume this is a specific quirk of unzip that it handles square > brackets specially (characters like * seem to be handled literally). I think it treats all wildcard characters the same. A `*' may not cause a warning because a file whose name is literally foo*, matches the wildcard foo*. > How about this patch? > > *** lisp/arc-mode.el 2010-01-13 08:35:10 +0000 > --- lisp/arc-mode.el 2010-01-26 21:03:54 +0000 > *************** > *** 1782,1787 **** > --- 1782,1791 ---- > (apply 'vector (nreverse files)))) > > (defun archive-zip-extract (archive name) > + (when (string-match "[][]" name) > + (require 'comint) > + (let ((comint-file-name-quote-list '(?\] ?\[))) > + (setq name (comint-quote-filename name)))) > (if (equal (car archive-zip-extract) "pkzip") > (archive-*-extract archive name archive-zip-extract) > (archive-extract-by-stdout archive name archive-zip-extract))) First, why not use shell-quote-argument, instead of requiring comint? Second, could someone please see if pkzip also expands wildcards internally? If it does not, the quoting will need to be done only in the non-pkzip branch. We also need to test this on MS-Windows. But most importantly, this patch is not clean, IMO: it hardcodes into archive-zip-extract (the function) some knowledge of what can be the possible values of archive-zip-extract the defcustom. What if tomorrow there will be a 3rd possibility, in addition to pkzip and unzip? That is why I thought about some less trivial patch: add to the data structures that are values of these defcustom's a flag to indicate whether the file name needs to be quoted or not. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 27 11:57:53 2010 Received: (at 5475) by debbugs.gnu.org; 27 Jan 2010 16:57:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NaBDF-0004UA-N1 for submit@debbugs.gnu.org; Wed, 27 Jan 2010 11:57:53 -0500 Received: from pantheon-po33.its.yale.edu ([130.132.50.94]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NaBDC-0004U5-VW for 5475@debbugs.gnu.org; Wed, 27 Jan 2010 11:57:51 -0500 Received: from furry (dhcp128036014123.central.yale.edu [128.36.14.123]) (authenticated bits=0) by pantheon-po33.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o0RGvkx1021522 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 27 Jan 2010 11:57:46 -0500 Received: by furry (Postfix, from userid 1000) id 20BFDC05D; Wed, 27 Jan 2010 09:57:46 -0700 (MST) From: Chong Yidong To: Eli Zaretskii Subject: Re: bug#5475: Archives with filenames with square brackets References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> Date: Wed, 27 Jan 2010 11:57:46 -0500 In-Reply-To: <83r5pc4jye.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 26 Jan 2010 23:47:37 +0200") Message-ID: <87vden4h9x.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 5475 Cc: juri@jurta.org, 5475@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) Eli Zaretskii writes: > First, why not use shell-quote-argument, instead of requiring comint? I wasn't sure whether it was only [] that was handled specially, or the usual shell wildcards. But I see now that it is the latter, as you say. So shell-quote-argument is indeed the correct thing. > Second, could someone please see if pkzip also expands wildcards > internally? If it does not, the quoting will need to be done only in > the non-pkzip branch. We also need to test this on MS-Windows. I have no way to check this. Looks like pkzip is Windows-only. > But most importantly, this patch is not clean, IMO: it hardcodes into > archive-zip-extract (the function) some knowledge of what can be the > possible values of archive-zip-extract the defcustom. What if > tomorrow there will be a 3rd possibility, in addition to pkzip and > unzip? > > That is why I thought about some less trivial patch: add to the data > structures that are values of these defcustom's a flag to indicate > whether the file name needs to be quoted or not. Well, archive-zip-extract already branches for pkzip/unzip, so whatever uncleanliness that's associated with is already present... From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 27 12:35:32 2010 Received: (at 5475) by debbugs.gnu.org; 27 Jan 2010 17:35:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NaBnf-0004og-7n for submit@debbugs.gnu.org; Wed, 27 Jan 2010 12:35:31 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NaBnd-0004ob-My for 5475@debbugs.gnu.org; Wed, 27 Jan 2010 12:35:30 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KWX00K0023CO800@a-mtaout22.012.net.il> for 5475@debbugs.gnu.org; Wed, 27 Jan 2010 19:35:15 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.127.180.161]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KWX00G6G26OZYE0@a-mtaout22.012.net.il>; Wed, 27 Jan 2010 19:35:13 +0200 (IST) Date: Wed, 27 Jan 2010 19:35:17 +0200 From: Eli Zaretskii Subject: Re: bug#5475: Archives with filenames with square brackets In-reply-to: <87vden4h9x.fsf@stupidchicken.com> X-012-Sender: halo1@inter.net.il To: Chong Yidong Message-id: <83ljfj4fje.fsf@gnu.org> References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 5475 Cc: juri@jurta.org, 5475@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > From: Chong Yidong > Cc: juri@jurta.org, 5475@debbugs.gnu.org > Date: Wed, 27 Jan 2010 11:57:46 -0500 > > > But most importantly, this patch is not clean, IMO: it hardcodes into > > archive-zip-extract (the function) some knowledge of what can be the > > possible values of archive-zip-extract the defcustom. What if > > tomorrow there will be a 3rd possibility, in addition to pkzip and > > unzip? > > > > That is why I thought about some less trivial patch: add to the data > > structures that are values of these defcustom's a flag to indicate > > whether the file name needs to be quoted or not. > > Well, archive-zip-extract already branches for pkzip/unzip Yes, but it does that by a user option, not by some hidden knowledge. I won't mind introducing a similar option that would tell arc-mode to quote the file arguments. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 15:07:15 2010 Received: (at 5475) by debbugs.gnu.org; 28 Jan 2010 20:07:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Naae3-0007Wd-2v for submit@debbugs.gnu.org; Thu, 28 Jan 2010 15:07:15 -0500 Received: from pantheon-po33.its.yale.edu ([130.132.50.94]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Naae1-0007WX-TS for 5475@debbugs.gnu.org; Thu, 28 Jan 2010 15:07:14 -0500 Received: from furry (dhcp128036014123.central.yale.edu [128.36.14.123]) (authenticated bits=0) by pantheon-po33.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o0SK79FS018196 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 28 Jan 2010 15:07:09 -0500 Received: by furry (Postfix, from userid 1000) id 92DF9C05D; Thu, 28 Jan 2010 15:07:09 -0500 (EST) From: Chong Yidong To: Eli Zaretskii Subject: Re: bug#5475: Archives with filenames with square brackets References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com> <83ljfj4fje.fsf@gnu.org> Date: Thu, 28 Jan 2010 15:07:09 -0500 In-Reply-To: <83ljfj4fje.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 27 Jan 2010 19:35:17 +0200") Message-ID: <87r5pavvrm.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 5475 Cc: juri@jurta.org, 5475@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) Eli Zaretskii writes: >> Well, archive-zip-extract already branches for pkzip/unzip > > Yes, but it does that by a user option, not by some hidden knowledge. > I won't mind introducing a similar option that would tell arc-mode to > quote the file arguments. Right, but once the user tells arc-mode to use unzip, we can automagically shell-quote the filename; there seems to be no reason not to. It doesn't seem like anyone's going to test PKzip anytime soon. In the meantime, I have checked in the change to use shell-quote-argument for unzip. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 16:06:24 2010 Received: (at 5475) by debbugs.gnu.org; 28 Jan 2010 21:06:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NabZ6-0001Bf-DG for submit@debbugs.gnu.org; Thu, 28 Jan 2010 16:06:24 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NabZ2-0001BW-VA for 5475@debbugs.gnu.org; Thu, 28 Jan 2010 16:06:11 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KWZ00H006J8UV00@a-mtaout22.012.net.il> for 5475@debbugs.gnu.org; Thu, 28 Jan 2010 23:05:06 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.127.180.161]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KWZ00D696KGT0A0@a-mtaout22.012.net.il>; Thu, 28 Jan 2010 23:05:05 +0200 (IST) Date: Thu, 28 Jan 2010 23:05:04 +0200 From: Eli Zaretskii Subject: Re: bug#5475: Archives with filenames with square brackets In-reply-to: <87r5pavvrm.fsf@stupidchicken.com> X-012-Sender: halo1@inter.net.il To: Chong Yidong Message-id: <838wbiszy7.fsf@gnu.org> References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com> <83ljfj4fje.fsf@gnu.org> <87r5pavvrm.fsf@stupidchicken.com> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 5475 Cc: juri@jurta.org, 5475@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > From: Chong Yidong > Cc: juri@jurta.org, 5475@debbugs.gnu.org > Date: Thu, 28 Jan 2010 15:07:09 -0500 > > Eli Zaretskii writes: > > >> Well, archive-zip-extract already branches for pkzip/unzip > > > > Yes, but it does that by a user option, not by some hidden knowledge. > > I won't mind introducing a similar option that would tell arc-mode to > > quote the file arguments. > > Right, but once the user tells arc-mode to use unzip, we can > automagically shell-quote the filename; there seems to be no reason not > to. If you want to glean the need for quoting from the value of archive-zip-extract (i.e. its car being "unzip"), I'm fine with that as well. But as your patch is written, it imposes that on any unzip command, regardless of whether it was "unzip" or something else, like p7zip, for example. That doesn't seem right to me. > It doesn't seem like anyone's going to test PKzip anytime soon. In the > meantime, I have checked in the change to use shell-quote-argument for > unzip. My "soon" is once a week. You only waited 2 days. :-( From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 16:25:18 2010 Received: (at 5475) by debbugs.gnu.org; 28 Jan 2010 21:25:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NabrZ-0001UZ-MK for submit@debbugs.gnu.org; Thu, 28 Jan 2010 16:25:17 -0500 Received: from fg-out-1718.google.com ([72.14.220.152]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NabrX-0001UP-QV for 5475@debbugs.gnu.org; Thu, 28 Jan 2010 16:25:16 -0500 Received: by fg-out-1718.google.com with SMTP id 22so193208fge.15 for <5475@debbugs.gnu.org>; Thu, 28 Jan 2010 13:25:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=5GsxSrtEl/JvyBBXuK8Hsm4dvwnBWndhcF6/QaVU2ls=; b=R3J2uUSKgkAhzczBjc88Y2VLu4q7Lkwc3OFCfToSmUHprKOU9iLOoX7eVfXqRnYVs0 FuI4ly3Cc/yLj0yYZxe+E8ANkp6eNHSn6XFDwSsRBNJ2FJhZebIgv7RVMw4pUpK4BBru dVajNjo9p/q6LxoH7PRMxNAyPeulUvC/u9cfY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=f+X+/9RCMxXCDBeNyEF39eUkh0p9nBDsE9j/9yFVJTlVqvbobhXHxNZ9yxLKwYkG8U rE4lgcCEfUjYg8Bw7mQy5gt5g6UQS8s5kHc51hOeTtrfWG6+w65ZAXRjqtT3gXMVGfeY vKJeq0pLsk3981iu3yP3+TXF4xhCdvOv0UUl8= MIME-Version: 1.0 Received: by 10.239.166.141 with SMTP id b13mr1251588hbe.101.1264713910406; Thu, 28 Jan 2010 13:25:10 -0800 (PST) In-Reply-To: <838wbiszy7.fsf@gnu.org> References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com> <83ljfj4fje.fsf@gnu.org> <87r5pavvrm.fsf@stupidchicken.com> <838wbiszy7.fsf@gnu.org> From: Lennart Borgman Date: Thu, 28 Jan 2010 22:24:50 +0100 Message-ID: Subject: Re: bug#5475: Archives with filenames with square brackets To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org, Chong Yidong X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) On Thu, Jan 28, 2010 at 10:05 PM, Eli Zaretskii wrote: >> From: Chong Yidong >> Cc: juri@jurta.org, 5475@debbugs.gnu.org >> Date: Thu, 28 Jan 2010 15:07:09 -0500 >> >> Eli Zaretskii writes: >> >> >> Well, archive-zip-extract already branches for pkzip/unzip >> > >> > Yes, but it does that by a user option, not by some hidden knowledge. >> > I won't mind introducing a similar option that would tell arc-mode to >> > quote the file arguments. >> >> Right, but once the user tells arc-mode to use unzip, we can >> automagically shell-quote the filename; there seems to be no reason not >> to. Excuse me, I did not follow this thread at all, but I get curious. What does shell-quote have to do with the arc-mode library? Does it use a shell at all? > If you want to glean the need for quoting from the value of > archive-zip-extract (i.e. its car being "unzip"), I'm fine with that > as well. =C2=A0But as your patch is written, it imposes that on any unzip > command, regardless of whether it was "unzip" or something else, like > p7zip, for example. =C2=A0That doesn't seem right to me. Now that 7-zip is available on GNU/Linux too wouldn't it be very good to include support for it? >> It doesn't seem like anyone's going to test PKzip anytime soon. =C2=A0In= the >> meantime, I have checked in the change to use shell-quote-argument for >> unzip. > > My "soon" is once a week. =C2=A0You only waited 2 days. :-( > > > > > From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 17:00:59 2010 Received: (at 5475) by debbugs.gnu.org; 28 Jan 2010 22:00:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NacQ6-00024K-SZ for submit@debbugs.gnu.org; Thu, 28 Jan 2010 17:00:59 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NacQ4-000246-QQ for 5475@debbugs.gnu.org; Thu, 28 Jan 2010 17:00:57 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0KWZ0040091ITR00@a-mtaout20.012.net.il> for 5475@debbugs.gnu.org; Fri, 29 Jan 2010 00:00:12 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.127.180.161]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KWZ0025T94BEZ70@a-mtaout20.012.net.il>; Fri, 29 Jan 2010 00:00:12 +0200 (IST) Date: Fri, 29 Jan 2010 00:00:11 +0200 From: Eli Zaretskii Subject: Re: bug#5475: Archives with filenames with square brackets In-reply-to: X-012-Sender: halo1@inter.net.il To: Lennart Borgman Message-id: <83636lubys.fsf@gnu.org> References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com> <83ljfj4fje.fsf@gnu.org> <87r5pavvrm.fsf@stupidchicken.com> <838wbiszy7.fsf@gnu.org> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > From: Lennart Borgman > Date: Thu, 28 Jan 2010 22:24:50 +0100 > Cc: Chong Yidong , 5475@debbugs.gnu.org > > On Thu, Jan 28, 2010 at 10:05 PM, Eli Zaretskii wrote: > >> From: Chong Yidong > >> Cc: juri@jurta.org, 5475@debbugs.gnu.org > >> Date: Thu, 28 Jan 2010 15:07:09 -0500 > >> > >> Eli Zaretskii writes: > >> > >> >> Well, archive-zip-extract already branches for pkzip/unzip > >> > > >> > Yes, but it does that by a user option, not by some hidden knowledge. > >> > I won't mind introducing a similar option that would tell arc-mode to > >> > quote the file arguments. > >> > >> Right, but once the user tells arc-mode to use unzip, we can > >> automagically shell-quote the filename; there seems to be no reason not > >> to. > > > Excuse me, I did not follow this thread at all, but I get curious. > What does shell-quote have to do with the arc-mode library? Does it > use a shell at all? No, it doesn't use the shell. But "unzip" expands wildcards internally, so wildcard characters need to be quoted if a file includes them literally. > Now that 7-zip is available on GNU/Linux too wouldn't it be very good > to include support for it? Patches are always welcome. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 30 18:56:42 2010 Received: (at 5475) by debbugs.gnu.org; 30 Jan 2010 23:56:42 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NbNBB-0007Bw-OG for submit@debbugs.gnu.org; Sat, 30 Jan 2010 18:56:42 -0500 Received: from smtp-out4.starman.ee ([85.253.0.6] helo=mx2.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NbNB9-0007Bf-DX for 5475@debbugs.gnu.org; Sat, 30 Jan 2010 18:56:39 -0500 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.68.107.cable.starman.ee [82.131.68.107]) by mx2.starman.ee (Postfix) with ESMTP id 3CC033F40CF; Sun, 31 Jan 2010 01:56:30 +0200 (EET) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#5475: Archives with filenames with square brackets Organization: JURTA References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com> <83ljfj4fje.fsf@gnu.org> <87r5pavvrm.fsf@stupidchicken.com> <838wbiszy7.fsf@gnu.org> Date: Sun, 31 Jan 2010 00:59:12 +0200 In-Reply-To: <838wbiszy7.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 28 Jan 2010 23:05:04 +0200") Message-ID: <87y6jfcg8b.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org, Chong Yidong X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) >> >> Well, archive-zip-extract already branches for pkzip/unzip >> > >> > Yes, but it does that by a user option, not by some hidden knowledge. >> > I won't mind introducing a similar option that would tell arc-mode to >> > quote the file arguments. >> >> Right, but once the user tells arc-mode to use unzip, we can >> automagically shell-quote the filename; there seems to be no reason not >> to. > > If you want to glean the need for quoting from the value of > archive-zip-extract (i.e. its car being "unzip"), I'm fine with that > as well. But as your patch is written, it imposes that on any unzip > command, regardless of whether it was "unzip" or something else, like > p7zip, for example. That doesn't seem right to me. I don't understand how this was supposed to work at all? The default value of `archive-zip-extract' can be either "unzip" or "pkunzip" (depending on the presence of the executable in `exec-path'), but the function `archive-zip-extract' compares with the value "pkzip". So the pkzip/pkunzip branch is never executed. It seems the intention of the change revno#45347 (2002-05-19) was to compare with "pkunzip" instead of "pkzip", but I currently can't confirm that since I can't find pkunzip for GNU/Linux. -- Juri Linkov http://www.jurta.org/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 30 23:18:16 2010 Received: (at 5475) by debbugs.gnu.org; 31 Jan 2010 04:18:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NbRGJ-00047P-Ul for submit@debbugs.gnu.org; Sat, 30 Jan 2010 23:18:16 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NbRG5-00046n-PI for 5475@debbugs.gnu.org; Sat, 30 Jan 2010 23:18:14 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0KX300700FMSMP00@a-mtaout20.012.net.il> for 5475@debbugs.gnu.org; Sun, 31 Jan 2010 06:17:57 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.70.32.75]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KX3006A5FXWXC60@a-mtaout20.012.net.il>; Sun, 31 Jan 2010 06:17:57 +0200 (IST) Date: Sun, 31 Jan 2010 06:18:00 +0200 From: Eli Zaretskii Subject: Re: bug#5475: Archives with filenames with square brackets In-reply-to: <87y6jfcg8b.fsf@mail.jurta.org> X-012-Sender: halo1@inter.net.il To: Juri Linkov Message-id: <83d40qj4av.fsf@gnu.org> References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com> <83ljfj4fje.fsf@gnu.org> <87r5pavvrm.fsf@stupidchicken.com> <838wbiszy7.fsf@gnu.org> <87y6jfcg8b.fsf@mail.jurta.org> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > From: Juri Linkov > Cc: Chong Yidong , 5475@debbugs.gnu.org > Date: Sun, 31 Jan 2010 00:59:12 +0200 > > The default value of `archive-zip-extract' can be either "unzip" or > "pkunzip" (depending on the presence of the executable in `exec-path'), > but the function `archive-zip-extract' compares with the value "pkzip". > So the pkzip/pkunzip branch is never executed. > > It seems the intention of the change revno#45347 (2002-05-19) was > to compare with "pkunzip" instead of "pkzip" Right, looks like a bug. Btw, I looked into 7z, and it doesn't have the same problem as unzip. So we probably should only quote with unzip. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 31 05:59:28 2010 Received: (at 5475) by debbugs.gnu.org; 31 Jan 2010 10:59:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NbXWZ-0002nS-Bi for submit@debbugs.gnu.org; Sun, 31 Jan 2010 05:59:27 -0500 Received: from smtp-out3.starman.ee ([85.253.0.5] helo=mx1.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NbXWW-0002nH-Q6 for 5475@debbugs.gnu.org; Sun, 31 Jan 2010 05:59:25 -0500 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (62.65.210.88.cable.starman.ee [62.65.210.88]) by mx1.starman.ee (Postfix) with ESMTP id 7D8813F40BC; Sun, 31 Jan 2010 12:59:15 +0200 (EET) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#5475: Archives with filenames with square brackets Organization: JURTA References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com> <83ljfj4fje.fsf@gnu.org> <87r5pavvrm.fsf@stupidchicken.com> <838wbiszy7.fsf@gnu.org> <87y6jfcg8b.fsf@mail.jurta.org> <83d40qj4av.fsf@gnu.org> Date: Sun, 31 Jan 2010 12:56:19 +0200 In-Reply-To: <83d40qj4av.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 31 Jan 2010 06:18:00 +0200") Message-ID: <87aavua6gb.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) >> The default value of `archive-zip-extract' can be either "unzip" or >> "pkunzip" (depending on the presence of the executable in `exec-path'), >> but the function `archive-zip-extract' compares with the value "pkzip". >> So the pkzip/pkunzip branch is never executed. >> >> It seems the intention of the change revno#45347 (2002-05-19) was >> to compare with "pkunzip" instead of "pkzip" > > Right, looks like a bug. > > Btw, I looked into 7z, and it doesn't have the same problem as unzip. > So we probably should only quote with unzip. Does the following patch look right? At least, it fixes a bug, and after feature freeze we could add more data structures to defcustom to indicate whether the file name needs to be quoted. === modified file 'lisp/arc-mode.el' --- lisp/arc-mode.el 2010-01-28 20:06:36 +0000 +++ lisp/arc-mode.el 2010-01-31 10:55:14 +0000 @@ -1782,12 +1782,13 @@ (defun archive-zip-summarize () (apply 'vector (nreverse files)))) (defun archive-zip-extract (archive name) - (if (equal (car archive-zip-extract) "pkzip") - (archive-*-extract archive name archive-zip-extract) - ;; unzip expands wildcards in NAME, so we need to quote it. - ;; FIXME: Does pkzip need similar treatment? - (archive-extract-by-stdout archive (shell-quote-argument name) - archive-zip-extract))) + (if (equal (car archive-zip-extract) "unzip") + ;; unzip expands wildcards in NAME, so we need to quote it. + ;; FIXME: Does pkzip need similar treatment? + ;; (7z doesn't need to quote wildcards) + (archive-extract-by-stdout archive (shell-quote-argument name) + archive-zip-extract) + (archive-*-extract archive name archive-zip-extract))) (defun archive-zip-write-file-member (archive descr) (archive-*-write-file-member -- Juri Linkov http://www.jurta.org/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 31 13:04:36 2010 Received: (at 5475) by debbugs.gnu.org; 31 Jan 2010 18:04:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nbe9z-0001RP-VN for submit@debbugs.gnu.org; Sun, 31 Jan 2010 13:04:36 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nbe9w-0001RC-QD for 5475@debbugs.gnu.org; Sun, 31 Jan 2010 13:04:33 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KX400H00HX3BV00@a-mtaout22.012.net.il> for 5475@debbugs.gnu.org; Sun, 31 Jan 2010 20:04:06 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.70.32.75]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KX4006DHI6OOZP0@a-mtaout22.012.net.il>; Sun, 31 Jan 2010 20:04:05 +0200 (IST) Date: Sun, 31 Jan 2010 20:04:03 +0200 From: Eli Zaretskii Subject: Re: bug#5475: Archives with filenames with square brackets In-reply-to: <87aavua6gb.fsf@mail.jurta.org> X-012-Sender: halo1@inter.net.il To: Juri Linkov Message-id: <838wbei224.fsf@gnu.org> References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com> <83ljfj4fje.fsf@gnu.org> <87r5pavvrm.fsf@stupidchicken.com> <838wbiszy7.fsf@gnu.org> <87y6jfcg8b.fsf@mail.jurta.org> <83d40qj4av.fsf@gnu.org> <87aavua6gb.fsf@mail.jurta.org> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > From: Juri Linkov > Cc: cyd@stupidchicken.com, 5475@debbugs.gnu.org > Date: Sun, 31 Jan 2010 12:56:19 +0200 > > >> The default value of `archive-zip-extract' can be either "unzip" or > >> "pkunzip" (depending on the presence of the executable in `exec-path'), > >> but the function `archive-zip-extract' compares with the value "pkzip". > >> So the pkzip/pkunzip branch is never executed. > >> > >> It seems the intention of the change revno#45347 (2002-05-19) was > >> to compare with "pkunzip" instead of "pkzip" > > > > Right, looks like a bug. > > > > Btw, I looked into 7z, and it doesn't have the same problem as unzip. > > So we probably should only quote with unzip. > > Does the following patch look right? At least, it fixes a bug, and > after feature freeze we could add more data structures to defcustom to > indicate whether the file name needs to be quoted. Looks okay to me, except that perhaps compare strings case-insensitively instead of just with `equal'. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 31 17:06:08 2010 Received: (at 5475) by debbugs.gnu.org; 31 Jan 2010 22:06:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nbhvk-000570-0U for submit@debbugs.gnu.org; Sun, 31 Jan 2010 17:06:08 -0500 Received: from smtp-out4.starman.ee ([85.253.0.6] helo=mx2.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nbhvi-00056r-VK for 5475@debbugs.gnu.org; Sun, 31 Jan 2010 17:06:07 -0500 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.55.214.cable.starman.ee [82.131.55.214]) by mx2.starman.ee (Postfix) with ESMTP id 002833F4071; Mon, 1 Feb 2010 00:05:55 +0200 (EET) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#5475: Archives with filenames with square brackets Organization: JURTA References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com> <83ljfj4fje.fsf@gnu.org> <87r5pavvrm.fsf@stupidchicken.com> <838wbiszy7.fsf@gnu.org> <87y6jfcg8b.fsf@mail.jurta.org> <83d40qj4av.fsf@gnu.org> <87aavua6gb.fsf@mail.jurta.org> <838wbei224.fsf@gnu.org> Date: Sun, 31 Jan 2010 23:59:40 +0200 In-Reply-To: <838wbei224.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 31 Jan 2010 20:04:03 +0200") Message-ID: <87zl3uorzn.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) >> > Right, looks like a bug. >> > >> > Btw, I looked into 7z, and it doesn't have the same problem as unzip. >> > So we probably should only quote with unzip. >> >> Does the following patch look right? At least, it fixes a bug, and >> after feature freeze we could add more data structures to defcustom to >> indicate whether the file name needs to be quoted. > > Looks okay to me, except that perhaps compare strings > case-insensitively instead of just with `equal'. There are more problems. When I try to set `archive-zip-extract' to ("7z" "x" "-so") it puts some unnecessary information (header lines, progress indication, etc.) to the output buffer, because it outputs this to stderr. With the following change, stderr goes to /dev/null, but there is no chance to see possible errors (this patch is for demonstration only, not to be installed): === modified file 'lisp/arc-mode.el' --- lisp/arc-mode.el 2010-01-28 20:06:36 +0000 +++ lisp/arc-mode.el 2010-01-31 21:48:51 +0000 @@ -1080,7 +1080,7 @@ (defun archive-extract-by-stdout (archiv (apply 'call-process (car command) nil - t + '(t nil) nil (append (cdr command) (list archive name)))) To process 7z in the correct branch, the following patch is needed, where any values other than pkunzip/pkzip are processed by archive-extract-by-stdout instead of archive-*-extract, where "unzip" needs to quote its filenames. So I propose to install the following patch, and add more changes for 7z processing after feature freeze. === modified file 'lisp/arc-mode.el' --- lisp/arc-mode.el 2010-01-28 20:06:36 +0000 +++ lisp/arc-mode.el 2010-01-31 21:48:51 +0000 @@ -1782,12 +1782,17 @@ (defun archive-zip-summarize () (apply 'vector (nreverse files)))) (defun archive-zip-extract (archive name) - (if (equal (car archive-zip-extract) "pkzip") + (if (member-ignore-case (car archive-zip-extract) '("pkunzip" "pkzip")) (archive-*-extract archive name archive-zip-extract) ;; unzip expands wildcards in NAME, so we need to quote it. - ;; FIXME: Does pkzip need similar treatment? - (archive-extract-by-stdout archive (shell-quote-argument name) - archive-zip-extract))) + ;; FIXME: Does pkunzip need similar treatment? + ;; (7z doesn't need to quote wildcards) + (archive-extract-by-stdout + archive + (if (equal (car archive-zip-extract) "unzip") + (shell-quote-argument name) + name) + archive-zip-extract))) (defun archive-zip-write-file-member (archive descr) (archive-*-write-file-member -- Juri Linkov http://www.jurta.org/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 31 23:16:08 2010 Received: (at 5475) by debbugs.gnu.org; 1 Feb 2010 04:16:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nbnhn-00007H-9K for submit@debbugs.gnu.org; Sun, 31 Jan 2010 23:16:07 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nbnhk-00006o-8R for 5475@debbugs.gnu.org; Sun, 31 Jan 2010 23:16:04 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KX500H00AEYAC00@a-mtaout22.012.net.il> for 5475@debbugs.gnu.org; Mon, 01 Feb 2010 06:15:23 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.70.67.249]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KX500DO6AHM12I0@a-mtaout22.012.net.il>; Mon, 01 Feb 2010 06:15:23 +0200 (IST) Date: Mon, 01 Feb 2010 06:15:27 +0200 From: Eli Zaretskii Subject: Re: bug#5475: Archives with filenames with square brackets In-reply-to: <87zl3uorzn.fsf@mail.jurta.org> X-012-Sender: halo1@inter.net.il To: Juri Linkov Message-id: <83zl3th9r4.fsf@gnu.org> References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com> <83ljfj4fje.fsf@gnu.org> <87r5pavvrm.fsf@stupidchicken.com> <838wbiszy7.fsf@gnu.org> <87y6jfcg8b.fsf@mail.jurta.org> <83d40qj4av.fsf@gnu.org> <87aavua6gb.fsf@mail.jurta.org> <838wbei224.fsf@gnu.org> <87zl3uorzn.fsf@mail.jurta.org> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > From: Juri Linkov > Cc: cyd@stupidchicken.com, 5475@debbugs.gnu.org > Date: Sun, 31 Jan 2010 23:59:40 +0200 > > When I try to set `archive-zip-extract' to ("7z" "x" "-so") it puts some > unnecessary information (header lines, progress indication, etc.) to > the output buffer, because it outputs this to stderr. With the following > change, stderr goes to /dev/null, but there is no chance to see possible errors > (this patch is for demonstration only, not to be installed): > > === modified file 'lisp/arc-mode.el' > --- lisp/arc-mode.el 2010-01-28 20:06:36 +0000 > +++ lisp/arc-mode.el 2010-01-31 21:48:51 +0000 > @@ -1080,7 +1080,7 @@ (defun archive-extract-by-stdout (archiv > (apply 'call-process > (car command) > nil > - t > + '(t nil) > nil > (append (cdr command) (list archive name)))) > > To process 7z in the correct branch, the following patch is needed, > where any values other than pkunzip/pkzip are processed by > archive-extract-by-stdout instead of archive-*-extract, > where "unzip" needs to quote its filenames. > > So I propose to install the following patch, and add more > changes for 7z processing after feature freeze. Thanks. I'm not sure we need to support 7z, I just tried it to see if other unzip programs expand wildcards by default like "unzip" does. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 05:57:46 2010 Received: (at 5475) by debbugs.gnu.org; 1 Feb 2010 10:57:46 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NbtyU-0004s6-5o for submit@debbugs.gnu.org; Mon, 01 Feb 2010 05:57:46 -0500 Received: from smtp-out3.starman.ee ([85.253.0.5] helo=mx1.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NbtyS-0004s1-HU for 5475@debbugs.gnu.org; Mon, 01 Feb 2010 05:57:45 -0500 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.53.239.cable.starman.ee [82.131.53.239]) by mx1.starman.ee (Postfix) with ESMTP id A6F673F40AB; Mon, 1 Feb 2010 12:57:35 +0200 (EET) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#5475: Archives with filenames with square brackets Organization: JURTA References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com> <83ljfj4fje.fsf@gnu.org> <87r5pavvrm.fsf@stupidchicken.com> <838wbiszy7.fsf@gnu.org> <87y6jfcg8b.fsf@mail.jurta.org> <83d40qj4av.fsf@gnu.org> <87aavua6gb.fsf@mail.jurta.org> <838wbei224.fsf@gnu.org> <87zl3uorzn.fsf@mail.jurta.org> <83zl3th9r4.fsf@gnu.org> Date: Mon, 01 Feb 2010 12:34:47 +0200 In-Reply-To: <83zl3th9r4.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 01 Feb 2010 06:15:27 +0200") Message-ID: <87aavtw8fs.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) > Thanks. I'm not sure we need to support 7z, I just tried it to see if > other unzip programs expand wildcards by default like "unzip" does. Do you mean we don't need to support 7z in 23.2 or at all? Are there some problems with 7z that makes undesirable to support it (maybe, it is not free software, or has an unsuitable license?) Even though it's quite rarely used format, sometimes when I try to visit a 7z archive in Emacs, I see only binary data. At least, nowadays the need to visit a 7z archive arises more often than for obsolete formats like arc/lzh/zoo still supported by arc-mode.el. -- Juri Linkov http://www.jurta.org/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 06:48:50 2010 Received: (at 5475) by debbugs.gnu.org; 1 Feb 2010 11:48:50 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nbulu-0005V1-Fs for submit@debbugs.gnu.org; Mon, 01 Feb 2010 06:48:50 -0500 Received: from fg-out-1718.google.com ([72.14.220.157]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nbuls-0005Uu-3J for 5475@debbugs.gnu.org; Mon, 01 Feb 2010 06:48:48 -0500 Received: by fg-out-1718.google.com with SMTP id e12so354334fga.15 for <5475@debbugs.gnu.org>; Mon, 01 Feb 2010 03:48:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=AGL9T4sj/U1aXxNDcceacuwQLrjlSTJZyWiAbY8FLIw=; b=Cmn5DDFhmNFXKk19bN/Qh7bUHFGHNDKnzCq/qL9hz9xuQkhgM2gPCAOx8ZKBXp6IiA xqn2TZyTYgXmQBk4l23Ehkbox+4V/QXJ3R2h2rBNy1zsiCl2L5PGAUlYIa4R2P3Of5ck D7fjBcZKfF6m9c8Wr+u2Y/1kWXUpV4SqyxEeU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=h2NuvVTd+nt1jdD4MScW8k99gDosEvGcC8yLQUIo/aJfB6bsDpcKHi3CJyBzq/Cs8O 3cmPEtC3n7DKwZ88ZaOPP8k8rihvgCrHDSw2tMJEbPxs9+5PUdLlLuxFvC5WYBScL/y2 t8VzdsMNclf84cmTE3jZSXx4lNQg8T5E7d0xo= MIME-Version: 1.0 Received: by 10.239.187.208 with SMTP id m16mr353360hbh.152.1265024922122; Mon, 01 Feb 2010 03:48:42 -0800 (PST) In-Reply-To: <87aavtw8fs.fsf@mail.jurta.org> References: <874omakv2m.fsf@mail.jurta.org> <87r5pavvrm.fsf@stupidchicken.com> <838wbiszy7.fsf@gnu.org> <87y6jfcg8b.fsf@mail.jurta.org> <83d40qj4av.fsf@gnu.org> <87aavua6gb.fsf@mail.jurta.org> <838wbei224.fsf@gnu.org> <87zl3uorzn.fsf@mail.jurta.org> <83zl3th9r4.fsf@gnu.org> <87aavtw8fs.fsf@mail.jurta.org> From: Lennart Borgman Date: Mon, 1 Feb 2010 12:48:21 +0100 Message-ID: Subject: Re: bug#5475: Archives with filenames with square brackets To: Juri Linkov Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org, Eli Zaretskii , cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) On Mon, Feb 1, 2010 at 11:34 AM, Juri Linkov wrote: > > Even though it's quite rarely used format, sometimes when I try to visit > a 7z archive in Emacs, I see only binary data. =C2=A0At least, nowadays t= he > need to visit a 7z archive arises more often than for obsolete formats > like arc/lzh/zoo still supported by arc-mode.el. 7zip also supports most other compression formats, including password protection. When I first started using 7zip it was the only free software that did this. I am not sure whether there is something else now. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 10:43:07 2010 Received: (at 5475) by debbugs.gnu.org; 1 Feb 2010 15:43:07 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NbyQd-0000VB-NF for submit@debbugs.gnu.org; Mon, 01 Feb 2010 10:43:07 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NbyQc-0000Uj-4a for 5475@debbugs.gnu.org; Mon, 01 Feb 2010 10:43:06 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEAJiFZktFpaN9/2dsb2JhbACBM9kdhEUEilo X-IronPort-AV: E=Sophos;i="4.49,383,1262581200"; d="scan'208";a="55064144" Received: from 69-165-163-125.dsl.teksavvy.com (HELO pastel.home) ([69.165.163.125]) by ironport2-out.pppoe.ca with ESMTP; 01 Feb 2010 10:43:01 -0500 Received: by pastel.home (Postfix, from userid 20848) id 12B6E7F8A; Mon, 1 Feb 2010 10:43:01 -0500 (EST) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#5475: Archives with filenames with square brackets Message-ID: References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com> <83ljfj4fje.fsf@gnu.org> <87r5pavvrm.fsf@stupidchicken.com> <838wbiszy7.fsf@gnu.org> <87y6jfcg8b.fsf@mail.jurta.org> <83d40qj4av.fsf@gnu.org> <87aavua6gb.fsf@mail.jurta.org> <838wbei224.fsf@gnu.org> <87zl3uorzn.fsf@mail.jurta.org> <83zl3th9r4.fsf@gnu.org> <87aavtw8fs.fsf@mail.jurta.org> Date: Mon, 01 Feb 2010 10:43:01 -0500 In-Reply-To: <87aavtw8fs.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 01 Feb 2010 12:34:47 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org, Eli Zaretskii , cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) > Do you mean we don't need to support 7z in 23.2 or at all? > Are there some problems with 7z that makes undesirable to support it > (maybe, it is not free software, or has an unsuitable license?) AFAIK 7zip is Free Software, but adding 7z support would be a new feature, so we would probably be better off insalling it into the `pending' branch. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 14:50:16 2010 Received: (at 5475) by debbugs.gnu.org; 1 Feb 2010 19:50:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc2Hn-0003mv-OJ for submit@debbugs.gnu.org; Mon, 01 Feb 2010 14:50:15 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc2Hl-0003mf-7U for 5475@debbugs.gnu.org; Mon, 01 Feb 2010 14:50:14 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KX600800GSNRG00@a-mtaout22.012.net.il> for 5475@debbugs.gnu.org; Mon, 01 Feb 2010 21:49:09 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.70.67.249]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KX6009TEHPT4220@a-mtaout22.012.net.il>; Mon, 01 Feb 2010 21:49:06 +0200 (IST) Date: Mon, 01 Feb 2010 21:49:12 +0200 From: Eli Zaretskii Subject: Re: bug#5475: Archives with filenames with square brackets In-reply-to: <87aavtw8fs.fsf@mail.jurta.org> X-012-Sender: halo1@inter.net.il To: Juri Linkov Message-id: <83wrywhh3b.fsf@gnu.org> References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com> <83ljfj4fje.fsf@gnu.org> <87r5pavvrm.fsf@stupidchicken.com> <838wbiszy7.fsf@gnu.org> <87y6jfcg8b.fsf@mail.jurta.org> <83d40qj4av.fsf@gnu.org> <87aavua6gb.fsf@mail.jurta.org> <838wbei224.fsf@gnu.org> <87zl3uorzn.fsf@mail.jurta.org> <83zl3th9r4.fsf@gnu.org> <87aavtw8fs.fsf@mail.jurta.org> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > From: Juri Linkov > Cc: cyd@stupidchicken.com, 5475@debbugs.gnu.org > Date: Mon, 01 Feb 2010 12:34:47 +0200 > > > Thanks. I'm not sure we need to support 7z, I just tried it to see if > > other unzip programs expand wildcards by default like "unzip" does. > > Do you mean we don't need to support 7z in 23.2 or at all? At all, for .zip files. > Are there some problems with 7z that makes undesirable to support it > (maybe, it is not free software, or has an unsuitable license?) Its support for zip archives is sporadic at best. On one GNU/Linux system I tried it, it insisted that a .zip file format was unsupported, although its Windows version that was older unzipped it with no trouble at all. Go figure. And the fact that it doesn't have a switch to make it silent, and you need to throw away its stderr (which means you cannot display error messages) is yet another nuisance. > Even though it's quite rarely used format, sometimes when I try to visit > a 7z archive in Emacs, I see only binary data. At least, nowadays the > need to visit a 7z archive arises more often than for obsolete formats > like arc/lzh/zoo still supported by arc-mode.el. I have nothing against adding support for 7z archives, although that would be a new feature. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 16:23:28 2010 Received: (at 5475) by debbugs.gnu.org; 1 Feb 2010 21:23:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc3k0-0004tv-1N for submit@debbugs.gnu.org; Mon, 01 Feb 2010 16:23:28 -0500 Received: from rcsinet11.oracle.com ([148.87.113.123]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc3jx-0004ti-M2 for 5475@debbugs.gnu.org; Mon, 01 Feb 2010 16:23:26 -0500 Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rcsinet11.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id o11LNIOW030229 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 1 Feb 2010 21:23:19 GMT Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by rcsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o11DpM8q012977; Mon, 1 Feb 2010 21:23:16 GMT Received: from abhmt015.oracle.com by acsmt355.oracle.com with ESMTP id 4982671265059303; Mon, 01 Feb 2010 13:21:43 -0800 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 01 Feb 2010 13:21:42 -0800 From: "Drew Adams" To: "'Eli Zaretskii'" , "'Juri Linkov'" References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com><83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com><83ljfj4fje.fsf@gnu.org> <87r5pavvrm.fsf@stupidchicken.com><838wbiszy7.fsf@gnu.org> <87y6jfcg8b.fsf@mail.jurta.org><83d40qj4av.fsf@gnu.org> <87aavua6gb.fsf@mail.jurta.org><838wbei224.fsf@gnu.org> <87zl3uorzn.fsf@mail.jurta.org><83zl3th9r4.fsf@gnu.org> <87aavtw8fs.fsf@mail.jurta.org> <83wrywhh3b.fsf@gnu.org> Subject: RE: bug#5475: Archives with filenames with square brackets Date: Mon, 1 Feb 2010 13:21:42 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <83wrywhh3b.fsf@gnu.org> Thread-Index: AcqjeM3wyIjWyjzzTcGHFDu+hgxMgQACuEFA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: acsmt355.oracle.com [141.146.40.155] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090203.4B674646.00E8:SCFMA4539814,ss=1,fgs=0 X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) > > Do you mean we don't need to support 7z in 23.2 or at all? > > At all, for .zip files. ... > > Even though it's quite rarely used format... At least, > > nowadays the need to visit a 7z archive arises more often > > than for obsolete formats...still supported by arc-mode.el. > > I have nothing against adding support for 7z archives, although that > would be a new feature. I have no opinion about this or more generally about this bug. I just want to mention that my company, which is a large software company, asked _everyone_ a few months back to install 7zip and get rid of Winzip from our work computers. I believe the reason was to save money somehow. Just thought I'd mention it, in case it's relevant. If this experience is at all typical or becomes so, then more people could be using 7zip. (I have no idea how widespread its use is now or might become.) From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 16:53:45 2010 Received: (at 5475) by debbugs.gnu.org; 1 Feb 2010 21:53:45 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc4DJ-0005Gq-Bf for submit@debbugs.gnu.org; Mon, 01 Feb 2010 16:53:45 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc4DH-0005Gj-I9 for 5475@debbugs.gnu.org; Mon, 01 Feb 2010 16:53:44 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KX600E00NCMB000@a-mtaout22.012.net.il> for 5475@debbugs.gnu.org; Mon, 01 Feb 2010 23:52:25 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.70.67.249]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KX600AXVNFB69E0@a-mtaout22.012.net.il>; Mon, 01 Feb 2010 23:52:24 +0200 (IST) Date: Mon, 01 Feb 2010 23:52:29 +0200 From: Eli Zaretskii Subject: Re: bug#5475: Archives with filenames with square brackets In-reply-to: X-012-Sender: halo1@inter.net.il To: Drew Adams Message-id: <83pr4ohbdu.fsf@gnu.org> References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com> <83ljfj4fje.fsf@gnu.org> <87r5pavvrm.fsf@stupidchicken.com> <838wbiszy7.fsf@gnu.org> <87y6jfcg8b.fsf@mail.jurta.org> <83d40qj4av.fsf@gnu.org> <87aavua6gb.fsf@mail.jurta.org> <838wbei224.fsf@gnu.org> <87zl3uorzn.fsf@mail.jurta.org> <83zl3th9r4.fsf@gnu.org> <87aavtw8fs.fsf@mail.jurta.org> <83wrywhh3b.fsf@gnu.org> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 5475 Cc: juri@jurta.org, 5475@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > From: "Drew Adams" > Cc: <5475@debbugs.gnu.org>, > Date: Mon, 1 Feb 2010 13:21:42 -0800 > > I just want to mention that my company, which is a large software company, asked > _everyone_ a few months back to install 7zip and get rid of Winzip from our work > computers. I believe the reason was to save money somehow. We support "unzip", not WinZip. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 17:06:00 2010 Received: (at 5475) by debbugs.gnu.org; 1 Feb 2010 22:06:00 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc4PA-0005PS-1M for submit@debbugs.gnu.org; Mon, 01 Feb 2010 17:06:00 -0500 Received: from rcsinet11.oracle.com ([148.87.113.123]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc4P8-0005PL-A4 for 5475@debbugs.gnu.org; Mon, 01 Feb 2010 17:05:58 -0500 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet11.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id o11M5phj028327 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 1 Feb 2010 22:05:53 GMT Received: from acsmt354.oracle.com (acsmt354.oracle.com [141.146.40.154]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o11FwNaD029047; Mon, 1 Feb 2010 22:05:50 GMT Received: from abhmt001.oracle.com by acsmt354.oracle.com with ESMTP id 4642061265061892; Mon, 01 Feb 2010 14:04:52 -0800 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 01 Feb 2010 14:04:51 -0800 From: "Drew Adams" To: "'Eli Zaretskii'" References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com> <83ljfj4fje.fsf@gnu.org> <87r5pavvrm.fsf@stupidchicken.com> <838wbiszy7.fsf@gnu.org> <87y6jfcg8b.fsf@mail.jurta.org> <83d40qj4av.fsf@gnu.org> <87aavua6gb.fsf@mail.jurta.org> <838wbei224.fsf@gnu.org> <87zl3uorzn.fsf@mail.jurta.org> <83zl3th9r4.fsf@gnu.org> <87aavtw8fs.fsf@mail.jurta.org> <83wrywhh3b.fsf@gnu.org> <83pr4ohbdu.fsf@gnu.org> Subject: RE: bug#5475: Archives with filenames with square brackets Date: Mon, 1 Feb 2010 14:04:52 -0800 Message-ID: <20CDC9C3BC91434BB5A64B83B5802205@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <83pr4ohbdu.fsf@gnu.org> Thread-Index: AcqjiQTOvL0WHUYkSuGCqa9KbJRGDQAASY1A X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: acsmt354.oracle.com [141.146.40.154] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090201.4B67503F.00CA:SCFMA4539814,ss=1,fgs=0 X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 5475 Cc: juri@jurta.org, 5475@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) > > I just want to mention that my company, which is a large > > software company, asked _everyone_ a few months back to > > install 7zip and get rid of Winzip from our work > > computers. I believe the reason was to save money somehow. > > We support "unzip", not WinZip. My point was not about WinZip; it was about 7zip: it might be that more people will use 7zip than has been true in the past. That's all. HTH. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 17:41:52 2010 Received: (at 5475) by debbugs.gnu.org; 1 Feb 2010 22:41:52 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc4xs-0005ry-4Z for submit@debbugs.gnu.org; Mon, 01 Feb 2010 17:41:52 -0500 Received: from mail-fx0-f211.google.com ([209.85.220.211]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc4xo-0005ro-02 for 5475@debbugs.gnu.org; Mon, 01 Feb 2010 17:41:50 -0500 Received: by fxm3 with SMTP id 3so1522137fxm.39 for <5475@debbugs.gnu.org>; Mon, 01 Feb 2010 14:41:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=2m1q8yrDHWOSuRdIxfvBw3n75gWmZBjMcQi+AuhNHns=; b=CL+UpX2tpLuaDiwwIHktpgkiit2rpH3IGwXdV4r3KEp6iqn4g1FLnB01pdfIPOr1f0 eDvxFT17qMaC9usYyzWB+zUQjFWq0K3QxkqLmVh5mZ/amPo/dJxVa4vY7QadPb4jdGv+ EOH8fW9lqJMJ62H149MwLRLUljeBS5Ra9tMqg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=kpU6/u/3hBwZ+MUhTbcEtVAeEPepSteTLeIBGfrCcEkqbfPHWQ2WsjF3ejgPcI5E0O 6/Be2tPZhWx6FswnYVhDFXZis3viTR7LDasxjxfCW8zg0XV5RFW/2EnjZqOs/57SZflV Pksigj+30p19fJBC8KiasnJbwiNLKLMcfysW4= MIME-Version: 1.0 Received: by 10.239.189.76 with SMTP id s12mr544009hbh.111.1265064102804; Mon, 01 Feb 2010 14:41:42 -0800 (PST) In-Reply-To: <83wrywhh3b.fsf@gnu.org> References: <874omakv2m.fsf@mail.jurta.org> <838wbiszy7.fsf@gnu.org> <87y6jfcg8b.fsf@mail.jurta.org> <83d40qj4av.fsf@gnu.org> <87aavua6gb.fsf@mail.jurta.org> <838wbei224.fsf@gnu.org> <87zl3uorzn.fsf@mail.jurta.org> <83zl3th9r4.fsf@gnu.org> <87aavtw8fs.fsf@mail.jurta.org> <83wrywhh3b.fsf@gnu.org> From: Lennart Borgman Date: Mon, 1 Feb 2010 23:41:21 +0100 Message-ID: Subject: Re: bug#5475: Archives with filenames with square brackets To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 5475 Cc: Juri Linkov , 5475@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) On Mon, Feb 1, 2010 at 8:49 PM, Eli Zaretskii wrote: > >> Are there some problems with 7z that makes undesirable to support it >> (maybe, it is not free software, or has an unsuitable license?) > > Its support for zip archives is sporadic at best. =C2=A0On one GNU/Linux > system I tried it, it insisted that a .zip file format was > unsupported, although its Windows version that was older unzipped it > with no trouble at all. My impression of 7-zip and the author Igor Pavlov is very positive. Some years ago I followed the discussion in the support forum a bit. I found good reasoning from the author. And things got fixed. I would be surprised if the GNU/Linux support will not be very good too. > Go figure. =C2=A0And the fact that it doesn't have > a switch to make it silent, and you need to throw away its stderr > (which means you cannot display error messages) is yet another > nuisance. I think this is a kind of thing you can ask for on the support lists. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 17:50:08 2010 Received: (at 5475) by debbugs.gnu.org; 1 Feb 2010 22:50:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc55p-0006Ts-Ey for submit@debbugs.gnu.org; Mon, 01 Feb 2010 17:50:08 -0500 Received: from smtp-out4.starman.ee ([85.253.0.6] helo=mx2.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc55l-0006TP-Hr for 5475@debbugs.gnu.org; Mon, 01 Feb 2010 17:50:02 -0500 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.53.239.cable.starman.ee [82.131.53.239]) by mx2.starman.ee (Postfix) with ESMTP id 7E0CA3F40AA; Tue, 2 Feb 2010 00:49:51 +0200 (EET) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#5475: Archives with filenames with square brackets Organization: JURTA References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com> <83ljfj4fje.fsf@gnu.org> <87r5pavvrm.fsf@stupidchicken.com> <838wbiszy7.fsf@gnu.org> <87y6jfcg8b.fsf@mail.jurta.org> <83d40qj4av.fsf@gnu.org> <87aavua6gb.fsf@mail.jurta.org> <838wbei224.fsf@gnu.org> <87zl3uorzn.fsf@mail.jurta.org> <83zl3th9r4.fsf@gnu.org> <87aavtw8fs.fsf@mail.jurta.org> Date: Mon, 01 Feb 2010 23:55:35 +0200 In-Reply-To: (Stefan Monnier's message of "Mon, 01 Feb 2010 10:43:01 -0500") Message-ID: <87r5p4k4dk.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) > AFAIK 7zip is Free Software, but adding 7z support would be a new > feature, so we would probably be better off insalling it into the > `pending' branch. Below is minimal support for the 7z format for the `pending' branch. Fortunately, 7z provides so-called "technical" mode for the list command (-slt) that outputs file information in a simple fixed format, so we could rely on it. In `archive-7z-extract' stderr is thrown away because 7z doesn't have a switch to make it silent. === modified file 'lisp/arc-mode.el' --- lisp/arc-mode.el 2010-01-28 20:06:36 +0000 +++ lisp/arc-mode.el 2010-02-01 21:48:09 +0000 @@ -52,17 +52,17 @@ ;; ARCHIVE TYPES: Currently only the archives below are handled, but the ;; structure for handling just about anything is in place. ;; -;; Arc Lzh Zip Zoo Rar -;; ---------------------------------------- -;; View listing Intern Intern Intern Intern Y -;; Extract member Y Y Y Y Y -;; Save changed member Y Y Y Y N -;; Add new member N N N N N -;; Delete member Y Y Y Y N -;; Rename member Y Y N N N -;; Chmod - Y Y - N -;; Chown - Y - - N -;; Chgrp - Y - - N +;; Arc Lzh Zip Zoo Rar 7z +;; -------------------------------------------- +;; View listing Intern Intern Intern Intern Y Y +;; Extract member Y Y Y Y Y Y +;; Save changed member Y Y Y Y N N +;; Add new member N N N N N N +;; Delete member Y Y Y Y N N +;; Rename member Y Y N N N N +;; Chmod - Y Y - N N +;; Chown - Y - - N N +;; Chgrp - Y - - N N ;; ;; Special thanks to Bill Brodie for very useful tips ;; on the first released version of this package. @@ -315,6 +315,20 @@ (defcustom archive-zoo-write-file-member :inline t (string :format "%v"))) :group 'archive-zoo) +;; ------------------------------ +;; 7z archive configuration + +(defcustom archive-7z-extract + '("7z" "x" "-so") + "Program and its options to run in order to extract a 7z file member. +Extraction should happen to standard output. Archive and member name will +be added." + :type '(list (string :tag "Program") + (repeat :tag "Options" + :inline t + (string :format "%v"))) + :group 'archive-7z) + ;; ------------------------------------------------------------------------- ;;; Section: Variables @@ -732,6 +746,7 @@ (defun archive-find-type () ((and (looking-at "MZ") (re-search-forward "Rar!" (+ (point) 100000) t)) 'rar-exe) + ((looking-at "7z\274\257\047\034") '7z) (t (error "Buffer format not recognized"))))) ;; ------------------------------------------------------------------------- @@ -1084,6 +1099,14 @@ (defun archive-extract-by-stdout (archiv nil (append (cdr command) (list archive name)))) +(defun archive-extract-by-stdout-without-stderr (archive name command) + (apply 'call-process + (car command) + nil + '(t nil) + nil + (append (cdr command) (list archive name)))) + (defun archive-extract-other-window () "In archive mode, find this member in another window." (interactive) @@ -1995,7 +2023,57 @@ (defun archive-rar-exe-extract (archive (if tmpbuf (kill-buffer tmpbuf)) (delete-file tmpfile)))) +;; ------------------------------------------------------------------------- +;;; Section: 7z Archives + +(defun archive-7z-summarize () + (let ((maxname 10) + (maxsize 5) + (file buffer-file-name) + (files ())) + (with-temp-buffer + (call-process "7z" nil t nil "l" "-slt" file) + (goto-char (point-min)) + (re-search-forward "^-+\n") + (while (re-search-forward "^Path = \\(.*\\)\n" nil t) + (goto-char (match-end 0)) + (let ((name (match-string 1)) + (size (save-excursion + (and (re-search-forward "^Size = \\(.*\\)\n") + (match-string 1)))) + (time (save-excursion + (and (re-search-forward "^Modified = \\(.*\\)\n") + (match-string 1))))) + (if (> (length name) maxname) (setq maxname (length name))) + (if (> (length size) maxsize) (setq maxsize (length size))) + (push (vector name name nil nil time nil nil size) + files)))) + (setq files (nreverse files)) + (goto-char (point-min)) + (let* ((format (format " %%%ds %%s %%s" maxsize)) + (sep (format format (make-string maxsize ?-) "-------------------" "")) + (column (length sep))) + (insert (format format "Size " "Date Time " " Filename") "\n") + (insert sep (make-string maxname ?-) "\n") + (archive-summarize-files (mapcar (lambda (desc) + (let ((text + (format format + (aref desc 7) + (aref desc 4) + (aref desc 1)))) + (vector text + column + (length text)))) + files)) + (insert sep (make-string maxname ?-) "\n") + (apply 'vector files)))) + +(defun archive-7z-extract (archive name) + ;; Throw away stderr because 7z doesn't have a switch to make it silent. + (archive-extract-by-stdout-without-stderr + archive name archive-7z-extract)) +;; ------------------------------------------------------------------------- ;;; Section `ar' archives. ;; TODO: we currently only handle the basic format of ar archives, === modified file 'lisp/files.el' --- lisp/files.el 2010-01-27 03:36:36 +0000 +++ lisp/files.el 2010-02-01 21:45:39 +0000 @@ -2252,8 +2252,8 @@ (defvar auto-mode-alist ;; The list of archive file extensions should be in sync with ;; `auto-coding-alist' with `no-conversion' coding system. ("\\.\\(\ -arc\\|zip\\|lzh\\|lha\\|zoo\\|[jew]ar\\|xpi\\|rar\\|\ -ARC\\|ZIP\\|LZH\\|LHA\\|ZOO\\|[JEW]AR\\|XPI\\|RAR\\)\\'" . archive-mode) +arc\\|zip\\|lzh\\|lha\\|zoo\\|[jew]ar\\|xpi\\|rar\\|7z\\|\ +ARC\\|ZIP\\|LZH\\|LHA\\|ZOO\\|[JEW]AR\\|XPI\\|RAR\\|7Z\\)\\'" . archive-mode) ("\\.\\(sx[dmicw]\\|od[fgpst]\\|oxt\\)\\'" . archive-mode) ;OpenOffice.org ("\\.\\(deb\\|[oi]pk\\)\\'" . archive-mode) ; Debian/Opkg packages. ;; Mailer puts message to be edited in === modified file 'lisp/international/mule.el' --- lisp/international/mule.el 2010-01-13 08:35:10 +0000 +++ lisp/international/mule.el 2010-02-01 21:43:42 +0000 @@ -1626,8 +1626,8 @@ (defcustom auto-coding-alist ;; .exe and .EXE are added to support archive-mode looking at DOS ;; self-extracting exe archives. (purecopy '(("\\.\\(\ -arc\\|zip\\|lzh\\|lha\\|zoo\\|[jew]ar\\|xpi\\|rar\\|\ -ARC\\|ZIP\\|LZH\\|LHA\\|ZOO\\|[JEW]AR\\|XPI\\|RAR\\)\\'" +arc\\|zip\\|lzh\\|lha\\|zoo\\|[jew]ar\\|xpi\\|rar\\|7z\\|\ +ARC\\|ZIP\\|LZH\\|LHA\\|ZOO\\|[JEW]AR\\|XPI\\|RAR\\|7z\\)\\'" . no-conversion-multibyte) ("\\.\\(exe\\|EXE\\)\\'" . no-conversion) ("\\.\\(sx[dmicw]\\|odt\\|tar\\|tgz\\)\\'" . no-conversion) -- Juri Linkov http://www.jurta.org/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 17:50:12 2010 Received: (at 5475) by debbugs.gnu.org; 1 Feb 2010 22:50:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc55w-0006U5-Fo for submit@debbugs.gnu.org; Mon, 01 Feb 2010 17:50:12 -0500 Received: from smtp-out4.starman.ee ([85.253.0.6] helo=mx2.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc55m-0006TS-Kg for 5475@debbugs.gnu.org; Mon, 01 Feb 2010 17:50:10 -0500 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.53.239.cable.starman.ee [82.131.53.239]) by mx2.starman.ee (Postfix) with ESMTP id DA12C3F40BA; Tue, 2 Feb 2010 00:49:52 +0200 (EET) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#5475: Archives with filenames with square brackets Organization: JURTA References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com> <83ljfj4fje.fsf@gnu.org> <87r5pavvrm.fsf@stupidchicken.com> <838wbiszy7.fsf@gnu.org> <87y6jfcg8b.fsf@mail.jurta.org> <83d40qj4av.fsf@gnu.org> <87aavua6gb.fsf@mail.jurta.org> <838wbei224.fsf@gnu.org> <87zl3uorzn.fsf@mail.jurta.org> <83zl3th9r4.fsf@gnu.org> <87aavtw8fs.fsf@mail.jurta.org> <83wrywhh3b.fsf@gnu.org> Date: Tue, 02 Feb 2010 00:39:36 +0200 In-Reply-To: <83wrywhh3b.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 01 Feb 2010 21:49:12 +0200") Message-ID: <87eil4k2c7.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) >> Do you mean we don't need to support 7z in 23.2 or at all? > > At all, for .zip files. Ah, I see. So I installed only a fix for pkzip/pkunzip without mentioning 7z. -- Juri Linkov http://www.jurta.org/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 19:11:26 2010 Received: (at 5475) by debbugs.gnu.org; 2 Feb 2010 00:11:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc6MY-0007TT-6V for submit@debbugs.gnu.org; Mon, 01 Feb 2010 19:11:26 -0500 Received: from fg-out-1718.google.com ([72.14.220.155]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc6MU-0007TJ-PG for 5475@debbugs.gnu.org; Mon, 01 Feb 2010 19:11:25 -0500 Received: by fg-out-1718.google.com with SMTP id 16so53883fgg.15 for <5475@debbugs.gnu.org>; Mon, 01 Feb 2010 16:11:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=TWJlKeTmh25zblhfRpBnKsZuyFQPMhgmOm4PuE0OAGc=; b=V74Q2b/x3xhS2Qdw1FxZhiHMI7E25uiu2mW5PQb7Uk8645NR93EF35yY4e0P9jzXZQ Agb8NpoHPn4VNpN7zBc/hnxztCQJK4D/jqPJgZL1K6ZF6H3IvpUtlwfBYPa5a4ut/+88 1hOnGSDizVMXN4a9G5IVaWmUPRYs07aF+jlVg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=GH47D8wWY5qQNMn6FTFjunjQ4TlYApeLacrK8UNrgKmaSeLkkRSvYmEw/ANhoYOisq EcgeRSmcVQ2XB3cHqqeqsRR8yHYXDCSlh1+Zv+73A3SdlvnUdmQBY2qRRXR2bIavMA6j pvkR8slvpbkoTOQRHxYMu2cITqBRj4kh1Aisk= MIME-Version: 1.0 Received: by 10.239.131.10 with SMTP id 10mr710169hbl.68.1265069477155; Mon, 01 Feb 2010 16:11:17 -0800 (PST) In-Reply-To: References: <874omakv2m.fsf@mail.jurta.org> <87y6jfcg8b.fsf@mail.jurta.org> <83d40qj4av.fsf@gnu.org> <87aavua6gb.fsf@mail.jurta.org> <838wbei224.fsf@gnu.org> <87zl3uorzn.fsf@mail.jurta.org> <83zl3th9r4.fsf@gnu.org> <87aavtw8fs.fsf@mail.jurta.org> <83wrywhh3b.fsf@gnu.org> From: Lennart Borgman Date: Tue, 2 Feb 2010 01:10:57 +0100 Message-ID: Subject: Re: bug#5475: Archives with filenames with square brackets To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 5475 Cc: Juri Linkov , 5475@debbugs.gnu.org, cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) On Mon, Feb 1, 2010 at 11:41 PM, Lennart Borgman wrote: > >> And the fact that it doesn't have >> a switch to make it silent, and you need to throw away its stderr >> (which means you cannot display error messages) is yet another >> nuisance. > > > I think this is a kind of thing you can ask for on the support lists. There is already a feature request for this in the 7-zip tracker at sourceforge. Eli, if you could specify exactly what would be useful for Emacs then I could add it to the feature request. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 19:12:24 2010 Received: (at 5475) by debbugs.gnu.org; 2 Feb 2010 00:12:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc6NU-0007UH-Cx for submit@debbugs.gnu.org; Mon, 01 Feb 2010 19:12:24 -0500 Received: from mail-fx0-f211.google.com ([209.85.220.211]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc6NS-0007UA-NY for 5475@debbugs.gnu.org; Mon, 01 Feb 2010 19:12:23 -0500 Received: by fxm3 with SMTP id 3so1584063fxm.39 for <5475@debbugs.gnu.org>; Mon, 01 Feb 2010 16:12:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=Gt1im1OzrROiZ4HqSWFEJ84dhU99gbyoKnMTxXe98ZE=; b=Rfbr5Ac5uhrv4noYHXa9tSSeJqx6qU3CD4v8AHl3beLKa7FPdPXNYKQANxlOvjNwCT Eb5969HLJMH52LHiZLK+83wsKTEZRXu7FgTKsq5qPuHXVV3wLk7QWQ1Wx60JHbUX/dsP ZmXW2CtVJQ6eL7ArH/Gvmr2t1Uu4MIqfPBZpE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=U/0HeCwJAiMQpgeQgG1msMLlkBP4435KoRaWE1LpsWoCos8t6R9qRbOLYl2eKfE0P2 YykzGb2hs99FxGG5q2PXbXBl+So/8TfScW5IZCme0ybp8UOBliI1m/v52Tu8iixFb2ue Kll8b1z8kNGFXlOA3PPKpLLhpTXqrVLdnx36A= MIME-Version: 1.0 Received: by 10.239.188.84 with SMTP id o20mr598542hbh.81.1265069538122; Mon, 01 Feb 2010 16:12:18 -0800 (PST) In-Reply-To: <87r5p4k4dk.fsf@mail.jurta.org> References: <874omakv2m.fsf@mail.jurta.org> <87y6jfcg8b.fsf@mail.jurta.org> <83d40qj4av.fsf@gnu.org> <87aavua6gb.fsf@mail.jurta.org> <838wbei224.fsf@gnu.org> <87zl3uorzn.fsf@mail.jurta.org> <83zl3th9r4.fsf@gnu.org> <87aavtw8fs.fsf@mail.jurta.org> <87r5p4k4dk.fsf@mail.jurta.org> From: Lennart Borgman Date: Tue, 2 Feb 2010 01:11:58 +0100 Message-ID: Subject: Re: bug#5475: Archives with filenames with square brackets To: Juri Linkov Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) On Mon, Feb 1, 2010 at 10:55 PM, Juri Linkov wrote: >> AFAIK 7zip is Free Software, but adding 7z support would be a new >> feature, so we would probably be better off insalling it into the >> `pending' branch. > > Below is minimal support for the 7z format for the `pending' branch. I think it would be very useful (at least on w32) to allow 7-zip to handle all compressed libraries. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 19:54:53 2010 Received: (at 5475) by debbugs.gnu.org; 2 Feb 2010 00:54:53 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc72b-0007yn-5d for submit@debbugs.gnu.org; Mon, 01 Feb 2010 19:54:53 -0500 Received: from smtp-out4.starman.ee ([85.253.0.6] helo=mx2.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc72Z-0007yX-5E for 5475@debbugs.gnu.org; Mon, 01 Feb 2010 19:54:51 -0500 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.53.239.cable.starman.ee [82.131.53.239]) by mx2.starman.ee (Postfix) with ESMTP id 8C63B3F40A7; Tue, 2 Feb 2010 02:54:41 +0200 (EET) From: Juri Linkov To: Lennart Borgman Subject: Re: bug#5475: Archives with filenames with square brackets Organization: JURTA References: <874omakv2m.fsf@mail.jurta.org> <87y6jfcg8b.fsf@mail.jurta.org> <83d40qj4av.fsf@gnu.org> <87aavua6gb.fsf@mail.jurta.org> <838wbei224.fsf@gnu.org> <87zl3uorzn.fsf@mail.jurta.org> <83zl3th9r4.fsf@gnu.org> <87aavtw8fs.fsf@mail.jurta.org> <83wrywhh3b.fsf@gnu.org> Date: Tue, 02 Feb 2010 02:42:33 +0200 In-Reply-To: (Lennart Borgman's message of "Tue, 2 Feb 2010 01:10:57 +0100") Message-ID: <87y6jc5uyu.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org, Eli Zaretskii , cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) >>> And the fact that it doesn't have a switch to make it silent, and >>> you need to throw away its stderr (which means you cannot display >>> error messages) is yet another nuisance. >> >> I think this is a kind of thing you can ask for on the support lists. > > There is already a feature request for this in the 7-zip tracker at sou= rceforge. > > Eli, if you could specify exactly what would be useful for Emacs then > I could add it to the feature request. I can answer this question. All major file compressors except 7-zip have such an option. man bzip2: -q --quiet Suppress non-essential warning messages. Messages pertaining to I/O errors and other critical events will not be suppressed. man gzip: -q --quiet Suppress all warnings. man unzip: -q perform operations quietly (-qq =3D even quieter). Ordinarily unzi= p prints the names of the files it=E2=80=99s extracting or testing, t= he extraction methods, any file or zipfile comments that may be stored in the archive, and possibly a summary when finished with each archive. The -q[q] options suppress the printing of some or all of these messages. man unrar: -inul Disable all messages. (the latter switch name is quite ugly) There are many ignored requests to add such option to 7-zip: http://sourceforge.net/projects/sevenzip/forums/forum/45797/topic/3376726= ?message=3D7580176 http://sourceforge.net/projects/p7zip/forums/forum/383044/topic/1270756 http://bugs.gentoo.org/show_bug.cgi?id=3D135134 http://osdir.com/ml/debian-bugs-dist/2009-05/msg03287.html http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=3D6643529 If you want add a new request, please ask for -q --quiet at sourceforge. --=20 Juri Linkov http://www.jurta.org/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 19:54:53 2010 Received: (at 5475) by debbugs.gnu.org; 2 Feb 2010 00:54:53 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc72b-0007yq-Hm for submit@debbugs.gnu.org; Mon, 01 Feb 2010 19:54:53 -0500 Received: from smtp-out4.starman.ee ([85.253.0.6] helo=mx2.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc72a-0007ya-5p for 5475@debbugs.gnu.org; Mon, 01 Feb 2010 19:54:52 -0500 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.53.239.cable.starman.ee [82.131.53.239]) by mx2.starman.ee (Postfix) with ESMTP id 2958E3F40A8; Tue, 2 Feb 2010 02:54:42 +0200 (EET) From: Juri Linkov To: Lennart Borgman Subject: Re: bug#5475: Archives with filenames with square brackets Organization: JURTA References: <874omakv2m.fsf@mail.jurta.org> <87y6jfcg8b.fsf@mail.jurta.org> <83d40qj4av.fsf@gnu.org> <87aavua6gb.fsf@mail.jurta.org> <838wbei224.fsf@gnu.org> <87zl3uorzn.fsf@mail.jurta.org> <83zl3th9r4.fsf@gnu.org> <87aavtw8fs.fsf@mail.jurta.org> <87r5p4k4dk.fsf@mail.jurta.org> Date: Tue, 02 Feb 2010 02:46:06 +0200 In-Reply-To: (Lennart Borgman's message of "Tue, 2 Feb 2010 01:11:58 +0100") Message-ID: <87wryw4g8h.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) > I think it would be very useful (at least on w32) to allow 7-zip to > handle all compressed libraries. To handle all compressed libraries, we need a new option -q --quiet because we don't need unnecessary messages in stderr, but we can't ignore stderr because it may contain error messages. -- Juri Linkov http://www.jurta.org/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 20:31:28 2010 Received: (at 5475) by debbugs.gnu.org; 2 Feb 2010 01:31:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc7by-0008On-Db for submit@debbugs.gnu.org; Mon, 01 Feb 2010 20:31:28 -0500 Received: from mail-fx0-f219.google.com ([209.85.220.219]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nc7bk-0008OY-Mk for 5475@debbugs.gnu.org; Mon, 01 Feb 2010 20:31:25 -0500 Received: by fxm19 with SMTP id 19so62784fxm.5 for <5475@debbugs.gnu.org>; Mon, 01 Feb 2010 17:31:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=UF6yUYpAeHbdUiHno/GHkd/9C8cpqaL+XgIbbzHUZ20=; b=wOmy/n7NEX+WsOWZ8in1xDvzC4Yu4nalT6t2p9N5MgGZ79RvILu/VhIz+c5gHXSBNY g87E6EkQ1eK554kdU0D5yG+rvtEn4BCDJoSYgwCDXvOmexenTzbpU5qjwfBazuhX38a1 GenE/OzaDr5qkxa/YOj85g9ZnOV1PGJysbH9w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=brGawFQckjRPheOjTIPbmZRHp2+G1VzD0V84ecmAuRnuwChA5aiT20/J+sb09pysAq i87Aw2jJAn/tqZ1TBOgvyiEdozkSeB9q3vkPJB1ACsywYtIQnhxGy+MP4m2v+dI3ixSM xsqL27Pl/g3UFt6wKNzQijpH5TvPMB05yHj4Y= MIME-Version: 1.0 Received: by 10.239.185.6 with SMTP id a6mr782883hbh.31.1265074268275; Mon, 01 Feb 2010 17:31:08 -0800 (PST) In-Reply-To: <87y6jc5uyu.fsf@mail.jurta.org> References: <874omakv2m.fsf@mail.jurta.org> <87aavua6gb.fsf@mail.jurta.org> <838wbei224.fsf@gnu.org> <87zl3uorzn.fsf@mail.jurta.org> <83zl3th9r4.fsf@gnu.org> <87aavtw8fs.fsf@mail.jurta.org> <83wrywhh3b.fsf@gnu.org> <87y6jc5uyu.fsf@mail.jurta.org> From: Lennart Borgman Date: Tue, 2 Feb 2010 02:30:48 +0100 Message-ID: Subject: Re: bug#5475: Archives with filenames with square brackets To: Juri Linkov Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org, Eli Zaretskii , cyd@stupidchicken.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) On Tue, Feb 2, 2010 at 1:42 AM, Juri Linkov wrote: >>>> And the fact that it doesn't have a switch to make it silent, and >>>> you need to throw away its stderr (which means you cannot display >>>> error messages) is yet another nuisance. >>> >>> I think this is a kind of thing you can ask for on the support lists. >> >> There is already a feature request for this in the 7-zip tracker at sour= ceforge. >> >> Eli, if you could specify exactly what would be useful for Emacs then >> I could add it to the feature request. > > I can answer this question. =C2=A0All major file compressors except 7-zip > have such an option. > > man bzip2: > > =C2=A0 -q --quiet > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Suppress non-essential warning messages= . =C2=A0Messages pertaining > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0to I/O errors and other critical events= will not be suppressed. > > man gzip: > > =C2=A0 -q --quiet > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Suppress all warnings. > > If you want add a new request, please ask for -q --quiet at sourceforge. Which version, the bzip2 or the gzip? From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 23:04:49 2010 Received: (at 5475) by debbugs.gnu.org; 2 Feb 2010 04:04:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NcA0P-0001PN-1y for submit@debbugs.gnu.org; Mon, 01 Feb 2010 23:04:49 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NcA0N-0001PF-Ao for 5475@debbugs.gnu.org; Mon, 01 Feb 2010 23:04:48 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KX7005004LC4F00@a-mtaout22.012.net.il> for 5475@debbugs.gnu.org; Tue, 02 Feb 2010 06:03:37 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.70.67.249]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KX7001LH4M0WXB0@a-mtaout22.012.net.il>; Tue, 02 Feb 2010 06:03:37 +0200 (IST) Date: Tue, 02 Feb 2010 06:03:43 +0200 From: Eli Zaretskii Subject: Re: bug#5475: Archives with filenames with square brackets In-reply-to: <87r5p4k4dk.fsf@mail.jurta.org> X-012-Sender: halo1@inter.net.il To: Juri Linkov Message-id: <83ock8gu74.fsf@gnu.org> References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com> <83ljfj4fje.fsf@gnu.org> <87r5pavvrm.fsf@stupidchicken.com> <838wbiszy7.fsf@gnu.org> <87y6jfcg8b.fsf@mail.jurta.org> <83d40qj4av.fsf@gnu.org> <87aavua6gb.fsf@mail.jurta.org> <838wbei224.fsf@gnu.org> <87zl3uorzn.fsf@mail.jurta.org> <83zl3th9r4.fsf@gnu.org> <87aavtw8fs.fsf@mail.jurta.org> <87r5p4k4dk.fsf@mail.jurta.org> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > From: Juri Linkov > Date: Mon, 01 Feb 2010 23:55:35 +0200 > Cc: 5475@debbugs.gnu.org > > > AFAIK 7zip is Free Software, but adding 7z support would be a new > > feature, so we would probably be better off insalling it into the > > `pending' branch. > > Below is minimal support for the 7z format for the `pending' branch. Thanks. Please don't forget a NEWS entry. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 02 05:42:28 2010 Received: (at 5475) by debbugs.gnu.org; 2 Feb 2010 10:42:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NcGDD-0005FH-W7 for submit@debbugs.gnu.org; Tue, 02 Feb 2010 05:42:28 -0500 Received: from smtp-out4.starman.ee ([85.253.0.6] helo=mx2.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NcGDB-0005FC-AK for 5475@debbugs.gnu.org; Tue, 02 Feb 2010 05:42:26 -0500 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.99.225.cable.starman.ee [82.131.99.225]) by mx2.starman.ee (Postfix) with ESMTP id BA2013F40AB; Tue, 2 Feb 2010 12:42:15 +0200 (EET) From: Juri Linkov To: Lennart Borgman Subject: Re: bug#5475: Archives with filenames with square brackets Organization: JURTA References: <874omakv2m.fsf@mail.jurta.org> <87aavua6gb.fsf@mail.jurta.org> <838wbei224.fsf@gnu.org> <87zl3uorzn.fsf@mail.jurta.org> <83zl3th9r4.fsf@gnu.org> <87aavtw8fs.fsf@mail.jurta.org> <83wrywhh3b.fsf@gnu.org> <87y6jc5uyu.fsf@mail.jurta.org> Date: Tue, 02 Feb 2010 12:03:17 +0200 In-Reply-To: (Lennart Borgman's message of "Tue, 2 Feb 2010 02:30:48 +0100") Message-ID: <87k4uw2ae2.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) >> man bzip2: >> >> =A0 -q --quiet >> >> =A0 =A0 =A0 =A0 =A0Suppress non-essential warning messages. =A0Message= s pertaining >> =A0 =A0 =A0 =A0 =A0to I/O errors and other critical events will not be= suppressed. >> >> man gzip: >> >> =A0 -q --quiet >> =A0 =A0 =A0 =A0 =A0Suppress all warnings. >> >> If you want add a new request, please ask for -q --quiet at sourceforg= e. > > Which version, the bzip2 or the gzip? Whatever. The main point is that with -q --quiet it should output only critical error messages. --=20 Juri Linkov http://www.jurta.org/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 02 19:17:51 2010 Received: (at 5475) by debbugs.gnu.org; 3 Feb 2010 00:17:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NcSwJ-000677-J9 for submit@debbugs.gnu.org; Tue, 02 Feb 2010 19:17:51 -0500 Received: from mail-fx0-f219.google.com ([209.85.220.219]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NcSwH-00066y-UB for 5475@debbugs.gnu.org; Tue, 02 Feb 2010 19:17:50 -0500 Received: by fxm19 with SMTP id 19so201171fxm.5 for <5475@debbugs.gnu.org>; Tue, 02 Feb 2010 16:17:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=eyH1tykhsx9sy9TUk+iD1PZlHXAJdwH4SQmU+xGb46g=; b=T8rplefIywvm1KIEdS+A22jVw0k0tRbZlogKpUDl9MQ2GLjHINvZGRaAV2Tzf/Jut/ +45UlsZe9UY3S7VVQOSGeUj37+Aey2aKKxMMtqfjaC7NdpDB7sscHChZlSFOkbsXnfJm XrEhEcHRIEAlzdlyDKctvEaqQXl+OYuvbucy8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=WklKWAK9hWGIJjY3c4WNXQ8IGCoEx4b1ogcMmaxseI9Vw4YRlzPQJjAD/7Aj6kS46i laWtPsmWmdejdTWFoVO2hGaQdjMxNdZnRvaf5vqk1HwdfgEsVQbHl18bVX9W8JYDD4Vf B8Qv9IDRV9iEnBQsznGCqARMNqdupQA/ZaM4I= MIME-Version: 1.0 Received: by 10.239.187.209 with SMTP id m17mr434020hbh.148.1265156265164; Tue, 02 Feb 2010 16:17:45 -0800 (PST) In-Reply-To: <87k4uw2ae2.fsf@mail.jurta.org> References: <874omakv2m.fsf@mail.jurta.org> <87zl3uorzn.fsf@mail.jurta.org> <83zl3th9r4.fsf@gnu.org> <87aavtw8fs.fsf@mail.jurta.org> <83wrywhh3b.fsf@gnu.org> <87y6jc5uyu.fsf@mail.jurta.org> <87k4uw2ae2.fsf@mail.jurta.org> From: Lennart Borgman Date: Wed, 3 Feb 2010 01:17:25 +0100 Message-ID: Subject: Re: bug#5475: Archives with filenames with square brackets To: Juri Linkov Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) On Tue, Feb 2, 2010 at 11:03 AM, Juri Linkov wrote: > > Whatever. =C2=A0The main point is that with -q --quiet it should output o= nly > critical error messages. I have added our comments to this feature request for 7-zip: https://sourceforge.net/tracker/index.php?func=3Ddetail&aid=3D2813266&group= _id=3D14481&atid=3D364481 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 02 19:37:09 2010 Received: (at 5475) by debbugs.gnu.org; 3 Feb 2010 00:37:09 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NcTEz-0006Jx-3C for submit@debbugs.gnu.org; Tue, 02 Feb 2010 19:37:09 -0500 Received: from smtp-out4.starman.ee ([85.253.0.6] helo=mx2.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NcTEw-0006Jb-Mp for 5475@debbugs.gnu.org; Tue, 02 Feb 2010 19:37:07 -0500 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.99.225.cable.starman.ee [82.131.99.225]) by mx2.starman.ee (Postfix) with ESMTP id 1F2D63F40A5; Wed, 3 Feb 2010 02:36:56 +0200 (EET) From: Juri Linkov To: Lennart Borgman Subject: Re: bug#5475: Archives with filenames with square brackets Organization: JURTA References: <874omakv2m.fsf@mail.jurta.org> <87zl3uorzn.fsf@mail.jurta.org> <83zl3th9r4.fsf@gnu.org> <87aavtw8fs.fsf@mail.jurta.org> <83wrywhh3b.fsf@gnu.org> <87y6jc5uyu.fsf@mail.jurta.org> <87k4uw2ae2.fsf@mail.jurta.org> Date: Wed, 03 Feb 2010 02:35:57 +0200 In-Reply-To: (Lennart Borgman's message of "Wed, 3 Feb 2010 01:17:25 +0100") Message-ID: <874olzyx3l.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) >> Whatever. =A0The main point is that with -q --quiet it should output o= nly >> critical error messages. > > I have added our comments to this feature request for 7-zip: > > https://sourceforge.net/tracker/index.php?func=3Ddetail&aid=3D2813266&g= roup_id=3D14481&atid=3D364481 Thanks. Until this option is implemented we should ignore stderr. --=20 Juri Linkov http://www.jurta.org/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 03 19:34:20 2010 Received: (at 5475) by debbugs.gnu.org; 4 Feb 2010 00:34:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ncpfl-0004Pj-SO for submit@debbugs.gnu.org; Wed, 03 Feb 2010 19:34:20 -0500 Received: from smtp-out4.starman.ee ([85.253.0.6] helo=mx2.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NcpfX-0004Ox-WD for 5475@debbugs.gnu.org; Wed, 03 Feb 2010 19:34:16 -0500 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.30.224.cable.starman.ee [82.131.30.224]) by mx2.starman.ee (Postfix) with ESMTP id 069AD3F4072; Thu, 4 Feb 2010 02:33:54 +0200 (EET) From: Juri Linkov To: Lennart Borgman Subject: Re: bug#5475: Archives with filenames with square brackets Organization: JURTA References: <874omakv2m.fsf@mail.jurta.org> <87zl3uorzn.fsf@mail.jurta.org> <83zl3th9r4.fsf@gnu.org> <87aavtw8fs.fsf@mail.jurta.org> <83wrywhh3b.fsf@gnu.org> <87y6jc5uyu.fsf@mail.jurta.org> <87k4uw2ae2.fsf@mail.jurta.org> <874olzyx3l.fsf@mail.jurta.org> Date: Thu, 04 Feb 2010 01:54:59 +0200 In-Reply-To: <874olzyx3l.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 03 Feb 2010 02:35:57 +0200") Message-ID: <873a1h52to.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 5475 Cc: 5475@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) > Until this option is implemented we should ignore stderr. Hmm, discarding stderr is too bad. Better would be to redirect stderr to a temporary file and display it when it contains error messages (a pending patch): === modified file 'lisp/arc-mode.el' --- lisp/arc-mode.el 2010-02-01 22:35:04 +0000 +++ lisp/arc-mode.el 2010-02-03 23:54:00 +0000 @@ -1076,11 +1099,11 @@ (defun archive-*-extract (archive name c (archive-delete-local tmpfile) success)) -(defun archive-extract-by-stdout (archive name command) +(defun archive-extract-by-stdout (archive name command &optional stderr-file) (apply 'call-process (car command) nil - t + (if stderr-file (list t stderr-file) t) nil (append (cdr command) (list archive name)))) @@ -1999,7 +2022,65 @@ (defun archive-rar-exe-extract (archive (if tmpbuf (kill-buffer tmpbuf)) (delete-file tmpfile)))) +(defun archive-7z-extract (archive name) + (let ((tmpfile (make-temp-file "7z-stderr"))) + ;; 7z doesn't provide a `quiet' option to suppress non-essential + ;; stderr messages. So redirect stderr to a temp file and display it + ;; in the echo area when it contains error messages. + (prog1 (archive-extract-by-stdout + archive name archive-7z-extract tmpfile) + (with-temp-buffer + (insert-file-contents tmpfile) + (unless (search-forward "Everything is Ok" nil t) + (message (buffer-string))) + (delete-file tmpfile))))) -- Juri Linkov http://www.jurta.org/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 18 19:14:40 2010 Received: (at 5475-done) by debbugs.gnu.org; 18 Apr 2010 23:14:40 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O3dhI-0000ST-C4 for submit@debbugs.gnu.org; Sun, 18 Apr 2010 19:14:40 -0400 Received: from smtp-out2.starman.ee ([85.253.0.4] helo=mx2.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O3dhG-0000SO-Js for 5475-done@debbugs.gnu.org; Sun, 18 Apr 2010 19:14:39 -0400 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.28.93.cable.starman.ee [82.131.28.93]) by mx2.starman.ee (Postfix) with ESMTP id 8CA413F4105 for <5475-done@debbugs.gnu.org>; Mon, 19 Apr 2010 02:14:32 +0300 (EEST) From: Juri Linkov To: 5475-done@debbugs.gnu.org Subject: Re: bug#5475: Archives with filenames with square brackets Organization: JURTA References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com> <83ljfj4fje.fsf@gnu.org> <87r5pavvrm.fsf@stupidchicken.com> <838wbiszy7.fsf@gnu.org> <87y6jfcg8b.fsf@mail.jurta.org> <83d40qj4av.fsf@gnu.org> <87aavua6gb.fsf@mail.jurta.org> <838wbei224.fsf@gnu.org> <87zl3uorzn.fsf@mail.jurta.org> <83zl3th9r4.fsf@gnu.org> <87aavtw8fs.fsf@mail.jurta.org> <87r5p4k4dk.fsf@mail.jurta.org> Date: Mon, 19 Apr 2010 02:14:03 +0300 In-Reply-To: <87r5p4k4dk.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 01 Feb 2010 23:55:35 +0200") Message-ID: <87k4s4l5fn.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.2 (--) X-Debbugs-Envelope-To: 5475-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) > Below is minimal support for the 7z format Patch installed to the trunk, bug closed. -- Juri Linkov http://www.jurta.org/emacs/ From unknown Sat Jun 21 03:24:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 17 May 2010 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator