GNU bug report logs - #54731
Please, revert part of dd0727e1ec1 related to Org mode (`encode-time')

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54731 in the body.
You can then email your comments to 54731 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Max Nikulin <manikulin <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Please, revert part of dd0727e1ec1 related to Org mode (`encode-time')
Date: Tue, 5 Apr 2022 23:43:35 +0700

Recently a bug with daylight saving time has been reported to the Org 
mode mail list:

https://list.orgmode.org/PAXPR06MB7760238F410CBE3203F78EE0C61E9 <at> PAXPR06MB7760.eurprd06.prod.outlook.com
Ignacio Casso. [BUG] org-agenda thinks timestamps after 23:00 correspond 
to the next day. Tue, 29 Mar 2022 15:09:10 +0200.

It can be reproduced only with the Org version bundled with Emacs-29. 
The code from the Org git repository works correctly. Due to Emacs 
commit dd0727e1ec1
   Paul Eggert Thu Dec 16 09:40:21 2021 -0800 encode-time simplifications
code of Org in the Emacs and the Org repositories diverged. Changes can 
not be just committed to Org since Org as a standalone package is 
compatible with Emacs-26 and even still with Emacs-25 where new style of 
`encode-time' arguments are not supported.

Moreover daylight saving time flag is ignored when timestamp components 
are passed as separate arguments and some Org code uses nil value (no 
DST) instead of -1 (ignore DST).

Even within Emacs both old and new calling styles of `encode-time' are 
used, so partial revert of the change does not reduce code consistency 
significantly enough.

On the Org side it is necessary to update at least the 
`org-parse-time-string' function and to introduce a compatibility 
wrapper that will use old calling convention when running under old 
Emacs versions. Such changes should finally land in the Emacs repository 
as well.

Please, revert changes from dd0727e1ec1 related to Org to fix the 
daylight saving time and to mitigate merge conflicts during porting of 
future fixes in Org.

Notice, this bug is namely for Emacs, not for Org mode as debbugs packages.

Message #8 received at 54731 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Max Nikulin <manikulin <at> gmail.com>, 54731 <at> debbugs.gnu.org
Cc: emacs-orgmode <at> gnu.org
Subject: Re: bug#54731: Please, revert part of dd0727e1ec1 related to Org mode
 (`encode-time')
Date: Tue, 5 Apr 2022 17:56:14 -0700

[Message part 1 (text/plain, inline)]

On 4/5/22 09:43, Max Nikulin wrote:

> Please, revert changes from dd0727e1ec1 related to Org to fix the 
> daylight saving time and to mitigate merge conflicts during porting of 
> future fixes in Org.

Thanks for mentioning the problem. I installed the attached, which I 
hope suffices.

This patch does keep two of the Org-related parts of dd0727e1ec1; these 
parts should work OK with Emacs 25 and so can be merged into Org before 
it starts assuming Emacs 27.

[0001-Port-Org-encode-time-usage-back-to-Emacs-25.patch (text/x-patch, attachment)]

Message #13 received at 54731 <at> debbugs.gnu.org (full text, mbox):

From: Max Nikulin <manikulin <at> gmail.com>
To: 54731 <at> debbugs.gnu.org
Subject: Re: bug#54731: Please, revert part of dd0727e1ec1 related to Org mode
 (`encode-time')
Date: Thu, 7 Apr 2022 00:05:43 +0700

On 06/04/2022 07:56, Paul Eggert wrote:
> On 4/5/22 09:43, Max Nikulin wrote:
> 
>> Please, revert changes from dd0727e1ec1 related to Org to fix the 
>> daylight saving time and to mitigate merge conflicts during porting of 
>> future fixes in Org.
> 
> Thanks for mentioning the problem. I installed the attached, which I 
> hope suffices.

Thank you, Paul. Now I see only a couple of differences with the Org 
bugfix branch related to time functions. I run Emacs from a system 
package, but I hope, Ignacio will confirm that there is no problem with 
the Emacs development version any more.

Message #16 received at 54731 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Max Nikulin <manikulin <at> gmail.com>
Cc: 54731 <at> debbugs.gnu.org
Subject: Re: bug#54731: Please, revert part of dd0727e1ec1 related to Org
 mode (`encode-time')
Date: Fri, 22 Apr 2022 13:45:56 +0200

Max Nikulin <manikulin <at> gmail.com> writes:

> Thank you, Paul. Now I see only a couple of differences with the Org
> bugfix branch related to time functions. I run Emacs from a system
> package, but I hope, Ignacio will confirm that there is no problem
> with the Emacs development version any more.

This was two weeks ago -- has Ignacio confirmed this?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #19 received at 54731 <at> debbugs.gnu.org (full text, mbox):

From: Max Nikulin <manikulin <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 54731 <at> debbugs.gnu.org
Subject: Re: bug#54731: Please, revert part of dd0727e1ec1 related to Org mode
 (`encode-time')
Date: Sat, 23 Apr 2022 15:05:29 +0700

On 22/04/2022 18:45, Lars Ingebrigtsen wrote:
> Max Nikulin writes:
> 
>> I run Emacs from a system
>> package, but I hope, Ignacio will confirm that there is no problem
>> with the Emacs development version any more.
> 
> This was two weeks ago -- has Ignacio confirmed this?

Yes, he has, see
https://list.orgmode.org/PAXPR06MB77601432D7227EC2A5884E3EC6F69 <at> PAXPR06MB7760.eurprd06.prod.outlook.com

I am sorry, Lars, I did not expect that (bug#54764) would cause so much 
activity, so I had to postpone this issue.

Message #22 received at 54731 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Max Nikulin <manikulin <at> gmail.com>
Cc: 54731 <at> debbugs.gnu.org
Subject: Re: bug#54731: Please, revert part of dd0727e1ec1 related to Org
 mode (`encode-time')
Date: Sat, 23 Apr 2022 14:32:07 +0200

Max Nikulin <manikulin <at> gmail.com> writes:

>>> I run Emacs from a system
>>> package, but I hope, Ignacio will confirm that there is no problem
>>> with the Emacs development version any more.
>> This was two weeks ago -- has Ignacio confirmed this?
>
> Yes, he has, see
> https://list.orgmode.org/PAXPR06MB77601432D7227EC2A5884E3EC6F69 <at> PAXPR06MB7760.eurprd06.prod.outlook.com
>
> I am sorry, Lars, I did not expect that (bug#54764) would cause so
> much activity, so I had to postpone this issue.

No problem.

So if I'm reading this bug thread correctly, the fix Paul pushed fixed
the reported issue, and I'm therefore closing this bug report.  If I
misunderstood, please respond to the debbugs address and we'll reopen.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.