Subject: Re: bug#54718: 28.0.92; rcirc channel-vs-log buffer confusion

From: Philip Kaludercic <[email-masked]>
Date: Fri, 14 Oct 2022 18:13:18 +0000

Philip Kaludercic <[email-masked]> writes:

> Philip Kaludercic <[email-masked]> writes:
>
>> Lars Ingebrigtsen <[email-masked]> writes:
>>
>>> Lars Ingebrigtsen <[email-masked]> writes:
>>>
>>>>> Could you try applying this patch to see if this improves the situation,
>>>>> or if some other issues arise:
>>>>
>>>> Ken, did you try Philip's patch?
>>>
>>> This was a month ago.  Philip, I think your patch looks "obviously
>>> correct", so feel free to push it.
>>
>> It appears the patch was not correct, as the function was used in a few
>> other spots.  One unintended side-effect was that logging creates a new
>> buffer for apparently every *received message*.
>
> Another idea might be to modify `rcirc-generate-log-filename' to add a
> ".log" to the end of each filename.

I have pushed a patch that does this, as there have been no objections.