GNU bug report logs - #54713
[PATCH] gnu: linux: Allow kconfig options to be strings

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: antlers <autumnalantlers <at> gmail.com>
Subject: bug#54713: closed (Re: bug#54713: [PATCH] gnu: linux: Allow
 kconfig options to be strings)
Date: Tue, 05 Apr 2022 18:20:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#54713: [PATCH] gnu: linux: Allow kconfig options to be strings

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 54713 <at> debbugs.gnu.org.

-- 
54713: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54713
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: antlers <autumnalantlers <at> gmail.com>
Cc: 54713-done <at> debbugs.gnu.org
Subject: Re: bug#54713: [PATCH] gnu: linux: Allow kconfig options to be strings
Date: Tue, 05 Apr 2022 20:18:38 +0200

Hi,

antlers <autumnalantlers <at> gmail.com> skribis:

> * gnu/packages/linux.scm (config->string): add a clause handling strings
>
> Allows for the declarative configuration of kconfig options which accept
> strings, such as CONFIG_MODULE_SIG_KEY.
>
> I've enclosed the given string in quotes, but don't do any kind of
> escaping. See the kernel mailing list for the current state of escaped
> strings upstream:
>
> https://patchwork.kernel.org/project/linux-kbuild/patch/1431003982-992-1-git-send-email-sr <at> denx.de/
>
> Apologies to those with double-quotes or backslashes in their
> CONFIG_SYSTEM_*_KEYS.

Applied.

If needed, a cheap and often “good enough” way to escape strings is
‘object->string’:

  (display (object->string "foo\"bar\"baz"))
  => "foo\"bar\"baz"

Would that help here?

Thanks,
Ludo’.

[Message part 3 (message/rfc822, inline)]

From: antlers <autumnalantlers <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: antlers <autumnalantlers <at> gmail.com>
Subject: [PATCH] gnu: linux: Allow kconfig options to be strings
Date: Mon,  4 Apr 2022 11:26:09 -0700

* gnu/packages/linux.scm (config->string): add a clause handling strings

Allows for the declarative configuration of kconfig options which accept
strings, such as CONFIG_MODULE_SIG_KEY.

I've enclosed the given string in quotes, but don't do any kind of
escaping. See the kernel mailing list for the current state of escaped
strings upstream:

https://patchwork.kernel.org/project/linux-kbuild/patch/1431003982-992-1-git-send-email-sr <at> denx.de/

Apologies to those with double-quotes or backslashes in their
CONFIG_SYSTEM_*_KEYS.

Signed-off-by: antlers <autumnalantlers <at> gmail.com>
---
 gnu/packages/linux.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index ec68f5c57e..9a81fc4a3d 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -767,7 +767,9 @@ (define (config->string options)
                       ((option . #t)
                        (string-append option "=y"))
                       ((option . #f)
-                       (string-append option "=n")))
+                       (string-append option "=n"))
+                      ((option . string)
+                       (string-append option "=\"" string "\"")))
                     options)
                "\n"))
 
-- 
2.34.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.