GNU bug report logs - #54706
28.0.92; eldoc-print-after-edit broken

Previous Next

To reply to this bug, email your comments to 54706 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.92; eldoc-print-after-edit broken
Date: Mon, 04 Apr 2022 19:13:50 +0800

I just noticed that eldoc not shown in 28.0.92 after messaging commands.
I have eldoc-print-after-edit set to t a long while ago and
`recenter-top-bottom' added to eldoc-message-commands. After some
digging it seems if doc is obtained async `C-l' can trigger eldoc no
more.

I have also noted that eldoc--request-state tries to capture the buffer
editing state using (buffer-modified-tick). Note this is not backward
compatible. Previously eldoc-message-commands can be any command.

Note also eldoc-print-after-edit is a misnomer. It should probably be
renamed to eldoc-print-after-command.

I can get back the old and tested behaviour by adding these 2 lines to
eldoc-print-current-symbol-info:

@@ -880,6 +884,8 @@
   (let (token)
     (cond (interactive
            (eldoc--invoke-strategy t))
+          ((eldoc--message-command-p last-command)
+           (eldoc--invoke-strategy nil))
           ((not (equal (setq token (eldoc--request-state))
                        eldoc--last-request-state))
            (let ((non-essential t))

Diff finished.  Mon Apr  4 18:58:29 2022

Message #8 received at 54706 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: 54706 <at> debbugs.gnu.org
Subject: Re: bug#54706: 28.0.92; eldoc-print-after-edit broken
Date: Mon, 04 Apr 2022 14:30:17 +0300

> From: Leo Liu <sdl.web <at> gmail.com>
> Date: Mon, 04 Apr 2022 19:13:50 +0800
> 
> 
> I just noticed that eldoc not shown in 28.0.92 after messaging commands.
> I have eldoc-print-after-edit set to t a long while ago and
> `recenter-top-bottom' added to eldoc-message-commands. After some
> digging it seems if doc is obtained async `C-l' can trigger eldoc no
> more.
> 
> I have also noted that eldoc--request-state tries to capture the buffer
> editing state using (buffer-modified-tick). Note this is not backward
> compatible. Previously eldoc-message-commands can be any command.

Can you please provide a simple test case for each of these issues?  I
don't think I understand clearly what you are saying (I'm only a
casual user of eldoc.)

Thanks.

Message #13 received at 54706 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Leo Liu <sdl.web <at> gmail.com>, 54706 <at> debbugs.gnu.org
Subject: Re: bug#54706: 28.0.92; eldoc-print-after-edit broken
Date: Thu, 05 May 2022 13:18:38 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

> Can you please provide a simple test case for each of these issues?  I
> don't think I understand clearly what you are saying (I'm only a
> casual user of eldoc.)

More information was requested, but no response was given within a
month, so I'm closing this bug report.  If the problem still exists,
please respond to this email and we'll reopen the bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #18 received at 54706 <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 54706 <at> debbugs.gnu.org
Subject: Re: bug#54706: 28.0.92; eldoc-print-after-edit broken
Date: Fri, 06 May 2022 12:44:52 +0800

On 2022-05-05 13:18 +0200, Lars Ingebrigtsen wrote:
> More information was requested, but no response was given within a
> month, so I'm closing this bug report.  If the problem still exists,
> please respond to this email and we'll reopen the bug report.

I think regression should be able to stay open a while longer ;)

Seriously, I have been trying to come back to this bug and I have it
bookmarked and have a test case in mind. We will fix it for 28.2.

Thanks,
Leo

Message #21 received at 54706 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: larsi <at> gnus.org, 54706 <at> debbugs.gnu.org
Subject: Re: bug#54706: 28.0.92; eldoc-print-after-edit broken
Date: Fri, 06 May 2022 08:58:22 +0300

reopen 54706
thanks

> From:  Leo Liu <sdl.web <at> gmail.com>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  54706 <at> debbugs.gnu.org
> Date: Fri, 06 May 2022 12:44:52 +0800
> 
> On 2022-05-05 13:18 +0200, Lars Ingebrigtsen wrote:
> > More information was requested, but no response was given within a
> > month, so I'm closing this bug report.  If the problem still exists,
> > please respond to this email and we'll reopen the bug report.
> 
> I think regression should be able to stay open a while longer ;)
> 
> Seriously, I have been trying to come back to this bug and I have it
> bookmarked and have a test case in mind. We will fix it for 28.2.

Thanks, I'm therefore reopening this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.