GNU bug report logs - #54702
29.0.50; ruby-mode indentation: endless methods

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#54702: closed (29.0.50; ruby-mode indentation: endless methods)
Date: Sun, 18 Dec 2022 12:07:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 18 Dec 2022 14:06:48 +0200
with message-id <925ca489-071d-1d9a-da9b-93b7a522ca63 <at> yandex.ru>
and subject line Re: bug#54702: 29.0.50; ruby-mode indentation: endless methods
has caused the debbugs.gnu.org bug report #54702,
regarding 29.0.50; ruby-mode indentation: endless methods
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
54702: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54702
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Aaron Jensen <aaronjensen <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; ruby-mode indentation: endless methods
Date: Sun, 03 Apr 2022 22:03:27 -0400

Ruby 3 and 3.1 bring us different versions of endless methods. They
currently don't indent correctly in `ruby-mode`:

Current:

```rb
class Bar
  def foo = bar

    def baz
    end
  end
```

Expected:

```rb
class Bar
  def foo = bar

  def baz
  end
end
```
In GNU Emacs 29.0.50 (build 1, aarch64-apple-darwin21.3.0, NS appkit-2113.30 Version 12.2.1 (Build 21D62))
 of 2022-03-04 built on aaron-m1.local
Windowing system distributor 'Apple', version 10.3.2113
System Description:  macOS 12.3.1

Configured using:
 'configure --disable-dependency-tracking --disable-silent-rules
 --enable-locallisppath=/opt/homebrew/share/emacs/site-lisp
 --infodir=/opt/homebrew/Cellar/emacs-plus <at> 29/29.0.50/share/info/emacs
 --prefix=/opt/homebrew/Cellar/emacs-plus <at> 29/29.0.50 --with-xml2
 --with-gnutls --with-native-compilation --without-dbus
 --without-imagemagick --with-modules --with-rsvg --with-ns
 --disable-ns-self-contained 'CFLAGS=-I/opt/homebrew/opt/gcc/include
 -I/opt/homebrew/opt/libgccjit/include -I/opt/homebrew/opt/gmp/include
 -I/opt/homebrew/opt/jpeg/include' 'LDFLAGS=-L/opt/homebrew/lib/gcc/11
 -I/opt/homebrew/opt/gcc/include -I/opt/homebrew/opt/libgccjit/include
 -I/opt/homebrew/opt/gmp/include -I/opt/homebrew/opt/jpeg/include''

Configured features:
ACL GIF GLIB GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP
NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS XIM ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

[Message part 3 (message/rfc822, inline)]

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 54702-done <at> debbugs.gnu.org, aaronjensen <at> gmail.com
Subject: Re: bug#54702: 29.0.50; ruby-mode indentation: endless methods
Date: Sun, 18 Dec 2022 14:06:48 +0200

Version: 29.1

On 16/12/2022 16:49, Eli Zaretskii wrote:
>> Date: Fri, 16 Dec 2022 14:40:24 +0200
>> From: Dmitry Gutov <dgutov <at> yandex.ru>
>> Cc: 54702 <at> debbugs.gnu.org, Aaron Jensen <aaronjensen <at> gmail.com>
>>
>> Hi Eli,
>>
>> On 16/12/2022 14:31, Dmitry Gutov wrote:
>>
>>> See the attached updated patch.
>>
>> What do you think about installing this on emacs-29?
>>
>> I want to treat this like a bugfix. It's fixing the lack of support for
>> a language feature that came out 2 years ago, but is apparently growing
>> in popularity now.
> 
> If you think this is safe enough, it's fine with me.

Thank you.

After some testing, I went with the v2 patch, further simplified.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.