From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 03 22:03:39 2022 Received: (at submit) by debbugs.gnu.org; 4 Apr 2022 02:03:39 +0000 Received: from localhost ([127.0.0.1]:49957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbC4A-0004lu-TL for submit@debbugs.gnu.org; Sun, 03 Apr 2022 22:03:39 -0400 Received: from lists.gnu.org ([209.51.188.17]:40638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbC49-0004ln-S9 for submit@debbugs.gnu.org; Sun, 03 Apr 2022 22:03:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbC49-0000iK-Mo for bug-gnu-emacs@gnu.org; Sun, 03 Apr 2022 22:03:37 -0400 Received: from [2607:f8b0:4864:20::733] (port=43612 helo=mail-qk1-x733.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nbC48-00008P-0G for bug-gnu-emacs@gnu.org; Sun, 03 Apr 2022 22:03:37 -0400 Received: by mail-qk1-x733.google.com with SMTP id p25so6569186qkj.10 for ; Sun, 03 Apr 2022 19:03:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version; bh=rYh/qPqkxmRtrE79dJoxz/Ff4TyKtowq4vuMyQqyV4E=; b=K1GWYZjkc/5ip8EUS+538v+opqnlPGh6J/I+dY6uR3rU3psXS3qIxzMqxKNjL/DX03 08Ksanr5EcQpKvWaNVsQMnqOxTkZgcnsOUF9Z8Di06eZOOm701JxI6XHMyl2bb1bVS1C pxBCxKatxm+dSbEYEZ8R7dy3Kr/mBPuvpy5JyRbvezle/BZLmbSeR5MWYtA652L5z6MU ff19hwRCNr/s0AV00Fk3u1J+fFwschmp1EAOwPn29oOCjBdSz7F7neBCmAs95b1QLnxp ajAkKVhPyuyZfLymer6UJWNac0C4adlz5VAhHq3QSLTEgN/2SazDQp+jhsTI9KzMlhxQ LtYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=rYh/qPqkxmRtrE79dJoxz/Ff4TyKtowq4vuMyQqyV4E=; b=mZBxDQF84uDbTKK1No/J9yvpvKJqNtmQWz+MG5+JDZXZwKNrthINodyKHoZWK0/HAz ajwOjW1hx8fQDdpuDP9Fe5YAZAguzSMVQBNqi4DT2/ZLluw72HVmQSlwXHCha6csNS5i 449uX/XbRKVWqRIB7Rg9eUMOORBwqVRZiHluCxixb4ZShXaQUTgsND+L2JsPX9Or6nC6 HyPUGo0am6f+HgY97TRNb2cFkosmRcPO5ivkB/FDBNGF5g/AYykh6nOV7s/9dQJkanQk CMP+f20m8MsF5scQpLORLBJF4UWTbcCsfBmOiGMqQBht8FGfe6I6VybDC9BiS1+JcJ4J dObw== X-Gm-Message-State: AOAM530DA6K+0UhrRLK1hmCFF1xXSOalmkstAqo/gjIiS34MrEccZqLC Zo5xUuV7QRRJIQA+3BifCrloBjt67EE= X-Google-Smtp-Source: ABdhPJxuplH4VhhKj0zMGXvgArEfhZFoPpdVdEx0ptgu96p+0n416ISuKc7z0kUU8RGY1FjaJ9U9yw== X-Received: by 2002:a05:620a:4309:b0:67b:3fc1:86eb with SMTP id u9-20020a05620a430900b0067b3fc186ebmr12637775qko.495.1649037814266; Sun, 03 Apr 2022 19:03:34 -0700 (PDT) Received: from aaron-m1.local (c-76-101-193-36.hsd1.fl.comcast.net. [76.101.193.36]) by smtp.gmail.com with ESMTPSA id j1-20020a05620a288100b0067b1be3201bsm5488747qkp.112.2022.04.03.19.03.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Apr 2022 19:03:33 -0700 (PDT) From: Aaron Jensen To: bug-gnu-emacs@gnu.org Subject: 29.0.50; ruby-mode indentation: endless methods Date: Sun, 03 Apr 2022 22:03:27 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::733 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::733; envelope-from=aaronjensen@gmail.com; helo=mail-qk1-x733.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Ruby 3 and 3.1 bring us different versions of endless methods. They currently don't indent correctly in `ruby-mode`: Current: ```rb class Bar def foo = bar def baz end end ``` Expected: ```rb class Bar def foo = bar def baz end end ``` In GNU Emacs 29.0.50 (build 1, aarch64-apple-darwin21.3.0, NS appkit-2113.30 Version 12.2.1 (Build 21D62)) of 2022-03-04 built on aaron-m1.local Windowing system distributor 'Apple', version 10.3.2113 System Description: macOS 12.3.1 Configured using: 'configure --disable-dependency-tracking --disable-silent-rules --enable-locallisppath=/opt/homebrew/share/emacs/site-lisp --infodir=/opt/homebrew/Cellar/emacs-plus@29/29.0.50/share/info/emacs --prefix=/opt/homebrew/Cellar/emacs-plus@29/29.0.50 --with-xml2 --with-gnutls --with-native-compilation --without-dbus --without-imagemagick --with-modules --with-rsvg --with-ns --disable-ns-self-contained 'CFLAGS=-I/opt/homebrew/opt/gcc/include -I/opt/homebrew/opt/libgccjit/include -I/opt/homebrew/opt/gmp/include -I/opt/homebrew/opt/jpeg/include' 'LDFLAGS=-L/opt/homebrew/lib/gcc/11 -I/opt/homebrew/opt/gcc/include -I/opt/homebrew/opt/libgccjit/include -I/opt/homebrew/opt/gmp/include -I/opt/homebrew/opt/jpeg/include'' Configured features: ACL GIF GLIB GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS XIM ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 26 22:44:48 2022 Received: (at 54702) by debbugs.gnu.org; 27 Apr 2022 02:44:48 +0000 Received: from localhost ([127.0.0.1]:40855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njXfb-0000xB-P8 for submit@debbugs.gnu.org; Tue, 26 Apr 2022 22:44:47 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:42790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njXfZ-0000wv-Ec for 54702@debbugs.gnu.org; Tue, 26 Apr 2022 22:44:45 -0400 Received: by mail-wr1-f52.google.com with SMTP id e24so558339wrc.9 for <54702@debbugs.gnu.org>; Tue, 26 Apr 2022 19:44:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=z9DXAroYG6bEd7P8Sk2WdqGz/JCK4sJFy2fD5N1Y7c8=; b=ATcuCwlx4W/lisGGszKLUbk+8zCr7XtseAVp4NJ3jg4k6R7rHgTWI/bcfArOEX4Jf+ hOrCcBW9dubIJVbDU//kkVeyfiTONeFhM/cX9ZWHr71JBgWkKiMvWBDQhT/x+c5LvqXt e8q1PlL3WGhU3ibB62hxZWjPn17hc1cBL8nM/OwgLL3IH7YmQ1c9KEcBwQc3/dJw7211 R8UzLt1Hvp+w6wznhtHpPWlGkTLNlr7FLQeqXQxkZ2XGWAftBe0MYq87TKMIy3KFWiOQ 1qfSkey+/m9PVbvNtpJoUeShhNeqyNbs7mSRqYY3VvyZvy0rJs+yPR3N/DbgPN7fqHUO rC8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=z9DXAroYG6bEd7P8Sk2WdqGz/JCK4sJFy2fD5N1Y7c8=; b=UVVaRMXhS7FaTqu4z2fgYHCBiEVnHx57fmJKPc4ZXiLAQCbOzL2WF037htFRqkKnFX 4aB1tbtKeYJuLvUsUdHANGb7EHtNdQ2hTCh6LtlvKggIYKDLvTpBJhOO2aRCzm8U4G/y nEMJcgSfATA8cGtUxqouMhLtW7gSMOkLX2ese3vAng+mYKU5iWACHeQGzryDsTcK9XWc kbI7Gy8WY2WqQ/QlMTzblshTIf75nEO+jBN2ljEMb2uZJE3+A2PyAksgJTmisjtc2wrF eyogMiLJXK5+O0VgxA9Z5gQy9a7J9m75yx4z18QJQo7JaYDEwQWUqKPhmldw1H3aVvRW Op1A== X-Gm-Message-State: AOAM5338FBmlE29APMjrn9Y5vUZ8anoUT0PcGZwxC6JI5XRAem/2bRc3 O7x+MqqX+Q1a+9Ac0Pglrq8= X-Google-Smtp-Source: ABdhPJzQ/uH8YzKzX/r5kfTxf0TZdE3dL1vuDpFkscLeF0kTIEIRO74NB6MLmufWv1853s4aOMiulA== X-Received: by 2002:a5d:434e:0:b0:207:a48e:a99a with SMTP id u14-20020a5d434e000000b00207a48ea99amr20225238wrr.250.1651027479348; Tue, 26 Apr 2022 19:44:39 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id a18-20020adffb92000000b00207a257d47asm12714163wrr.95.2022.04.26.19.44.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Apr 2022 19:44:38 -0700 (PDT) Message-ID: <2136fe2e-85dd-8a3f-dc7b-ee7a8389dc76@yandex.ru> Date: Wed, 27 Apr 2022 05:44:36 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: bug#54702: 29.0.50; ruby-mode indentation: endless methods Content-Language: en-US To: Aaron Jensen , 54702@debbugs.gnu.org References: From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 54702 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hi Aaron, On 04.04.2022 05:03, Aaron Jensen wrote: > > Ruby 3 and 3.1 bring us different versions of endless methods. They > currently don't indent correctly in `ruby-mode`: > > Current: > > ```rb > class Bar > def foo = bar > > def baz > end > end > ``` > > Expected: > > ```rb > class Bar > def foo = bar > > def baz > end > end > ``` Thanks for the report. I'll work on this further, but here's a quick-and-dirty patch to fix the indentation problems. diff --git a/lisp/progmodes/ruby-mode.el b/lisp/progmodes/ruby-mode.el index a197724634..3733603fb3 100644 --- a/lisp/progmodes/ruby-mode.el +++ b/lisp/progmodes/ruby-mode.el @@ -528,6 +528,9 @@ ruby-smie--forward-token (ruby-smie--forward-token)) ;Fully redundant. (t ";"))) ((equal tok "&.") ".") + ((and (equal tok "def") + (looking-at " *[a-zA-Z0-9_]* *\\(([^()]*)\\)? *=")) + "def=") (t tok))))))))) (defun ruby-smie--backward-token () @@ -575,6 +578,9 @@ ruby-smie--backward-token (ruby-smie--backward-token)) ;Fully redundant. (t ";"))) ((equal tok "&.") ".") + ((and (equal tok "def") + (looking-at "def *[a-zA-Z0-9_]* *\\(([^()]*)\\)? *=")) + "def=") (t tok))))))) (defun ruby-smie--indent-to-stmt () From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 27 19:59:02 2022 Received: (at 54702) by debbugs.gnu.org; 27 Apr 2022 23:59:02 +0000 Received: from localhost ([127.0.0.1]:44757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njrYk-00051S-2L for submit@debbugs.gnu.org; Wed, 27 Apr 2022 19:59:02 -0400 Received: from mail-pj1-f54.google.com ([209.85.216.54]:46933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njrYh-00050C-Ss for 54702@debbugs.gnu.org; Wed, 27 Apr 2022 19:59:00 -0400 Received: by mail-pj1-f54.google.com with SMTP id u6-20020a17090a1f0600b001d86bd69427so2949995pja.5 for <54702@debbugs.gnu.org>; Wed, 27 Apr 2022 16:58:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JlHHCgJywtOwv9WJEqmslsDv/10WD6T6OKt3+DpSu1Y=; b=eP53olZ+dXG/w77tNpxObiyvvAoifAjQHy0g8NKbVBHdUgBEDy1a2D4e6XE0rOfPAZ Zeq+qOC2YwxsRfi+VRE0moucjEbmEe2ijkR2YOYzuoZs1Oj/ESzWamdmeOrtGDsOHGvo 22RMWtORYu3ejx3BvW6ZHi1lil5wsCAxy8plSztVl2XVs7Vx3lXxU4NgXpdcEyDwNS/y pOWgGTlcahLWWkoz+ghkZB4oDpdKFqso2CR48qRKQVUoIhquPrl/6IgORoadO33BBSi9 2kuc0EG/9g5R8AvWX64lf8Ohn6ZeCyCHF91z5KlweSqx4CPfIjs+oTXIqIewys87wBLr 4s2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JlHHCgJywtOwv9WJEqmslsDv/10WD6T6OKt3+DpSu1Y=; b=u0wMHZwBWK5CeW8I4Zn6w5i55+g1cVfReN7pOZ2LbZdEGtEPvlT0zIQ+7rF0O1XBPJ aDNR86QjFku+j2X1ZzMCDyt4b08tu+p1HMfb6sgFLtZvmd1F7dEhe4ebDvSbbl//WVl3 0XmaIUMq74K6ib01CszuSaa50LkzWc5hjFZkzA3oY2izYcua00s81j1J2SuUmWZR1r9q yiSeHyFQhofEmMmAI178ZNi9FoxpusQ+7AAXxl/+c9yZnFAhE3I/MO6Rzv2eqGjl/yzo lNsu/hVsOtHYZRer5sJr0h/28WDSZ6k61YpurhJDOLnNbfLY1VhxRjOioIFfYdAbnQCG 4JXw== X-Gm-Message-State: AOAM531eaLPCxoYVPVaaX56itlAJTkM/epRQH6CpdnZmyOodCnmNkkOi zjrhoGZSlQ8rSE+IkckoN31N2Td4ofIyuV06bzI= X-Google-Smtp-Source: ABdhPJwH/0BgpA9Ka5zTOtOXSIJYaIfuNnXXGg2cST/Dpod6y8ih8Vfi0Noq7cHOfYSbznpI06dYN9iySCud6R2c4ZM= X-Received: by 2002:a17:90a:94c2:b0:1d9:3fbd:bbe1 with SMTP id j2-20020a17090a94c200b001d93fbdbbe1mr26459513pjw.59.1651103933621; Wed, 27 Apr 2022 16:58:53 -0700 (PDT) MIME-Version: 1.0 References: <2136fe2e-85dd-8a3f-dc7b-ee7a8389dc76@yandex.ru> In-Reply-To: <2136fe2e-85dd-8a3f-dc7b-ee7a8389dc76@yandex.ru> From: Aaron Jensen Date: Wed, 27 Apr 2022 19:58:42 -0400 Message-ID: Subject: Re: bug#54702: 29.0.50; ruby-mode indentation: endless methods To: Dmitry Gutov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54702 Cc: 54702@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Apr 26, 2022 at 10:44 PM Dmitry Gutov wrote: > Thanks for the report. > > I'll work on this further, but here's a quick-and-dirty patch to fix the > indentation problems. Great, thank you. I've since moved back to enh-ruby-mode and I was able to patch it to support this (though that project appears to be currently not accepting contributions). I'd probably use ruby-mode if it supported indenting long parameter/argument lists the way the non-smie version does, like this: def some_method( some_param, some_other_param ) I believe I've seen you imply concerns about enh-ruby-mode -- do you have any aside from the fact that it's not in core and it requires a ruby process? It's mostly worked well for me, but I don't know what I don't know. Thanks, Aaron From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 19:33:30 2022 Received: (at 54702) by debbugs.gnu.org; 16 Dec 2022 00:33:31 +0000 Received: from localhost ([127.0.0.1]:45844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5yfK-00069b-Ac for submit@debbugs.gnu.org; Thu, 15 Dec 2022 19:33:30 -0500 Received: from mail-wr1-f54.google.com ([209.85.221.54]:43779) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5yfG-00069L-CK for 54702@debbugs.gnu.org; Thu, 15 Dec 2022 19:33:29 -0500 Received: by mail-wr1-f54.google.com with SMTP id h12so1010708wrv.10 for <54702@debbugs.gnu.org>; Thu, 15 Dec 2022 16:33:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:sender:from:to:cc:subject :date:message-id:reply-to; bh=rSjmGGFTAQZgVVgL9X8WY9Z82pPeeTksCRBzmARDL7A=; b=ONNtRvLRc1lt9UATDEzTcralrF3S1QJCPsB+GA66CW6khSwrfHEX5nSkBsm5iayFkp yxVBBn7Uv7PCzApjanRE/e14rP5xMnckiD/bjmA3AniySc/0ZZ6fgcgG1BXHrFGtyQNc uoSzKLarvp6Eow2imsxSTwHyH8RRklTxqrYMRfaCv1QwpOwZTjUacCgCgbQVQcc13QVx Uo6BhgByBdZCyZiqby+TTtuTJ+uZsBi2Fqmzf8d+zb/CbsseOcaLPda5V+6L4J1EEh6z HAeuAlTDK2smmD2yAqo8jfAXHvPhlTD/bNkh/XEl32YGsNGsVhTf2Uvb7L7/b0+6t57Z t+mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=rSjmGGFTAQZgVVgL9X8WY9Z82pPeeTksCRBzmARDL7A=; b=U6IcgcIVNfEKuaYiDQwkYarm6DsqW0ANle0Qjo3ssfvz3DWGzGB8kWb+ShlcWz1qkU SCR/dKVZNWsLIjJJAncz3MYDy9p9bft+Tf/H32+DnF9KGJT6xhfvBsyJXEjmtTiFv5fi KeZkNyDKq3aSs2MTdU7KpRfo15ZX5ArzScRsGVqR7XGzAtpb0HoNb8DIBbFOtZvOEBDh d3o46jGegJBLjkj4/xZRz7D8GrmLqf/u1mcKpZY11xkDLJZloxDBm2EaxsYOTMMWGqNC bc8Ia8YyUdtAu4a679uB56v6fThijWi1yAAfzB4u9A+SAUg+4VikuceplX4EE6iiUxGa JH/A== X-Gm-Message-State: ANoB5pkUtA9lnJwkbR734G3EPswtVNJ2uxlnmjxxEPpAYkbVtJPqJ4Ur I1HzacmoALqueZMoXDh+WM8= X-Google-Smtp-Source: AA0mqf5e/VMKkxfRrdzjafLiWxxNWJqckGA/OMtMBORBq6m+Vryevwz0nhOTUq5bIdOOIPxuuDCPeQ== X-Received: by 2002:a5d:4c4b:0:b0:242:2390:15f with SMTP id n11-20020a5d4c4b000000b002422390015fmr20729838wrt.64.1671150800123; Thu, 15 Dec 2022 16:33:20 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id z1-20020a5d6541000000b00241f029e672sm704143wrv.107.2022.12.15.16.33.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Dec 2022 16:33:19 -0800 (PST) Content-Type: multipart/mixed; boundary="------------wMUXI2kQRDUdLy5IALW5xLPt" Message-ID: <0178ae56-21d9-55e9-68f6-b2e8e2a483ff@yandex.ru> Date: Fri, 16 Dec 2022 02:33:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#54702: 29.0.50; ruby-mode indentation: endless methods Content-Language: en-US To: Aaron Jensen References: <2136fe2e-85dd-8a3f-dc7b-ee7a8389dc76@yandex.ru> From: Dmitry Gutov In-Reply-To: X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 54702 Cc: 54702@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) This is a multi-part message in MIME format. --------------wMUXI2kQRDUdLy5IALW5xLPt Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Aaron, Sorry for the long pause. You said you're using something else, though, so it didn't seem urgent (and I've yet to encounter endless methods at $day_job, FWIW). On 28/04/2022 02:58, Aaron Jensen wrote: > On Tue, Apr 26, 2022 at 10:44 PM Dmitry Gutov wrote: >> Thanks for the report. >> >> I'll work on this further, but here's a quick-and-dirty patch to fix the >> indentation problems. > > Great, thank you. I've since moved back to enh-ruby-mode and I was > able to patch it to support this (though that project appears to be > currently not accepting contributions). Not a problem for me, but could you test the attached patch anyway? It seems to handle a bunch of different/complex cases fine without regressions, but it's always better with a second pair of eyes. > I'd probably use ruby-mode if > it supported indenting long parameter/argument lists the way the > non-smie version does, like this: > > def some_method( > some_param, > some_other_param > ) Now that the SMIE stuff is again in my short-term memory, it shouldn't be too hard. Just please file a separate bug report (slash feature request) with a precise example. Bonus points for linking to a relevant Rubocop rule, so that we can pick a better name for the new user option. I don't see the non-SMIE version indenting it like this -- it looks more like this instead (and only if I set ruby-deep-indent-paren to nil): def test2 ( asd, asd asd ) So let's start with a couple of good examples. > I believe I've seen you imply concerns about enh-ruby-mode -- do you > have any aside from the fact that it's not in core and it requires a > ruby process? It's mostly worked well for me, but I don't know what I > don't know. My main problem with it is the spotty maintenance like in this example: https://github.com/zenspider/enhanced-ruby-mode/issues/96 But it might work fine for many people. Especially those who don't use Robe. Some previous versions of it (probably by the previous maintainer) were really broken, so I just took up ruby-mode instead. I haven't tried using its latest versions much. --------------wMUXI2kQRDUdLy5IALW5xLPt Content-Type: text/x-patch; charset=UTF-8; name="ruby-endless-methods.diff" Content-Disposition: attachment; filename="ruby-endless-methods.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3J1YnktbW9kZS5lbCBiL2xpc3AvcHJvZ21v ZGVzL3J1YnktbW9kZS5lbAppbmRleCA0YWMyODlkNTI5Li40ZDRjYTYzNWE0IDEwMDY0NAot LS0gYS9saXNwL3Byb2dtb2Rlcy9ydWJ5LW1vZGUuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMv cnVieS1tb2RlLmVsCkBAIC0xMzQsNiArMTM0LDEyIEBAIHJ1Ynktc3ltYm9sLWNoYXJzCiAo ZGVmY29uc3QgcnVieS1zeW1ib2wtcmUgKGNvbmNhdCAiWyIgcnVieS1zeW1ib2wtY2hhcnMg Il0iKQogICAiUmVnZXhwIHRvIG1hdGNoIHN5bWJvbHMuIikKIAorKGRlZmNvbnN0IHJ1Ynkt ZW5kbGVzcy1tZXRob2QtaGVhZC1yZQorICAoZm9ybWF0ICIgKiVzK1s/IV0/ICpcXCgoW14o KV0qKVxcKT8gKj0iIHJ1Ynktc3ltYm9sLXJlKQorICAiUmVnZXhwIHRvIG1hdGNoIHRoZSBi ZWdpbm5pbmcgb2YgYW4gZW5kbGVzcyBtZXRob2QgZGVmaW5pdGlvbi4KKworSXQgc2hvdWxk IG1hdGNoIHRoZSBwYXJ0IGFmdGVyIFwiZGVmXCIgYW5kIHVudGlsIFwiPVwiLiIpCisKIChk ZWZ2YXIgcnVieS11c2Utc21pZSB0KQogKG1ha2Utb2Jzb2xldGUtdmFyaWFibGUgJ3J1Ynkt dXNlLXNtaWUgbmlsICIyOC4xIikKIApAQCAtMzUxLDcgKzM1Nyw4IEBAIHJ1Ynktc21pZS1n cmFtbWFyCiAgICAgICAgKGV4cCAgKGV4cDEpIChleHAgIiwiIGV4cCkgKGV4cCAiPSIgZXhw KQogICAgICAgICAgICAgIChpZCAiIEAgIiBleHApKQogICAgICAgIChleHAxIChleHAyKSAo ZXhwMiAiPyIgZXhwMSAiOiIgZXhwMSkpCi0gICAgICAgKGV4cDIgKGV4cDMpIChleHAzICIu IiBleHAzKSkKKyAgICAgICAoZXhwMiAoZXhwMykgKGV4cDMgIi4iIGV4cDMpCisgICAgICAg ICAgICAgKGV4cDMgImRlZj0iIGV4cDMpKQogICAgICAgIChleHAzICgiZGVmIiBpbnN0cyAi ZW5kIikKICAgICAgICAgICAgICAoImJlZ2luIiBpbnN0cy1yZXNjdWUtaW5zdHMgImVuZCIp CiAgICAgICAgICAgICAgKCJkbyIgaW5zdHMgImVuZCIpCkBAIC01MjgsNiArNTM1LDkgQEAg cnVieS1zbWllLS1mb3J3YXJkLXRva2VuCiAgICAgICAgICAgICAgIChydWJ5LXNtaWUtLWZv cndhcmQtdG9rZW4pKSA7RnVsbHkgcmVkdW5kYW50LgogICAgICAgICAgICAgICh0ICI7Iikp KQogICAgICAgICAgICAoKGVxdWFsIHRvayAiJi4iKSAiLiIpCisgICAgICAgICAgICgoYW5k IChlcXVhbCB0b2sgImRlZiIpCisgICAgICAgICAgICAgICAgIChsb29raW5nLWF0IHJ1Ynkt ZW5kbGVzcy1tZXRob2QtaGVhZC1yZSkpCisgICAgICAgICAgICAiZGVmPSIpCiAgICAgICAg ICAgICh0IHRvaykpKSkpKSkpKQogCiAoZGVmdW4gcnVieS1zbWllLS1iYWNrd2FyZC10b2tl biAoKQpAQCAtNTc1LDYgKzU4NSw5IEBAIHJ1Ynktc21pZS0tYmFja3dhcmQtdG9rZW4KICAg ICAgICAgICAgIChydWJ5LXNtaWUtLWJhY2t3YXJkLXRva2VuKSkgO0Z1bGx5IHJlZHVuZGFu dC4KICAgICAgICAgICAgKHQgIjsiKSkpCiAgICAgICAgICAoKGVxdWFsIHRvayAiJi4iKSAi LiIpCisgICAgICAgICAoKGFuZCAoZXF1YWwgdG9rICJkZWYiKQorICAgICAgICAgICAgICAg KGxvb2tpbmctYXQgKGNvbmNhdCAiZGVmIiBydWJ5LWVuZGxlc3MtbWV0aG9kLWhlYWQtcmUp KSkKKyAgICAgICAgICAiZGVmPSIpCiAgICAgICAgICAodCB0b2spKSkpKSkpCiAKIChkZWZ1 biBydWJ5LXNtaWUtLWluZGVudC10by1zdG10ICgpCkBAIC02NDEsOSArNjU0LDExIEBAIHJ1 Ynktc21pZS1ydWxlcwogICAgICAgICh1bmxlc3MgKG9yIChlb2xwKSAoZm9yd2FyZC1jb21t ZW50IDEpKQogICAgICAgICAgKGNvbnMgJ2NvbHVtbiAoY3VycmVudC1jb2x1bW4pKSkpKQog ICAgICgnKDpiZWZvcmUgLiAiIEAgIikKLSAgICAgKHNhdmUtZXhjdXJzaW9uCi0gICAgICAg KHNraXAtY2hhcnMtZm9yd2FyZCAiIFx0IikKLSAgICAgICAoY29ucyAnY29sdW1uIChjdXJy ZW50LWNvbHVtbikpKSkKKyAgICAgKGlmIChzbWllLXJ1bGUtcGFyZW50LXAgImRlZj0iKQor ICAgICAgICAgKHNtaWUtcnVsZS1wYXJlbnQpCisgICAgICAgKHNhdmUtZXhjdXJzaW9uCisg ICAgICAgICAoc2tpcC1jaGFycy1mb3J3YXJkICIgXHQiKQorICAgICAgICAgKGNvbnMgJ2Nv bHVtbiAoY3VycmVudC1jb2x1bW4pKSkpKQogICAgICgnKDpiZWZvcmUgLiAiZG8iKSAocnVi eS1zbWllLS1pbmRlbnQtdG8tc3RtdCkpCiAgICAgKCcoOmJlZm9yZSAuICIuIikKICAgICAg KGlmIChzbWllLXJ1bGUtc2libGluZy1wKQpAQCAtNjcyLDYgKzY4Nyw5IEBAIHJ1Ynktc21p ZS1ydWxlcwogICAgICAoYW5kIChzbWllLXJ1bGUtcGFyZW50LXAgIjsiIG5pbCkKICAgICAg ICAgICAoc21pZS1pbmRlbnQtLWhhbmdpbmctcCkKICAgICAgICAgICBydWJ5LWluZGVudC1s ZXZlbCkpCisgICAgKGAoOmJlZm9yZSAuICI9IikKKyAgICAgKGFuZCAoc21pZS1ydWxlLXBh cmVudC1wICIgQCAiKQorICAgICAgICAgIChzbWllLXJ1bGUtcGFyZW50IHJ1YnktaW5kZW50 LWxldmVsKSkpCiAgICAgKGAoOmFmdGVyIC4gLChvciAiPyIgIjoiKSkgcnVieS1pbmRlbnQt bGV2ZWwpCiAgICAgKGAoOmJlZm9yZSAuICwoZ3VhcmQgKG1lbXEgKGludGVybi1zb2Z0IHRv a2VuKSBydWJ5LWFsaWduYWJsZS1rZXl3b3JkcykpKQogICAgICAod2hlbiAobm90IChydWJ5 LS1hdC1pbmRlbnRhdGlvbi1wKSkKQEAgLTE2MzEsNyArMTY0OSw3IEBAIHJ1YnktYWRkLWxv Zy1jdXJyZW50LW1ldGhvZAogICAgICAgICAgICAgICAgICAgKHdoaWxlIChhbmQgKHJlLXNl YXJjaC1iYWNrd2FyZCBkZWZpbml0aW9uLXJlIG5pbCB0KQogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgKGlmIChpZiAoc3RyaW5nLWVxdWFsICJkZWYiIChtYXRjaC1zdHJpbmcg MSkpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDs7IFdlJ3JlIGlu c2lkZSBhIG1ldGhvZC4KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KGlmIChydWJ5LWJsb2NrLWNvbnRhaW5zLXBvaW50IHN0YXJ0KQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAoaWYgKHJ1YnktYmxvY2stY29udGFpbnMtcG9pbnQg KDEtIHN0YXJ0KSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHQKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA7OyBUcnkgdG8g bWF0Y2ggYSBtZXRob2Qgb25seSBvbmNlLgogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIChzZXRxIGRlZmluaXRpb24tcmUgbW9kdWxlLXJlKQpkaWZmIC0tZ2l0 IGEvdGVzdC9saXNwL3Byb2dtb2Rlcy9ydWJ5LW1vZGUtcmVzb3VyY2VzL3J1YnkucmIgYi90 ZXN0L2xpc3AvcHJvZ21vZGVzL3J1YnktbW9kZS1yZXNvdXJjZXMvcnVieS5yYgppbmRleCBm Mzk0ODkwNzFlLi5jYmViMzYyZWYwIDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvcHJvZ21vZGVz L3J1YnktbW9kZS1yZXNvdXJjZXMvcnVieS5yYgorKysgYi90ZXN0L2xpc3AvcHJvZ21vZGVz L3J1YnktbW9kZS1yZXNvdXJjZXMvcnVieS5yYgpAQCAtNTAwLDMgKzUwMCwyNiBAQCBkZWYg cmVzb2x2ZSgqKmFyZ3MpCiAKICAgbWVtYmVyLmNhbGwoKiphcmdzKQogZW5kCisKKyMgRW5k bGVzcyBtZXRob2RzLgorY2xhc3MgQmFyCisgIGRlZiBmb28oYWJjKSA9CisgICAgYmFyICsK KyAgICBiYXIKKyAgICAgIC5iYXoKKworICBkZWYgYmFyID0KKyAgICAxMjMgKworICAgIDQK KworICBkZWYgcmVxdWVzdF9wYXJhbXMgPSB7CisgICAgaGVhZGVyczogcmVxdWVzdF9oZWFk ZXJzLAorICAgIGJvZHk6IHJlcXVlc3RfYm9keQorICB9CitlbmQKKworCitjbGFzcyBGb28K KyAgZGVmIGZvbyguLi4pID0gegorICBkZWYgYmFyID0geQorZW5kCmRpZmYgLS1naXQgYS90 ZXN0L2xpc3AvcHJvZ21vZGVzL3J1YnktbW9kZS10ZXN0cy5lbCBiL3Rlc3QvbGlzcC9wcm9n bW9kZXMvcnVieS1tb2RlLXRlc3RzLmVsCmluZGV4IGU5MGE5ZTQwNzUuLjliZTAxZGM3OGYg MTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9wcm9nbW9kZXMvcnVieS1tb2RlLXRlc3RzLmVsCisr KyBiL3Rlc3QvbGlzcC9wcm9nbW9kZXMvcnVieS1tb2RlLXRlc3RzLmVsCkBAIC02MDUsNiAr NjA1LDE4IEBAIHJ1YnktYWRkLWxvZy1jdXJyZW50LW1ldGhvZC1hZnRlci1pbm5lci1jbGFz cy1vdXRzaWRlLW1ldGhvZHMtd2l0aC10ZXh0CiAgICAgKHNlYXJjaC1iYWNrd2FyZCAiRk9P IikKICAgICAoc2hvdWxkIChzdHJpbmc9IChydWJ5LWFkZC1sb2ctY3VycmVudC1tZXRob2Qp ICJNOjpDIikpKSkKIAorKGVydC1kZWZ0ZXN0IHJ1YnktYWRkLWxvZy1jdXJyZW50LW1ldGhv ZC1hZnRlci1lbmRsZXNzLW1ldGhvZCAoKQorICAocnVieS13aXRoLXRlbXAtYnVmZmVyIChy dWJ5LXRlc3Qtc3RyaW5nCisgICAgICAgICAgICAgICAgICAgICAgICAgICJtb2R1bGUgTQor ICAgICAgICAgICAgICAgICAgICAgICAgICB8ICBjbGFzcyBDCisgICAgICAgICAgICAgICAg ICAgICAgICAgIHwgICAgZGVmIGZvbyA9CisgICAgICAgICAgICAgICAgICAgICAgICAgIHwg ICAgICA0XworICAgICAgICAgICAgICAgICAgICAgICAgICB8ICBlbmQKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgfGVuZCIpCisgICAgKHNlYXJjaC1iYWNrd2FyZCAiXyIpCisgICAg KGRlbGV0ZS1jaGFyIDEpCisgICAgKHNob3VsZCAoc3RyaW5nPSAocnVieS1hZGQtbG9nLWN1 cnJlbnQtbWV0aG9kKSAiTTo6QyNmb28iKSkpKQorCiAoZGVmdmFyIHJ1YnktYmxvY2stdGVz dC1leGFtcGxlCiAgIChydWJ5LXRlc3Qtc3RyaW5nCiAgICAiY2xhc3MgQwo= --------------wMUXI2kQRDUdLy5IALW5xLPt-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 16 00:07:26 2022 Received: (at 54702) by debbugs.gnu.org; 16 Dec 2022 05:07:26 +0000 Received: from localhost ([127.0.0.1]:47005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p62wP-0003P7-RX for submit@debbugs.gnu.org; Fri, 16 Dec 2022 00:07:26 -0500 Received: from mail-pf1-f181.google.com ([209.85.210.181]:43869) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p62wO-0003P1-LX for 54702@debbugs.gnu.org; Fri, 16 Dec 2022 00:07:25 -0500 Received: by mail-pf1-f181.google.com with SMTP id n3so1026751pfq.10 for <54702@debbugs.gnu.org>; Thu, 15 Dec 2022 21:07:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BxE7piec0pi2O3Vwy7/L/27bwykcJYI34DrWsyV9j58=; b=ausOmOph54zscMbWYbdGdbrvWv7WJ7kx7K61rxAfumoQrEraaLS+iyvt9/VUNSdf6y 8TZ04C6W0BiFBYmlHvr4IM+wEkFBe5V7Dht3eBPf7wIorB90WFq0Rvgki+/DtBoAFD+e N2Ai9c50m8BPL5TUPGoffZl7jYmljpAprlv2oImMptofZtkZ8e4atubDUJvCbGfGvgMI DGhkpVvZuaJz/hqBHg5ZJu31Y6qGhRgd0OGz+OW/DBuWbNi7vCYUyRYkeDPZM+xEAKGc G8dEXXRtgNl5CZ8MaqqYv4kDpaMD49b6Wza9TWGr8r8Ddb9+LerB1+R46QqZ78/U+Lpg wHIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BxE7piec0pi2O3Vwy7/L/27bwykcJYI34DrWsyV9j58=; b=rhyK8QQ74fAuyuf8JQwJEN4pBRVwMO2B/zruKbdJSCQux8Fo4kW9IjSVK+jc2FFNLP ek17LsikCxMPdDuTvic/E0A3JKVdeEle1/fBoCKMwDCdNoUcJkHavg1lIZH/YPXFosB+ szwh/hV8XFx5NgHju4H24+8eIDxQ4hahVQb8iDRsEVbz7MM4BAGrK0utdlqzhU14Sjge IsxKbkfEbcdO8hbrKYtTBwT0Y8ZhbrWsO2W6tJjYYY2Kq9j0oQj6ovzcXTXfQ5gcqTwg SMim0jURsptr/4sX9Dn+82GzbUHMiaukMXbqe8FmANZwzYxCt3D1iG93VP2u/exK3X79 ZraA== X-Gm-Message-State: ANoB5pmRaMqW0AoLrSECSuvGJgW5cucZ8Z+AM51+PjI0l8ShjOU9O/JU 2CgxGY7CezdcsIIY3oZU1qP04y+KzFrjvL/AjoLV1v5jYB0Z9Q== X-Google-Smtp-Source: AA0mqf5M6VwRL7O19QGXHfMuQw5j+O8bQVGsDH9WiwwNW78PCUBvtUygjIKT7oQ/4C1g+9xVDdz9p+sf0ektZH6UuTw= X-Received: by 2002:a63:7111:0:b0:478:a6de:4d1b with SMTP id m17-20020a637111000000b00478a6de4d1bmr21346172pgc.95.1671167238496; Thu, 15 Dec 2022 21:07:18 -0800 (PST) MIME-Version: 1.0 References: <2136fe2e-85dd-8a3f-dc7b-ee7a8389dc76@yandex.ru> <0178ae56-21d9-55e9-68f6-b2e8e2a483ff@yandex.ru> In-Reply-To: <0178ae56-21d9-55e9-68f6-b2e8e2a483ff@yandex.ru> From: Aaron Jensen Date: Fri, 16 Dec 2022 00:07:07 -0500 Message-ID: Subject: Re: bug#54702: 29.0.50; ruby-mode indentation: endless methods To: Dmitry Gutov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54702 Cc: 54702@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Dec 15, 2022 at 7:33 PM Dmitry Gutov wrote: > > Hi Aaron, > > Sorry for the long pause. You said you're using something else, though, > so it didn't seem urgent (and I've yet to encounter endless methods at > $day_job, FWIW). Not a problem at all. Our project is very data heavy and we define lots of one line methods, so we have made good use of them. > Not a problem for me, but could you test the attached patch anyway? > > It seems to handle a bunch of different/complex cases fine without > regressions, but it's always better with a second pair of eyes. Sure. I tried a few things and the only problem I can find is that it does not handle endless module methods: def self.some_method = "some-value" (with or without the line break, it handles them as the unpatched version handles instance endless methods. > > I'd probably use ruby-mode if > > it supported indenting long parameter/argument lists the way the > > non-smie version does, like this: > > > > def some_method( > > some_param, > > some_other_param > > ) > > Now that the SMIE stuff is again in my short-term memory, it shouldn't > be too hard. Just please file a separate bug report (slash feature > request) with a precise example. Bonus points for linking to a relevant > Rubocop rule, so that we can pick a better name for the new user option. Sure thing, just sent one in: bug#60110 > I don't see the non-SMIE version indenting it like this -- it looks more > like this instead (and only if I set ruby-deep-indent-paren to nil): > > def test2 ( > asd, > asd > asd > ) > > So let's start with a couple of good examples. Yeah, this is what I see too. Not sure what I saw before. In any case, I sent a current/desired. > My main problem with it is the spotty maintenance like in this example: > https://github.com/zenspider/enhanced-ruby-mode/issues/96 > > But it might work fine for many people. Especially those who don't use Robe. > > Some previous versions of it (probably by the previous maintainer) were > really broken, so I just took up ruby-mode instead. I haven't tried > using its latest versions much. Copy that. It works well for me. My endless method patch has since been merged. Unrelated, but I'm excited about the prospect of a treesit mode for Ruby. Thanks again, Aaron From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 16 07:31:29 2022 Received: (at 54702) by debbugs.gnu.org; 16 Dec 2022 12:31:29 +0000 Received: from localhost ([127.0.0.1]:49001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p69s8-0002Oo-GC for submit@debbugs.gnu.org; Fri, 16 Dec 2022 07:31:28 -0500 Received: from mail-ed1-f48.google.com ([209.85.208.48]:44892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p69s6-0002Of-FC for 54702@debbugs.gnu.org; Fri, 16 Dec 2022 07:31:27 -0500 Received: by mail-ed1-f48.google.com with SMTP id d14so3366821edj.11 for <54702@debbugs.gnu.org>; Fri, 16 Dec 2022 04:31:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:sender:from:to:cc:subject :date:message-id:reply-to; bh=jx5Bg2x2AShhaDoz3OK1uGcgf40DuKDdzMd09KEKm4M=; b=eqRLnp3m2sE1hiQIw8PtjWry7wFFklBHoiOCvYQKnr2tfV0/ZTJQgUrOOROK2iWvpX RSWeHNhueC3NhRW8qZ3n7VyM6cFt/QVck9Yp9COjA0z6I8OKBkijDhKTQ1r4oQSaLgkS CtAy+uc0KHoTG5DL6vSw0JD13soo6owKVUkLexfAAa3cUVyjYRdulw08Byl04ZDzt8Vp GOVDULnpKqVqAzeQ/kba35raFaCFaVsbZYvBTXqF1q2FETAoH3cYUn1pislzayHD0ezd YtFC/wfK8L8fs0IN7FL8vo668440hce70olfNyKfI3obCXATbk7QIxf8i4Lte5nQ42VY 9ouQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=jx5Bg2x2AShhaDoz3OK1uGcgf40DuKDdzMd09KEKm4M=; b=1TNMl9fpAu3wK8LMkzUrl8yDUqtfGfBt2+EUpLyqq8ojadwEUOIym/oGV0dusKLSwB /BgDeY/JENJwo4Mav55cd6mG4l5Tj0oc0ZFP5b2ZffymfIu5l2190okstDDSpKGQtd5/ ylo8eMkFEnSPvobJ++vexi3LNQPpL7uGIGJiZFmegK8iLSDz2UlGjkswVbi/EeBhjwNM LlGF8gxBS/1XjRxOXcTNVB/j/lxhthPIEhW2Bz2YrGHY7t9QbXCL52Do7Sk3qnwYu8Zr /02N+ldAVIA8C7fb60VLNUZZkkV8pyrU6WA4KaeviOF4Z/0ebft6dKg/8qI0ZZ1uGAMy Hy9w== X-Gm-Message-State: ANoB5pkZVvkGEvaVHMK7xQHdNnP979rZA7MKkpUAS6bPfhWvCb66kfmC o93X8kdzrc4YPnYthjq0/bM= X-Google-Smtp-Source: AA0mqf5P0GSPAQ0msNaP6mt3GFUSqDxrbQaNkcI6BXhar6zakyy99JOrXwVYk2+73MbA772S9DdT1Q== X-Received: by 2002:a05:6402:2949:b0:460:ce2e:30ba with SMTP id ed9-20020a056402294900b00460ce2e30bamr26439186edb.10.1671193880139; Fri, 16 Dec 2022 04:31:20 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id da15-20020a056402176f00b004615f7495e0sm824900edb.8.2022.12.16.04.31.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Dec 2022 04:31:19 -0800 (PST) Content-Type: multipart/mixed; boundary="------------0vf04a750hbrpXwR60vBcsAP" Message-ID: Date: Fri, 16 Dec 2022 14:31:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#54702: 29.0.50; ruby-mode indentation: endless methods Content-Language: en-US To: Aaron Jensen References: <2136fe2e-85dd-8a3f-dc7b-ee7a8389dc76@yandex.ru> <0178ae56-21d9-55e9-68f6-b2e8e2a483ff@yandex.ru> From: Dmitry Gutov In-Reply-To: X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 54702 Cc: 54702@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) This is a multi-part message in MIME format. --------------0vf04a750hbrpXwR60vBcsAP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 16/12/2022 07:07, Aaron Jensen wrote: >> Not a problem for me, but could you test the attached patch anyway? >> >> It seems to handle a bunch of different/complex cases fine without >> regressions, but it's always better with a second pair of eyes. > > Sure. I tried a few things and the only problem I can find is that it > does not handle endless module methods: > > def self.some_method = > "some-value" > > (with or without the line break, it handles them as the unpatched > version handles instance endless methods. Right, thanks. See the attached updated patch. >>> I'd probably use ruby-mode if >>> it supported indenting long parameter/argument lists the way the >>> non-smie version does, like this: >>> >>> def some_method( >>> some_param, >>> some_other_param >>> ) >> >> Now that the SMIE stuff is again in my short-term memory, it shouldn't >> be too hard. Just please file a separate bug report (slash feature >> request) with a precise example. Bonus points for linking to a relevant >> Rubocop rule, so that we can pick a better name for the new user option. > > Sure thing, just sent one in: bug#60110 > >> I don't see the non-SMIE version indenting it like this -- it looks more >> like this instead (and only if I set ruby-deep-indent-paren to nil): >> >> def test2 ( >> asd, >> asd >> asd >> ) >> >> So let's start with a couple of good examples. > > Yeah, this is what I see too. Not sure what I saw before. In any case, > I sent a current/desired. Thanks! The implementation (on top of the patch here) looks trivial, the question is whether to add an option, or just change the behavior and treat it like a "fix". Let's continue there after closing this one. > Unrelated, but I'm excited about the prospect of a treesit mode for Ruby. Yeah, it looks promising, but let's see how it goes. And there is a certain barrier to compiling the tree-sitter stuff, so we'll probably need to maintain the current/pure version in parallel for a while. --------------0vf04a750hbrpXwR60vBcsAP Content-Type: text/x-patch; charset=UTF-8; name="ruby-endless-methods.diff" Content-Disposition: attachment; filename="ruby-endless-methods.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3J1YnktbW9kZS5lbCBiL2xpc3AvcHJvZ21v ZGVzL3J1YnktbW9kZS5lbAppbmRleCA0YWMyODlkNTI5Li5kMjBlNWU5YjUxIDEwMDY0NAot LS0gYS9saXNwL3Byb2dtb2Rlcy9ydWJ5LW1vZGUuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMv cnVieS1tb2RlLmVsCkBAIC0xMzQsNiArMTM0LDEyIEBAIHJ1Ynktc3ltYm9sLWNoYXJzCiAo ZGVmY29uc3QgcnVieS1zeW1ib2wtcmUgKGNvbmNhdCAiWyIgcnVieS1zeW1ib2wtY2hhcnMg Il0iKQogICAiUmVnZXhwIHRvIG1hdGNoIHN5bWJvbHMuIikKIAorKGRlZmNvbnN0IHJ1Ynkt ZW5kbGVzcy1tZXRob2QtaGVhZC1yZQorICAoZm9ybWF0ICIgKlxcKHNlbGZcXC5cXCk/JXMr Wz8hXT8gKlxcKChbXigpXSopXFwpPyAqPSIgcnVieS1zeW1ib2wtcmUpCisgICJSZWdleHAg dG8gbWF0Y2ggdGhlIGJlZ2lubmluZyBvZiBhbiBlbmRsZXNzIG1ldGhvZCBkZWZpbml0aW9u LgorCitJdCBzaG91bGQgbWF0Y2ggdGhlIHBhcnQgYWZ0ZXIgXCJkZWZcIiBhbmQgdW50aWwg XCI9XCIuIikKKwogKGRlZnZhciBydWJ5LXVzZS1zbWllIHQpCiAobWFrZS1vYnNvbGV0ZS12 YXJpYWJsZSAncnVieS11c2Utc21pZSBuaWwgIjI4LjEiKQogCkBAIC0zNTEsNyArMzU3LDgg QEAgcnVieS1zbWllLWdyYW1tYXIKICAgICAgICAoZXhwICAoZXhwMSkgKGV4cCAiLCIgZXhw KSAoZXhwICI9IiBleHApCiAgICAgICAgICAgICAgKGlkICIgQCAiIGV4cCkpCiAgICAgICAg KGV4cDEgKGV4cDIpIChleHAyICI/IiBleHAxICI6IiBleHAxKSkKLSAgICAgICAoZXhwMiAo ZXhwMykgKGV4cDMgIi4iIGV4cDMpKQorICAgICAgIChleHAyIChleHAzKSAoZXhwMyAiLiIg ZXhwMykKKyAgICAgICAgICAgICAoZXhwMyAiZGVmPSIgZXhwMykpCiAgICAgICAgKGV4cDMg KCJkZWYiIGluc3RzICJlbmQiKQogICAgICAgICAgICAgICgiYmVnaW4iIGluc3RzLXJlc2N1 ZS1pbnN0cyAiZW5kIikKICAgICAgICAgICAgICAoImRvIiBpbnN0cyAiZW5kIikKQEAgLTUy OCw2ICs1MzUsOSBAQCBydWJ5LXNtaWUtLWZvcndhcmQtdG9rZW4KICAgICAgICAgICAgICAg KHJ1Ynktc21pZS0tZm9yd2FyZC10b2tlbikpIDtGdWxseSByZWR1bmRhbnQuCiAgICAgICAg ICAgICAgKHQgIjsiKSkpCiAgICAgICAgICAgICgoZXF1YWwgdG9rICImLiIpICIuIikKKyAg ICAgICAgICAgKChhbmQgKGVxdWFsIHRvayAiZGVmIikKKyAgICAgICAgICAgICAgICAgKGxv b2tpbmctYXQgcnVieS1lbmRsZXNzLW1ldGhvZC1oZWFkLXJlKSkKKyAgICAgICAgICAgICJk ZWY9IikKICAgICAgICAgICAgKHQgdG9rKSkpKSkpKSkpCiAKIChkZWZ1biBydWJ5LXNtaWUt LWJhY2t3YXJkLXRva2VuICgpCkBAIC01NzUsNiArNTg1LDkgQEAgcnVieS1zbWllLS1iYWNr d2FyZC10b2tlbgogICAgICAgICAgICAgKHJ1Ynktc21pZS0tYmFja3dhcmQtdG9rZW4pKSA7 RnVsbHkgcmVkdW5kYW50LgogICAgICAgICAgICAodCAiOyIpKSkKICAgICAgICAgICgoZXF1 YWwgdG9rICImLiIpICIuIikKKyAgICAgICAgICgoYW5kIChlcXVhbCB0b2sgImRlZiIpCisg ICAgICAgICAgICAgICAobG9va2luZy1hdCAoY29uY2F0ICJkZWYiIHJ1YnktZW5kbGVzcy1t ZXRob2QtaGVhZC1yZSkpKQorICAgICAgICAgICJkZWY9IikKICAgICAgICAgICh0IHRvaykp KSkpKSkKIAogKGRlZnVuIHJ1Ynktc21pZS0taW5kZW50LXRvLXN0bXQgKCkKQEAgLTY0MSw5 ICs2NTQsMTEgQEAgcnVieS1zbWllLXJ1bGVzCiAgICAgICAgKHVubGVzcyAob3IgKGVvbHAp IChmb3J3YXJkLWNvbW1lbnQgMSkpCiAgICAgICAgICAoY29ucyAnY29sdW1uIChjdXJyZW50 LWNvbHVtbikpKSkpCiAgICAgKCcoOmJlZm9yZSAuICIgQCAiKQotICAgICAoc2F2ZS1leGN1 cnNpb24KLSAgICAgICAoc2tpcC1jaGFycy1mb3J3YXJkICIgXHQiKQotICAgICAgIChjb25z ICdjb2x1bW4gKGN1cnJlbnQtY29sdW1uKSkpKQorICAgICAoaWYgKHNtaWUtcnVsZS1wYXJl bnQtcCAiZGVmPSIpCisgICAgICAgICAoc21pZS1ydWxlLXBhcmVudCkKKyAgICAgICAoc2F2 ZS1leGN1cnNpb24KKyAgICAgICAgIChza2lwLWNoYXJzLWZvcndhcmQgIiBcdCIpCisgICAg ICAgICAoY29ucyAnY29sdW1uIChjdXJyZW50LWNvbHVtbikpKSkpCiAgICAgKCcoOmJlZm9y ZSAuICJkbyIpIChydWJ5LXNtaWUtLWluZGVudC10by1zdG10KSkKICAgICAoJyg6YmVmb3Jl IC4gIi4iKQogICAgICAoaWYgKHNtaWUtcnVsZS1zaWJsaW5nLXApCkBAIC02NzIsNiArNjg3 LDkgQEAgcnVieS1zbWllLXJ1bGVzCiAgICAgIChhbmQgKHNtaWUtcnVsZS1wYXJlbnQtcCAi OyIgbmlsKQogICAgICAgICAgIChzbWllLWluZGVudC0taGFuZ2luZy1wKQogICAgICAgICAg IHJ1YnktaW5kZW50LWxldmVsKSkKKyAgICAoYCg6YmVmb3JlIC4gIj0iKQorICAgICAoYW5k IChzbWllLXJ1bGUtcGFyZW50LXAgIiBAICIpCisgICAgICAgICAgKHNtaWUtcnVsZS1wYXJl bnQgcnVieS1pbmRlbnQtbGV2ZWwpKSkKICAgICAoYCg6YWZ0ZXIgLiAsKG9yICI/IiAiOiIp KSBydWJ5LWluZGVudC1sZXZlbCkKICAgICAoYCg6YmVmb3JlIC4gLChndWFyZCAobWVtcSAo aW50ZXJuLXNvZnQgdG9rZW4pIHJ1YnktYWxpZ25hYmxlLWtleXdvcmRzKSkpCiAgICAgICh3 aGVuIChub3QgKHJ1YnktLWF0LWluZGVudGF0aW9uLXApKQpAQCAtMTYzMSw3ICsxNjQ5LDcg QEAgcnVieS1hZGQtbG9nLWN1cnJlbnQtbWV0aG9kCiAgICAgICAgICAgICAgICAgICAod2hp bGUgKGFuZCAocmUtc2VhcmNoLWJhY2t3YXJkIGRlZmluaXRpb24tcmUgbmlsIHQpCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAoaWYgKGlmIChzdHJpbmctZXF1YWwgImRlZiIg KG1hdGNoLXN0cmluZyAxKSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgOzsgV2UncmUgaW5zaWRlIGEgbWV0aG9kLgotICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAoaWYgKHJ1YnktYmxvY2stY29udGFpbnMtcG9pbnQgc3RhcnQpCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChpZiAocnVieS1ibG9jay1j b250YWlucy1wb2ludCAoMS0gc3RhcnQpKQogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgdAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIDs7IFRyeSB0byBtYXRjaCBhIG1ldGhvZCBvbmx5IG9uY2UuCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKHNldHEgZGVmaW5pdGlvbi1yZSBtb2R1bGUt cmUpCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvcHJvZ21vZGVzL3J1YnktbW9kZS1yZXNvdXJj ZXMvcnVieS5yYiBiL3Rlc3QvbGlzcC9wcm9nbW9kZXMvcnVieS1tb2RlLXJlc291cmNlcy9y dWJ5LnJiCmluZGV4IGYzOTQ4OTA3MWUuLjJlMDg3MzkzYTggMTAwNjQ0Ci0tLSBhL3Rlc3Qv bGlzcC9wcm9nbW9kZXMvcnVieS1tb2RlLXJlc291cmNlcy9ydWJ5LnJiCisrKyBiL3Rlc3Qv bGlzcC9wcm9nbW9kZXMvcnVieS1tb2RlLXJlc291cmNlcy9ydWJ5LnJiCkBAIC01MDAsMyAr NTAwLDI1IEBAIGRlZiByZXNvbHZlKCoqYXJncykKIAogICBtZW1iZXIuY2FsbCgqKmFyZ3Mp CiBlbmQKKworIyBFbmRsZXNzIG1ldGhvZHMuCitjbGFzcyBCYXIKKyAgZGVmIGZvbyhhYmMp ID0KKyAgICBiYXIgKworICAgIGJhcgorICAgICAgLmJhegorCisgIGRlZiBzZWxmLmJhciA9 CisgICAgMTIzICsKKyAgICA0CisKKyAgZGVmIHJlcXVlc3RfcGFyYW1zID0geworICAgIGhl YWRlcnM6IHJlcXVlc3RfaGVhZGVycywKKyAgICBib2R5OiByZXF1ZXN0X2JvZHkKKyAgfQor ZW5kCisKK2NsYXNzIEZvbworICBkZWYgZm9vKC4uLikgPSB6CisgIGRlZiBiYXIgPSB5Citl bmQKZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9wcm9nbW9kZXMvcnVieS1tb2RlLXRlc3RzLmVs IGIvdGVzdC9saXNwL3Byb2dtb2Rlcy9ydWJ5LW1vZGUtdGVzdHMuZWwKaW5kZXggZTkwYTll NDA3NS4uOWJlMDFkYzc4ZiAxMDA2NDQKLS0tIGEvdGVzdC9saXNwL3Byb2dtb2Rlcy9ydWJ5 LW1vZGUtdGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL3Byb2dtb2Rlcy9ydWJ5LW1vZGUtdGVz dHMuZWwKQEAgLTYwNSw2ICs2MDUsMTggQEAgcnVieS1hZGQtbG9nLWN1cnJlbnQtbWV0aG9k LWFmdGVyLWlubmVyLWNsYXNzLW91dHNpZGUtbWV0aG9kcy13aXRoLXRleHQKICAgICAoc2Vh cmNoLWJhY2t3YXJkICJGT08iKQogICAgIChzaG91bGQgKHN0cmluZz0gKHJ1YnktYWRkLWxv Zy1jdXJyZW50LW1ldGhvZCkgIk06OkMiKSkpKQogCisoZXJ0LWRlZnRlc3QgcnVieS1hZGQt bG9nLWN1cnJlbnQtbWV0aG9kLWFmdGVyLWVuZGxlc3MtbWV0aG9kICgpCisgIChydWJ5LXdp dGgtdGVtcC1idWZmZXIgKHJ1YnktdGVzdC1zdHJpbmcKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgIm1vZHVsZSBNCisgICAgICAgICAgICAgICAgICAgICAgICAgIHwgIGNsYXNzIEMK KyAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICBkZWYgZm9vID0KKyAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgICAgIDRfCisgICAgICAgICAgICAgICAgICAgICAgICAgIHwg IGVuZAorICAgICAgICAgICAgICAgICAgICAgICAgICB8ZW5kIikKKyAgICAoc2VhcmNoLWJh Y2t3YXJkICJfIikKKyAgICAoZGVsZXRlLWNoYXIgMSkKKyAgICAoc2hvdWxkIChzdHJpbmc9 IChydWJ5LWFkZC1sb2ctY3VycmVudC1tZXRob2QpICJNOjpDI2ZvbyIpKSkpCisKIChkZWZ2 YXIgcnVieS1ibG9jay10ZXN0LWV4YW1wbGUKICAgKHJ1YnktdGVzdC1zdHJpbmcKICAgICJj bGFzcyBDCg== --------------0vf04a750hbrpXwR60vBcsAP-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 16 07:40:34 2022 Received: (at 54702) by debbugs.gnu.org; 16 Dec 2022 12:40:34 +0000 Received: from localhost ([127.0.0.1]:49043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6A0w-0002Tt-1M for submit@debbugs.gnu.org; Fri, 16 Dec 2022 07:40:34 -0500 Received: from mail-wr1-f51.google.com ([209.85.221.51]:34671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6A0u-0002Tm-D9 for 54702@debbugs.gnu.org; Fri, 16 Dec 2022 07:40:32 -0500 Received: by mail-wr1-f51.google.com with SMTP id o5so2382790wrm.1 for <54702@debbugs.gnu.org>; Fri, 16 Dec 2022 04:40:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=oln96CxZMVK7aacC6vbXquqY40ziOLUmwGroanPmKww=; b=VVfZrnuZ9eZaAGSBWpJy73Ja8ZTUuokP0YLjcAs/8Rwl6JOOw20De5VxW9wl9Z8je1 XtbdeYRr4N237B0S7+tfs6fEZXeYghEbb0C/d88nFZP9rh+vZ1t4iYJKtTTQIdnRnAgt RS2MMSAVEldwdo9R6PRd6ctThtctuMfuT0/ueHoSbsq4g/1A7yIFe94ZggLqAzbGzfZe Abl/1+wM7DsjrTYs606eh11pN7DbIww0Gk5h/bAEVsMS9QZkjESByPc2Oa5MBEFyYk4x OvhzAtryM98S9+Nz6MeCfdaoKskKBOM9srtka1t9TjoXumIa1KEdirCpLyIe18p74F27 YAUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oln96CxZMVK7aacC6vbXquqY40ziOLUmwGroanPmKww=; b=IB5u3dlWdjZdg8gQx+LrBDQRugybx70vJ1gv03PIsccGyZahUNbt8CN+k7T8TLeq6X XIUFs04kqb7CKitHJw8O8c//zaDLo2AkO5Tr+zNZ2CJgcd+lgppJ7z78uBVvWsfDbJMj mpV6OF7jz+yQZ6CjUXNx0+1BfelGBaVdJWDAOMBii+iZi66KNOHo+PKp7z0usTmF7nMc wChI3jDZ60yXP1EU5qkk0WIBsr1yBxb7nKyDzMSteKydQc54oXG98bATDic8WhoK7chF B9c5VxAehZVJXSAJb0Yc4Yuu+ANYtafBnTVisLZNdjkt2AO+8rWaeSQW5FXzN+mOX9GV YRTw== X-Gm-Message-State: ANoB5pmJF3kN8RsvTehP7i1j/MhRPbRTXsNjX5WXNtr+PwV36eVpp5Sl R6ob7Ywnu0M3XWQIRk3gc7k= X-Google-Smtp-Source: AA0mqf6OvkqjGdagHaX2YvCbNqZdWTEGIQ5fAcvCCFsLbt0OdF30b+VbFkrbWF35F8EWePh4bRaPog== X-Received: by 2002:a5d:4f8d:0:b0:242:7084:b1b1 with SMTP id d13-20020a5d4f8d000000b002427084b1b1mr21227372wru.23.1671194426342; Fri, 16 Dec 2022 04:40:26 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id s4-20020a5d5104000000b0024207ed4ce0sm2174701wrt.58.2022.12.16.04.40.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Dec 2022 04:40:25 -0800 (PST) Message-ID: <420c9de4-19c7-1e44-afa9-7820d3549d4f@yandex.ru> Date: Fri, 16 Dec 2022 14:40:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#54702: 29.0.50; ruby-mode indentation: endless methods Content-Language: en-US From: Dmitry Gutov To: Eli Zaretskii References: <2136fe2e-85dd-8a3f-dc7b-ee7a8389dc76@yandex.ru> <0178ae56-21d9-55e9-68f6-b2e8e2a483ff@yandex.ru> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 54702 Cc: 54702@debbugs.gnu.org, Aaron Jensen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Hi Eli, On 16/12/2022 14:31, Dmitry Gutov wrote: > See the attached updated patch. What do you think about installing this on emacs-29? I want to treat this like a bugfix. It's fixing the lack of support for a language feature that came out 2 years ago, but is apparently growing in popularity now. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 16 08:12:29 2022 Received: (at 54702) by debbugs.gnu.org; 16 Dec 2022 13:12:29 +0000 Received: from localhost ([127.0.0.1]:49193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6AVp-0002qn-Bd for submit@debbugs.gnu.org; Fri, 16 Dec 2022 08:12:29 -0500 Received: from mail-pg1-f171.google.com ([209.85.215.171]:35410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6AVm-0002qY-F8 for 54702@debbugs.gnu.org; Fri, 16 Dec 2022 08:12:28 -0500 Received: by mail-pg1-f171.google.com with SMTP id f3so1740438pgc.2 for <54702@debbugs.gnu.org>; Fri, 16 Dec 2022 05:12:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+HMKTHjyJlLbxMtpSnymV///hprHPOJuolg6AvOGy3E=; b=PNsdmvtWzQG/XbjOqiIkSRm6LIp65HhBaRGoom8P+sXyPyKFezl9gatIr51n18hCHJ T5mTLEGt+Y5gtobzUyzjv7DviixKwr2HOqW9NP7xKu/ZXps3ZLX6/GwcwBEiaJt8HcXr twlT72WChDR2tw5JCDvayMcANae9B7V7F70Cs3FzgJYaeKVpcJZiebECq87yty2s6RH/ KPqNFsOOE+Q3U6nPzbJlRfLMXVwYDGrvwbqM3vDi/UDWwFWyVFQICMNSRti3NboGBNYL SqL8WygoCO+qTzhyFHHMsg0er3gHHx+/Pto8STZk77KFiQC+G9Iaa8zi2KGjos8QSvo+ BbbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+HMKTHjyJlLbxMtpSnymV///hprHPOJuolg6AvOGy3E=; b=EStiFznUBx5VLom+6pO0wirdvoEQw/hhmMG3WN90d5I23JcHzwOezuh909wL8AmdTE KhHx2FTucAvy8p3g1n4HEsbK9mEsDS1fTQr77ACwGixKtaJmfVo0RE5JEaC3/gBbiKSy yX9rqdVufZxbcXhWm7wMinpKfWD+sS7R4x6KbiMHar/xlbQ/5UNt6apM/nijKxU55DVG 1gkEiSHyKzqWR/s1Uq7fR+IohBEnSPacjP2c9Wwbg/dpo8sYhK8HeY2Zp++cP34khUgi O7rHjOmM5tuq68MbMTOZyOyieXLEU85KiPwbPA1Zz9GuyMqJQWidmu7Ddx5FD2wVg+J4 f20g== X-Gm-Message-State: ANoB5pkJ7eWNxClzWPIqYRdK9r8m3QuddJjEDfUtHyUqs7KXYAhpb3Od G1drO83FuFoA+PyRvCkGksLWLeMiJ/r0U38TWr8= X-Google-Smtp-Source: AA0mqf5JdL/HOIAY5uYel3QeFMtFHgp5+GbOiCgcUmsNE5qc4I8LI1BaFMpxhqMnJ8DHgu5U6ye3+80ZXxRsbqmcEs0= X-Received: by 2002:aa7:8502:0:b0:576:9786:94c2 with SMTP id v2-20020aa78502000000b00576978694c2mr26167326pfn.26.1671196340337; Fri, 16 Dec 2022 05:12:20 -0800 (PST) MIME-Version: 1.0 References: <2136fe2e-85dd-8a3f-dc7b-ee7a8389dc76@yandex.ru> <0178ae56-21d9-55e9-68f6-b2e8e2a483ff@yandex.ru> In-Reply-To: From: Aaron Jensen Date: Fri, 16 Dec 2022 08:12:09 -0500 Message-ID: Subject: Re: bug#54702: 29.0.50; ruby-mode indentation: endless methods To: Dmitry Gutov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 54702 Cc: 54702@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Dec 16, 2022 at 7:31 AM Dmitry Gutov wrote: > > Right, thanks. See the attached updated patch. That works. I found another inconsistency related to the other issue I just opened: def foo( baz, bar ) = what def foo( baz, bar ) hello end I don't know who is savage enough to do a multi-line endless method like that, but when it's done the closing paren should probably be consistent w/ the regular method closing paren. > Yeah, it looks promising, but let's see how it goes. > > And there is a certain barrier to compiling the tree-sitter stuff, so > we'll probably need to maintain the current/pure version in parallel for > a while. Indeed, it took me a while to even find reference to documentation on it and I was looking explicitly, so there's work to be done there for sure. Aaron From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 16 09:49:46 2022 Received: (at 54702) by debbugs.gnu.org; 16 Dec 2022 14:49:46 +0000 Received: from localhost ([127.0.0.1]:49798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6C1x-0006Wd-Td for submit@debbugs.gnu.org; Fri, 16 Dec 2022 09:49:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6C1t-0006WX-AM for 54702@debbugs.gnu.org; Fri, 16 Dec 2022 09:49:44 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6C1n-0007rZ-Kv; Fri, 16 Dec 2022 09:49:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=He3kd+mTGpC4WCOZ8KXs7M1A2ZlTDaYFjVZlzAoefas=; b=ZyL5Tz91T1VV Qps/xNvN6WBxmYrIX/8MZWTu/xhZZITtxsoVmfsEvsX/bO9aJIqq+ITr8Ud8Bz9MG0IR0WBA9ISlV l1R5l8MzQ1EG5KTdS6do+gb1mOPHNICwxBhmTKOSiBJYt/6hVyeCy2Qw+Q9n9khk1xiaqzH8XAYHA n1oHdP9ET1nNYXfliPiqyraoJH/S9791ldTycarGyr8TChRHRKMp5Dvyc4WH2I4qKN+vi2cgdpXVo xSBVrVO48EmG1TrT5clvFwdcHtoyJRCMhfVFiUtyRGWNYDgc3oFnsbFX/aTlv4fDUp/L0MN0R67Mq O2DWWKMeFzjzk+c1zVFCHg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6C1m-0005u7-UD; Fri, 16 Dec 2022 09:49:35 -0500 Date: Fri, 16 Dec 2022 16:49:37 +0200 Message-Id: <83h6xvjtdq.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <420c9de4-19c7-1e44-afa9-7820d3549d4f@yandex.ru> (message from Dmitry Gutov on Fri, 16 Dec 2022 14:40:24 +0200) Subject: Re: bug#54702: 29.0.50; ruby-mode indentation: endless methods References: <2136fe2e-85dd-8a3f-dc7b-ee7a8389dc76@yandex.ru> <0178ae56-21d9-55e9-68f6-b2e8e2a483ff@yandex.ru> <420c9de4-19c7-1e44-afa9-7820d3549d4f@yandex.ru> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54702 Cc: 54702@debbugs.gnu.org, aaronjensen@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 16 Dec 2022 14:40:24 +0200 > From: Dmitry Gutov > Cc: 54702@debbugs.gnu.org, Aaron Jensen > > Hi Eli, > > On 16/12/2022 14:31, Dmitry Gutov wrote: > > > See the attached updated patch. > > What do you think about installing this on emacs-29? > > I want to treat this like a bugfix. It's fixing the lack of support for > a language feature that came out 2 years ago, but is apparently growing > in popularity now. If you think this is safe enough, it's fine with me. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 16 11:15:49 2022 Received: (at 54702) by debbugs.gnu.org; 16 Dec 2022 16:15:50 +0000 Received: from localhost ([127.0.0.1]:50241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6DNF-0001Md-DH for submit@debbugs.gnu.org; Fri, 16 Dec 2022 11:15:49 -0500 Received: from mail-wm1-f47.google.com ([209.85.128.47]:51195) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6DNA-0001MU-M2 for 54702@debbugs.gnu.org; Fri, 16 Dec 2022 11:15:48 -0500 Received: by mail-wm1-f47.google.com with SMTP id v7so2268714wmn.0 for <54702@debbugs.gnu.org>; Fri, 16 Dec 2022 08:15:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:sender:from:to:cc:subject :date:message-id:reply-to; bh=NczXuMn2yDVqoRuBmPhYhWPEh1wfm5hMxnVxE3X3AgQ=; b=e/WAwLCTXLMthay9dBV8vuSP4qG0vRgKJPvHBbidtY+JbZxi7xbwi68N2iiWTUEfIo aBeuFcXomc5Kl9MaEPD/k009Qk/Q/uKZ4tYXGBzdnksg7jultIw8tWmUSp81KXLNBhkr 2U781ybsfG/CeMHys9C/HXwjr42i6vqYb3TMpRywcIbCcfawl+S0HjVyTSlm3V/M6fQJ Zf48pkxSTLGE0ZdM8m31rNEggZhlV+d36QBrQ8JneAKfSCM5Ln5u9WhEfp0Ln1wjEYIP nNQvuuCntHxgc7l2unRz92UTk0AKazGzwHucFpMxlhjqi1LmeQvO4JRMzf0gf5hN/cMC yTfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NczXuMn2yDVqoRuBmPhYhWPEh1wfm5hMxnVxE3X3AgQ=; b=Vk7mGf7ZC2woRoUvZ0qP63Tuq+YhzUIoIDpaJZXZuLj0xgb47d/qBk+3SNSH9Sk60Q hyOJGAdCGjcAToYTZ/WXx/r2aIQFFDv/1BYjplDblzZ/4bylXtXwRGnSdnp3eVGtsCwT m5JcL6oAZaftEAyajwCVVicovYTKxNf23Vyh+vEFZS2CYx6an4w5dZgzba5vULVNl6JX s7ay/CCmmlid/JZVwoJdzrfzm7Fd0IStD3opg2AK2HnBD+ZRO9go3mneuFxFZPtUS+lc mZK2VjvpIoRT4jV9PcqoBNClBecyI/FoDJPeSkW6WKIYbnlcLTWc2L20sB8oxBCLcSpz 8udw== X-Gm-Message-State: AFqh2kodgJkCKBQ+9yFXdunIrR0wQLozqzFA5eg0JRqobbSFntiWnXCT wlUZZpGHGI5UvUvv90frw90= X-Google-Smtp-Source: AMrXdXsTLWSkd1AvgoT89GP67QwRW7uHIfc9UpaNogIgpXXEaaFHz9iBBL7yvT5DIE0wQ/TDrKQasQ== X-Received: by 2002:a05:600c:5126:b0:3d3:3c60:b2bb with SMTP id o38-20020a05600c512600b003d33c60b2bbmr5168015wms.23.1671207338607; Fri, 16 Dec 2022 08:15:38 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id f4-20020a5d58e4000000b002425be3c9e2sm2638113wrd.60.2022.12.16.08.15.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Dec 2022 08:15:37 -0800 (PST) Content-Type: multipart/mixed; boundary="------------o41ZDlb0T80Cugz7Jd4Z4boB" Message-ID: <0d8a9e9d-2c8f-6282-63da-e4af020fea8d@yandex.ru> Date: Fri, 16 Dec 2022 18:15:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#54702: 29.0.50; ruby-mode indentation: endless methods Content-Language: en-US To: Aaron Jensen References: <2136fe2e-85dd-8a3f-dc7b-ee7a8389dc76@yandex.ru> <0178ae56-21d9-55e9-68f6-b2e8e2a483ff@yandex.ru> From: Dmitry Gutov In-Reply-To: X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 54702 Cc: 54702@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) This is a multi-part message in MIME format. --------------o41ZDlb0T80Cugz7Jd4Z4boB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 16/12/2022 15:12, Aaron Jensen wrote: > On Fri, Dec 16, 2022 at 7:31 AM Dmitry Gutov wrote: >> >> Right, thanks. See the attached updated patch. > > That works. I found another inconsistency related to the other issue I > just opened: > > def foo( > baz, > bar > ) = what > > def foo( > baz, > bar > ) > hello > end > > I don't know who is savage enough to do a multi-line endless method > like that, but when it's done the closing paren should probably be > consistent w/ the regular method closing paren. Thank you, savage indeed. Okay, here's an alternative version -- this was a pain to implement. Would be much easier if we just decided to change the args indentation without support for the current one. --------------o41ZDlb0T80Cugz7Jd4Z4boB Content-Type: text/x-patch; charset=UTF-8; name="ruby-endless-methods-v2.diff" Content-Disposition: attachment; filename="ruby-endless-methods-v2.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3J1YnktbW9kZS5lbCBiL2xpc3AvcHJvZ21v ZGVzL3J1YnktbW9kZS5lbAppbmRleCA0YWMyODlkNTI5Li4yOTVhMmE2N2U5IDEwMDY0NAot LS0gYS9saXNwL3Byb2dtb2Rlcy9ydWJ5LW1vZGUuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMv cnVieS1tb2RlLmVsCkBAIC0xMzQsNiArMTM0LDEyIEBAIHJ1Ynktc3ltYm9sLWNoYXJzCiAo ZGVmY29uc3QgcnVieS1zeW1ib2wtcmUgKGNvbmNhdCAiWyIgcnVieS1zeW1ib2wtY2hhcnMg Il0iKQogICAiUmVnZXhwIHRvIG1hdGNoIHN5bWJvbHMuIikKIAorKGRlZmNvbnN0IHJ1Ynkt ZW5kbGVzcy1tZXRob2QtaGVhZC1yZQorICAoZm9ybWF0ICIgKlxcKHNlbGZcXC5cXCk/JXMr Wz8hXT8gKlxcKChbXigpXSopXFwpPyAqPSIgcnVieS1zeW1ib2wtcmUpCisgICJSZWdleHAg dG8gbWF0Y2ggdGhlIGJlZ2lubmluZyBvZiBhbiBlbmRsZXNzIG1ldGhvZCBkZWZpbml0aW9u LgorCitJdCBzaG91bGQgbWF0Y2ggdGhlIHBhcnQgYWZ0ZXIgXCJkZWZcIiBhbmQgdW50aWwg XCI9XCIuIikKKwogKGRlZnZhciBydWJ5LXVzZS1zbWllIHQpCiAobWFrZS1vYnNvbGV0ZS12 YXJpYWJsZSAncnVieS11c2Utc21pZSBuaWwgIjI4LjEiKQogCkBAIC0zNTEsNyArMzU3LDgg QEAgcnVieS1zbWllLWdyYW1tYXIKICAgICAgICAoZXhwICAoZXhwMSkgKGV4cCAiLCIgZXhw KSAoZXhwICI9IiBleHApCiAgICAgICAgICAgICAgKGlkICIgQCAiIGV4cCkpCiAgICAgICAg KGV4cDEgKGV4cDIpIChleHAyICI/IiBleHAxICI6IiBleHAxKSkKLSAgICAgICAoZXhwMiAo ZXhwMykgKGV4cDMgIi4iIGV4cDMpKQorICAgICAgIChleHAyIChleHAzKSAoZXhwMyAiLiIg ZXhwMykKKyAgICAgICAgICAgICAoZXhwMyAiZGVmPSIgZXhwMykpCiAgICAgICAgKGV4cDMg KCJkZWYiIGluc3RzICJlbmQiKQogICAgICAgICAgICAgICgiYmVnaW4iIGluc3RzLXJlc2N1 ZS1pbnN0cyAiZW5kIikKICAgICAgICAgICAgICAoImRvIiBpbnN0cyAiZW5kIikKQEAgLTUy OCw2ICs1MzUsOSBAQCBydWJ5LXNtaWUtLWZvcndhcmQtdG9rZW4KICAgICAgICAgICAgICAg KHJ1Ynktc21pZS0tZm9yd2FyZC10b2tlbikpIDtGdWxseSByZWR1bmRhbnQuCiAgICAgICAg ICAgICAgKHQgIjsiKSkpCiAgICAgICAgICAgICgoZXF1YWwgdG9rICImLiIpICIuIikKKyAg ICAgICAgICAgKChhbmQgKGVxdWFsIHRvayAiZGVmIikKKyAgICAgICAgICAgICAgICAgKGxv b2tpbmctYXQgcnVieS1lbmRsZXNzLW1ldGhvZC1oZWFkLXJlKSkKKyAgICAgICAgICAgICJk ZWY9IikKICAgICAgICAgICAgKHQgdG9rKSkpKSkpKSkpCiAKIChkZWZ1biBydWJ5LXNtaWUt LWJhY2t3YXJkLXRva2VuICgpCkBAIC01NzUsNiArNTg1LDkgQEAgcnVieS1zbWllLS1iYWNr d2FyZC10b2tlbgogICAgICAgICAgICAgKHJ1Ynktc21pZS0tYmFja3dhcmQtdG9rZW4pKSA7 RnVsbHkgcmVkdW5kYW50LgogICAgICAgICAgICAodCAiOyIpKSkKICAgICAgICAgICgoZXF1 YWwgdG9rICImLiIpICIuIikKKyAgICAgICAgICgoYW5kIChlcXVhbCB0b2sgImRlZiIpCisg ICAgICAgICAgICAgICAobG9va2luZy1hdCAoY29uY2F0ICJkZWYiIHJ1YnktZW5kbGVzcy1t ZXRob2QtaGVhZC1yZSkpKQorICAgICAgICAgICJkZWY9IikKICAgICAgICAgICh0IHRvaykp KSkpKSkKIAogKGRlZnVuIHJ1Ynktc21pZS0taW5kZW50LXRvLXN0bXQgKCkKQEAgLTYyOSw2 ICs2NDIsMTMgQEAgcnVieS1zbWllLXJ1bGVzCiAgICAgICAgICAgICAgICAgICAgICAobm90 IChydWJ5LXNtaWUtLWJvc3ApKSkKICAgICAgICAgICAgKGZvcndhcmQtY2hhciAtMSkpCiAg ICAgICAgICAoc21pZS1pbmRlbnQtdmlydHVhbCkpCisgICAgICAgICgoYW5kIChzbWllLXJ1 bGUtcGFyZW50LXAgIiBAICIpCisgICAgICAgICAgICAgIChzYXZlLWV4Y3Vyc2lvbgorICAg ICAgICAgICAgICAgIChnb3RvLWNoYXIgKG50aCAxIChzbWllLWluZGVudC0tcGFyZW50KSkp CisgICAgICAgICAgICAgICAgKGFuZAorICAgICAgICAgICAgICAgICAoc21pZS1ydWxlLXBy ZXYtcCAiZGVmPSIpCisgICAgICAgICAgICAgICAgIChzbWllLWluZGVudC1iYWNrd2FyZC10 b2tlbikKKyAgICAgICAgICAgICAgICAgKHNtaWUtaW5kZW50LXZpcnR1YWwpKSkpKQogICAg ICAgICAodCAoc21pZS1ydWxlLXBhcmVudCkpKSkpKQogICAgIChgKDphZnRlciAuICwob3Ig IigiICJbIiAieyIpKQogICAgICA7OyBGSVhNRTogU2hvdWxkbid0IHRoaXMgYmUgdGhlIGRl ZmF1bHQgYmVoYXZpb3Igb2YKQEAgLTY3Miw2ICs2OTIsMTEgQEAgcnVieS1zbWllLXJ1bGVz CiAgICAgIChhbmQgKHNtaWUtcnVsZS1wYXJlbnQtcCAiOyIgbmlsKQogICAgICAgICAgIChz bWllLWluZGVudC0taGFuZ2luZy1wKQogICAgICAgICAgIHJ1YnktaW5kZW50LWxldmVsKSkK KyAgICAoYCg6YmVmb3JlIC4gIj0iKQorICAgICAod2hlbiAoc21pZS1ydWxlLXBhcmVudC1w ICIgQCAiKQorICAgICAgIChnb3RvLWNoYXIgKG50aCAxIChzbWllLWluZGVudC0tcGFyZW50 KSkpCisgICAgICAgKHNtaWUtaW5kZW50LWJhY2t3YXJkLXRva2VuKQorICAgICAgIChjb25z ICdjb2x1bW4gKCsgKHNtaWUtaW5kZW50LXZpcnR1YWwpIHJ1YnktaW5kZW50LWxldmVsKSkp KQogICAgIChgKDphZnRlciAuICwob3IgIj8iICI6IikpIHJ1YnktaW5kZW50LWxldmVsKQog ICAgIChgKDpiZWZvcmUgLiAsKGd1YXJkIChtZW1xIChpbnRlcm4tc29mdCB0b2tlbikgcnVi eS1hbGlnbmFibGUta2V5d29yZHMpKSkKICAgICAgKHdoZW4gKG5vdCAocnVieS0tYXQtaW5k ZW50YXRpb24tcCkpCkBAIC0xNjMxLDcgKzE2NTYsNyBAQCBydWJ5LWFkZC1sb2ctY3VycmVu dC1tZXRob2QKICAgICAgICAgICAgICAgICAgICh3aGlsZSAoYW5kIChyZS1zZWFyY2gtYmFj a3dhcmQgZGVmaW5pdGlvbi1yZSBuaWwgdCkKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIChpZiAoaWYgKHN0cmluZy1lcXVhbCAiZGVmIiAobWF0Y2gtc3RyaW5nIDEpKQogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA7OyBXZSdyZSBpbnNpZGUgYSBt ZXRob2QuCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChpZiAocnVi eS1ibG9jay1jb250YWlucy1wb2ludCBzdGFydCkKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgKGlmIChydWJ5LWJsb2NrLWNvbnRhaW5zLXBvaW50ICgxLSBzdGFy dCkpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0CiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgVHJ5IHRvIG1hdGNoIGEg bWV0aG9kIG9ubHkgb25jZS4KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAoc2V0cSBkZWZpbml0aW9uLXJlIG1vZHVsZS1yZSkKZGlmZiAtLWdpdCBhL3Rlc3Qv bGlzcC9wcm9nbW9kZXMvcnVieS1tb2RlLXJlc291cmNlcy9ydWJ5LnJiIGIvdGVzdC9saXNw L3Byb2dtb2Rlcy9ydWJ5LW1vZGUtcmVzb3VyY2VzL3J1YnkucmIKaW5kZXggZjM5NDg5MDcx ZS4uOWQ5YjQ2ZmEzMSAxMDA2NDQKLS0tIGEvdGVzdC9saXNwL3Byb2dtb2Rlcy9ydWJ5LW1v ZGUtcmVzb3VyY2VzL3J1YnkucmIKKysrIGIvdGVzdC9saXNwL3Byb2dtb2Rlcy9ydWJ5LW1v ZGUtcmVzb3VyY2VzL3J1YnkucmIKQEAgLTUwMCwzICs1MDAsNDEgQEAgZGVmIHJlc29sdmUo KiphcmdzKQogCiAgIG1lbWJlci5jYWxsKCoqYXJncykKIGVuZAorCisjIEVuZGxlc3MgbWV0 aG9kcy4KK2NsYXNzIEJhcgorICBkZWYgZm9vKGFiYykgPQorICAgIGJhciArCisgICAgYmFy CisgICAgICAuYmF6CisKKyAgZGVmIHNlbGYuYmFyID0KKyAgICAxMjMgKworICAgIDQKKwor ICBkZWYgcmVxdWVzdF9wYXJhbXMgPSB7CisgICAgaGVhZGVyczogcmVxdWVzdF9oZWFkZXJz LAorICAgIGJvZHk6IHJlcXVlc3RfYm9keQorICB9CisKKyAgZm9vIGEgPSA1LAorICAgICAg YgorCisgIGRlZiBmb28oCisgICAgICAgIGJheiwKKyAgICAgICAgYmFyCisgICAgICApID0K KyAgICB3aGF0CisKKyAgZGVmIGZvbygKKyAgICAgICAgYmF6LAorICAgICAgICBiYXIKKyAg ICAgICkKKyAgICBoZWxsbworICBlbmQKK2VuZAorCitjbGFzcyBGb28KKyAgZGVmIGZvbygu Li4pID0gegorICBkZWYgYmFyID0geQorZW5kCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvcHJv Z21vZGVzL3J1YnktbW9kZS10ZXN0cy5lbCBiL3Rlc3QvbGlzcC9wcm9nbW9kZXMvcnVieS1t b2RlLXRlc3RzLmVsCmluZGV4IGU5MGE5ZTQwNzUuLjliZTAxZGM3OGYgMTAwNjQ0Ci0tLSBh L3Rlc3QvbGlzcC9wcm9nbW9kZXMvcnVieS1tb2RlLXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlz cC9wcm9nbW9kZXMvcnVieS1tb2RlLXRlc3RzLmVsCkBAIC02MDUsNiArNjA1LDE4IEBAIHJ1 YnktYWRkLWxvZy1jdXJyZW50LW1ldGhvZC1hZnRlci1pbm5lci1jbGFzcy1vdXRzaWRlLW1l dGhvZHMtd2l0aC10ZXh0CiAgICAgKHNlYXJjaC1iYWNrd2FyZCAiRk9PIikKICAgICAoc2hv dWxkIChzdHJpbmc9IChydWJ5LWFkZC1sb2ctY3VycmVudC1tZXRob2QpICJNOjpDIikpKSkK IAorKGVydC1kZWZ0ZXN0IHJ1YnktYWRkLWxvZy1jdXJyZW50LW1ldGhvZC1hZnRlci1lbmRs ZXNzLW1ldGhvZCAoKQorICAocnVieS13aXRoLXRlbXAtYnVmZmVyIChydWJ5LXRlc3Qtc3Ry aW5nCisgICAgICAgICAgICAgICAgICAgICAgICAgICJtb2R1bGUgTQorICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICBjbGFzcyBDCisgICAgICAgICAgICAgICAgICAgICAgICAgIHwg ICAgZGVmIGZvbyA9CisgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgICA0XworICAg ICAgICAgICAgICAgICAgICAgICAgICB8ICBlbmQKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgfGVuZCIpCisgICAgKHNlYXJjaC1iYWNrd2FyZCAiXyIpCisgICAgKGRlbGV0ZS1jaGFy IDEpCisgICAgKHNob3VsZCAoc3RyaW5nPSAocnVieS1hZGQtbG9nLWN1cnJlbnQtbWV0aG9k KSAiTTo6QyNmb28iKSkpKQorCiAoZGVmdmFyIHJ1YnktYmxvY2stdGVzdC1leGFtcGxlCiAg IChydWJ5LXRlc3Qtc3RyaW5nCiAgICAiY2xhc3MgQwo= --------------o41ZDlb0T80Cugz7Jd4Z4boB-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 16 11:24:44 2022 Received: (at 54702) by debbugs.gnu.org; 16 Dec 2022 16:24:45 +0000 Received: from localhost ([127.0.0.1]:50278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6DVs-0001RJ-Jk for submit@debbugs.gnu.org; Fri, 16 Dec 2022 11:24:44 -0500 Received: from mail-pj1-f46.google.com ([209.85.216.46]:51820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6DVp-0001RD-3v for 54702@debbugs.gnu.org; Fri, 16 Dec 2022 11:24:43 -0500 Received: by mail-pj1-f46.google.com with SMTP id gt4so2994309pjb.1 for <54702@debbugs.gnu.org>; Fri, 16 Dec 2022 08:24:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FwDLgfm2tVhAdtDmkevrzvNo57ZW/XheyFSKiVDUemY=; b=Xhg6LhKzLyBFSk7zGwMtg5rlRyID9teDiTs2NnfkXY4t7HC0QRb6tRYSBnDs7rNDJ3 rXWzgnEGwVZxVjqAZfSd8QbeWDUobYJa+b6XvJpvnkeyjusZ3+GT7MT6xpj98kBjo+Fk gpqJNv6S+qOJzfvD+/zDBkktSTOMW2+vM9tKoIb4PPk3bijdHZk2GYTgLMVYfbFxV+w0 LcVuHVlmPcmBJTwn96eeBjBjkNGFhCbzYZ+eCsYKhIrdpstsgqdaPpW2IOU0oL+e5253 UPGKF2W1LjKFAik0CCAzBs/ihi7veXLmkmcZwuSNAs+ZzXTdFtusQWCCwOCnMmEawlP0 9SvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FwDLgfm2tVhAdtDmkevrzvNo57ZW/XheyFSKiVDUemY=; b=0Uy4oJn5QneJroQllH8b7HjlEKrg9hUBcfYLE+IXJCW+4geR72RWyIre93YjLdrGPU RYFB9C6dxSQada0HW2qUWcN+iG1mLfY/NXABNRa/RmYgkOWnhy4EW+kHUOr8F4pa1LyO G/dt/X1+Hx4fHvImovStsBy3UrfSyV88seWtDi2F5f9yt3Ux7XGA0UqP7d5+Frwu1IWK JvAeD2KsDL59fZtYRdSvm0N3uR/hRzn9YgNQILFQIrdjBcUk+r+eIRQObfdG9o7fJyj0 dTYuhHTk1xjte9K5RJjowMMeKchIltzaBAvh1gvbevsp76eubYfRHdnJONd8eoBMSL/w jKzA== X-Gm-Message-State: ANoB5pkX33DGwjExTox0En9dunNAT5fa+SgN5A19XZoV+W8A0uymJG+t fBBZc21rcuPiS0a4F8rqKA0dCotLoZRVMZYg74d0IBE+4NQ= X-Google-Smtp-Source: AA0mqf5msD7KaHQiFxHbTLvUUIrw655dUYBHoqCkS1yCUxgd+RTF28fp+jQZIebOTTI8cDwbYhjcVzWZdM+UlU4i/6Q= X-Received: by 2002:a17:902:9b92:b0:18e:bd50:f19a with SMTP id y18-20020a1709029b9200b0018ebd50f19amr1335707plp.81.1671207874920; Fri, 16 Dec 2022 08:24:34 -0800 (PST) MIME-Version: 1.0 References: <2136fe2e-85dd-8a3f-dc7b-ee7a8389dc76@yandex.ru> <0178ae56-21d9-55e9-68f6-b2e8e2a483ff@yandex.ru> <0d8a9e9d-2c8f-6282-63da-e4af020fea8d@yandex.ru> In-Reply-To: <0d8a9e9d-2c8f-6282-63da-e4af020fea8d@yandex.ru> From: Aaron Jensen Date: Fri, 16 Dec 2022 11:24:23 -0500 Message-ID: Subject: Re: bug#54702: 29.0.50; ruby-mode indentation: endless methods To: Dmitry Gutov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54702 Cc: 54702@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Dec 16, 2022 at 11:15 AM Dmitry Gutov wrote: > > On 16/12/2022 15:12, Aaron Jensen wrote: > > On Fri, Dec 16, 2022 at 7:31 AM Dmitry Gutov wrote: > >> > >> Right, thanks. See the attached updated patch. > > > > That works. I found another inconsistency related to the other issue I > > just opened: > > > > def foo( > > baz, > > bar > > ) = what > > > > def foo( > > baz, > > bar > > ) > > hello > > end > > > > I don't know who is savage enough to do a multi-line endless method > > like that, but when it's done the closing paren should probably be > > consistent w/ the regular method closing paren. > > Thank you, savage indeed. > > Okay, here's an alternative version -- this was a pain to implement. > > Would be much easier if we just decided to change the args indentation > without support for the current one. It works for me w/ that example. You won't find me resisting getting rid of the old way. Lining up against the method name is a fairly clear UX issue, in my opinion. I don't know that it's something I see outside of Emacs, and my guess is that it was influenced by Lisp rather than being influenced by Ruby and its community. Aaron From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 16 12:49:45 2022 Received: (at 54702) by debbugs.gnu.org; 16 Dec 2022 17:49:45 +0000 Received: from localhost ([127.0.0.1]:50653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6Eq9-0004d1-Dg for submit@debbugs.gnu.org; Fri, 16 Dec 2022 12:49:45 -0500 Received: from mail-wr1-f46.google.com ([209.85.221.46]:40722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6Eq7-0004ct-VR for 54702@debbugs.gnu.org; Fri, 16 Dec 2022 12:49:44 -0500 Received: by mail-wr1-f46.google.com with SMTP id m14so3243621wrh.7 for <54702@debbugs.gnu.org>; Fri, 16 Dec 2022 09:49:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=n/xjBxcdSAapDlRWgiTB4JE4NUbqFNLpR3KZ/us0ViU=; b=j/jhV5KPdF7dR8FqPfkyZV2aiJdfm3tu2IhAiFCTaTJLChEeo9iFvuRLuYRi61c5s+ dPF2PacCnWJSl3SX7iXZo8k8TJFpg0hgxpDEcorvddeAMu62J2ti31cWbcE7h0coN69M BRRPgFQzNL4KaJK5VnFxo3M1JXG0ZtA689ioRdZNpohZ4kfkpjmGROMe3RQfXk9WNg3p VcO2LQFMCly3AAAlbi8sQtV1yOtwAWvjdBO5LhfBW0/slv1FfGP6cVxeUjwzi6g64s3d VVT+dK5IO0gKfM4pKDe/wSY7DJ6Y1L05PoTKakbMe1V3s2k+YHHCzrR6RR/z5Gcixr5n iGrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n/xjBxcdSAapDlRWgiTB4JE4NUbqFNLpR3KZ/us0ViU=; b=70ISnyOifnN9uVqXheX4lnKy7xHSSdrH6g8RWqaRI12kY7I6zM7WpqqFoayXg5yMKt tB3eO5LfdgJ9xSx5jd0WE4uxcYk85oSlJ78kIKECSS/WEnrLC5XgBI/r7bMfdAxKSVQN NGSSt8BJ4sJxaB3vIXMCl+cGaYRFgMtwNifrMHzC+5h2FfNx4Mgmc07fzoSNlOGogpV5 YI5sEkw0f/67ougbpVjku8CrkPscPslWxXPG/Sw2ayXrCD73izU9rFSmXcaW9/FZMFgt j+oyPzhgMUqZFwJrh959ncyzU6pMg0ESl0CNW4gyR0qGC3YzuaHBe8KvWYyGzucCU3E2 w0dA== X-Gm-Message-State: ANoB5plOhSSa9NAXnfD0orVXab12Vn7OyuIiqKJ9FuWOvxQvCxzDNGvi f0wCccUFSMyYvHpth2yxRg8= X-Google-Smtp-Source: AA0mqf5/yn0RM1Iaknvz2A+f/MkZdGG+ecwG0ncx9RFhsJdXnSuBZXa9rmWCO7j6JDzIp1Q+k1TbKw== X-Received: by 2002:a5d:4ec5:0:b0:242:509a:ad4a with SMTP id s5-20020a5d4ec5000000b00242509aad4amr21223153wrv.7.1671212977883; Fri, 16 Dec 2022 09:49:37 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id c3-20020a5d5283000000b0024206ed539fsm2846610wrv.66.2022.12.16.09.49.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Dec 2022 09:49:37 -0800 (PST) Message-ID: Date: Fri, 16 Dec 2022 19:49:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#54702: 29.0.50; ruby-mode indentation: endless methods Content-Language: en-US To: Aaron Jensen References: <2136fe2e-85dd-8a3f-dc7b-ee7a8389dc76@yandex.ru> <0178ae56-21d9-55e9-68f6-b2e8e2a483ff@yandex.ru> <0d8a9e9d-2c8f-6282-63da-e4af020fea8d@yandex.ru> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 54702 Cc: 54702@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 16/12/2022 18:24, Aaron Jensen wrote: >> Okay, here's an alternative version -- this was a pain to implement. >> >> Would be much easier if we just decided to change the args indentation >> without support for the current one. > > It works for me w/ that example. > > You won't find me resisting getting rid of the old way. Lining up > against the method name is a fairly clear UX issue, in my opinion. I > don't know that it's something I see outside of Emacs, I suppose we might still want to care about a bunch of Emacs users who got used to this indentation over the years. :/ > and my guess is > that it was influenced by Lisp rather than being influenced by Ruby > and its community. You could say that. Not really influenced, though, it just works that way by accident due to the structural indentation algorithm. There are other Lispy examples which seem to provide their value: foo = 3 + 4 * 5 or this example, which is influenced by a lot of early Ruby code examples, yet is not supported by a lot of editors these days: qux :+, bar, :[]=, bar, :a From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 18 07:06:59 2022 Received: (at 54702-done) by debbugs.gnu.org; 18 Dec 2022 12:06:59 +0000 Received: from localhost ([127.0.0.1]:33588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6sRX-0008Jj-30 for submit@debbugs.gnu.org; Sun, 18 Dec 2022 07:06:59 -0500 Received: from mail-wm1-f43.google.com ([209.85.128.43]:33466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6sRU-0008Jd-Nf for 54702-done@debbugs.gnu.org; Sun, 18 Dec 2022 07:06:57 -0500 Received: by mail-wm1-f43.google.com with SMTP id z8-20020a05600c220800b003d33b0bda11so4353090wml.0 for <54702-done@debbugs.gnu.org>; Sun, 18 Dec 2022 04:06:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=CsN8qCWdl0a6Y+dF+wDYSNqChjzgOpgOosH/m+kMBwU=; b=LKjZIGS0UqN4kmOcPW5PcXScaAI31E4HKopTMQTIe0SHUVDP7/4exOeYRqJNZ0MnQW JqzbVSSusZtx+4MPAEBA1CR+FiNY2Ax9e1+cqaksq/9ho/U+RGQColIGWxFkOsM1r22Q yw/LdJ5qjggsCUTVYGnpmth2hU3xomdxJN/9uHVfkrr3QrMgFVXB8h/v+UVRkRQW14ft JWt0+BFGxFSToBKVF2pp0taDVYHu3v3VOKmNmvHflmdpBTTEAW4WFppAUunylxtpFsX+ waAQ8lUkImE9vEF18gClXFLsvezFWWk2tkieDvIazaTm2FhcdmNWU7cgVHf3HDJce2Vx wm9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CsN8qCWdl0a6Y+dF+wDYSNqChjzgOpgOosH/m+kMBwU=; b=nQ0kfCOJK1cAGLbn2TlrNrH4GGFuVsqxMgczr4yPjr9VUSQ6N1bGaWDNbX8MDZ1ZGD j7OAEgTzv97+vY/GqMDO1Om5Lo8iNyMnBuGu65Ie+Na7mufTDTZc5H16NUMbPYa96UTV eRRjCgO1zCiE+jYUl4vAs0HM1lSj+IKoZ1B64QeB6Lm/Ieep/eCtKAm+EiLgI0ACtzd8 Y9djj2pFjHFQsHVecYQy2QArQomAOtSFpoiSAFSLLYYdnq3jglST7MP1HUoyUj5lZBML cn5Hi5tObo9Puntz0oD0sEHGnQtEjC+cSKKnSEXsQnWrWQMXXJ3zTNsrxnYdfDLCMBST RPUw== X-Gm-Message-State: ANoB5plsCb14YclTnQWx9YDsXCBRG605ixPTB1iqe41lxQYViwqCuqiL LCs5StPQoiE/iu/4MpMXpww= X-Google-Smtp-Source: AA0mqf4W7B3BuITe6Msl0wi7S+Y8mtcrMQJ7mm/0StD3U993JNnZDZn1bFm43nSK5d15rhLEq2/nVA== X-Received: by 2002:a05:600c:a11:b0:3d2:2a74:3a90 with SMTP id z17-20020a05600c0a1100b003d22a743a90mr19227329wmp.22.1671365210805; Sun, 18 Dec 2022 04:06:50 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id v2-20020a05600c214200b003cfa81e2eb4sm8610221wml.38.2022.12.18.04.06.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Dec 2022 04:06:50 -0800 (PST) Message-ID: <925ca489-071d-1d9a-da9b-93b7a522ca63@yandex.ru> Date: Sun, 18 Dec 2022 14:06:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#54702: 29.0.50; ruby-mode indentation: endless methods Content-Language: en-US To: Eli Zaretskii References: <2136fe2e-85dd-8a3f-dc7b-ee7a8389dc76@yandex.ru> <0178ae56-21d9-55e9-68f6-b2e8e2a483ff@yandex.ru> <420c9de4-19c7-1e44-afa9-7820d3549d4f@yandex.ru> <83h6xvjtdq.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83h6xvjtdq.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 54702-done Cc: 54702-done@debbugs.gnu.org, aaronjensen@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Version: 29.1 On 16/12/2022 16:49, Eli Zaretskii wrote: >> Date: Fri, 16 Dec 2022 14:40:24 +0200 >> From: Dmitry Gutov >> Cc: 54702@debbugs.gnu.org, Aaron Jensen >> >> Hi Eli, >> >> On 16/12/2022 14:31, Dmitry Gutov wrote: >> >>> See the attached updated patch. >> >> What do you think about installing this on emacs-29? >> >> I want to treat this like a bugfix. It's fixing the lack of support for >> a language feature that came out 2 years ago, but is apparently growing >> in popularity now. > > If you think this is safe enough, it's fine with me. Thank you. After some testing, I went with the v2 patch, further simplified. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 18 10:42:44 2022 Received: (at 54702-done) by debbugs.gnu.org; 18 Dec 2022 15:42:44 +0000 Received: from localhost ([127.0.0.1]:34537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6voK-00070j-3X for submit@debbugs.gnu.org; Sun, 18 Dec 2022 10:42:44 -0500 Received: from mail-pj1-f46.google.com ([209.85.216.46]:43762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6voH-00070Y-Ur for 54702-done@debbugs.gnu.org; Sun, 18 Dec 2022 10:42:43 -0500 Received: by mail-pj1-f46.google.com with SMTP id u15-20020a17090a3fcf00b002191825cf02so6768884pjm.2 for <54702-done@debbugs.gnu.org>; Sun, 18 Dec 2022 07:42:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nR/kZO1zyE16dHopNfWRSOOywCC2bhfCe3rmnrzE1Sk=; b=M56NLCd8X8ufA19RDPLr3o6+LfcRp/q9bAxuzXgMIWXLZpq/BxQ53v91onZNyh20OU 4BFs3HqeyzV9Z15Jf0khQZ4gYLx5nyDjuk0is7NaIGKaZMe7i3Hs7pnz4Vtdraef4R/k +wbACit16VyJQbTRdlhcSP1OZ8/oIj1Dn8vKablKb1jwLS7NRhwplWvpUJz+b3swCtRf NF47bud984ZY+qTbzVWK64VbXva1fuKo/Rh5MqjX0DNNebqBUNx0bmOyGH6LB8RmDXvZ kF/QQ3T1APJloIQ9VA5jPK1glkeAr8CBzEYAVLKQPca7J4AFLM6O/HU3O1XuFngEgAvC QN/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nR/kZO1zyE16dHopNfWRSOOywCC2bhfCe3rmnrzE1Sk=; b=u5Sk8H7di62bh9uTtyl7fwFwh91yg9ei/pWliHBqgzhsiA+tPZvlr01zCzxW1V59cy /nyV94XZ7Olc9Hy3PPsGkisJX6+qD9LqwMmMM8PCV7G3m3wyf9vqGIkiO2v3g1HDVAx/ xk02h813Z37iNYZG5830aqQGcWrKhWrzLk7gaaxWdO7lROBliGNhHq+ege9kmSPwniFN 8g9Ez9xel+Y9Eyq1Dh2KCb3ysd92Xt75p5FuBkz788o2Q+YduNkmGEA/U+s6WOTCfMq0 K/QbZRBAUhkrW+rM2SHa+jRa7Zy4iIJqF7D/IJCp4Yd34lz+Sb7PFaYzDfDavCocUZ5A kb4w== X-Gm-Message-State: ANoB5pk2W0h7e6+01GdCF8i1WdqwRA6sYhQ+tll4p22oXVpA9SUfN/ct ASnob/53kf2uVAaEeohGoqo6O3uIyUpAwU1CHAg= X-Google-Smtp-Source: AA0mqf77OA80TRNZ7gB7HVgQ+9nPIUkCWCCZIhVDyqrcvAyHqhscJxVE24uLAFdbtp6l+P2i1S7DoJgLMzUA3DW5xsY= X-Received: by 2002:a17:902:7689:b0:189:b6cf:850d with SMTP id m9-20020a170902768900b00189b6cf850dmr32483470pll.30.1671378155833; Sun, 18 Dec 2022 07:42:35 -0800 (PST) MIME-Version: 1.0 References: <2136fe2e-85dd-8a3f-dc7b-ee7a8389dc76@yandex.ru> <0178ae56-21d9-55e9-68f6-b2e8e2a483ff@yandex.ru> <420c9de4-19c7-1e44-afa9-7820d3549d4f@yandex.ru> <83h6xvjtdq.fsf@gnu.org> <925ca489-071d-1d9a-da9b-93b7a522ca63@yandex.ru> In-Reply-To: <925ca489-071d-1d9a-da9b-93b7a522ca63@yandex.ru> From: Aaron Jensen Date: Sun, 18 Dec 2022 10:42:24 -0500 Message-ID: Subject: Re: bug#54702: 29.0.50; ruby-mode indentation: endless methods To: Dmitry Gutov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54702-done Cc: Eli Zaretskii , 54702-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Dec 18, 2022 at 7:06 AM Dmitry Gutov wrote: > Thank you. > > After some testing, I went with the v2 patch, further simplified. Thank you. From unknown Sat Aug 16 18:40:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 16 Jan 2023 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator