GNU bug report logs - #54674
[PATCH] services: configuration: Use *unspecified* instead of 'disabled.

Previous Next

Full log

View this message in rfc822 format

From: Maxime Devos <maximedevos <at> telenet.be>
To: Attila Lendvai <attila <at> lendvai.name>, 54674 <at> debbugs.gnu.org
Subject: [bug#54674] [PATCH] services: configuration: Use *unspecified* instead of 'disabled.
Date: Fri, 01 Apr 2022 21:46:37 +0200

[Message part 1 (text/plain, inline)]

Attila Lendvai schreef op vr 01-04-2022 om 21:19 [+0200]:
> ...as a marker for field values that have not been set. Rationale: 'disabled
> may easily [...], is confusing

Exactly, example:

> --- a/gnu/services/authentication.scm
> +++ b/gnu/services/authentication.scm
> @@ -218,7 +218,7 @@ (define-configuration nslcd-configuration
>  
>    ;; Runtime options
>    (threads
> -   (maybe-number 'disabled)
> +   (maybe-number)
>     "The number of threads to start that can handle requests and perform LDAP
>  queries.  Each thread opens a separate connection to the LDAP server.  The
>  default is to start 5 threads.")

(threads 'disabled) did not actually disable multi-threading.
FWIW, in this particular case, it could be (threads (number 5) ...)
instead (not using 'disabled' or *unspecified*), but that seems
somewhat a separate matter to me.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.