GNU bug report logs - #54641
[PATCH] gnu: xmonad-next: Change #:phases to gexp.

Previous Next

Package: guix-patches;

Reported by: Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>

Date: Wed, 30 Mar 2022 18:04:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54641 in the body.
You can then email your comments to 54641 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#54641; Package guix-patches. (Wed, 30 Mar 2022 18:04:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 30 Mar 2022 18:04:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Meißner
 <daniel.meissner-i4k <at> ruhr-uni-bochum.de>
To: guix-patches <at> gnu.org
Cc: Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>
Subject: [PATCH] gnu: xmonad-next: Change #:phases to gexp.
Date: Wed, 30 Mar 2022 20:02:34 +0200

* gnu/packages/wm.scm (xmonad-next)[arguments]: Use #$output instead of
%output and $#(package-name this-package) and $#(package-synopsis
this-package) instead of name and synopsis.
---
 gnu/packages/wm.scm | 27 +++++++++++++++------------
 1 file changed, 15 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 3de760d7a6..d6e27f0677 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -51,6 +51,7 @@
 ;;; Copyright © 2022 John Kehayias <john.kehayias <at> protonmail.com>
 ;;; Copyright © 2022 Gabriel Wicki <gabriel <at> erlikon.ch>
 ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan <at> gmail.com>
+;;; Copyright © 2022 Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -758,22 +759,24 @@ (define-public xmonad-next
     (inputs (list ghc-data-default-class ghc-setlocale ghc-x11))
     (native-inputs (list ghc-quickcheck ghc-quickcheck-classes))
     (arguments
-     `(#:phases
-       (modify-phases %standard-phases
-         (add-after
-          'install 'install-xsession
-          (lambda _
-            (let* ((xsessions (string-append %output "/share/xsessions")))
-              (mkdir-p xsessions)
-              (call-with-output-file
-                  (string-append xsessions "/xmonad.desktop")
-                (lambda (port)
-                  (format port "~
+     (list #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'install 'install-xsession
+                 (lambda _
+                   (let ((xsessions (string-append #$output "/share/xsessions")))
+                     (mkdir-p xsessions)
+                     (call-with-output-file (string-append xsessions
+                                                           "/xmonad.desktop")
+                       (lambda (port)
+                         (format port "~
                     [Desktop Entry]~@
                     Name=~a~@
                     Comment=~a~@
                     Exec=~a/bin/xmonad~@
-                    Type=Application~%" ,name ,synopsis %output)))))))))
+                    Type=Application~%"
+                                 #$(package-name this-package)
+                                 #$(package-synopsis this-package)
+                                 #$output)))))))))
     (home-page "https://xmonad.org")
     (description
      "Xmonad is a tiling window manager for X.  Windows are arranged
-- 
2.34.0
Information forwarded to guix-patches <at> gnu.org:
bug#54641; Package guix-patches. (Wed, 30 Mar 2022 18:45:01 GMT) Full text and rfc822 format available.

Message #8 received at 54641 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Daniel Meißner
 <daniel.meissner-i4k <at> ruhr-uni-bochum.de>,  54641 <at> debbugs.gnu.org
Subject: Re: [bug#54641] [PATCH] gnu: xmonad-next: Change #:phases to gexp.
Date: Wed, 30 Mar 2022 20:44:25 +0200

[Message part 1 (text/plain, inline)]
Daniel Meißner via Guix-patches via schreef op wo 30-03-2022 om 20:02
[+0200]:
> +                                 #$(package-name this-package)
> +                                 #$(package-synopsis this-package)

These can be simplified to

  #$name
  #$synopsis

No need to use package-name/package-synopsis here.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]
Information forwarded to guix-patches <at> gnu.org:
bug#54641; Package guix-patches. (Wed, 30 Mar 2022 20:54:01 GMT) Full text and rfc822 format available.

Message #11 received at 54641 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Meißner
 <daniel.meissner-i4k <at> ruhr-uni-bochum.de>
To: 54641 <at> debbugs.gnu.org
Cc: Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>,
 maximedevos <at> telenet.be
Subject: [PATCH v2] gnu: xmonad-next: Change #:phases to gexp.
Date: Wed, 30 Mar 2022 22:53:34 +0200

* gnu/packages/wm.scm (xmonad-next)[arguments]: Use #$output instead of
%output and $#(package-name this-package) and $#(package-synopsis
this-package) instead of name and synopsis.
---
 gnu/packages/wm.scm | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

Thanks for your suggestions, Maxime.

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 3de760d7a6..036665f7f0 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -51,6 +51,7 @@
 ;;; Copyright © 2022 John Kehayias <john.kehayias <at> protonmail.com>
 ;;; Copyright © 2022 Gabriel Wicki <gabriel <at> erlikon.ch>
 ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan <at> gmail.com>
+;;; Copyright © 2022 Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -758,22 +759,21 @@ (define-public xmonad-next
     (inputs (list ghc-data-default-class ghc-setlocale ghc-x11))
     (native-inputs (list ghc-quickcheck ghc-quickcheck-classes))
     (arguments
-     `(#:phases
-       (modify-phases %standard-phases
-         (add-after
-          'install 'install-xsession
-          (lambda _
-            (let* ((xsessions (string-append %output "/share/xsessions")))
-              (mkdir-p xsessions)
-              (call-with-output-file
-                  (string-append xsessions "/xmonad.desktop")
-                (lambda (port)
-                  (format port "~
+     (list #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'install 'install-xsession
+                 (lambda _
+                   (let ((xsessions (string-append #$output "/share/xsessions")))
+                     (mkdir-p xsessions)
+                     (call-with-output-file (string-append xsessions
+                                                           "/xmonad.desktop")
+                       (lambda (port)
+                         (format port "~
                     [Desktop Entry]~@
                     Name=~a~@
                     Comment=~a~@
                     Exec=~a/bin/xmonad~@
-                    Type=Application~%" ,name ,synopsis %output)))))))))
+                    Type=Application~%" #$name #$synopsis #$output)))))))))
     (home-page "https://xmonad.org")
     (description
      "Xmonad is a tiling window manager for X.  Windows are arranged
-- 
2.34.0
Information forwarded to guix-patches <at> gnu.org:
bug#54641; Package guix-patches. (Fri, 01 Apr 2022 07:59:01 GMT) Full text and rfc822 format available.

Message #14 received at 54641 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Meißner
 <daniel.meissner-i4k <at> ruhr-uni-bochum.de>
To: 54641 <at> debbugs.gnu.org
Cc: Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>,
 Maxime Devos <maximedevos <at> telenet.be>
Subject: [PATCH v3] gnu: xmonad-next: Change #:phases to gexp.
Date: Fri,  1 Apr 2022 09:57:58 +0200

* gnu/packages/wm.scm (xmonad-next)[arguments]: Use #$output, #$name
and #$synopsis instead of %output, name and synopsis.
---
 gnu/packages/wm.scm | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

Sorry, I missed to change the commit message also.  This one should be
alright.

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 3de760d7a6..036665f7f0 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -51,6 +51,7 @@
 ;;; Copyright © 2022 John Kehayias <john.kehayias <at> protonmail.com>
 ;;; Copyright © 2022 Gabriel Wicki <gabriel <at> erlikon.ch>
 ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan <at> gmail.com>
+;;; Copyright © 2022 Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -758,22 +759,21 @@ (define-public xmonad-next
     (inputs (list ghc-data-default-class ghc-setlocale ghc-x11))
     (native-inputs (list ghc-quickcheck ghc-quickcheck-classes))
     (arguments
-     `(#:phases
-       (modify-phases %standard-phases
-         (add-after
-          'install 'install-xsession
-          (lambda _
-            (let* ((xsessions (string-append %output "/share/xsessions")))
-              (mkdir-p xsessions)
-              (call-with-output-file
-                  (string-append xsessions "/xmonad.desktop")
-                (lambda (port)
-                  (format port "~
+     (list #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'install 'install-xsession
+                 (lambda _
+                   (let ((xsessions (string-append #$output "/share/xsessions")))
+                     (mkdir-p xsessions)
+                     (call-with-output-file (string-append xsessions
+                                                           "/xmonad.desktop")
+                       (lambda (port)
+                         (format port "~
                     [Desktop Entry]~@
                     Name=~a~@
                     Comment=~a~@
                     Exec=~a/bin/xmonad~@
-                    Type=Application~%" ,name ,synopsis %output)))))))))
+                    Type=Application~%" #$name #$synopsis #$output)))))))))
     (home-page "https://xmonad.org")
     (description
      "Xmonad is a tiling window manager for X.  Windows are arranged
-- 
2.34.0
Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Tue, 05 Apr 2022 12:11:01 GMT) Full text and rfc822 format available.
Notification sent to Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>:
bug acknowledged by developer. (Tue, 05 Apr 2022 12:11:01 GMT) Full text and rfc822 format available.

Message #19 received at 54641-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>
Cc: Maxime Devos <maximedevos <at> telenet.be>, 54641-done <at> debbugs.gnu.org
Subject: Re: bug#54641: [PATCH] gnu: xmonad-next: Change #:phases to gexp.
Date: Tue, 05 Apr 2022 14:10:48 +0200

Hi,

Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de> skribis:

> * gnu/packages/wm.scm (xmonad-next)[arguments]: Use #$output, #$name
> and #$synopsis instead of %output, name and synopsis.

Applied, thanks!

Ludo’.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 04 May 2022 11:24:09 GMT) Full text and rfc822 format available.
This bug report was last modified 3 years and 45 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.