GNU bug report logs - #54618
[PATCH] gnu: lbzip2: Fix cross-compilation.

Previous Next

Package: guix-patches;

Reported by: Brian Kubisiak <brian <at> kubisiak.com>

Date: Tue, 29 Mar 2022 01:37:02 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Maxime Devos <maximedevos <at> telenet.be>
To: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>, Brian Kubisiak <brian <at> kubisiak.com>, 54618 <at> debbugs.gnu.org
Subject: [bug#54618] [PATCH] gnu: lbzip2: Fix cross-compilation.
Date: Tue, 29 Mar 2022 11:05:40 +0200

[Message part 1 (text/plain, inline)]
Liliana Marie Prikler schreef op di 29-03-2022 om 08:07 [+0200]:
> +             (lambda* (#:key inputs native-inputs #:allow-other-
> keys)
> +               (let ((gnulib (assoc-ref (or native-inputs inputs)
> "gnulib")))
>                   (copy-recursively gnulib "lib")
>                   (setenv "PATH" (string-append "lib:" (getenv
> "PATH")))
>                   #t)))
Note that referring to inputs by name is discouraged. In this case, the
gnulib origin should be inlined (see ppsspp or gnome-recipes for
examples on how that is done).  I don't think there is a native vs.
non-native distinction for origins, but if there is, simply use #+
instead of #$.

I would go with

  (let ((gnulib (dirname (search-input-file (or native-inputs inputs) "gnulib-tool.py"))))
    [...]).

That way, no input labels are used yet package transformations are
still possible:

  (package (inherit lbzip2) (native-inputs [some inputs with a different gnulib]))

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 3 years and 55 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.