Subject: bug#54615: closed (Re: [PATCH v3 2/2] gnu: Add riscv-pk.)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 31 Mar 2022 12:32:02 +0000

Your bug report

#54615: [PATCH 0/2] Add riscv-pk and improve spike

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
54615: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54615
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [PATCH v3 2/2] gnu: Add riscv-pk.
From: Efraim Flashner <[email-masked]>
To: Arun Isaac <[email-masked]>
Cc: Maxime Devos <[email-masked]>, [email-masked]
Date: Thu, 31 Mar 2022 15:30:26 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

Thanks for the patches. Does it make sense to wrap spike with riscv-pk?
Right now I'm running it with:
guix shell spike riscv-pk -- sh -c 'spike $GUIX_ENVIRONMENT/bin/pk /gnu/store/hzd70l3dbgf66m4ibf34dzl7sif06f3k-hello-static-2.12/bin/hello'

I'm not sure how much spike is used without pk.

-- 
Efraim Flashner   <[email-masked]>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Subject: [PATCH 0/2] Add riscv-pk and improve spike
From: Arun Isaac <[email-masked]>
To: [email-masked]
Cc: Arun Isaac <[email-masked]>, Efraim Flashner <[email-masked]>
Date: Tue, 29 Mar 2022 00:11:17 +0530
List-Id: <debbugs-submit.debbugs.gnu.org>

Patch 1 adds riscv-pk---a companion package for spike and something that is
meant to be used with it. riscv-pk is not meant to build on x86_64. So, a
regular `guix build riscv-pk' on a x86_64 machine will fail. Only `guix build
--target=riscv64-linux-gnu riscv-pk' will succeed.

Patch 2 improves our spike package by substituting the absolute path to dtc
instead of wrapping the spike executable.

Arun Isaac (2):
  gnu: spike: Substitute path to dtc instead of wrapping executables.
  gnu: Add riscv-pk.

 gnu/packages/virtualization.scm | 64 ++++++++++++++++++++++++++++-----
 1 file changed, 55 insertions(+), 9 deletions(-)

-- 
2.34.0