From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 28 10:49:52 2022 Received: (at submit) by debbugs.gnu.org; 28 Mar 2022 14:49:52 +0000 Received: from localhost ([127.0.0.1]:58919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYqgq-0003rp-CS for submit@debbugs.gnu.org; Mon, 28 Mar 2022 10:49:52 -0400 Received: from lists.gnu.org ([209.51.188.17]:35118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYqgp-0003rh-K3 for submit@debbugs.gnu.org; Mon, 28 Mar 2022 10:49:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51132) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYqgh-0007aQ-B9 for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2022 10:49:44 -0400 Received: from [2607:f8b0:4864:20::f2c] (port=45618 helo=mail-qv1-xf2c.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nYqge-0003mL-Vx for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2022 10:49:43 -0400 Received: by mail-qv1-xf2c.google.com with SMTP id b17so2335546qvf.12 for ; Mon, 28 Mar 2022 07:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20210112.gappssmtp.com; s=20210112; h=from:to:subject:date:message-id:mime-version; bh=snYkZVYBZ07hJf+HdHZ/D2z2YxPN2earl+dUOfCnwJU=; b=XSTKXn/V/gNTf+gkWpviAW8DyTTfht94AEg+98S+K0rvRd/oJgJqvx3M9Sl6/jEltU jhszXzatlaHAjKu65S0A3owENSIpT2bdb7F3f7dsr2xX5+WGoiuax64tjd36MfqKogXB wg+xueKNODg7GXrN8slbFptsPDZkJoCyFsUCRC1ZW6ZHItcJdDKQ40by/jV6Xm4mxepf /TMf9tpdhd0Dr9m5q5FBwsicsXfEvDHyteOQOkrwwplS+E+7dxynI44EPFBXBBDCk1i0 D6DPLMv8JGqApEidAw6sNCFFfeQFr2YI7WkfEgcY11e3QlsWeL1RTnjiKJ17190QKRWe I1GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=snYkZVYBZ07hJf+HdHZ/D2z2YxPN2earl+dUOfCnwJU=; b=k/R+fSi+HMqvn7+1/7DSR8Hcb0gmnATCQHZ+o5Z6NTWGeB6/BcHB4BxoKSbMBGKyzu Eq+uxGT9TqS22xB3Bng/VbIeO2T+Y9Q3U6nRgAWJYIXSkrOwzbv+/75CU7LlhCTgVI2O kJOqt4UGggrwww3LkUemQhqXqRP4XsnSqF7o2jRHySg7QErkulNPp1HVmuAgaKiw+AwN sD2rFZAUV5DtX7lLPpqvPUxxrwCAJCe/6LV+tZY/W8zwRzLFhM44LubZoRvUFBIkjRC2 s92MZInuOZxqP5iLBtWqAh1BSN9Hwmal2tzi1AnQ+fXUaa0sJ9cVpHQNWThUPgy3egGv X+Ag== X-Gm-Message-State: AOAM533ROutE57AWxFPZignH6Mq3LSJyynDw84slKHUDhuDUqFsFLrhJ 4wTwVF843OwNqp7NFGDnF3guDQ1oc3crFg== X-Google-Smtp-Source: ABdhPJx0k1wLtxuZIIpOt8+YJZCKBOc8VzVcO3gwvF0r63YABajv/v3fGFbScJmRyU+MQAPI/BvOHw== X-Received: by 2002:a05:6214:202a:b0:441:6a41:f710 with SMTP id 10-20020a056214202a00b004416a41f710mr20749224qvf.84.1648478977714; Mon, 28 Mar 2022 07:49:37 -0700 (PDT) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id 193-20020a3706ca000000b0067d3e4b5667sm8151403qkg.67.2022.03.28.07.49.37 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Mar 2022 07:49:37 -0700 (PDT) From: Thomas Fitzsimmons To: bug-gnu-emacs@gnu.org Subject: 29.0.50; eww-bookmarks data loss when print-length not nil Date: Mon, 28 Mar 2022 10:49:36 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::f2c (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::f2c; envelope-from=fitzsim@fitzsim.org; helo=mail-qv1-xf2c.google.com X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, In GNU Emacs 29.0.50 (build 1, powerpc64le-unknown-linux-gnu, X toolkit, cairo version 1.16.0, Xaw scroll bars) of 2022-02-27 built on orca.fitzsim.org Repository revision: 6a10a3e8d489d7b4dcffd6b4c63cee77e73e2535 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux bookworm/sid Configured using: 'configure --with-x-toolkit=lucid' Somehow print-length got set to 10 globally -- I don't know who the culprit was -- and I lost about 80 EWW bookmarks. I've looked around and they seem to have been well and truly purged from this Emacs session's memory. I'll have to restore from backups, I suppose. When a bookmark is added, and print-length is less than the length of eww-bookmarks, the contents of ~/.emacs.d/eww-bookmarks is truncated: ;; Auto-generated file; don't edit -*- mode: lisp-data -*- ((:url "" :title "" :time "") [(- print-length 1) more items] ...) I haven't investigated fully, but it seems like a terrible design that a global variable like print-length can have influence over princ/print in this way. This makes all printing fundamentally unreliable and subject to data loss if some rogue package or the end user goes (setq print-length ). What about this to at least insulate eww-write-bookmarks from this behaviour: diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 700a6c3e82..f5139819fb 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -2053,7 +2053,8 @@ eww-add-bookmark (defun eww-write-bookmarks () (with-temp-file (expand-file-name "eww-bookmarks" eww-bookmarks-directory) (insert ";; Auto-generated file; don't edit -*- mode: lisp-data -*-\n") - (pp eww-bookmarks (current-buffer)))) + (let ((print-length nil)) + (pp eww-bookmarks (current-buffer))))) (defun eww-read-bookmarks (&optional error-out) "Read bookmarks from `eww-bookmarks'. I'm not sure what a more general solution to the print-length/print-level data loss problem could be. Thomas From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 29 08:35:25 2022 Received: (at 54612) by debbugs.gnu.org; 29 Mar 2022 12:35:25 +0000 Received: from localhost ([127.0.0.1]:60129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZB4H-0002A1-Bm for submit@debbugs.gnu.org; Tue, 29 Mar 2022 08:35:25 -0400 Received: from quimby.gnus.org ([95.216.78.240]:59920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZB4F-00029n-Kv for 54612@debbugs.gnu.org; Tue, 29 Mar 2022 08:35:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YhhgjZuMPQU+rgmwioqMuupyReJJReMJXXL1P26xTpY=; b=CrjO05kqpSIb6+gbUY+7teuLj0 UNVHd5C0YcACQB8GD+TcrdJ6YxozSO8XHnUmKcqzW2XXebUYxsngWAeRONs3SCLSPSlo7Nrr6Q9uO dGcNDYzZhsz+WNUuYpTfNWXWjWxUBGrsoe0Tj/Xds8SHhZ/51mMnNntHt+VAWfSO05Zk=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZB46-0002qe-26; Tue, 29 Mar 2022 14:35:16 +0200 From: Lars Ingebrigtsen To: Thomas Fitzsimmons Subject: Re: bug#54612: 29.0.50; eww-bookmarks data loss when print-length not nil References: Date: Tue, 29 Mar 2022 14:35:11 +0200 In-Reply-To: (Thomas Fitzsimmons's message of "Mon, 28 Mar 2022 10:49:36 -0400") Message-ID: <87bkxpaqdc.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Thomas Fitzsimmons writes: > What about this to at least insulate eww-write-bookmarks from this > behaviour: Thanks, applied to Emacs 29 (along with a binding of print-level, which has a similar issue). Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54612 Cc: 54612@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thomas Fitzsimmons writes: > What about this to at least insulate eww-write-bookmarks from this > behaviour: Thanks, applied to Emacs 29 (along with a binding of print-level, which has a similar issue). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 29 08:35:29 2022 Received: (at control) by debbugs.gnu.org; 29 Mar 2022 12:35:29 +0000 Received: from localhost ([127.0.0.1]:60132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZB4L-0002AI-Ic for submit@debbugs.gnu.org; Tue, 29 Mar 2022 08:35:29 -0400 Received: from quimby.gnus.org ([95.216.78.240]:59940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZB4I-00029r-70 for control@debbugs.gnu.org; Tue, 29 Mar 2022 08:35:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vuINpzPuLeOlZ69mD9r0BBBrhv6Mis2q6C+4uljoEvs=; b=fO4TV4QnsQiGgIDBp2aVL+a1Wo sMHA7lkmaFdmdSKdcFkCqpJDwl++H8EyEnudFfvVdQzUkPVXJyz/njb6laCg6q1ZIoBCPFKAdxuZI O4KrLz86z0Gi4UHUHBdDtCUezsAtKulPlhcnmGruwQS3ZwRZoljaYX741xYVP5OBcdW8=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZB4B-0002ql-0N for control@debbugs.gnu.org; Tue, 29 Mar 2022 14:35:20 +0200 Date: Tue, 29 Mar 2022 14:35:18 +0200 Message-Id: <87a6d9aqd5.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #54612 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 54612 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 54612 29.1 quit From unknown Sat Aug 09 20:35:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 27 Apr 2022 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator