GNU bug report logs - #54596
[PATCH 0/1] Fix ocaml-odoc by updating to 2.2.0-alpha

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54596 in the body.
You can then email your comments to 54596 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: pukkamustard <pukkamustard <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: pukkamustard <pukkamustard <at> posteo.net>
Subject: [PATCH 0/1] Fix ocaml-odoc by updating to 2.2.0-alpha
Date: Sun, 27 Mar 2022 13:39:37 +0000

Hello Guix,

ocaml-odoc (2.1.0) does not seem to pass tests with recently updated dune
(3.0.3).

This has been fixed upstream:

https://github.com/ocaml/odoc/commit/6ac97f3148f7791ec7451785ef4dbd9ca0daf2d1

and pre-released with a 2.2.0-alpha tag:

https://github.com/ocaml/odoc/releases/tag/2.2.0-alpha

Following patch updates ocaml-odoc to 2.2.0-alpha and fixes the build.

Updating to 2.2.0-alpha seems like a slightly better hack than adding a patch
with the upstream fix. 

Regards,
pukkamustard

pukkamustard (1):
  gnu: ocaml-odoc: Update to 2.2.0-alpha.

 gnu/packages/ocaml.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

-- 
2.34.0

Message #8 received at 54596 <at> debbugs.gnu.org (full text, mbox):

From: pukkamustard <pukkamustard <at> posteo.net>
To: 54596 <at> debbugs.gnu.org
Cc: pukkamustard <pukkamustard <at> posteo.net>
Subject: [PATCH 1/1] gnu: ocaml-odoc: Update to 2.2.0-alpha.
Date: Sun, 27 Mar 2022 13:41:37 +0000

* gnu/packages/ocaml.scm (ocaml-odoc): Update to 2.2.0-alpha.
---
 gnu/packages/ocaml.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index 78eab203de..cb461bf257 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -6766,7 +6766,9 @@ (define-public ocaml4.07-bisect-ppx
 (define-public ocaml-odoc
   (package
     (name "ocaml-odoc")
-    (version "2.1.0")
+    ;; 2.2.0-alpha contains fixes for Dune 3.0 compatibility
+    ;; (https://github.com/ocaml/odoc/commit/6ac97f3148f7791ec7451785ef4dbd9ca0daf2d1)
+    (version "2.2.0-alpha")
     (source
      (origin
        (method git-fetch)
@@ -6775,7 +6777,7 @@ (define-public ocaml-odoc
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1ycb468pc6vsvqj176j99bmbkrr9saxvyn9qhpazi01abbcq5d90"))))
+        (base32 "07zjkk455l51i29lcayzrc1q8j5bvbv97sscv8yhcj7x6h6q2nag"))))
     (build-system dune-build-system)
     (arguments
      `(#:phases
-- 
2.34.0

Message #11 received at 54596 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: pukkamustard <pukkamustard <at> posteo.net>
Cc: 54596 <at> debbugs.gnu.org
Subject: Re: bug#54596: [PATCH 0/1] Fix ocaml-odoc by updating to 2.2.0-alpha
Date: Fri, 08 Apr 2022 15:09:19 +0200

Hi,

On Sun, 27 Mar 2022 at 13:39, pukkamustard <pukkamustard <at> posteo.net> wrote:

> pukkamustard (1):
>   gnu: ocaml-odoc: Update to 2.2.0-alpha.
>
>  gnu/packages/ocaml.scm | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

I propose to include this patch in the series #53882 and close this
submission.  WDYT?


Cheers,
simon

Message #16 received at 54596-done <at> debbugs.gnu.org (full text, mbox):

From: pukkamustard <pukkamustard <at> posteo.net>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 54596-done <at> debbugs.gnu.org
Subject: Re: bug#54596: [PATCH 0/1] Fix ocaml-odoc by updating to 2.2.0-alpha
Date: Fri, 08 Apr 2022 13:52:47 +0000

Hi,

zimoun <zimon.toutoune <at> gmail.com> writes:

> I propose to include this patch in the series #53882 and close this
> submission.  WDYT?

Ok for me. Closing this issue.

Cheers,
pukkamustard

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.