From unknown Sat Jun 14 18:46:14 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#54593 <54593@debbugs.gnu.org> To: bug#54593 <54593@debbugs.gnu.org> Subject: Status: Do not create output file on error Reply-To: bug#54593 <54593@debbugs.gnu.org> Date: Sun, 15 Jun 2025 01:46:14 +0000 retitle 54593 Do not create output file on error reassign 54593 skribilo submitter 54593 Arun Isaac severity 54593 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 27 04:51:43 2022 Received: (at submit) by debbugs.gnu.org; 27 Mar 2022 08:51:44 +0000 Received: from localhost ([127.0.0.1]:55310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYOch-0005wS-ME for submit@debbugs.gnu.org; Sun, 27 Mar 2022 04:51:43 -0400 Received: from lists.gnu.org ([209.51.188.17]:37750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYOcg-0005wL-EU for submit@debbugs.gnu.org; Sun, 27 Mar 2022 04:51:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYOcg-000449-4z for skribilo-bugs@nongnu.org; Sun, 27 Mar 2022 04:51:42 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:55536) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYOce-0005ld-Iu for skribilo-bugs@nongnu.org; Sun, 27 Mar 2022 04:51:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cpUnyYXm9265+gIOd0bWWjtHLy6IvQ2EJUv/2NplE+8=; b=hbNyzITLMHHpcsbZxuGvGClU5q opHiyeXK1nuR3mipTSrZSCUfLsxw5F1WCVMaAyFWLCJAhmNta+tNpeC4zKm3wrhUweJGFt9AOzJAp 6f0HMHbOiSumQ+UQr+G9rrgoZmS3Y0wznyBbvQ2kyJdc6cREfMrSqW6ezwOsAVzl6utgOGbRKi0Rq 9FrGV4FSQWD+yVJxycTCn9mIUxTYP8G4SmmXT+ZCyTq70eB8UX7vG+QlMOmX/tOrR6XIpPy1yzNHK zWt7kcSGvqdOQEsdRpqnozKyBiAdVoxk2kQq7KYuVa60yjMQyc9eqizMsvyCAjv68VMIIUYingGfb ZfKTv3bA==; Received: from [192.168.2.1] (port=6576 helo=steel) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1nYOca-000GNg-6l for skribilo-bugs@nongnu.org; Sun, 27 Mar 2022 14:21:36 +0530 From: Arun Isaac To: skribilo-bugs@nongnu.org Subject: Do not create output file on error Date: Sun, 27 Mar 2022 14:21:35 +0530 Message-ID: <87ee2nrd60.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=139.59.75.54; envelope-from=arunisaac@systemreboot.net; helo=mugam.systemreboot.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Skribilo creates an empty output file even when it errors out. For example, if I invoke skribilo as follows with foo.skb being non-existent, skribilo will error out but still create a foo.html. --8<---------------cut here---------------start------------->8--- $ ls foo.html ls: cannot access 'foo.html': No such file or directory $ ls foo.skb ls: cannot access 'foo.skb': No such file or directory $ skribilo -t html -o foo.html foo.skb Backtrace: In ice-9/boot-9.scm: 1752:10 10 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _) In unknown file: 9 (apply-smob/0 #) In ice-9/boot-9.scm: 724:2 8 (call-with-prompt _ _ #) In ice-9/eval.scm: 619:8 7 (_ #(#(#))) In ice-9/command-line.scm: 185:19 6 (_ #) In unknown file: 5 (eval (call-with-skribilo-error-catch/exit (lambda () (apply (module-ref (resolve-interface (quote (skribilo))) (quote skribilo)) (cdr (command-line))))) #) In ice-9/boot-9.scm: 1752:10 4 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _) In skribilo.scm: 429:14 3 (skribilo . _) In ice-9/ports.scm: 450:11 2 (call-with-input-file "foo.skb" # #:binary _ #:encoding _ #:guess-encoding _) In unknown file: 1 (open-file "foo.skb" "r" #:encoding #f #:guess-encoding #f) In ice-9/boot-9.scm: 1685:16 0 (raise-exception _ #:continuable? _) ice-9/boot-9.scm:1685:16: In procedure raise-exception: In procedure open-file: No such file or directory: "foo.skb" $ ls foo.html foo.html --8<---------------cut here---------------end--------------->8--- Among other things, this upsets the use of skribilo in Makefiles. When a skribilo invocation in a Makefile recipe fails, an output file is still created, and when make is run again, the skribilo invocation is not re-run. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 10 16:01:13 2022 Received: (at 54593) by debbugs.gnu.org; 10 Apr 2022 20:01:13 +0000 Received: from localhost ([127.0.0.1]:41595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nddkH-000167-Ee for submit@debbugs.gnu.org; Sun, 10 Apr 2022 16:01:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nddkF-00015q-Uz for 54593@debbugs.gnu.org; Sun, 10 Apr 2022 16:01:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48218) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nddk9-0006tC-GZ; Sun, 10 Apr 2022 16:01:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=ajuhMndTv0jsfk3vJGF7rtGLbdf3YHALdGawhCQEbW0=; b=JYT4IxKtdx+2TbXx/SXD xe5jx14W1hJeodhX/xsfoQiwj6Ssw5KHYp9Pv5c7XylpoNpGP1n1CDX+xOW0IdkvJO4Ytbdfr4Cvr J78Qqmnrrm/0Op2/VgvAquMMRfiscIR9n89SgnrkfXNrq72HgLwww/38vZHbaoA4ZRdG/yh+i67Hj y16EH0Y7u/odmJgEe/9afPccraRYBqm4dXyeBy6SZv7eFIXAyT+zEWbhizpoSbAK/mqpxCrjiMx2H HDD+GDkQg4W3wMPQFXenwFjzlQE2Op3vmKGiaa2gnV61GUO6c+2/XuiZjbx0jjkaSGqiBfnTL8Qax 3fg7n1UovoAgFA==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=52720 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nddk8-0000R0-80; Sun, 10 Apr 2022 16:01:05 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Arun Isaac Subject: Re: bug#54593: Do not create output file on error References: <87ee2nrd60.fsf@systemreboot.net> Date: Sun, 10 Apr 2022 22:01:02 +0200 In-Reply-To: <87ee2nrd60.fsf@systemreboot.net> (Arun Isaac's message of "Sun, 27 Mar 2022 14:21:35 +0530") Message-ID: <87k0bw6741.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54593 Cc: 54593@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Arun Isaac skribis: > Among other things, this upsets the use of skribilo in Makefiles. When a > skribilo invocation in a Makefile recipe fails, an output file is still > created, and when make is run again, the skribilo invocation is not > re-run. Indeed. Furthermore, I think the output file should be created atomically, with something like Guix=E2=80=99s =E2=80=98with-atomic-file-ou= tput=E2=80=99. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 12 15:45:19 2022 Received: (at 54593) by debbugs.gnu.org; 12 Apr 2022 19:45:19 +0000 Received: from localhost ([127.0.0.1]:50137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1neMRz-0000Cz-4K for submit@debbugs.gnu.org; Tue, 12 Apr 2022 15:45:19 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:36260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1neMRy-0000Cs-7K for 54593@debbugs.gnu.org; Tue, 12 Apr 2022 15:45:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GD70/vyVFoompS8h2zARs8/2q8l/v7+q+Bcy6AA7hbA=; b=Jo1ii+IjLkDJffB89zTlRvgh0a ekNSthrm6lQSuAhg9I5ENwZx5TbLY5Vho+QKDi8E4+oENhdLLI7tdgEo/atduvtEJsfVtepy2/VFI 38mRkKfLDgfwSomCdGViZTutmqr023bIKcpmNRr33XAOUahLexSoNiU3TL3nxVWiOFUNVlgZn+pU/ BntcAbn2SKNhUUy19Jzo61fFNnFimzA9fCb7OC8wHG5JfWf2KWJ63lGaAnPkvqEcLzVEwYt10YkqJ bvBFqCR2uWmqJTYTrGrEcnS1zipNqPRak7monNbbkdjqEIl9y+mr0FN0vetY7JhEYbiQeNAAdT7Gu kuLfM7Rw==; Received: from [192.168.2.1] (port=6868 helo=steel) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1neMRw-000An9-2c; Wed, 13 Apr 2022 01:15:16 +0530 From: Arun Isaac To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#54593: Do not create output file on error In-Reply-To: <87k0bw6741.fsf@gnu.org> References: <87ee2nrd60.fsf@systemreboot.net> <87k0bw6741.fsf@gnu.org> Date: Wed, 13 Apr 2022 01:15:15 +0530 Message-ID: <87ilre3x2s.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54593 Cc: 54593@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Furthermore, I think the output file should be created atomically, > with something like Guix=E2=80=99s =E2=80=98with-atomic-file-output=E2=80= =99. Definitely, agreed!