GNU bug report logs - #54578
[PATCH] services: Replace murmur-service-type with mumble-server-service-type.

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 54578 <at> debbugs.gnu.org
Subject: [bug#54578] [PATCH] services: Replace murmur-service-type with mumble-server-service-type.
Date: Tue, 29 Mar 2022 11:40:13 +0200

Hi,

Great job!

Liliana Marie Prikler <liliana.prikler <at> gmail.com> skribis:


[...]

> -@subsubheading Murmur (VoIP server)
> +@subsubheading Mumble server
>  
> -@cindex Murmur (VoIP server)
> +@cindex Mumble
>  @cindex VoIP server
> -This section describes how to set up and run a Murmur server.  Murmur is
> -the server of the @uref{https://mumble.info, Mumble} voice-over-IP
> -(VoIP) suite.
> +This section describes how to set up and run a
> +@uref{https://mumble.info, Mumble} server.

Perhaps you can add “formerly known as Murmur” and keep “@cindex
Murmur”?

> +(define-deprecated/alias
> +  murmur-configuration
> +  mumble-server-configuration)
> +(define-deprecated/alias
> +  make-murmur-configuration
> +  make-mumble-server-configuration)

[...]

> +(export murmur-configuration)
> +(export make-murmur-configuration)

Perhaps you can define a ‘define-public-deprecated/alias’ macro to
reduce boilerplate.

Feel free to push with changes along these lines.

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.