Subject: bug#54570: closed (Re: bug#54570: [PATCH] gnu: Add parole.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 04 Apr 2022 20:55:02 +0000

Your bug report

#54570: [PATCH] gnu: Add parole.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
54570: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54570
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#54570: [PATCH] gnu: Add parole.
From: Ludovic Courtès <[email-masked]>
To: "Feng Shu" <[email-masked]>
Cc: Maxime Devos <[email-masked]>, [email-masked]
Date: Mon, 04 Apr 2022 22:54:11 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

"Feng Shu" <[email-masked]> skribis:

>>>From 03ca3c58c8bc54cec5e12cafbc6dc65aafcbd6cc Mon Sep 17 00:00:00 2001
> From: Feng Shu <[email-masked]>
> Date: Sat, 26 Mar 2022 07:01:25 +0800
> Subject: [patch v2] gnu: Add parole.
>
> * gnu/packages/xfce.scm (parole): New variable.

I made the minor changes below mostly to placate ‘guix lint’.

Thanks!

Ludo’.

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index a4bdc38aa3..44b6c34b29 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -36,6 +36,7 @@ (define-module (gnu packages xfce)
   #:use-module (gnu artwork)
   #:use-module (gnu packages)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages bash)
   #:use-module (gnu packages calendar)
   #:use-module (gnu packages cdrom)
   #:use-module (gnu packages fonts)
@@ -926,14 +927,16 @@ (define-public parole
       #:phases
       #~(modify-phases %standard-phases
           (add-after 'install 'wrap-parole
-            (lambda _
+            (lambda* (#:key inputs #:allow-other-keys)
               (let ((gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
                 (wrap-program (string-append #$output "/bin/parole")
+                  #:sh (search-input-file inputs "bin/bash")
                   `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)))))))))
     (native-inputs
      (list pkg-config intltool gobject-introspection))
     (inputs
-     (list dbus-glib
+     (list bash-minimal                           ;for 'wrap-program'
+           dbus-glib
            (list glib "bin")
            gstreamer
            gst-plugins-base
@@ -942,10 +945,10 @@ (define-public parole
            libxfce4ui
            libxfce4util))
     (home-page "https://www.xfce.org/")
-    (synopsis "Modern simple media player based on the GStreamer framework")
+    (synopsis "Media player based on the GStreamer framework")
     (description "Parole is a modern simple media player based on the
 GStreamer framework and written to fit well in the Xfce desktop.  Parole
-features playback of local media files, DVD/CD and live streams. ")
+features playback of local media files, DVD/CD and live streams.")
     (license gpl2)))                    ;version 2 only
 
 (define-public xfce4-terminal

Subject: [PATCH] gnu: Add parole.
From: [email-masked]
To: [email-masked]
Cc: Feng Shu <[email-masked]>
Date: Sat, 26 Mar 2022 07:05:22 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

From: Feng Shu <[email-masked]>

* gnu/packages/xfce.scm (parole): New variable.
---
 gnu/packages/xfce.scm | 44 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index a2d8e99290..76f904d423 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -904,6 +904,50 @@ (define-public gigolo
 local and remote file systems and manage bookmarks of such.")
     (license gpl2)))                              ;version 2 only
 
+(define-public parole
+  (package
+    (name "parole")
+    (version "4.16.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://archive.xfce.org/src/apps/"
+                                  name "/" (version-major+minor version) "/"
+                                  name "-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "1rx7apylqb7mf1dl0sswj1630fca3ddk4x1gcdmlv5ykrkc5lc0d"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      #:configure-flags
+      #~(list (string-append "CPPFLAGS=-I"
+                             #$gst-plugins-base
+                             "/include/gstreamer-1.0"))
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'install 'wrap-parole
+            (lambda _
+              (let ((gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
+                (wrap-program (string-append #$output "/bin/parole")
+                  `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)))))))))
+    (native-inputs
+     (list pkg-config intltool gobject-introspection))
+    (inputs
+     (list dbus-glib
+           (list glib "bin")
+           gstreamer
+           gst-plugins-base
+           gst-plugins-good
+           libnotify
+           libxfce4ui
+           libxfce4util))
+    (home-page "https://www.xfce.org/")
+    (synopsis "Modern simple media player based on the GStreamer framework")
+    (description "Parole is a modern simple media player based on the
+GStreamer framework and written to fit well in the Xfce desktop.  Parole
+features playback of local media files, DVD/CD and live streams. ")
+    (license gpl2)))                    ;version 2 only
+
 (define-public xfce4-terminal
   (package
     (name "xfce4-terminal")
-- 
2.34.0