GNU bug report logs - #54564
29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Po Lu <luangruo <at> yahoo.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#54564: closed (29.0.50; [PATCH] Use gsettings font rendering
 entries for pgtk builds)
Date: Fri, 13 May 2022 12:52:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 13 May 2022 20:51:36 +0800
with message-id <87v8u9tx2f.fsf <at> yahoo.com>
and subject line Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds
has caused the debbugs.gnu.org bug report #54564,
regarding 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
54564: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54564
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Pieter van Prooijen <pieter.van.prooijen <at> teloden.nl>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds
Date: Fri, 25 Mar 2022 12:23:10 +0100

[Message part 3 (text/plain, inline)]

Hello, 

When using the pgtk build of emacs under Wayland/Ubuntu, I noticed that
the font hinting was different from the regular X (Ubuntu supplied)
version of emacs.

I have the gsettings config for font hinting set to "full" on my
system, using the fonts tab in the gnome-tweaks tool.

It looks like Cairo defaults to the "slight" hinting setting when using
the Wayland backend for display and will only use the gsettings config
when rendering to an X backend, when it reads the current font settings
from xrdb.

I've attached a patch (against
380f0443b288c68df3762ee20d78719f08dd92ff) which applies the font
entries from gsettings (if present) when creating a font in Cairo.

Note that this patch won't dynamically re-render when emacs is already
running (like it does when changing the system font).
I made an attempt to hook into the gsettings change callback, but could
not force a re-creation of the font with the changed parameters,for
instance using a 'font-render' config changed event. Any pointers on
how to achieve this?
 
Do you think if this patch is a good approach to get the pgtk build to
use the system preferences for font hinting and anti-aliasing?

Kind Regards,

Pieter van Prooijen
    

[0001-Use-gsettings-font-rendering-entries-for-pgtk-builds.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Po Lu <luangruo <at> yahoo.com>
To: Pieter van Prooijen <pieter.van.prooijen <at> teloden.nl>
Cc: 54564-done <at> debbugs.gnu.org
Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering
 entries for pgtk builds
Date: Fri, 13 May 2022 20:51:36 +0800

Pieter van Prooijen <pieter.van.prooijen <at> teloden.nl> writes:

> Hello All,
>
> The copyright assignment paperwork came through, is it possible to
> incorporate the gsetting font rendering changes? I've attached a patch
> against the current master, let me know if I need to change anything.

Thank you.  I will install this shortly and am closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.