From unknown Fri Jun 20 07:11:27 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#54564 <54564@debbugs.gnu.org> To: bug#54564 <54564@debbugs.gnu.org> Subject: Status: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds Reply-To: bug#54564 <54564@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:11:27 +0000 retitle 54564 29.0.50; [PATCH] Use gsettings font rendering entries for pgt= k builds reassign 54564 emacs submitter 54564 Pieter van Prooijen severity 54564 normal tag 54564 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 25 10:09:20 2022 Received: (at submit) by debbugs.gnu.org; 25 Mar 2022 14:09:20 +0000 Received: from localhost ([127.0.0.1]:51964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXkcx-00032Z-Fm for submit@debbugs.gnu.org; Fri, 25 Mar 2022 10:09:20 -0400 Received: from lists.gnu.org ([209.51.188.17]:59644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXi2I-0004iw-6G for submit@debbugs.gnu.org; Fri, 25 Mar 2022 07:23:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXi2H-00063c-VZ for bug-gnu-emacs@gnu.org; Fri, 25 Mar 2022 07:23:18 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:46141) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXi2F-0006VF-Il for bug-gnu-emacs@gnu.org; Fri, 25 Mar 2022 07:23:17 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id DEF055C01F9 for ; Fri, 25 Mar 2022 07:23:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 25 Mar 2022 07:23:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=teloden.nl; h=cc :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm3; bh=q 88eTcWWEPlsZWCyuFYUdSO7Mjf2CuNTg70ISM61JJs=; b=ilF1ncUJbNHtBt2xe 0T0Z8w/70hj47SrX0MHFVpByQmyRNm0WqdbYhmq6+SpLknbPlOW5/lXf84/Y2xPv iaWbVs08cTy2l2cX+s+wwyP5xBPAuam8S1Sggbbir1l825K9TpTS0c0gTaKVmiPl ByJiIHLn+EV0C1ToERq+mmBY9molxdseLNP6KhPTnaIga/mhrp38kWfEyu/vcGfN CacNz75jyiOlm2EEGd7GZdydGStdZF/xnRe2hBtoJXVAI/deS3hWiwHJtZaoSobQ ficReBf/c75MJu1Z28Dg85bvlzGbTIIONVoLgIeworgr0E1GI69MlO9XnChssv4e Xk9Jw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=q88eTcWWEPlsZWCyuFYUdSO7Mjf2CuNTg70ISM61J Js=; b=j75ElZbbO6hMdPWWujJHzfh7rzDqCXh9o2XMyMcH8REaKeXbf2tO/Q9LV GozyK5UCD0lragoeIf72akHIaix3peDSlLWVSmn1/HF8eEcDTM0bEpemyY9I5PZ4 u2Vy1m4FKj3gUKqRcNW8hUZMOjJLKWLY/UWDmD1Qxhqwuzl6ytyn4P+4PTHBOHXM z2wK7WCytJzhzK0xmuc4OHUxBcPponnVNM52IGvm4iBKGz2NrANgG3fXETytq7TR PztEVvHeLZDmHrDBEmFSGqT8yrwgsla9R8yhUSFDUL5nGowJt4H3gESBuAh5AwfL k5GlQtURZPuhMLZYQueVGNOs2fzvA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudehuddgvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkuffhvffftggfggesmhdtreertd erjeenucfhrhhomheprfhivghtvghruchvrghnucfrrhhoohhijhgvnhcuoehpihgvthgv rhdrvhgrnhdrphhrohhoihhjvghnsehtvghlohguvghnrdhnlheqnecuggftrfgrthhtvg hrnheptdehvefffeeiffeuhfettddugfeiuefftedtjeffffeggeejgeeivefgtdeutdek necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphhivg htvghrrdhvrghnrdhprhhoohhijhgvnhesthgvlhhouggvnhdrnhhl X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Fri, 25 Mar 2022 07:23:12 -0400 (EDT) Message-ID: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> Subject: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds From: Pieter van Prooijen To: bug-gnu-emacs@gnu.org Date: Fri, 25 Mar 2022 12:23:10 +0100 Content-Type: multipart/mixed; boundary="=-TauzUyoYTQYzDBBn31OT" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 Received-SPF: pass client-ip=66.111.4.27; envelope-from=pieter.van.prooijen@teloden.nl; helo=out3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 25 Mar 2022 10:09:18 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) --=-TauzUyoYTQYzDBBn31OT Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Hello,  When using the pgtk build of emacs under Wayland/Ubuntu, I noticed that the font hinting was different from the regular X (Ubuntu supplied) version of emacs. I have the gsettings config for font hinting set to "full" on my system, using the fonts tab in the gnome-tweaks tool. It looks like Cairo defaults to the "slight" hinting setting when using the Wayland backend for display and will only use the gsettings config when rendering to an X backend, when it reads the current font settings from xrdb. I've attached a patch (against 380f0443b288c68df3762ee20d78719f08dd92ff) which applies the font entries from gsettings (if present) when creating a font in Cairo. Note that this patch won't dynamically re-render when emacs is already running (like it does when changing the system font). I made an attempt to hook into the gsettings change callback, but could not force a re-creation of the font with the changed parameters,for instance using a 'font-render' config changed event. Any pointers on how to achieve this?   Do you think if this patch is a good approach to get the pgtk build to use the system preferences for font hinting and anti-aliasing? Kind Regards, Pieter van Prooijen      --=-TauzUyoYTQYzDBBn31OT Content-Disposition: attachment; filename*0=0001-Use-gsettings-font-rendering-entries-for-pgtk-builds.pat; filename*1=ch Content-Type: text/x-patch; name="0001-Use-gsettings-font-rendering-entries-for-pgtk-builds.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSA2ZmU4ODhlN2MxNGVmNWFhZDEyNGMwZDY4ZmNkMDcxY2Q1YjY1ZTgxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaWV0ZXIgdmFuIFByb29pamVuIDxwaWV0ZXIudmFuLnByb29p amVuQHRlbG9kZW4ubmw+CkRhdGU6IEZyaSwgMjUgTWFyIDIwMjIgMTE6NDc6MzkgKzAxMDAKU3Vi amVjdDogW1BBVENIXSBVc2UgZ3NldHRpbmdzIGZvbnQgcmVuZGVyaW5nIGVudHJpZXMgZm9yIHBn dGsgYnVpbGRzCgpJZiBwcmVzZW50LCBhcHBseSB0aGUgZ3NldHRpbmdzIGZvbnQgaGludGluZyBh bmQgYW50aWFsaWFzaW5nIGVudHJpZXMKd2hlbiBjcmVhdGluZyBhIGZvbnQgaW4gY2Fpcm8uCiog c3JjL3hzZXR0aW5ncy5jLCBzcmMveHNldHRpbmdzLmg6IHJlYWQgYW5kIGFwcGx5IGdzZXR0aW5n IGVudHJpZXMuCiogc3JjL2Z0Y3Jmb250LmM6IHVzZSB0aGUgZm9udF9vcHRpb25zIGZyb20geHNl dHRpbmdzLmMgd2hlbiBjcmVhdGluZyBhIGZvbnQuCi0tLQogc3JjL2Z0Y3Jmb250LmMgIHwgICA2 ICsrLQogc3JjL3hzZXR0aW5ncy5jIHwgMTE4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKwogc3JjL3hzZXR0aW5ncy5oIHwgICA1ICstCiAzIGZpbGVzIGNo YW5nZWQsIDEyNyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3Ny Yy9mdGNyZm9udC5jIGIvc3JjL2Z0Y3Jmb250LmMKaW5kZXggOThhMjhhZjVmMi4uYjY1OTAyNDUy NCAxMDA2NDQKLS0tIGEvc3JjL2Z0Y3Jmb250LmMKKysrIGIvc3JjL2Z0Y3Jmb250LmMKQEAgLTM3 LDYgKzM3LDcgQEAKICNpbmNsdWRlICJmb250LmgiCiAjaW5jbHVkZSAiZnRmb250LmgiCiAjaW5j bHVkZSAicGR1bXBlci5oIgorI2luY2x1ZGUgInhzZXR0aW5ncy5oIgogCiAjaWZkZWYgVVNFX0JF X0NBSVJPCiAjZGVmaW5lIFJFRF9GUk9NX1VMT05HKGNvbG9yKQkoKChjb2xvcikgPj4gMTYpICYg MHhmZikKQEAgLTE2OCwxMCArMTY5LDEzIEBAIGZ0Y3Jmb250X29wZW4gKHN0cnVjdCBmcmFtZSAq ZiwgTGlzcF9PYmplY3QgZW50aXR5LCBpbnQgcGl4ZWxfc2l6ZSkKICAgY2Fpcm9fbWF0cml4X3Qg Zm9udF9tYXRyaXgsIGN0bTsKICAgY2Fpcm9fbWF0cml4X2luaXRfc2NhbGUgKCZmb250X21hdHJp eCwgcGl4ZWxfc2l6ZSwgcGl4ZWxfc2l6ZSk7CiAgIGNhaXJvX21hdHJpeF9pbml0X2lkZW50aXR5 ICgmY3RtKTsKLSAgY2Fpcm9fZm9udF9vcHRpb25zX3QgKm9wdGlvbnMgPSBjYWlyb19mb250X29w dGlvbnNfY3JlYXRlICgpOworCiAjaWZkZWYgVVNFX0JFX0NBSVJPCisgIGNhaXJvX2ZvbnRfb3B0 aW9uc190ICpvcHRpb25zID0gY2Fpcm9fZm9udF9vcHRpb25zX2NyZWF0ZSgpOwogICBpZiAoYmVf dXNlX3N1YnBpeGVsX2FudGlhbGlhc2luZyAoKSkKICAgICBjYWlyb19mb250X29wdGlvbnNfc2V0 X2FudGlhbGlhcyAob3B0aW9ucywgQ0FJUk9fQU5USUFMSUFTX1NVQlBJWEVMKTsKKyNlbHNlCisg IGNhaXJvX2ZvbnRfb3B0aW9uc190ICpvcHRpb25zID0geHNldHRpbmdzX2dldF9mb250X29wdGlv bnMoKTsKICNlbmRpZgogICBjYWlyb19zY2FsZWRfZm9udF90ICpzY2FsZWRfZm9udAogICAgID0g Y2Fpcm9fc2NhbGVkX2ZvbnRfY3JlYXRlIChmb250X2ZhY2UsICZmb250X21hdHJpeCwgJmN0bSwg b3B0aW9ucyk7CmRpZmYgLS1naXQgYS9zcmMveHNldHRpbmdzLmMgYi9zcmMveHNldHRpbmdzLmMK aW5kZXggNzFkMDJlNjE1Mi4uYzcyZDU5ZTk5YiAxMDA2NDQKLS0tIGEvc3JjL3hzZXR0aW5ncy5j CisrKyBiL3NyYy94c2V0dGluZ3MuYwpAQCAtNTcsNiArNTcsNyBAQCBDb3B5cmlnaHQgKEMpIDIw MDktMjAyMiBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4KICNpZiBkZWZpbmVkIFVTRV9D QUlSTyB8fCBkZWZpbmVkIEhBVkVfWEZUCiAjaWZkZWYgVVNFX0NBSVJPCiAjaW5jbHVkZSA8Zm9u dGNvbmZpZy9mb250Y29uZmlnLmg+CisjaW5jbHVkZSA8Y2Fpcm8uaD4KICNlbHNlICAvKiBIQVZF X1hGVCAqLwogI2luY2x1ZGUgPFgxMS9YZnQvWGZ0Lmg+CiAjZW5kaWYKQEAgLTY3LDYgKzY4LDEw IEBAIENvcHlyaWdodCAoQykgMjAwOS0yMDIyIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5j Lgogc3RhdGljIERpc3BsYXlfSW5mbyAqZmlyc3RfZHB5aW5mbzsKIHN0YXRpYyBMaXNwX09iamVj dCBjdXJyZW50X3Rvb2xfYmFyX3N0eWxlOwogCisjaWZkZWYgVVNFX0NBSVJPCitzdGF0aWMgY2Fp cm9fZm9udF9vcHRpb25zX3QgKmZvbnRfb3B0aW9uczsKKyNlbmRpZgorCiAvKiBTdG9yZSBhIGNv bmZpZyBjaGFuZ2VkIGV2ZW50IGluIHRvIHRoZSBldmVudCBxdWV1ZS4gICovCiAKIHN0YXRpYyB2 b2lkCkBAIC0yMTUsMTEgKzIyMCw5NiBAQCAjZGVmaW5lIEdTRVRUSU5HU19NT05PX0ZPTlQgICJt b25vc3BhY2UtZm9udC1uYW1lIgogI2RlZmluZSBHU0VUVElOR1NfRk9OVF9OQU1FICAiZm9udC1u YW1lIgogI2VuZGlmCiAKKyNpZmRlZiBIQVZFX1BHVEsKKyNkZWZpbmUgR1NFVFRJTkdTX0ZPTlRf QU5USUFMSUFTSU5HICJmb250LWFudGlhbGlhc2luZyIKKyNkZWZpbmUgR1NFVFRJTkdTX0ZPTlRf UkdCQV9PUkRFUiAgICJmb250LXJnYmEtb3JkZXIiCisjZGVmaW5lIEdTRVRUSU5HU19GT05UX0hJ TlRJTkcgICAgICAiZm9udC1oaW50aW5nIgorI2VuZGlmCiAKIC8qIFRoZSBzaW5nbGUgR1NldHRp bmdzIGluc3RhbmNlLCBvciBOVUxMIGlmIG5vdCBjb25uZWN0ZWQgdG8gR1NldHRpbmdzLiAgKi8K IAogc3RhdGljIEdTZXR0aW5ncyAqZ3NldHRpbmdzX2NsaWVudDsKIAorLyogRm9yIGhpbnRpbmcg YW5kIGFudGlhbGlhcyBubyBkeW5hbWljIHJlLWRpc3BsYXkgaXMgKHlldCkgcG9zc2libGUsCisg ICBiZWNhdXNlIGNhaXJvIGFwcGxpZXMgdGhlc2Ugb3B0aW9ucyB3aGVuIGNyZWF0aW5nIHRoZSBm b250LCBub3Qgd2hlbgorICAgcmVuZGVyaW5nIGl0LgorKi8KKworI2lmZGVmIEhBVkVfUEdUSwor LyogQXBwbHkgY2hhbmdlcyBpbiB0aGUgaGludGluZyBzeXN0ZW0gc2V0dGluZyAqLworc3RhdGlj IHZvaWQKK2FwcGx5X2dzZXR0aW5nc19mb250X2hpbnRpbmcoR1NldHRpbmdzICpzZXR0aW5ncykK K3sKKyAgR1ZhcmlhbnQgKnZhbCA9IGdfc2V0dGluZ3NfZ2V0X3ZhbHVlIChzZXR0aW5ncywgR1NF VFRJTkdTX0ZPTlRfSElOVElORyk7CisgIGlmICh2YWwpCisgICAgeworICAgICAgZ192YXJpYW50 X3JlZl9zaW5rICh2YWwpOworICAgICAgaWYgKGdfdmFyaWFudF9pc19vZl90eXBlICh2YWwsIEdf VkFSSUFOVF9UWVBFX1NUUklORykpCisJeworCSAgY29uc3QgY2hhciAqaGludGluZyA9IGdfdmFy aWFudF9nZXRfc3RyaW5nICh2YWwsIE5VTEwpOworCisJICBpZiAoc3RyY21wIChoaW50aW5nLCAi ZnVsbCIpID09IDApCisJICAgIGNhaXJvX2ZvbnRfb3B0aW9uc19zZXRfaGludF9zdHlsZShmb250 X29wdGlvbnMsIENBSVJPX0hJTlRfU1RZTEVfRlVMTCk7CisJICBlbHNlIGlmIChzdHJjbXAgKGhp bnRpbmcsICJtZWRpdW0iKSA9PSAwKQorCSAgICBjYWlyb19mb250X29wdGlvbnNfc2V0X2hpbnRf c3R5bGUoZm9udF9vcHRpb25zLCBDQUlST19ISU5UX1NUWUxFX01FRElVTSk7CisJICBlbHNlIGlm IChzdHJjbXAgKGhpbnRpbmcsICJzbGlnaHQiKSA9PSAwKQorCSAgICBjYWlyb19mb250X29wdGlv bnNfc2V0X2hpbnRfc3R5bGUoZm9udF9vcHRpb25zLCBDQUlST19ISU5UX1NUWUxFX1NMSUdIVCk7 CisJICBlbHNlIGlmIChzdHJjbXAgKGhpbnRpbmcsICJub25lIikgPT0gMCkKKwkgICAgY2Fpcm9f Zm9udF9vcHRpb25zX3NldF9oaW50X3N0eWxlKGZvbnRfb3B0aW9ucywgQ0FJUk9fSElOVF9TVFlM RV9OT05FKTsKKwl9CisgICAgICBnX3ZhcmlhbnRfdW5yZWYgKHZhbCk7CisgICAgfQorfQorCisv KiBBcHBseSBjaGFuZ2VzIGluIHRoZSBhbnRpYWxpYXNpbmcgc3lzdGVtIHNldHRpbmcgKi8KK3N0 YXRpYyB2b2lkCithcHBseV9nc2V0dGluZ3NfZm9udF9hbnRpYWxpYXMoR1NldHRpbmdzICpzZXR0 aW5ncykKK3sKKyAgR1ZhcmlhbnQgKnZhbCA9IGdfc2V0dGluZ3NfZ2V0X3ZhbHVlIChzZXR0aW5n cywgR1NFVFRJTkdTX0ZPTlRfQU5USUFMSUFTSU5HKTsKKyAgaWYgKHZhbCkKKyAgICB7CisgICAg ICBnX3ZhcmlhbnRfcmVmX3NpbmsgKHZhbCk7CisgICAgICBpZiAoZ192YXJpYW50X2lzX29mX3R5 cGUgKHZhbCwgR19WQVJJQU5UX1RZUEVfU1RSSU5HKSkKKwl7CisJICBjb25zdCBjaGFyICphbnRp YWxpYXMgPSBnX3ZhcmlhbnRfZ2V0X3N0cmluZyAodmFsLCBOVUxMKTsKKworCSAgaWYgKHN0cmNt cCAoYW50aWFsaWFzLCAibm9uZSIpID09IDApCisJICAgIGNhaXJvX2ZvbnRfb3B0aW9uc19zZXRf YW50aWFsaWFzKGZvbnRfb3B0aW9ucywgQ0FJUk9fQU5USUFMSUFTX05PTkUpOworCSAgZWxzZSBp ZiAoc3RyY21wKGFudGlhbGlhcywgImdyYXlzY2FsZSIpID09IDApCisJICAgIGNhaXJvX2ZvbnRf b3B0aW9uc19zZXRfYW50aWFsaWFzKGZvbnRfb3B0aW9ucywgQ0FJUk9fQU5USUFMSUFTX0dSQVkp OworCSAgZWxzZSBpZiAoc3RyY21wKGFudGlhbGlhcywgInJnYmEiKSA9PSAwKQorCSAgICBjYWly b19mb250X29wdGlvbnNfc2V0X2FudGlhbGlhcyhmb250X29wdGlvbnMsIENBSVJPX0FOVElBTElB U19TVUJQSVhFTCk7CisJfQorICAgICAgZ192YXJpYW50X3VucmVmICh2YWwpOworICAgIH0KK30K KworLyogQXBwbHkgdGhlIHNldHRpbmdzIGZvciB0aGUgcmdiIGVsZW1lbnQgb3JkZXJpbmcgKi8K K3N0YXRpYyB2b2lkCithcHBseV9nc2V0dGluZ3NfZm9udF9yZ2JhX29yZGVyKEdTZXR0aW5ncyAq c2V0dGluZ3MpCit7CisgIEdWYXJpYW50ICp2YWwgPSBnX3NldHRpbmdzX2dldF92YWx1ZSAoc2V0 dGluZ3MsIEdTRVRUSU5HU19GT05UX1JHQkFfT1JERVIpOworICBpZiAodmFsKQorICAgIHsKKyAg ICAgIGdfdmFyaWFudF9yZWZfc2luayAodmFsKTsKKyAgICAgIGlmIChnX3ZhcmlhbnRfaXNfb2Zf dHlwZSAodmFsLCBHX1ZBUklBTlRfVFlQRV9TVFJJTkcpKQorCXsKKwkgIGNvbnN0IGNoYXIgKnJn YmFfb3JkZXIgPSBnX3ZhcmlhbnRfZ2V0X3N0cmluZyAodmFsLCBOVUxMKTsKKworCSAgaWYgKHN0 cmNtcCAocmdiYV9vcmRlciwgInJnYiIpID09IDApCisJICAgIGNhaXJvX2ZvbnRfb3B0aW9uc19z ZXRfc3VicGl4ZWxfb3JkZXIoZm9udF9vcHRpb25zLCBDQUlST19TVUJQSVhFTF9PUkRFUl9SR0Ip OworCSAgZWxzZSBpZiAoc3RyY21wIChyZ2JhX29yZGVyLCAiYmdyIikgPT0gMCkKKwkgICAgY2Fp cm9fZm9udF9vcHRpb25zX3NldF9zdWJwaXhlbF9vcmRlcihmb250X29wdGlvbnMsIENBSVJPX1NV QlBJWEVMX09SREVSX0JHUik7CisJICBlbHNlIGlmIChzdHJjbXAgKHJnYmFfb3JkZXIsICJ2cmdi IikgPT0gMCkKKwkgICAgY2Fpcm9fZm9udF9vcHRpb25zX3NldF9zdWJwaXhlbF9vcmRlcihmb250 X29wdGlvbnMsIENBSVJPX1NVQlBJWEVMX09SREVSX1ZSR0IpOworCSAgZWxzZSBpZiAoc3RyY21w IChyZ2JhX29yZGVyLCAidmJnciIpID09IDApCisJICAgIGNhaXJvX2ZvbnRfb3B0aW9uc19zZXRf c3VicGl4ZWxfb3JkZXIoZm9udF9vcHRpb25zLCBDQUlST19TVUJQSVhFTF9PUkRFUl9WQkdSKTsK Kwl9CisgICAgICBnX3ZhcmlhbnRfdW5yZWYgKHZhbCk7CisgICAgfQorfQorI2VuZGlmIC8qIEhB VkVfUEdUSyAqLworCiAvKiBDYWxsYmFjayBjYWxsZWQgd2hlbiBzb21ldGhpbmcgY2hhbmdlZCBp biBHU2V0dGluZ3MuICAqLwogCiBzdGF0aWMgdm9pZApAQCAtOTAwLDYgKzk5MCwxOCBAQCBpbml0 X2dzZXR0aW5ncyAodm9pZCkKICAgICAgICAgZHVwc3RyaW5nICgmY3VycmVudF9mb250LCBnX3Zh cmlhbnRfZ2V0X3N0cmluZyAodmFsLCBOVUxMKSk7CiAgICAgICBnX3ZhcmlhbnRfdW5yZWYgKHZh bCk7CiAgICAgfQorCisgIC8qIE9ubHkgdXNlIHRoZSBnc2V0dGluZ3MgZm9udCBlbnRyaWVzIGZv ciBub24tWCBjYWlybyBiYWNrZW5kcworICAgICAod2hpY2ggaXMgdGhlIHJlY29tbWVuZGVkIHdh eSBvZiBydW5uaW5nIHBndGsgYnVpbGRzKS4KKyAgICAgRm9yIHRoZSBYIGJhY2tlbmQgY2Fpcm8g d2lsbCBhcHBseSB0aGVzZSBlbnRyaWVzIGl0c2VsZiwKKyAgICAgcmVhZGluZyB0aGVtIGZyb20g eHJkYi4gKi8KKyNpZmRlZiBIQVZFX1BHVEsKKyAgZm9udF9vcHRpb25zID0gY2Fpcm9fZm9udF9v cHRpb25zX2NyZWF0ZSAoKTsKKyAgYXBwbHlfZ3NldHRpbmdzX2ZvbnRfYW50aWFsaWFzKGdzZXR0 aW5nc19jbGllbnQpOworICBhcHBseV9nc2V0dGluZ3NfZm9udF9oaW50aW5nKGdzZXR0aW5nc19j bGllbnQpOworICBhcHBseV9nc2V0dGluZ3NfZm9udF9yZ2JhX29yZGVyKGdzZXR0aW5nc19jbGll bnQpOworI2VuZGlmIC8qIEhBVkVfUEdUSyAqLworCiAjZW5kaWYgLyogVVNFX0NBSVJPIHx8IEhB VkVfWEZUICovCiAKICNlbmRpZiAvKiBIQVZFX0dTRVRUSU5HUyAqLwpAQCAtMTAyMSw2ICsxMTIz LDE4IEBAIHhzZXR0aW5nc19nZXRfc3lzdGVtX25vcm1hbF9mb250ICh2b2lkKQogfQogI2VuZGlm CiAKKyNpZmRlZiBVU0VfQ0FJUk8KKy8qIFJldHVybiB0aGUgY2Fpcm8gZm9udCBvcHRpb25zLCBw b3NzaWJseSBpbml0aWFsaXplZCBpbgorICAgaW5pdF9nc2V0dGluZ3MoKSAqLworY2Fpcm9fZm9u dF9vcHRpb25zX3QgKgoreHNldHRpbmdzX2dldF9mb250X29wdGlvbnMgKHZvaWQpIHsKKyAgaWYg KGZvbnRfb3B0aW9ucyA9PSBOVUxMKQorICAgIHJldHVybiBjYWlyb19mb250X29wdGlvbnNfY3Jl YXRlKCk7CisgIGVsc2UKKyAgICByZXR1cm4gY2Fpcm9fZm9udF9vcHRpb25zX2NvcHkoZm9udF9v cHRpb25zKTsKK30KKyNlbmRpZgorCiBERUZVTiAoImZvbnQtZ2V0LXN5c3RlbS1ub3JtYWwtZm9u dCIsIEZmb250X2dldF9zeXN0ZW1fbm9ybWFsX2ZvbnQsCiAgICAgICAgU2ZvbnRfZ2V0X3N5c3Rl bV9ub3JtYWxfZm9udCwKICAgICAgICAwLCAwLCAwLApAQCAtMTA3Myw2ICsxMTg3LDEwIEBAIHN5 bXNfb2ZfeHNldHRpbmdzICh2b2lkKQogICBnY29uZl9jbGllbnQgPSBOVUxMOwogICBQRFVNUEVS X0lHTk9SRSAoZ2NvbmZfY2xpZW50KTsKICNlbmRpZgorI2lmZGVmIFVTRV9DQUlSTworICBmb250 X29wdGlvbnMgPSBOVUxMOworICBQRFVNUEVSX0lHTk9SRSAoZm9udF9vcHRpb25zKTsKKyNlbmRp ZgogCiAgIERFRlNZTSAoUW1vbm9zcGFjZV9mb250X25hbWUsICJtb25vc3BhY2UtZm9udC1uYW1l Iik7CiAgIERFRlNZTSAoUWZvbnRfbmFtZSwgImZvbnQtbmFtZSIpOwpkaWZmIC0tZ2l0IGEvc3Jj L3hzZXR0aW5ncy5oIGIvc3JjL3hzZXR0aW5ncy5oCmluZGV4IGNjYWEzNjQ4OWQuLjE1OTg0ZTg4 NjUgMTAwNjQ0Ci0tLSBhL3NyYy94c2V0dGluZ3MuaAorKysgYi9zcmMveHNldHRpbmdzLmgKQEAg LTQwLDYgKzQwLDkgQEAgI2RlZmluZSBYU0VUVElOR1NfSAogI2lmZGVmIFVTRV9MVUNJRAogZXh0 ZXJuIGNvbnN0IGNoYXIgKnhzZXR0aW5nc19nZXRfc3lzdGVtX25vcm1hbF9mb250ICh2b2lkKTsK ICNlbmRpZgotCisjaWZkZWYgVVNFX0NBSVJPCitzdHJ1Y3QgY2Fpcm9fZm9udF9vcHRpb25zX3Q7 CitleHRlcm4gY2Fpcm9fZm9udF9vcHRpb25zX3QgKnhzZXR0aW5nc19nZXRfZm9udF9vcHRpb25z ICh2b2lkKTsKKyNlbmRpZgogCiAjZW5kaWYgLyogWFNFVFRJTkdTX0ggKi8KLS0gCjIuMzIuMAoK --=-TauzUyoYTQYzDBBn31OT-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 25 10:18:37 2022 Received: (at control) by debbugs.gnu.org; 25 Mar 2022 14:18:38 +0000 Received: from localhost ([127.0.0.1]:52138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXklx-0005ck-O8 for submit@debbugs.gnu.org; Fri, 25 Mar 2022 10:18:37 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXklv-0005cW-Sc for control@debbugs.gnu.org; Fri, 25 Mar 2022 10:18:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3dHmOTCE8EGaj6D7cUxicR3eL5cdkGu3mpy43js3RvU=; b=M5ceFn8xQC4mt7NhAV1IUuqVhX BcvGmQ1ICrR2toLbHyqbxk+mNYfXIR7/75QoQqIWP/ThZN0T5SfLUOY69S3AI8KEKYU8Lnc+pvNDY MhZLaiCSMMRgDxTfrIJwtVKVDb1DgteAERJb0aBksmgf/sb74mu1Ra7zQInQLyrAtVsM=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXkln-0003cj-Pu for control@debbugs.gnu.org; Fri, 25 Mar 2022 15:18:29 +0100 Date: Fri, 25 Mar 2022 15:18:27 +0100 Message-Id: <87cziaf74c.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #54565 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: forcemerge 54565 54564 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) forcemerge 54565 54564 quit From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 25 21:16:25 2022 Received: (at 54564) by debbugs.gnu.org; 26 Mar 2022 01:16:25 +0000 Received: from localhost ([127.0.0.1]:52784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXv2W-0001LS-HH for submit@debbugs.gnu.org; Fri, 25 Mar 2022 21:16:25 -0400 Received: from sonic303-22.consmr.mail.ne1.yahoo.com ([66.163.188.148]:38171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXv2T-0001LC-SG for 54564@debbugs.gnu.org; Fri, 25 Mar 2022 21:16:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648257375; bh=6vHW+W3yZekilwKZsmuyuXiif+Bulotyxfbuu8BBhfs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=apABF9E2adFqzh9n688v6DvPPzI+Z9tBTTz/mjCwQwt+fAWxjy+mAlw9Ps/nkMYn+Rhp4sXgFKC+DSWAbuOMdkCxM5bfONMYFSE7KUVzyzUHEUAr5IEQO7DEfYfKVW2iWi+DNXoM7VnKZibVNu2TkF0YNNcQ1UkotOW0V3cVS+Vz61+oDThd1p5XdObV+EYEVcpJ5PY3Ds6Xva0Q9DGSAmLQY4+SDEViwRRRYNCkVb2V0XGHoUKLUByjSoEwm9FPveyjF7fhYYHGMNgIF737nYFnucD5FcMO20cm87kzXwiEw0UPxaAxHKajBFl10EdnNHGozMyuyTz0Vzv888T+uw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648257375; bh=bx1F90PaboPJigRcXx3kTHni8JCu+k0zEtu1TeEx/LR=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=uJQrIbj/eCNbY2CZE/6S6VyMWGq5/rVe4DvqpKAnvozJ20s3U6aJ9g7D8HGXibyIaRpw/jnv9h4hpEQdkJ4wVw6obUtZ6aUBEXwCojFNCEb6xYqGQpXin5W3mMlhXNX6tD+x9p0V2MF7zCxOLia1Shui6K80jK6qoz0dy2DthfcIEM+QAkF471sVTsBgW26DEPeXIL79Ae+BXlml+OvpinNqXhvjVLuD/Dv7l4VLPqaAbwRM5T96FTlIKXPtZmf9Soz4UW1UkbP9ujowvKeZKz/Dy3KxGf4ZwXFtb5qKC3Ua+dP5pz3fuCGE7fM0QWpQSr36lfgjPFQ24NtgvwjEgA== X-YMail-OSG: 6GrtUWQVM1nh8iaftx3YdzHYMJ7rENqfNDU.BUrs4y.7Gr7Gp.KjRrP06OQNNWA WytEZ0tafF3mwLfhmDOAU5GZG0z38yBeouSYmO4oEKCheJing_IXgGPwg6AqEZi2OTuQ2qwK1ilS EWJouo4UPW8X6oRJTmZ7i_nOQ1OLrSqhVRlkDWz4lBt.I1qUWE1FZfHKPRZ.9yZ4zUklON4aHZXB yaGPsg56MplytC3PbTR2SyuDDEqAs7IAXjBuRAFYzaTE2wTDpvkIrViKipXD4k01RrFuG3nlhr16 K8dcqHyZbXwCt82O70xX1I5lD.Lt1yvXH489PdUUkIjCMUmeWHXUiiYTKJFIl70F_U0nqYTtd3Dv ZXzoWAPDbb7jKcnH6lCQdKExICEOM.7NakjiTqM.MuvL95ih1b8u7VrrhaJvxigz6GnOG69ONuIX CYJ0KqNO3I.wFcpQz8J27kAwq3qG39pQKLBr8twWpILcWVsHNa2xlrUB4vmNM3IhdJhWk.Od5uu1 brucULATV3Rd2HXya8plZDKyR61_wZo6FbMRh8M8184cMFqjZR0WwXOE1oYqgVG086bLt19GLgld zGnm3QNAvzsDaJbTnJJb5v.XY9ZLXxHDp2b3h0wW70B_eVp9wc2QOz.1y3yoAxYkcQePDAf9CM9Z tUATCyN1QhG8op67wDSCFpTFAnUKahmLhWgyi3yPqsHzQH7dpu4.dhlid6OZexQNrS1RAqsQ4KjI Y_w8vxGajfB4D_bwIeoily_K6uUo1jUn50DIzx6WylzsQhvKHxDjJh8S50eWcxp.lvur4VOiVGEn eUa6pCagYmgir8V9vAJUxoTLmBK0uom.NUoGHFg2RED_VT3AwkKHg7LcZtDq.fd3D5FBlN37HVE8 1vPDD_1IdA_OtAifmoU1KTtqQ1YID2nMOEzPADAMhEF9YcdPUg4Chjh0QHz453FwNkOqipmPqud1 U1zCMYqnxjEX4cRpK7Zj__5T0_GLQxtFSJPROkplIIQAod.YjPtWCrZD.vvyoxvLY2YHuzjzasno bJGsqSX8r9Ez1qk_DLsLEM46WfaXlgmOmzBMPbAS6oUsszxa_L.8f.rDqe0pP0Whk1dS8rPRwjHR TBNfK4sqDG3sCP03i7w4CoA4z37BOtCFoKwZvrJfP931efJi1_qGVkOdvGwzWTnKgLyQlATJ7Og3 qlnjoKTnT2d9lqJQyJOeWAyq6hWYHG7td6ZNlsDNNdobmg0XyD9XbTu.a4Fk7veoJPjvOryeP_kc Xk6JZtlHIDDF0_OB4rf06lyvKpfaFbUvhPlgjGwsQeHh3FJZciMsU57Zn03S5tdLUnfU8JZ4ylHE 0U8Ih50obQ0jUzQkSWYW6BRuaRe5Ap1_3jpiSn8301hF9dtiMVz86SRsb8rE5xwXyoFkS6bbSxAq kbu_JkwScGE_qNN5.HxMlaARUd0CEJtJefcFEHoXuI9N4K5gVzyzIni9ohdZKYmn2V0rs1HEUfmr 4UHCd4Z4PlwWmQilQ3zc8xkQrCq9gbW8Wf1MqNNweuzhINByOm0z4s96QvS1E8_INrESfdEGimL9 HvpTlV5eNQFa1x2MjyL.xzNGfmi_1pCVTTE1qYIq07dw8odU6oPA.f4_VF4eh5jSg.ME_alWNbGB ypw45gEGXjn8AybBdej2j9i6SOKdqU3zsXpf8Kg8B17S5DWcbOb_Z5RriaZoMjOq_aGN_wxI6Xkj v8UgRYJh2w9SVs3RqSqQqsffwOHxUEjUwhP6fzA1GC2t9.oClla4U8wUZ5jW78XBkpYXPkLq1KOz UCBqEftcSpiHi.busICzT44ujsgDXFb8SVvdoODCBQ6ed9u9Tm2Bnit48XFaj7C89PhdlnsfYD3I EwxZk3T873XKLPa0vtMPM2ZWRdzBQmBgryVe4oncexkXyCh3yyekNkvegPh93A76XJcO0CvFtPjR d8p_QE7gWYEc.z1tuaEePUvHIOdGvb3S71QIWebTt8_xGwEc2HFMbh.mZGzxkNjhvhVJpEkq0OIb srixvaDLCNQjPCmhQprXmKOe.CqSE9pi6ztjN7pxxsuOqdhrY0vCEK772UsTsZbeK_fQSfwIDQ0g CpchWzcLPiUDDEG8sBQ0esgKQ04bmTyyJcvsirph95ZUIc5pdnYYfd_z7cyRrYXyStWlnQTutfW_ xQlFsfHZMzOWD4pEa6nh5pVvunXDFuDOzZF7BFV0HQa.rpn2yzcbA_MqVi8xh7fvOGZFxPQQrdda VtMheEKfq7xW4dNcK62zgoc29JmxhSkKpJk2BFGxnWgqVbtSVH.MvlEOqXIuvCXITQrDv X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ne1.yahoo.com with HTTP; Sat, 26 Mar 2022 01:16:15 +0000 Received: by kubenode517.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 8e6f6728c38b0321039853bbec3714f9; Sat, 26 Mar 2022 01:16:08 +0000 (UTC) From: Po Lu To: Pieter van Prooijen Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> Date: Sat, 26 Mar 2022 09:16:03 +0800 In-Reply-To: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> (Pieter van Prooijen's message of "Fri, 25 Mar 2022 12:23:10 +0100") Message-ID: <87o81t5x9o.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19987 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 6747 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54564 Cc: 54564@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pieter van Prooijen writes: > When using the pgtk build of emacs under Wayland/Ubuntu, I noticed that > the font hinting was different from the regular X (Ubuntu supplied) > version of emacs. > > I have the gsettings config for font hinting set to "full" on my > system, using the fonts tab in the gnome-tweaks tool. > > It looks like Cairo defaults to the "slight" hinting setting when using > the Wayland backend for display and will only use the gsettings config > when rendering to an X backend, when it reads the current font settings > from xrdb. > > I've attached a patch (against > 380f0443b288c68df3762ee20d78719f08dd92ff) which applies the font > entries from gsettings (if present) when creating a font in Cairo. > > Note that this patch won't dynamically re-render when emacs is already > running (like it does when changing the system font). I made an > attempt to hook into the gsettings change callback, but could not > force a re-creation of the font with the changed parameters,for > instance using a 'font-render' config changed event. Any pointers on > how to achieve this? I'm not sure, but perhaps someone else around here knows. > Do you think if this patch is a good approach to get the pgtk build to > use the system preferences for font hinting and anti-aliasing? The basic approach is good, thanks for working on this. However, I have some comments on your code below. > Kind Regards, > > Pieter van Prooijen > > From 6fe888e7c14ef5aad124c0d68fcd071cd5b65e81 Mon Sep 17 00:00:00 2001 > From: Pieter van Prooijen > Date: Fri, 25 Mar 2022 11:47:39 +0100 > Subject: [PATCH] Use gsettings font rendering entries for pgtk builds > > If present, apply the gsettings font hinting and antialiasing entries > when creating a font in cairo. > * src/xsettings.c, src/xsettings.h: read and apply gsetting entries. > * src/ftcrfont.c: use the font_options from xsettings.c when creating a font. Please capitalize the first character of each line in the changelog message after the files. Also, try to write an entry for each function that was changed, instead of lumping all the changes together in one file. > +#include "xsettings.h" This must be conditional on HAVE_X_WINDOWS || HAVE_PGTK. > - cairo_font_options_t *options = cairo_font_options_create (); > + > #ifdef USE_BE_CAIRO > + cairo_font_options_t *options = cairo_font_options_create(); > if (be_use_subpixel_antialiasing ()) > cairo_font_options_set_antialias (options, CAIRO_ANTIALIAS_SUBPIXEL); > +#else > + cairo_font_options_t *options = xsettings_get_font_options(); > #endif This else statement should be conditional on HAVE_PGTK, correct? The Cairo font backend currently supports 3 platforms: X Windows, where Cairo will detect the font options by itself, Haiku (where it is configured manually), and PGTK. > +#ifdef USE_CAIRO > +static cairo_font_options_t *font_options; > +#endif This is conditional on USE_CAIRO, but most of the code below is conditional on HAVE_PGTK. Is that really correct? > +/* For hinting and antialias no dynamic re-display is (yet) possible, > + because cairo applies these options when creating the font, not when > + rendering it. > +*/ This is not how we write comments. Please keep the closing part on the same line, with only two spaces separating it from the last line, like this: /* Changes in hinting and antialiasing preferences cannot currently be applied to existing fonts, since the Cairo font backend does not support changing font options after a font object is created. */ > +#ifdef HAVE_PGTK > +/* Apply changes in the hinting system setting */ > +static void > +apply_gsettings_font_hinting(GSettings *settings) > +{ > + GVariant *val = g_settings_get_value (settings, GSETTINGS_FONT_HINTING); > + if (val) > + { > + g_variant_ref_sink (val); > + if (g_variant_is_of_type (val, G_VARIANT_TYPE_STRING)) > + { > + const char *hinting = g_variant_get_string (val, NULL); > + > + if (strcmp (hinting, "full") == 0) > + cairo_font_options_set_hint_style(font_options, CAIRO_HINT_STYLE_FULL); > + else if (strcmp (hinting, "medium") == 0) > + cairo_font_options_set_hint_style(font_options, CAIRO_HINT_STYLE_MEDIUM); > + else if (strcmp (hinting, "slight") == 0) > + cairo_font_options_set_hint_style(font_options, CAIRO_HINT_STYLE_SLIGHT); > + else if (strcmp (hinting, "none") == 0) > + cairo_font_options_set_hint_style(font_options, CAIRO_HINT_STYLE_NONE); > + } > + g_variant_unref (val); > + } > +} This will need some stylistic changes as well: we put a space between the function name and its parameter list, like such: static void apply_gsettings_font_hinting (GSettings *settings) And inside function calls as well: cairo_font_options_set_hint_style (font_options, CAIRO_HINT_STYLE_FULL); Also, the idomatic style is to write !strcmp (hinting, "full") instead of saying strcmp (hinting, "full") == 0. > +/* Apply changes in the antialiasing system setting */ Please also put a period after the sentences in each comment, followed by two spaces. > +#ifdef HAVE_PGTK > + font_options = cairo_font_options_create (); > + apply_gsettings_font_antialias(gsettings_client); > + apply_gsettings_font_hinting(gsettings_client); > + apply_gsettings_font_rgba_order(gsettings_client); > +#endif /* HAVE_PGTK */ Similar stylistic fixes are also needed to the function calls here. > +#ifdef USE_CAIRO > +/* Return the cairo font options, possibly initialized in > + init_gsettings() */ > +cairo_font_options_t * > +xsettings_get_font_options (void) { > + if (font_options == NULL) > + return cairo_font_options_create(); > + else > + return cairo_font_options_copy(font_options); > +} > +#endif Please don't say "init_gsettings()" inside a comment to mean that `init_gsettings' is a function. That makes it look like a function call with no arguments. I would write the comment like this: /* Return the cairo font options based on the user's font preferences, possibly initialized in `init_gsettings'. */ Our style is also to put the opening brace of a function definition on a new line, so that tools which look for defuns by looking for opening parens in column 0 can operate correctly. This should probably be conditional on HAVE_PGTK instead of USE_CAIRO as well. > +#ifdef USE_CAIRO > + font_options = NULL; > + PDUMPER_IGNORE (font_options); > +#endif Likewise. > +#ifdef USE_CAIRO > +struct cairo_font_options_t; > +extern cairo_font_options_t *xsettings_get_font_options (void); > +#endif This too. Also, just include `cairo.h' instead of declaring `struct cairo_font_options_t'. Thanks again for working on Emacs. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 26 02:01:22 2022 Received: (at 54564) by debbugs.gnu.org; 26 Mar 2022 06:01:23 +0000 Received: from localhost ([127.0.0.1]:52915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXzUI-0000Rb-M6 for submit@debbugs.gnu.org; Sat, 26 Mar 2022 02:01:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXzUH-0000RO-91 for 54564@debbugs.gnu.org; Sat, 26 Mar 2022 02:01:21 -0400 Received: from [2001:470:142:3::e] (port=47136 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXzUB-0008Da-Ky; Sat, 26 Mar 2022 02:01:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+l/zhBS8TO9xRMvEUWZJ1xMEYcjRT9WxQXFMLXJbx5s=; b=CjJQKiWcMV6R FbvLdC1S9AX90sga9t7UkXahbiPMpEMOtpB5rfCYPfD8Pz74l09bKPqZEkA3WvwYVs8oaz4zjVhdj pZP05M+xkHjeQgqVRKLpsl7lIb9JIYOk2LyWRppbGr+wF8DwcJnEDfOQorPTkQgYc1wZc82ymwiKB VOMQ9ZNlTQQr7paX/oogyc/RhZfQyf4f5bKjwRc+nu6/S0FANRKj07i+vVDtNXD0WWxmvYNE/T2jg ahlGgdAcPVHdhMfOEk2TDQhRcNKXwcrb8cT/6ZDCr5J4Kf1UYBItAAQq6UQb+TNwTtGkGMmu/4u9y v1pYHKz4zNly+a0zwB1EoA==; Received: from [87.69.77.57] (port=4242 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXzTy-0003OA-Q5; Sat, 26 Mar 2022 02:01:11 -0400 Date: Sat, 26 Mar 2022 09:01:00 +0300 Message-Id: <83fsn5b6cj.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <87o81t5x9o.fsf@yahoo.com> (bug-gnu-emacs@gnu.org) Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54564 Cc: 54564@debbugs.gnu.org, pieter.van.prooijen@teloden.nl X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 54564@debbugs.gnu.org > Date: Sat, 26 Mar 2022 09:16:03 +0800 > From: Po Lu via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > Note that this patch won't dynamically re-render when emacs is already > > running (like it does when changing the system font). I made an > > attempt to hook into the gsettings change callback, but could not > > force a re-creation of the font with the changed parameters,for > > instance using a 'font-render' config changed event. Any pointers on > > how to achieve this? > > I'm not sure, but perhaps someone else around here knows. Maybe I could help if I understood the difficulty well enough. What exactly is the problem here? In particular, what is meant by "force a re-creation of the font with the changed parameters"? How can Emacs "re-create" a font? > The basic approach is good, thanks for working on this. AFAIU, this uses gsettings to determine some Emacs font-related functionality. One aspect that bothers me is whether users will have the means to tell Emacs to ignore those gsettings and use the usual Emacs defaults instead? I don't think it's a good idea to apply those gsettings unconditionally without letting users override that. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 26 02:07:41 2022 Received: (at 54564) by debbugs.gnu.org; 26 Mar 2022 06:07:41 +0000 Received: from localhost ([127.0.0.1]:52920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXzaP-0000aP-DD for submit@debbugs.gnu.org; Sat, 26 Mar 2022 02:07:41 -0400 Received: from sonic313-10.consmr.mail.ne1.yahoo.com ([66.163.185.33]:33787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXzaN-0000aA-FC for 54564@debbugs.gnu.org; Sat, 26 Mar 2022 02:07:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648274853; bh=8VS/+oNgI+4jKWzKkWPHvO67D99O8MBASM8njkJj89U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=WK1H7nBiF3Rcs1eSHMA3Rd57/AOZcIlmvQeKR8NN9hhuYKYWomRMHXKsrzrSj0U3X/zSOeaCRGUJdkZTr6HzxpYCi19XLM0WuWIWiBJMOEsHXR6wbU/yiRlIcGt2w1Dim41gBOFK1rbdXCyrwTuTK6yenMf5BNdVMTzBYEYPa1UlhrgbZZ7xb2SsaHbXbVDKjJpeLWAsgF9shQWhLveOFlDDw5oP72XYtGDRDOO3efyjZxojeundEumO5lG62u770q3ALs7aiicOB2gf5pYXHTGFfDC0zr5FRGfp1oCEpIdOrj+6QBKcLUfmZxYIPjNQ+IautLyIjTktofD/Ds9Llg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648274853; bh=6AZyYIARi4aAOiXxUATlUIhGnl77KfzRRhNNSgjPpo0=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=jL6Tv2C2pUoC9I0aNaSgrrCmUrv43wp4SOAp0PHARLo6dfneA82g3iqzJGsWMJA0BcLQ9od9W90O8hkdEg9Zr1Dah4qJEGR3KD/jLoaQoEu5hDk2YaM/NNVOrKoqI0ivbzIb+VnjzvJYPjfu/wXPKVTVhvg5WMlXh5d87vQU5D3Zk/WoWxhWb/ObzZhlcs/T8KOChZoG8yWkJN3r2/xbMubzaUPSVQe6BGMOmKaJ888rvvXBvuFPj2+cmwhD9u0RoUmKVBMena8kqHTxSkbnc559A474Z5IqDrw2cLZ71R0LJa7nzcqH2pjZoWrGzAJu4FmK0ZS6BhVUnKIX3VO6qA== X-YMail-OSG: v57pJSgVM1l4tMG5Pr8gBBaShgMuSnbdDEFJMuas3Zn58S3mXIgaC30ZzqRvwAZ ZrgMQPY9sbJvjWBNEmPGN_BVKFysJlNdHJooINjKZd60V5Nyi8zuEkqbBWDGLpBXN2uOWJKY2.K. vGbcL3oRskUHjmtn.iQeYz8bziY5CDkIxkeShZNE0Dgr5gZ.T3a7caeCW5rxhh6N0St_4zVIxURM QmqnPxwDa7NrMxPPYcJWOrExqkmkSvj.AXG2sW7bmTpf79RgRXjnnbc5z66OqH3Ie48EoUYNOWHx vpRSzylvu4DIxO_PyO7vti.hcMWiVReXsWLxMS67QbTq9vOaz2XFZNLGHbsQ2Sln7V8Kp696MMXq A4FnSNYfszjAlwuzv5HGao3ICBAciOH_UDH.Sfk4pk69FdZ7sDh6dgRr_VGov2TYB7146u_IZ7Io 1FGdJTKpNGtT6cQ7w_w1xr5au_2IE3qqmoVzBvharKclN5NnOzS0YPM00JyrR0wL0G7G59gj7P48 QMCGgZDAL.U7SnKP4AfnsenszdOj2TOYPAdsMgHGbgMSGfSxHah117Nc.zfi1Nb316RUji4HDfoh Nr5AhJBvnkLMDZKW7JKWh5uk_Nrp9zj4eypfh7dhy297McoPCBxR24xHxd_h_UFrPIWU1G4onu4D 1AEy5ATvwTtrAmVCOyzm4e_FhOzm2GeqskxMAPd4VHiYr43jvH97KZNnFHbfnl205nnHPjCZTRHF kY1Yorzde5piRoVPc350fi6vD.j7QpcFp.chhi7Em8avml0vigWUkBt6MOvbQINs.GYwPfDmq0zV 0pk3Q7O2VcV8tTMXaQfLvh7sUNVmn07pL4Jxzaqoc_l25.YT_92p76wfMdeQbi4NU57STd.vmnNS cog.Vmq740f.sOc4NkE9t_JzEmQEySTnr52t6MJZ8feMs9PaGaaIRm76Vx6GFrgDtYYjfoWHKN7y vGX2h8d3Q8_vI6gNNvyDQ52Gs3jvFZ28U9w3h5AJevh1OiT0kt3LxtZkZdxkEIVqEpNxyz4m9_w2 OiQA0nOp6KO3_GuxEbdNhVedSrl050O5O4Fpj1RJ_9wvL6LY.4vhtD6F_hfsDG0C8TtzrSkuB.mI rHjKojHbzdZNGiP4SFkAnvVtATMLhbQsSNzgDNHZasbz4rwS6dOGd0aw1IKabBikTTvdn12Ppc4x VDt4KLNNdhemypfFFNLb2YxmtNad_wZP7kNUH07f1XTKmZUrQ9ymv6HbfgyPdbDLZMRid8pGVrx6 hqFym4fgG6NRsemDnlxN79_rHjQonE2gp9DEjXBiooOYAmLDFIQPyGI73HyLkPUcOCXZfqHeDQxu _KLHlS9mIcumByiFs1kymljz2_HTXHaB7wNM1uSm4iuQjYhQqO_Egf6XHyWIMwAvjZyaoCNQ4Zzi eRRVKcyeVTgebV7MHMwVyjR0F7VlbQj00y.2fvq40o42eBeKhqUnZxXgOTS5oLwYw3rF6tMt.wfE 6bKgiZ2icEpqoW0_3LXsuoGaDARYVoUxOZzGVdcnrmCZfWz6kUyeBUROTOv1Jc180UcH4J3yDq1m 5Xn6cTjbrZUGcAlLo6md4CfEi9amd2N89yHsu.8mOys5IjCca3E7LoIPpzrYMQDY1JWuihpLeviL iDkO.niIjTol0YhPJV.WJYVk3gzQCqYCqIQjQNue1bSaM8sKBEHSry3EdjYJVkany1MHN5pkzbuX msyaApu7ZNpOsfkq8Eymnq6TbET7Pl1vr6hbFIC.XVgXWJlX556UN_fOeNofQIslN6mVF1bZIjWe b7Z2hBrfxHbGpKtfZB1hhi7.IAm.gCu5cnuiddesmUnjCCaoN2T_k8hQtdUsW0CfO9NrbeVvWuiv a2n2aMeVWpZ.eoZZaNFiB3EZuijIUetdEzqzpW6OaN69uLhPqP_jf.AD7iONpcrh4Hk9vGrysyZT yM9.cnBAXmMEa8f.loki_sIzvF9eiZLJ_bXgAoX9P0kKUwFIGVVSKjovBNS5LzcDr8cP68QhLuj7 O2t0xdYgqLtVbl5rLsHJ2huZwrh8H.AcL7J2uCWffIgZRGYocXucRpyC3wPiKJIEKMgDsegiV89b LrxkDPEIFzgeqhH6z8mqlNm56JdH0avSM_1nX8bfqvn9.UbUCNbEVa8x7JOCBOmpAm7OZU4uCmJ8 ITbMRMeOuwmfWbgH3xakMU05N4qK2TpOd7tPUCwpEsJJJLr27mx9UVPD_ymR8pc0hQ4fTZmH74zE .ez7rLVXbn.2LgXCT3AD_6PdKg0Ejwt1I4SIcxqjnvQAmmuDqx3SNQXFMyzI_wmp0mVRdBw-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Sat, 26 Mar 2022 06:07:33 +0000 Received: by kubenode518.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 5dcc4ecaeb17a245bca65eeee77daeca; Sat, 26 Mar 2022 06:07:25 +0000 (UTC) From: Po Lu To: Eli Zaretskii Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> Date: Sat, 26 Mar 2022 14:07:21 +0800 In-Reply-To: <83fsn5b6cj.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 26 Mar 2022 09:01:00 +0300") Message-ID: <8735j55js6.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19987 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 940 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54564 Cc: 54564@debbugs.gnu.org, pieter.van.prooijen@teloden.nl X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Maybe I could help if I understood the difficulty well enough. What > exactly is the problem here? In particular, what is meant by "force a > re-creation of the font with the changed parameters"? How can Emacs > "re-create" a font? Basically, Emacs needs to close every open font object created by the ftcr (or ftcrhb) font driver, and open it again, if that makes any sense. > AFAIU, this uses gsettings to determine some Emacs font-related > functionality. One aspect that bothers me is whether users will have > the means to tell Emacs to ignore those gsettings and use the usual > Emacs defaults instead? I don't think it's a good idea to apply those > gsettings unconditionally without letting users override that. I think all the gsettings-related behavior is controlled by `font-use-system-font', but if it's not, we could always make it work that way, or add a new variable. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 26 02:20:27 2022 Received: (at 54564) by debbugs.gnu.org; 26 Mar 2022 06:20:28 +0000 Received: from localhost ([127.0.0.1]:52927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXzml-0000sx-Hc for submit@debbugs.gnu.org; Sat, 26 Mar 2022 02:20:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXzmj-0000sk-EL for 54564@debbugs.gnu.org; Sat, 26 Mar 2022 02:20:25 -0400 Received: from [2001:470:142:3::e] (port=47292 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXzmd-0002JR-Tz; Sat, 26 Mar 2022 02:20:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3wBD7n7k+64ow22VZEMrOWeY61o6zrgZnm94SThOZt4=; b=GQkiDN56bfhJ UeunUXxUDiM1ZawT815b9Z6lorGI8X/Q1nxX6XEq7qVBFr5gGs88Utl4tTPQ//hBZrNaH13sr77wf +CS43KHF4PXSqH8gGAieRvoYahX5jtH0izJGzA8EjoPFkSeCWJYD07qrjPuN5kafkfCJhknCNCWSU 2e8u9XfRxMINS9Y5ynm2juZHl+QzVEzFhUE9LC61r5HyeYMnZXfg3zthUDnG4CtDvPNZs4MtYj0rE OtpgoK4rir/SBev0gv1GmpfUQ9IadK9PL2IXJLvJ1zxJZFUkyPONTik+xQ1u6rk52TkkhJcBNJGzY o7xJhPYizi3Ru1nzPCSUqw==; Received: from [87.69.77.57] (port=1457 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXzmc-0005LO-Mf; Sat, 26 Mar 2022 02:20:19 -0400 Date: Sat, 26 Mar 2022 09:20:14 +0300 Message-Id: <83czi9b5gh.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <8735j55js6.fsf@yahoo.com> (message from Po Lu on Sat, 26 Mar 2022 14:07:21 +0800) Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54564 Cc: 54564@debbugs.gnu.org, pieter.van.prooijen@teloden.nl X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Po Lu > Cc: pieter.van.prooijen@teloden.nl, 54564@debbugs.gnu.org > Date: Sat, 26 Mar 2022 14:07:21 +0800 > > Eli Zaretskii writes: > > > Maybe I could help if I understood the difficulty well enough. What > > exactly is the problem here? In particular, what is meant by "force a > > re-creation of the font with the changed parameters"? How can Emacs > > "re-create" a font? > > Basically, Emacs needs to close every open font object created by the > ftcr (or ftcrhb) font driver, and open it again, if that makes any > sense. Does the below fit the bill? clear_face_cache (true); Or did you mean to do this only on a single frame (or on specific selected frames)? Then looking inside clear_face_cache will tell you how to do that. And one more thing: care should be taken if this is done in response to some async notification, because clearing all the faces will need a thorough redisplay. Most probably all the affected frames need to be marked as "garbaged". > > AFAIU, this uses gsettings to determine some Emacs font-related > > functionality. One aspect that bothers me is whether users will have > > the means to tell Emacs to ignore those gsettings and use the usual > > Emacs defaults instead? I don't think it's a good idea to apply those > > gsettings unconditionally without letting users override that. > > I think all the gsettings-related behavior is controlled by > `font-use-system-font' I don't see any references to that variable in the patch you are discussing. And its name and doc string don't seem to give any clue that it's relevant to this issue. Is this only for fixed-pitch fonts? > but if it's not, we could always make it work that way, or add a new > variable. Yes, I think so. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 26 02:45:13 2022 Received: (at 54564) by debbugs.gnu.org; 26 Mar 2022 06:45:13 +0000 Received: from localhost ([127.0.0.1]:52949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nY0Aj-0001Up-Et for submit@debbugs.gnu.org; Sat, 26 Mar 2022 02:45:13 -0400 Received: from sonic306-20.consmr.mail.ne1.yahoo.com ([66.163.189.82]:38779) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nY0Ah-0001UW-Br for 54564@debbugs.gnu.org; Sat, 26 Mar 2022 02:45:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648277105; bh=tZ3fCJkLVcxe/lTNxIeWwwQkALSkvs4ZifAT8vfXxxE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=gPY3xDMe4eJ/tCNc8iBj93e34LD3D6hLGxsgARB7jw4izofnwXQTvVmiuJ6vhY0L7cw1kGWOD+C55lQWzqYtvjLKfLpXecAChu0P9D2LjbbuVcntqaW98lH1KBpHKs4yoJ9HdoFMdS/BqM5y1sRBTdV1M3z81dsdOWKNd7hhhbBx5UBKvYS1z5DKTze87cPQNyHFdMNN+lOlU9ZkFmu9DD991cde55tIDH2SAnYLweDfi6Ik5rd7RANBUP7Da+cYEWUTgVN8ZIsP8egEaq4oI2NWKhhl4xF3RulrXCyd6E9/4XGBkMF0TCWJeDVtVeUh3Mv2xIcTqWvlhT6xhfkr7A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648277105; bh=6oUkcfaPHKi9uUCAOWFOULqqVaYk9XB2uSesRQhxTHK=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Zc5PFZJdHvMaPUYEWpJ0s+mpu0zj4xvKRNauJ6E9Bu48scatyUsHpUnCrZ/+JwItZTNURoZK2ADgPHe1JcZTY0ynUA005m63ALncxguIKlmmxkmulS4wihGZi4w0Hn0sb8frTx5zK62aBEe+6JB5hMuOFjPN2h3hVNnV1k7C3Ovs2I1asVpvh47GUM2onJgztT6n72I1/W4RPTblWU6VzN4TzKMFrXfzv0z/JaArSXXFidFCHy0zgjm8Yl+8aF9JezAKuzmXB7Dky12s/C78P7yMm87Zn+jp8tcDtvL1cI+JEoaLKbTr6BsP8743ell+xcQqirMfHBTQ1gOpDfcOPg== X-YMail-OSG: 5SDTJO4VM1kwkDUsdOY4_dLY2v23bGiCp1hOAC0JY5_ylYd4gBxJ1xxZiy6E5hy wdUbbYvFbM31j9hhtDgwVXqpxAIt6PDLq8mfBed88WAonjHffsEzDZEDsJ5sbLvlHICVrD9fs9Dh 14Y7atMqtOiNEows7WzZLquH8zHHYBV_f0dA5opeTHb7ZKD5DFTwJpQCzhjhB5baY2OtvaOIfvQZ BJUGnoIcwdAtW0emEngDdZuCGr0WfO4Xt8rF7eVQq.nL4MkJOYFuvxVG.v3P4W7IzYg53MhIfS.a ovbso6pN8wz1KWgqbSt9G8GHiDcahrOVoYNfOW1wCds204ewN5Z1QRSz0aLBclXe8mjrzloh8T8F R4UXuH2oPbQojKMJOJwEgTyZzIlZ.DqlS_QLxtXfIyxRL75iTd0U9twsaK.50l3Sri9_E_5YoXQg huDhlUSLrtLLZERTu6Ch7LDqBqUHrwItDn7EFfYLcoPKUMuAfBu1aZzoGc7aAINwQPDJ6aLx.Vhr awuK1ijdayHrshZ2MT2pKK5rdf6jWJ5kjNB05zADC5sK4TADOvAC4RWDqh4w5MxBuZhxnVSBAw79 YG8ACYFZpymYO1DVcqCtZhe71.jXG3nrfPNPxx_7_DVO2FBYL8Mh0kI1.gY0fQrNYinKdt9kUEDz qScni_FAOcpIqg2NgD9va7Cd9ufnKkohJXZFKREaKnPdM5w_hzPESjyBN5uWReQwfxZA71265Tfm Zav3Mul2pJYYbd2LxQBm6OFf2.y7ouNaP1fS3PzTaXxXo1RkrM1fc.l1uErxOJEm2IULR8s7in7Y ckPLUPujF_YkT8dzs6rRs_2gw.su77hUMo11WyK_wp7GaL7v62YS0_WHBI7MTD8x9uhR0L0K18t9 __uLzHCzmP.mJirQntQIdj06aCHKwGLP3Qwtw0GDJ.fx7yDayJZx3EZJk0OLh9Hiojde7lMNU4.e 3zbGIDuDZWyDUjyyLLUrhgD4e8FBq56v4AH_D3_krfH.sv.zAnqrXbNmvt.lxhgndguJ4mNA.JuR VthqohmXmVYGoTUYwxyNLvMRQG72VwbZk1aQKl312L0M2wy4IhYkac04Py2eco5sk2kfDbhH65bL kyaK.nU8Zd3vk1JfpKuJf0zlVY2AVFwDI8Eq1Fwjw.XMdL73p44QU4aD6FttkQWWS_kFQv1mgxHR jtq4HaH3h1VLilQs6KwAUTIxhehsTdlX1qXlAkKCCEwgBb7626IvN9kjOHWbJ30ZUakd3GVG9PxX aPreAJVXx29KUcDN4JzMdROZK5KoS7_QXZnyWwC1XIR1l2IebBMatISrMRBH1ySwYEATB_aS14lQ 1HfiLPpCyuIybEbS0bXwaNgrSMdy.6Ak70t1DbNgDtG9wL4yKh1ya3ctosEbvNPIckH8pDfoB9Hq FGJSWE4GK.0_02OjyTbiaSdfUjVI0UKbOmmoyawFoiE1u.Hkq8GTMtA_pEIPYDMSocJfdwpAhwTZ UkfWxFIV2aNfuy_6UBjbiSHOI8DYrTdvzHcTdAA2jseTcrz8NaMZ7CIB__lRX0qKbdd2kZQW93hr fPk9T.OuMU61agUhEnTUz32GTIxWze6cdFY.biMOodUfQAejjVcrZCtBo.1BkQkgtnlS1hPXlcKp gB2bJ28x5_APZ9jlRKO.4VChoU_cHC0u1BlM4XXTQTRvocVVDHTCMr1B55AKkas3Zf5b3WUb2Dqq WN_.o739VibQC6Q_8.Gyv0deOZNxosqS7_Dk.mcjfMZA9zM.ipj3X4r7ipnSJkd2HJrc4bJWPwFL gnKXT3o06CsNRt87f50_IVRGbv02Ku4e8xsQCrO3iXLtb8OHPcdcvOkmhgxp3.gcop_lLUeHAl36 _wtdFHYESSRk3lS5tG6TRvgUg0LtK8SD4PsxNA7ktfnWwCMis4EupxdyB.n4I2_FMGelq.jlZf9T 4i5BVXeokB4uY1zjHdiheuSRpRCNgUJ6Az6xjA6fj3N51uLr3WLKAWnde9DX.0HHdH8EaKXRxbar Qca8louWo4PoRgIkBnL1imDisEHuL88y61mwvYljlsmNYL2zZ55OiNNK9CKwVAoKXuFwrKK.rMRu H8rBpBmPmGA1Rj_N2augSi26aYwkrFxz.YYytIukaMv6owqCYqSYNL.0Sz3kmXhhd1b0k0ukVkJK .tSuyCh8epzkIAHdZPevlPGwZuRtHcjddaT.D9340JZjqjRu6CUu6rgi5QtEkN_wVq_4Ug4xrIHU 6Khm04O7FOkffnIBWFQ81m8Ha0uc3d7Y5WrZjedVWYe6mRtOjfqSsBF17z1tx5x6n3p5K X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Sat, 26 Mar 2022 06:45:05 +0000 Received: by kubenode510.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 8dc2a232d606a6068c2a3c20f29377ab; Sat, 26 Mar 2022 06:44:59 +0000 (UTC) From: Po Lu To: Eli Zaretskii Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> <83czi9b5gh.fsf@gnu.org> Date: Sat, 26 Mar 2022 14:44:53 +0800 In-Reply-To: <83czi9b5gh.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 26 Mar 2022 09:20:14 +0300") Message-ID: <87v8w143h6.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19987 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1069 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54564 Cc: 54564@debbugs.gnu.org, pieter.van.prooijen@teloden.nl X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Does the below fit the bill? > > clear_face_cache (true); > > Or did you mean to do this only on a single frame (or on specific > selected frames)? Then looking inside clear_face_cache will tell you > how to do that. It should be done for each frame on every display, so clear_face_cache probably does fit the bill. (Though perhaps clear_font_cache on each window system frame by itself will be enough?) > And one more thing: care should be taken if this is done in response > to some async notification, because clearing all the faces will need a > thorough redisplay. Most probably all the affected frames need to be > marked as "garbaged". Thanks. Pieter, do you need any help in implementing the feature along those lines? > I don't see any references to that variable in the patch you are > discussing. And its name and doc string don't seem to give any clue > that it's relevant to this issue. Is this only for fixed-pitch fonts? No, this is supposed to work for all fonts. > Yes, I think so. Sure, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 26 03:45:32 2022 Received: (at 54564) by debbugs.gnu.org; 26 Mar 2022 07:45:32 +0000 Received: from localhost ([127.0.0.1]:53006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nY176-000312-Di for submit@debbugs.gnu.org; Sat, 26 Mar 2022 03:45:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nY174-00030q-IQ for 54564@debbugs.gnu.org; Sat, 26 Mar 2022 03:45:30 -0400 Received: from [2001:470:142:3::e] (port=47796 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nY16z-0004s8-87; Sat, 26 Mar 2022 03:45:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=x4UWI+dlUqSmXolMp0hI3iBK1HpU0UpON1TiuEDnVbo=; b=Qz+JjNwUIvLV Dfn/qkp+TRhnZlo27j+YPokfMMh+LshhJiR301ZNa2ttNGMro1+p8xeMUoiZN/9i8lJivOYTJ5+Oi xKUL0W6dZ4QaXkadSM8JB/0cno4K3L9qhD+VTy6GZMRPxLnRlwxLEOmQoewQysXb/yJ1DGnDEVmk1 EiFMWPu397VAefid1P2KXcGr+urzzPjVB4FvzB+yUz+EH60xkhqOiLcvCaw7xtaRTaRKwEeHMb0DH LkPKAwEbfRawcbbZ33/Cw5cgzXp/QHCbZY8uav/kJE1ZK4k7/L4EG7I6Da1R4yjXUNOl/fDADgs4S AuW/WR1fpFsQboazA+lEsw==; Received: from [87.69.77.57] (port=2806 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nY16y-0001Y8-Lv; Sat, 26 Mar 2022 03:45:25 -0400 Date: Sat, 26 Mar 2022 10:45:21 +0300 Message-Id: <838rsxb1im.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <87v8w143h6.fsf@yahoo.com> (message from Po Lu on Sat, 26 Mar 2022 14:44:53 +0800) Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> <83czi9b5gh.fsf@gnu.org> <87v8w143h6.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54564 Cc: 54564@debbugs.gnu.org, pieter.van.prooijen@teloden.nl X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Po Lu > Cc: pieter.van.prooijen@teloden.nl, 54564@debbugs.gnu.org > Date: Sat, 26 Mar 2022 14:44:53 +0800 > > Eli Zaretskii writes: > > > Does the below fit the bill? > > > > clear_face_cache (true); > > > > Or did you mean to do this only on a single frame (or on specific > > selected frames)? Then looking inside clear_face_cache will tell you > > how to do that. > > It should be done for each frame on every display, so clear_face_cache > probably does fit the bill. (Though perhaps clear_font_cache on each > window system frame by itself will be enough?) You cannot clear the font cache of a frame without also clearing all the faces on that frame. Fonts are face attributes in Emacs, so faces have references to fonts. > > I don't see any references to that variable in the patch you are > > discussing. And its name and doc string don't seem to give any clue > > that it's relevant to this issue. Is this only for fixed-pitch fonts? > > No, this is supposed to work for all fonts. Then I Think the existing variable is not the solution, as it explicitly talks about fixed-pitch fonts. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 26 04:12:12 2022 Received: (at 54564) by debbugs.gnu.org; 26 Mar 2022 08:12:12 +0000 Received: from localhost ([127.0.0.1]:53019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nY1Wt-0003gA-Vy for submit@debbugs.gnu.org; Sat, 26 Mar 2022 04:12:12 -0400 Received: from sonic308-56.consmr.mail.ne1.yahoo.com ([66.163.187.31]:45664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nY1Ws-0003fx-Gh for 54564@debbugs.gnu.org; Sat, 26 Mar 2022 04:12:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648282324; bh=CJ0C0GsOMFuvKjnDDJvg+deAOlrtABTK55ELUq4z3CE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=cFIiPA1HvLqH4/dIk9XmgwcecR4mWQC4/OkA6Ud1H0aRqKntQEnAsU/V8JIDcmxc9t84SziemUAaJBIAMucNuIXPSsXfl/Sy+VMBOCCmo1wGNIM7r65xGHxf662qzVtp8Kg6BnT/2c+MlUtCkDzCny0OfiMG7qazwETWO6DNe4k549NyrX9chhi5Hc97Tk6NJph1UnTZin2Ws//MadUl5FocE/0MhyO87czvatNtsiF1JUPE4g+G9bJSZSp4/IHVwFJYfz/bh1SkrZO7CCnbjsfSsOGi+mGSivEagEGJUMfFCZ5l1Kloh8jYHs4uRqBr8eqvCX6DZ0sY4DlQ4O06Hw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648282324; bh=Xlh4foOvfs9b6zVqxJyKHM3dyZAK1bBNxviL/E8DXbG=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=X92M39yfajLr3k+6HjIT3+ErvCJuYYPq/pofJUvtjxCXxU7+TD1WMdEM4pOSsT7xuHDr+3Rcet8Sf9gdcFTb9JrlK8XNuNI05KGwNJV1nf/KvXrm0AXkfLbSPGK2sa5CcqY2uL76+qg8g5/gyCqol2A6PUgxpxCIl34aFo9MJD6JRBrMhb6mqWAvSQ1S16aJHkhGnngKfmrm7ehl1+DWlrPnOy4HEIIrx6eE2Ce4bNHx4WejBe/eGvqxgwRGYTNIhrBGWDaxqDNynoptmSXilfLVIx/H3V6gpTw45XmUw53JlhNsSIBX1wV4i71MiBWYYn5DEfD3XOs6MlFRsHtuKw== X-YMail-OSG: nY2wQSIVM1lHNnovFlUk82dL3tBe.NvqfGt3BwbXkz6ZE7erOJWNsFpE6aoa7Lc 3I0qYf01.6pDzlYDTDCuNLZQQTnTyFgwaNk8miYT.gFGAtgVXh2SIyQOVMCBi_s2.dxczPse..6c o.chDeFaIh_EcALuLm1GOFIXQKqNOBbyaBsWshGOHP9AuMZnUq_flRCkBnwHk5iKSKOq4twxue_E eFcxkmpoZ7P2iezu1mBtOtpdW75Q6g0Qso_Ekv5MnRcfyjRreF.lSbttisV.Ja5mpHAFIKMTRJ0C l1GHBbDqUxFGEdoSSRiI6.eRCfIgM8nIZqboV9TIjriKztlnYPTIbVwtgKSP8j.JEE7WTYdJeUr2 Sm2FrBF7edN2l0WEQQvjlvQjSLoqs.RBt0.Dd98h0OqnRo0elpuA0vMZheRiVyW1_tpok7l_g55H RJRcKr6bLibPsM6HqIEOAMcEyq54YQeCYxVvMAtEaQW5uakCRX6tGLO62Efyo0pt65zLwfHsq09x Wox9NBZrG1Wl8dxCcn29BxHfafk2XubaXVqEszyF02FD9Y2LH_.zJGF2SR8JKrQ_jN3sAfTJlq1Z u23T0_znP9MhMh2MjHdsDWiFg5PWwRj2Oq8OAqZedU0N4ZSpB63HU4pmtF_Gkkjc6Ei_KAVg.MRY Fp.9Klimaig3w5cvspimjdO2tB6XFz9Q8LShgd5DSLdPmVK0PnWITHJINeTACbIf_fkUfrIrXVcu Q6I1HuL85.VbfH5_hle4hHCSuigx2LLyH.Sy9FX4T3IP81OOBHwWFuRTYwi6j6fYkez2KAUFGKwX xdTwpeNL28zXd7Bq7LxJGbtZiAc2sKOsLCMai01Mv550IDaJ7dWjXn0zjYwolRL9CNo2ogAWnit. mmj57PKsVSxAu8mQHD4iqT6pSog1vUGRin4W96F6IR3avsOymOKirefwp49nfC3dLlJT57snvvzy 3qHYXS73T999R7KZY.NrPiR0qkAc6u2O95c.eCFJCj8ytrnqvdnFOcU5I3DAUYufGzkjPDWz7KiT DocR8eBGlUYfEp8XS2VAWYKScJk3sBs4T6zTA5yjGP5ykKfsRHntGY0Tbux_Y9wbtuFiQ9QB5sf4 aucTjy9ChHfmePl49vhO4gqhDtiBAGwNF65XdIUqXpZb0UCPVuccJ9.K.8W9SkUR_B0Dnc54ze86 IJ5RHG4xRuMnv468c9qucI6SnGJDH9zXgqbSXSi34pJH.B9vdloWCFmUJkg3S6tev5stUWrYG60K 2mDl3BHIEUuVFvnEI6j1pJtUcO3MSdE1yKMF85WlNTFKy_Z8eCQMZ1l9jCbla1_ztj2SLmYeGh32 qqWD6mLNngevx5bje225XjivTPHT.2M_gSzZ6r63Df1R7ogxTxWYEH31IFisYooqE7Dhp0mWgMjR eqwrJWXs8ehRQG178_StfKviwteVd_8lo6UW0C0bfesPc24M0aWET8aTCWfyDEfFtMSWi0386rQj rajNLzdMcuOlvoJWgNakg0G1KZ0R62G9ySH08wmQXRzK2YWogJOFOHJBXk_to4mm5XtgX32YVkY8 kLBOegl9hEBEosBQBi1l._Eyp2x99_zj4rwtd6KsBYS5yunMxAq5GbGhv1799IXBqWuRvYEfrI0m 4UTuhNLfQ5s_VfovgMHQ2lr3.I7MVki1R3FK.pKAjNFY6RB0VF11bHxIHayITEr0v2fB609QSjsJ jvrbOEG.STm62hUSVBZ3ghpZaozqdlUeMGhbdE6Kr8WNXfBbB_cOhgEzzb24B4o9ObAauuX4O_wB 1LDUqSkLIXh7cXuHqp6.8KPerDwDWD5Y6ez7SgsHUXBrMD99KlsxWF3PFGr9o17sl08EjZ8KM.YN ivuJRJSFKy4RI._1ZaWyl_72o2uAsSaGLZTpMJsMXAiHPQguGnQeG0b_b84pdUL8ii8f9eSK_9ER SEWdiEfIUp1lufpijw6ClODx0goccuwMzARF1UE0VxV_B7QA3O1T.ld3qcLFtvjFs7ImId4RXjrF i8GIi8k1lK7dHiZbV9.Chf0SxylkP5vUNx0BxBnXnTdjcxXUuXE0YF7cTqX1C.KDgTst8hEzwGV. fWIPHDEgmb37D2_IDoMk33nt0ewQPVgnLu5JUBlXTP9pniMMlOLaZDN8VRZAdCnSipIHYWAkN55h W.T7Lj7FadFCUNgmgc2lHsx8.kn87qmD3jrO5v6iVqC2cst.71yjQOj_I_mhAgSJFL9jMXVduG9M wTWyIQ5kys2itJaE9inRCxpfuIC35m.5IgjcwO69C7PGAjWkrR5lYj2_6pTWFIX9byQ-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ne1.yahoo.com with HTTP; Sat, 26 Mar 2022 08:12:04 +0000 Received: by kubenode514.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 24bf6e5f9a2fb446cebfd8b5f470f10e; Sat, 26 Mar 2022 08:11:58 +0000 (UTC) From: Po Lu To: Eli Zaretskii Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> <83czi9b5gh.fsf@gnu.org> <87v8w143h6.fsf@yahoo.com> <838rsxb1im.fsf@gnu.org> Date: Sat, 26 Mar 2022 16:11:54 +0800 In-Reply-To: <838rsxb1im.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 26 Mar 2022 10:45:21 +0300") Message-ID: <87mthd3zg5.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19987 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 355 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54564 Cc: 54564@debbugs.gnu.org, pieter.van.prooijen@teloden.nl X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > You cannot clear the font cache of a frame without also clearing all > the faces on that frame. Fonts are face attributes in Emacs, so faces > have references to fonts. Thanks, I see. > Then I Think the existing variable is not the solution, as it > explicitly talks about fixed-pitch fonts. That's reasonable. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 26 05:36:34 2022 Received: (at 54564) by debbugs.gnu.org; 26 Mar 2022 09:36:35 +0000 Received: from localhost ([127.0.0.1]:53078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nY2qY-0005kl-L0 for submit@debbugs.gnu.org; Sat, 26 Mar 2022 05:36:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nY2qX-0005ka-Jc for 54564@debbugs.gnu.org; Sat, 26 Mar 2022 05:36:33 -0400 Received: from [2001:470:142:3::e] (port=53658 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nY2qS-0002ZN-8x; Sat, 26 Mar 2022 05:36:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4JLe696LQM8x+yCpNiK6OrcqNPkpG3DSy7/s6kmVKwc=; b=RiOj4Em70gwH hMjUGAj7TCD1q1rLa0Cp00wZJy3tKCTmrFivbP0bXN2HzDQRbmSw9Pu56Ge48nGPQRFqhD3yV8iYc PnOyPdfEBSPDuq2Z4vQhs3RrC5OuyFAjc830clWPKOD/2fB3ZKHXjTOj6+EAULEI4eWHcIpANKzuy IwGr0O3c1ony8MFHQqL85AkxfWWjiNQ/G5bJW7SPoqJpvsSSYIoyJ9hg8xcUBtY8z5ar8RH2ZjtBc +l0i0t0P/jIJwLE4bJ5U9BVhKmylC6b1oTq5FGocf9EhBTVg/0R5tWTuor9XZi368lwpNssF1sdPY +smHiyfHLZVlaV2r5t4BCA==; Received: from [87.69.77.57] (port=2206 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nY2qR-0005d6-OS; Sat, 26 Mar 2022 05:36:28 -0400 Date: Sat, 26 Mar 2022 12:36:24 +0300 Message-Id: <837d8hawdj.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <87v8w143h6.fsf@yahoo.com> (message from Po Lu on Sat, 26 Mar 2022 14:44:53 +0800) Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> <83czi9b5gh.fsf@gnu.org> <87v8w143h6.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54564 Cc: 54564@debbugs.gnu.org, pieter.van.prooijen@teloden.nl X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Po Lu > Cc: pieter.van.prooijen@teloden.nl, 54564@debbugs.gnu.org > Date: Sat, 26 Mar 2022 14:44:53 +0800 > > Eli Zaretskii writes: > > > Does the below fit the bill? > > > > clear_face_cache (true); > > > > Or did you mean to do this only on a single frame (or on specific > > selected frames)? Then looking inside clear_face_cache will tell you > > how to do that. > > It should be done for each frame on every display, so clear_face_cache > probably does fit the bill. (Though perhaps clear_font_cache on each > window system frame by itself will be enough?) Actually, I see that clear_face_cache doesn't force clearing of the font cache on every frame, only those frames which have "enough" fonts defined. So I guess an explicit call to clear_font_cache for every frame, followed by free_all_realized_faces, will be needed. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 26 11:48:42 2022 Received: (at 54564) by debbugs.gnu.org; 26 Mar 2022 15:48:42 +0000 Received: from localhost ([127.0.0.1]:54544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nY8eg-0000r3-2m for submit@debbugs.gnu.org; Sat, 26 Mar 2022 11:48:42 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:52383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nY8ed-0000qp-2R for 54564@debbugs.gnu.org; Sat, 26 Mar 2022 11:48:40 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 372DE32009F8; Sat, 26 Mar 2022 11:48:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 26 Mar 2022 11:48:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=teloden.nl; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=F8wPXxvX/30lOa 5NZpvR4WLaTrot8lqu39pCPEHr9pY=; b=nvJzyDUvJ5kPBNaULPHREzZTBF9epE WwD3mL6UYu1ICIYgXofrwOyra+fkuUM1kTqcIEVdR4/gTtAyiPI2SdcNp80feEw4 l0B1mC1nMWmOGvlftAAv8mCGBApoG31tcfptgDWsC95SeJ2VG/j2vAXgqWi/7U4x lD8OxqABOeDxcp0ONJ/ItgXU5h+zVJ/87a2CDUsVY4yQjpVF/aKsBvMM7Fmc4u/S Wrvu6Ej61WiygV04Jkw7ADsd7ZFDJesDIL7hjatbQU+ufPTeZUiiwHUQy7frk52B j4yo/mKPsNjSIKPOfbyFMoN7VY2pwAYevGc4SBRT5kvkJ4wenUiRnXsA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=F8wPXxvX/30lOa5NZpvR4WLaTrot8lqu39pCPEHr9 pY=; b=NmHm28FFI4yRsVQVS5tqUOjNJe30D9lN+8u2vTf97x+G7hZjbjPjHZlKH ixy9b87SU10ZsZluzqXjg8gpFa18AxErBeDz25lpPKrAbtA745KMYo1aXrHhkBdb OeMNaGa7ZoJWEx6eXMcXL/R434dTvjM3K4Myh8j5rStj47TlCNfMmiJv8uLra7A9 YXo3MVwuEELagSrJ+fUthb3j35tZrgaBCfiwNV5vr8TAb2FCKjlbKlHLlSFafaWd ruQIUNzgh4eC/fzTS/vPwYNjkSD0WidaW6lDkUF9nL+PR0jo5f5fdqKp1w+jMaVE 51BtNppTRccgolVl9rpWGrKVuJpTA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudehfedgkeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkffuhffvffgjfhgtfggggfesthekredttderjeenucfhrhhomheprfhivght vghruchvrghnucfrrhhoohhijhgvnhcuoehpihgvthgvrhdrvhgrnhdrphhrohhoihhjvg hnsehtvghlohguvghnrdhnlheqnecuggftrfgrthhtvghrnhepfeefueejvdduffehieej tdeuffdtjeffhfevkeegueegheduffeileetiedtffffnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepphhivghtvghrrdhvrghnrdhprhhoohhi jhgvnhesthgvlhhouggvnhdrnhhl X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 26 Mar 2022 11:48:31 -0400 (EDT) Message-ID: Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds From: Pieter van Prooijen To: Po Lu , Eli Zaretskii Date: Sat, 26 Mar 2022 16:48:30 +0100 In-Reply-To: <87v8w143h6.fsf@yahoo.com> References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> <83czi9b5gh.fsf@gnu.org> <87v8w143h6.fsf@yahoo.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54564 Cc: 54564@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello All, Thanks for looking into my patch!, I'll fix the formatting issues you mentioned and narrow the changes to the HAVE_PGTK define in the various source files, so it's is only present for that build. Not sure about having this functionality controlled by a user defined variable (as is possible with using the system font), as far as I know, the current cairo X backend doesn't have this as well, it will always use the gsettings/xrdb defined parameters for rendering. Regarding the re-rendering upon a config change, I'll have a look at the options mentioned (clearing the font cache and marking each frame for redisplay), but that will probably be a separate patch. Kind Regards, Pieter On Sat, 2022-03-26 at 14:44 +0800, Po Lu wrote: > Eli Zaretskii writes: > > > Does the below fit the bill? > > > >    clear_face_cache (true); > > > > Or did you mean to do this only on a single frame (or on specific > > selected frames)?  Then looking inside clear_face_cache will tell > > you > > how to do that. > > It should be done for each frame on every display, so > clear_face_cache > probably does fit the bill.  (Though perhaps clear_font_cache on each > window system frame by itself will be enough?) > > > And one more thing: care should be taken if this is done in > > response > > to some async notification, because clearing all the faces will > > need a > > thorough redisplay.  Most probably all the affected frames need to > > be > > marked as "garbaged". > > Thanks.  Pieter, do you need any help in implementing the feature > along > those lines? > > > I don't see any references to that variable in the patch you are > > discussing.  And its name and doc string don't seem to give any > > clue > > that it's relevant to this issue.  Is this only for fixed-pitch > > fonts? > > No, this is supposed to work for all fonts. > > > Yes, I think so. > > Sure, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 26 20:59:46 2022 Received: (at 54564) by debbugs.gnu.org; 27 Mar 2022 00:59:46 +0000 Received: from localhost ([127.0.0.1]:54965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYHFy-00025b-L5 for submit@debbugs.gnu.org; Sat, 26 Mar 2022 20:59:46 -0400 Received: from sonic306-22.consmr.mail.ne1.yahoo.com ([66.163.189.84]:35180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYHFx-00025N-5W for 54564@debbugs.gnu.org; Sat, 26 Mar 2022 20:59:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648342779; bh=As3AKezw/5WjoJD4gmVeFkPTLRC3hW8q4qMZncJt7Dw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=QSj6U0UQ7E/EcW+lVm01BexHDdMciob83EW1RIpk1ackhxB9tW4Xq1u8VRTOuZDK6WNmTS8G7KvDBNVlZQimGX5LCkbSoeyezm3BIFrukm6lqjywk0PTrZe7obK/B12evqtXjTLKZaSIjjENsIJfmwIIqTZZ4dn3+8+vaCa4xVe6B+MNOar8osSP8wjq7cwbcZ7HuNbikyNFFSvVcVIKpbqa1kulxLX+ftH69m9koPPnnJ1iWD+1p+4y1YKzLSyywckExrqXzbUf0noBRuhYcn6kXnF/kA8QHZm+qaUCr+4MW1EHhDDHJiUyACnbrCRhbIN8XaFsy6TYogMMS8LxBQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648342779; bh=+OrS3YvtKo0fjRaDVMkgcrZYgkPRZsL6+/YsfTzKadK=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=jkBsDQo8uAKlJ8N5jPF3rfLjpXopuIxz2LJsfnM2rsUZAFizogpf7XXzlMoGZXWYQ/JHxHyds5n0pACftl/W/vpGCMwrJAUMZWnGQbxkdYws2NqVBhnjdnAN0MN14IwrnsWGryULokPg87jOQpsC3DUTohxGcuqNb6r4u1gOWnjj+iGySfqeAaF/Fvpx4IiOE1R6xzeL/KB3VGWmsWVJBfDToHuXiORAeU8qbpEwJr8skEY8zdONdw1eHB6N/brH++H+DblKIt0rl1+ERO7wGbuIFuI/uIe92ymijjCBQE+QzbBYfYORXsBQm/flX3IYCUSkz78iOZEbOETGf2PHhQ== X-YMail-OSG: WKs6OrwVM1nHVMpKWM73KMzSMZQTz8JFWoxyFIYX2AxpozUo26bbTvP.tOHlfkY aW6iFeaAic.JOGzsisf.h9AqjpTB7X3ijo6Z0VgBPC8Cmfg.FFPqLh8_9LTx7iwJHPMiAxD_5Mgu I1Q8y.MZGn__l7VfzEHY.QdpcKRjnvSQe1Bw5VpkIQdK_qFbaAS7JvYmMzTeZ7D2v6KgzvTdTE2j f.zVxUgc5igv7M8BZwDc8EdHC7K7tDy6.SVCoAD8Go2XP57eAKTO5E0D_7Qe3z68x_v9aVnMzKWM ZjRCIX.4nIARuQKXB._UXBoiaGXPc6BRAjfAa9Z0.tWouV544ZgGe11gelJK15LwrDJxqRbyMRoo BfIuWuej63wkK_004PQid2m4rMEwM0w4920bCmN412pVZijWdVSbxjTrOq5f45_XGVJ6BGhtxtQX 25C3N3J2JmT9C8wSNc9tC6OKDHZcOqSfurfsLIH8ZiUeAJpjhEn3VstpGDgn6Ug4bsQ6WhqLipHm .vxr3J5k3ZYhoZ6KCGY5Zuj965KoMhbNB250u4HuqCPwvJg0P955LjQ4PwYm2iGSk577bpA_5gr6 EhIXbe54WTFrmcBwnL.ibPVSwLuaEMt17etU4SJCVkyY.oGO3o6_25K7HamLsY_0xj.7_Jt3t_zF p1Ww6Zti2xqVShdMIa7vLBRuJDHXXwgmgswPJuFl0dum5Cv0GkCW9ZpunzLZzLf5.6JGrI8liGKc i8A2MDef0_sijcBMNSGCoVpFecYzzraEx26LMBBWzEo3cINTPO1sb2YZgfFzeehXaoJ0hxUrXHQu 07_Seq.JSO.JHwcXg4nGM74dvOt2QDmG1dHcd2DVwtp56ST0A1hCDabgNqMfHEGpPNDc_i07.PUn KnoLpkJ4acbUMFy8vBVsSHRYlM8TOsdlfieeVyxjx8TYuHDpwgmTX5D1OisM5qk4KeHcA9bmOye0 HME2JeTwIuxg80bs2twc1lSgZ82ATeVmjdtcif7awrn8J83IhiJVlFWLgGFmSiE9bp8.VuhvmElD bgmlqMWKpDL3eUMuwPWVeCZlWggyRzFW2OCAU9PDOQeVIFsMN4mi24qDLB1QaDJ9vkFH2xZQWIlV Fr7pGpydiW8L_RCouyoIuensjB46JMKU_HjHt3K2m9lXwKw9ioyy.HL6VrUP_GJMRog69eTyST9_ TKoEtVTsKctlJN5k4.d_bix4LsNP_gWZbRPRp.JofulhAupSIVGWj_Zk0vVSSKfGoX_FX8ZTCkH_ yn3WC7qk1_E1Fc7FStoEABsbIRPlK0ToJOeRa44ryLGdG6I4I9cPU3g_7tB3GpeACf5DCq6qOEt_ 05nMylCZHLFxTcoIJXhGueJqzf8zS9IBvg1tzDyIpeqbTtDxK4jSlg7G.GJTcFazl9RWhZuvEkHo iYgEqT9qIVlpu_mCVipN5LZmCc9xNcEMwcRU_PJhD4KOyTqNzpRPEI8KFlYkm0bfoPi_nyLRWqa7 rsC.bkq1_yk21Oq26eTcbtAEnDYkNUT9h_dEuzSa6aVHORwxlyVGc5kUVMpZgf462btULfITFsc_ kVaOer8SEB_jgRewkpdrxLEn7v8jyp0N7WtRzccKTkYwC8gcK6O4A8CfKf0ceyh3HInCOoVSsCS7 9YdA2MDCrc_GQgzWhwtsNjxnOEhyefU59701ZEB3jwSsQf94I7SpDZRf2pkdDnAbfMWc0tloxGv7 RDvNkKshDN49H9YgJ4hb77Xqd2x7Ea0CO7OrJmfQCNtcqoOJ9t4oxabChMqy.4VIpXL0YYlcomJj Sjq59UbVGZqXre3r1aw3p.MnNLP91r9D7tz4l2Dtf7EYnQhsyjZDl4RTXCrTjh3w2gMIwUPp7TaC GRFN09SCLYPPpF3t2bnGNiKz8QJKfHgwp6NSKqQUu7t1McjzB8DnVtw9z6TzVXGdOnOXdhY4xsj9 5lDP5SIulnGo1KgPOvKAXomGmXZKK5tRW.0QeFibhJ697C7ur.IxMLATXXPW4NXHPoPqILWSf74. 3K3wY8HhXX7boBfci5frlnNwFVSOk0H8FgkdmNen46Y1zjbmHSWKQwB9YVp7g0NfATStyHMlobv7 6jjZ5j1w4KbF1ZHkOje4oM3LO4DT9wspM_e0BjegIwqwaFpQFbWN5ZSjFOujo2r1NJkxeGeIYKgk 9mlaXgaGkBzSyjyTLOj4ZbjwTVEaVRHBnisCOMox2vTKk0yw9Po0FKfx08H._OSZouF0RKO1fwM8 TZUnzDmCpODZu6PcETLmJ8a4QcYbgEW5cuG6WCDXDVR.R1yupF6RFx309g8hHXYx8pGYc X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Sun, 27 Mar 2022 00:59:39 +0000 Received: by kubenode508.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 3376d51eb5771c3b1db27ae193a5f84f; Sun, 27 Mar 2022 00:59:36 +0000 (UTC) From: Po Lu To: Pieter van Prooijen Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> <83czi9b5gh.fsf@gnu.org> <87v8w143h6.fsf@yahoo.com> Date: Sun, 27 Mar 2022 08:59:32 +0800 In-Reply-To: (Pieter van Prooijen's message of "Sat, 26 Mar 2022 16:48:30 +0100") Message-ID: <87o81s2osr.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19987 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1062 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54564 Cc: Eli Zaretskii , 54564@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pieter van Prooijen writes: > Hello All, > > Thanks for looking into my patch!, I'll fix the formatting issues you > mentioned and narrow the changes to the HAVE_PGTK define in the various > source files, so it's is only present for that build. Indeed, and thanks for working on Emacs as well. > Not sure about having this functionality controlled by a user defined > variable (as is possible with using the system font), as far as I know, > the current cairo X backend doesn't have this as well, it will always > use the gsettings/xrdb defined parameters for rendering. We don't support using the PGTK build on X Windows anyway, so that's not a real problem. Besides, manually specified font options will override whatever Cairo thinks is best. > Regarding the re-rendering upon a config change, I'll have a look at > the options mentioned (clearing the font cache and marking each frame > for redisplay), but that will probably be a separate patch. I think it would be best to have that feature as part of this change. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 30 04:02:03 2022 Received: (at 54564) by debbugs.gnu.org; 30 Mar 2022 08:02:03 +0000 Received: from localhost ([127.0.0.1]:34378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZTHG-0007PO-5B for submit@debbugs.gnu.org; Wed, 30 Mar 2022 04:02:03 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:49545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZTHE-0007Ox-5n for 54564@debbugs.gnu.org; Wed, 30 Mar 2022 04:02:01 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 2738B3201134; Wed, 30 Mar 2022 04:01:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 30 Mar 2022 04:01:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=teloden.nl; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=Q1jTTeqjPBeH0dibpb1UKDV7YOf6n/YjEtVWup 674vY=; b=GMFkGmsaYCL/0BteIi882kfZ0kn1Pwm5KdXGJeulJ8b1QcecplsgyX juRaHgnL6pUdsqBd+Q+VvQQlNdXXp8i62oLDNh0t50nov6Z2gU3NVRxTvfl/KgHS 295k9KSemofjnl9+wkx4oE2VCEe5o4CJVi3xBHhrUmbTdNxmfvJd47dm+w8224Gu K+UHUZAzJH1oU61Paf2WE0ZSraq0feTPT78AVsU1HkXNxznzcJSvIynPlmyHvy9j XT1ciLTib+sj69/KsGy4ugpmf+v6X7TLT66u9nqMi+b2wCXz9Qwe1IzVflmTYCI4 pADPzvqUsBnkl0yTTPxqBUOnTeW+gPkQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=Q1jTTeqjPBeH0dibp b1UKDV7YOf6n/YjEtVWup674vY=; b=OEu8NVxyflF8dwUzfO1J9yX7tfDaR8Nwm J7jn9aXqx08jRsXt2uhEK+FwlUdxCckE6i5pktMU5u+JlJurMYWZfALhu/v1Os06 +SIYOwMi5fNudF2pGT50DGDJx9R++AZnjp+gBTsnNAGCgnh4PhqYJ+YcbMbJR+dv hZgs4mXtFldCsO+hS1lSf8gYEU7OGAuy7dISimnkMkq18MubkNu5gx4TOn2sc9Us kNNgHhVmSNNw7nW/y8tM/HVb4+wOUmK6tea80q7eeST2NVv3b8xADEiCtbM2vjSU LDlf58vWrzA2S4Hod7uzQ/4TA3uG1S4KTpxCTNOrKJWXEnGEL0BcA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeiuddguddvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkuffhvfffjghftggfggesmhdtreertderjeenucfhrhhomheprfhivght vghruchvrghnucfrrhhoohhijhgvnhcuoehpihgvthgvrhdrvhgrnhdrphhrohhoihhjvg hnsehtvghlohguvghnrdhnlheqnecuggftrfgrthhtvghrnhepveelvddtgfeluefghfdt jeefudfgtefgieejgfduteevudekieevtdegjeettdefnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepphhivghtvghrrdhvrghnrdhprhhoohhi jhgvnhesthgvlhhouggvnhdrnhhl X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Mar 2022 04:01:52 -0400 (EDT) Message-ID: <88d833f72df4f4cbb5769f1a75057d3f957a812c.camel@teloden.nl> Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds From: Pieter van Prooijen To: Po Lu Date: Wed, 30 Mar 2022 10:01:49 +0200 In-Reply-To: <87o81s2osr.fsf@yahoo.com> References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> <83czi9b5gh.fsf@gnu.org> <87v8w143h6.fsf@yahoo.com> <87o81s2osr.fsf@yahoo.com> Content-Type: multipart/mixed; boundary="=-umKXohLniwe+xo2fRDwk" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54564 Cc: Eli Zaretskii , 54564@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-umKXohLniwe+xo2fRDwk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Hello All, Here's the second version of my patch to use the gsettings for font rendering: - Every change is scoped to the pgtk build.  - Changing settings redisplay dynamically by hooking into the cached_font_ok field of the cairo font driver and storing a font-render event upon a gsettings change. - Formatting is now in line with the gnu c style. - Commit message was split into multiple parts per changed file. When playing around with the font settings, I noticed that cairo/pgtk doesn't seem to use the subpixel antialias (e.g. cleartype style) rendering setting, even though that option is set. I'll investigate further, it doesn't look like a regression due to this patch, but existing behavior. Kind Regards, Pieter On Sun, 2022-03-27 at 08:59 +0800, Po Lu wrote: > Pieter van Prooijen writes: > > > Hello All, > > > > Thanks for looking into my patch!, I'll fix the formatting issues > > you > > mentioned and narrow the changes to the HAVE_PGTK define in the > > various > > source files, so it's is only present for that build. > > Indeed, and thanks for working on Emacs as well. > > > Not sure about having this functionality controlled by a user > > defined > > variable (as is possible with using the system font), as far as I > > know, > > the current cairo X backend doesn't have this as well, it will > > always > > use the gsettings/xrdb defined parameters for rendering. > > We don't support using the PGTK build on X Windows anyway, so that's > not > a real problem.  Besides, manually specified font options will > override > whatever Cairo thinks is best. > > > Regarding the re-rendering upon a config change, I'll have a look > > at > > the options mentioned (clearing the font cache and marking each > > frame > > for redisplay), but that will probably be a separate patch. > > I think it would be best to have that feature as part of this change. --=-umKXohLniwe+xo2fRDwk Content-Disposition: attachment; filename*0=0001-Use-gsettings-font-rendering-entries-for-pgtk-builds.pat; filename*1=ch Content-Type: text/x-patch; name="0001-Use-gsettings-font-rendering-entries-for-pgtk-builds.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSBiYzBhYTIzNzc3ZjJhYWU0MmIyOTU5N2EwNGMwZDE0MDA3MDYzMTQ5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaWV0ZXIgdmFuIFByb29pamVuIDxwaWV0ZXIudmFuLnByb29p amVuQHRlbG9kZW4ubmw+CkRhdGU6IFR1ZSwgMjkgTWFyIDIwMjIgMjE6MjE6NTIgKzAyMDAKU3Vi amVjdDogW1BBVENIXSBVc2UgZ3NldHRpbmdzIGZvbnQgcmVuZGVyaW5nIGVudHJpZXMgZm9yIHBn dGsgYnVpbGRzCgpJZiBwcmVzZW50LCBhcHBseSB0aGUgZ3NldHRpbmdzIGZvbnQgaGludGluZyBh bmQgYW50aWFsaWFzaW5nIGVudHJpZXMKd2hlbiBjcmVhdGluZyBhIGZvbnQgaW4gY2Fpcm8uICBE byB0aGlzIGF0IGluaXRpYWxpemF0aW9uIGFuZCB3aGVuIHRoZQplbnRyaWVzIGNoYW5nZSwgcmUt cmVuZGVyaW5nIHRoZSBmcmFtZXMuCgoqIHNyYy9mdGNyZm9udC5jIChmdGNyZm9udF9vcGVuKTog VXNlIHRoZSBmb250X29wdGlvbnMgZGVyaXZlZCBmcm9tIGdzZXR0aW5ncwogIHdoZW4gb3Blbmlu ZyBhIGZvbnQuCiogc3JjL2Z0Y3Jmb250LmM6IChmdGNyZm9udF9jYWNoZWRfZm9udF9vayk6IFJl cG9ydCBhIGNhY2hlZCBmb250IGFzIGludmFsaWQKICBpZiBpdHMgZm9udCBvcHRpb25zIGRpZmZl ciBmcm9tIHRoZSBjdXJyZW50IGdzZXR0aW5ncyBvbmVzLgoqIHNyYy94c2V0dGluZ3MuYywgc3Jj L3hzZXR0aW5ncy5oICh4c2V0dGluZ3NfZ2V0X2ZvbnRfb3B0aW9ucyk6IFJldHJpZXZlIHRoZQog IGN1cnJlbnQgZ3NldHRpbmdzIGRlcml2ZWQgY2Fpcm8gZm9udF9vcHRpb25zLgoqIHNyYy94c2V0 dGluZ3MuYyAoYXBwbHlfZ3NldHRpbmdzX2ZvbnRfaGludGluZyk6IENvbnZlcnQgdGhlIGdzZXR0 aW5ncyBoaW50CiAgc2V0dGluZyB0byB0aGUgZm9udF9vcHRpb25zIHN0cnVjdC4KKiBzcmMveHNl dHRpbmdzLmMgKGFwcGx5X2dzZXR0aW5nc19mb250X2FudGlhbGlhcyk6IENvbnZlcnQgdGhlIGdz ZXR0aW5ncwogIGFudGlhbGlhcyBzZXR0aW5nIHRvIHRoZSBmb250X29wdGlvbnMgc3RydWN0Lgoq IHNyYy94c2V0dGluZ3MuYyAoYXBwbHlfZ3NldHRpbmdzX2ZvbnRfcmdiYV9vcmRlcik6IENvbnZl cnQgdGhlIGdzZXR0aW5ncwogIHJnYmEgb3JkZXIgc2V0dGluZyB0byB0aGUgZm9udF9vcHRpb25z IHN0cnVjdC4KKiBzcmMveHNldHRpbmdzLmMgKGluaXRfZ3NldHRpbmdzKTogSW52b2tlIHRoZSBh cHBseSBmdW5jdGlvbnMgd2hlbgogIGluaXRpYWxpemluZyBmcm9tIGdzZXR0aW5ncy4KKiBzcmMv eHNldHRpbmdzLmMgKHNvbWV0aGluZ19jaGFuZ2VkX2dzZXR0aW5nc0NCKTogSW52b2tlIHRoZSBh cHBseSBmdW5jdGlvbnMKICBpZiB0aGUgcmVsZXZhbnQgZ3NldHRpbmdzIGNoYW5nZWQuCiogc3Jj L3hzZXR0aW5ncy5jIChzdG9yZV9mb250X29wdGlvbnNfY2hhbmdlZCk6IFN0b3JlIGFuIGV2ZW50 IHRvIHJlLXJlbmRlcgogIHRoZSBmb250cy4KLS0tCiBzcmMvZnRjcmZvbnQuYyAgfCAgMzIgKysr KysrKysrKwogc3JjL3hzZXR0aW5ncy5jIHwgMTUxICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKwogc3JjL3hzZXR0aW5ncy5oIHwgICA0ICsrCiAzIGZpbGVz IGNoYW5nZWQsIDE4NyBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3JjL2Z0Y3Jmb250LmMg Yi9zcmMvZnRjcmZvbnQuYwppbmRleCA5OGEyOGFmNWYyLi4xMDNkYTkzZDUxIDEwMDY0NAotLS0g YS9zcmMvZnRjcmZvbnQuYworKysgYi9zcmMvZnRjcmZvbnQuYwpAQCAtMzcsNiArMzcsOSBAQAog I2luY2x1ZGUgImZvbnQuaCIKICNpbmNsdWRlICJmdGZvbnQuaCIKICNpbmNsdWRlICJwZHVtcGVy LmgiCisjaWZkZWYgSEFWRV9QR1RLCisjaW5jbHVkZSAieHNldHRpbmdzLmgiCisjZW5kaWYKIAog I2lmZGVmIFVTRV9CRV9DQUlSTwogI2RlZmluZSBSRURfRlJPTV9VTE9ORyhjb2xvcikJKCgoY29s b3IpID4+IDE2KSAmIDB4ZmYpCkBAIC0xNjgsNyArMTcxLDEyIEBAIGZ0Y3Jmb250X29wZW4gKHN0 cnVjdCBmcmFtZSAqZiwgTGlzcF9PYmplY3QgZW50aXR5LCBpbnQgcGl4ZWxfc2l6ZSkKICAgY2Fp cm9fbWF0cml4X3QgZm9udF9tYXRyaXgsIGN0bTsKICAgY2Fpcm9fbWF0cml4X2luaXRfc2NhbGUg KCZmb250X21hdHJpeCwgcGl4ZWxfc2l6ZSwgcGl4ZWxfc2l6ZSk7CiAgIGNhaXJvX21hdHJpeF9p bml0X2lkZW50aXR5ICgmY3RtKTsKKworI2lmZGVmIEhBVkVfUEdUSworICBjYWlyb19mb250X29w dGlvbnNfdCAqb3B0aW9ucyA9IHhzZXR0aW5nc19nZXRfZm9udF9vcHRpb25zICgpOworI2Vsc2UK ICAgY2Fpcm9fZm9udF9vcHRpb25zX3QgKm9wdGlvbnMgPSBjYWlyb19mb250X29wdGlvbnNfY3Jl YXRlICgpOworI2VuZGlmCiAjaWZkZWYgVVNFX0JFX0NBSVJPCiAgIGlmIChiZV91c2Vfc3VicGl4 ZWxfYW50aWFsaWFzaW5nICgpKQogICAgIGNhaXJvX2ZvbnRfb3B0aW9uc19zZXRfYW50aWFsaWFz IChvcHRpb25zLCBDQUlST19BTlRJQUxJQVNfU1VCUElYRUwpOwpAQCAtNjI0LDYgKzYzMiwyNyBA QCBmdGNyZm9udF9kcmF3IChzdHJ1Y3QgZ2x5cGhfc3RyaW5nICpzLAogICByZXR1cm4gbGVuOwog fQogCisjaWZkZWYgSEFWRV9QR1RLCisvKiBEZXRlcm1pbmUgaWYgdGhlIGNhY2hlZCBmb250IHNo b3VsZCBiZSByZS1vcGVuZWQsIGJ5IGNvbXBhcmluZworICAgaXRzIGZvbnRfb3B0aW9ucyB3aXRo IHRoZSBvbmVzIGRlcml2ZWQgZnJvbSBnc2V0dGluZ3MuICAqLworc3RhdGljIGJvb2wKK2Z0Y3Jm b250X2NhY2hlZF9mb250X29rIChzdHJ1Y3QgZnJhbWUgKmYsIExpc3BfT2JqZWN0IGZvbnRfb2Jq ZWN0LAorCQkJIExpc3BfT2JqZWN0IGVudGl0eSkKK3sKKyAgc3RydWN0IGZvbnRfaW5mbyAqaW5m byA9IChzdHJ1Y3QgZm9udF9pbmZvICopIFhGT05UX09CSkVDVCAoZm9udF9vYmplY3QpOworCisg IGNhaXJvX2ZvbnRfb3B0aW9uc190ICpvcHRpb25zID0gY2Fpcm9fZm9udF9vcHRpb25zX2NyZWF0 ZSAoKTsKKyAgY2Fpcm9fc2NhbGVkX2ZvbnRfZ2V0X2ZvbnRfb3B0aW9ucyAoaW5mby0+Y3Jfc2Nh bGVkX2ZvbnQsIG9wdGlvbnMpOworICBjYWlyb19mb250X29wdGlvbnNfdCAqZ3NldHRpbmdzX29w dGlvbnMgPSB4c2V0dGluZ3NfZ2V0X2ZvbnRfb3B0aW9ucyAoKTsKKworICBib29sIGVxdWFsID0g Y2Fpcm9fZm9udF9vcHRpb25zX2VxdWFsIChvcHRpb25zLCBnc2V0dGluZ3Nfb3B0aW9ucyk7Cisg IGNhaXJvX2ZvbnRfb3B0aW9uc19kZXN0cm95IChvcHRpb25zKTsKKyAgY2Fpcm9fZm9udF9vcHRp b25zX2Rlc3Ryb3kgKGdzZXR0aW5nc19vcHRpb25zKTsKKworICByZXR1cm4gZXF1YWw7Cit9Cisj ZW5kaWYKKwogI2lmZGVmIEhBVkVfSEFSRkJVWloKIAogc3RhdGljIExpc3BfT2JqZWN0CkBAIC02 OTQsNiArNzIzLDkgQEAgZnRjcmhiZm9udF9lbmRfaGJfZm9udCAoc3RydWN0IGZvbnQgKmZvbnQs IGhiX2ZvbnRfdCAqaGJfZm9udCkKICNlbmRpZgogICAuZmlsdGVyX3Byb3BlcnRpZXMgPSBmdGZv bnRfZmlsdGVyX3Byb3BlcnRpZXMsCiAgIC5jb21iaW5pbmdfY2FwYWJpbGl0eSA9IGZ0Zm9udF9j b21iaW5pbmdfY2FwYWJpbGl0eSwKKyNpZmRlZiBIQVZFX1BHVEsKKyAgLmNhY2hlZF9mb250X29r ID0gZnRjcmZvbnRfY2FjaGVkX2ZvbnRfb2sKKyNlbmRpZgogICB9OwogI2lmZGVmIEhBVkVfSEFS RkJVWloKIHN0cnVjdCBmb250X2RyaXZlciBmdGNyaGJmb250X2RyaXZlcjsKZGlmZiAtLWdpdCBh L3NyYy94c2V0dGluZ3MuYyBiL3NyYy94c2V0dGluZ3MuYwppbmRleCA3MWQwMmU2MTUyLi4yNTM4 YWI1MWIzIDEwMDY0NAotLS0gYS9zcmMveHNldHRpbmdzLmMKKysrIGIvc3JjL3hzZXR0aW5ncy5j CkBAIC0yMTUsMTEgKzIxNSwxMTggQEAgI2RlZmluZSBHU0VUVElOR1NfTU9OT19GT05UICAibW9u b3NwYWNlLWZvbnQtbmFtZSIKICNkZWZpbmUgR1NFVFRJTkdTX0ZPTlRfTkFNRSAgImZvbnQtbmFt ZSIKICNlbmRpZgogCisjaWZkZWYgSEFWRV9QR1RLCisjZGVmaW5lIEdTRVRUSU5HU19GT05UX0FO VElBTElBU0lORyAgImZvbnQtYW50aWFsaWFzaW5nIgorI2RlZmluZSBHU0VUVElOR1NfRk9OVF9S R0JBX09SREVSICAgICJmb250LXJnYmEtb3JkZXIiCisjZGVmaW5lIEdTRVRUSU5HU19GT05UX0hJ TlRJTkcgICAgICAgImZvbnQtaGludGluZyIKKyNlbmRpZgogCiAvKiBUaGUgc2luZ2xlIEdTZXR0 aW5ncyBpbnN0YW5jZSwgb3IgTlVMTCBpZiBub3QgY29ubmVjdGVkIHRvIEdTZXR0aW5ncy4gICov CiAKIHN0YXRpYyBHU2V0dGluZ3MgKmdzZXR0aW5nc19jbGllbnQ7CiAKKyNpZmRlZiBIQVZFX1BH VEsKKworLyogVGhlIGNhaXJvIGZvbnRfb3B0aW9ucyBhcyBvYnRhaW5lZCB1c2luZyBnc2V0dGlu Z3MuICAqLworc3RhdGljIGNhaXJvX2ZvbnRfb3B0aW9uc190ICpmb250X29wdGlvbnM7CisKKy8q IFN0b3JlIGFuIGV2ZW50IGZvciByZS1yZW5kZXJpbmcgb2YgdGhlIGZvbnRzLiAgKi8KK3N0YXRp YyB2b2lkCitzdG9yZV9mb250X29wdGlvbnNfY2hhbmdlZCAodm9pZCkKK3sKKyAgaWYgKGRweWlu Zm9fdmFsaWQgKGZpcnN0X2RweWluZm8pKQorICAgIHsKKyAgICAgIHN0b3JlX2NvbmZpZ19jaGFu Z2VkX2V2ZW50IChRZm9udF9yZW5kZXIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgWENBUiAoZmlyc3RfZHB5aW5mby0+bmFtZV9saXN0X2VsZW1lbnQpKTsKKyAgICB9Cit9CisK Ky8qIEFwcGx5IGNoYW5nZXMgaW4gdGhlIGhpbnRpbmcgc3lzdGVtIHNldHRpbmcuICAqLworc3Rh dGljIHZvaWQKK2FwcGx5X2dzZXR0aW5nc19mb250X2hpbnRpbmcgKEdTZXR0aW5ncyAqc2V0dGlu Z3MpCit7CisgIEdWYXJpYW50ICp2YWwgPSBnX3NldHRpbmdzX2dldF92YWx1ZSAoc2V0dGluZ3Ms IEdTRVRUSU5HU19GT05UX0hJTlRJTkcpOworICBpZiAodmFsKQorICAgIHsKKyAgICAgIGdfdmFy aWFudF9yZWZfc2luayAodmFsKTsKKyAgICAgIGlmIChnX3ZhcmlhbnRfaXNfb2ZfdHlwZSAodmFs LCBHX1ZBUklBTlRfVFlQRV9TVFJJTkcpKQorCXsKKwkgIGNvbnN0IGNoYXIgKmhpbnRpbmcgPSBn X3ZhcmlhbnRfZ2V0X3N0cmluZyAodmFsLCBOVUxMKTsKKworCSAgaWYgKCFzdHJjbXAgKGhpbnRp bmcsICJmdWxsIikpCisJICAgIGNhaXJvX2ZvbnRfb3B0aW9uc19zZXRfaGludF9zdHlsZSAoZm9u dF9vcHRpb25zLAorCQkJCQkgICAgICAgQ0FJUk9fSElOVF9TVFlMRV9GVUxMKTsKKwkgIGVsc2Ug aWYgKCFzdHJjbXAgKGhpbnRpbmcsICJtZWRpdW0iKSkKKwkgICAgY2Fpcm9fZm9udF9vcHRpb25z X3NldF9oaW50X3N0eWxlIChmb250X29wdGlvbnMsCisJCQkJCSAgICAgICBDQUlST19ISU5UX1NU WUxFX01FRElVTSk7CisJICBlbHNlIGlmICghc3RyY21wIChoaW50aW5nLCAic2xpZ2h0IikpCisJ ICAgIGNhaXJvX2ZvbnRfb3B0aW9uc19zZXRfaGludF9zdHlsZSAoZm9udF9vcHRpb25zLAorCQkJ CQkgICAgICAgQ0FJUk9fSElOVF9TVFlMRV9TTElHSFQpOworCSAgZWxzZSBpZiAoIXN0cmNtcCAo aGludGluZywgIm5vbmUiKSkKKwkgICAgY2Fpcm9fZm9udF9vcHRpb25zX3NldF9oaW50X3N0eWxl IChmb250X29wdGlvbnMsCisJCQkJCSAgICAgICBDQUlST19ISU5UX1NUWUxFX05PTkUpOworCX0K KyAgICAgIGdfdmFyaWFudF91bnJlZiAodmFsKTsKKyAgICB9Cit9CisKKy8qIEFwcGx5IGNoYW5n ZXMgaW4gdGhlIGFudGlhbGlhc2luZyBzeXN0ZW0gc2V0dGluZy4gICovCitzdGF0aWMgdm9pZAor YXBwbHlfZ3NldHRpbmdzX2ZvbnRfYW50aWFsaWFzIChHU2V0dGluZ3MgKnNldHRpbmdzKQorewor ICBHVmFyaWFudCAqdmFsID0gZ19zZXR0aW5nc19nZXRfdmFsdWUgKHNldHRpbmdzLCBHU0VUVElO R1NfRk9OVF9BTlRJQUxJQVNJTkcpOworICBpZiAodmFsKQorICAgIHsKKyAgICAgIGdfdmFyaWFu dF9yZWZfc2luayAodmFsKTsKKyAgICAgIGlmIChnX3ZhcmlhbnRfaXNfb2ZfdHlwZSAodmFsLCBH X1ZBUklBTlRfVFlQRV9TVFJJTkcpKQorCXsKKwkgIGNvbnN0IGNoYXIgKmFudGlhbGlhcyA9IGdf dmFyaWFudF9nZXRfc3RyaW5nICh2YWwsIE5VTEwpOworCisJICBpZiAoIXN0cmNtcCAoYW50aWFs aWFzLCAibm9uZSIpKQorCSAgICBjYWlyb19mb250X29wdGlvbnNfc2V0X2FudGlhbGlhcyAoZm9u dF9vcHRpb25zLAorCQkJCQkgICAgICBDQUlST19BTlRJQUxJQVNfTk9ORSk7CisJICBlbHNlIGlm ICghc3RyY21wIChhbnRpYWxpYXMsICJncmF5c2NhbGUiKSkKKwkgICAgY2Fpcm9fZm9udF9vcHRp b25zX3NldF9hbnRpYWxpYXMgKGZvbnRfb3B0aW9ucywKKwkJCQkJICAgICAgQ0FJUk9fQU5USUFM SUFTX0dSQVkpOworCSAgZWxzZSBpZiAoIXN0cmNtcCAoYW50aWFsaWFzLCAicmdiYSIpKQorCSAg ICBjYWlyb19mb250X29wdGlvbnNfc2V0X2FudGlhbGlhcyAoZm9udF9vcHRpb25zLAorCQkJCQkg ICAgICBDQUlST19BTlRJQUxJQVNfU1VCUElYRUwpOworCX0KKyAgICAgIGdfdmFyaWFudF91bnJl ZiAodmFsKTsKKyAgICB9Cit9CisKKy8qIEFwcGx5IHRoZSBzZXR0aW5ncyBmb3IgdGhlIHJnYiBl bGVtZW50IG9yZGVyaW5nLiAgKi8KK3N0YXRpYyB2b2lkCithcHBseV9nc2V0dGluZ3NfZm9udF9y Z2JhX29yZGVyIChHU2V0dGluZ3MgKnNldHRpbmdzKQoreworICBHVmFyaWFudCAqdmFsID0gZ19z ZXR0aW5nc19nZXRfdmFsdWUgKHNldHRpbmdzLAorCQkJCQlHU0VUVElOR1NfRk9OVF9SR0JBX09S REVSKTsKKyAgaWYgKHZhbCkKKyAgICB7CisgICAgICBnX3ZhcmlhbnRfcmVmX3NpbmsgKHZhbCk7 CisgICAgICBpZiAoZ192YXJpYW50X2lzX29mX3R5cGUgKHZhbCwgR19WQVJJQU5UX1RZUEVfU1RS SU5HKSkKKwl7CisJICBjb25zdCBjaGFyICpyZ2JhX29yZGVyID0gZ192YXJpYW50X2dldF9zdHJp bmcgKHZhbCwgTlVMTCk7CisKKwkgIGlmICghc3RyY21wIChyZ2JhX29yZGVyLCAicmdiIikpCisJ ICAgIGNhaXJvX2ZvbnRfb3B0aW9uc19zZXRfc3VicGl4ZWxfb3JkZXIgKGZvbnRfb3B0aW9ucywK KwkJCQkJCSAgIENBSVJPX1NVQlBJWEVMX09SREVSX1JHQik7CisJICBlbHNlIGlmICghc3RyY21w IChyZ2JhX29yZGVyLCAiYmdyIikpCisJICAgIGNhaXJvX2ZvbnRfb3B0aW9uc19zZXRfc3VicGl4 ZWxfb3JkZXIgKGZvbnRfb3B0aW9ucywKKwkJCQkJCSAgIENBSVJPX1NVQlBJWEVMX09SREVSX0JH Uik7CisJICBlbHNlIGlmICghc3RyY21wIChyZ2JhX29yZGVyLCAidnJnYiIpKQorCSAgICBjYWly b19mb250X29wdGlvbnNfc2V0X3N1YnBpeGVsX29yZGVyIChmb250X29wdGlvbnMsCisJCQkJCQkg ICBDQUlST19TVUJQSVhFTF9PUkRFUl9WUkdCKTsKKwkgIGVsc2UgaWYgKCFzdHJjbXAgKHJnYmFf b3JkZXIsICJ2YmdyIikpCisJICAgIGNhaXJvX2ZvbnRfb3B0aW9uc19zZXRfc3VicGl4ZWxfb3Jk ZXIgKGZvbnRfb3B0aW9ucywKKwkJCQkJCSAgIENBSVJPX1NVQlBJWEVMX09SREVSX1ZCR1IpOwor CX0KKyAgICAgIGdfdmFyaWFudF91bnJlZiAodmFsKTsKKyAgICB9Cit9CisjZW5kaWYgLyogSEFW RV9QR1RLICovCisKIC8qIENhbGxiYWNrIGNhbGxlZCB3aGVuIHNvbWV0aGluZyBjaGFuZ2VkIGlu IEdTZXR0aW5ncy4gICovCiAKIHN0YXRpYyB2b2lkCkBAIC0yNzMsNiArMzgwLDIzIEBAIHNvbWV0 aGluZ19jaGFuZ2VkX2dzZXR0aW5nc0NCIChHU2V0dGluZ3MgKnNldHRpbmdzLAogICAgICAgICB9 CiAgICAgfQogI2VuZGlmIC8qIFVTRV9DQUlSTyB8fCBIQVZFX1hGVCAqLworI2lmZGVmIEhBVkVf UEdUSworICBlbHNlIGlmIChzdHJjbXAgKGtleSwgR1NFVFRJTkdTX0ZPTlRfQU5USUFMSUFTSU5H KSA9PSAwKQorICAgIHsKKyAgICAgIGFwcGx5X2dzZXR0aW5nc19mb250X2FudGlhbGlhcyAoc2V0 dGluZ3MpOworICAgICAgc3RvcmVfZm9udF9vcHRpb25zX2NoYW5nZWQgKCk7CisgICAgfQorICBl bHNlIGlmIChzdHJjbXAgKGtleSwgR1NFVFRJTkdTX0ZPTlRfSElOVElORykgPT0gMCkKKyAgICB7 CisgICAgICBhcHBseV9nc2V0dGluZ3NfZm9udF9oaW50aW5nIChzZXR0aW5ncyk7CisgICAgICBz dG9yZV9mb250X29wdGlvbnNfY2hhbmdlZCAoKTsKKyAgICB9CisgIGVsc2UgaWYgKHN0cmNtcCAo a2V5LCBHU0VUVElOR1NfRk9OVF9SR0JBX09SREVSKSA9PSAwKQorICAgIHsKKyAgICAgIGFwcGx5 X2dzZXR0aW5nc19mb250X3JnYmFfb3JkZXIgKHNldHRpbmdzKTsKKyAgICAgIHN0b3JlX2ZvbnRf b3B0aW9uc19jaGFuZ2VkICgpOworICAgIH0KKyNlbmRpZiAvKiBIQVZFX1BHVEsgKi8KIH0KIAog I2VuZGlmIC8qIEhBVkVfR1NFVFRJTkdTICovCkBAIC05MDAsNiArMTAyNCwxOCBAQCBpbml0X2dz ZXR0aW5ncyAodm9pZCkKICAgICAgICAgZHVwc3RyaW5nICgmY3VycmVudF9mb250LCBnX3Zhcmlh bnRfZ2V0X3N0cmluZyAodmFsLCBOVUxMKSk7CiAgICAgICBnX3ZhcmlhbnRfdW5yZWYgKHZhbCk7 CiAgICAgfQorCisgIC8qIE9ubHkgdXNlIHRoZSBnc2V0dGluZ3MgZm9udCBlbnRyaWVzIGZvciBu b24tWDExIGNhaXJvIGJhY2tlbmRzCisgICAgICh3aGljaCBpcyB0aGUgcmVjb21tZW5kZWQgd2F5 IG9mIHJ1bm5pbmcgcGd0ayBidWlsZHMpLgorICAgICBGb3IgdGhlIFgxMSBiYWNrZW5kIGNhaXJv IHdpbGwgYXBwbHkgdGhlc2UgZW50cmllcyBpdHNlbGYsCisgICAgIHJlYWRpbmcgdGhlbSBmcm9t IHhyZGIuICAqLworI2lmZGVmIEhBVkVfUEdUSworICBmb250X29wdGlvbnMgPSBjYWlyb19mb250 X29wdGlvbnNfY3JlYXRlICgpOworICBhcHBseV9nc2V0dGluZ3NfZm9udF9hbnRpYWxpYXMgKGdz ZXR0aW5nc19jbGllbnQpOworICBhcHBseV9nc2V0dGluZ3NfZm9udF9oaW50aW5nIChnc2V0dGlu Z3NfY2xpZW50KTsKKyAgYXBwbHlfZ3NldHRpbmdzX2ZvbnRfcmdiYV9vcmRlciAoZ3NldHRpbmdz X2NsaWVudCk7CisjZW5kaWYgLyogSEFWRV9QR1RLICovCisKICNlbmRpZiAvKiBVU0VfQ0FJUk8g fHwgSEFWRV9YRlQgKi8KIAogI2VuZGlmIC8qIEhBVkVfR1NFVFRJTkdTICovCkBAIC0xMDIxLDYg KzExNTcsMTcgQEAgeHNldHRpbmdzX2dldF9zeXN0ZW1fbm9ybWFsX2ZvbnQgKHZvaWQpCiB9CiAj ZW5kaWYKIAorI2lmZGVmIEhBVkVfUEdUSworLyogUmV0dXJuIHRoZSBjYWlybyBmb250IG9wdGlv bnMsIHVwZGF0ZWQgZnJvbSB0aGUgZ3NldHRpbmdzIGZvbnQKKyAgIGNvbmZpZyBlbnRyaWVzLiBU aGUgY2FsbGVyIHNob3VsZCBjYWxsIGNhaXJvX2ZvbnRfb3B0aW9uc19kZXN0cm95CisgICBvbiB0 aGUgcmVzdWx0LiAgKi8KK2NhaXJvX2ZvbnRfb3B0aW9uc190ICoKK3hzZXR0aW5nc19nZXRfZm9u dF9vcHRpb25zICh2b2lkKQoreworICByZXR1cm4gY2Fpcm9fZm9udF9vcHRpb25zX2NvcHkgKGZv bnRfb3B0aW9ucyk7Cit9CisjZW5kaWYKKwogREVGVU4gKCJmb250LWdldC1zeXN0ZW0tbm9ybWFs LWZvbnQiLCBGZm9udF9nZXRfc3lzdGVtX25vcm1hbF9mb250LAogICAgICAgIFNmb250X2dldF9z eXN0ZW1fbm9ybWFsX2ZvbnQsCiAgICAgICAgMCwgMCwgMCwKQEAgLTEwNzMsNiArMTIyMCwxMCBA QCBzeW1zX29mX3hzZXR0aW5ncyAodm9pZCkKICAgZ2NvbmZfY2xpZW50ID0gTlVMTDsKICAgUERV TVBFUl9JR05PUkUgKGdjb25mX2NsaWVudCk7CiAjZW5kaWYKKyNpZmRlZiBIQVZFX1BHVEsKKyAg Zm9udF9vcHRpb25zID0gTlVMTDsKKyAgUERVTVBFUl9JR05PUkUgKGZvbnRfb3B0aW9ucyk7Cisj ZW5kaWYKIAogICBERUZTWU0gKFFtb25vc3BhY2VfZm9udF9uYW1lLCAibW9ub3NwYWNlLWZvbnQt bmFtZSIpOwogICBERUZTWU0gKFFmb250X25hbWUsICJmb250LW5hbWUiKTsKZGlmZiAtLWdpdCBh L3NyYy94c2V0dGluZ3MuaCBiL3NyYy94c2V0dGluZ3MuaAppbmRleCBjY2FhMzY0ODlkLi5jN2Zl ODYxYzQwIDEwMDY0NAotLS0gYS9zcmMveHNldHRpbmdzLmgKKysrIGIvc3JjL3hzZXR0aW5ncy5o CkBAIC00MSw1ICs0MSw5IEBAICNkZWZpbmUgWFNFVFRJTkdTX0gKIGV4dGVybiBjb25zdCBjaGFy ICp4c2V0dGluZ3NfZ2V0X3N5c3RlbV9ub3JtYWxfZm9udCAodm9pZCk7CiAjZW5kaWYKIAorI2lm ZGVmIEhBVkVfUEdUSworI2luY2x1ZGUgPGNhaXJvLmg+CitleHRlcm4gY2Fpcm9fZm9udF9vcHRp b25zX3QgKnhzZXR0aW5nc19nZXRfZm9udF9vcHRpb25zICh2b2lkKTsKKyNlbmRpZgogCiAjZW5k aWYgLyogWFNFVFRJTkdTX0ggKi8KLS0gCjIuMzIuMAoK --=-umKXohLniwe+xo2fRDwk-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 30 04:59:45 2022 Received: (at 54564) by debbugs.gnu.org; 30 Mar 2022 08:59:45 +0000 Received: from localhost ([127.0.0.1]:34480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZUB6-0000Ou-Jc for submit@debbugs.gnu.org; Wed, 30 Mar 2022 04:59:44 -0400 Received: from sonic314-22.consmr.mail.ne1.yahoo.com ([66.163.189.148]:45533) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZUB4-0000Of-K0 for 54564@debbugs.gnu.org; Wed, 30 Mar 2022 04:59:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648630776; bh=SM8gmA0l2BxYLeLli5/CkoxO6ycrA6QWb56x5RBCxWs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=JVB4COZaKjfMKNLLR8P0gU0Q9+81DSugV2fNlWpved2wEsn8Uaoemeoc7pepTDDlDCDxSue6sPfslvU48fycYv6wxxsTyGwNNsM/53usWIDNfvDrWXZ8p+c7EELBuDI/K/WxTK6JTxur3cn4Nly00s+0mFfx9FRr+YXQ4bpTZ0MX1Xxx1vYe50tCPQ7SkhgUjAvmQEj6d/nvRUgEwQkstBmh/MlYqy1yhjGPfHKHfq7MYIIUTp4XW1FYt8WIeIlHt3h6OYUh4W6mrWcRn3937gVAsif+RjAV7jQiwFzSXAtKerrzdbZtiOrfKV8lVS0B9R5alwJJMT6sINMAqI/JpA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648630776; bh=jh+/uQeFHtDOsKVuz0zkLzLUVDouiplOa9w3cpOWPzv=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=ouryCZ5brkdVUpSk5l98iQ6D+P1jHslBJAUehudCimBLvaHS6ZOBh66BQmI0EEoyJu7xkYG2OL/LMmlq7u+2s3yM9I1UU9lYvy9FCyHAvdhLyDFHGPG6oxJxjVJjD2SzM8aD3UL+qwdiKaFJMIu8WXUq02gPwUmxdNq+PvIi4GCi7kN/Nf1I2XqUe/lYkQxVIiLKcx3JybQK6CF11JX+qf1yan86up2/+iV7qixyM4B1cFMm03qCDZwM+RQWnkTivJRRimxbgVJoufVXxH/6BqPj9UvK/yX0mBAeyZ8gxmgUinJQW00TUsWKO+RBnbjcmhe2Sq8Px6c2Gl9GXQyZTA== X-YMail-OSG: oLaReNMVM1kWN0yndYvNIbl9XlTurMIKuZNUVuiT2_t1GJbhJkRvKqB3RymDqfw wQqgCQyF12OTrI3GldRUUmfjErRynQIakvx7.rUQ23LzfhczEIqTfDI1s.h0JS0KBNoXJdH1GFgx HI8wRUgB48LfyFmdZXu2PnYGcc0TTb9.uD69kdD81SvjRVLxKpDNZPslt2HxUQOtsFCMroCNp0qP l1R2jGRn0TiUwnPLi.iZTDLi3F9NM7bV_yRnZu_69YHpFmo94dSdj_7ahqKQtinDRq021csnppB9 r2lEwkNFTfnfJr.CRktxFOHNrXWFoyiv6L9FHX.JzI4PiR5uViKzCdNN1bCgphvetx3.5DPvtXhZ Dks8M2j8akEOJxznSHTHgWTltswVWkvEh0zrTnaVnggqzcSVgvvwh2DxLrsvTW6P3jdJaZqxrUl8 6dlx9XH0dF7hqOQtorWyi.3meAIDVQH6NK2cjJvpJiYN0..BQu_44TiiyEF2iNv3m6pDwVbZB4V7 p18X0xsmMhdaJI.yYc_1vksBH9yoQUtRtlnHwyGRPexN3nQY6y2ato2T7gfjcSBijI6.nxGPIJa9 tdMwtdMG11sknVZfMu9ZPLCg5GyYTXfuaTHT.7QwRBdapDUsJmPPSh1kdeCjKY9Q8jycVloq5.NA Pp7ymDbBeBm1fUktCzvSFZJW4aRHu5KQBsIvUoL.XbOfR7dqW3SAZB0YxGp.75fPy0BvFVoEGEOA c9iBDx9VOyzQAxfCjG1OTuT1EYOQpdop1fJgurXDJiQvq0p6uCE6gNjVBBDJVb5tWzzRB9_QvGzP SRrxxqwyMAleD0WR4N42Hdg6RZurMNerWMiYM2hGKD3g3dRrSTp18aqQE_Osv8k7Gct4xxWsuCJx uQwVX9e.4cs8UhuUcwD._jJwQMd3HL23g4uzgWvS.sHFkHub8iYH.U7hZ19BVQfDZptDJwyhWHG_ 9hbRSXkdLLZem8iEVozHcRHhjhpfHRHp.uQ..nVx5arTeBNcZHfhd6gLxAwwV1i7bYBKvE2RVZ6i ajNWT92sHWRC7_v4O7RI2gepyYpQoIW5.QnPhI1Ea7f8dtt01lJkVdg_jdUseE.7_W5JsaVMn_ym 7YukvvqNJSkyf3o7LKVuob50rac6vGy9QyccgkdfhhRFlEDEtjmPUKKlL2npUwgcOq6OaPUyBnr7 rmtEwKo1c0kdiQbFMTAgrfRQ.1PKG2RBIZvi5u4SIEb1vfhlViK3FH0dmHZ23DZNJT2g1OgFhls_ cfTcfZh5A6Jsncp5yO0I_wdzKdYfiTebIfavSgONVDkFk0hnXUr7tD.6y8Ighe7Z8ylVg..SI9Wq 8phJOFxGty65vZraGDX8NRut0RW6rdaUMahA.SnNxkUDD7SEnaRMhqbbgKpi1hrLwY7dZGV5xdF3 weHHhFndPQI5UKw1AgJVHlQ3LvbZDazVWneTfzcEaXM4l1iWUw3G8aYPNvyIUzTa6.qssQv6opwQ 6qUogj.PYGtbNJbnTo5Q4LMkYkt.14dt9QpQvr8HtB2bwUQy8_72Z0MXlriGg9TvTiYhcXxp1y8d ddNMfR7Meg1UFHZ3TuE9kxW4UrTp4vlC6OHIo.uPaCokEAOZcZkigXk2V.5fq6psIpjNbNV8LMB0 VBluUlzNaZtrcMMyOhJclWetOm2UKPY4RXu_rlxybYXehIAp3Z4W38j0zaZggRlg3yEiVxriNhu8 KtlgUu0ZMCjXXrDOYEzI7XdbcYHHLpB0teTwK3HFYzy6oGuKC6_JgL_muUsKqQiN4Dpi5VLlWbL8 udyYd2gezDWrjpo4fJdShuQ8BLAR4VJSZOJKeE_qRbXDkcvRAEJ4LgnCGog9gf85gNn19GwKNMP. KmgqKLkSFN.rYDN7CdR3Mx2f6tUAFDk1PKQXpe3V78pXA6Xi33YoITMyr7DbDwc8zkFUVomnJTkv kZ2C.BPZcwWRyslmdQaGA9baenD8L1zgBEFmH64PKdVkEm2mnJs6wFipsoIEkNDqkoY06ohxva68 YazLywnRbHfMy6f6jcWnchaawBgi08wZjRuhFRfKeFW9CRUfGg1QD8MgJjMi7xpDpMguKle1.PeP 6l6wNmdrNm6Qde.1pZ3lXTNFwe_8oEbHeeLNWkaYlnA0p50DI7HJLStjioMfQuwiGLpyQgnS_XsW qVxgcSwrbh4o0R.hBs5qAMp5UrDA5N9WPOtjkU92gsAJBtD8tpcNRSUY4Zb9TFJTsJyR9vf.Zidr T2IxuUrH6zmMSmMlNAnmXmHacuYtjOdAkXhEQHx2WZkLY_bbN7jGn1uIvKKWh6qSD X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ne1.yahoo.com with HTTP; Wed, 30 Mar 2022 08:59:36 +0000 Received: by kubenode522.mail-prod1.omega.ne1.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID f1d37f93715ab141401f990b92f4bef0; Wed, 30 Mar 2022 08:59:32 +0000 (UTC) From: Po Lu To: Pieter van Prooijen Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> <83czi9b5gh.fsf@gnu.org> <87v8w143h6.fsf@yahoo.com> <87o81s2osr.fsf@yahoo.com> <88d833f72df4f4cbb5769f1a75057d3f957a812c.camel@teloden.nl> Date: Wed, 30 Mar 2022 16:59:19 +0800 In-Reply-To: <88d833f72df4f4cbb5769f1a75057d3f957a812c.camel@teloden.nl> (Pieter van Prooijen's message of "Wed, 30 Mar 2022 10:01:49 +0200") Message-ID: <87bkxnx1co.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20001 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 5072 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54564 Cc: Eli Zaretskii , 54564@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pieter van Prooijen writes: > Here's the second version of my patch to use the gsettings for font > rendering: Thanks. > When playing around with the font settings, I noticed that cairo/pgtk > doesn't seem to use the subpixel antialias (e.g. cleartype style) > rendering setting, even though that option is set. I'll investigate > further, it doesn't look like a regression due to this patch, but > existing behavior. It works here for me, so I don't know why you're seeing that behavior. There could be something wrong with fontconfig on your system. Some minor comments below: > * src/ftcrfont.c (ftcrfont_open): Use the font_options derived from gsettings > when opening a font. > * src/ftcrfont.c: (ftcrfont_cached_font_ok): Report a cached font as invalid > if its font options differ from the current gsettings ones. > * src/xsettings.c, src/xsettings.h (xsettings_get_font_options): Retrieve the > current gsettings derived cairo font_options. > * src/xsettings.c (apply_gsettings_font_hinting): Convert the gsettings hint > setting to the font_options struct. > * src/xsettings.c (apply_gsettings_font_antialias): Convert the gsettings > antialias setting to the font_options struct. > * src/xsettings.c (apply_gsettings_font_rgba_order): Convert the gsettings > rgba order setting to the font_options struct. > * src/xsettings.c (init_gsettings): Invoke the apply functions when > initializing from gsettings. > * src/xsettings.c (something_changed_gsettingsCB): Invoke the apply functions > if the relevant gsettings changed. > * src/xsettings.c (store_font_options_changed): Store an event to re-render > the fonts. Please don't indent the first asterisk of the filename inside the commit message, or the other lines of the text, and don't repeat the filename for each change within the same file. (You can type C-c C-w inside the *vc-log* buffer to generate an appropriate commit message.) In many cases there is also no need to repeat the same description of a change with changes to a single word. Here is how I would write the commit message (make sure the entire message is no wider than 64 characters): * src/ftcrfont.c (ftcrfont_open): Use the font_options derived from gsettings when opening a font. (ftcrfont_cached_font_ok): Report a cached font as invalid if its font options differ from the current options inside gsettings. * src/xsettings.c (apply_gsettings_font_hinting) (apply_gsettings_font_alias, apply_gsettings_font_rgba_order): Convert the settings from GSettings to the cairo_font_options_t object. (init_gsettings, something_changed_gsettingsCB): Invoke the apply functions if the relevant settings changed. (store_font_options_changed): Store an event to re-render the fonts. (xsetting_get_font_options) * src/xsettings.h (xsettings_get_font_options): New function. > +/* Determine if the cached font should be re-opened, by comparing > + its font_options with the ones derived from gsettings. */ I would say "determine if FONT_OBJECT is a valid cached font for ENTITY by comparing the options used to open it with the user's current preferences specified via GSettings". > +static void > +store_font_options_changed (void) > +{ > + if (dpyinfo_valid (first_dpyinfo)) > + { > + store_config_changed_event (Qfont_render, > + XCAR (first_dpyinfo->name_list_element)); > + } > +} Please remove the extra braces in this if statement. > +#ifdef HAVE_PGTK > + else if (strcmp (key, GSETTINGS_FONT_ANTIALIASING) == 0) > + { > + apply_gsettings_font_antialias (settings); > + store_font_options_changed (); > + } > + else if (strcmp (key, GSETTINGS_FONT_HINTING) == 0) > + { > + apply_gsettings_font_hinting (settings); > + store_font_options_changed (); > + } > + else if (strcmp (key, GSETTINGS_FONT_RGBA_ORDER) == 0) > + { > + apply_gsettings_font_rgba_order (settings); > + store_font_options_changed (); > + } > +#endif /* HAVE_PGTK */ > } Once again, please reword these tests as !strcmp (key, ... > + /* Only use the gsettings font entries for non-X11 cairo backends > + (which is the recommended way of running pgtk builds). > + For the X11 backend cairo will apply these entries itself, > + reading them from xrdb. */ > +#ifdef HAVE_PGTK > + font_options = cairo_font_options_create (); > + apply_gsettings_font_antialias (gsettings_client); > + apply_gsettings_font_hinting (gsettings_client); > + apply_gsettings_font_rgba_order (gsettings_client); > +#endif /* HAVE_PGTK */ This should say "the Cairo backend running on PGTK". > +/* Return the cairo font options, updated from the gsettings font > + config entries. The caller should call cairo_font_options_destroy > + on the result. */ This needs two spaces between "entries." and "The". > +#ifdef HAVE_PGTK > +#include Please move this include to the top of the file. Otherwise, LGTM. Thanks for working on Emacs. Have you completed the necessary copyright paperwork? From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 31 13:31:10 2022 Received: (at 54564) by debbugs.gnu.org; 31 Mar 2022 17:31:10 +0000 Received: from localhost ([127.0.0.1]:39677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZydZ-0004Lh-F9 for submit@debbugs.gnu.org; Thu, 31 Mar 2022 13:31:10 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:57689) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZydW-0004L7-L4 for 54564@debbugs.gnu.org; Thu, 31 Mar 2022 13:31:08 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 2B1495C0159; Thu, 31 Mar 2022 13:31:01 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 31 Mar 2022 13:31:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=teloden.nl; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=OkCHF3rdfp/MuCxRyRsaV8/0QoFL02nXxy0TPW SN2XQ=; b=ZSVGXgyznRpCB0A1PD78xrK/kC0bPf+oGZCfBMy0ADgJFh5DAQdKXC F+KDUnivxVCXgg7Ym6L6RXTF96FMxZa+8ibIchbokhOsrt9VDQ9ZoJpVmBRvtszs jeaLWEMggsxP5YM9V7T7TUM8yd4ihPJ992nw7J7IrIXG/0YvlycKc8/uxCZd9h7N I+lY0zQH/3RGhjoWKQWPQd1HQT918pqU/zXj1/WF8+DWffSBkRcQRSPSrKNgQK3y /G28ep3DGxD3QlWXcNQI8b4ylhTwZgXRfGLd8dqMIePqWDbIEpToBe0DOaSpj2C/ KrxdOZTxdCKbn9wjge+IENIIa6cNOXUA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=OkCHF3rdfp/MuCxRy RsaV8/0QoFL02nXxy0TPWSN2XQ=; b=EEQYQtCkn7UfiSWYJbqmO/2Km79D+oxO8 LuuHBCjcWe+fadRlSuySw0SSP7vu//W/Dar20ISSUM8IJc7+RFYuus6Fg4XfMHT8 3/MRnE0erH5qI3drhsGA1qVbFnqMdUvIFLpBQHlchZ72FbDYXVj37yp4kE4q9jkS lWlAvIhTHngkkdyfQmGS9F6a7knD7uQAFidX/wPtFaVTK5yiXD57Yn8cwo+aFB2e KpS95/ivVESgVtp9JiChCF7kGGOidDMmQHWIcxlmG1cKTbFEUSbKtnhTHg6gkTBD 5c6N+MfDmeWAWN51Rs7UgkJ3jLxALqzZ0J7rkfWwi2IavPkTONssg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeigedguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkuffhvfffjghftggfggesmhdtreertderjeenucfhrhhomheprfhivght vghruchvrghnucfrrhhoohhijhgvnhcuoehpihgvthgvrhdrvhgrnhdrphhrohhoihhjvg hnsehtvghlohguvghnrdhnlheqnecuggftrfgrthhtvghrnhepveelvddtgfeluefghfdt jeefudfgtefgieejgfduteevudekieevtdegjeettdefnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepphhivghtvghrrdhvrghnrdhprhhoohhi jhgvnhesthgvlhhouggvnhdrnhhl X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 31 Mar 2022 13:31:00 -0400 (EDT) Message-ID: <211c08916190ef05cc1677956a77fca0c6122eda.camel@teloden.nl> Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds From: Pieter van Prooijen To: Po Lu Date: Thu, 31 Mar 2022 19:30:58 +0200 In-Reply-To: <87bkxnx1co.fsf@yahoo.com> References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> <83czi9b5gh.fsf@gnu.org> <87v8w143h6.fsf@yahoo.com> <87o81s2osr.fsf@yahoo.com> <88d833f72df4f4cbb5769f1a75057d3f957a812c.camel@teloden.nl> <87bkxnx1co.fsf@yahoo.com> Content-Type: multipart/mixed; boundary="=-IVco8ip8y9CGMgQe1UR0" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54564 Cc: Eli Zaretskii , 54564@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-IVco8ip8y9CGMgQe1UR0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Hi All, Thanks for the review, I've updated the commit message and other changes you mentioned in the attached patch (against c5af19cba5924de89a38e7a177c07f42fd3cd543) I've requested the form for the copyright assignment, but have not received it yet, will send it in as soon as it arrives. No progress yet on the problem with subpixel antialiasing, but it doesn't look like a fontconfig issue, as a non-pgtk build from the same source works correctly, will have to dig deeper to find out what is happening. Kind Regards, Pieter On Wed, 2022-03-30 at 16:59 +0800, Po Lu wrote: > Pieter van Prooijen writes: > > > Here's the second version of my patch to use the gsettings for font > > rendering: > > Thanks. > > > When playing around with the font settings, I noticed that > > cairo/pgtk > > doesn't seem to use the subpixel antialias (e.g. cleartype style) > > rendering setting, even though that option is set. I'll investigate > > further, it doesn't look like a regression due to this patch, but > > existing behavior. > > It works here for me, so I don't know why you're seeing that > behavior. > There could be something wrong with fontconfig on your system. > > Some minor comments below: > > > * src/ftcrfont.c (ftcrfont_open): Use the font_options derived from > > gsettings > >   when opening a font. > > * src/ftcrfont.c: (ftcrfont_cached_font_ok): Report a cached font > > as invalid > >   if its font options differ from the current gsettings ones. > > * src/xsettings.c, src/xsettings.h (xsettings_get_font_options): > > Retrieve the > >   current gsettings derived cairo font_options. > > * src/xsettings.c (apply_gsettings_font_hinting): Convert the > > gsettings hint > >   setting to the font_options struct. > > * src/xsettings.c (apply_gsettings_font_antialias): Convert the > > gsettings > >   antialias setting to the font_options struct. > > * src/xsettings.c (apply_gsettings_font_rgba_order): Convert the > > gsettings > >   rgba order setting to the font_options struct. > > * src/xsettings.c (init_gsettings): Invoke the apply functions when > >   initializing from gsettings. > > * src/xsettings.c (something_changed_gsettingsCB): Invoke the apply > > functions > >   if the relevant gsettings changed. > > * src/xsettings.c (store_font_options_changed): Store an event to > > re-render > >   the fonts. > > Please don't indent the first asterisk of the filename inside the > commit > message, or the other lines of the text, and don't repeat the > filename > for each change within the same file.  (You can type C-c C-w inside > the > *vc-log* buffer to generate an appropriate commit message.) > > In many cases there is also no need to repeat the same description of > a change with changes to a single word. > > Here is how I would write the commit message (make sure the entire > message is no wider than 64 characters): > > > * src/ftcrfont.c (ftcrfont_open): Use the font_options derived > from gsettings when opening a font. > (ftcrfont_cached_font_ok): Report a cached font as invalid if > its font options differ from the current options inside > gsettings. > > * src/xsettings.c (apply_gsettings_font_hinting) > (apply_gsettings_font_alias, apply_gsettings_font_rgba_order): > Convert the settings from GSettings to the cairo_font_options_t > object. > (init_gsettings, something_changed_gsettingsCB): Invoke the > apply functions if the relevant settings changed. > (store_font_options_changed): Store an event to re-render the > fonts. > (xsetting_get_font_options) > * src/xsettings.h (xsettings_get_font_options): New function. > > > +/* Determine if the cached font should be re-opened, by comparing > > +   its font_options with the ones derived from gsettings.  */ > > I would say "determine if FONT_OBJECT is a valid cached font for > ENTITY by comparing the options used to open it with the user's > current preferences specified via GSettings". > > > +static void > > +store_font_options_changed (void) > > +{ > > +  if (dpyinfo_valid (first_dpyinfo)) > > +    { > > +      store_config_changed_event (Qfont_render, > > +                                  XCAR (first_dpyinfo- > > >name_list_element)); > > +    } > > +} > > Please remove the extra braces in this if statement. > > > +#ifdef HAVE_PGTK > > +  else if (strcmp (key, GSETTINGS_FONT_ANTIALIASING) == 0) > > +    { > > +      apply_gsettings_font_antialias (settings); > > +      store_font_options_changed (); > > +    } > > +  else if (strcmp (key, GSETTINGS_FONT_HINTING) == 0) > > +    { > > +      apply_gsettings_font_hinting (settings); > > +      store_font_options_changed (); > > +    } > > +  else if (strcmp (key, GSETTINGS_FONT_RGBA_ORDER) == 0) > > +    { > > +      apply_gsettings_font_rgba_order (settings); > > +      store_font_options_changed (); > > +    } > > +#endif /* HAVE_PGTK */ > >  } > > Once again, please reword these tests as !strcmp (key, ... > > > +  /* Only use the gsettings font entries for non-X11 cairo > > backends > > +     (which is the recommended way of running pgtk builds). > > +     For the X11 backend cairo will apply these entries itself, > > +     reading them from xrdb.  */ > > +#ifdef HAVE_PGTK > > +  font_options = cairo_font_options_create (); > > +  apply_gsettings_font_antialias (gsettings_client); > > +  apply_gsettings_font_hinting (gsettings_client); > > +  apply_gsettings_font_rgba_order (gsettings_client); > > +#endif /* HAVE_PGTK */ > > This should say "the Cairo backend running on PGTK". > > > +/* Return the cairo font options, updated from the gsettings font > > +   config entries. The caller should call > > cairo_font_options_destroy > > +   on the result.  */ > > This needs two spaces between "entries." and "The". > > > +#ifdef HAVE_PGTK > > +#include > > Please move this include to the top of the file. > > Otherwise, LGTM.  Thanks for working on Emacs.  Have you completed > the > necessary copyright paperwork? --=-IVco8ip8y9CGMgQe1UR0 Content-Disposition: attachment; filename*0=0001-Use-gsettings-font-rendering-entries-for-pgtk-builds.pat; filename*1=ch Content-Type: text/x-patch; name="0001-Use-gsettings-font-rendering-entries-for-pgtk-builds.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSBiYmY1YWJiNGIyYWVmMzk5ZmUyNDYzZTNhMzk0MzEzMjk2MzMxMGIzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaWV0ZXIgdmFuIFByb29pamVuIDxwaWV0ZXIudmFuLnByb29p amVuQHRlbG9kZW4ubmw+CkRhdGU6IFR1ZSwgMjkgTWFyIDIwMjIgMjE6MjE6NTIgKzAyMDAKU3Vi amVjdDogW1BBVENIXSBVc2UgZ3NldHRpbmdzIGZvbnQgcmVuZGVyaW5nIGVudHJpZXMgZm9yIHBn dGsgYnVpbGRzCgpJZiBwcmVzZW50LCBhcHBseSB0aGUgZ3NldHRpbmdzIGZvbnQgaGludGluZyBh bmQgYW50aWFsaWFzaW5nCmVudHJpZXMgd2hlbiBjcmVhdGluZyBhIGZvbnQgaW4gY2Fpcm8uICBE byB0aGlzIGF0CmluaXRpYWxpemF0aW9uIGFuZCB3aGVuIHRoZSBlbnRyaWVzIGNoYW5nZSwgcmUt cmVuZGVyaW5nIHRoZQpmcmFtZXMuCgoqIHNyYy9mdGNyZm9udC5jIChmdGNyZm9udF9vcGVuKTog VXNlIHRoZSBmb250X29wdGlvbnMgZGVyaXZlZApmcm9tIGdzZXR0aW5ncyB3aGVuIG9wZW5pbmcg YSBmb250LgooZnRjcmZvbnRfY2FjaGVkX2ZvbnRfb2spOiBSZXBvcnQgYSBjYWNoZWQgZm9udCBh cyBpbnZhbGlkIGlmCml0cyBmb250IG9wdGlvbnMgZGlmZmVyIGZyb20gdGhlIGN1cnJlbnQgb3B0 aW9ucyBpbnNpZGUKZ3NldHRpbmdzLgoqIHNyYy94c2V0dGluZ3MuYyAoYXBwbHlfZ3NldHRpbmdz X2ZvbnRfaGludGluZykKKGFwcGx5X2dzZXR0aW5nc19mb250X2FsaWFzLCBhcHBseV9nc2V0dGlu Z3NfZm9udF9yZ2JhX29yZGVyKToKQ29udmVydCB0aGUgc2V0dGluZ3MgZnJvbSBHU2V0dGluZ3Mg dG8gdGhlIGNhaXJvX2ZvbnRfb3B0aW9uc190Cm9iamVjdC4KKGluaXRfZ3NldHRpbmdzLCBzb21l dGhpbmdfY2hhbmdlZF9nc2V0dGluZ3NDQik6IEludm9rZSB0aGUKYXBwbHkgZnVuY3Rpb25zIGlm IHRoZSByZWxldmFudCBzZXR0aW5ncyBjaGFuZ2VkLgooc3RvcmVfZm9udF9vcHRpb25zX2NoYW5n ZWQpOiBTdG9yZSBhbiBldmVudCB0byByZS1yZW5kZXIgdGhlCmZvbnRzLgooeHNldHRpbmdfZ2V0 X2ZvbnRfb3B0aW9ucykKKiBzcmMveHNldHRpbmdzLmggKHhzZXR0aW5nc19nZXRfZm9udF9vcHRp b25zKTogTmV3IGZ1bmN0aW9uLgotLS0KIHNyYy9mdGNyZm9udC5jICB8ICAzMyArKysrKysrKysr Kwogc3JjL3hzZXR0aW5ncy5jIHwgMTQ3ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKwogc3JjL3hzZXR0aW5ncy5oIHwgICA1ICsrCiAzIGZpbGVzIGNoYW5n ZWQsIDE4NSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3JjL2Z0Y3Jmb250LmMgYi9zcmMv ZnRjcmZvbnQuYwppbmRleCA5OGEyOGFmNWYyLi42YmI0MTExMGQ1IDEwMDY0NAotLS0gYS9zcmMv ZnRjcmZvbnQuYworKysgYi9zcmMvZnRjcmZvbnQuYwpAQCAtMzcsNiArMzcsOSBAQAogI2luY2x1 ZGUgImZvbnQuaCIKICNpbmNsdWRlICJmdGZvbnQuaCIKICNpbmNsdWRlICJwZHVtcGVyLmgiCisj aWZkZWYgSEFWRV9QR1RLCisjaW5jbHVkZSAieHNldHRpbmdzLmgiCisjZW5kaWYKIAogI2lmZGVm IFVTRV9CRV9DQUlSTwogI2RlZmluZSBSRURfRlJPTV9VTE9ORyhjb2xvcikJKCgoY29sb3IpID4+ IDE2KSAmIDB4ZmYpCkBAIC0xNjgsNyArMTcxLDEyIEBAIGZ0Y3Jmb250X29wZW4gKHN0cnVjdCBm cmFtZSAqZiwgTGlzcF9PYmplY3QgZW50aXR5LCBpbnQgcGl4ZWxfc2l6ZSkKICAgY2Fpcm9fbWF0 cml4X3QgZm9udF9tYXRyaXgsIGN0bTsKICAgY2Fpcm9fbWF0cml4X2luaXRfc2NhbGUgKCZmb250 X21hdHJpeCwgcGl4ZWxfc2l6ZSwgcGl4ZWxfc2l6ZSk7CiAgIGNhaXJvX21hdHJpeF9pbml0X2lk ZW50aXR5ICgmY3RtKTsKKworI2lmZGVmIEhBVkVfUEdUSworICBjYWlyb19mb250X29wdGlvbnNf dCAqb3B0aW9ucyA9IHhzZXR0aW5nc19nZXRfZm9udF9vcHRpb25zICgpOworI2Vsc2UKICAgY2Fp cm9fZm9udF9vcHRpb25zX3QgKm9wdGlvbnMgPSBjYWlyb19mb250X29wdGlvbnNfY3JlYXRlICgp OworI2VuZGlmCiAjaWZkZWYgVVNFX0JFX0NBSVJPCiAgIGlmIChiZV91c2Vfc3VicGl4ZWxfYW50 aWFsaWFzaW5nICgpKQogICAgIGNhaXJvX2ZvbnRfb3B0aW9uc19zZXRfYW50aWFsaWFzIChvcHRp b25zLCBDQUlST19BTlRJQUxJQVNfU1VCUElYRUwpOwpAQCAtNjI0LDYgKzYzMiwyOCBAQCBmdGNy Zm9udF9kcmF3IChzdHJ1Y3QgZ2x5cGhfc3RyaW5nICpzLAogICByZXR1cm4gbGVuOwogfQogCisj aWZkZWYgSEFWRV9QR1RLCisvKiBEZXRlcm1pbmUgaWYgRk9OVF9PQkpFQ1QgaXMgYSB2YWxpZCBj YWNoZWQgZm9udCBmb3IgRU5USVRZIGJ5CisgICBjb21wYXJpbmcgdGhlIG9wdGlvbnMgdXNlZCB0 byBvcGVuIGl0IHdpdGggdGhlIHVzZXIncyBjdXJyZW50CisgICBwcmVmZXJlbmNlcyBzcGVjaWZp ZWQgdmlhIEdTZXR0aW5ncy4gICovCitzdGF0aWMgYm9vbAorZnRjcmZvbnRfY2FjaGVkX2ZvbnRf b2sgKHN0cnVjdCBmcmFtZSAqZiwgTGlzcF9PYmplY3QgZm9udF9vYmplY3QsCisJCQkgTGlzcF9P YmplY3QgZW50aXR5KQoreworICBzdHJ1Y3QgZm9udF9pbmZvICppbmZvID0gKHN0cnVjdCBmb250 X2luZm8gKikgWEZPTlRfT0JKRUNUIChmb250X29iamVjdCk7CisKKyAgY2Fpcm9fZm9udF9vcHRp b25zX3QgKm9wdGlvbnMgPSBjYWlyb19mb250X29wdGlvbnNfY3JlYXRlICgpOworICBjYWlyb19z Y2FsZWRfZm9udF9nZXRfZm9udF9vcHRpb25zIChpbmZvLT5jcl9zY2FsZWRfZm9udCwgb3B0aW9u cyk7CisgIGNhaXJvX2ZvbnRfb3B0aW9uc190ICpnc2V0dGluZ3Nfb3B0aW9ucyA9IHhzZXR0aW5n c19nZXRfZm9udF9vcHRpb25zICgpOworCisgIGJvb2wgZXF1YWwgPSBjYWlyb19mb250X29wdGlv bnNfZXF1YWwgKG9wdGlvbnMsIGdzZXR0aW5nc19vcHRpb25zKTsKKyAgY2Fpcm9fZm9udF9vcHRp b25zX2Rlc3Ryb3kgKG9wdGlvbnMpOworICBjYWlyb19mb250X29wdGlvbnNfZGVzdHJveSAoZ3Nl dHRpbmdzX29wdGlvbnMpOworCisgIHJldHVybiBlcXVhbDsKK30KKyNlbmRpZgorCiAjaWZkZWYg SEFWRV9IQVJGQlVaWgogCiBzdGF0aWMgTGlzcF9PYmplY3QKQEAgLTY5NCw2ICs3MjQsOSBAQCBm dGNyaGJmb250X2VuZF9oYl9mb250IChzdHJ1Y3QgZm9udCAqZm9udCwgaGJfZm9udF90ICpoYl9m b250KQogI2VuZGlmCiAgIC5maWx0ZXJfcHJvcGVydGllcyA9IGZ0Zm9udF9maWx0ZXJfcHJvcGVy dGllcywKICAgLmNvbWJpbmluZ19jYXBhYmlsaXR5ID0gZnRmb250X2NvbWJpbmluZ19jYXBhYmls aXR5LAorI2lmZGVmIEhBVkVfUEdUSworICAuY2FjaGVkX2ZvbnRfb2sgPSBmdGNyZm9udF9jYWNo ZWRfZm9udF9vaworI2VuZGlmCiAgIH07CiAjaWZkZWYgSEFWRV9IQVJGQlVaWgogc3RydWN0IGZv bnRfZHJpdmVyIGZ0Y3JoYmZvbnRfZHJpdmVyOwpkaWZmIC0tZ2l0IGEvc3JjL3hzZXR0aW5ncy5j IGIvc3JjL3hzZXR0aW5ncy5jCmluZGV4IDcxZDAyZTYxNTIuLjc0NjllYjVlNDAgMTAwNjQ0Ci0t LSBhL3NyYy94c2V0dGluZ3MuYworKysgYi9zcmMveHNldHRpbmdzLmMKQEAgLTIxNSwxMSArMjE1 LDExNiBAQCAjZGVmaW5lIEdTRVRUSU5HU19NT05PX0ZPTlQgICJtb25vc3BhY2UtZm9udC1uYW1l IgogI2RlZmluZSBHU0VUVElOR1NfRk9OVF9OQU1FICAiZm9udC1uYW1lIgogI2VuZGlmCiAKKyNp ZmRlZiBIQVZFX1BHVEsKKyNkZWZpbmUgR1NFVFRJTkdTX0ZPTlRfQU5USUFMSUFTSU5HICAiZm9u dC1hbnRpYWxpYXNpbmciCisjZGVmaW5lIEdTRVRUSU5HU19GT05UX1JHQkFfT1JERVIgICAgImZv bnQtcmdiYS1vcmRlciIKKyNkZWZpbmUgR1NFVFRJTkdTX0ZPTlRfSElOVElORyAgICAgICAiZm9u dC1oaW50aW5nIgorI2VuZGlmCiAKIC8qIFRoZSBzaW5nbGUgR1NldHRpbmdzIGluc3RhbmNlLCBv ciBOVUxMIGlmIG5vdCBjb25uZWN0ZWQgdG8gR1NldHRpbmdzLiAgKi8KIAogc3RhdGljIEdTZXR0 aW5ncyAqZ3NldHRpbmdzX2NsaWVudDsKIAorI2lmZGVmIEhBVkVfUEdUSworCisvKiBUaGUgY2Fp cm8gZm9udF9vcHRpb25zIGFzIG9idGFpbmVkIHVzaW5nIGdzZXR0aW5ncy4gICovCitzdGF0aWMg Y2Fpcm9fZm9udF9vcHRpb25zX3QgKmZvbnRfb3B0aW9uczsKKworLyogU3RvcmUgYW4gZXZlbnQg Zm9yIHJlLXJlbmRlcmluZyBvZiB0aGUgZm9udHMuICAqLworc3RhdGljIHZvaWQKK3N0b3JlX2Zv bnRfb3B0aW9uc19jaGFuZ2VkICh2b2lkKQoreworICBpZiAoZHB5aW5mb192YWxpZCAoZmlyc3Rf ZHB5aW5mbykpCisgICAgICBzdG9yZV9jb25maWdfY2hhbmdlZF9ldmVudCAoUWZvbnRfcmVuZGVy LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFhDQVIgKGZpcnN0X2RweWluZm8t Pm5hbWVfbGlzdF9lbGVtZW50KSk7Cit9CisKKy8qIEFwcGx5IGNoYW5nZXMgaW4gdGhlIGhpbnRp bmcgc3lzdGVtIHNldHRpbmcuICAqLworc3RhdGljIHZvaWQKK2FwcGx5X2dzZXR0aW5nc19mb250 X2hpbnRpbmcgKEdTZXR0aW5ncyAqc2V0dGluZ3MpCit7CisgIEdWYXJpYW50ICp2YWwgPSBnX3Nl dHRpbmdzX2dldF92YWx1ZSAoc2V0dGluZ3MsIEdTRVRUSU5HU19GT05UX0hJTlRJTkcpOworICBp ZiAodmFsKQorICAgIHsKKyAgICAgIGdfdmFyaWFudF9yZWZfc2luayAodmFsKTsKKyAgICAgIGlm IChnX3ZhcmlhbnRfaXNfb2ZfdHlwZSAodmFsLCBHX1ZBUklBTlRfVFlQRV9TVFJJTkcpKQorCXsK KwkgIGNvbnN0IGNoYXIgKmhpbnRpbmcgPSBnX3ZhcmlhbnRfZ2V0X3N0cmluZyAodmFsLCBOVUxM KTsKKworCSAgaWYgKCFzdHJjbXAgKGhpbnRpbmcsICJmdWxsIikpCisJICAgIGNhaXJvX2ZvbnRf b3B0aW9uc19zZXRfaGludF9zdHlsZSAoZm9udF9vcHRpb25zLAorCQkJCQkgICAgICAgQ0FJUk9f SElOVF9TVFlMRV9GVUxMKTsKKwkgIGVsc2UgaWYgKCFzdHJjbXAgKGhpbnRpbmcsICJtZWRpdW0i KSkKKwkgICAgY2Fpcm9fZm9udF9vcHRpb25zX3NldF9oaW50X3N0eWxlIChmb250X29wdGlvbnMs CisJCQkJCSAgICAgICBDQUlST19ISU5UX1NUWUxFX01FRElVTSk7CisJICBlbHNlIGlmICghc3Ry Y21wIChoaW50aW5nLCAic2xpZ2h0IikpCisJICAgIGNhaXJvX2ZvbnRfb3B0aW9uc19zZXRfaGlu dF9zdHlsZSAoZm9udF9vcHRpb25zLAorCQkJCQkgICAgICAgQ0FJUk9fSElOVF9TVFlMRV9TTElH SFQpOworCSAgZWxzZSBpZiAoIXN0cmNtcCAoaGludGluZywgIm5vbmUiKSkKKwkgICAgY2Fpcm9f Zm9udF9vcHRpb25zX3NldF9oaW50X3N0eWxlIChmb250X29wdGlvbnMsCisJCQkJCSAgICAgICBD QUlST19ISU5UX1NUWUxFX05PTkUpOworCX0KKyAgICAgIGdfdmFyaWFudF91bnJlZiAodmFsKTsK KyAgICB9Cit9CisKKy8qIEFwcGx5IGNoYW5nZXMgaW4gdGhlIGFudGlhbGlhc2luZyBzeXN0ZW0g c2V0dGluZy4gICovCitzdGF0aWMgdm9pZAorYXBwbHlfZ3NldHRpbmdzX2ZvbnRfYW50aWFsaWFz IChHU2V0dGluZ3MgKnNldHRpbmdzKQoreworICBHVmFyaWFudCAqdmFsID0gZ19zZXR0aW5nc19n ZXRfdmFsdWUgKHNldHRpbmdzLCBHU0VUVElOR1NfRk9OVF9BTlRJQUxJQVNJTkcpOworICBpZiAo dmFsKQorICAgIHsKKyAgICAgIGdfdmFyaWFudF9yZWZfc2luayAodmFsKTsKKyAgICAgIGlmIChn X3ZhcmlhbnRfaXNfb2ZfdHlwZSAodmFsLCBHX1ZBUklBTlRfVFlQRV9TVFJJTkcpKQorCXsKKwkg IGNvbnN0IGNoYXIgKmFudGlhbGlhcyA9IGdfdmFyaWFudF9nZXRfc3RyaW5nICh2YWwsIE5VTEwp OworCisJICBpZiAoIXN0cmNtcCAoYW50aWFsaWFzLCAibm9uZSIpKQorCSAgICBjYWlyb19mb250 X29wdGlvbnNfc2V0X2FudGlhbGlhcyAoZm9udF9vcHRpb25zLAorCQkJCQkgICAgICBDQUlST19B TlRJQUxJQVNfTk9ORSk7CisJICBlbHNlIGlmICghc3RyY21wIChhbnRpYWxpYXMsICJncmF5c2Nh bGUiKSkKKwkgICAgY2Fpcm9fZm9udF9vcHRpb25zX3NldF9hbnRpYWxpYXMgKGZvbnRfb3B0aW9u cywKKwkJCQkJICAgICAgQ0FJUk9fQU5USUFMSUFTX0dSQVkpOworCSAgZWxzZSBpZiAoIXN0cmNt cCAoYW50aWFsaWFzLCAicmdiYSIpKQorCSAgICBjYWlyb19mb250X29wdGlvbnNfc2V0X2FudGlh bGlhcyAoZm9udF9vcHRpb25zLAorCQkJCQkgICAgICBDQUlST19BTlRJQUxJQVNfU1VCUElYRUwp OworCX0KKyAgICAgIGdfdmFyaWFudF91bnJlZiAodmFsKTsKKyAgICB9Cit9CisKKy8qIEFwcGx5 IHRoZSBzZXR0aW5ncyBmb3IgdGhlIHJnYiBlbGVtZW50IG9yZGVyaW5nLiAgKi8KK3N0YXRpYyB2 b2lkCithcHBseV9nc2V0dGluZ3NfZm9udF9yZ2JhX29yZGVyIChHU2V0dGluZ3MgKnNldHRpbmdz KQoreworICBHVmFyaWFudCAqdmFsID0gZ19zZXR0aW5nc19nZXRfdmFsdWUgKHNldHRpbmdzLAor CQkJCQlHU0VUVElOR1NfRk9OVF9SR0JBX09SREVSKTsKKyAgaWYgKHZhbCkKKyAgICB7CisgICAg ICBnX3ZhcmlhbnRfcmVmX3NpbmsgKHZhbCk7CisgICAgICBpZiAoZ192YXJpYW50X2lzX29mX3R5 cGUgKHZhbCwgR19WQVJJQU5UX1RZUEVfU1RSSU5HKSkKKwl7CisJICBjb25zdCBjaGFyICpyZ2Jh X29yZGVyID0gZ192YXJpYW50X2dldF9zdHJpbmcgKHZhbCwgTlVMTCk7CisKKwkgIGlmICghc3Ry Y21wIChyZ2JhX29yZGVyLCAicmdiIikpCisJICAgIGNhaXJvX2ZvbnRfb3B0aW9uc19zZXRfc3Vi cGl4ZWxfb3JkZXIgKGZvbnRfb3B0aW9ucywKKwkJCQkJCSAgIENBSVJPX1NVQlBJWEVMX09SREVS X1JHQik7CisJICBlbHNlIGlmICghc3RyY21wIChyZ2JhX29yZGVyLCAiYmdyIikpCisJICAgIGNh aXJvX2ZvbnRfb3B0aW9uc19zZXRfc3VicGl4ZWxfb3JkZXIgKGZvbnRfb3B0aW9ucywKKwkJCQkJ CSAgIENBSVJPX1NVQlBJWEVMX09SREVSX0JHUik7CisJICBlbHNlIGlmICghc3RyY21wIChyZ2Jh X29yZGVyLCAidnJnYiIpKQorCSAgICBjYWlyb19mb250X29wdGlvbnNfc2V0X3N1YnBpeGVsX29y ZGVyIChmb250X29wdGlvbnMsCisJCQkJCQkgICBDQUlST19TVUJQSVhFTF9PUkRFUl9WUkdCKTsK KwkgIGVsc2UgaWYgKCFzdHJjbXAgKHJnYmFfb3JkZXIsICJ2YmdyIikpCisJICAgIGNhaXJvX2Zv bnRfb3B0aW9uc19zZXRfc3VicGl4ZWxfb3JkZXIgKGZvbnRfb3B0aW9ucywKKwkJCQkJCSAgIENB SVJPX1NVQlBJWEVMX09SREVSX1ZCR1IpOworCX0KKyAgICAgIGdfdmFyaWFudF91bnJlZiAodmFs KTsKKyAgICB9Cit9CisjZW5kaWYgLyogSEFWRV9QR1RLICovCisKIC8qIENhbGxiYWNrIGNhbGxl ZCB3aGVuIHNvbWV0aGluZyBjaGFuZ2VkIGluIEdTZXR0aW5ncy4gICovCiAKIHN0YXRpYyB2b2lk CkBAIC0yNzMsNiArMzc4LDIzIEBAIHNvbWV0aGluZ19jaGFuZ2VkX2dzZXR0aW5nc0NCIChHU2V0 dGluZ3MgKnNldHRpbmdzLAogICAgICAgICB9CiAgICAgfQogI2VuZGlmIC8qIFVTRV9DQUlSTyB8 fCBIQVZFX1hGVCAqLworI2lmZGVmIEhBVkVfUEdUSworICBlbHNlIGlmICghc3RyY21wIChrZXks IEdTRVRUSU5HU19GT05UX0FOVElBTElBU0lORykpCisgICAgeworICAgICAgYXBwbHlfZ3NldHRp bmdzX2ZvbnRfYW50aWFsaWFzIChzZXR0aW5ncyk7CisgICAgICBzdG9yZV9mb250X29wdGlvbnNf Y2hhbmdlZCAoKTsKKyAgICB9CisgIGVsc2UgaWYgKCFzdHJjbXAgKGtleSwgR1NFVFRJTkdTX0ZP TlRfSElOVElORykpCisgICAgeworICAgICAgYXBwbHlfZ3NldHRpbmdzX2ZvbnRfaGludGluZyAo c2V0dGluZ3MpOworICAgICAgc3RvcmVfZm9udF9vcHRpb25zX2NoYW5nZWQgKCk7CisgICAgfQor ICBlbHNlIGlmICghc3RyY21wIChrZXksIEdTRVRUSU5HU19GT05UX1JHQkFfT1JERVIpKQorICAg IHsKKyAgICAgIGFwcGx5X2dzZXR0aW5nc19mb250X3JnYmFfb3JkZXIgKHNldHRpbmdzKTsKKyAg ICAgIHN0b3JlX2ZvbnRfb3B0aW9uc19jaGFuZ2VkICgpOworICAgIH0KKyNlbmRpZiAvKiBIQVZF X1BHVEsgKi8KIH0KIAogI2VuZGlmIC8qIEhBVkVfR1NFVFRJTkdTICovCkBAIC05MDAsNiArMTAy MiwxNiBAQCBpbml0X2dzZXR0aW5ncyAodm9pZCkKICAgICAgICAgZHVwc3RyaW5nICgmY3VycmVu dF9mb250LCBnX3ZhcmlhbnRfZ2V0X3N0cmluZyAodmFsLCBOVUxMKSk7CiAgICAgICBnX3Zhcmlh bnRfdW5yZWYgKHZhbCk7CiAgICAgfQorCisgIC8qIE9ubHkgdXNlIHRoZSBnc2V0dGluZ3MgZm9u dCBlbnRyaWVzIGZvciB0aGUgQ2Fpcm8gYmFja2VuZAorICAgICBydW5uaW5nIG9uIFBHVEsuICAq LworI2lmZGVmIEhBVkVfUEdUSworICBmb250X29wdGlvbnMgPSBjYWlyb19mb250X29wdGlvbnNf Y3JlYXRlICgpOworICBhcHBseV9nc2V0dGluZ3NfZm9udF9hbnRpYWxpYXMgKGdzZXR0aW5nc19j bGllbnQpOworICBhcHBseV9nc2V0dGluZ3NfZm9udF9oaW50aW5nIChnc2V0dGluZ3NfY2xpZW50 KTsKKyAgYXBwbHlfZ3NldHRpbmdzX2ZvbnRfcmdiYV9vcmRlciAoZ3NldHRpbmdzX2NsaWVudCk7 CisjZW5kaWYgLyogSEFWRV9QR1RLICovCisKICNlbmRpZiAvKiBVU0VfQ0FJUk8gfHwgSEFWRV9Y RlQgKi8KIAogI2VuZGlmIC8qIEhBVkVfR1NFVFRJTkdTICovCkBAIC0xMDIxLDYgKzExNTMsMTcg QEAgeHNldHRpbmdzX2dldF9zeXN0ZW1fbm9ybWFsX2ZvbnQgKHZvaWQpCiB9CiAjZW5kaWYKIAor I2lmZGVmIEhBVkVfUEdUSworLyogUmV0dXJuIHRoZSBjYWlybyBmb250IG9wdGlvbnMsIHVwZGF0 ZWQgZnJvbSB0aGUgZ3NldHRpbmdzIGZvbnQKKyAgIGNvbmZpZyBlbnRyaWVzLiAgVGhlIGNhbGxl ciBzaG91bGQgY2FsbCBjYWlyb19mb250X29wdGlvbnNfZGVzdHJveQorICAgb24gdGhlIHJlc3Vs dC4gICovCitjYWlyb19mb250X29wdGlvbnNfdCAqCit4c2V0dGluZ3NfZ2V0X2ZvbnRfb3B0aW9u cyAodm9pZCkKK3sKKyAgcmV0dXJuIGNhaXJvX2ZvbnRfb3B0aW9uc19jb3B5IChmb250X29wdGlv bnMpOworfQorI2VuZGlmCisKIERFRlVOICgiZm9udC1nZXQtc3lzdGVtLW5vcm1hbC1mb250Iiwg RmZvbnRfZ2V0X3N5c3RlbV9ub3JtYWxfZm9udCwKICAgICAgICBTZm9udF9nZXRfc3lzdGVtX25v cm1hbF9mb250LAogICAgICAgIDAsIDAsIDAsCkBAIC0xMDczLDYgKzEyMTYsMTAgQEAgc3ltc19v Zl94c2V0dGluZ3MgKHZvaWQpCiAgIGdjb25mX2NsaWVudCA9IE5VTEw7CiAgIFBEVU1QRVJfSUdO T1JFIChnY29uZl9jbGllbnQpOwogI2VuZGlmCisjaWZkZWYgSEFWRV9QR1RLCisgIGZvbnRfb3B0 aW9ucyA9IE5VTEw7CisgIFBEVU1QRVJfSUdOT1JFIChmb250X29wdGlvbnMpOworI2VuZGlmCiAK ICAgREVGU1lNIChRbW9ub3NwYWNlX2ZvbnRfbmFtZSwgIm1vbm9zcGFjZS1mb250LW5hbWUiKTsK ICAgREVGU1lNIChRZm9udF9uYW1lLCAiZm9udC1uYW1lIik7CmRpZmYgLS1naXQgYS9zcmMveHNl dHRpbmdzLmggYi9zcmMveHNldHRpbmdzLmgKaW5kZXggY2NhYTM2NDg5ZC4uNWU1ZGYzNzA2MiAx MDA2NDQKLS0tIGEvc3JjL3hzZXR0aW5ncy5oCisrKyBiL3NyYy94c2V0dGluZ3MuaApAQCAtMjMs NiArMjMsOCBAQCAjZGVmaW5lIFhTRVRUSU5HU19ICiAjaWZuZGVmIEhBVkVfUEdUSwogI2luY2x1 ZGUgImRpc3BleHRlcm4uaCIKICNpbmNsdWRlIDxYMTEvWGxpYi5oPgorI2Vsc2UKKyNpbmNsdWRl IDxjYWlyby5oPgogI2VuZGlmCiAKIHN0cnVjdCB4X2Rpc3BsYXlfaW5mbzsKQEAgLTQxLDUgKzQz LDggQEAgI2RlZmluZSBYU0VUVElOR1NfSAogZXh0ZXJuIGNvbnN0IGNoYXIgKnhzZXR0aW5nc19n ZXRfc3lzdGVtX25vcm1hbF9mb250ICh2b2lkKTsKICNlbmRpZgogCisjaWZkZWYgSEFWRV9QR1RL CitleHRlcm4gY2Fpcm9fZm9udF9vcHRpb25zX3QgKnhzZXR0aW5nc19nZXRfZm9udF9vcHRpb25z ICh2b2lkKTsKKyNlbmRpZgogCiAjZW5kaWYgLyogWFNFVFRJTkdTX0ggKi8KLS0gCjIuMzIuMAoK --=-IVco8ip8y9CGMgQe1UR0-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 31 22:00:28 2022 Received: (at 54564) by debbugs.gnu.org; 1 Apr 2022 02:00:28 +0000 Received: from localhost ([127.0.0.1]:40408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1na6aS-0005MZ-E6 for submit@debbugs.gnu.org; Thu, 31 Mar 2022 22:00:28 -0400 Received: from sonic302-20.consmr.mail.ne1.yahoo.com ([66.163.186.146]:40366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1na6aR-0005MK-OC for 54564@debbugs.gnu.org; Thu, 31 Mar 2022 22:00:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648778421; bh=QJIKymCWedLL5diUU0QuAP/Lje/UICltqUdNvFwN+X0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=QxCx7peyPPBV++2OUfdg/ScGesVKWnuQP3fS4EoYrJ5TMinN2kWB3KSiAE/CE2+RoOyDFBoMaEgioaeS51fr+ACn37CJeskInMFp55odRMvCmqGipq/ALwnq5iV/eI47f7yISviVNQCEJtN0Bt+vKJjRGXOb8rio08h9UdtXBLWF606C6xXoL25G2y4W8Fn0iknedWimQMVqKLppwE6j5uqBbNhneevHqkxHkYsW1KdXNmccgupOXZRUSfk1L7rAPnCYLnl0nRxaC3cPFksOx8Bxsgil9BOov75xgmW8Lq4yLpCvgXDGOd8eYShRrVMksV2d3iwrhcvxKSwEJpKMFw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648778421; bh=mQBMObSk6k5xkv41SK5KkMFjPe6+SfYX+TOScJjFdlu=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=ELEW+bFw0LI3OE5fxUDgyrllvmXRW2WseF33sb7Z1cfU2SgI6nJOOahdaouZam8jo0K7b5Dh6Thc4n9C+5kGppP8+a/JlaAAI/DzZOvWcnaVy+f/XML0s6NPzqqjjaj0ocbhagxp8qFEf1k4u3HR6cFJ8GU++TgbTX3WMERv+vrBkUhKmivYfrHeDRnEDdLKpWyOEnHjjzO69k4XiPrT9HX8ufq+8AYgEbpKVBPBEf+lsHzAxDD6zdU5ZY1IZGl8BBnfWW7s9Es8TUEGgio2zVzUSsNlHmrjxSLmWiqELHxRVx1R5JRkEa+Zy5QpW2ol2JWSdiO/Q71jWfBXFkt4uA== X-YMail-OSG: 2nV6qHkVM1kXjfTIh8unxYUzUJiSoK5TnLNFHtQFswr67vm27IjjFi3tc3b8AMn vG3TGvDLfIVQ_C.vSrNbYsh90Q9lp.zZ0TY3KKHBSYp4f28oLSnM7vF10cJ40qGa8Gyw7tw6.D2F g2zov2Ty_TXRD.X6XXFY.JSQTUQxr88Ex43hxDtv3JOCd2R84pq5Ap7QgIkizAqzC8QA.7jHvBsx fKqkScC6ZhEWtSGffLKwGn4E4lrcdazJWlMrnB0Nf_Y_QMlXGm95STI5bPZaxjxeYnq7eUvakkxP QBDwy8VvGB118P.2mFunPGboUR8Q2elmRmekr3RVSBzWB47.g8NEEThUrc39c7stKmjDqAN38GqA 0LFxLr_BNpUN6E9MrW0sbgT7hRGUFiV458bOkZblb29NPs9wlKR9GItmcX4fFCsu8cUlPM2ToXCb QMVwuulAAtOAm3TEtYFHINwqLtSMgDNmbxroRtKD0ysKJ9SfHuQqMf4EMmR0QjNRS_NsOgfmbE7P z7Vm0RdL6Y8Er9zYlxcyyAJXNOSYkps8fJOX7LdqsH2zsHbXp8zglNmNOOioicTIU6Mo.PpcL4kD 3qu9DKK25czK88tDkTqmAEZeefUJOvXNLXfd5JxHmwzgwSIwaTAPOS7kbWCL_zW7gGBUWQfPaNHh CmQ9Dp19c1m7mVzFNuS1Bxr0MtMoEDcTTHNjRE_9z7L_7aZ1lU7PVHkQYggCbnUhb56DVftfbr86 wU8mydyurJJvlxwWhXaSHjIcDdJDIk4Jdr8FjNZiUkyAgV5ydrpabc9kbhDsVvu1JE5oTTvpwFdy 6HIgM1KljU6PsDUrUR7VtQfGRWh1lv7w8o0XAphx5.HDkAemIvJkI0N_oZop0zPGTjNEbdlq2o15 VROPvBE.IoyZdgWM8MWWrJWhgsVHQWDO_qilvE.YTvgwflr6LGV7fpUvbbJCJ1JQim6B8x89vC2y PZlAnxZXD7Zh1AfuRh9h69yHf717.6NenOkD46Eh3qqmU6cnBqNZEfay0DoG1yQWSlAFvDpy67g1 9k92puHk.TQahnpqD6W4bLweClVMt4tZ4lMX5xvvHXNY6s0h10CHCL6RlWqlvglrt6Hl29ma.jy6 YdQWKCLqTzXwNzlNxpXS17UpiHLdbd8nUjZc4nd9iZShazIWm31GZeIMg916PoTK30kaxM7PTGFb cQNthU8kpIwiynIHSt2MNffMB2VJM3QTQHelYzopWljGNRfz93lQ1BnxEDE2mNO4Uj9LPfo2a1q2 LI_DkMH7Vv8ycuErt_kcYRjUYI_KDvBH695UDO4gOrrmaP2Mg6ZFQp5_ukHCwwFpOCqiTkl6BUB7 lIqQXXm3O9aJTeAA0HRkJLbVOsgFVFWPTZHbXUDTL6ckaKYDYH9DcxwjeWbA_.bjAZbipVATjAIK bgv_WAy9qKuwawltqapQFuJqKTItJpOndmCbGWWOlYvAl1xrgUfaI_BFZkMKNzRlUPDIRQL7Zv1k 4ulPYXtUlkpxG3Xbr9fpGMV8O0waUqMvODutBKg8WNqvL3xRny904IrkgGONIf2kj6d1tIcSMAi4 g4ggX.5ngP7PZ_hvWTcdx43kQxUql6KQpOAYbirC4Qi5J57mSKY8OR8_b6TQ2Dt8uuoEEPUe4n.b NzjCgzz.1yUmg9e6waZVTWJPaO3nci24Xd6fXmVXNGK_qWBP7G1mKwhonnQbxZw7yxKcYMbkqnKI hzhlGBcFS6MeTDXPqT2BCcQTHcr6dgby8NAnvXEBfRbjyHuR3DkqNJempzDuXmbgKutefj40zYyn L_D9wcvY5YYTn9GWbL7fUAaDJHa6SxXoO5dWyT0eVp7MXKIgKSXxioX3Ckq32Jx2cTmGJ3VayiL. PYp7TtJbE7p9LlxgxelYfGXOlTyn0OiwUlTH7.e1.8oaVVuJaKO7s3HUdAu2TIImNFIHcVwaRiQL wyAiPOajP67kbi19InkdJG3pGg4hft33zlMGo8to7zXLry8TOjlobXia9L1BF1yH_QDxpsyiZ0kG CQLMTA4bfKiTrIOuw6b9BpFcOzUwEVu.xSE5dMsHVlIv5eoF60fEpLScR6pDG25_gFP4k9QeO3EQ VAjYklWwsKiJ0AC7lcXB0WklVefBdggF147ux1.qntx.I9qPj5SnJiweBJGHjf3.I6TY9WrNBlLk fIvltmOeCOaYiMiqu.D3e65OhqLA4zyuWTnr5pmrlUx_BqCa0uKIPjqYz1eKYg44jXxk01l32h.Q IlK0QaBm_wYdCcXj4LauehKYcSgQPWI8DKwcLb928JXmqwDU6XZjPnpISOevsh9x97xthZEs- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ne1.yahoo.com with HTTP; Fri, 1 Apr 2022 02:00:21 +0000 Received: by hermes--canary-production-sg3-65d7bd97b5-nlj7h (VZM Hermes SMTP Server) with ESMTPA ID 8f4b154e6d772bbebec20f76c33358b2; Fri, 01 Apr 2022 02:00:14 +0000 (UTC) From: Po Lu To: Pieter van Prooijen Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> <83czi9b5gh.fsf@gnu.org> <87v8w143h6.fsf@yahoo.com> <87o81s2osr.fsf@yahoo.com> <88d833f72df4f4cbb5769f1a75057d3f957a812c.camel@teloden.nl> <87bkxnx1co.fsf@yahoo.com> <211c08916190ef05cc1677956a77fca0c6122eda.camel@teloden.nl> Date: Fri, 01 Apr 2022 10:00:10 +0800 In-Reply-To: <211c08916190ef05cc1677956a77fca0c6122eda.camel@teloden.nl> (Pieter van Prooijen's message of "Thu, 31 Mar 2022 19:30:58 +0200") Message-ID: <87k0c9imvp.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.20001 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1127 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54564 Cc: Eli Zaretskii , 54564@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pieter van Prooijen writes: > Hi All, > > Thanks for the review, I've updated the commit message and other > changes you mentioned in the attached=C2=A0patch (against > c5af19cba5924de89a38e7a177c07f42fd3cd543) > > I've requested the form for the copyright assignment, but have not > received it yet, will send it in as soon as it arrives. > > No progress yet on the problem with subpixel antialiasing, but it > doesn't look like a fontconfig issue, as a non-pgtk build from the same > source works correctly, will have to dig deeper to find out what is > happening.=20 Thanks. >> > +=C2=A0=C2=A0 on the result.=C2=A0 */ Hmm... Is there an actual non-breaking space character here, or is your MUA munging the messages? > + if (dpyinfo_valid (first_dpyinfo)) > + store_config_changed_event (Qfont_render, > + XCAR (first_dpyinfo->name_list_element= )); You got the indentation wrong here. The "s" in "store_config_changed_event" should be two spaces behind where it is now. Otherwise, LGTM. Hopefully the copyright paperwork can be finished soon. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 07 15:24:40 2022 Received: (at 54564) by debbugs.gnu.org; 7 Apr 2022 19:24:41 +0000 Received: from localhost ([127.0.0.1]:33404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ncXkG-00039C-6s for submit@debbugs.gnu.org; Thu, 07 Apr 2022 15:24:40 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:46805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ncXkE-00038v-BX for 54564@debbugs.gnu.org; Thu, 07 Apr 2022 15:24:39 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 3959C5C023F; Thu, 7 Apr 2022 15:24:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 07 Apr 2022 15:24:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=teloden.nl; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=yGgyWb/jpkqX0zKnzoAqOlrJOW0ta8qaWp0T8g PWnS8=; b=fZ59lkl7nWGx3GsOIKHqGsnEnyRTj4HaWr3PHLltlB6gu3MpL9c10b PtOk3A/Mqh9uCYtf9QcIHn6JIVLCJAWI2A7cZwwrvjUNkKtP7smOD988rPSqOOHI esHICuZxe6tnGPw2yxpUCIXKiAeoNqPB3MRN4tpdx8egMXzw4Y1lVIkBf8ebLYEE zsFSK+MPJxMhaBO4qeb6CiUaqp1qAdITtbckPbw8H6gyJye6Hyiwlz+fb3TZ21p2 Uza9DoPwiyCeXzsV0+vhehZm4Lov2Tun3GW/QVw6roLgQ3vYY1NoVfXNEWBfq6JG XLfTPVRtzvVLIV5FGluDCfp+E/qkb3BQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=yGgyWb/jpkqX0zKnz oAqOlrJOW0ta8qaWp0T8gPWnS8=; b=WjZihsDmc3BPu/iWtddhKKY8OuppmV32D tFZUmbNhCL0uIjtMZvHcdfgv/C5eQR7aZ6pakOAGeqrCOZ/QnS/vie1TJGYe8eJf BWXn9hw497oeog4Bf+Sd0fMbx/OhMYSSq3R16IyekJzscIhKAC0CTNgOim39751Y NTgPInpWdv7mV/XMqMaIfP486Mbcns7Mle2MUghQOphxEIOg79mnmPwiKCoCj6fo jq2StdqTpv02RytqdngbGmW/xVmdmQGailsOt7I0iIT0hqds7qURarshqon70uw6 GCgqFJSnkkQZmMjYvmDnMTm7831HbTwfWI+t47gQn2j2y7q/g20aA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudejkedgudegtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkuffhvfffjghftggfggesmhdtreertderjeenucfhrhhomheprfhivght vghruchvrghnucfrrhhoohhijhgvnhcuoehpihgvthgvrhdrvhgrnhdrphhrohhoihhjvg hnsehtvghlohguvghnrdhnlheqnecuggftrfgrthhtvghrnheptdfghefgtefhueejhfef gfdvffefgfetkeetffevveefkeejudduleelfeejleegnecuffhomhgrihhnpehgnhhurd horhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep phhivghtvghrrdhvrghnrdhprhhoohhijhgvnhesthgvlhhouggvnhdrnhhl X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Apr 2022 15:24:30 -0400 (EDT) Message-ID: <66a9a7d83ca545dd23c890d4aa97717f1796579f.camel@teloden.nl> Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds From: Pieter van Prooijen To: Po Lu Date: Thu, 07 Apr 2022 21:24:28 +0200 In-Reply-To: <87k0c9imvp.fsf@yahoo.com> References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> <83czi9b5gh.fsf@gnu.org> <87v8w143h6.fsf@yahoo.com> <87o81s2osr.fsf@yahoo.com> <88d833f72df4f4cbb5769f1a75057d3f957a812c.camel@teloden.nl> <87bkxnx1co.fsf@yahoo.com> <211c08916190ef05cc1677956a77fca0c6122eda.camel@teloden.nl> <87k0c9imvp.fsf@yahoo.com> Content-Type: multipart/mixed; boundary="=-mmTeLzNAJeAK4lRU/qTZ" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54564 Cc: Eli Zaretskii , 54564@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-mmTeLzNAJeAK4lRU/qTZ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Hi All,  It took a fair bit of digging, but sub-pixel anti-aliasing on pgtk now seems to work correctly. The problem lies with the "source" operator set by pgtk when drawing a font, this will take a particular execution path in the cairo glyph compositor (using a mask image) which converts the colors created by freetype for the sub pixel effect to greys-cale. Using the default "over" operator takes a different path which preserves the colors. Note that on small screens the difference between sub-pixel and grey-scale rendering is hard to see, it's more pronounced on larger displays) I've amended my gsettings patch with this change, only replacing the operator for anti-aliased fonts in ftcrfont_draw, because I'm not sure about its impact for non-anti-aliased fonts.    I've also fixed the indent error, but couldn't find the non-breaking space in the patch, it's perhaps caused by the mail program. Regarding the copyright assignment, I've had no response after sending in the questionnaire at https://git.savannah.gnu.org/cgit/gnulib.git/plain/doc/Copyright/request-assign.future to assign@gnu.org Do you get sent a paper form of some kind which has to be filled in? (I'm not at my home address atm so I will have missed that) Kind Regards, Pieter On Fri, 2022-04-01 at 10:00 +0800, Po Lu wrote: > Pieter van Prooijen writes: > > > Hi All, > > > > Thanks for the review, I've updated the commit message and other > > changes you mentioned in the attached patch (against > > c5af19cba5924de89a38e7a177c07f42fd3cd543) > > > > I've requested the form for the copyright assignment, but have not > > received it yet, will send it in as soon as it arrives. > > > > No progress yet on the problem with subpixel antialiasing, but it > > doesn't look like a fontconfig issue, as a non-pgtk build from the > > same > > source works correctly, will have to dig deeper to find out what is > > happening. > > Thanks. > > > > > +   on the result.  */ > > Hmm... Is there an actual non-breaking space character here, or is your > MUA munging the messages? > > > +  if (dpyinfo_valid (first_dpyinfo)) > > +      store_config_changed_event (Qfont_render, > > +                                  XCAR (first_dpyinfo- > > >name_list_element)); > > You got the indentation wrong here.  The "s" in > "store_config_changed_event" should be two spaces behind where it is > now. > > Otherwise, LGTM.  Hopefully the copyright paperwork can be finished > soon. --=-mmTeLzNAJeAK4lRU/qTZ Content-Disposition: attachment; filename*0=0001-Use-gsettings-font-rendering-entries-for-pgtk-builds.pat; filename*1=ch Content-Type: text/x-patch; name="0001-Use-gsettings-font-rendering-entries-for-pgtk-builds.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSBiOWQ5NmE0N2M0YjMwMWUwNDQ1YTZkN2I4MGNmYjg4NzZjOTIxYzA1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaWV0ZXIgdmFuIFByb29pamVuIDxwaWV0ZXIudmFuLnByb29p amVuQHRlbG9kZW4ubmw+CkRhdGU6IFRodSwgNyBBcHIgMjAyMiAxODo1MjoxNCArMDIwMApTdWJq ZWN0OiBbUEFUQ0hdIFVzZSBnc2V0dGluZ3MgZm9udCByZW5kZXJpbmcgZW50cmllcyBmb3IgcGd0 ayBidWlsZHMKCklmIHByZXNlbnQsIGFwcGx5IHRoZSBnc2V0dGluZ3MgZm9udCBoaW50aW5nIGFu ZCBhbnRpYWxpYXNpbmcKZW50cmllcyB3aGVuIGNyZWF0aW5nIGEgZm9udCBpbiBjYWlyby4gIERv IHRoaXMgYXQKaW5pdGlhbGl6YXRpb24gYW5kIHdoZW4gdGhlIGVudHJpZXMgY2hhbmdlLCByZS1y ZW5kZXJpbmcgdGhlCmZyYW1lcy4KCiogc3JjL2Z0Y3Jmb250LmMgKGZ0Y3Jmb250X29wZW4pOiBV c2UgdGhlIGZvbnRfb3B0aW9ucyBkZXJpdmVkCmZyb20gZ3NldHRpbmdzIHdoZW4gb3BlbmluZyBh IGZvbnQuCihmdGNyZm9udF9jYWNoZWRfZm9udF9vayk6IFJlcG9ydCBhIGNhY2hlZCBmb250IGFz IGludmFsaWQgaWYKaXRzIGZvbnQgb3B0aW9ucyBkaWZmZXIgZnJvbSB0aGUgY3VycmVudCBvcHRp b25zIGluc2lkZQpnc2V0dGluZ3MuCihmdGNyZm9udF9kcmF3KTogVXNlIGEgZGlmZmVyZW50IGNh aXJvIG9wZXJhdG9yIHdoZW4KZHJhd2luZyBzdWJwaXhlbCBhbnRpYWxpYXNlZCBmb250cy4KKiBz cmMveHNldHRpbmdzLmMgKGFwcGx5X2dzZXR0aW5nc19mb250X2hpbnRpbmcpCihhcHBseV9nc2V0 dGluZ3NfZm9udF9hbGlhcywgYXBwbHlfZ3NldHRpbmdzX2ZvbnRfcmdiYV9vcmRlcik6CkNvbnZl cnQgdGhlIHNldHRpbmdzIGZyb20gR1NldHRpbmdzIHRvIHRoZSBjYWlyb19mb250X29wdGlvbnNf dApvYmplY3QuCihpbml0X2dzZXR0aW5ncywgc29tZXRoaW5nX2NoYW5nZWRfZ3NldHRpbmdzQ0Ip OiBJbnZva2UgdGhlCmFwcGx5IGZ1bmN0aW9ucyBpZiB0aGUgcmVsZXZhbnQgc2V0dGluZ3MgY2hh bmdlZC4KKHN0b3JlX2ZvbnRfb3B0aW9uc19jaGFuZ2VkKTogU3RvcmUgYW4gZXZlbnQgdG8gcmUt cmVuZGVyIHRoZQpmb250cy4KKHhzZXR0aW5nX2dldF9mb250X29wdGlvbnMpCiogc3JjL3hzZXR0 aW5ncy5oICh4c2V0dGluZ3NfZ2V0X2ZvbnRfb3B0aW9ucyk6IE5ldyBmdW5jdGlvbi4KLS0tCiBz cmMvZnRjcmZvbnQuYyAgfCAgNDMgKysrKysrKysrKysrKysKIHNyYy94c2V0dGluZ3MuYyB8IDE0 NyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIHNyYy94 c2V0dGluZ3MuaCB8ICAgNSArKwogMyBmaWxlcyBjaGFuZ2VkLCAxOTUgaW5zZXJ0aW9ucygrKQoK ZGlmZiAtLWdpdCBhL3NyYy9mdGNyZm9udC5jIGIvc3JjL2Z0Y3Jmb250LmMKaW5kZXggOThhMjhh ZjVmMi4uZTYwNjdkMjVjNyAxMDA2NDQKLS0tIGEvc3JjL2Z0Y3Jmb250LmMKKysrIGIvc3JjL2Z0 Y3Jmb250LmMKQEAgLTM3LDYgKzM3LDkgQEAKICNpbmNsdWRlICJmb250LmgiCiAjaW5jbHVkZSAi ZnRmb250LmgiCiAjaW5jbHVkZSAicGR1bXBlci5oIgorI2lmZGVmIEhBVkVfUEdUSworI2luY2x1 ZGUgInhzZXR0aW5ncy5oIgorI2VuZGlmCiAKICNpZmRlZiBVU0VfQkVfQ0FJUk8KICNkZWZpbmUg UkVEX0ZST01fVUxPTkcoY29sb3IpCSgoKGNvbG9yKSA+PiAxNikgJiAweGZmKQpAQCAtMTY4LDcg KzE3MSwxMiBAQCBmdGNyZm9udF9vcGVuIChzdHJ1Y3QgZnJhbWUgKmYsIExpc3BfT2JqZWN0IGVu dGl0eSwgaW50IHBpeGVsX3NpemUpCiAgIGNhaXJvX21hdHJpeF90IGZvbnRfbWF0cml4LCBjdG07 CiAgIGNhaXJvX21hdHJpeF9pbml0X3NjYWxlICgmZm9udF9tYXRyaXgsIHBpeGVsX3NpemUsIHBp eGVsX3NpemUpOwogICBjYWlyb19tYXRyaXhfaW5pdF9pZGVudGl0eSAoJmN0bSk7CisKKyNpZmRl ZiBIQVZFX1BHVEsKKyAgY2Fpcm9fZm9udF9vcHRpb25zX3QgKm9wdGlvbnMgPSB4c2V0dGluZ3Nf Z2V0X2ZvbnRfb3B0aW9ucyAoKTsKKyNlbHNlCiAgIGNhaXJvX2ZvbnRfb3B0aW9uc190ICpvcHRp b25zID0gY2Fpcm9fZm9udF9vcHRpb25zX2NyZWF0ZSAoKTsKKyNlbmRpZgogI2lmZGVmIFVTRV9C RV9DQUlSTwogICBpZiAoYmVfdXNlX3N1YnBpeGVsX2FudGlhbGlhc2luZyAoKSkKICAgICBjYWly b19mb250X29wdGlvbnNfc2V0X2FudGlhbGlhcyAob3B0aW9ucywgQ0FJUk9fQU5USUFMSUFTX1NV QlBJWEVMKTsKQEAgLTU5OSw2ICs2MDcsMTYgQEAgZnRjcmZvbnRfZHJhdyAoc3RydWN0IGdseXBo X3N0cmluZyAqcywKICAgeF9zZXRfY3Jfc291cmNlX3dpdGhfZ2NfZm9yZWdyb3VuZCAoZiwgcy0+ Z2MsIGZhbHNlKTsKICNlbHNlCiAgIHBndGtfc2V0X2NyX3NvdXJjZV93aXRoX2NvbG9yIChmLCBz LT54Z2N2LmZvcmVncm91bmQsIGZhbHNlKTsKKworICAvKiBUaGUgQ0FJUk9fT1BFUkFUT1JfU09V UkNFIG9wZXJhdG9yIHNldCBieSBwZ3RrX3NldF9jcl9zb3VyY2Vfd2l0aF9jb2xvcgorICAgICBh Ym92ZSByZW5kZXJzIHN1Yi1waXhlbCBhbnRpLWFsaWFzZWQgZm9udHMgaW4gZ3JleS1zY2FsZSwg dXNlIHRoZQorICAgICBkZWZhdWx0IENBSVJPX09QRVJBVE9SX09WRVIgaW5zdGVhZC4gICovCisg IGNhaXJvX2ZvbnRfb3B0aW9uc190ICpvcHRpb25zID0gY2Fpcm9fZm9udF9vcHRpb25zX2NyZWF0 ZSAoKTsKKyAgY2Fpcm9fc2NhbGVkX2ZvbnRfZ2V0X2ZvbnRfb3B0aW9ucyAoZnRjcmZvbnRfaW5m by0+Y3Jfc2NhbGVkX2ZvbnQsCisJCQkJICAgICAgb3B0aW9ucyk7CisgIGlmIChjYWlyb19mb250 X29wdGlvbnNfZ2V0X2FudGlhbGlhcyAob3B0aW9ucykgPT0gQ0FJUk9fQU5USUFMSUFTX1NVQlBJ WEVMKQorICAgIGNhaXJvX3NldF9vcGVyYXRvciAoY3IsIENBSVJPX09QRVJBVE9SX09WRVIpOwor ICBjYWlyb19mb250X29wdGlvbnNfZGVzdHJveSAob3B0aW9ucyk7CiAjZW5kaWYKICNlbHNlCiAg IHVpbnQzMl90IGNvbCA9IGJlX2ZvcmVncm91bmQ7CkBAIC02MjQsNiArNjQyLDI4IEBAIGZ0Y3Jm b250X2RyYXcgKHN0cnVjdCBnbHlwaF9zdHJpbmcgKnMsCiAgIHJldHVybiBsZW47CiB9CiAKKyNp ZmRlZiBIQVZFX1BHVEsKKy8qIERldGVybWluZSBpZiBGT05UX09CSkVDVCBpcyBhIHZhbGlkIGNh Y2hlZCBmb250IGZvciBFTlRJVFkgYnkKKyAgIGNvbXBhcmluZyB0aGUgb3B0aW9ucyB1c2VkIHRv IG9wZW4gaXQgd2l0aCB0aGUgdXNlcidzIGN1cnJlbnQKKyAgIHByZWZlcmVuY2VzIHNwZWNpZmll ZCB2aWEgR1NldHRpbmdzLiAgKi8KK3N0YXRpYyBib29sCitmdGNyZm9udF9jYWNoZWRfZm9udF9v ayAoc3RydWN0IGZyYW1lICpmLCBMaXNwX09iamVjdCBmb250X29iamVjdCwKKwkJCSBMaXNwX09i amVjdCBlbnRpdHkpCit7CisgIHN0cnVjdCBmb250X2luZm8gKmluZm8gPSAoc3RydWN0IGZvbnRf aW5mbyAqKSBYRk9OVF9PQkpFQ1QgKGZvbnRfb2JqZWN0KTsKKworICBjYWlyb19mb250X29wdGlv bnNfdCAqb3B0aW9ucyA9IGNhaXJvX2ZvbnRfb3B0aW9uc19jcmVhdGUgKCk7CisgIGNhaXJvX3Nj YWxlZF9mb250X2dldF9mb250X29wdGlvbnMgKGluZm8tPmNyX3NjYWxlZF9mb250LCBvcHRpb25z KTsKKyAgY2Fpcm9fZm9udF9vcHRpb25zX3QgKmdzZXR0aW5nc19vcHRpb25zID0geHNldHRpbmdz X2dldF9mb250X29wdGlvbnMgKCk7CisKKyAgYm9vbCBlcXVhbCA9IGNhaXJvX2ZvbnRfb3B0aW9u c19lcXVhbCAob3B0aW9ucywgZ3NldHRpbmdzX29wdGlvbnMpOworICBjYWlyb19mb250X29wdGlv bnNfZGVzdHJveSAob3B0aW9ucyk7CisgIGNhaXJvX2ZvbnRfb3B0aW9uc19kZXN0cm95IChnc2V0 dGluZ3Nfb3B0aW9ucyk7CisKKyAgcmV0dXJuIGVxdWFsOworfQorI2VuZGlmCisKICNpZmRlZiBI QVZFX0hBUkZCVVpaCiAKIHN0YXRpYyBMaXNwX09iamVjdApAQCAtNjk0LDYgKzczNCw5IEBAIGZ0 Y3JoYmZvbnRfZW5kX2hiX2ZvbnQgKHN0cnVjdCBmb250ICpmb250LCBoYl9mb250X3QgKmhiX2Zv bnQpCiAjZW5kaWYKICAgLmZpbHRlcl9wcm9wZXJ0aWVzID0gZnRmb250X2ZpbHRlcl9wcm9wZXJ0 aWVzLAogICAuY29tYmluaW5nX2NhcGFiaWxpdHkgPSBmdGZvbnRfY29tYmluaW5nX2NhcGFiaWxp dHksCisjaWZkZWYgSEFWRV9QR1RLCisgIC5jYWNoZWRfZm9udF9vayA9IGZ0Y3Jmb250X2NhY2hl ZF9mb250X29rCisjZW5kaWYKICAgfTsKICNpZmRlZiBIQVZFX0hBUkZCVVpaCiBzdHJ1Y3QgZm9u dF9kcml2ZXIgZnRjcmhiZm9udF9kcml2ZXI7CmRpZmYgLS1naXQgYS9zcmMveHNldHRpbmdzLmMg Yi9zcmMveHNldHRpbmdzLmMKaW5kZXggNzFkMDJlNjE1Mi4uZTcxODg3ZTAzZCAxMDA2NDQKLS0t IGEvc3JjL3hzZXR0aW5ncy5jCisrKyBiL3NyYy94c2V0dGluZ3MuYwpAQCAtMjE1LDExICsyMTUs MTE2IEBAICNkZWZpbmUgR1NFVFRJTkdTX01PTk9fRk9OVCAgIm1vbm9zcGFjZS1mb250LW5hbWUi CiAjZGVmaW5lIEdTRVRUSU5HU19GT05UX05BTUUgICJmb250LW5hbWUiCiAjZW5kaWYKIAorI2lm ZGVmIEhBVkVfUEdUSworI2RlZmluZSBHU0VUVElOR1NfRk9OVF9BTlRJQUxJQVNJTkcgICJmb250 LWFudGlhbGlhc2luZyIKKyNkZWZpbmUgR1NFVFRJTkdTX0ZPTlRfUkdCQV9PUkRFUiAgICAiZm9u dC1yZ2JhLW9yZGVyIgorI2RlZmluZSBHU0VUVElOR1NfRk9OVF9ISU5USU5HICAgICAgICJmb250 LWhpbnRpbmciCisjZW5kaWYKIAogLyogVGhlIHNpbmdsZSBHU2V0dGluZ3MgaW5zdGFuY2UsIG9y IE5VTEwgaWYgbm90IGNvbm5lY3RlZCB0byBHU2V0dGluZ3MuICAqLwogCiBzdGF0aWMgR1NldHRp bmdzICpnc2V0dGluZ3NfY2xpZW50OwogCisjaWZkZWYgSEFWRV9QR1RLCisKKy8qIFRoZSBjYWly byBmb250X29wdGlvbnMgYXMgb2J0YWluZWQgdXNpbmcgZ3NldHRpbmdzLiAgKi8KK3N0YXRpYyBj YWlyb19mb250X29wdGlvbnNfdCAqZm9udF9vcHRpb25zOworCisvKiBTdG9yZSBhbiBldmVudCBm b3IgcmUtcmVuZGVyaW5nIG9mIHRoZSBmb250cy4gICovCitzdGF0aWMgdm9pZAorc3RvcmVfZm9u dF9vcHRpb25zX2NoYW5nZWQgKHZvaWQpCit7CisgIGlmIChkcHlpbmZvX3ZhbGlkIChmaXJzdF9k cHlpbmZvKSkKKyAgICBzdG9yZV9jb25maWdfY2hhbmdlZF9ldmVudCAoUWZvbnRfcmVuZGVyLAor CQkJCVhDQVIgKGZpcnN0X2RweWluZm8tPm5hbWVfbGlzdF9lbGVtZW50KSk7Cit9CisKKy8qIEFw cGx5IGNoYW5nZXMgaW4gdGhlIGhpbnRpbmcgc3lzdGVtIHNldHRpbmcuICAqLworc3RhdGljIHZv aWQKK2FwcGx5X2dzZXR0aW5nc19mb250X2hpbnRpbmcgKEdTZXR0aW5ncyAqc2V0dGluZ3MpCit7 CisgIEdWYXJpYW50ICp2YWwgPSBnX3NldHRpbmdzX2dldF92YWx1ZSAoc2V0dGluZ3MsIEdTRVRU SU5HU19GT05UX0hJTlRJTkcpOworICBpZiAodmFsKQorICAgIHsKKyAgICAgIGdfdmFyaWFudF9y ZWZfc2luayAodmFsKTsKKyAgICAgIGlmIChnX3ZhcmlhbnRfaXNfb2ZfdHlwZSAodmFsLCBHX1ZB UklBTlRfVFlQRV9TVFJJTkcpKQorCXsKKwkgIGNvbnN0IGNoYXIgKmhpbnRpbmcgPSBnX3Zhcmlh bnRfZ2V0X3N0cmluZyAodmFsLCBOVUxMKTsKKworCSAgaWYgKCFzdHJjbXAgKGhpbnRpbmcsICJm dWxsIikpCisJICAgIGNhaXJvX2ZvbnRfb3B0aW9uc19zZXRfaGludF9zdHlsZSAoZm9udF9vcHRp b25zLAorCQkJCQkgICAgICAgQ0FJUk9fSElOVF9TVFlMRV9GVUxMKTsKKwkgIGVsc2UgaWYgKCFz dHJjbXAgKGhpbnRpbmcsICJtZWRpdW0iKSkKKwkgICAgY2Fpcm9fZm9udF9vcHRpb25zX3NldF9o aW50X3N0eWxlIChmb250X29wdGlvbnMsCisJCQkJCSAgICAgICBDQUlST19ISU5UX1NUWUxFX01F RElVTSk7CisJICBlbHNlIGlmICghc3RyY21wIChoaW50aW5nLCAic2xpZ2h0IikpCisJICAgIGNh aXJvX2ZvbnRfb3B0aW9uc19zZXRfaGludF9zdHlsZSAoZm9udF9vcHRpb25zLAorCQkJCQkgICAg ICAgQ0FJUk9fSElOVF9TVFlMRV9TTElHSFQpOworCSAgZWxzZSBpZiAoIXN0cmNtcCAoaGludGlu ZywgIm5vbmUiKSkKKwkgICAgY2Fpcm9fZm9udF9vcHRpb25zX3NldF9oaW50X3N0eWxlIChmb250 X29wdGlvbnMsCisJCQkJCSAgICAgICBDQUlST19ISU5UX1NUWUxFX05PTkUpOworCX0KKyAgICAg IGdfdmFyaWFudF91bnJlZiAodmFsKTsKKyAgICB9Cit9CisKKy8qIEFwcGx5IGNoYW5nZXMgaW4g dGhlIGFudGlhbGlhc2luZyBzeXN0ZW0gc2V0dGluZy4gICovCitzdGF0aWMgdm9pZAorYXBwbHlf Z3NldHRpbmdzX2ZvbnRfYW50aWFsaWFzIChHU2V0dGluZ3MgKnNldHRpbmdzKQoreworICBHVmFy aWFudCAqdmFsID0gZ19zZXR0aW5nc19nZXRfdmFsdWUgKHNldHRpbmdzLCBHU0VUVElOR1NfRk9O VF9BTlRJQUxJQVNJTkcpOworICBpZiAodmFsKQorICAgIHsKKyAgICAgIGdfdmFyaWFudF9yZWZf c2luayAodmFsKTsKKyAgICAgIGlmIChnX3ZhcmlhbnRfaXNfb2ZfdHlwZSAodmFsLCBHX1ZBUklB TlRfVFlQRV9TVFJJTkcpKQorCXsKKwkgIGNvbnN0IGNoYXIgKmFudGlhbGlhcyA9IGdfdmFyaWFu dF9nZXRfc3RyaW5nICh2YWwsIE5VTEwpOworCisJICBpZiAoIXN0cmNtcCAoYW50aWFsaWFzLCAi bm9uZSIpKQorCSAgICBjYWlyb19mb250X29wdGlvbnNfc2V0X2FudGlhbGlhcyAoZm9udF9vcHRp b25zLAorCQkJCQkgICAgICBDQUlST19BTlRJQUxJQVNfTk9ORSk7CisJICBlbHNlIGlmICghc3Ry Y21wIChhbnRpYWxpYXMsICJncmF5c2NhbGUiKSkKKwkgICAgY2Fpcm9fZm9udF9vcHRpb25zX3Nl dF9hbnRpYWxpYXMgKGZvbnRfb3B0aW9ucywKKwkJCQkJICAgICAgQ0FJUk9fQU5USUFMSUFTX0dS QVkpOworCSAgZWxzZSBpZiAoIXN0cmNtcCAoYW50aWFsaWFzLCAicmdiYSIpKQorCSAgICBjYWly b19mb250X29wdGlvbnNfc2V0X2FudGlhbGlhcyAoZm9udF9vcHRpb25zLAorCQkJCQkgICAgICBD QUlST19BTlRJQUxJQVNfU1VCUElYRUwpOworCX0KKyAgICAgIGdfdmFyaWFudF91bnJlZiAodmFs KTsKKyAgICB9Cit9CisKKy8qIEFwcGx5IHRoZSBzZXR0aW5ncyBmb3IgdGhlIHJnYiBlbGVtZW50 IG9yZGVyaW5nLiAgKi8KK3N0YXRpYyB2b2lkCithcHBseV9nc2V0dGluZ3NfZm9udF9yZ2JhX29y ZGVyIChHU2V0dGluZ3MgKnNldHRpbmdzKQoreworICBHVmFyaWFudCAqdmFsID0gZ19zZXR0aW5n c19nZXRfdmFsdWUgKHNldHRpbmdzLAorCQkJCQlHU0VUVElOR1NfRk9OVF9SR0JBX09SREVSKTsK KyAgaWYgKHZhbCkKKyAgICB7CisgICAgICBnX3ZhcmlhbnRfcmVmX3NpbmsgKHZhbCk7CisgICAg ICBpZiAoZ192YXJpYW50X2lzX29mX3R5cGUgKHZhbCwgR19WQVJJQU5UX1RZUEVfU1RSSU5HKSkK Kwl7CisJICBjb25zdCBjaGFyICpyZ2JhX29yZGVyID0gZ192YXJpYW50X2dldF9zdHJpbmcgKHZh bCwgTlVMTCk7CisKKwkgIGlmICghc3RyY21wIChyZ2JhX29yZGVyLCAicmdiIikpCisJICAgIGNh aXJvX2ZvbnRfb3B0aW9uc19zZXRfc3VicGl4ZWxfb3JkZXIgKGZvbnRfb3B0aW9ucywKKwkJCQkJ CSAgIENBSVJPX1NVQlBJWEVMX09SREVSX1JHQik7CisJICBlbHNlIGlmICghc3RyY21wIChyZ2Jh X29yZGVyLCAiYmdyIikpCisJICAgIGNhaXJvX2ZvbnRfb3B0aW9uc19zZXRfc3VicGl4ZWxfb3Jk ZXIgKGZvbnRfb3B0aW9ucywKKwkJCQkJCSAgIENBSVJPX1NVQlBJWEVMX09SREVSX0JHUik7CisJ ICBlbHNlIGlmICghc3RyY21wIChyZ2JhX29yZGVyLCAidnJnYiIpKQorCSAgICBjYWlyb19mb250 X29wdGlvbnNfc2V0X3N1YnBpeGVsX29yZGVyIChmb250X29wdGlvbnMsCisJCQkJCQkgICBDQUlS T19TVUJQSVhFTF9PUkRFUl9WUkdCKTsKKwkgIGVsc2UgaWYgKCFzdHJjbXAgKHJnYmFfb3JkZXIs ICJ2YmdyIikpCisJICAgIGNhaXJvX2ZvbnRfb3B0aW9uc19zZXRfc3VicGl4ZWxfb3JkZXIgKGZv bnRfb3B0aW9ucywKKwkJCQkJCSAgIENBSVJPX1NVQlBJWEVMX09SREVSX1ZCR1IpOworCX0KKyAg ICAgIGdfdmFyaWFudF91bnJlZiAodmFsKTsKKyAgICB9Cit9CisjZW5kaWYgLyogSEFWRV9QR1RL ICovCisKIC8qIENhbGxiYWNrIGNhbGxlZCB3aGVuIHNvbWV0aGluZyBjaGFuZ2VkIGluIEdTZXR0 aW5ncy4gICovCiAKIHN0YXRpYyB2b2lkCkBAIC0yNzMsNiArMzc4LDIzIEBAIHNvbWV0aGluZ19j aGFuZ2VkX2dzZXR0aW5nc0NCIChHU2V0dGluZ3MgKnNldHRpbmdzLAogICAgICAgICB9CiAgICAg fQogI2VuZGlmIC8qIFVTRV9DQUlSTyB8fCBIQVZFX1hGVCAqLworI2lmZGVmIEhBVkVfUEdUSwor ICBlbHNlIGlmICghc3RyY21wIChrZXksIEdTRVRUSU5HU19GT05UX0FOVElBTElBU0lORykpCisg ICAgeworICAgICAgYXBwbHlfZ3NldHRpbmdzX2ZvbnRfYW50aWFsaWFzIChzZXR0aW5ncyk7Cisg ICAgICBzdG9yZV9mb250X29wdGlvbnNfY2hhbmdlZCAoKTsKKyAgICB9CisgIGVsc2UgaWYgKCFz dHJjbXAgKGtleSwgR1NFVFRJTkdTX0ZPTlRfSElOVElORykpCisgICAgeworICAgICAgYXBwbHlf Z3NldHRpbmdzX2ZvbnRfaGludGluZyAoc2V0dGluZ3MpOworICAgICAgc3RvcmVfZm9udF9vcHRp b25zX2NoYW5nZWQgKCk7CisgICAgfQorICBlbHNlIGlmICghc3RyY21wIChrZXksIEdTRVRUSU5H U19GT05UX1JHQkFfT1JERVIpKQorICAgIHsKKyAgICAgIGFwcGx5X2dzZXR0aW5nc19mb250X3Jn YmFfb3JkZXIgKHNldHRpbmdzKTsKKyAgICAgIHN0b3JlX2ZvbnRfb3B0aW9uc19jaGFuZ2VkICgp OworICAgIH0KKyNlbmRpZiAvKiBIQVZFX1BHVEsgKi8KIH0KIAogI2VuZGlmIC8qIEhBVkVfR1NF VFRJTkdTICovCkBAIC05MDAsNiArMTAyMiwxNiBAQCBpbml0X2dzZXR0aW5ncyAodm9pZCkKICAg ICAgICAgZHVwc3RyaW5nICgmY3VycmVudF9mb250LCBnX3ZhcmlhbnRfZ2V0X3N0cmluZyAodmFs LCBOVUxMKSk7CiAgICAgICBnX3ZhcmlhbnRfdW5yZWYgKHZhbCk7CiAgICAgfQorCisgIC8qIE9u bHkgdXNlIHRoZSBnc2V0dGluZ3MgZm9udCBlbnRyaWVzIGZvciB0aGUgQ2Fpcm8gYmFja2VuZAor ICAgICBydW5uaW5nIG9uIFBHVEsuICAqLworI2lmZGVmIEhBVkVfUEdUSworICBmb250X29wdGlv bnMgPSBjYWlyb19mb250X29wdGlvbnNfY3JlYXRlICgpOworICBhcHBseV9nc2V0dGluZ3NfZm9u dF9hbnRpYWxpYXMgKGdzZXR0aW5nc19jbGllbnQpOworICBhcHBseV9nc2V0dGluZ3NfZm9udF9o aW50aW5nIChnc2V0dGluZ3NfY2xpZW50KTsKKyAgYXBwbHlfZ3NldHRpbmdzX2ZvbnRfcmdiYV9v cmRlciAoZ3NldHRpbmdzX2NsaWVudCk7CisjZW5kaWYgLyogSEFWRV9QR1RLICovCisKICNlbmRp ZiAvKiBVU0VfQ0FJUk8gfHwgSEFWRV9YRlQgKi8KIAogI2VuZGlmIC8qIEhBVkVfR1NFVFRJTkdT ICovCkBAIC0xMDIxLDYgKzExNTMsMTcgQEAgeHNldHRpbmdzX2dldF9zeXN0ZW1fbm9ybWFsX2Zv bnQgKHZvaWQpCiB9CiAjZW5kaWYKIAorI2lmZGVmIEhBVkVfUEdUSworLyogUmV0dXJuIHRoZSBj YWlybyBmb250IG9wdGlvbnMsIHVwZGF0ZWQgZnJvbSB0aGUgZ3NldHRpbmdzIGZvbnQKKyAgIGNv bmZpZyBlbnRyaWVzLiAgVGhlIGNhbGxlciBzaG91bGQgY2FsbCBjYWlyb19mb250X29wdGlvbnNf ZGVzdHJveQorICAgb24gdGhlIHJlc3VsdC4gICovCitjYWlyb19mb250X29wdGlvbnNfdCAqCit4 c2V0dGluZ3NfZ2V0X2ZvbnRfb3B0aW9ucyAodm9pZCkKK3sKKyAgcmV0dXJuIGNhaXJvX2ZvbnRf b3B0aW9uc19jb3B5IChmb250X29wdGlvbnMpOworfQorI2VuZGlmCisKIERFRlVOICgiZm9udC1n ZXQtc3lzdGVtLW5vcm1hbC1mb250IiwgRmZvbnRfZ2V0X3N5c3RlbV9ub3JtYWxfZm9udCwKICAg ICAgICBTZm9udF9nZXRfc3lzdGVtX25vcm1hbF9mb250LAogICAgICAgIDAsIDAsIDAsCkBAIC0x MDczLDYgKzEyMTYsMTAgQEAgc3ltc19vZl94c2V0dGluZ3MgKHZvaWQpCiAgIGdjb25mX2NsaWVu dCA9IE5VTEw7CiAgIFBEVU1QRVJfSUdOT1JFIChnY29uZl9jbGllbnQpOwogI2VuZGlmCisjaWZk ZWYgSEFWRV9QR1RLCisgIGZvbnRfb3B0aW9ucyA9IE5VTEw7CisgIFBEVU1QRVJfSUdOT1JFIChm b250X29wdGlvbnMpOworI2VuZGlmCiAKICAgREVGU1lNIChRbW9ub3NwYWNlX2ZvbnRfbmFtZSwg Im1vbm9zcGFjZS1mb250LW5hbWUiKTsKICAgREVGU1lNIChRZm9udF9uYW1lLCAiZm9udC1uYW1l Iik7CmRpZmYgLS1naXQgYS9zcmMveHNldHRpbmdzLmggYi9zcmMveHNldHRpbmdzLmgKaW5kZXgg Y2NhYTM2NDg5ZC4uNWU1ZGYzNzA2MiAxMDA2NDQKLS0tIGEvc3JjL3hzZXR0aW5ncy5oCisrKyBi L3NyYy94c2V0dGluZ3MuaApAQCAtMjMsNiArMjMsOCBAQCAjZGVmaW5lIFhTRVRUSU5HU19ICiAj aWZuZGVmIEhBVkVfUEdUSwogI2luY2x1ZGUgImRpc3BleHRlcm4uaCIKICNpbmNsdWRlIDxYMTEv WGxpYi5oPgorI2Vsc2UKKyNpbmNsdWRlIDxjYWlyby5oPgogI2VuZGlmCiAKIHN0cnVjdCB4X2Rp c3BsYXlfaW5mbzsKQEAgLTQxLDUgKzQzLDggQEAgI2RlZmluZSBYU0VUVElOR1NfSAogZXh0ZXJu IGNvbnN0IGNoYXIgKnhzZXR0aW5nc19nZXRfc3lzdGVtX25vcm1hbF9mb250ICh2b2lkKTsKICNl bmRpZgogCisjaWZkZWYgSEFWRV9QR1RLCitleHRlcm4gY2Fpcm9fZm9udF9vcHRpb25zX3QgKnhz ZXR0aW5nc19nZXRfZm9udF9vcHRpb25zICh2b2lkKTsKKyNlbmRpZgogCiAjZW5kaWYgLyogWFNF VFRJTkdTX0ggKi8KLS0gCjIuMzIuMAoK --=-mmTeLzNAJeAK4lRU/qTZ-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 07 19:38:21 2022 Received: (at 54564) by debbugs.gnu.org; 7 Apr 2022 23:38:21 +0000 Received: from localhost ([127.0.0.1]:33632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ncbhl-0003iw-7v for submit@debbugs.gnu.org; Thu, 07 Apr 2022 19:38:21 -0400 Received: from sonic304-22.consmr.mail.ne1.yahoo.com ([66.163.191.148]:39546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ncbhj-0003ii-Hl for 54564@debbugs.gnu.org; Thu, 07 Apr 2022 19:38:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649374693; bh=NmP5Pki4+tH2CroP21O8KUTOMnLI7HKxPG8U5aaWTPM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=obCp5W4ARt20mvacf0AaMA9blRvJE1BWdAuv63NEOYYt2bVa7hMp7RIN/z9MXhHOdVchq64ORe8jMIg9qpdvPcvnt96hiLdk/jrM0qOzAntp7C1EawVrwF2z08kECsVrp/+6xOH3SbGyqGdrHxGlAubJ6DEYcDLXVEc8j7Bve0+WNGVPu9TjIzGGk0lXaQYfEOPpHLeoGG719pihS5PGo0sh5Fepau3P6XJE3Gv55wKPY6MzAAaadBt9zdcaipMqzt96ijPPxQAj/8iYwDGvkX50/77elIuCBjIkY1WxLB1EJ1eAixtUo85NYsT5WauOpQfVkMHz/1Eh+H76WAR4Wg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649374693; bh=H1SDbhJhzz41UwovJ1wj3JD6wLxv1ct+FCFwd15M23O=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=VecrdMc+ZYwzBEEp3m2yIefGvRFVGWALybvWPKnIiYu+wRL5d0K0D9E268J09ARKRsbtTT/aiZVC8Jhbwo45HCF63I3GUZy3pGmukrJcKQ8Lo6PX3hu0YkjE7LfPXbGaoFp1+NV6HdiHjgzqtv0jeLWS71E4XnV/eXlWyx7R4FI7/TDGNNMFpibARgcB0clIjqPdzioHngjYjmh2I2nGQ/5KPV1b/a8jySgLT/+O6S3hBZ7aD8NBsEskc8SAZ6i6HdW+M/0tqZzIuxowtfDOrgCindQkzoCLAO4WfL4il/9c/OUPGb/CH6AyQSTOaO9TK9xMpYcl1V5WUH1eMzHX3w== X-YMail-OSG: 4Qj.KcEVM1ni4YFRdnBvYCpQUUAJdRWw723YTafdh.HQd3Ju3aQajxRyBmS2cZU 63o4Jzz0JU_6mZZ9IN7mNRkVMNjc1PAUotQggdSxQn8NNwkw8llclVV2V5kQlhGyVPBT6S6e538s 6tL0CJueeYONMdH.PdV36MYDTzwtZQMXp3oU.x6g2cm.ewpSkXuDfLuKGMYMfk1OyNoWCDk9jf7y RmYZ1JwUjff1uQsx.46.I_OMa0oJVm0nYVXuYgMTDGvtx4rZXyrGxowouoQP9akUuYt_gnTjKiYR czR2jCljnJHv643k0KExYJERa1acCFlXmp1HcU8WfuW06ssM9GH3yRDee16bfKSuv8upauUQCiHq F1WYjEMWw_2Wqw0jtHhYeRvwlsnMjukFmJTokbiE0Nwa1.EsLfzLvs0HR.AEv7XsiSfyrlEi8CZk nFqBhNy3k.YOU7VtltzTfaHfKS49dCg22NRDNLgPIufFWXtwUIj.Za55coTgrAEB5GzAmJ0picbC ryjWuHT37MuFGtvY5TVUzZZp8ygiv49D3BvvXoJx8xFkynXumUx3G5b4Abldmp73PbteyivYDdQl qPbHdiHmlPnsZzvFec8Yw6cNlXmkUwSTmckjy6QiUkciwzTqoy65NsDUTmGti1oieGQdYI5WLmbJ 3aC5V9HWPVlTlBF6ztmyf8OShfGRjyQM_3Spg4VUUzGwAv6PchGssBgLe_8MiHHyreazUeVDnY3Z K47._K0jIuV7wyah30.yT1Au3WIupI7Pz_dH8G8cYb_0UNqxjSCwaQ0Z3NzsTE5t_1Xl_vZaYrQN _YVHkOh7GCXlDHySfBXkT6HeTBKKxtbFCNdNngOE1Uz.4Y1xG6bHr.5pa5JQF.jLN.S.gQNsQGYi c2XQAQrxfSttAMtGj3.A1IoTG5jH3gW2DUTwzcxkktn3wuTozJ1Q3VeBj8qihqS4KpmgOwcysIWo QuZj55IXz7w66RNGRtjLqfd08M8dQzb1VZKPPcs7EjIY97jZ3MmBjeuY4jxtmtXObJogeRim8gdd KgoUk8Jtq8hBIUDQVOJMjOM4i70HgwkuIXGoXkN2HX_alKEcXkQALHSWFYHdd9PWRMAp0v.k0rap oKMd.JfvksM5OP2rBi.fmsjPhjeXRydHUabQH3VQQARLbquO8LFJhHcyQvdoW_IaNCYMRXUXDcL0 0s57HGms_pJv4ldbzzBBOVZyKU.ZVyogcdFp_nlxVvXlHA6SnJGOS3WxpotkKlv54qDGB6oDRRyE IhWZqWbd5MrR6bS1K6y9AvpbECxs1ppeecD6gfGad.IXIfNPqiOBaAQXcNT.JwyBLqPFdID4Z3nz KJ2PNEc0ADeTBAhtH.cuIx9Fvq3ShwTlzODGsDXBSFrRHZj10JmuOhi.nrDZF_1GJm1og_ClFfgh GqJrftzRjECrvEwxElQAeEByBmWoKrHpJ0A2nU0Qgmx1dXh.pVog2PMVeFY0IiRohPPDxb2BBIIZ OHIpbbMoWJPInBw7Oomao8WHLL_5Lc8QnMb_ZC4jLCEF9Wr76f3iEfC6a_i5PqbS48qUc6R51yX5 LyF71A2lrmPRtLa8liD1cU7xjSAA4hX2.3aduLcdjx.lzB9BfzxhUHshw.Lyh455P87tQOaIiMHf sB3fgxC_wImCRo3OqkSiEtZyd5ONB51L8AhYbqhw1eh47fn2IrL1YFPuSvmYpZvsAyFY_5B4OAB_ YV4c98oozCzrIkHTPeA3yOEpC4FpJK4V1mNB7zbdYogJyiPCbL1HRn5h8pfBYm6_mtAg6jTU8Iip ..3ixc7vNII6jXMDSpWz.cBB5xWn.SpRq7Xqq5r2ruvINwejSY2k0kmUM1845wQirF8HOUnYE3nE AFKiWQRrZC3dkqwesSMFax0PwdiFPNqlND9q5F0dZPzXPW.n9j7hiLyL0npPNDZoUOQHHsvHNAyz aNSfJkEycbXpc5yd.FUhDKJEP0URdxVdMpfvcx5LAJMc0BpkyAtYeBVACY.xqi7B4LwDYeA7kxEM IBg90V8RdtinwA03vDqadoNN3Qici7nhcysMaea7Q33Yr91hk_UTBqnh54Z3Dz5XKnmYTunCyHOe kbgXPVjK2AcqNlwDkUN0rXkNNKLwO6Em7.ju.BvSljjN8pHQ7_n8Li87hNLQJdsD82bkfYSutad0 9SWrHGpHUBFPj1JXKENKm5V_sAmAZOuGbNV18oa2_G7Gd5hVqVzKMSR1iQ.aYqNNpI1GM4RzY490 sjLvfjNt0ZUVx21gVx3TmEeJj1P4eX2KCn9255rqCLt1mL_sTlVn4C5qyrHp1gpV2ypQUnN6PF0P BEChheyGr2tOY70w7NAFkZaO.maaVfbditqFW4pyL2JqAtt.3KGdYU_Ngpch5MbvpDhb4FxtxEP8 11kY- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ne1.yahoo.com with HTTP; Thu, 7 Apr 2022 23:38:13 +0000 Received: by hermes--canary-production-sg3-65d7bd97b5-gqv44 (VZM Hermes SMTP Server) with ESMTPA ID 674d9332323d063d07fdad5ba1c61005; Thu, 07 Apr 2022 23:38:09 +0000 (UTC) From: Po Lu To: Pieter van Prooijen Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> <83czi9b5gh.fsf@gnu.org> <87v8w143h6.fsf@yahoo.com> <87o81s2osr.fsf@yahoo.com> <88d833f72df4f4cbb5769f1a75057d3f957a812c.camel@teloden.nl> <87bkxnx1co.fsf@yahoo.com> <211c08916190ef05cc1677956a77fca0c6122eda.camel@teloden.nl> <87k0c9imvp.fsf@yahoo.com> <66a9a7d83ca545dd23c890d4aa97717f1796579f.camel@teloden.nl> Date: Fri, 08 Apr 2022 07:38:05 +0800 In-Reply-To: <66a9a7d83ca545dd23c890d4aa97717f1796579f.camel@teloden.nl> (Pieter van Prooijen's message of "Thu, 07 Apr 2022 21:24:28 +0200") Message-ID: <8735ioxy5e.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.20048 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 2265 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54564 Cc: Eli Zaretskii , 54564@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pieter van Prooijen writes: > Hi All,=C2=A0 > > It took a fair bit of digging, but sub-pixel anti-aliasing on pgtk now > seems to work correctly. > > The problem lies with the "source" operator set by pgtk when drawing a > font, this will take a particular execution path in the cairo glyph > compositor (using a mask image) which converts the colors created by > freetype for the sub pixel effect to greys-cale. Using the default > "over" operator takes a different path which preserves the colors. Note > that on small screens the difference between sub-pixel and grey-scale > rendering is hard to see, it's more pronounced on larger displays) Ah thanks. Does this fix the problem as well? diff --git a/src/pgtkterm.c b/src/pgtkterm.c index b2816aa04a..5fbc56ae81 100644 --- a/src/pgtkterm.c +++ b/src/pgtkterm.c @@ -7037,8 +7037,11 @@ pgtk_set_cr_source_with_color (struct frame *f, unsi= gned long color, pgtk_query_color (f, &col); =20 if (!respects_alpha_background) - cairo_set_source_rgb (FRAME_CR_CONTEXT (f), col.red / 65535.0, - col.green / 65535.0, col.blue / 65535.0); + { + cairo_set_source_rgb (FRAME_CR_CONTEXT (f), col.red / 65535.0, + col.green / 65535.0, col.blue / 65535.0); + cairo_set_operator (FRAME_CR_CONTEXT (f), CAIRO_OPERATOR_OVER); + } else { cairo_set_source_rgba (FRAME_CR_CONTEXT (f), col.red / 65535.0, > I've also fixed the indent error, but couldn't find the non-breaking > space in the patch, it's perhaps caused by the mail program. It was previously filled with non-breaking spaces, but the patch you attached looks fine now. > Regarding the copyright assignment, I've had no response after sending > in the questionnaire at > https://git.savannah.gnu.org/cgit/gnulib.git/plain/doc/Copyright/request-= assign.future > to assign@gnu.org It takes a while; if you don't get a response in 2 weeks, you should contact Eli or Lars, and they will ask the folks at the FSF to expedite things. > Do you get sent a paper form of some kind which has to be filled in? > (I'm not at my home address atm so I will have missed that) You get sent a document you have to print and fill in, I think, but that depends on the country you're in. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 08 14:45:02 2022 Received: (at 54564) by debbugs.gnu.org; 8 Apr 2022 18:45:02 +0000 Received: from localhost ([127.0.0.1]:35974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nctbN-0004BP-UF for submit@debbugs.gnu.org; Fri, 08 Apr 2022 14:45:02 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:54585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nctbM-0004BB-5x for 54564@debbugs.gnu.org; Fri, 08 Apr 2022 14:44:56 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 07EB25C00E5; Fri, 8 Apr 2022 14:44:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 08 Apr 2022 14:44:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=teloden.nl; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=XmPmLuq+M6OBlT5zYiPIzrXB0h9sIo/rrxNO4N 5HO+M=; b=Ph/Gumv+4+o48QuR44qdtXckXHidTkAonxKpZVLNsz6UcOuw1xDagt PvWfGXWLwmGtliKooIxDRmuxTrTn+GwH/89HoIC8b5w4fFPMNASTE7sZhwk4PEab j7VLoO/CU4t2oDZaJufj46oQVTLid9BCkLg9l1upIkWZwbZvYbVH4Ps3f6ACAMwi JI2rHz1xDyMP2B8vdyoVg1TtauPAMqeXbED8LqBeVYJ/t4rgNFGrbI9HEyy8RAKH 71O7wMnOsySzzAwE0o6BZZmoXjhIwc7wLPeN7/kW5qZA5hm5yHOhNkqj5OEgO3Ap TD0/Mab6tBEgE5/OSVLmiQJXq7UjuxpQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=XmPmLuq+M6OBlT5zY iPIzrXB0h9sIo/rrxNO4N5HO+M=; b=fTpDuJZDcMyAu2gb0zHWwzArc4RGbgwGq Kf4TE5nuBvWX+piYYQMh8IYux2vzHMYoHrsElRJG6llZPoJ8lji1foijs+8HCh0G +ok3OvziyacqSa75VyFwluV8Eg+rcqW5Y9TGDXh3n8mlbhL0uQPcfKOMmY8IKCHG abMakpuzfa56gSSU2CkLHyGgQ1MvB3PCgq7DbdwXONM/J7I3SA1NJ/5QuiRqoEew Ooc1MRPDU17eY9FDKefrtOEyGwmOMWJ0nVo5WeykPa9em+8AJRIL3hg5K17vHsMh JRf+eJz4vNqSzU39nHC8OtcP71qG+4phOLFs2GcLPzURdM1J9NZnA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudektddguddvkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkuffhvfffjghftggfggesmhdtreertderjeenucfhrhhomheprfhivght vghruchvrghnucfrrhhoohhijhgvnhcuoehpihgvthgvrhdrvhgrnhdrphhrohhoihhjvg hnsehtvghlohguvghnrdhnlheqnecuggftrfgrthhtvghrnhepffekuefhjeffgeejffdt iedukeeutdfftdetvdffffeffeehiefgudelhfffheelnecuffhomhgrihhnpegtohhlrd hrvggupdgtohhlrdhgrhgvvghnpdgtohhlrdgslhhuvgdpghhnuhdrohhrghenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpihgvthgvrhdrvh grnhdrphhrohhoihhjvghnsehtvghlohguvghnrdhnlh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Apr 2022 14:44:49 -0400 (EDT) Message-ID: <04ae2baf0a2a974bb411820c4d294b82d86ddc92.camel@teloden.nl> Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds From: Pieter van Prooijen To: Po Lu Date: Fri, 08 Apr 2022 20:44:47 +0200 In-Reply-To: <8735ioxy5e.fsf@yahoo.com> References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> <83czi9b5gh.fsf@gnu.org> <87v8w143h6.fsf@yahoo.com> <87o81s2osr.fsf@yahoo.com> <88d833f72df4f4cbb5769f1a75057d3f957a812c.camel@teloden.nl> <87bkxnx1co.fsf@yahoo.com> <211c08916190ef05cc1677956a77fca0c6122eda.camel@teloden.nl> <87k0c9imvp.fsf@yahoo.com> <66a9a7d83ca545dd23c890d4aa97717f1796579f.camel@teloden.nl> <8735ioxy5e.fsf@yahoo.com> Content-Type: multipart/mixed; boundary="=-/bTr7EmZFZdoOnWtRsD7" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54564 Cc: Eli Zaretskii , 54564@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-/bTr7EmZFZdoOnWtRsD7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Hi, Yes, your patch fixes the problem as well, and I don't see any other side effects at a first glance. I've changed my patch to incorporate it and revert the changes to ftcrfont_draw. Thanks, Pieter On Fri, 2022-04-08 at 07:38 +0800, Po Lu wrote: > Pieter van Prooijen writes: > > > Hi All,  > > > > It took a fair bit of digging, but sub-pixel anti-aliasing on pgtk > > now > > seems to work correctly. > > > > The problem lies with the "source" operator set by pgtk when > > drawing a > > font, this will take a particular execution path in the cairo glyph > > compositor (using a mask image) which converts the colors created > > by > > freetype for the sub pixel effect to greys-cale. Using the default > > "over" operator takes a different path which preserves the colors. > > Note > > that on small screens the difference between sub-pixel and grey- > > scale > > rendering is hard to see, it's more pronounced on larger displays) > > Ah thanks.  Does this fix the problem as well? > > diff --git a/src/pgtkterm.c b/src/pgtkterm.c > index b2816aa04a..5fbc56ae81 100644 > --- a/src/pgtkterm.c > +++ b/src/pgtkterm.c > @@ -7037,8 +7037,11 @@ pgtk_set_cr_source_with_color (struct frame > *f, unsigned long color, >    pgtk_query_color (f, &col); >   >    if (!respects_alpha_background) > -    cairo_set_source_rgb (FRAME_CR_CONTEXT (f), col.red / 65535.0, > -                         col.green / 65535.0, col.blue / 65535.0); > +    { > +      cairo_set_source_rgb (FRAME_CR_CONTEXT (f), col.red / 65535.0, > +                           col.green / 65535.0, col.blue / 65535.0); > +      cairo_set_operator (FRAME_CR_CONTEXT (f), > CAIRO_OPERATOR_OVER); > +    } >    else >      { >        cairo_set_source_rgba (FRAME_CR_CONTEXT (f), col.red / > 65535.0, > > > I've also fixed the indent error, but couldn't find the non- > > breaking > > space in the patch, it's perhaps caused by the mail program. > > It was previously filled with non-breaking spaces, but the patch you > attached looks fine now. > > > Regarding the copyright assignment, I've had no response after > > sending > > in the questionnaire at > > https://git.savannah.gnu.org/cgit/gnulib.git/plain/doc/Copyright/re > > quest-assign.future > > to assign@gnu.org > > It takes a while; if you don't get a response in 2 weeks, you should > contact Eli or Lars, and they will ask the folks at the FSF to > expedite > things. > > > Do you get sent a paper form of some kind which has to be filled > > in? > > (I'm not at my home address atm so I will have missed that) > > You get sent a document you have to print and fill in, I think, but > that > depends on the country you're in. > > Thanks. --=-/bTr7EmZFZdoOnWtRsD7 Content-Disposition: attachment; filename*0=0001-Use-gsettings-font-rendering-entries-for-pgtk-builds.pat; filename*1=ch Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-Use-gsettings-font-rendering-entries-for-pgtk-builds.patch"; charset="UTF-8" RnJvbSA3Y2I0NTg5NDRlODI1MjgxZGY1OWE2ZGQzNjBlMGU0MGZmMzEyZDI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaWV0ZXIgdmFuIFByb29pamVuIDxwaWV0ZXIudmFuLnByb29p amVuQHRlbG9kZW4ubmw+CkRhdGU6IFRodSwgNyBBcHIgMjAyMiAxODo1MjoxNCArMDIwMApTdWJq ZWN0OiBbUEFUQ0hdIFVzZSBnc2V0dGluZ3MgZm9udCByZW5kZXJpbmcgZW50cmllcyBmb3IgcGd0 ayBidWlsZHMKCklmIHByZXNlbnQsIGFwcGx5IHRoZSBnc2V0dGluZ3MgZm9udCBoaW50aW5nIGFu ZCBhbnRpYWxpYXNpbmcKZW50cmllcyB3aGVuIGNyZWF0aW5nIGEgZm9udCBpbiBjYWlyby4gIERv IHRoaXMgYXQKaW5pdGlhbGl6YXRpb24gYW5kIHdoZW4gdGhlIGVudHJpZXMgY2hhbmdlLCByZS1y ZW5kZXJpbmcgdGhlCmZyYW1lcy4KCiogc3JjL2Z0Y3Jmb250LmMgKGZ0Y3Jmb250X29wZW4pOiBV c2UgdGhlIGZvbnRfb3B0aW9ucyBkZXJpdmVkCmZyb20gZ3NldHRpbmdzIHdoZW4gb3BlbmluZyBh IGZvbnQuCihmdGNyZm9udF9jYWNoZWRfZm9udF9vayk6IFJlcG9ydCBhIGNhY2hlZCBmb250IGFz IGludmFsaWQgaWYKaXRzIGZvbnQgb3B0aW9ucyBkaWZmZXIgZnJvbSB0aGUgY3VycmVudCBvcHRp b25zIGluc2lkZQpnc2V0dGluZ3MuCiogc3JjL3hzZXR0aW5ncy5jIChhcHBseV9nc2V0dGluZ3Nf Zm9udF9oaW50aW5nKQooYXBwbHlfZ3NldHRpbmdzX2ZvbnRfYWxpYXMsIGFwcGx5X2dzZXR0aW5n c19mb250X3JnYmFfb3JkZXIpOgpDb252ZXJ0IHRoZSBzZXR0aW5ncyBmcm9tIEdTZXR0aW5ncyB0 byB0aGUgY2Fpcm9fZm9udF9vcHRpb25zX3QKb2JqZWN0LgooaW5pdF9nc2V0dGluZ3MsIHNvbWV0 aGluZ19jaGFuZ2VkX2dzZXR0aW5nc0NCKTogSW52b2tlIHRoZQphcHBseSBmdW5jdGlvbnMgaWYg dGhlIHJlbGV2YW50IHNldHRpbmdzIGNoYW5nZWQuCihzdG9yZV9mb250X29wdGlvbnNfY2hhbmdl ZCk6IFN0b3JlIGFuIGV2ZW50IHRvIHJlLXJlbmRlciB0aGUKZm9udHMuCih4c2V0dGluZ19nZXRf Zm9udF9vcHRpb25zKQoqIHNyYy94c2V0dGluZ3MuaCAoeHNldHRpbmdzX2dldF9mb250X29wdGlv bnMpOiBOZXcgZnVuY3Rpb24uCiogc3JjL3BndGt0ZXJtLmMgKHBndGtfc2V0X2NyX3NvdXJjZV93 aXRoX2NvbG9yKTogVXNlIHRoZQpkZWZhdWx0IENBSVJPX09QRVJBVE9SX09WRVIgZm9yIG5vbi1y ZXNwZWN0c19hbHBoYV9iYWNrZ3JvdW5kCmNhbGxzIHRvIHByZXNlcnZlIHRoZSBjb2xvciBpbmZv cm1hdGlvbiBhZGRlZCBieSBzdWItcGl4ZWwKYW50aS1hbGlhc2VkIHJlbmRlcmVkIGZvbnRzLgot LS0KIHNyYy9mdGNyZm9udC5jICB8ICAzMyArKysrKysrKysrKwogc3JjL3BndGt0ZXJtLmMgIHwg ICA1ICstCiBzcmMveHNldHRpbmdzLmMgfCAxNDcgKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrCiBzcmMveHNldHRpbmdzLmggfCAgIDUgKysKIDQgZmlsZXMg Y2hhbmdlZCwgMTg5IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9z cmMvZnRjcmZvbnQuYyBiL3NyYy9mdGNyZm9udC5jCmluZGV4IDk4YTI4YWY1ZjIuLjZiYjQxMTEw ZDUgMTAwNjQ0Ci0tLSBhL3NyYy9mdGNyZm9udC5jCisrKyBiL3NyYy9mdGNyZm9udC5jCkBAIC0z Nyw2ICszNyw5IEBACiAjaW5jbHVkZSAiZm9udC5oIgogI2luY2x1ZGUgImZ0Zm9udC5oIgogI2lu Y2x1ZGUgInBkdW1wZXIuaCIKKyNpZmRlZiBIQVZFX1BHVEsKKyNpbmNsdWRlICJ4c2V0dGluZ3Mu aCIKKyNlbmRpZgogCiAjaWZkZWYgVVNFX0JFX0NBSVJPCiAjZGVmaW5lIFJFRF9GUk9NX1VMT05H KGNvbG9yKQkoKChjb2xvcikgPj4gMTYpICYgMHhmZikKQEAgLTE2OCw3ICsxNzEsMTIgQEAgZnRj cmZvbnRfb3BlbiAoc3RydWN0IGZyYW1lICpmLCBMaXNwX09iamVjdCBlbnRpdHksIGludCBwaXhl bF9zaXplKQogICBjYWlyb19tYXRyaXhfdCBmb250X21hdHJpeCwgY3RtOwogICBjYWlyb19tYXRy aXhfaW5pdF9zY2FsZSAoJmZvbnRfbWF0cml4LCBwaXhlbF9zaXplLCBwaXhlbF9zaXplKTsKICAg Y2Fpcm9fbWF0cml4X2luaXRfaWRlbnRpdHkgKCZjdG0pOworCisjaWZkZWYgSEFWRV9QR1RLCisg IGNhaXJvX2ZvbnRfb3B0aW9uc190ICpvcHRpb25zID0geHNldHRpbmdzX2dldF9mb250X29wdGlv bnMgKCk7CisjZWxzZQogICBjYWlyb19mb250X29wdGlvbnNfdCAqb3B0aW9ucyA9IGNhaXJvX2Zv bnRfb3B0aW9uc19jcmVhdGUgKCk7CisjZW5kaWYKICNpZmRlZiBVU0VfQkVfQ0FJUk8KICAgaWYg KGJlX3VzZV9zdWJwaXhlbF9hbnRpYWxpYXNpbmcgKCkpCiAgICAgY2Fpcm9fZm9udF9vcHRpb25z X3NldF9hbnRpYWxpYXMgKG9wdGlvbnMsIENBSVJPX0FOVElBTElBU19TVUJQSVhFTCk7CkBAIC02 MjQsNiArNjMyLDI4IEBAIGZ0Y3Jmb250X2RyYXcgKHN0cnVjdCBnbHlwaF9zdHJpbmcgKnMsCiAg IHJldHVybiBsZW47CiB9CiAKKyNpZmRlZiBIQVZFX1BHVEsKKy8qIERldGVybWluZSBpZiBGT05U X09CSkVDVCBpcyBhIHZhbGlkIGNhY2hlZCBmb250IGZvciBFTlRJVFkgYnkKKyAgIGNvbXBhcmlu ZyB0aGUgb3B0aW9ucyB1c2VkIHRvIG9wZW4gaXQgd2l0aCB0aGUgdXNlcidzIGN1cnJlbnQKKyAg IHByZWZlcmVuY2VzIHNwZWNpZmllZCB2aWEgR1NldHRpbmdzLiAgKi8KK3N0YXRpYyBib29sCitm dGNyZm9udF9jYWNoZWRfZm9udF9vayAoc3RydWN0IGZyYW1lICpmLCBMaXNwX09iamVjdCBmb250 X29iamVjdCwKKwkJCSBMaXNwX09iamVjdCBlbnRpdHkpCit7CisgIHN0cnVjdCBmb250X2luZm8g KmluZm8gPSAoc3RydWN0IGZvbnRfaW5mbyAqKSBYRk9OVF9PQkpFQ1QgKGZvbnRfb2JqZWN0KTsK KworICBjYWlyb19mb250X29wdGlvbnNfdCAqb3B0aW9ucyA9IGNhaXJvX2ZvbnRfb3B0aW9uc19j cmVhdGUgKCk7CisgIGNhaXJvX3NjYWxlZF9mb250X2dldF9mb250X29wdGlvbnMgKGluZm8tPmNy X3NjYWxlZF9mb250LCBvcHRpb25zKTsKKyAgY2Fpcm9fZm9udF9vcHRpb25zX3QgKmdzZXR0aW5n c19vcHRpb25zID0geHNldHRpbmdzX2dldF9mb250X29wdGlvbnMgKCk7CisKKyAgYm9vbCBlcXVh bCA9IGNhaXJvX2ZvbnRfb3B0aW9uc19lcXVhbCAob3B0aW9ucywgZ3NldHRpbmdzX29wdGlvbnMp OworICBjYWlyb19mb250X29wdGlvbnNfZGVzdHJveSAob3B0aW9ucyk7CisgIGNhaXJvX2ZvbnRf b3B0aW9uc19kZXN0cm95IChnc2V0dGluZ3Nfb3B0aW9ucyk7CisKKyAgcmV0dXJuIGVxdWFsOwor fQorI2VuZGlmCisKICNpZmRlZiBIQVZFX0hBUkZCVVpaCiAKIHN0YXRpYyBMaXNwX09iamVjdApA QCAtNjk0LDYgKzcyNCw5IEBAIGZ0Y3JoYmZvbnRfZW5kX2hiX2ZvbnQgKHN0cnVjdCBmb250ICpm b250LCBoYl9mb250X3QgKmhiX2ZvbnQpCiAjZW5kaWYKICAgLmZpbHRlcl9wcm9wZXJ0aWVzID0g ZnRmb250X2ZpbHRlcl9wcm9wZXJ0aWVzLAogICAuY29tYmluaW5nX2NhcGFiaWxpdHkgPSBmdGZv bnRfY29tYmluaW5nX2NhcGFiaWxpdHksCisjaWZkZWYgSEFWRV9QR1RLCisgIC5jYWNoZWRfZm9u dF9vayA9IGZ0Y3Jmb250X2NhY2hlZF9mb250X29rCisjZW5kaWYKICAgfTsKICNpZmRlZiBIQVZF X0hBUkZCVVpaCiBzdHJ1Y3QgZm9udF9kcml2ZXIgZnRjcmhiZm9udF9kcml2ZXI7CmRpZmYgLS1n aXQgYS9zcmMvcGd0a3Rlcm0uYyBiL3NyYy9wZ3RrdGVybS5jCmluZGV4IGIyODE2YWEwNGEuLjli YzJkZGZkNzkgMTAwNjQ0Ci0tLSBhL3NyYy9wZ3RrdGVybS5jCisrKyBiL3NyYy9wZ3RrdGVybS5j CkBAIC03MDM3LDggKzcwMzcsMTEgQEAgcGd0a19zZXRfY3Jfc291cmNlX3dpdGhfY29sb3IgKHN0 cnVjdCBmcmFtZSAqZiwgdW5zaWduZWQgbG9uZyBjb2xvciwKICAgcGd0a19xdWVyeV9jb2xvciAo ZiwgJmNvbCk7CiAKICAgaWYgKCFyZXNwZWN0c19hbHBoYV9iYWNrZ3JvdW5kKQotICAgIGNhaXJv X3NldF9zb3VyY2VfcmdiIChGUkFNRV9DUl9DT05URVhUIChmKSwgY29sLnJlZCAvIDY1NTM1LjAs CisgICAgeworICAgICAgY2Fpcm9fc2V0X3NvdXJjZV9yZ2IgKEZSQU1FX0NSX0NPTlRFWFQgKGYp LCBjb2wucmVkIC8gNjU1MzUuMCwKIAkJCSAgY29sLmdyZWVuIC8gNjU1MzUuMCwgY29sLmJsdWUg LyA2NTUzNS4wKTsKKyAgICAgIGNhaXJvX3NldF9vcGVyYXRvciAoRlJBTUVfQ1JfQ09OVEVYVCAo ZiksIENBSVJPX09QRVJBVE9SX09WRVIpOworICAgIH0KICAgZWxzZQogICAgIHsKICAgICAgIGNh aXJvX3NldF9zb3VyY2VfcmdiYSAoRlJBTUVfQ1JfQ09OVEVYVCAoZiksIGNvbC5yZWQgLyA2NTUz NS4wLApkaWZmIC0tZ2l0IGEvc3JjL3hzZXR0aW5ncy5jIGIvc3JjL3hzZXR0aW5ncy5jCmluZGV4 IDcxZDAyZTYxNTIuLmU3MTg4N2UwM2QgMTAwNjQ0Ci0tLSBhL3NyYy94c2V0dGluZ3MuYworKysg Yi9zcmMveHNldHRpbmdzLmMKQEAgLTIxNSwxMSArMjE1LDExNiBAQCAjZGVmaW5lIEdTRVRUSU5H U19NT05PX0ZPTlQgICJtb25vc3BhY2UtZm9udC1uYW1lIgogI2RlZmluZSBHU0VUVElOR1NfRk9O VF9OQU1FICAiZm9udC1uYW1lIgogI2VuZGlmCiAKKyNpZmRlZiBIQVZFX1BHVEsKKyNkZWZpbmUg R1NFVFRJTkdTX0ZPTlRfQU5USUFMSUFTSU5HICAiZm9udC1hbnRpYWxpYXNpbmciCisjZGVmaW5l IEdTRVRUSU5HU19GT05UX1JHQkFfT1JERVIgICAgImZvbnQtcmdiYS1vcmRlciIKKyNkZWZpbmUg R1NFVFRJTkdTX0ZPTlRfSElOVElORyAgICAgICAiZm9udC1oaW50aW5nIgorI2VuZGlmCiAKIC8q IFRoZSBzaW5nbGUgR1NldHRpbmdzIGluc3RhbmNlLCBvciBOVUxMIGlmIG5vdCBjb25uZWN0ZWQg dG8gR1NldHRpbmdzLiAgKi8KIAogc3RhdGljIEdTZXR0aW5ncyAqZ3NldHRpbmdzX2NsaWVudDsK IAorI2lmZGVmIEhBVkVfUEdUSworCisvKiBUaGUgY2Fpcm8gZm9udF9vcHRpb25zIGFzIG9idGFp bmVkIHVzaW5nIGdzZXR0aW5ncy4gICovCitzdGF0aWMgY2Fpcm9fZm9udF9vcHRpb25zX3QgKmZv bnRfb3B0aW9uczsKKworLyogU3RvcmUgYW4gZXZlbnQgZm9yIHJlLXJlbmRlcmluZyBvZiB0aGUg Zm9udHMuICAqLworc3RhdGljIHZvaWQKK3N0b3JlX2ZvbnRfb3B0aW9uc19jaGFuZ2VkICh2b2lk KQoreworICBpZiAoZHB5aW5mb192YWxpZCAoZmlyc3RfZHB5aW5mbykpCisgICAgc3RvcmVfY29u ZmlnX2NoYW5nZWRfZXZlbnQgKFFmb250X3JlbmRlciwKKwkJCQlYQ0FSIChmaXJzdF9kcHlpbmZv LT5uYW1lX2xpc3RfZWxlbWVudCkpOworfQorCisvKiBBcHBseSBjaGFuZ2VzIGluIHRoZSBoaW50 aW5nIHN5c3RlbSBzZXR0aW5nLiAgKi8KK3N0YXRpYyB2b2lkCithcHBseV9nc2V0dGluZ3NfZm9u dF9oaW50aW5nIChHU2V0dGluZ3MgKnNldHRpbmdzKQoreworICBHVmFyaWFudCAqdmFsID0gZ19z ZXR0aW5nc19nZXRfdmFsdWUgKHNldHRpbmdzLCBHU0VUVElOR1NfRk9OVF9ISU5USU5HKTsKKyAg aWYgKHZhbCkKKyAgICB7CisgICAgICBnX3ZhcmlhbnRfcmVmX3NpbmsgKHZhbCk7CisgICAgICBp ZiAoZ192YXJpYW50X2lzX29mX3R5cGUgKHZhbCwgR19WQVJJQU5UX1RZUEVfU1RSSU5HKSkKKwl7 CisJICBjb25zdCBjaGFyICpoaW50aW5nID0gZ192YXJpYW50X2dldF9zdHJpbmcgKHZhbCwgTlVM TCk7CisKKwkgIGlmICghc3RyY21wIChoaW50aW5nLCAiZnVsbCIpKQorCSAgICBjYWlyb19mb250 X29wdGlvbnNfc2V0X2hpbnRfc3R5bGUgKGZvbnRfb3B0aW9ucywKKwkJCQkJICAgICAgIENBSVJP X0hJTlRfU1RZTEVfRlVMTCk7CisJICBlbHNlIGlmICghc3RyY21wIChoaW50aW5nLCAibWVkaXVt IikpCisJICAgIGNhaXJvX2ZvbnRfb3B0aW9uc19zZXRfaGludF9zdHlsZSAoZm9udF9vcHRpb25z LAorCQkJCQkgICAgICAgQ0FJUk9fSElOVF9TVFlMRV9NRURJVU0pOworCSAgZWxzZSBpZiAoIXN0 cmNtcCAoaGludGluZywgInNsaWdodCIpKQorCSAgICBjYWlyb19mb250X29wdGlvbnNfc2V0X2hp bnRfc3R5bGUgKGZvbnRfb3B0aW9ucywKKwkJCQkJICAgICAgIENBSVJPX0hJTlRfU1RZTEVfU0xJ R0hUKTsKKwkgIGVsc2UgaWYgKCFzdHJjbXAgKGhpbnRpbmcsICJub25lIikpCisJICAgIGNhaXJv X2ZvbnRfb3B0aW9uc19zZXRfaGludF9zdHlsZSAoZm9udF9vcHRpb25zLAorCQkJCQkgICAgICAg Q0FJUk9fSElOVF9TVFlMRV9OT05FKTsKKwl9CisgICAgICBnX3ZhcmlhbnRfdW5yZWYgKHZhbCk7 CisgICAgfQorfQorCisvKiBBcHBseSBjaGFuZ2VzIGluIHRoZSBhbnRpYWxpYXNpbmcgc3lzdGVt IHNldHRpbmcuICAqLworc3RhdGljIHZvaWQKK2FwcGx5X2dzZXR0aW5nc19mb250X2FudGlhbGlh cyAoR1NldHRpbmdzICpzZXR0aW5ncykKK3sKKyAgR1ZhcmlhbnQgKnZhbCA9IGdfc2V0dGluZ3Nf Z2V0X3ZhbHVlIChzZXR0aW5ncywgR1NFVFRJTkdTX0ZPTlRfQU5USUFMSUFTSU5HKTsKKyAgaWYg KHZhbCkKKyAgICB7CisgICAgICBnX3ZhcmlhbnRfcmVmX3NpbmsgKHZhbCk7CisgICAgICBpZiAo Z192YXJpYW50X2lzX29mX3R5cGUgKHZhbCwgR19WQVJJQU5UX1RZUEVfU1RSSU5HKSkKKwl7CisJ ICBjb25zdCBjaGFyICphbnRpYWxpYXMgPSBnX3ZhcmlhbnRfZ2V0X3N0cmluZyAodmFsLCBOVUxM KTsKKworCSAgaWYgKCFzdHJjbXAgKGFudGlhbGlhcywgIm5vbmUiKSkKKwkgICAgY2Fpcm9fZm9u dF9vcHRpb25zX3NldF9hbnRpYWxpYXMgKGZvbnRfb3B0aW9ucywKKwkJCQkJICAgICAgQ0FJUk9f QU5USUFMSUFTX05PTkUpOworCSAgZWxzZSBpZiAoIXN0cmNtcCAoYW50aWFsaWFzLCAiZ3JheXNj YWxlIikpCisJICAgIGNhaXJvX2ZvbnRfb3B0aW9uc19zZXRfYW50aWFsaWFzIChmb250X29wdGlv bnMsCisJCQkJCSAgICAgIENBSVJPX0FOVElBTElBU19HUkFZKTsKKwkgIGVsc2UgaWYgKCFzdHJj bXAgKGFudGlhbGlhcywgInJnYmEiKSkKKwkgICAgY2Fpcm9fZm9udF9vcHRpb25zX3NldF9hbnRp YWxpYXMgKGZvbnRfb3B0aW9ucywKKwkJCQkJICAgICAgQ0FJUk9fQU5USUFMSUFTX1NVQlBJWEVM KTsKKwl9CisgICAgICBnX3ZhcmlhbnRfdW5yZWYgKHZhbCk7CisgICAgfQorfQorCisvKiBBcHBs eSB0aGUgc2V0dGluZ3MgZm9yIHRoZSByZ2IgZWxlbWVudCBvcmRlcmluZy4gICovCitzdGF0aWMg dm9pZAorYXBwbHlfZ3NldHRpbmdzX2ZvbnRfcmdiYV9vcmRlciAoR1NldHRpbmdzICpzZXR0aW5n cykKK3sKKyAgR1ZhcmlhbnQgKnZhbCA9IGdfc2V0dGluZ3NfZ2V0X3ZhbHVlIChzZXR0aW5ncywK KwkJCQkJR1NFVFRJTkdTX0ZPTlRfUkdCQV9PUkRFUik7CisgIGlmICh2YWwpCisgICAgeworICAg ICAgZ192YXJpYW50X3JlZl9zaW5rICh2YWwpOworICAgICAgaWYgKGdfdmFyaWFudF9pc19vZl90 eXBlICh2YWwsIEdfVkFSSUFOVF9UWVBFX1NUUklORykpCisJeworCSAgY29uc3QgY2hhciAqcmdi YV9vcmRlciA9IGdfdmFyaWFudF9nZXRfc3RyaW5nICh2YWwsIE5VTEwpOworCisJICBpZiAoIXN0 cmNtcCAocmdiYV9vcmRlciwgInJnYiIpKQorCSAgICBjYWlyb19mb250X29wdGlvbnNfc2V0X3N1 YnBpeGVsX29yZGVyIChmb250X29wdGlvbnMsCisJCQkJCQkgICBDQUlST19TVUJQSVhFTF9PUkRF Ul9SR0IpOworCSAgZWxzZSBpZiAoIXN0cmNtcCAocmdiYV9vcmRlciwgImJnciIpKQorCSAgICBj YWlyb19mb250X29wdGlvbnNfc2V0X3N1YnBpeGVsX29yZGVyIChmb250X29wdGlvbnMsCisJCQkJ CQkgICBDQUlST19TVUJQSVhFTF9PUkRFUl9CR1IpOworCSAgZWxzZSBpZiAoIXN0cmNtcCAocmdi YV9vcmRlciwgInZyZ2IiKSkKKwkgICAgY2Fpcm9fZm9udF9vcHRpb25zX3NldF9zdWJwaXhlbF9v cmRlciAoZm9udF9vcHRpb25zLAorCQkJCQkJICAgQ0FJUk9fU1VCUElYRUxfT1JERVJfVlJHQik7 CisJICBlbHNlIGlmICghc3RyY21wIChyZ2JhX29yZGVyLCAidmJnciIpKQorCSAgICBjYWlyb19m b250X29wdGlvbnNfc2V0X3N1YnBpeGVsX29yZGVyIChmb250X29wdGlvbnMsCisJCQkJCQkgICBD QUlST19TVUJQSVhFTF9PUkRFUl9WQkdSKTsKKwl9CisgICAgICBnX3ZhcmlhbnRfdW5yZWYgKHZh bCk7CisgICAgfQorfQorI2VuZGlmIC8qIEhBVkVfUEdUSyAqLworCiAvKiBDYWxsYmFjayBjYWxs ZWQgd2hlbiBzb21ldGhpbmcgY2hhbmdlZCBpbiBHU2V0dGluZ3MuICAqLwogCiBzdGF0aWMgdm9p ZApAQCAtMjczLDYgKzM3OCwyMyBAQCBzb21ldGhpbmdfY2hhbmdlZF9nc2V0dGluZ3NDQiAoR1Nl dHRpbmdzICpzZXR0aW5ncywKICAgICAgICAgfQogICAgIH0KICNlbmRpZiAvKiBVU0VfQ0FJUk8g fHwgSEFWRV9YRlQgKi8KKyNpZmRlZiBIQVZFX1BHVEsKKyAgZWxzZSBpZiAoIXN0cmNtcCAoa2V5 LCBHU0VUVElOR1NfRk9OVF9BTlRJQUxJQVNJTkcpKQorICAgIHsKKyAgICAgIGFwcGx5X2dzZXR0 aW5nc19mb250X2FudGlhbGlhcyAoc2V0dGluZ3MpOworICAgICAgc3RvcmVfZm9udF9vcHRpb25z X2NoYW5nZWQgKCk7CisgICAgfQorICBlbHNlIGlmICghc3RyY21wIChrZXksIEdTRVRUSU5HU19G T05UX0hJTlRJTkcpKQorICAgIHsKKyAgICAgIGFwcGx5X2dzZXR0aW5nc19mb250X2hpbnRpbmcg KHNldHRpbmdzKTsKKyAgICAgIHN0b3JlX2ZvbnRfb3B0aW9uc19jaGFuZ2VkICgpOworICAgIH0K KyAgZWxzZSBpZiAoIXN0cmNtcCAoa2V5LCBHU0VUVElOR1NfRk9OVF9SR0JBX09SREVSKSkKKyAg ICB7CisgICAgICBhcHBseV9nc2V0dGluZ3NfZm9udF9yZ2JhX29yZGVyIChzZXR0aW5ncyk7Cisg ICAgICBzdG9yZV9mb250X29wdGlvbnNfY2hhbmdlZCAoKTsKKyAgICB9CisjZW5kaWYgLyogSEFW RV9QR1RLICovCiB9CiAKICNlbmRpZiAvKiBIQVZFX0dTRVRUSU5HUyAqLwpAQCAtOTAwLDYgKzEw MjIsMTYgQEAgaW5pdF9nc2V0dGluZ3MgKHZvaWQpCiAgICAgICAgIGR1cHN0cmluZyAoJmN1cnJl bnRfZm9udCwgZ192YXJpYW50X2dldF9zdHJpbmcgKHZhbCwgTlVMTCkpOwogICAgICAgZ192YXJp YW50X3VucmVmICh2YWwpOwogICAgIH0KKworICAvKiBPbmx5IHVzZSB0aGUgZ3NldHRpbmdzIGZv bnQgZW50cmllcyBmb3IgdGhlIENhaXJvIGJhY2tlbmQKKyAgICAgcnVubmluZyBvbiBQR1RLLiAg Ki8KKyNpZmRlZiBIQVZFX1BHVEsKKyAgZm9udF9vcHRpb25zID0gY2Fpcm9fZm9udF9vcHRpb25z X2NyZWF0ZSAoKTsKKyAgYXBwbHlfZ3NldHRpbmdzX2ZvbnRfYW50aWFsaWFzIChnc2V0dGluZ3Nf Y2xpZW50KTsKKyAgYXBwbHlfZ3NldHRpbmdzX2ZvbnRfaGludGluZyAoZ3NldHRpbmdzX2NsaWVu dCk7CisgIGFwcGx5X2dzZXR0aW5nc19mb250X3JnYmFfb3JkZXIgKGdzZXR0aW5nc19jbGllbnQp OworI2VuZGlmIC8qIEhBVkVfUEdUSyAqLworCiAjZW5kaWYgLyogVVNFX0NBSVJPIHx8IEhBVkVf WEZUICovCiAKICNlbmRpZiAvKiBIQVZFX0dTRVRUSU5HUyAqLwpAQCAtMTAyMSw2ICsxMTUzLDE3 IEBAIHhzZXR0aW5nc19nZXRfc3lzdGVtX25vcm1hbF9mb250ICh2b2lkKQogfQogI2VuZGlmCiAK KyNpZmRlZiBIQVZFX1BHVEsKKy8qIFJldHVybiB0aGUgY2Fpcm8gZm9udCBvcHRpb25zLCB1cGRh dGVkIGZyb20gdGhlIGdzZXR0aW5ncyBmb250CisgICBjb25maWcgZW50cmllcy4gIFRoZSBjYWxs ZXIgc2hvdWxkIGNhbGwgY2Fpcm9fZm9udF9vcHRpb25zX2Rlc3Ryb3kKKyAgIG9uIHRoZSByZXN1 bHQuICAqLworY2Fpcm9fZm9udF9vcHRpb25zX3QgKgoreHNldHRpbmdzX2dldF9mb250X29wdGlv bnMgKHZvaWQpCit7CisgIHJldHVybiBjYWlyb19mb250X29wdGlvbnNfY29weSAoZm9udF9vcHRp b25zKTsKK30KKyNlbmRpZgorCiBERUZVTiAoImZvbnQtZ2V0LXN5c3RlbS1ub3JtYWwtZm9udCIs IEZmb250X2dldF9zeXN0ZW1fbm9ybWFsX2ZvbnQsCiAgICAgICAgU2ZvbnRfZ2V0X3N5c3RlbV9u b3JtYWxfZm9udCwKICAgICAgICAwLCAwLCAwLApAQCAtMTA3Myw2ICsxMjE2LDEwIEBAIHN5bXNf b2ZfeHNldHRpbmdzICh2b2lkKQogICBnY29uZl9jbGllbnQgPSBOVUxMOwogICBQRFVNUEVSX0lH Tk9SRSAoZ2NvbmZfY2xpZW50KTsKICNlbmRpZgorI2lmZGVmIEhBVkVfUEdUSworICBmb250X29w dGlvbnMgPSBOVUxMOworICBQRFVNUEVSX0lHTk9SRSAoZm9udF9vcHRpb25zKTsKKyNlbmRpZgog CiAgIERFRlNZTSAoUW1vbm9zcGFjZV9mb250X25hbWUsICJtb25vc3BhY2UtZm9udC1uYW1lIik7 CiAgIERFRlNZTSAoUWZvbnRfbmFtZSwgImZvbnQtbmFtZSIpOwpkaWZmIC0tZ2l0IGEvc3JjL3hz ZXR0aW5ncy5oIGIvc3JjL3hzZXR0aW5ncy5oCmluZGV4IGNjYWEzNjQ4OWQuLjVlNWRmMzcwNjIg MTAwNjQ0Ci0tLSBhL3NyYy94c2V0dGluZ3MuaAorKysgYi9zcmMveHNldHRpbmdzLmgKQEAgLTIz LDYgKzIzLDggQEAgI2RlZmluZSBYU0VUVElOR1NfSAogI2lmbmRlZiBIQVZFX1BHVEsKICNpbmNs dWRlICJkaXNwZXh0ZXJuLmgiCiAjaW5jbHVkZSA8WDExL1hsaWIuaD4KKyNlbHNlCisjaW5jbHVk ZSA8Y2Fpcm8uaD4KICNlbmRpZgogCiBzdHJ1Y3QgeF9kaXNwbGF5X2luZm87CkBAIC00MSw1ICs0 Myw4IEBAICNkZWZpbmUgWFNFVFRJTkdTX0gKIGV4dGVybiBjb25zdCBjaGFyICp4c2V0dGluZ3Nf Z2V0X3N5c3RlbV9ub3JtYWxfZm9udCAodm9pZCk7CiAjZW5kaWYKIAorI2lmZGVmIEhBVkVfUEdU SworZXh0ZXJuIGNhaXJvX2ZvbnRfb3B0aW9uc190ICp4c2V0dGluZ3NfZ2V0X2ZvbnRfb3B0aW9u cyAodm9pZCk7CisjZW5kaWYKIAogI2VuZGlmIC8qIFhTRVRUSU5HU19IICovCi0tIAoyLjMyLjAK Cg== --=-/bTr7EmZFZdoOnWtRsD7-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 08 20:35:31 2022 Received: (at 54564) by debbugs.gnu.org; 9 Apr 2022 00:35:31 +0000 Received: from localhost ([127.0.0.1]:36384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ncz4d-0006o9-Iz for submit@debbugs.gnu.org; Fri, 08 Apr 2022 20:35:31 -0400 Received: from sonic316-21.consmr.mail.ne1.yahoo.com ([66.163.187.147]:41342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ncz4b-0006nw-OM for 54564@debbugs.gnu.org; Fri, 08 Apr 2022 20:35:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649464524; bh=ywyta5mVVSNHDsjrusLzwTqiY1dlb2hMk2pLQy9Im7c=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=J/9fZKYfZXsiJinSNv6onW4cIQrHPeQqZlWDj8S/YkYCg6MhuSqaAdWxEkWhmZ5zoEdTo7LGWY1VAZZ46+Tn68VjOH19487+XZ4pEHJed0JkRmxf9jLDVnrR+Yhjl5pL2fOGk4iTVmvEWoXKboqh5t10CSrALAefY4moUy9FSt3eGB/V7Wdfy854Zr21/J7lC6PbP+G8jwMu1eAuKTr5ZZH0FIKbZm+jNoN+tTMBWxIIpdwOXcIgrOntspr/TgzKfC84DRsKdBXrOznSiM8PowjA31wiIK3LPnxwEVKOQKYnqm85tk5zctf5zBRRgtGNsmJ9i7t7JviFIK+lVuVpTQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649464524; bh=fhsi3ud+YiwGKkjSLb5UC0M+5F/rgKd+Aa7ZNrligzO=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=AVUjoHE7iN7ZO25mueyl3pkLiAqMvglvn77R8Y9f7InNzKodBe8S7c/6fyE5Fhn4fl9F5YYQ+xSIKb0TDBd2WMn/7n3dPZh74nxEfEtWHZAsdosrOwtR4Ijg4sDx4imMCb+KqEKtplOBIpA6TX1OkhJ06UdSbnPigjl+lVmVI5n8GVVKxPSM5KvXh0rMfvsZQ/I7yX2e+xoHdkXVuNWEq2WUpin4bG1V3eGzh4Q3+ZDru1kF13LzHqaPzsmLijyDp2E6XG0hZmjkPIvg2ocEBLnHHXfj+Lwlq7kJoZpLwnvt0H8JiFLtsP/Px+3Ch1r3Od7hrIUcbSB6oKHMMG6Qgw== X-YMail-OSG: CgqUlyoVM1kRIgxPH1ljVzjfITDOuorJANlCeQL2lfTwxRQQZQceIyMOlCbsl02 v7uoR0s6IDb37F3coZT46DDydkKPJh6GWdH4PZKDeONHwvRvZg_fL9fXaiv3sE1bl2Nhmyd0PPaL CR2GMBPtUBJ68ooyshXvTyRpe.kNdZOstr0pQ2z8OHM06_85TmPj2pBnUMcAyqGQfwe6q7ZsotJq G7ABkyCxjcrkjVzK0T7lLLSy6_Ym9h0heg._3AZbc5S8NiFcVm0Sbv4uxyJYc.5uyC3GZw6GzJT7 7C5BLZO6uD.JGoi8XRRpkQX5w6BP6w8dgIw4QOxY5K1sneOitv.opA27kQllkRu0ezATs8CO_6Im RyT92QvxqtNNJLbdGSQHPr1OKJ6SRz0Y2u3cDlJi8jfCUpM6.0ZLL2JmUMO9B5lUXzvLAK0KwM7l Wp5xzDOaRtX8G8vADJhf_MIx_5afx2K8aP5_fSAzRs.UpNAhKb8ZdiI4friuBAXaaMjvGsx__lzE Ehqlv4ii4Pg7zxPvjg8iFHWEtnemEJoXHLChDBqrMnzjOBiA0YPx7Slix43TCv3KlvcajyvFf5Jr AQqyr3qUpFHY52f2WaybD6bGiVc.htcd8A8sxSjXuBA81gQ.IQD3VEFwLCXUrP4QMP0ZVH80fpSm QzsOXx6RHOJIVtyXLcWzsyHp_TPRtgF2yLvV5z06.r7xYXbLelFZrHx0Vq5C8ddOVeyhVDFBCFDy h50gapArysR7zc4bIHyyV5Ac0aT7L5YBnUTx6ttq8OshgN0.CuidVDuquz7g59qGNxC.MD69bQKS hBBk2WRJtnBlE.BINvwXB1i2Y2qBkWl3c3bh2wtg3xXvqJrtT6IWmiIEGU95t_I7ShwZMiNv5i1x 4D.rOYzvVPxS3aReokWpyClo7ajBGF5jHvUhhoaI5sfXMsFIOEcgV5dnuVmnWIzQsbQjCYC8aDyQ q901rNyTGiORQqcrf9R6JUnEOKxDFS_L_ZrhPDF8yEvt1oHKvPkWrsFeFb90u8667Cb3aJI4tsdE h.0YEBMMXI_sFEPmJrO5DWE5YfQpE_SvjnjkegDI5_x8xHb_kU2SDVGAT5BcWE2sgQJnHuoRYqQ. p2H50bbOQ_YFd7MzNk3vXLy9gi_hY9HnXwvLXsCSfqfSSCpz3FN_ofJopTgFyd1wJEm3sntBdUaH vDWPvcKNIUghA6IlzxpqZYdM6HQdJfPGQIQF0wZ78hw8WiIGdV29FZne3ra5VxFB069p7NdAZZfv UJiC6Bt6Oz.yPs57Vqr_VmSiA4HGGLsD85mF7s1LJf4ir2DxTU.Cx2KdKpq4l9cQTdJFPWsYNr4R AsgRxhM5w6ITdsbXfjP97eV4DdUOlvS1IewV86EBjc2GCjXXJ.GsU0aBmV34pXKF3owEtCLNsqig hkt8Xz8nqc_qWoD28g090XeAi9l_cgmRRP.wNvHztvXIAAd1UsGSkZwGMG6__MVE5T.DA7ciVdCR 1IejNx2rJuz_M4Jk.RWHiDtkQbErANVYK_bH2krEb9U2kDm5YpSJc.jPFEqRDgQ7oE3RVasvOBJQ e4yZQV0wpxP8Q.jZW1v__OFJPYKvFc71Lb57Jh9QrxQg2Z7Wezzne3lMUs_qa.4MA.BWhcInNRs7 CBftO1PiBHKq3QX313GKaTPYBHCsLzo6hUQbFQ66MoWantx5qMSt3b3KE_3Hz1dSx7C3UirYoTTH gXqVBSOj5VbskTSuM12VEDHeuv7UniQv71dbDgrqnBFlQdv0O6wYIWgwpNMo3m8b96NGPhuP51Uc PDmdK7zGXfOgzUk5fAdaszJm7E8GD0oGx.ClCQbBubmom7cwIYj13FVpTIf_UNyzzF3aRbLF4cPy WOp652DdDiaWrnKt30L0i6GZv.S5ZN3_hW5VFqHsJm_BXh5aYFQ.oUIFnNLSZRf9Jfv3kYptYwmA sCVHVw9bF3WmpSgdEMstE6UckCGOSKxDAArivi_2T6Su5b.SE5pn6Y7yqPUu1evb77RGWYe9lmrY S9ycHUPg4Zqt27jiuPRCAxRGIO_B0nBBznvY5Csgtr052FPOcutcBUxj7vAtokgfBWrmUxr62aO0 P_gLwFDcdE0Tknq3G41BeKqYvNBpTB0guDn7.nF4lyLDHtRZthgaq3VYzgml6LZDYR1bkjtTmNB0 cxMkMCOQuoe1YCQxw6gpOwt6iKPKfmyqQEhyBnTbzWIaDzmBWCu0eAqcWRknADHkxUmvU3H4RdpP ZgUNMO9dtmvTPyD7DKn8weKxEL5aDebPs8C8F0Jr4Gd8z5sjMQuSk...73BzMpR.p2pgk X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Sat, 9 Apr 2022 00:35:24 +0000 Received: by hermes--canary-production-sg3-65d7bd97b5-r89m2 (VZM Hermes SMTP Server) with ESMTPA ID 80fba91e06b13604d3286abb2b024205; Sat, 09 Apr 2022 00:35:18 +0000 (UTC) From: Po Lu To: Pieter van Prooijen Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> <83czi9b5gh.fsf@gnu.org> <87v8w143h6.fsf@yahoo.com> <87o81s2osr.fsf@yahoo.com> <88d833f72df4f4cbb5769f1a75057d3f957a812c.camel@teloden.nl> <87bkxnx1co.fsf@yahoo.com> <211c08916190ef05cc1677956a77fca0c6122eda.camel@teloden.nl> <87k0c9imvp.fsf@yahoo.com> <66a9a7d83ca545dd23c890d4aa97717f1796579f.camel@teloden.nl> <8735ioxy5e.fsf@yahoo.com> <04ae2baf0a2a974bb411820c4d294b82d86ddc92.camel@teloden.nl> Date: Sat, 09 Apr 2022 08:35:14 +0800 In-Reply-To: <04ae2baf0a2a974bb411820c4d294b82d86ddc92.camel@teloden.nl> (Pieter van Prooijen's message of "Fri, 08 Apr 2022 20:44:47 +0200") Message-ID: <87czhrqekd.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.20048 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 422 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54564 Cc: Eli Zaretskii , 54564@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pieter van Prooijen writes: > Hi, > > Yes, your patch fixes the problem as well, and I don't see any > other=C2=A0side effects at a first glance. I've changed my patch to > incorporate it and revert the changes to ftcrfont_draw.=20 You don't have to incorporate that, I will install it now since it fixes another unrelated problem. Thanks. BTW, the non-breaking spaces are back again. From debbugs-submit-bounces@debbugs.gnu.org Fri May 13 07:38:32 2022 Received: (at 54564) by debbugs.gnu.org; 13 May 2022 11:38:32 +0000 Received: from localhost ([127.0.0.1]:43033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npTcp-00052T-2K for submit@debbugs.gnu.org; Fri, 13 May 2022 07:38:31 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:52187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npTcn-00052H-Md for 54564@debbugs.gnu.org; Fri, 13 May 2022 07:38:26 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 86E375C0174; Fri, 13 May 2022 07:38:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 13 May 2022 07:38:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=teloden.nl; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1652441899; x=1652528299; bh=+YfUBkv5de 6RftpjcsKj7McBlZ9+yaTnUvTBnWZAwSQ=; b=tcObS5JCQOnw1Jol9iG8WPY6q7 iLa1/cxMUBiRUhU9MStCxL5PDSDOml9Qts6zVBnCwlGol9HElhcum/LgEO7JhbCz mNzGU4abblOyFag0m2YmxtiCa3SvvrwhGVyDHnC2JTwfuRRW6W3jVflpzJL3M0BF BjAUEN7nqMM6a2j6QCWuWHDEuSUo63BuuKAq2fC3VF0V9fLe+Yb3UYrsb9vwsG6n GL3LMnf3gfg+CGAmxyA773G/kspRHsryhNZSObOx9Y5AlRf/UMSfM81qJpt0wHGb dJLb0REdm5DOsbJ5TC7KAK9k9wb4oqS1al+OVs16HtX2FpXPNgJkk3WB+Qgg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1652441899; x= 1652528299; bh=+YfUBkv5de6RftpjcsKj7McBlZ9+yaTnUvTBnWZAwSQ=; b=I oFxs+nzeACnxUPfsl93BdHVxdHXBOVW7dqHSCKgQBsvsK3tshlxcThPboDSfBXU6 518SiKNEL8eRtkaZzV2oMFQiW5qguTaT7mGLI7wqIuqe4vJ8UhE+F4sovbjww+w1 ko6xkaYNT+Ye4hAitiRcBSdIRmsB42hFMh/Noo+aGsw262kq69uSu65h9H0+apzp +5d1EYh6TtYRohAv5oi18t664KxgHVxNm/Ca7moCubGN13032Oc2WUXID/ssOT0s +dp1IkcwJmjMlrLlfCZwjW7fEN7EZCDuIMYAXGseAagqXjEX6cW+I1JRXGekTuY4 DfIL6gakyzKF+z8TDXPhA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgeelgdegudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepkffuhffvveffjghftggfggesmhdtre ertderjeenucfhrhhomheprfhivghtvghruchvrghnucfrrhhoohhijhgvnhcuoehpihgv thgvrhdrvhgrnhdrphhrohhoihhjvghnsehtvghlohguvghnrdhnlheqnecuggftrfgrth htvghrnhepudelvdffudegvdehueeftdfgfeejffdvhfehvdegffdtudevgfetvdduleek ffegnecuffhomhgrihhnpegtohhlrdhrvggupdgtohhlrdhgrhgvvghnpdgtohhlrdgslh huvgdpghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpehpihgvthgvrhdrvhgrnhdrphhrohhoihhjvghnsehtvghlohguvghnrd hnlh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 13 May 2022 07:38:17 -0400 (EDT) Message-ID: Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds From: Pieter van Prooijen To: Po Lu Date: Fri, 13 May 2022 13:38:16 +0200 In-Reply-To: <04ae2baf0a2a974bb411820c4d294b82d86ddc92.camel@teloden.nl> References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> <83czi9b5gh.fsf@gnu.org> <87v8w143h6.fsf@yahoo.com> <87o81s2osr.fsf@yahoo.com> <88d833f72df4f4cbb5769f1a75057d3f957a812c.camel@teloden.nl> <87bkxnx1co.fsf@yahoo.com> <211c08916190ef05cc1677956a77fca0c6122eda.camel@teloden.nl> <87k0c9imvp.fsf@yahoo.com> <66a9a7d83ca545dd23c890d4aa97717f1796579f.camel@teloden.nl> <8735ioxy5e.fsf@yahoo.com> <04ae2baf0a2a974bb411820c4d294b82d86ddc92.camel@teloden.nl> Content-Type: multipart/mixed; boundary="=-Za+PJlPruPa6JdchbnKe" User-Agent: Evolution 3.44.0-1ubuntu1 MIME-Version: 1.0 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54564 Cc: 54564@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-Za+PJlPruPa6JdchbnKe Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello All, The copyright assignment paperwork came through, is it possible to incorporate the gsetting font rendering changes? I've attached a patch against the current master, let me know if I need to change anything. Kind Regards, Pieter On Fri, 2022-04-08 at 20:44 +0200, Pieter van Prooijen wrote: > Hi, >=20 > Yes, your patch fixes the problem as well, and I don't see any > other=C2=A0side effects at a first glance. I've changed my patch to > incorporate it and revert the changes to ftcrfont_draw.=20 >=20 > Thanks, >=20 > Pieter >=20 >=20 > On Fri, 2022-04-08 at 07:38 +0800, Po Lu wrote: > > Pieter van Prooijen writes: > >=20 > > > Hi All,=C2=A0 > > >=20 > > > It took a fair bit of digging, but sub-pixel anti-aliasing on > > > pgtk > > > now > > > seems to work correctly. > > >=20 > > > The problem lies with the "source" operator set by pgtk when > > > drawing a > > > font, this will take a particular execution path in the cairo > > > glyph > > > compositor (using a mask image) which converts the colors created > > > by > > > freetype for the sub pixel effect to greys-cale. Using the > > > default > > > "over" operator takes a different path which preserves the > > > colors. > > > Note > > > that on small screens the difference between sub-pixel and grey- > > > scale > > > rendering is hard to see, it's more pronounced on larger > > > displays) > >=20 > > Ah thanks.=C2=A0 Does this fix the problem as well? > >=20 > > diff --git a/src/pgtkterm.c b/src/pgtkterm.c > > index b2816aa04a..5fbc56ae81 100644 > > --- a/src/pgtkterm.c > > +++ b/src/pgtkterm.c > > @@ -7037,8 +7037,11 @@ pgtk_set_cr_source_with_color (struct frame > > *f, unsigned long color, > > =C2=A0=C2=A0 pgtk_query_color (f, &col); > > =C2=A0 > > =C2=A0=C2=A0 if (!respects_alpha_background) > > -=C2=A0=C2=A0=C2=A0 cairo_set_source_rgb (FRAME_CR_CONTEXT (f), col.red= / 65535.0, > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= col.green / 65535.0, col.blue / 65535.0); > > +=C2=A0=C2=A0=C2=A0 { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 cairo_set_source_rgb (FRAME_CR_CONTEXT = (f), col.red / > > 65535.0, > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 col.green / 65535.0, col.blue / > > 65535.0); > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 cairo_set_operator (FRAME_CR_CONTEXT (f= ), > > CAIRO_OPERATOR_OVER); > > +=C2=A0=C2=A0=C2=A0 } > > =C2=A0=C2=A0 else > > =C2=A0=C2=A0=C2=A0=C2=A0 { > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 cairo_set_source_rgba (FRAME_CR_CO= NTEXT (f), col.red / > > 65535.0, > >=20 > > > I've also fixed the indent error, but couldn't find the non- > > > breaking > > > space in the patch, it's perhaps caused by the mail program. > >=20 > > It was previously filled with non-breaking spaces, but the patch > > you > > attached looks fine now. > >=20 > > > Regarding the copyright assignment, I've had no response after > > > sending > > > in the questionnaire at > > > https://git.savannah.gnu.org/cgit/gnulib.git/plain/doc/Copyright/ > > > re > > > quest-assign.future > > > to assign@gnu.org > >=20 > > It takes a while; if you don't get a response in 2 weeks, you > > should > > contact Eli or Lars, and they will ask the folks at the FSF to > > expedite > > things. > >=20 > > > Do you get sent a paper form of some kind which has to be filled > > > in? > > > (I'm not at my home address atm so I will have missed that) > >=20 > > You get sent a document you have to print and fill in, I think, but > > that > > depends on the country you're in. > >=20 > > Thanks. >=20 --=-Za+PJlPruPa6JdchbnKe Content-Disposition: attachment; filename*0=0001-Use-gsettings-font-rendering-entries-for-pgtk-builds.pat; filename*1=ch Content-Type: text/x-patch; name="0001-Use-gsettings-font-rendering-entries-for-pgtk-builds.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSA4NGQ0NDAxYTlhOWU2Mjg4MTVmYTMwMTQ3ZWUwOGQ0NTk3YWY1M2Q2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaWV0ZXIgdmFuIFByb29pamVuIDxwaWV0ZXIudmFuLnByb29p amVuQHRlbG9kZW4ubmw+CkRhdGU6IFN1biwgOCBNYXkgMjAyMiAxNjoyNzozOCArMDIwMApTdWJq ZWN0OiBbUEFUQ0hdIFVzZSBnc2V0dGluZ3MgZm9udCByZW5kZXJpbmcgZW50cmllcyBmb3IgcGd0 ayBidWlsZHMKCklmIHByZXNlbnQsIGFwcGx5IHRoZSBnc2V0dGluZ3MgZm9udCBoaW50aW5nIGFu ZCBhbnRpYWxpYXNpbmcKZW50cmllcyB3aGVuIGNyZWF0aW5nIGEgZm9udCBpbiBjYWlyby4gIERv IHRoaXMgYXQKaW5pdGlhbGl6YXRpb24gYW5kIHdoZW4gdGhlIGVudHJpZXMgY2hhbmdlLCByZS1y ZW5kZXJpbmcgdGhlCmZyYW1lcy4KCiogc3JjL2Z0Y3Jmb250LmMgKGZ0Y3Jmb250X29wZW4pOiBV c2UgdGhlIGZvbnRfb3B0aW9ucyBkZXJpdmVkCmZyb20gZ3NldHRpbmdzIHdoZW4gb3BlbmluZyBh IGZvbnQuCihmdGNyZm9udF9jYWNoZWRfZm9udF9vayk6IFJlcG9ydCBhIGNhY2hlZCBmb250IGFz IGludmFsaWQgaWYKaXRzIGZvbnQgb3B0aW9ucyBkaWZmZXIgZnJvbSB0aGUgY3VycmVudCBvcHRp b25zIGluc2lkZQpnc2V0dGluZ3MuCiogc3JjL3hzZXR0aW5ncy5jIChhcHBseV9nc2V0dGluZ3Nf Zm9udF9oaW50aW5nKQooYXBwbHlfZ3NldHRpbmdzX2ZvbnRfYWxpYXMsIGFwcGx5X2dzZXR0aW5n c19mb250X3JnYmFfb3JkZXIpOgpDb252ZXJ0IHRoZSBzZXR0aW5ncyBmcm9tIEdTZXR0aW5ncyB0 byB0aGUgY2Fpcm9fZm9udF9vcHRpb25zX3QKb2JqZWN0LgooaW5pdF9nc2V0dGluZ3MsIHNvbWV0 aGluZ19jaGFuZ2VkX2dzZXR0aW5nc0NCKTogSW52b2tlIHRoZQphcHBseSBmdW5jdGlvbnMgaWYg dGhlIHJlbGV2YW50IHNldHRpbmdzIGNoYW5nZWQuCihzdG9yZV9mb250X29wdGlvbnNfY2hhbmdl ZCk6IFN0b3JlIGFuIGV2ZW50IHRvIHJlLXJlbmRlciB0aGUKZm9udHMuCih4c2V0dGluZ19nZXRf Zm9udF9vcHRpb25zKQoqIHNyYy94c2V0dGluZ3MuaCAoeHNldHRpbmdzX2dldF9mb250X29wdGlv bnMpOiBOZXcgZnVuY3Rpb24uCi0tLQogc3JjL2Z0Y3Jmb250LmMgIHwgIDMzICsrKysrKysrKysr CiBzcmMveHNldHRpbmdzLmMgfCAxNDcgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrCiBzcmMveHNldHRpbmdzLmggfCAgIDUgKysKIDMgZmlsZXMgY2hhbmdl ZCwgMTg1IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9zcmMvZnRjcmZvbnQuYyBiL3NyYy9m dGNyZm9udC5jCmluZGV4IDk4YTI4YWY1ZjIuLjZiYjQxMTEwZDUgMTAwNjQ0Ci0tLSBhL3NyYy9m dGNyZm9udC5jCisrKyBiL3NyYy9mdGNyZm9udC5jCkBAIC0zNyw2ICszNyw5IEBACiAjaW5jbHVk ZSAiZm9udC5oIgogI2luY2x1ZGUgImZ0Zm9udC5oIgogI2luY2x1ZGUgInBkdW1wZXIuaCIKKyNp ZmRlZiBIQVZFX1BHVEsKKyNpbmNsdWRlICJ4c2V0dGluZ3MuaCIKKyNlbmRpZgogCiAjaWZkZWYg VVNFX0JFX0NBSVJPCiAjZGVmaW5lIFJFRF9GUk9NX1VMT05HKGNvbG9yKQkoKChjb2xvcikgPj4g MTYpICYgMHhmZikKQEAgLTE2OCw3ICsxNzEsMTIgQEAgZnRjcmZvbnRfb3BlbiAoc3RydWN0IGZy YW1lICpmLCBMaXNwX09iamVjdCBlbnRpdHksIGludCBwaXhlbF9zaXplKQogICBjYWlyb19tYXRy aXhfdCBmb250X21hdHJpeCwgY3RtOwogICBjYWlyb19tYXRyaXhfaW5pdF9zY2FsZSAoJmZvbnRf bWF0cml4LCBwaXhlbF9zaXplLCBwaXhlbF9zaXplKTsKICAgY2Fpcm9fbWF0cml4X2luaXRfaWRl bnRpdHkgKCZjdG0pOworCisjaWZkZWYgSEFWRV9QR1RLCisgIGNhaXJvX2ZvbnRfb3B0aW9uc190 ICpvcHRpb25zID0geHNldHRpbmdzX2dldF9mb250X29wdGlvbnMgKCk7CisjZWxzZQogICBjYWly b19mb250X29wdGlvbnNfdCAqb3B0aW9ucyA9IGNhaXJvX2ZvbnRfb3B0aW9uc19jcmVhdGUgKCk7 CisjZW5kaWYKICNpZmRlZiBVU0VfQkVfQ0FJUk8KICAgaWYgKGJlX3VzZV9zdWJwaXhlbF9hbnRp YWxpYXNpbmcgKCkpCiAgICAgY2Fpcm9fZm9udF9vcHRpb25zX3NldF9hbnRpYWxpYXMgKG9wdGlv bnMsIENBSVJPX0FOVElBTElBU19TVUJQSVhFTCk7CkBAIC02MjQsNiArNjMyLDI4IEBAIGZ0Y3Jm b250X2RyYXcgKHN0cnVjdCBnbHlwaF9zdHJpbmcgKnMsCiAgIHJldHVybiBsZW47CiB9CiAKKyNp ZmRlZiBIQVZFX1BHVEsKKy8qIERldGVybWluZSBpZiBGT05UX09CSkVDVCBpcyBhIHZhbGlkIGNh Y2hlZCBmb250IGZvciBFTlRJVFkgYnkKKyAgIGNvbXBhcmluZyB0aGUgb3B0aW9ucyB1c2VkIHRv IG9wZW4gaXQgd2l0aCB0aGUgdXNlcidzIGN1cnJlbnQKKyAgIHByZWZlcmVuY2VzIHNwZWNpZmll ZCB2aWEgR1NldHRpbmdzLiAgKi8KK3N0YXRpYyBib29sCitmdGNyZm9udF9jYWNoZWRfZm9udF9v ayAoc3RydWN0IGZyYW1lICpmLCBMaXNwX09iamVjdCBmb250X29iamVjdCwKKwkJCSBMaXNwX09i amVjdCBlbnRpdHkpCit7CisgIHN0cnVjdCBmb250X2luZm8gKmluZm8gPSAoc3RydWN0IGZvbnRf aW5mbyAqKSBYRk9OVF9PQkpFQ1QgKGZvbnRfb2JqZWN0KTsKKworICBjYWlyb19mb250X29wdGlv bnNfdCAqb3B0aW9ucyA9IGNhaXJvX2ZvbnRfb3B0aW9uc19jcmVhdGUgKCk7CisgIGNhaXJvX3Nj YWxlZF9mb250X2dldF9mb250X29wdGlvbnMgKGluZm8tPmNyX3NjYWxlZF9mb250LCBvcHRpb25z KTsKKyAgY2Fpcm9fZm9udF9vcHRpb25zX3QgKmdzZXR0aW5nc19vcHRpb25zID0geHNldHRpbmdz X2dldF9mb250X29wdGlvbnMgKCk7CisKKyAgYm9vbCBlcXVhbCA9IGNhaXJvX2ZvbnRfb3B0aW9u c19lcXVhbCAob3B0aW9ucywgZ3NldHRpbmdzX29wdGlvbnMpOworICBjYWlyb19mb250X29wdGlv bnNfZGVzdHJveSAob3B0aW9ucyk7CisgIGNhaXJvX2ZvbnRfb3B0aW9uc19kZXN0cm95IChnc2V0 dGluZ3Nfb3B0aW9ucyk7CisKKyAgcmV0dXJuIGVxdWFsOworfQorI2VuZGlmCisKICNpZmRlZiBI QVZFX0hBUkZCVVpaCiAKIHN0YXRpYyBMaXNwX09iamVjdApAQCAtNjk0LDYgKzcyNCw5IEBAIGZ0 Y3JoYmZvbnRfZW5kX2hiX2ZvbnQgKHN0cnVjdCBmb250ICpmb250LCBoYl9mb250X3QgKmhiX2Zv bnQpCiAjZW5kaWYKICAgLmZpbHRlcl9wcm9wZXJ0aWVzID0gZnRmb250X2ZpbHRlcl9wcm9wZXJ0 aWVzLAogICAuY29tYmluaW5nX2NhcGFiaWxpdHkgPSBmdGZvbnRfY29tYmluaW5nX2NhcGFiaWxp dHksCisjaWZkZWYgSEFWRV9QR1RLCisgIC5jYWNoZWRfZm9udF9vayA9IGZ0Y3Jmb250X2NhY2hl ZF9mb250X29rCisjZW5kaWYKICAgfTsKICNpZmRlZiBIQVZFX0hBUkZCVVpaCiBzdHJ1Y3QgZm9u dF9kcml2ZXIgZnRjcmhiZm9udF9kcml2ZXI7CmRpZmYgLS1naXQgYS9zcmMveHNldHRpbmdzLmMg Yi9zcmMveHNldHRpbmdzLmMKaW5kZXggNzFkMDJlNjE1Mi4uZTcxODg3ZTAzZCAxMDA2NDQKLS0t IGEvc3JjL3hzZXR0aW5ncy5jCisrKyBiL3NyYy94c2V0dGluZ3MuYwpAQCAtMjE1LDExICsyMTUs MTE2IEBAICNkZWZpbmUgR1NFVFRJTkdTX01PTk9fRk9OVCAgIm1vbm9zcGFjZS1mb250LW5hbWUi CiAjZGVmaW5lIEdTRVRUSU5HU19GT05UX05BTUUgICJmb250LW5hbWUiCiAjZW5kaWYKIAorI2lm ZGVmIEhBVkVfUEdUSworI2RlZmluZSBHU0VUVElOR1NfRk9OVF9BTlRJQUxJQVNJTkcgICJmb250 LWFudGlhbGlhc2luZyIKKyNkZWZpbmUgR1NFVFRJTkdTX0ZPTlRfUkdCQV9PUkRFUiAgICAiZm9u dC1yZ2JhLW9yZGVyIgorI2RlZmluZSBHU0VUVElOR1NfRk9OVF9ISU5USU5HICAgICAgICJmb250 LWhpbnRpbmciCisjZW5kaWYKIAogLyogVGhlIHNpbmdsZSBHU2V0dGluZ3MgaW5zdGFuY2UsIG9y IE5VTEwgaWYgbm90IGNvbm5lY3RlZCB0byBHU2V0dGluZ3MuICAqLwogCiBzdGF0aWMgR1NldHRp bmdzICpnc2V0dGluZ3NfY2xpZW50OwogCisjaWZkZWYgSEFWRV9QR1RLCisKKy8qIFRoZSBjYWly byBmb250X29wdGlvbnMgYXMgb2J0YWluZWQgdXNpbmcgZ3NldHRpbmdzLiAgKi8KK3N0YXRpYyBj YWlyb19mb250X29wdGlvbnNfdCAqZm9udF9vcHRpb25zOworCisvKiBTdG9yZSBhbiBldmVudCBm b3IgcmUtcmVuZGVyaW5nIG9mIHRoZSBmb250cy4gICovCitzdGF0aWMgdm9pZAorc3RvcmVfZm9u dF9vcHRpb25zX2NoYW5nZWQgKHZvaWQpCit7CisgIGlmIChkcHlpbmZvX3ZhbGlkIChmaXJzdF9k cHlpbmZvKSkKKyAgICBzdG9yZV9jb25maWdfY2hhbmdlZF9ldmVudCAoUWZvbnRfcmVuZGVyLAor CQkJCVhDQVIgKGZpcnN0X2RweWluZm8tPm5hbWVfbGlzdF9lbGVtZW50KSk7Cit9CisKKy8qIEFw cGx5IGNoYW5nZXMgaW4gdGhlIGhpbnRpbmcgc3lzdGVtIHNldHRpbmcuICAqLworc3RhdGljIHZv aWQKK2FwcGx5X2dzZXR0aW5nc19mb250X2hpbnRpbmcgKEdTZXR0aW5ncyAqc2V0dGluZ3MpCit7 CisgIEdWYXJpYW50ICp2YWwgPSBnX3NldHRpbmdzX2dldF92YWx1ZSAoc2V0dGluZ3MsIEdTRVRU SU5HU19GT05UX0hJTlRJTkcpOworICBpZiAodmFsKQorICAgIHsKKyAgICAgIGdfdmFyaWFudF9y ZWZfc2luayAodmFsKTsKKyAgICAgIGlmIChnX3ZhcmlhbnRfaXNfb2ZfdHlwZSAodmFsLCBHX1ZB UklBTlRfVFlQRV9TVFJJTkcpKQorCXsKKwkgIGNvbnN0IGNoYXIgKmhpbnRpbmcgPSBnX3Zhcmlh bnRfZ2V0X3N0cmluZyAodmFsLCBOVUxMKTsKKworCSAgaWYgKCFzdHJjbXAgKGhpbnRpbmcsICJm dWxsIikpCisJICAgIGNhaXJvX2ZvbnRfb3B0aW9uc19zZXRfaGludF9zdHlsZSAoZm9udF9vcHRp b25zLAorCQkJCQkgICAgICAgQ0FJUk9fSElOVF9TVFlMRV9GVUxMKTsKKwkgIGVsc2UgaWYgKCFz dHJjbXAgKGhpbnRpbmcsICJtZWRpdW0iKSkKKwkgICAgY2Fpcm9fZm9udF9vcHRpb25zX3NldF9o aW50X3N0eWxlIChmb250X29wdGlvbnMsCisJCQkJCSAgICAgICBDQUlST19ISU5UX1NUWUxFX01F RElVTSk7CisJICBlbHNlIGlmICghc3RyY21wIChoaW50aW5nLCAic2xpZ2h0IikpCisJICAgIGNh aXJvX2ZvbnRfb3B0aW9uc19zZXRfaGludF9zdHlsZSAoZm9udF9vcHRpb25zLAorCQkJCQkgICAg ICAgQ0FJUk9fSElOVF9TVFlMRV9TTElHSFQpOworCSAgZWxzZSBpZiAoIXN0cmNtcCAoaGludGlu ZywgIm5vbmUiKSkKKwkgICAgY2Fpcm9fZm9udF9vcHRpb25zX3NldF9oaW50X3N0eWxlIChmb250 X29wdGlvbnMsCisJCQkJCSAgICAgICBDQUlST19ISU5UX1NUWUxFX05PTkUpOworCX0KKyAgICAg IGdfdmFyaWFudF91bnJlZiAodmFsKTsKKyAgICB9Cit9CisKKy8qIEFwcGx5IGNoYW5nZXMgaW4g dGhlIGFudGlhbGlhc2luZyBzeXN0ZW0gc2V0dGluZy4gICovCitzdGF0aWMgdm9pZAorYXBwbHlf Z3NldHRpbmdzX2ZvbnRfYW50aWFsaWFzIChHU2V0dGluZ3MgKnNldHRpbmdzKQoreworICBHVmFy aWFudCAqdmFsID0gZ19zZXR0aW5nc19nZXRfdmFsdWUgKHNldHRpbmdzLCBHU0VUVElOR1NfRk9O VF9BTlRJQUxJQVNJTkcpOworICBpZiAodmFsKQorICAgIHsKKyAgICAgIGdfdmFyaWFudF9yZWZf c2luayAodmFsKTsKKyAgICAgIGlmIChnX3ZhcmlhbnRfaXNfb2ZfdHlwZSAodmFsLCBHX1ZBUklB TlRfVFlQRV9TVFJJTkcpKQorCXsKKwkgIGNvbnN0IGNoYXIgKmFudGlhbGlhcyA9IGdfdmFyaWFu dF9nZXRfc3RyaW5nICh2YWwsIE5VTEwpOworCisJICBpZiAoIXN0cmNtcCAoYW50aWFsaWFzLCAi bm9uZSIpKQorCSAgICBjYWlyb19mb250X29wdGlvbnNfc2V0X2FudGlhbGlhcyAoZm9udF9vcHRp b25zLAorCQkJCQkgICAgICBDQUlST19BTlRJQUxJQVNfTk9ORSk7CisJICBlbHNlIGlmICghc3Ry Y21wIChhbnRpYWxpYXMsICJncmF5c2NhbGUiKSkKKwkgICAgY2Fpcm9fZm9udF9vcHRpb25zX3Nl dF9hbnRpYWxpYXMgKGZvbnRfb3B0aW9ucywKKwkJCQkJICAgICAgQ0FJUk9fQU5USUFMSUFTX0dS QVkpOworCSAgZWxzZSBpZiAoIXN0cmNtcCAoYW50aWFsaWFzLCAicmdiYSIpKQorCSAgICBjYWly b19mb250X29wdGlvbnNfc2V0X2FudGlhbGlhcyAoZm9udF9vcHRpb25zLAorCQkJCQkgICAgICBD QUlST19BTlRJQUxJQVNfU1VCUElYRUwpOworCX0KKyAgICAgIGdfdmFyaWFudF91bnJlZiAodmFs KTsKKyAgICB9Cit9CisKKy8qIEFwcGx5IHRoZSBzZXR0aW5ncyBmb3IgdGhlIHJnYiBlbGVtZW50 IG9yZGVyaW5nLiAgKi8KK3N0YXRpYyB2b2lkCithcHBseV9nc2V0dGluZ3NfZm9udF9yZ2JhX29y ZGVyIChHU2V0dGluZ3MgKnNldHRpbmdzKQoreworICBHVmFyaWFudCAqdmFsID0gZ19zZXR0aW5n c19nZXRfdmFsdWUgKHNldHRpbmdzLAorCQkJCQlHU0VUVElOR1NfRk9OVF9SR0JBX09SREVSKTsK KyAgaWYgKHZhbCkKKyAgICB7CisgICAgICBnX3ZhcmlhbnRfcmVmX3NpbmsgKHZhbCk7CisgICAg ICBpZiAoZ192YXJpYW50X2lzX29mX3R5cGUgKHZhbCwgR19WQVJJQU5UX1RZUEVfU1RSSU5HKSkK Kwl7CisJICBjb25zdCBjaGFyICpyZ2JhX29yZGVyID0gZ192YXJpYW50X2dldF9zdHJpbmcgKHZh bCwgTlVMTCk7CisKKwkgIGlmICghc3RyY21wIChyZ2JhX29yZGVyLCAicmdiIikpCisJICAgIGNh aXJvX2ZvbnRfb3B0aW9uc19zZXRfc3VicGl4ZWxfb3JkZXIgKGZvbnRfb3B0aW9ucywKKwkJCQkJ CSAgIENBSVJPX1NVQlBJWEVMX09SREVSX1JHQik7CisJICBlbHNlIGlmICghc3RyY21wIChyZ2Jh X29yZGVyLCAiYmdyIikpCisJICAgIGNhaXJvX2ZvbnRfb3B0aW9uc19zZXRfc3VicGl4ZWxfb3Jk ZXIgKGZvbnRfb3B0aW9ucywKKwkJCQkJCSAgIENBSVJPX1NVQlBJWEVMX09SREVSX0JHUik7CisJ ICBlbHNlIGlmICghc3RyY21wIChyZ2JhX29yZGVyLCAidnJnYiIpKQorCSAgICBjYWlyb19mb250 X29wdGlvbnNfc2V0X3N1YnBpeGVsX29yZGVyIChmb250X29wdGlvbnMsCisJCQkJCQkgICBDQUlS T19TVUJQSVhFTF9PUkRFUl9WUkdCKTsKKwkgIGVsc2UgaWYgKCFzdHJjbXAgKHJnYmFfb3JkZXIs ICJ2YmdyIikpCisJICAgIGNhaXJvX2ZvbnRfb3B0aW9uc19zZXRfc3VicGl4ZWxfb3JkZXIgKGZv bnRfb3B0aW9ucywKKwkJCQkJCSAgIENBSVJPX1NVQlBJWEVMX09SREVSX1ZCR1IpOworCX0KKyAg ICAgIGdfdmFyaWFudF91bnJlZiAodmFsKTsKKyAgICB9Cit9CisjZW5kaWYgLyogSEFWRV9QR1RL ICovCisKIC8qIENhbGxiYWNrIGNhbGxlZCB3aGVuIHNvbWV0aGluZyBjaGFuZ2VkIGluIEdTZXR0 aW5ncy4gICovCiAKIHN0YXRpYyB2b2lkCkBAIC0yNzMsNiArMzc4LDIzIEBAIHNvbWV0aGluZ19j aGFuZ2VkX2dzZXR0aW5nc0NCIChHU2V0dGluZ3MgKnNldHRpbmdzLAogICAgICAgICB9CiAgICAg fQogI2VuZGlmIC8qIFVTRV9DQUlSTyB8fCBIQVZFX1hGVCAqLworI2lmZGVmIEhBVkVfUEdUSwor ICBlbHNlIGlmICghc3RyY21wIChrZXksIEdTRVRUSU5HU19GT05UX0FOVElBTElBU0lORykpCisg ICAgeworICAgICAgYXBwbHlfZ3NldHRpbmdzX2ZvbnRfYW50aWFsaWFzIChzZXR0aW5ncyk7Cisg ICAgICBzdG9yZV9mb250X29wdGlvbnNfY2hhbmdlZCAoKTsKKyAgICB9CisgIGVsc2UgaWYgKCFz dHJjbXAgKGtleSwgR1NFVFRJTkdTX0ZPTlRfSElOVElORykpCisgICAgeworICAgICAgYXBwbHlf Z3NldHRpbmdzX2ZvbnRfaGludGluZyAoc2V0dGluZ3MpOworICAgICAgc3RvcmVfZm9udF9vcHRp b25zX2NoYW5nZWQgKCk7CisgICAgfQorICBlbHNlIGlmICghc3RyY21wIChrZXksIEdTRVRUSU5H U19GT05UX1JHQkFfT1JERVIpKQorICAgIHsKKyAgICAgIGFwcGx5X2dzZXR0aW5nc19mb250X3Jn YmFfb3JkZXIgKHNldHRpbmdzKTsKKyAgICAgIHN0b3JlX2ZvbnRfb3B0aW9uc19jaGFuZ2VkICgp OworICAgIH0KKyNlbmRpZiAvKiBIQVZFX1BHVEsgKi8KIH0KIAogI2VuZGlmIC8qIEhBVkVfR1NF VFRJTkdTICovCkBAIC05MDAsNiArMTAyMiwxNiBAQCBpbml0X2dzZXR0aW5ncyAodm9pZCkKICAg ICAgICAgZHVwc3RyaW5nICgmY3VycmVudF9mb250LCBnX3ZhcmlhbnRfZ2V0X3N0cmluZyAodmFs LCBOVUxMKSk7CiAgICAgICBnX3ZhcmlhbnRfdW5yZWYgKHZhbCk7CiAgICAgfQorCisgIC8qIE9u bHkgdXNlIHRoZSBnc2V0dGluZ3MgZm9udCBlbnRyaWVzIGZvciB0aGUgQ2Fpcm8gYmFja2VuZAor ICAgICBydW5uaW5nIG9uIFBHVEsuICAqLworI2lmZGVmIEhBVkVfUEdUSworICBmb250X29wdGlv bnMgPSBjYWlyb19mb250X29wdGlvbnNfY3JlYXRlICgpOworICBhcHBseV9nc2V0dGluZ3NfZm9u dF9hbnRpYWxpYXMgKGdzZXR0aW5nc19jbGllbnQpOworICBhcHBseV9nc2V0dGluZ3NfZm9udF9o aW50aW5nIChnc2V0dGluZ3NfY2xpZW50KTsKKyAgYXBwbHlfZ3NldHRpbmdzX2ZvbnRfcmdiYV9v cmRlciAoZ3NldHRpbmdzX2NsaWVudCk7CisjZW5kaWYgLyogSEFWRV9QR1RLICovCisKICNlbmRp ZiAvKiBVU0VfQ0FJUk8gfHwgSEFWRV9YRlQgKi8KIAogI2VuZGlmIC8qIEhBVkVfR1NFVFRJTkdT ICovCkBAIC0xMDIxLDYgKzExNTMsMTcgQEAgeHNldHRpbmdzX2dldF9zeXN0ZW1fbm9ybWFsX2Zv bnQgKHZvaWQpCiB9CiAjZW5kaWYKIAorI2lmZGVmIEhBVkVfUEdUSworLyogUmV0dXJuIHRoZSBj YWlybyBmb250IG9wdGlvbnMsIHVwZGF0ZWQgZnJvbSB0aGUgZ3NldHRpbmdzIGZvbnQKKyAgIGNv bmZpZyBlbnRyaWVzLiAgVGhlIGNhbGxlciBzaG91bGQgY2FsbCBjYWlyb19mb250X29wdGlvbnNf ZGVzdHJveQorICAgb24gdGhlIHJlc3VsdC4gICovCitjYWlyb19mb250X29wdGlvbnNfdCAqCit4 c2V0dGluZ3NfZ2V0X2ZvbnRfb3B0aW9ucyAodm9pZCkKK3sKKyAgcmV0dXJuIGNhaXJvX2ZvbnRf b3B0aW9uc19jb3B5IChmb250X29wdGlvbnMpOworfQorI2VuZGlmCisKIERFRlVOICgiZm9udC1n ZXQtc3lzdGVtLW5vcm1hbC1mb250IiwgRmZvbnRfZ2V0X3N5c3RlbV9ub3JtYWxfZm9udCwKICAg ICAgICBTZm9udF9nZXRfc3lzdGVtX25vcm1hbF9mb250LAogICAgICAgIDAsIDAsIDAsCkBAIC0x MDczLDYgKzEyMTYsMTAgQEAgc3ltc19vZl94c2V0dGluZ3MgKHZvaWQpCiAgIGdjb25mX2NsaWVu dCA9IE5VTEw7CiAgIFBEVU1QRVJfSUdOT1JFIChnY29uZl9jbGllbnQpOwogI2VuZGlmCisjaWZk ZWYgSEFWRV9QR1RLCisgIGZvbnRfb3B0aW9ucyA9IE5VTEw7CisgIFBEVU1QRVJfSUdOT1JFIChm b250X29wdGlvbnMpOworI2VuZGlmCiAKICAgREVGU1lNIChRbW9ub3NwYWNlX2ZvbnRfbmFtZSwg Im1vbm9zcGFjZS1mb250LW5hbWUiKTsKICAgREVGU1lNIChRZm9udF9uYW1lLCAiZm9udC1uYW1l Iik7CmRpZmYgLS1naXQgYS9zcmMveHNldHRpbmdzLmggYi9zcmMveHNldHRpbmdzLmgKaW5kZXgg Y2NhYTM2NDg5ZC4uNWU1ZGYzNzA2MiAxMDA2NDQKLS0tIGEvc3JjL3hzZXR0aW5ncy5oCisrKyBi L3NyYy94c2V0dGluZ3MuaApAQCAtMjMsNiArMjMsOCBAQCAjZGVmaW5lIFhTRVRUSU5HU19ICiAj aWZuZGVmIEhBVkVfUEdUSwogI2luY2x1ZGUgImRpc3BleHRlcm4uaCIKICNpbmNsdWRlIDxYMTEv WGxpYi5oPgorI2Vsc2UKKyNpbmNsdWRlIDxjYWlyby5oPgogI2VuZGlmCiAKIHN0cnVjdCB4X2Rp c3BsYXlfaW5mbzsKQEAgLTQxLDUgKzQzLDggQEAgI2RlZmluZSBYU0VUVElOR1NfSAogZXh0ZXJu IGNvbnN0IGNoYXIgKnhzZXR0aW5nc19nZXRfc3lzdGVtX25vcm1hbF9mb250ICh2b2lkKTsKICNl bmRpZgogCisjaWZkZWYgSEFWRV9QR1RLCitleHRlcm4gY2Fpcm9fZm9udF9vcHRpb25zX3QgKnhz ZXR0aW5nc19nZXRfZm9udF9vcHRpb25zICh2b2lkKTsKKyNlbmRpZgogCiAjZW5kaWYgLyogWFNF VFRJTkdTX0ggKi8KLS0gCjIuMzQuMQoK --=-Za+PJlPruPa6JdchbnKe-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 13 07:55:29 2022 Received: (at 54564) by debbugs.gnu.org; 13 May 2022 11:55:29 +0000 Received: from localhost ([127.0.0.1]:43049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npTtJ-0005bS-21 for submit@debbugs.gnu.org; Fri, 13 May 2022 07:55:29 -0400 Received: from sonic303-21.consmr.mail.ne1.yahoo.com ([66.163.188.147]:46640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npTtD-0005b9-Lh for 54564@debbugs.gnu.org; Fri, 13 May 2022 07:55:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1652442918; bh=UWM+tfh10J78UaefsHhOyyeZmDX9NQShfoJDtGwyhnw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=MbLk5h9+c4q7Rn0o6DRdtOt2YPhjtP4YEhZqmXPXubisGJQuHuQX0C5JYdzySfWNnc3GJ1E7m/XpfRoDQWxGOvN0/TAGakCw84x+7BGzkxJzgxU0MAemLseSpA/i1DKcCeNuJb/G6Ba982YYwiz8Lk0+A81b7sMSCFSgwReQ3ZqdkWw1nJVWlJ9KtB3a/PrakCoFPq2MBelGuc0sCBeC0J8pgKWak389m3BWwC2wC6qK4dw2now/zDb2d1XNYxuByndnOFoVxUkw8W/JivyR5DvZaLATLCp1kWRL0vFUUqvaACDswNi7cy6yLR0R8ZQAJ9yW6zleqyTtYYoaFxXO2w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1652442918; bh=T0YvDxtypCNYteOOXPc2PhSmgQ3c9NeZWo3nyOGK6FL=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Iet5yA0O0bXj0n1yTLznKSicxeCoAWAa6w7DxK7pSCXt52vSf2kiTbNOe0v++QGteLfsb8+ej5+L85Kf7gRr/CkZpflCG4VVBf844hS7Wmrhzee5DV9Y7n9uc+PrgX/IvPQX5e0yR95wF1bVAGuRs3DGZ5yD0DAoHRAbhxt3V5br5sUgy2zNT9a+GDeGr2jfuNsNMSLu3bY50j3LpzULD7BY0y5gbKvScSs0nOgwAqpJa/pf+yCQEilTkImAMQSFzfhwKnMZ4qutmnf6W7Gty7dgVefjsgM+azUSU75LJN4V+3JpowoDbAbcAYAJ9T3A1CRtN5PO+t15BfQPw3h/JQ== X-YMail-OSG: aDxwToEVM1l9alA.990YnRVu8u7gGqz_QcgEvyezuoRRjvdlMsEvQefLm5DxfvI 49DVsSzyPONyKve_9qBT8mkazyC8pBVDaQE2Ckesyg3JF4pxYnmGOWCvKeXMbzGv5hiLCAZnrNFJ u_1A1sw7zqXsdjdBv9CFFOp_QTv3igLyKronvyEoPSst9qJyyrhl4f5ZSjvMuFd0N2qaEg.L7Wol eJ.g3K0o_Fu.f34OEjhsTGuAqvtJR68QtTny5HXcENbGYhNVTJ6jkIRUWtCc.FInUC3RuJ8XlLzI 3LdR7uh04MjhxFIKY394kOghSDf24NdS..XZx7Z6WRN8u5IIDJZo0YGuFncOtMoMhjjT8JnQHz4R 8zpkPD4RGb1F1pRB5_yXdtsWlkUUGg0mf3qiDwx3TuA.U3fZC_ssZJH.hZPYfxEUdQa5DhzwxtFN LVOdMH0eFcG4nMtJhu8xcqwzpuBgrQtsuvgZMoGWL1bfrGG6d4My64TFpE15eEEuoVdzLpFl4eDX 6yiLHrh1pmxLdNm3HuONs.1Pu8bz9zKiAFPMMkKdNlwU0BNnYuTtn7i8cfSmIDNGMC_bSl.bOuya PlKfr8a2T2.2Md8e7JcIqt63ITG2R5rIMV2m2DHGd9bF332zI4AABbFzxgapp9Ja9aVWGXZxc7lc mWB1ETQ4CVqs.HbOY1qVzw40k1PmcaU9sA7lH6rNQTslXhmdBuyHEuzfWJDXw837q4uYkWWSa5j0 gWlT7xnVKbGUhBEqSXH_8R4ZCmk1ftarjRu1ea6J.EqGT0AcN4k._v3MVU6g_la7ztLXdHFKHDy1 lCNnz5An_FIbYGoLAA3eSCKtsjcG6hrln0b8ImPYvjRkMLw7Kc2uwjhjmvxTnnfcHaDoiwcfOML4 rDSmTiJM2EMHN_Cevzhpx15OUr8bi1Z066mSt8NBW3.3Nk_SOVKThYnzlvhIKHt5lDGFUx1vvlXy TxAKZBtN2n5iPOWvwqrOAsmVs3VzhVFNu3.jQDsIELARArJH9JEhvPYieH1meaI03aY4oU.cwKg7 1Y3bSvBlr4zWVm9TPp6b.AZwebZ2uh6QLXzJEYqKemiwlFltLVRYY.3VTDozdkByrVP1M7v7jFBW 71GddbopG6fQihRFEK9x8996yIgHiEMAJLhzPKtg4V3GSHlIuOQ64iHW8yDdVfFv2OBnXM6TzwxO QxVQ2O8nqgli0f4gz3cumql3Pg2JJB.rdF_cicJKUyiYkxB6lTbp_OdGdR6mnLpPFIesjiBxNJZh mj4eufp3LmX8FjwQfN7VnYCmmYUb4pQwXzpjVqdv_s_rkGB77mYspqbd_gRqxfP.oWL1YkJkdl2K MzddyjdGVQBz3TbQo4WbPHHr7SnjmmSKTdAK3cazYT3b7onJTJy78y8WQdndOhyT_Befjw.AVxgj 6ADisnC6QmLvnViPPPwtwYGwStprAX_xhwjqZBLw_BbkxPCYAZVMsKuhWIzUczo6eukH2Ct0u5bK _Gbz7mA80Jae8dZfASA8wFhWqXFBxxfZKaCg9wvKr.1TRMhMQUVGBZ_j695ye407a1hmWzXgqT4o zpzK5PTwWKd.dw7SFVsU3EHF6HmvAOY8NwC6q_w200T2vzNBl77KiaWVPqwp0uv7xLSvZ_CvTWKx b5Dund08c4vjNlm_AeSZ1Zxpi6dMmx9ASJo9wRiMypdym8eMz4ePr9_32U7C1VM2PVZToSqpdDlv 6aWEJTJtatFtx22bODQ3zA8qpsauIfdyZl.zJo5DrLCudyuwMgMrI5tpEwYAV8uKQ4HLvBlV1nEh .y1onhHhOe0WOz65O7d4ISkOwVGoSMCA8htXi5FVyernNgp77ZBu_7NqyOWKAdVTS5jkxXyr48Fu 8aQvPILe4KO.g.VM6cM8E6.INPxt8Nfkandem_bWCQzH8HoBBuWKp4ByQz_Nkec3EQdEdl8CXeX6 BUXp6C6BYGBnHl7grcJ4uEBTIiVA3Mp6FAvXwcqHK1507MymgbKe5TjIi1p2TxGrJfMHjaqykWf3 .3kLUXnRpqBWh.8..6Xxxu3ec79Ovhj38.3JopqdCp2uDFW0cn5nONbpcOlq2MfalbEZu3ltEA48 _N3WOMyQm25wi.lZVRAGO6KeDxOyOCEpwcZyLMrHlxTqNh7_yQVUojEpztevKgU28zM1Dy5XuKxr STe09N5J938cPV5irtF5HVkyzaT_r87lCUWxeOBEhAulLkbjPzqzoIxTccDwb0A4_rWcpyV3AycL p9KjIUwPAn3_LNBNup21auDpRHZK3o.in396wcVkVg0gjkY_Ur9zxEJG_T5HlRw-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ne1.yahoo.com with HTTP; Fri, 13 May 2022 11:55:18 +0000 Received: by hermes--canary-production-sg3-856bf69955-lwmfc (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 09f1bbcbd95743ac73614cfd892f1b38; Fri, 13 May 2022 11:55:12 +0000 (UTC) From: Po Lu To: Pieter van Prooijen Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> <83czi9b5gh.fsf@gnu.org> <87v8w143h6.fsf@yahoo.com> <87o81s2osr.fsf@yahoo.com> <88d833f72df4f4cbb5769f1a75057d3f957a812c.camel@teloden.nl> <87bkxnx1co.fsf@yahoo.com> <211c08916190ef05cc1677956a77fca0c6122eda.camel@teloden.nl> <87k0c9imvp.fsf@yahoo.com> <66a9a7d83ca545dd23c890d4aa97717f1796579f.camel@teloden.nl> <8735ioxy5e.fsf@yahoo.com> <04ae2baf0a2a974bb411820c4d294b82d86ddc92.camel@teloden.nl> Date: Fri, 13 May 2022 19:55:05 +0800 In-Reply-To: (Pieter van Prooijen's message of "Fri, 13 May 2022 13:38:16 +0200") Message-ID: <87czghve92.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20188 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 432 X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: 54564 Cc: Lars Ingebrigtsen , Eli Zaretskii , 54564@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pieter van Prooijen writes: > Hello All, > > The copyright assignment paperwork came through, is it possible to > incorporate the gsetting font rendering changes? I've attached a patch > against the current master, let me know if I need to change anything. Great, thanks! Once Eli or Lars say your copyright paperwork is in order, I will install your change. Again, thanks for working on Emacs. From debbugs-submit-bounces@debbugs.gnu.org Fri May 13 07:58:03 2022 Received: (at 54564) by debbugs.gnu.org; 13 May 2022 11:58:03 +0000 Received: from localhost ([127.0.0.1]:43053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npTvY-0005fo-Fo for submit@debbugs.gnu.org; Fri, 13 May 2022 07:58:03 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npTvW-0005fV-Gj for 54564@debbugs.gnu.org; Fri, 13 May 2022 07:57:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oOt/zNDLo3rnLW/cf2eu58lGz5n6OMtoo+1QTpTF2mU=; b=ReCVLdXfiiAJInmNAm1LsXoX1u pExOUsnkQ3lBmc4ybT/n31Yakyakjpa6Q0gUOf0gD3nP/R3eoGVnr65Qay9aXUxWaejPgV9pD03jU 1Kn8w85SRVl5GQzsimYLG1sT68sFztIpz5gtnAoIcF18bcxwtQoMJtw0/7r+Jqx8fPDk=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1npTvM-00009Y-0d; Fri, 13 May 2022 13:57:38 +0200 From: Lars Ingebrigtsen To: Po Lu Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> <83czi9b5gh.fsf@gnu.org> <87v8w143h6.fsf@yahoo.com> <87o81s2osr.fsf@yahoo.com> <88d833f72df4f4cbb5769f1a75057d3f957a812c.camel@teloden.nl> <87bkxnx1co.fsf@yahoo.com> <211c08916190ef05cc1677956a77fca0c6122eda.camel@teloden.nl> <87k0c9imvp.fsf@yahoo.com> <66a9a7d83ca545dd23c890d4aa97717f1796579f.camel@teloden.nl> <8735ioxy5e.fsf@yahoo.com> <04ae2baf0a2a974bb411820c4d294b82d86ddc92.camel@teloden.nl> <87czghve92.fsf@yahoo.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEWhHy+el0itrKM7 ISH///94VleDAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+YFDQs5F7dB4g4AAAFvSURBVDjLdZNrtsMg CIRJ3EDQDQS6AQ3739vlYdS0uf7oOeXrzChQgO3cMVNmO7Qz6MnEDCcQiDR0cu4nOEHW8q5ABA0A Hw42ypDB6yIGsjsZYNiONEEXAKL+vgvEQ3r9MhAC9ntRGHHDO6ExW3w4hTYEO3ORHALwtJ6wqY1c Z3eaoB6USVo4MeIC9sIicHg/0EgHG5RM+ulvQGz5zoAj610NJNG6ShaABjaRovWSb6Dv8eim7cQi 5RpAKkC0QQEOUONpMQDNkAafBdRoj3kJkFbVINXZZxUEmPlyd/SzgAppGZkATzAFBtCLadZjlF0x 3iD3JiHogDoYd7oUNB3XF9Bs0pEA2yIuQCesgLPuXoIKq8KBrejaJ8vQARg40jfAjH19nkC4+RLP no8MGuvzDL+WvXoAeWziCq4F2BK+Aot5dJfG15oegKfBffA/4P8snccPaNYQav9YfV5Ac/BiVT3k C9SRXn4V0Sp5yQjwB4D5mi5LfRUoAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTA1LTEzVDExOjU3 OjIzKzAwOjAwEvfPUQAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wNS0xM1QxMTo1NzoyMyswMDow MGOqd+0AAAAASUVORK5CYII= X-Now-Playing: Joe Jackson's _Mike's Murder_: "Cosmopolitan" Date: Fri, 13 May 2022 13:57:35 +0200 In-Reply-To: <87czghve92.fsf@yahoo.com> (Po Lu's message of "Fri, 13 May 2022 19:55:05 +0800") Message-ID: <87lev5wspc.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Po Lu writes: > Great, thanks! Once Eli or Lars say your copyright paperwork is in > order, I will install your change. The paperwork is in order. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54564 Cc: Eli Zaretskii , 54564@debbugs.gnu.org, Pieter van Prooijen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Po Lu writes: > Great, thanks! Once Eli or Lars say your copyright paperwork is in > order, I will install your change. The paperwork is in order. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri May 13 08:12:07 2022 Received: (at 54564) by debbugs.gnu.org; 13 May 2022 12:12:07 +0000 Received: from localhost ([127.0.0.1]:43074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npU9P-00069C-0P for submit@debbugs.gnu.org; Fri, 13 May 2022 08:12:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npU9N-00068g-P0 for 54564@debbugs.gnu.org; Fri, 13 May 2022 08:12:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53642) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npU9I-0004mG-C7; Fri, 13 May 2022 08:12:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9/e5XdXE/tdEeE6L0DUUJK7k2hL8g6P2HGDfJYwDgyU=; b=okDDjnX4as4u YA1T5oG3Vm5WBbkSHxGm7T1y091QuCRXmORwZ6UKg/20vs6FG0rzSyCCmmULBswDH71TIhMSdgRbb eOh4/kpI1okJ+UZ8bxK64v5posHuxeg15rZIufQZ7FBeR/9cNbms2vcsPimE3XEsfPNTFnYUuKXVp lopO9oBLRpkp774Cl1eVKVsAnEksbilBTQTT/77X5BoOehgx29R3Qa511RI6wn5xEQjaDbv524JSV 8UpJ59qNRsgtPuvTZqn3PoeLZiEief4FEmIK0LzViCr954XBiAXMdp69pe5+T4ETMU50w9XRqsWL+ UYSoMgUqA7kYeOa/56zdcQ==; Received: from [87.69.77.57] (port=2201 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npU9H-0004uU-Qu; Fri, 13 May 2022 08:12:00 -0400 Date: Fri, 13 May 2022 15:12:06 +0300 Message-Id: <83tu9tmy21.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <87czghve92.fsf@yahoo.com> (message from Po Lu on Fri, 13 May 2022 19:55:05 +0800) Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> <83czi9b5gh.fsf@gnu.org> <87v8w143h6.fsf@yahoo.com> <87o81s2osr.fsf@yahoo.com> <88d833f72df4f4cbb5769f1a75057d3f957a812c.camel@teloden.nl> <87bkxnx1co.fsf@yahoo.com> <211c08916190ef05cc1677956a77fca0c6122eda.camel@teloden.nl> <87k0c9imvp.fsf@yahoo.com> <66a9a7d83ca545dd23c890d4aa97717f1796579f.camel@teloden.nl> <8735ioxy5e.fsf@yahoo.com> <04ae2baf0a2a974bb411820c4d294b82d86ddc92.camel@teloden.nl> <87czghve92.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54564 Cc: larsi@gnus.org, 54564@debbugs.gnu.org, pieter.van.prooijen@teloden.nl X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Po Lu > Cc: 54564@debbugs.gnu.org, Eli Zaretskii , Lars Ingebrigtsen > > Date: Fri, 13 May 2022 19:55:05 +0800 > > Pieter van Prooijen writes: > > > Hello All, > > > > The copyright assignment paperwork came through, is it possible to > > incorporate the gsetting font rendering changes? I've attached a patch > > against the current master, let me know if I need to change anything. > > Great, thanks! Once Eli or Lars say your copyright paperwork is in > order, I will install your change. Pieter's assignment is on file, so please go ahead. From debbugs-submit-bounces@debbugs.gnu.org Fri May 13 08:51:51 2022 Received: (at 54564-done) by debbugs.gnu.org; 13 May 2022 12:51:51 +0000 Received: from localhost ([127.0.0.1]:43138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npUlr-0001Ac-LD for submit@debbugs.gnu.org; Fri, 13 May 2022 08:51:51 -0400 Received: from sonic311-23.consmr.mail.ne1.yahoo.com ([66.163.188.204]:45055) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npUlp-0001AL-PN for 54564-done@debbugs.gnu.org; Fri, 13 May 2022 08:51:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1652446303; bh=7hkZ6LF+PGRrTIBYxlyzV7sNZcRCLFeCIXneJCjrBZs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=ZeDTc/3UIwTLDzXJh3DxN2m0HFu8MoQLKY/chdvkuTrjajxr0rQbs1NHQVOtnVm8T5li1PubarBXx41h4u8QdL6TJFvHZy1IsvXMT28Ho/Szt6GgQxMm/wwZyayzYuxKxEq+WJKA/ufAp/ONSlDKIH5ZNJBLCgLE60fQjJcazFBY7OimZCsSa8/dUR6kMhOciSRFMvpsRmSuDNlIrUaXSEJRp6cuJaLux5FRw7T/UuhyL420PohxViIpbY6GUCYeiPj+MYWObMlQT0uqoq8JwSm7Ok0v3JRjG1W/MKG6jh/FEkRD5V2fla/2C5M4U97yC4VKLLyXkqh5zyFwJHZx4w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1652446303; bh=0GQrbEc8Uz3bqH91XP7zhX7CZJ9FXpHr36hebBrqqtH=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Rw+o4Bu8E9BrmVsteAtD1dHN7dFAoYKIQzsv27Kg+YvdU1/3Xoejq9BgfbHGU5l8J+6TSaxwtx0MAdkqVNI1ql642pnlVCW1OvXnNI3BI92WyaEC4HFnfWWW3SecZSbzaXmwmQxg65gnxBWWInYE9VxmyO6uUGhUxBHLCJYVTygxBfIWw58t3BiKwLWQ0RuTKKM/I0eH2zrWW3uN0YSMDW54xvtIENEBRgsVmHGoD8ukqsyQ6HQuKGhUYYVaf7UaWGmeURpvJG4ytLDE15IiuejmrMcbkVvz7513psaDSBtajyKIVmORdgNBufkkNn/bMrt+54b+Xd2N8k+LhR71XQ== X-YMail-OSG: qwMmys4VM1m76u7XBrnuJhg.O2rmm5gXy59uKK.kCxb6lkCF0Z4TiIxiOR3NT42 zLYnnujWDMWV8BTQRAHV3kVMnu5ELtmCHZrf9dhXgaZFKpMsvdMeIoI8K82jHzDfBO7HWgDMomD6 HKoVVZpAAwj0Pppz_aMT0GxLFE70sudF0RxoJ.n0d2vuCNR4KFpwD_wolVJtFiVVG6eScU6RGXW5 00eXNP78mzK9K.W9t38QpJNFDGj5Cts2VJiF8p.hbfP7yEnEFeo9swb8ij0SiQLOSHiJyDYY_aYG 6pzScT4f3bryNSG1CEnTwxZvAS5Yg0ev62IEEsckKpKqLGRzrbBIP03FtL9B9fF5HUHc.6LBVTWp RoH2uQEtmOptuPlew3deyBvKDT_JwQXyZ39KWACSlqEITRMEneUZdUbKjK3V6s3VFiehrLQX_0jW XeVsHBXD0MlngRmE3jasLmKRn_pibxOiEl3XtAEVPUggNII.OknxH2fHiuvLewF7_MGoo8mjAjAO .HwTKfpOPOoXThATp5yJL5mpdR__KDJWrs2XOeIrwkaHwBonG01VQ873GsMxOkho0cWbmEPi1z5E _oUAHQPWICafXQglQnz.N_fPwiPnQqHd7uMPt.SFYplNIgvIjpLGei6QGxalORqvu0jZ8ys1GB1r Yib5CKgXGpbCd8BDzDUynYe9RHuEFnf_Oo1Uyk4Is4xrGb.Jq90NUceDm13L9l15_OMGYEp9r2iz xWEjdhVrCPHjop8PjljLVvykMvg7rk6oGUQCsgb7y2Doq648Hh8Q0NOM1X8kZtmJE9RU5WNT3ZX. j3XfpP7mpE6d3hopnd_KiKs7PuIDC.plS2OBfoQMpIFJttAG83cbd4WXKuI_EndCTBbJEfJZhpN8 4j0g6Lc0bm1GJC.HrOiI97A6dp5kKr6WOZh3mnJOuoJk8vI2KUvgmY5rhVrG3uOwFpxAY_aIXwfp DF8i0rN6f7ooHkcyDmcf.JCNdoZdc.vNxC.8csZ3nBghMQ6BJnO5E2cd_CGhCIGNJX63lVUacyfR uz7kwgxSzKZ9TZ0AsafR6RBqf2.jS1Sx_FaVq6JCof6kMhNunzZISZ15E1fTknuZ1yi1iSie95Vg mFNREQ3VOaMfqUXf1UU.bun.EpHQ16i_j_zslutHGG4Ig6owy1vx_vqydo7RPATDiZ1d9iYewf72 swhht_og2DcuQcU9ynmut20T9hGGYgYbSGoT27AHhcUYyvQ3ItSH08kNSJctFHhZOL63kmfjaWMW luv_C1vX1ct4thDNjEuER5HOCQ3B_n5H1Th6HAcgYSrLcsMOZe4BdwGohWx3hCC7bXNt9UWJoZl4 Z7Mst.pqs3z4kP8zfZJuHQ4DUbNKBtqG5n.q1tJebeUfKBLU_nV_ps4ds4M1yfjCuktmkLmk3L9m mBoZTLRMaI0asDxfxig60BBpgCKbvUVDDkEo_BN4Hdp50YkcPP8zJDhhp36VHACVlv_xCBvhiPh1 1x35SWszpgPmX3MLIrgyv2z1FklZypcjFWQCABV02AQHe9KA0E_W57O37L2zzAeBE2rUUHWLelQl dZFMkMSTHgc8d0ITfhESJ8dRGIIe2fzo3OxvJ4h5vkMsdjhbH1f79ruYUWjvUgwgWZ8Bg6watIog Q1Ot32LLfY3..8GrALgcNYy._lvsGVCyA8sU3JdPYYtfLgP1D7Q6UVCAqLVN4ifrFLFu_mRwgWfD SIuT_WYbzfR_ABwlD.SIR_lWbxWk.Jc7.iyjfbw3IZNZEoDK3OjR7DkXMXx_dStroV3VvPhBuZl9 RzLVv7GxiXPoQbv.VqfxFF2PtR4to8h6EhyS3PQC_h73J8GpIvSEos5QckwfDt3.3f0XlIPjUl4o QA5TzlRZSMl2qM8SHjp4HEx_pJgEuH3kL.li4lL3qhnWxpYBVMySqNfZIA2egfd944mCb5pfMXJq _tjrlW.t84RF7J9.OYIZWxGhR76iEuEAnUpBuQY6A1xhcUVvqlenVzUgtoalampJfDE3Ufb9ioma tfNwMRTFOluSeFZ8PB88Wq1_wc7ZJMLHc2nCVvEWh7_ZsD6SKSxh2xM1k1s1Vu2lk8WsNF_gyufR TTiWYUBVucNhkI8EUud6FSxAC.mOP30wYV66QAV6gQIf9yrPhiQjzBWNXfLPiGcFKjdPMM3Qe6sy xPN.O7jjUN1CJmcChjzzkUtBZQ05tBP36u67rXv8qn4U2K9ZP2V6RaF7ywl14wwihFOAVz3ftV0u dzmLAB232z_8ogULtiJvljYEmKDLlVqt91KRpNhCIuHXwu8EuBxpqFwnEdv0DSdgy X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ne1.yahoo.com with HTTP; Fri, 13 May 2022 12:51:43 +0000 Received: by hermes--canary-production-sg3-856bf69955-lwmfc (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 6bef2e33bdcbb92967f6e6ced8c41692; Fri, 13 May 2022 12:51:40 +0000 (UTC) From: Po Lu To: Pieter van Prooijen Subject: Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> <83czi9b5gh.fsf@gnu.org> <87v8w143h6.fsf@yahoo.com> <87o81s2osr.fsf@yahoo.com> <88d833f72df4f4cbb5769f1a75057d3f957a812c.camel@teloden.nl> <87bkxnx1co.fsf@yahoo.com> <211c08916190ef05cc1677956a77fca0c6122eda.camel@teloden.nl> <87k0c9imvp.fsf@yahoo.com> <66a9a7d83ca545dd23c890d4aa97717f1796579f.camel@teloden.nl> <8735ioxy5e.fsf@yahoo.com> <04ae2baf0a2a974bb411820c4d294b82d86ddc92.camel@teloden.nl> Date: Fri, 13 May 2022 20:51:36 +0800 In-Reply-To: (Pieter van Prooijen's message of "Fri, 13 May 2022 13:38:16 +0200") Message-ID: <87v8u9tx2f.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20188 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 357 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54564-done Cc: 54564-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pieter van Prooijen writes: > Hello All, > > The copyright assignment paperwork came through, is it possible to > incorporate the gsetting font rendering changes? I've attached a patch > against the current master, let me know if I need to change anything. Thank you. I will install this shortly and am closing this bug. From unknown Fri Jun 20 07:11:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 11 Jun 2022 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator