GNU bug report logs - #54561
[PATCH 0/4] Add service declarations for Samba

Previous Next

Full log

Message #80 received at 54561 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Simon Streit <simon <at> netpanic.org>
Cc: 54561 <at> debbugs.gnu.org
Subject: Re: bug#54561: [PATCH 0/4] Add service declarations for Samba
Date: Fri, 08 Apr 2022 23:26:20 +0200

Simon Streit <simon <at> netpanic.org> skribis:

> * gnu/services/samba.scm (<samba-configuration>): New record.
> (samba-service-type): New variable.
> (samba-shepherd-services): New Procedure.

Just write “New file.”, that’s enough.

Please also add it to gnu/local.mk and to po/guix/POTFILES.in.

[...]

> +  #:export (samba-service-type
> +            samba-configuration
> +            samba-smb-conf
> +
> +            wsdd-service-type
> +            wsdd-configuration))

These two lines shouldn’t be here for now.  :-)

> +(define samba-service-type
> +  (service-type
> +   (name 'samba)
> +   (description "Samba")
> +   (extensions
> +    (list (service-extension shepherd-root-service-type
> +                             samba-shepherd-services)
> +          (service-extension activation-service-type
> +                             samba-activation)
> +          (service-extension profile-service-type
> +                             (compose list samba-configuration-package))))
> +   (default-value (samba-configuration))))

Please add a ‘description’ field with Texinfo markup (it’s the
description you see when running ‘guix system search’.)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.