Subject: Re: bug#54561: [PATCH 0/4] Add service declarations for Samba

From: Ludovic Courtès <[email-masked]>
Date: Fri, 08 Apr 2022 23:41:16 +0200

Simon Streit <[email-masked]> skribis:

> +@cindex wsdd
> +@subsubheading Web Service Discovery Daemon
> +
> +Web Service Discovery Daemon implements the WSD protocoll.

Please provide a bit of context, for example:

  The Web Service Discovery daemon (wsdd) implements, not surprisingly,
  Web Service Discovery (WSD), a protocol for …

>  It is a
> +drop-in replacement for host discovery that lack support for the SMBv1
> +protocol.

That too would need a bit more context IMO.

> +@defvr{Scheme Variable} wsdd-service-type
         ^
Missing space (in other similar places too).

> +Service type for the Web Service Discoery host daemon.  The value for

Typo; but you can write “WSD” here, since that has been introduced
above.

> +@item @code{ipv6only} (default: @code{#f})
> +Only listen to ipv6 addresses.  Please note: Activating both options is
> +not possible, since there would be no ip versions to listen to.

“IPv6”, “IP”.

> +@item @code{chroot} (default: @code{#f})
> +Chroot into a sperate directory to prevent access to other directories.

“separate”

> +This is to increase security in case there is a vulnerability in
> +@command{wsdd}.
> +
> +@item @code{hoplimit} (default: @code{1})

s/hoplimit/hop-limit/ (two words), and in the code too.

> +@item @code{hostname} (default: @code{#f})

Likewise, preferably ‘host-name’.

Ludo’.