GNU bug report logs - #54560
[PATCH 00/47] gnu: Add go-github-com-prometheus-prometheus.

Previous Next

Package: guix-patches;

Reported by: Leo Nikkilä <hello <at> lnikki.la>

Date: Fri, 25 Mar 2022 08:11:02 UTC

Severity: normal

Tags: patch

Full log


Message #236 received at 54560 <at> debbugs.gnu.org (full text, mbox):

From: Leo Nikkilä <hello <at> lnikki.la>
To: "Maxime Devos" <maximedevos <at> telenet.be>, 54560 <at> debbugs.gnu.org
Subject: Re: [bug#54560] [PATCH 04/47] gnu:
 go-github-com-prometheus-client-golang: Update to 1.12.1.
Date: Fri, 25 Mar 2022 22:55:47 +0000
> Why is the 'build phase deleted?

> Is ignoring tests still necessary?

Looks like you're right, I was able to use the default build phases with these packages locally, after minor tweaks. I believe I followed the pattern from the existing packages earlier, seems it's unnecessary.

> Returning #t from phases is not necessary anymore.  I'm wondering, did
> you find this in some documentation floating around somewhere or
> something?

Old habit, I learned this when this was still common. Will remove these.

> This looks Linux-specific.

Thank you, it is.




This bug report was last modified 293 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.