From unknown Sun Jun 15 01:07:20 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#5456: vc-hg-state does not search hg in vc-path Resent-From: Stephan Bergmann Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Jan 2010 22:12:01 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: report 5456 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: To: 5456@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.126419829015746 (code B ref -1); Fri, 22 Jan 2010 22:12:01 +0000 Received: (at submit) by debbugs.gnu.org; 22 Jan 2010 22:11:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYRiy-00045t-La for submit@debbugs.gnu.org; Fri, 22 Jan 2010 17:11:29 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYReQ-00042Z-JC for submit@debbugs.gnu.org; Fri, 22 Jan 2010 17:06:47 -0500 Received: from mail.gnu.org ([199.232.76.166]:54146 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYReM-0006DA-Ir for submit@debbugs.gnu.org; Fri, 22 Jan 2010 17:06:42 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NYReL-0000DE-8t for submit@debbugs.gnu.org; Fri, 22 Jan 2010 17:06:42 -0500 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on monty-python X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,UNPARSEABLE_RELAY autolearn=ham version=3.1.0 Received: from lists.gnu.org ([199.232.76.165]:59685) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NYReL-0000D8-2m for submit@debbugs.gnu.org; Fri, 22 Jan 2010 17:06:41 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NYReK-00022h-Qq for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2010 17:06:40 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NYReF-0001qn-VY for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2010 17:06:40 -0500 Received: from [199.232.76.173] (port=60115 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NYReF-0001qX-Ra for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2010 17:06:35 -0500 Received: from gmp-eb-inf-2.sun.com ([192.18.6.24]:47061) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1NYReF-0000CL-5Z for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2010 17:06:35 -0500 Received: from fe-emea-09.sun.com (gmp-eb-lb-1-fe1.eu.sun.com [192.18.6.7] (may be forged)) by gmp-eb-inf-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id o0MM6XbE009632 for ; Fri, 22 Jan 2010 22:06:33 GMT MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII Received: from conversion-daemon.fe-emea-09.sun.com by fe-emea-09.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) id <0KWO0090053QK000@fe-emea-09.sun.com> for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2010 22:06:08 +0000 (GMT) Received: from little.fritz.box ([unknown] [79.222.1.114]) by fe-emea-09.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) with ESMTPSA id <0KWO00DHC5DZ6R90@fe-emea-09.sun.com> for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2010 22:06:08 +0000 (GMT) Date: Fri, 22 Jan 2010 23:05:58 +0100 From: Stephan Bergmann Message-id: <26BBB3D3-37BA-4E83-A9C3-16247D4D8241@sun.com> X-Mailer: Apple Mail (2.1077) X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -6.6 (------) X-Mailman-Approved-At: Fri, 22 Jan 2010 17:11:27 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) At least in 23.1, vc-hg-state (and vc-hg-working-revision) in vc-hg.el call "hg" without making sure that it is being searched for in vc-path (as is done in vc-dispatcher.el by extending exec-path). What fixed it for me (on recent trunk) is ---8<--- === modified file 'lisp/vc-hg.el' --- lisp/vc-hg.el 2010-01-13 08:35:10 +0000 +++ lisp/vc-hg.el 2010-01-22 21:46:14 +0000 @@ -169,7 +169,8 @@ ;; Ignore all errors. (let ((process-environment ;; Avoid localization of messages so we can parse the output. - (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=") process-environment))) + (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=") process-environment)) + (exec-path (append vc-path exec-path))) (process-file "hg" nil t nil @@ -205,7 +206,8 @@ (let ((process-environment ;; Avoid localization of messages so we can parse the output. (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=") - process-environment))) + process-environment)) + (exec-path (append vc-path exec-path))) ;; Ignore all errors. (process-file "hg" nil t nil ---8<--- -Stephan From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 23 06:21:52 2010 Received: (at control) by debbugs.gnu.org; 23 Jan 2010 11:21:52 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYe3r-0004d2-IL for submit@debbugs.gnu.org; Sat, 23 Jan 2010 06:21:51 -0500 Received: from mail-bw0-f223.google.com ([209.85.218.223]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYe3p-0004cx-76 for control@debbugs.gnu.org; Sat, 23 Jan 2010 06:21:49 -0500 Received: by bwz23 with SMTP id 23so746233bwz.39 for ; Sat, 23 Jan 2010 03:21:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=uv7AhcnwDjncq6tHt5gfqz9gxWDsVi8soqiLGvCesdw=; b=Ht5ABJzvaXNKoqud3HpfNv5MNPvxa8MOHTEQ3PbspN/8W1A0UH61ojUyRUEihD5gEt Th3j5wd4wza55c8nWopfhT6q5dJhQe4zMAn8zlv9gcEvsSUxncQShAxo2czWhYHXzUac WhmgPcx6CpHNSxjB/d5vIL6RGSLfvixlNrC8U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=i7PwumXZmry8dekM/kuYsqPiv5tXNAm8DDTkdwazsB4JV3PiuqraeXpoQIob+c+S9D VLuSHpg3jVcXitSMNLiT/p1oiceLFgy+K4NmYi2bNtGAdgxkq4kFlsTJdkPb/J4XSX6f DpF7O0O+YyJ+v2k5zIAxfrdncaCneWby8Ozg4= MIME-Version: 1.0 Received: by 10.204.5.207 with SMTP id 15mr2416995bkw.89.1264245705775; Sat, 23 Jan 2010 03:21:45 -0800 (PST) From: Juanma Barranquero Date: Sat, 23 Jan 2010 12:21:25 +0100 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.8 (-) reassign 5456 emacs,vc tags 5456 + patch quit From unknown Sun Jun 15 01:07:20 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#5456: vc-hg-state does not search hg in vc-path Resent-From: Dan Nicolaescu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Jan 2010 06:17:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5456 X-Emacs-PR-Package: emacs,vc X-Emacs-PR-Keywords: patch To: Stephan Bergmann Cc: 5456@debbugs.gnu.org Received: via spool by 5456-submit@debbugs.gnu.org id=B5456.126440020420677 (code B ref 5456); Mon, 25 Jan 2010 06:17:02 +0000 Received: (at 5456) by debbugs.gnu.org; 25 Jan 2010 06:16:44 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZIFg-0005NR-3W for submit@debbugs.gnu.org; Mon, 25 Jan 2010 01:16:44 -0500 Received: from paul-mcgann-v0.ics.uci.edu ([128.195.1.147]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZIFe-0005NM-Dc for 5456@debbugs.gnu.org; Mon, 25 Jan 2010 01:16:43 -0500 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by paul-mcgann-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id o0P6GT1G025326 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 24 Jan 2010 22:16:30 -0800 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id o0P6GThb002574; Sun, 24 Jan 2010 22:16:29 -0800 (PST) Date: Sun, 24 Jan 2010 22:16:29 -0800 (PST) Message-Id: <201001250616.o0P6GThb002574@godzilla.ics.uci.edu> From: Dan Nicolaescu References: <26BBB3D3-37BA-4E83-A9C3-16247D4D8241@sun.com> In-Reply-To: <26BBB3D3-37BA-4E83-A9C3-16247D4D8241@sun.com> (Stephan Bergmann's message of "Fri, 22 Jan 2010 23:05:58 +0100") Lines: 35 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: o0P6GT1G025326 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-Spam-Status: No X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Stephan Bergmann writes: > At least in 23.1, vc-hg-state (and vc-hg-working-revision) in vc-hg.el call "hg" without making sure that it is being searched for in vc-path (as is done in vc-dispatcher.el by extending exec-path). What fixed it for me (on recent trunk) is > ---8<--- > === modified file 'lisp/vc-hg.el' > --- lisp/vc-hg.el 2010-01-13 08:35:10 +0000 > +++ lisp/vc-hg.el 2010-01-22 21:46:14 +0000 > @@ -169,7 +169,8 @@ > ;; Ignore all errors. > (let ((process-environment > ;; Avoid localization of messages so we can parse the output. > - (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=") process-environment))) > + (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=") process-environment)) > + (exec-path (append vc-path exec-path))) > > (process-file > "hg" nil t nil > @@ -205,7 +206,8 @@ > (let ((process-environment > ;; Avoid localization of messages so we can parse the output. > (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=") > - process-environment))) > + process-environment)) > + (exec-path (append vc-path exec-path))) > ;; Ignore all errors. > (process-file > "hg" nil t nil There's more places where a change like this would be necessary.... Actually, looking over all the VC backends, almost all could use vc-path, but NONE does. So I'd rather vote for deprecating vc-path in 23.2 and remove it later. From unknown Sun Jun 15 01:07:20 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#5456: vc-hg-state does not search hg in vc-path Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Jan 2010 15:36:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5456 X-Emacs-PR-Package: emacs,vc X-Emacs-PR-Keywords: patch To: Dan Nicolaescu Cc: 5456@debbugs.gnu.org, Stephan Bergmann Received: via spool by 5456-submit@debbugs.gnu.org id=B5456.126443373912796 (code B ref 5456); Mon, 25 Jan 2010 15:36:02 +0000 Received: (at 5456) by debbugs.gnu.org; 25 Jan 2010 15:35:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZQyY-0003KK-0C for submit@debbugs.gnu.org; Mon, 25 Jan 2010 10:35:38 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZQyV-0003K5-R8 for 5456@debbugs.gnu.org; Mon, 25 Jan 2010 10:35:36 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsFALdIXUvO+LMp/2dsb2JhbACBRdkJhDsEik6DFA X-IronPort-AV: E=Sophos;i="4.49,339,1262581200"; d="scan'208";a="54504095" Received: from 206-248-179-41.dsl.teksavvy.com (HELO pastel.home) ([206.248.179.41]) by ironport2-out.pppoe.ca with ESMTP; 25 Jan 2010 10:35:30 -0500 Received: by pastel.home (Postfix, from userid 20848) id 808C481D6; Mon, 25 Jan 2010 10:35:30 -0500 (EST) From: Stefan Monnier Message-ID: References: <26BBB3D3-37BA-4E83-A9C3-16247D4D8241@sun.com> <201001250616.o0P6GThb002574@godzilla.ics.uci.edu> Date: Mon, 25 Jan 2010 10:35:30 -0500 In-Reply-To: <201001250616.o0P6GThb002574@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Sun, 24 Jan 2010 22:16:29 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.0 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > So I'd rather vote for deprecating vc-path in 23.2 and remove it later. Agreed, I see no need to treat VC specially in this regard (IIUC this was done originally because RCS and SCCS started as a bunch of separate commands with potentially conflicting names (like ci/co/...), and were often installed in a non-standard place, but it doesn't seem relevant nowadays). Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 25 17:15:50 2010 Received: (at control) by debbugs.gnu.org; 25 Jan 2010 22:15:50 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZXDp-0005lk-KA for submit@debbugs.gnu.org; Mon, 25 Jan 2010 17:15:49 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZXDn-0005lf-OZ for control@debbugs.gnu.org; Mon, 25 Jan 2010 17:15:47 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1NZXDj-0008Mo-PR; Mon, 25 Jan 2010 17:15:43 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19294.6159.769802.454605@fencepost.gnu.org> Date: Mon, 25 Jan 2010 17:15:43 -0500 From: Glenn Morris To: control Subject: control X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) retitle 5456 deprecate vc-path tags 5456 = severity 5456 minor unmerge 2562 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 27 19:13:46 2010 Received: (at control) by debbugs.gnu.org; 28 Jan 2010 00:13:46 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NaI14-0003WI-8V for submit@debbugs.gnu.org; Wed, 27 Jan 2010 19:13:46 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NaI12-0003WB-1C for control@debbugs.gnu.org; Wed, 27 Jan 2010 19:13:44 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1NaI0y-0002kj-9B; Wed, 27 Jan 2010 19:13:40 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19296.54964.237486.393967@fencepost.gnu.org> Date: Wed, 27 Jan 2010 19:13:40 -0500 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: magenta X-Ran: jqeI@9]N2j9L=T5y{46XM$yis^=8-t%A[c3H.k}5+~~"#Nf)E5)8*?XxH+0T%:q./m!M*2 X-Debbugs-No-Ack: yes X-Spam-Score: -4.9 (----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.9 (----) tags 5032 moreinfo reassign 5032 emacs,w32 reassign 5040 emacs,w32 severity 5042 wishlist reassign 5074 emacs,w32 severity 5105 minor tags 5173 patch severity 5183 minor severity 5184 minor submitter 5195 monnier@iro.umontreal.ca unarchive 5227 unmerge 5227 tags 5251 patch severity 5290 wishlist reassign 5299 emacs,w32 tags 5326 patch reopen 5336 severity 5336 serious retitle 5336 DOC file is arch dependent reassign 5349 emacs,ns severity 5433 wishlist close 5456 reassign 5464 emacs,w32 reassign 5465 emacs,w32 reassign 5480 emacs,gnus reassign 5482 emacs,w32 reassign 5484 emacs,etags tags 5484 patch