GNU bug report logs - #5456
deprecate vc-path

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5456 in the body.
You can then email your comments to 5456 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stephan Bergmann <Stephan.Bergmann <at> Sun.COM>
To: bug-gnu-emacs <at> gnu.org
Subject: vc-hg-state does not search hg in vc-path
Date: Fri, 22 Jan 2010 23:05:58 +0100

At least in 23.1, vc-hg-state (and vc-hg-working-revision) in vc-hg.el call "hg" without making sure that it is being searched for in vc-path (as is done in vc-dispatcher.el by extending exec-path).  What fixed it for me (on recent trunk) is

---8<---
=== modified file 'lisp/vc-hg.el'
--- lisp/vc-hg.el	2010-01-13 08:35:10 +0000
+++ lisp/vc-hg.el	2010-01-22 21:46:14 +0000
@@ -169,7 +169,8 @@
                       ;; Ignore all errors.
 		      (let ((process-environment
 			     ;; Avoid localization of messages so we can parse the output.
-			     (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=") process-environment)))
+			     (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=") process-environment))
+                            (exec-path (append vc-path exec-path)))
 
 		      (process-file
                        "hg" nil t nil
@@ -205,7 +206,8 @@
 		      (let ((process-environment
 			     ;; Avoid localization of messages so we can parse the output.
 			     (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=")
-				     process-environment)))
+				     process-environment))
+                            (exec-path (append vc-path exec-path)))
 			;; Ignore all errors.
 			(process-file
 			 "hg" nil t nil

---8<---

-Stephan

Message #12 received at 5456 <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: Stephan Bergmann <Stephan.Bergmann <at> Sun.COM>
Cc: 5456 <at> debbugs.gnu.org
Subject: Re: bug#5456: vc-hg-state does not search hg in vc-path
Date: Sun, 24 Jan 2010 22:16:29 -0800 (PST)

Stephan Bergmann <Stephan.Bergmann <at> Sun.COM> writes:

  > At least in 23.1, vc-hg-state (and vc-hg-working-revision) in vc-hg.el call "hg" without making sure that it is being searched for in vc-path (as is done in vc-dispatcher.el by extending exec-path).  What fixed it for me (on recent trunk) is

  > ---8<---
  > === modified file 'lisp/vc-hg.el'
  > --- lisp/vc-hg.el	2010-01-13 08:35:10 +0000
  > +++ lisp/vc-hg.el	2010-01-22 21:46:14 +0000
  > @@ -169,7 +169,8 @@
  >                        ;; Ignore all errors.
  >  		      (let ((process-environment
  >  			     ;; Avoid localization of messages so we can parse the output.
  > -			     (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=") process-environment)))
  > +			     (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=") process-environment))
  > +                            (exec-path (append vc-path exec-path)))
  >  
  >  		      (process-file
  >                         "hg" nil t nil
  > @@ -205,7 +206,8 @@
  >  		      (let ((process-environment
  >  			     ;; Avoid localization of messages so we can parse the output.
  >  			     (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=")
  > -				     process-environment)))
  > +				     process-environment))
  > +                            (exec-path (append vc-path exec-path)))
  >  			;; Ignore all errors.
  >  			(process-file
  >  			 "hg" nil t nil

There's more places where a change like this would be necessary....

Actually, looking over all the VC backends, almost all could use vc-path,
but NONE does.

So I'd rather vote for deprecating vc-path in 23.2 and remove it later.

Message #15 received at 5456 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Dan Nicolaescu <dann <at> ics.uci.edu>
Cc: 5456 <at> debbugs.gnu.org, Stephan Bergmann <Stephan.Bergmann <at> Sun.COM>
Subject: Re: bug#5456: vc-hg-state does not search hg in vc-path
Date: Mon, 25 Jan 2010 10:35:30 -0500

> So I'd rather vote for deprecating vc-path in 23.2 and remove it later.

Agreed, I see no need to treat VC specially in this regard (IIUC this
was done originally because RCS and SCCS started as a bunch of separate
commands with potentially conflicting names (like ci/co/...), and were
often installed in a non-standard place, but it doesn't seem relevant
nowadays).


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.