Subject: Re: Mcomix 2.0.1 do not install locale data.

From: "Feng Shu" <[email-masked]>
Date: Sun, 27 Mar 2022 17:52:04 +0800

"Feng Shu" <[email-masked]> writes:

> "Feng Shu" <[email-masked]> writes:
>
>> I think Mcomix 2.0.1 do not install locale date.
>
> I try to code a patch:
>
> From bc1627e85cde9569b96057daa863184566863858 Mon Sep 17 00:00:00 2001
> From: Feng Shu <[email-masked]>
> Date: Sun, 27 Mar 2022 17:35:13 +0800
> Subject: [PATCH] gnu: mcomix: Install messages directory.
>
> * gnu/packages/image-viewers.scm (mcomix)
> [arguments]: Install messages directory.
> ---
>  gnu/packages/image-viewers.scm | 51 +++++++++++++++++-----------------
>  1 file changed, 26 insertions(+), 25 deletions(-)
>
> diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
> index 05a8151c29..7410605077 100644
> --- a/gnu/packages/image-viewers.scm
> +++ b/gnu/packages/image-viewers.scm
> @@ -695,31 +695,32 @@ (define-public mcomix
>                (substitute* "mcomix/image_tools.py"
>                  (("assert name not in supported_formats_gdk")
>                   "if name in supported_formats_gdk: continue"))))
> -         (add-after 'install 'install-data
> -           (lambda* (#:key outputs #:allow-other-keys)
> -             (copy-recursively
> -              "mcomix/images"
> -              (string-append (assoc-ref outputs "out")
> -                             "/lib/python"
> -                             #$(version-major+minor
> -                                (package-version (this-package-input "python")))
> -                             "/site-packages/mcomix/images"))))
> -         (add-after 'install 'install-messages
> -           (lambda* (#:key outputs #:allow-other-keys)
> -             (copy-recursively
> -              "mcomix/messages"
> -              (string-append (assoc-ref outputs "out")
> -                             "/share/locale"))))
> -         (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap
> -           (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))
> -         (add-after 'wrap 'gi-wrap
> -           (lambda* (#:key outputs #:allow-other-keys)
> -             (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
> -               (for-each
> -                (lambda (prog)
> -                  (wrap-program prog
> -                    `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH")))))
> -                (list (string-append bin "/mcomix")))))))))
> +          (add-after 'install 'install-data
> +            (lambda* (#:key outputs #:allow-other-keys)
> +              (copy-recursively
> +               "mcomix/images"
> +               (string-append (assoc-ref outputs "out")
> +                              "/lib/python"
> +                              #$(version-major+minor
> +                                 (package-version (this-package-input "python")))
> +                              "/site-packages/mcomix/images"))
> +              (copy-recursively
> +               "mcomix/messages"
> +               (string-append (assoc-ref outputs "out")
> +                              "/lib/python"
> +                              #$(version-major+minor
> +                                 (package-version (this-package-input "python")))
> +                              "/site-packages/mcomix/messages"))))
> +          (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap
> +            (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))
> +          (add-after 'wrap 'gi-wrap
> +            (lambda* (#:key outputs #:allow-other-keys)
> +              (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
> +                (for-each
> +                 (lambda (prog)
> +                   (wrap-program prog
> +                     `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH")))))
> +                 (list (string-append bin "/mcomix")))))))))
>      (home-page "https://sourceforge.net/p/mcomix/wiki/Home/")
>      (synopsis "Image viewer for comics")
>      (description "MComix is a customizable image viewer that specializes as
> -- 
> 2.34.0

Sorry, the above is wrong patch, please see below:

>From a84f1c8d1ad923f2b90fdf40a0655f8015f122a8 Mon Sep 17 00:00:00 2001
From: Feng Shu <[email-masked]>
Date: Sun, 27 Mar 2022 17:47:52 +0800
Subject: [PATCH] gnu: mcomix: Install messages directory.

* gnu/packages/image-viewers.scm (mcomix)
[arguments]: Install messages directory.
---
 gnu/packages/image-viewers.scm | 45 ++++++++++++++++++++--------------
 1 file changed, 26 insertions(+), 19 deletions(-)

diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index 09c448e8f5..7410605077 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -695,25 +695,32 @@ (define-public mcomix
               (substitute* "mcomix/image_tools.py"
                 (("assert name not in supported_formats_gdk")
                  "if name in supported_formats_gdk: continue"))))
-         (add-after 'install 'install-data
-           (lambda* (#:key outputs #:allow-other-keys)
-             (copy-recursively
-              "mcomix/images"
-              (string-append (assoc-ref outputs "out")
-                             "/lib/python"
-                             #$(version-major+minor
-                                (package-version (this-package-input "python")))
-                             "/site-packages/mcomix/images"))))
-         (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap
-           (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))
-         (add-after 'wrap 'gi-wrap
-           (lambda* (#:key outputs #:allow-other-keys)
-             (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
-               (for-each
-                (lambda (prog)
-                  (wrap-program prog
-                    `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH")))))
-                (list (string-append bin "/mcomix")))))))))
+          (add-after 'install 'install-data
+            (lambda* (#:key outputs #:allow-other-keys)
+              (copy-recursively
+               "mcomix/images"
+               (string-append (assoc-ref outputs "out")
+                              "/lib/python"
+                              #$(version-major+minor
+                                 (package-version (this-package-input "python")))
+                              "/site-packages/mcomix/images"))
+              (copy-recursively
+               "mcomix/messages"
+               (string-append (assoc-ref outputs "out")
+                              "/lib/python"
+                              #$(version-major+minor
+                                 (package-version (this-package-input "python")))
+                              "/site-packages/mcomix/messages"))))
+          (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap
+            (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))
+          (add-after 'wrap 'gi-wrap
+            (lambda* (#:key outputs #:allow-other-keys)
+              (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
+                (for-each
+                 (lambda (prog)
+                   (wrap-program prog
+                     `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH")))))
+                 (list (string-append bin "/mcomix")))))))))
     (home-page "https://sourceforge.net/p/mcomix/wiki/Home/")
     (synopsis "Image viewer for comics")
     (description "MComix is a customizable image viewer that specializes as
-- 
2.34.0

--