From unknown Sat Sep 20 13:00:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54558: mcomix refuses to run, missing GTK libraries Resent-From: Natalie Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 24 Mar 2022 22:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 54558 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 54558@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16481592272696 (code B ref -1); Thu, 24 Mar 2022 22:01:01 +0000 Received: (at submit) by debbugs.gnu.org; 24 Mar 2022 22:00:27 +0000 Received: from localhost ([127.0.0.1]:49582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXVVL-0000hP-5S for submit@debbugs.gnu.org; Thu, 24 Mar 2022 18:00:27 -0400 Received: from lists.gnu.org ([209.51.188.17]:49454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXTlW-0006BJ-9K for submit@debbugs.gnu.org; Thu, 24 Mar 2022 16:09:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56486) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXTlV-0002Hh-LM for bug-guix@gnu.org; Thu, 24 Mar 2022 16:09:01 -0400 Received: from mx1.riseup.net ([198.252.153.129]:53896) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXTlT-0007l2-Rm for bug-guix@gnu.org; Thu, 24 Mar 2022 16:09:01 -0400 Received: from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4KPbs510nrzDsPj for ; Thu, 24 Mar 2022 13:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1648152537; bh=8FPvSzGkQ7iWdf2tOCj8HbijRtEbheOHAz6kdHlAnpI=; h=Date:From:To:Subject:From; b=Co98a4OQJobpLX53mFp5EXUxsPW4VLOKY6LlQKuFfomPSHJ32tS8l2+eG0TOK3cvP vpdh+zxiSeARl+CKADFQVBv4LMZCFfAE39xsm0c3wRk5AJgds5htQHedai3omgIk72 kmW/A05vn900MqkvlxSGgJOXYkP2G2tHLDeMN408= X-Riseup-User-ID: 88B9AA41B73D569B8A43215D3E5AD5A2CAFF413F0DE417CF533EFD5416ABB71B Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews2.riseup.net (Postfix) with ESMTPSA id 4KPbs500yNz1yQq for ; Thu, 24 Mar 2022 13:08:56 -0700 (PDT) MIME-Version: 1.0 Date: Thu, 24 Mar 2022 13:08:56 -0700 From: Natalie Message-ID: Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=198.252.153.129; envelope-from=batalie@riseup.net; helo=mx1.riseup.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Mailman-Approved-At: Thu, 24 Mar 2022 18:00:26 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hi there, I've just tried to install mcomix on Guix System, but have had no luck running it. Upon installing and trying to run it in the shell, it fails with: > [MainThread] ERROR: You do not have the required versions of GTK+ 3.0 installed. Does GTK need to be added to its inputs? From unknown Sat Sep 20 13:00:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54558: [PATCH 2/2] gnu: mcomix: Wrap missing paths. References: In-Reply-To: Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 25 Mar 2022 22:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54558 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 54558@debbugs.gnu.org Cc: batalie@riseup.net Received: via spool by 54558-submit@debbugs.gnu.org id=B54558.164824852222694 (code B ref 54558); Fri, 25 Mar 2022 22:49:02 +0000 Received: (at 54558) by debbugs.gnu.org; 25 Mar 2022 22:48:42 +0000 Received: from localhost ([127.0.0.1]:52697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXsja-0005tw-Ev for submit@debbugs.gnu.org; Fri, 25 Mar 2022 18:48:42 -0400 Received: from mail-ej1-f68.google.com ([209.85.218.68]:35829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXsjZ-0005tZ-IH for 54558@debbugs.gnu.org; Fri, 25 Mar 2022 18:48:41 -0400 Received: by mail-ej1-f68.google.com with SMTP id yy13so18048060ejb.2 for <54558@debbugs.gnu.org>; Fri, 25 Mar 2022 15:48:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:date:subject:mime-version:to:cc:content-transfer-encoding :message-id; bh=BVLtp8BaUPuVH89iQUXyKaHZM5ZgEc7bo7R9vQUnKiA=; b=KqNoRlBXwLl8EykugjWa10zwSU5EfjOsrKgWm0Ma2gW6MCMRTH/TIOLP9UZBLP6sRc XbCC7BTte6RT2MsfZQsJpwnkj7enx8KOCas9mEQaRqUaqvruhMPNHP2AojfCQn72KpJP anuh1GhNoTp6afm1NLYMbskcAOkJKk1UObFzrzuhNRmLuXOh3KbBO9+RNbm3JFigoH8O XXsov0tEpq1wrwuA39kBPo+YI68O/kBzaEEzHJyhTIvYRvGEvaWECKKfiRBvyNTcAfmQ pbYPyz4Y6+NbkErUPFo3XxFJwckLY+33MnDJxHJJ1Qc/3ArBgN2ozQf0WlePya3aueiF GscA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:subject:mime-version:to:cc :content-transfer-encoding:message-id; bh=BVLtp8BaUPuVH89iQUXyKaHZM5ZgEc7bo7R9vQUnKiA=; b=FSgHJbgEIz6MMXI2XFVW/zXEYvS3nTY8ZfNgVOks+0VJQzCTL1/9VxtVN4OlETPICw 13VDSp4O2o7cwmW7610arEwYrnj2lhSdz+WYxJphc096jmfpqwV2SRQ/qE626rqZatKQ bqpInPOaDPoFlrpXoBzPSP4aver3U+8g1AGRjCRQL/SoO8H0ukRkAo9jFkoR8Kna9uGi /8rfIP0uNg0PjOhCmnbvrC0KrdoxNUBU5Rjq81QIjGyJywtx7/1NSbEa7ctSl9CLbmCA iHhc5Eif+z8Bgss7UpBI5KaMzHR9Uil+8qiGTRQPQpf/eFcbMq16L+pRj6gd6vg1Opeh sBLw== X-Gm-Message-State: AOAM532rAW7aOQt88p1tY/CowTlY978YyWKoJSx/+deXUKEsVtNWsiB/ Tc6xbpYENJVvzExb+uc622wjF2r/CLE= X-Google-Smtp-Source: ABdhPJz9a0tRwfuLv+hDo5PuyMF+NhgofJyYyaiONNqq2638VjNajP1WlAvaSczeGcjJsh62sKdxQw== X-Received: by 2002:a17:907:da6:b0:6e0:c59:f3ad with SMTP id go38-20020a1709070da600b006e00c59f3admr14374387ejc.85.1648248515903; Fri, 25 Mar 2022 15:48:35 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id bm5-20020a170906c04500b006ce6f8892a5sm2822429ejb.7.2022.03.25.15.48.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 15:48:35 -0700 (PDT) From: Liliana Marie Prikler Date: Fri, 25 Mar 2022 23:45:51 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Message-ID: X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/image-viewers.scm (mcomix)[inputs]: Add gtk+. [arguments]<#:imported-modules,#:modules>: New arguments. <#:phases>: Add ‘glib-or-gtk-wrap’ and ‘gi-wrap’. --- gnu/packages/image-viewers.scm | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm index 1c325cd8a7..134ffc563a 100644 --- a/gnu/packages/image-viewers.scm +++ b/gnu/packages/image-viewers.scm @@ -675,9 +675,14 @@ (define-public mcomix "187ca815vxb2in1ryvfiaf1zapi0bc9jxdac3c1bky0kr6x7xyap")))) (build-system python-build-system) (inputs - (list p7zip python python-pillow python-pygobject python-pycairo)) + (list p7zip python python-pillow python-pygobject python-pycairo gtk+)) (arguments (list + #:imported-modules `(,@%python-build-system-modules + (guix build glib-or-gtk-build-system)) + #:modules '((guix build python-build-system) + ((guix build glib-or-gtk-build-system) #:prefix glib-or-gtk:) + (guix build utils)) #:phases #~(modify-phases %standard-phases (add-after 'unpack 'patch-source @@ -699,7 +704,17 @@ (define-public mcomix "/lib/python" #$(version-major+minor (package-version (this-package-input "python"))) - "/site-packages/mcomix/images"))))))) + "/site-packages/mcomix/images")))) + (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap + (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)) + (add-after 'wrap 'gi-wrap + (lambda* (#:key outputs #:allow-other-keys) + (let ((bin (string-append (assoc-ref outputs "out") "/bin"))) + (for-each + (lambda (prog) + (wrap-program prog + `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH"))))) + (list (string-append bin "/mcomix"))))))))) (home-page "https://sourceforge.net/p/mcomix/wiki/Home/") (synopsis "Image viewer for comics") (description "MComix is a customizable image viewer that specializes as -- 2.34.0 From unknown Sat Sep 20 13:00:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54558: [PATCH 1/2] gnu: mcomix: Update to 2.0.1. References: In-Reply-To: Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 25 Mar 2022 22:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54558 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 54558@debbugs.gnu.org Cc: batalie@riseup.net Received: via spool by 54558-submit@debbugs.gnu.org id=B54558.164824852622705 (code B ref 54558); Fri, 25 Mar 2022 22:49:02 +0000 Received: (at 54558) by debbugs.gnu.org; 25 Mar 2022 22:48:46 +0000 Received: from localhost ([127.0.0.1]:52699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXsja-0005tz-NQ for submit@debbugs.gnu.org; Fri, 25 Mar 2022 18:48:46 -0400 Received: from mail-ej1-f66.google.com ([209.85.218.66]:42664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXsjZ-0005tY-9f for 54558@debbugs.gnu.org; Fri, 25 Mar 2022 18:48:41 -0400 Received: by mail-ej1-f66.google.com with SMTP id j15so17991932eje.9 for <54558@debbugs.gnu.org>; Fri, 25 Mar 2022 15:48:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:date:subject:mime-version:to:cc:content-transfer-encoding :message-id; bh=SFPJH8FQ6Hlr0LkeuoMSbPcLoVIMalryrrmsgbItjcM=; b=fHcYql9uH+rFaP8CBTTFUT2nvG5t1nllo3LU/Awjk3p68NZ5oYrprT7LKkIsdX3WkF ckrs0cefYTfa97uZhmb1+RtxZcI1U99w0mvpP+XGrfBYHlhPyshBh8gFGCoaH4MdX6IA iWo5tV+g6yGLAGv1lOuuSqiITnI9cRLNXyx2Ak1CqYEQ3lNGOSexWt9YcjJvr7JB+f6s N1f36yBv/stwFHytgwmBPVeQO9R6AlvFlL9ptGUEieXYKmSou0uzGpOYN17aqOBz8zNp fxHQy/rmrZTGnzuQnO5Ie2quvwR/iUihtrfUVetUQVOQ35n9kvkjl0xs4iH8Arq0BNKq 7V3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:subject:mime-version:to:cc :content-transfer-encoding:message-id; bh=SFPJH8FQ6Hlr0LkeuoMSbPcLoVIMalryrrmsgbItjcM=; b=mkcAccdVUqr6yrLVMPty1UVJjKDI1tYDKa+OIo1hZtSMkBUwP3Y0/3V9/jC5Bhfm3m xHVVH6jhM9jqZq6rxM5wnnwRsDCeShYtFGHQhc+u8PzjCTcqjXiHufKEk4JEyCWBPUEk dzmQ50eXgh2HdfuF4LnM5BwKDsLBbf23hfAPt2emH03GsJrq6XC2xtpCG9AZRgjZQWOj 7Y25bxAXu2w8OTppe4SIFj96yEYITGHuQaHtsnv5RKXIgz5NDgK8f9ozW09UmdsxCtSf wbkrnT2bv1dIWFVRLmPFqOvYNtaUD8Jkul215L9XToemZxIDKoDOaHuAZp169kI76QWX 5yBw== X-Gm-Message-State: AOAM532b8X73P8kAVE0YtMm1TMV8SUq26+oLK1YY3sguvz5C9Frqtvq6 iSyVYeYELyh/ED0BAwGmseMrGD9haOY= X-Google-Smtp-Source: ABdhPJziOSOdwVsjJ/DDLYCe8nwzsSByw07uUhu9egaUNIZl425/NmO1sxOrEk741Lw65fewrUfAhw== X-Received: by 2002:a17:907:7284:b0:6df:9120:d935 with SMTP id dt4-20020a170907728400b006df9120d935mr14387475ejc.276.1648248515152; Fri, 25 Mar 2022 15:48:35 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id bm5-20020a170906c04500b006ce6f8892a5sm2822429ejb.7.2022.03.25.15.48.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 15:48:34 -0700 (PDT) From: Liliana Marie Prikler Date: Fri, 25 Mar 2022 21:37:01 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Message-ID: X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/image-viewers.scm (mcomix): Update to 2.0.1. [source]: Use sourceforge once again. [inputs]: Add ‘python’. [arguments]: Convert to a list of G-Expressions. <#:tests?>: Drop. <#:phases>: Rename ‘configure’ to ‘patch-sources’. Also fix an assertion error in "mcomix/image_tools.py". No longer replace ‘build’ or ‘install’. Add ‘install-data’ phase after ‘install’. Use (this-package-input) to refer to the python input. --- gnu/packages/image-viewers.scm | 123 +++++++++++---------------------- 1 file changed, 42 insertions(+), 81 deletions(-) diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm index 6ab6cf3307..1c325cd8a7 100644 --- a/gnu/packages/image-viewers.scm +++ b/gnu/packages/image-viewers.scm @@ -662,91 +662,52 @@ (define-public luminance-hdr ;; CBR and RAR are currently unsupported, due to non-free dependencies. (define-public mcomix - ;; Official mcomix hasn't been updated since 2016, it's broken with - ;; python-pillow 6+ and only supports Python 2. We use fork instead. - (let ((commit "fea55a7a9369569eefed72209eed830409c4af98")) - (package - (name "mcomix") - (version (git-version "1.2.1" "1" commit)) - (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/multiSnow/mcomix3") - (commit commit))) - (file-name (git-file-name name version)) - (sha256 - (base32 - "05zl0dkjwbdcm2zlk4nz9w33amlqj8pbf32a8ymshc2356fqhhi5")))) - (build-system python-build-system) - (inputs - (list p7zip python-pillow python-pygobject python-pycairo)) - (arguments - `(#:tests? #f ; FIXME: How do we run tests? - #:phases - (modify-phases %standard-phases - (add-after 'unpack 'configure - (lambda* (#:key inputs #:allow-other-keys) - (let ((p7zip (assoc-ref inputs "p7zip"))) - ;; insert absolute path to 7z executable - (substitute* "mcomix/mcomix/archive/sevenzip_external.py" - (("_7z_executable = -1") - (string-append "_7z_executable = u'" p7zip "/bin/7z'")))) - #t)) - (replace 'build - (lambda* (#:key outputs #:allow-other-keys) - (let* ((out (assoc-ref outputs "out")) - (pyver ,(version-major+minor (package-version python))) - (lib (string-append out "/lib/python" pyver))) - (invoke (which "python") "installer.py" "--srcdir=mcomix" - (string-append "--target=" lib)) - (rename-file (string-append lib "/mcomix") - (string-append lib "/site-packages")) - #t))) - (replace 'install - (lambda* (#:key outputs #:allow-other-keys) - (let* ((out (assoc-ref outputs "out")) - (share (string-append out "/share")) - (bin (string-append out "/bin")) - (pyver ,(version-major+minor (package-version python))) - (lib (string-append out "/lib/python" pyver "/site-packages"))) - (mkdir-p bin) - (rename-file (string-append lib "/mcomixstarter.py") - (string-append bin "/mcomix")) - (rename-file (string-append lib "/comicthumb.py") - (string-append bin "/comicthumb")) - (install-file "mime/mcomix.desktop" - (string-append share "/applications")) - (install-file "mime/mcomix.appdata.xml" - (string-append share "/metainfo")) - (install-file "mime/mcomix.xml" - (string-append share "/mime/packages")) - (install-file "mime/comicthumb.thumbnailer" - (string-append share "/thumbnailers")) - (install-file "man/mcomix.1" (string-append share "/man/man1")) - (install-file "man/comicthumb.1" (string-append share "/man/man1")) - (for-each - (lambda (size) - (install-file - (format #f "mcomix/mcomix/images/~sx~s/mcomix.png" size size) - (format #f "~a/icons/hicolor/~sx~s/apps/" share size size)) - (for-each - (lambda (ext) - (install-file - (format #f "mime/icons/~sx~s/application-x-~a.png" size size ext) - (format #f "~a/icons/hicolor/~sx~s/mimetypes/" - share size size))) - '("cb7" "cbr" "cbt" "cbz"))) - '(16 22 24 32 48)) - #t)))))) - (home-page "https://sourceforge.net/p/mcomix/wiki/Home/") - (synopsis "Image viewer for comics") - (description "MComix is a customizable image viewer that specializes as + (package + (name "mcomix") + (version "2.0.1") + (source + (origin + (method url-fetch) + (uri (string-append "mirror://sourceforge/mcomix/MComix-" version "/" + "mcomix-" version ".tar.gz")) + (sha256 + (base32 + "187ca815vxb2in1ryvfiaf1zapi0bc9jxdac3c1bky0kr6x7xyap")))) + (build-system python-build-system) + (inputs + (list p7zip python python-pillow python-pygobject python-pycairo)) + (arguments + (list + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'patch-source + (lambda* (#:key inputs #:allow-other-keys) + (let ((p7zip (assoc-ref inputs "p7zip"))) + ;; insert absolute path to 7z executable + (substitute* "mcomix/archive/sevenzip_external.py" + (("_7z_executable = -1") + (string-append "_7z_executable = u'" p7zip "/bin/7z'"))) + + (substitute* "mcomix/image_tools.py" + (("assert name not in supported_formats_gdk") + "if name in supported_formats_gdk: continue"))))) + (add-after 'install 'install-data + (lambda* (#:key outputs #:allow-other-keys) + (copy-recursively + "mcomix/images" + (string-append (assoc-ref outputs "out") + "/lib/python" + #$(version-major+minor + (package-version (this-package-input "python"))) + "/site-packages/mcomix/images"))))))) + (home-page "https://sourceforge.net/p/mcomix/wiki/Home/") + (synopsis "Image viewer for comics") + (description "MComix is a customizable image viewer that specializes as a comic and manga reader. It supports a variety of container formats including CBZ, CB7, CBT, LHA. For PDF support, install the @emph{mupdf} package.") - (license license:gpl2+)))) + (license license:gpl2+))) (define-public qview (package -- 2.34.0 From unknown Sat Sep 20 13:00:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54558: mcomix refuses to run, missing GTK libraries Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 26 Mar 2022 02:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54558 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Liliana Marie Prikler Cc: 54558@debbugs.gnu.org, batalie@riseup.net Received: via spool by 54558-submit@debbugs.gnu.org id=B54558.164826346015086 (code B ref 54558); Sat, 26 Mar 2022 02:58:02 +0000 Received: (at 54558) by debbugs.gnu.org; 26 Mar 2022 02:57:40 +0000 Received: from localhost ([127.0.0.1]:52825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXwcS-0003v3-0H for submit@debbugs.gnu.org; Fri, 25 Mar 2022 22:57:40 -0400 Received: from mail-qk1-f176.google.com ([209.85.222.176]:36776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXwcQ-0003ud-6s for 54558@debbugs.gnu.org; Fri, 25 Mar 2022 22:57:34 -0400 Received: by mail-qk1-f176.google.com with SMTP id v13so7398991qkv.3 for <54558@debbugs.gnu.org>; Fri, 25 Mar 2022 19:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=EnyCnqqobtbcnK0iBnqBe0bJXnmPn3V8FqLnHf1wW18=; b=bN104xSKBlfBJP16EVFoEuWVD2FPZiOcBqsW1aPN73/yJiM6k1f0Q09h0jwKG6cb6H wmQhdvHEQsS2cEHntxbvlqMutn8Axoy2kXD7b+P79v1z0NFInhWGP+DG59NF/xncKOWv rS882wJl+hhr+G32Qx6YtRG6jfEEuT7nIEtZG14oxUT5wY6qP4iQ9buEXzsgQHklv8nL /Ihn2OIA34o/OcQA93QP+D7koUNge9pdbyB3r7wBpCpkB7P3f392+jFWJZ017tZ0DDuF E3jPPvVrtbW31i0Pec7jM1dy4vuzOQfcsEAUXZQJwSV8CcsSYcfBncSMpBHx/9x4EaR6 97bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=EnyCnqqobtbcnK0iBnqBe0bJXnmPn3V8FqLnHf1wW18=; b=JiFI8vZj8DpfxuGYmDp3dio8l8aIPLB5/+T234/0uulF75Avwn63idFh4/kAfoP97/ W1SFiMsoQjqSU8DYTZYjp7Uk/tM3ZLeHYnml1UyMsg/SwfRtS3uF3wIUiBScfV+jwwh3 XD9N+2e9uwkWkKHNHf0lagrjZx46yGvpfRnvYmZrurVAs9CX5buGWXxBHWByfJhMyjFW O2qi5lreQPmN3xuUb5wy6YJc8FszFO6zSs61BnabPOGuuxTcVRpdFlLsi3CbmTAHJZBk qADa/SPiOxk9F2Uwxrfg23JwUPZZM7CWz0YVNdSj+hOcGFNVb9YluzWY4itYCmd+r0Ic 9/1A== X-Gm-Message-State: AOAM533NV6VMQ+rZ6ibtSRUNB/b/FgzjeLIY88AkGeFPCleS6aZ9Gl1Q yJV7Ro7/6CaLqqr/ayzihp8= X-Google-Smtp-Source: ABdhPJyI8rkUKc9L4w/FEwcMhDerxHLvewV/i0mzEUgIXZ5WAbO6tXLAa33X+dMERlSG+2Mly7QOaA== X-Received: by 2002:a05:620a:4541:b0:67e:4bb7:c11b with SMTP id u1-20020a05620a454100b0067e4bb7c11bmr8984746qkp.194.1648263448543; Fri, 25 Mar 2022 19:57:28 -0700 (PDT) Received: from hurd (dsl-157-48.b2b2c.ca. [66.158.157.48]) by smtp.gmail.com with ESMTPSA id 3-20020a370503000000b0067b03f03589sm4301738qkf.53.2022.03.25.19.57.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 19:57:27 -0700 (PDT) From: Maxim Cournoyer References: Date: Fri, 25 Mar 2022 22:57:26 -0400 In-Reply-To: (Liliana Marie Prikler's message of "Fri, 25 Mar 2022 21:37:01 +0100") Message-ID: <87czi9xvxl.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Liliana, Liliana Marie Prikler writes: > * gnu/packages/image-viewers.scm (mcomix): Update to 2.0.1. > [source]: Use sourceforge once again. > [inputs]: Add =E2=80=98python=E2=80=99. > [arguments]: Convert to a list of G-Expressions. > <#:tests?>: Drop. > <#:phases>: Rename =E2=80=98configure=E2=80=99 to =E2=80=98patch-sources= =E2=80=99. Also fix an assertion > error in "mcomix/image_tools.py". > No longer replace =E2=80=98build=E2=80=99 or =E2=80=98install=E2=80=99. = Add =E2=80=98install-data=E2=80=99 phase after > =E2=80=98install=E2=80=99. Use (this-package-input) to refer to the pyth= on input. > --- > gnu/packages/image-viewers.scm | 123 +++++++++++---------------------- > 1 file changed, 42 insertions(+), 81 deletions(-) > > diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.= scm > index 6ab6cf3307..1c325cd8a7 100644 > --- a/gnu/packages/image-viewers.scm > +++ b/gnu/packages/image-viewers.scm > @@ -662,91 +662,52 @@ (define-public luminance-hdr >=20=20 > ;; CBR and RAR are currently unsupported, due to non-free dependencies. > (define-public mcomix > - ;; Official mcomix hasn't been updated since 2016, it's broken with > - ;; python-pillow 6+ and only supports Python 2. We use fork instead. > - (let ((commit "fea55a7a9369569eefed72209eed830409c4af98")) > - (package > - (name "mcomix") > - (version (git-version "1.2.1" "1" commit)) > - (source > - (origin > - (method git-fetch) > - (uri (git-reference > - (url "https://github.com/multiSnow/mcomix3") > - (commit commit))) > - (file-name (git-file-name name version)) > - (sha256 > - (base32 > - "05zl0dkjwbdcm2zlk4nz9w33amlqj8pbf32a8ymshc2356fqhhi5")))) > - (build-system python-build-system) > - (inputs > - (list p7zip python-pillow python-pygobject python-pycairo)) > - (arguments > - `(#:tests? #f ; FIXME: How do we run tests? > - #:phases > - (modify-phases %standard-phases > - (add-after 'unpack 'configure > - (lambda* (#:key inputs #:allow-other-keys) > - (let ((p7zip (assoc-ref inputs "p7zip"))) > - ;; insert absolute path to 7z executable > - (substitute* "mcomix/mcomix/archive/sevenzip_external.p= y" > - (("_7z_executable =3D -1") > - (string-append "_7z_executable =3D u'" p7zip "/bin/7= z'")))) > - #t)) > - (replace 'build > - (lambda* (#:key outputs #:allow-other-keys) > - (let* ((out (assoc-ref outputs "out")) > - (pyver ,(version-major+minor (package-version pyth= on))) > - (lib (string-append out "/lib/python" pyver))) > - (invoke (which "python") "installer.py" "--srcdir=3Dmco= mix" > - (string-append "--target=3D" lib)) > - (rename-file (string-append lib "/mcomix") > - (string-append lib "/site-packages")) > - #t))) > - (replace 'install > - (lambda* (#:key outputs #:allow-other-keys) > - (let* ((out (assoc-ref outputs "out")) > - (share (string-append out "/share")) > - (bin (string-append out "/bin")) > - (pyver ,(version-major+minor (package-version pyth= on))) > - (lib (string-append out "/lib/python" pyver "/site= -packages"))) > - (mkdir-p bin) > - (rename-file (string-append lib "/mcomixstarter.py") > - (string-append bin "/mcomix")) > - (rename-file (string-append lib "/comicthumb.py") > - (string-append bin "/comicthumb")) > - (install-file "mime/mcomix.desktop" > - (string-append share "/applications")) > - (install-file "mime/mcomix.appdata.xml" > - (string-append share "/metainfo")) > - (install-file "mime/mcomix.xml" > - (string-append share "/mime/packages")) > - (install-file "mime/comicthumb.thumbnailer" > - (string-append share "/thumbnailers")) > - (install-file "man/mcomix.1" (string-append share "/man= /man1")) > - (install-file "man/comicthumb.1" (string-append share "= /man/man1")) > - (for-each > - (lambda (size) > - (install-file > - (format #f "mcomix/mcomix/images/~sx~s/mcomix.png" = size size) > - (format #f "~a/icons/hicolor/~sx~s/apps/" share siz= e size)) > - (for-each > - (lambda (ext) > - (install-file > - (format #f "mime/icons/~sx~s/application-x-~a.pn= g" size size ext) > - (format #f "~a/icons/hicolor/~sx~s/mimetypes/" > - share size size))) > - '("cb7" "cbr" "cbt" "cbz"))) > - '(16 22 24 32 48)) > - #t)))))) > - (home-page "https://sourceforge.net/p/mcomix/wiki/Home/") > - (synopsis "Image viewer for comics") > - (description "MComix is a customizable image viewer that specializ= es as > + (package > + (name "mcomix") > + (version "2.0.1") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "mirror://sourceforge/mcomix/MComix-" version= "/" > + "mcomix-" version ".tar.gz")) > + (sha256 > + (base32 > + "187ca815vxb2in1ryvfiaf1zapi0bc9jxdac3c1bky0kr6x7xyap")))) > + (build-system python-build-system) > + (inputs > + (list p7zip python python-pillow python-pygobject python-pycairo)) > + (arguments > + (list > + #:phases > + #~(modify-phases %standard-phases > + (add-after 'unpack 'patch-source > + (lambda* (#:key inputs #:allow-other-keys) > + (let ((p7zip (assoc-ref inputs "p7zip"))) > + ;; insert absolute path to 7z executable I know it's in the original, but since while we're revamping the package, let's make this comment a proper complete sentence. > + (substitute* "mcomix/archive/sevenzip_external.py" > + (("_7z_executable =3D -1") > + (string-append "_7z_executable =3D u'" p7zip "/bin/7z= '"))) I'd use something like: (format #f "_7z_executable =3D ~s" (search-input-file inputs "bin/7z")) For the replacement. That unicode string (u"something") is obsolete/unnecessary (all strings are unicode in Python 3). > + (substitute* "mcomix/image_tools.py" > + (("assert name not in supported_formats_gdk") > + "if name in supported_formats_gdk: continue"))))) > + (add-after 'install 'install-data > + (lambda* (#:key outputs #:allow-other-keys) > + (copy-recursively > + "mcomix/images" > + (string-append (assoc-ref outputs "out") > + "/lib/python" > + #$(version-major+minor > + (package-version (this-package-input "py= thon"))) > + "/site-packages/mcomix/images"))))))) > + (home-page "https://sourceforge.net/p/mcomix/wiki/Home/") > + (synopsis "Image viewer for comics") > + (description "MComix is a customizable image viewer that specializes= as > a comic and manga reader. It supports a variety of container formats > including CBZ, CB7, CBT, LHA. >=20=20 > For PDF support, install the @emph{mupdf} package.") > - (license license:gpl2+)))) > + (license license:gpl2+))) I haven't tried it, but LGTM with my above comments addressed. Thank you! Maxim From unknown Sat Sep 20 13:00:48 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Natalie Subject: bug#54558: closed (Re: bug#54558: mcomix refuses to run, missing GTK libraries) Message-ID: References: X-Gnu-PR-Message: they-closed 54558 X-Gnu-PR-Package: guix Reply-To: 54558@debbugs.gnu.org Date: Sat, 26 Mar 2022 08:02:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1648281722-13249-1" This is a multi-part message in MIME format... ------------=_1648281722-13249-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #54558: mcomix refuses to run, missing GTK libraries which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 54558@debbugs.gnu.org. --=20 54558: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D54558 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1648281722-13249-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 54558-done) by debbugs.gnu.org; 26 Mar 2022 08:01:58 +0000 Received: from localhost ([127.0.0.1]:53011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nY1Mz-0003RS-V8 for submit@debbugs.gnu.org; Sat, 26 Mar 2022 04:01:58 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:37452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nY1My-0003RD-LX for 54558-done@debbugs.gnu.org; Sat, 26 Mar 2022 04:01:57 -0400 Received: by mail-ed1-f66.google.com with SMTP id b15so11521519edn.4 for <54558-done@debbugs.gnu.org>; Sat, 26 Mar 2022 01:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=/sbWwad4O1TMovO3GeGk1fr6HPH0IvYZ7fX6hFXxxtc=; b=ioyyQFDIVWrGFHMd8ZD6Pe4QfvZ2zMzlzF1RGjMZNrneub5WOO39bNJzSadwisLDGM Qa0ekpVYYfavLlEUp0Zn9IqquXT6BzOXJDzS3BJQlqw5c7PRjdsGS7Lmj3gtaUsEIQIg saAoDSMqaAoGDen5oKgAEw/PutAWqrdzvnDzZF7Itj4u5gYMwOVw4JaZtiiHRzr1KcGC kbo+a58Qae1ptB2Fp83tzrTYY5U87W9bJmCEpWsqdBa3LwtxUJLonusHYI+9MoieZO9N KjnFauQAENJKs1pxcdpgRk0Ejf1mlTtsiykPEKuA0jUeeom2hEQuqrpo0IW62+KPyjzD YfCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=/sbWwad4O1TMovO3GeGk1fr6HPH0IvYZ7fX6hFXxxtc=; b=pTH9EBOZIIOKrM97PArSK277TL8H6zJS+g1HKUZCbH/nHeAjg+ZWk0UIEc1YusYfrV UvsDpR9SfXN5qKY6xWd2m47eyOU0pvu6YCFLHf/XQN3bR7vn/9olxyfoAnHSFYmuanmf MddCONO9r4F6qOQ6WwUOpjFpMY+r44DSZyGGTXYxVxHkkSNYMSzcVMCiMIiLJcD3DflX sBM4V8ObSBr8hYPtOg0NGJx+5jH2jQegx8JCH7VxnVyNg6j8VGqGcQGOcBTbI5r5ZB12 T3GZoC0i4WaJ8BfYdTcUp7eVx7IVmipdaH7jTp1VH3CNTWwOLXozfzlhcAjnwS9ifMgy J1wA== X-Gm-Message-State: AOAM531HcFYHRixtkg5f2hy1xprVeiheNT0NnBxGwHK7VKffeVpZif+3 DZ1EurdMjvJSWebPkN/43oY= X-Google-Smtp-Source: ABdhPJz4ucjQZvGnA2vtyiLkkU/cq1uSeghe11kdW8AHc6cJFowQPFs3iYuv0fJCTTNlJ7b6fP7rEQ== X-Received: by 2002:a05:6402:3593:b0:419:7a2d:4b0b with SMTP id y19-20020a056402359300b004197a2d4b0bmr3048151edc.39.1648281709188; Sat, 26 Mar 2022 01:01:49 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id ks20-20020a170906f85400b006e091a0cf8bsm2306370ejb.16.2022.03.26.01.01.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Mar 2022 01:01:48 -0700 (PDT) Message-ID: Subject: Re: bug#54558: mcomix refuses to run, missing GTK libraries From: Liliana Marie Prikler To: Maxim Cournoyer Date: Sat, 26 Mar 2022 09:01:47 +0100 In-Reply-To: <87czi9xvxl.fsf_-_@gmail.com> References: <87czi9xvxl.fsf_-_@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54558-done Cc: 54558-done@debbugs.gnu.org, batalie@riseup.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, Am Freitag, dem 25.03.2022 um 22:57 -0400 schrieb Maxim Cournoyer: > Hi Liliana, > > Liliana Marie Prikler writes: > > > [...] > > +              (let ((p7zip (assoc-ref inputs "p7zip"))) > > +                ;; insert absolute path to 7z executable > > I know it's in the original, but since while we're revamping the > package, let's make this comment a proper complete sentence. Thanks, did that. > > +                (substitute* "mcomix/archive/sevenzip_external.py" > > +                  (("_7z_executable = -1") > > +                   (string-append "_7z_executable = u'" p7zip > > "/bin/7z'"))) > > I'd use something like: > > (format #f "_7z_executable = ~s" >  (search-input-file inputs "bin/7z")) > > For the replacement.  That unicode string (u"something") is > obsolete/unnecessary (all strings are unicode in Python 3). Thanks, did that. > I haven't tried it, but LGTM with my above comments addressed. I tried it in a pure shell and apart from the usual missing icons, it launched fine. Closing. Cheers ------------=_1648281722-13249-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 24 Mar 2022 22:00:27 +0000 Received: from localhost ([127.0.0.1]:49582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXVVL-0000hP-5S for submit@debbugs.gnu.org; Thu, 24 Mar 2022 18:00:27 -0400 Received: from lists.gnu.org ([209.51.188.17]:49454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXTlW-0006BJ-9K for submit@debbugs.gnu.org; Thu, 24 Mar 2022 16:09:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56486) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXTlV-0002Hh-LM for bug-guix@gnu.org; Thu, 24 Mar 2022 16:09:01 -0400 Received: from mx1.riseup.net ([198.252.153.129]:53896) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXTlT-0007l2-Rm for bug-guix@gnu.org; Thu, 24 Mar 2022 16:09:01 -0400 Received: from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4KPbs510nrzDsPj for ; Thu, 24 Mar 2022 13:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1648152537; bh=8FPvSzGkQ7iWdf2tOCj8HbijRtEbheOHAz6kdHlAnpI=; h=Date:From:To:Subject:From; b=Co98a4OQJobpLX53mFp5EXUxsPW4VLOKY6LlQKuFfomPSHJ32tS8l2+eG0TOK3cvP vpdh+zxiSeARl+CKADFQVBv4LMZCFfAE39xsm0c3wRk5AJgds5htQHedai3omgIk72 kmW/A05vn900MqkvlxSGgJOXYkP2G2tHLDeMN408= X-Riseup-User-ID: 88B9AA41B73D569B8A43215D3E5AD5A2CAFF413F0DE417CF533EFD5416ABB71B Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews2.riseup.net (Postfix) with ESMTPSA id 4KPbs500yNz1yQq for ; Thu, 24 Mar 2022 13:08:56 -0700 (PDT) MIME-Version: 1.0 Date: Thu, 24 Mar 2022 13:08:56 -0700 From: Natalie To: bug-guix@gnu.org Subject: mcomix refuses to run, missing GTK libraries Message-ID: Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=198.252.153.129; envelope-from=batalie@riseup.net; helo=mx1.riseup.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 24 Mar 2022 18:00:26 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hi there, I've just tried to install mcomix on Guix System, but have had no luck running it. Upon installing and trying to run it in the shell, it fails with: > [MainThread] ERROR: You do not have the required versions of GTK+ 3.0 installed. Does GTK need to be added to its inputs? ------------=_1648281722-13249-1-- From unknown Sat Sep 20 13:00:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54558: Mcomix 2.0.1 do not install locale data. References: In-Reply-To: Resent-From: "Feng Shu" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 27 Mar 2022 02:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54558 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 54558@debbugs.gnu.org Cc: Feng Shu Received: via spool by 54558-submit@debbugs.gnu.org id=B54558.164834800816156 (code B ref 54558); Sun, 27 Mar 2022 02:27:02 +0000 Received: (at 54558) by debbugs.gnu.org; 27 Mar 2022 02:26:48 +0000 Received: from localhost ([127.0.0.1]:54989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYIcC-0004CW-D8 for submit@debbugs.gnu.org; Sat, 26 Mar 2022 22:26:48 -0400 Received: from m12-11.163.com ([220.181.12.11]:52926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYIc7-0004CC-3a for 54558@debbugs.gnu.org; Sat, 26 Mar 2022 22:26:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=iZWYz vCwbqsGE2o5qyhvnFXz5rFOdbjdod7WNr1lFqk=; b=NOmIzgz20kTM6R6h81oYy dGmdBmaqfGJIwrkqfSBQornPPEOsvILYZMWRnoaDHaNuv4IRkM5vlInAbYBtzt0A SCRFVyJrgGd8SYkOSf+jRpIyhOJ51XMjXNjoWO0fnqWwzXNDS/wuUcaHtTNmlbIo bMJdbnqVOCOEp6JnIztwE0= Received: from Guix (unknown [117.92.30.200]) by smtp7 (Coremail) with SMTP id C8CowADX5HxYyz9iCPIsEQ--.36928S2; Sun, 27 Mar 2022 10:26:33 +0800 (CST) From: "Feng Shu" Date: Sun, 27 Mar 2022 10:26:32 +0800 Message-ID: <87ee2om8pz.fsf@163.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-CM-TRANSID: C8CowADX5HxYyz9iCPIsEQ--.36928S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvj4RVuWWDUUUU X-Originating-IP: [117.92.30.200] X-CM-SenderInfo: 5wxpt2lkx6il2tof0z/xtbBERnQ1FaEHSMJcQAAsY X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I think Mcomix 2.0.1 do not install locale date. -- From unknown Sat Sep 20 13:00:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54558: Mcomix 2.0.1 do not install locale data. Resent-From: "Feng Shu" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 27 Mar 2022 09:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54558 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 54558@debbugs.gnu.org Cc: Feng Shu Received: via spool by 54558-submit@debbugs.gnu.org id=B54558.16483739653336 (code B ref 54558); Sun, 27 Mar 2022 09:40:01 +0000 Received: (at 54558) by debbugs.gnu.org; 27 Mar 2022 09:39:25 +0000 Received: from localhost ([127.0.0.1]:55343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYPMr-0000rk-3l for submit@debbugs.gnu.org; Sun, 27 Mar 2022 05:39:25 -0400 Received: from m12-13.163.com ([220.181.12.13]:64081) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYPMl-0000rP-FX for 54558@debbugs.gnu.org; Sun, 27 Mar 2022 05:39:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=X+4tU R8ZtxF0Hy1Sz6A6vsqj8vk9+Mi7Cv5wLM9mwO4=; b=lv1SXmT340IYKQbBuIVxu uHTSyeBqjlOkzYF30HQBm8rwvtOrgyug2sjNmKxTbNC2UcpkvnnJX/BzWcvgdLOr uw7fEO0GlHAPbA9gi24+dJGllzQTjn/5711P/+gYELpklcBWhECk7QOd414aHi1q WEO4SfYjkvbtrs7YMXw81w= Received: from Guix (unknown [117.92.30.200]) by smtp9 (Coremail) with SMTP id DcCowADHKJi7MEBiurzHCg--.35707S2; Sun, 27 Mar 2022 17:39:08 +0800 (CST) From: "Feng Shu" References: <87ee2om8pz.fsf@163.com> Date: Sun, 27 Mar 2022 17:39:07 +0800 In-Reply-To: <87ee2om8pz.fsf@163.com> (Feng Shu's message of "Sun, 27 Mar 2022 10:26:32 +0800") Message-ID: <87sfr3zqdg.fsf@163.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-CM-TRANSID: DcCowADHKJi7MEBiurzHCg--.35707S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjTRtOzxUUUUU X-Originating-IP: [117.92.30.200] X-CM-SenderInfo: 5wxpt2lkx6il2tof0z/xtbB3xTQ1GBHIQOEVQAAsb X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain "Feng Shu" writes: > I think Mcomix 2.0.1 do not install locale date. I try to code a patch: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-mcomix-Install-messages-directory.patch >From bc1627e85cde9569b96057daa863184566863858 Mon Sep 17 00:00:00 2001 From: Feng Shu Date: Sun, 27 Mar 2022 17:35:13 +0800 Subject: [PATCH] gnu: mcomix: Install messages directory. * gnu/packages/image-viewers.scm (mcomix) [arguments]: Install messages directory. --- gnu/packages/image-viewers.scm | 51 +++++++++++++++++----------------- 1 file changed, 26 insertions(+), 25 deletions(-) diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm index 05a8151c29..7410605077 100644 --- a/gnu/packages/image-viewers.scm +++ b/gnu/packages/image-viewers.scm @@ -695,31 +695,32 @@ (define-public mcomix (substitute* "mcomix/image_tools.py" (("assert name not in supported_formats_gdk") "if name in supported_formats_gdk: continue")))) - (add-after 'install 'install-data - (lambda* (#:key outputs #:allow-other-keys) - (copy-recursively - "mcomix/images" - (string-append (assoc-ref outputs "out") - "/lib/python" - #$(version-major+minor - (package-version (this-package-input "python"))) - "/site-packages/mcomix/images")))) - (add-after 'install 'install-messages - (lambda* (#:key outputs #:allow-other-keys) - (copy-recursively - "mcomix/messages" - (string-append (assoc-ref outputs "out") - "/share/locale")))) - (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap - (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)) - (add-after 'wrap 'gi-wrap - (lambda* (#:key outputs #:allow-other-keys) - (let ((bin (string-append (assoc-ref outputs "out") "/bin"))) - (for-each - (lambda (prog) - (wrap-program prog - `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH"))))) - (list (string-append bin "/mcomix"))))))))) + (add-after 'install 'install-data + (lambda* (#:key outputs #:allow-other-keys) + (copy-recursively + "mcomix/images" + (string-append (assoc-ref outputs "out") + "/lib/python" + #$(version-major+minor + (package-version (this-package-input "python"))) + "/site-packages/mcomix/images")) + (copy-recursively + "mcomix/messages" + (string-append (assoc-ref outputs "out") + "/lib/python" + #$(version-major+minor + (package-version (this-package-input "python"))) + "/site-packages/mcomix/messages")))) + (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap + (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)) + (add-after 'wrap 'gi-wrap + (lambda* (#:key outputs #:allow-other-keys) + (let ((bin (string-append (assoc-ref outputs "out") "/bin"))) + (for-each + (lambda (prog) + (wrap-program prog + `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH"))))) + (list (string-append bin "/mcomix"))))))))) (home-page "https://sourceforge.net/p/mcomix/wiki/Home/") (synopsis "Image viewer for comics") (description "MComix is a customizable image viewer that specializes as -- 2.34.0 --=-=-= Content-Type: text/plain -- --=-=-=-- From unknown Sat Sep 20 13:00:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54558: Mcomix 2.0.1 do not install locale data. Resent-From: "Feng Shu" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 27 Mar 2022 09:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54558 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 54558@debbugs.gnu.org Cc: Feng Shu Received: via spool by 54558-submit@debbugs.gnu.org id=B54558.16483747394844 (code B ref 54558); Sun, 27 Mar 2022 09:53:01 +0000 Received: (at 54558) by debbugs.gnu.org; 27 Mar 2022 09:52:19 +0000 Received: from localhost ([127.0.0.1]:55364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYPZL-0001G3-7J for submit@debbugs.gnu.org; Sun, 27 Mar 2022 05:52:19 -0400 Received: from m12-11.163.com ([220.181.12.11]:5949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYPZH-0001FV-Pa for 54558@debbugs.gnu.org; Sun, 27 Mar 2022 05:52:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=OVcrV EXBdmObczJU0XMTo6HaX0OvEro5ZEWOZGAvhds=; b=lR7t34CWwP11FOsuE7aE1 4yLOSHMNGdhrf+BVExSIM8uBKmj+R0sf9CJnvnJIR3HQKR5fxYDKeYV36GeKuJXd TLyFFRAw95n8mDrizh+yZiJl3FF7KweSNxTdcRV5cepNlAXeJA2j20Igu4w9BQHJ ItP2lVI9QgTxmB64ejQZOo= Received: from Guix (unknown [117.92.30.200]) by smtp7 (Coremail) with SMTP id C8CowABXXnbEM0Bi1stOEQ--.40481S2; Sun, 27 Mar 2022 17:52:05 +0800 (CST) From: "Feng Shu" References: <87ee2om8pz.fsf@163.com> <87sfr3zqdg.fsf@163.com> Date: Sun, 27 Mar 2022 17:52:04 +0800 In-Reply-To: <87sfr3zqdg.fsf@163.com> (Feng Shu's message of "Sun, 27 Mar 2022 17:39:07 +0800") Message-ID: <878rsvg1tn.fsf@163.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-CM-TRANSID: C8CowABXXnbEM0Bi1stOEQ--.40481S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxAr1UWr1rJFyDuw4xAr1fWFg_yoW5urWxpa sIgw13CryrJr18Xwn3XF4jvFyYg3y0krnYyw4avr1I9a18GFW0qryIgrZY9F1IqasxGw1D Ww4kZ3y5ur4rWFDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pRg6phUUUUU= X-Originating-IP: [117.92.30.200] X-CM-SenderInfo: 5wxpt2lkx6il2tof0z/xtbB0wXQ1FXltb6AOgAAsT X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain "Feng Shu" writes: > "Feng Shu" writes: > >> I think Mcomix 2.0.1 do not install locale date. > > I try to code a patch: > > From bc1627e85cde9569b96057daa863184566863858 Mon Sep 17 00:00:00 2001 > From: Feng Shu > Date: Sun, 27 Mar 2022 17:35:13 +0800 > Subject: [PATCH] gnu: mcomix: Install messages directory. > > * gnu/packages/image-viewers.scm (mcomix) > [arguments]: Install messages directory. > --- > gnu/packages/image-viewers.scm | 51 +++++++++++++++++----------------- > 1 file changed, 26 insertions(+), 25 deletions(-) > > diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm > index 05a8151c29..7410605077 100644 > --- a/gnu/packages/image-viewers.scm > +++ b/gnu/packages/image-viewers.scm > @@ -695,31 +695,32 @@ (define-public mcomix > (substitute* "mcomix/image_tools.py" > (("assert name not in supported_formats_gdk") > "if name in supported_formats_gdk: continue")))) > - (add-after 'install 'install-data > - (lambda* (#:key outputs #:allow-other-keys) > - (copy-recursively > - "mcomix/images" > - (string-append (assoc-ref outputs "out") > - "/lib/python" > - #$(version-major+minor > - (package-version (this-package-input "python"))) > - "/site-packages/mcomix/images")))) > - (add-after 'install 'install-messages > - (lambda* (#:key outputs #:allow-other-keys) > - (copy-recursively > - "mcomix/messages" > - (string-append (assoc-ref outputs "out") > - "/share/locale")))) > - (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap > - (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)) > - (add-after 'wrap 'gi-wrap > - (lambda* (#:key outputs #:allow-other-keys) > - (let ((bin (string-append (assoc-ref outputs "out") "/bin"))) > - (for-each > - (lambda (prog) > - (wrap-program prog > - `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH"))))) > - (list (string-append bin "/mcomix"))))))))) > + (add-after 'install 'install-data > + (lambda* (#:key outputs #:allow-other-keys) > + (copy-recursively > + "mcomix/images" > + (string-append (assoc-ref outputs "out") > + "/lib/python" > + #$(version-major+minor > + (package-version (this-package-input "python"))) > + "/site-packages/mcomix/images")) > + (copy-recursively > + "mcomix/messages" > + (string-append (assoc-ref outputs "out") > + "/lib/python" > + #$(version-major+minor > + (package-version (this-package-input "python"))) > + "/site-packages/mcomix/messages")))) > + (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap > + (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)) > + (add-after 'wrap 'gi-wrap > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((bin (string-append (assoc-ref outputs "out") "/bin"))) > + (for-each > + (lambda (prog) > + (wrap-program prog > + `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH"))))) > + (list (string-append bin "/mcomix"))))))))) > (home-page "https://sourceforge.net/p/mcomix/wiki/Home/") > (synopsis "Image viewer for comics") > (description "MComix is a customizable image viewer that specializes as > -- > 2.34.0 Sorry, the above is wrong patch, please see below: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-mcomix-Install-messages-directory.patch >From a84f1c8d1ad923f2b90fdf40a0655f8015f122a8 Mon Sep 17 00:00:00 2001 From: Feng Shu Date: Sun, 27 Mar 2022 17:47:52 +0800 Subject: [PATCH] gnu: mcomix: Install messages directory. * gnu/packages/image-viewers.scm (mcomix) [arguments]: Install messages directory. --- gnu/packages/image-viewers.scm | 45 ++++++++++++++++++++-------------- 1 file changed, 26 insertions(+), 19 deletions(-) diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm index 09c448e8f5..7410605077 100644 --- a/gnu/packages/image-viewers.scm +++ b/gnu/packages/image-viewers.scm @@ -695,25 +695,32 @@ (define-public mcomix (substitute* "mcomix/image_tools.py" (("assert name not in supported_formats_gdk") "if name in supported_formats_gdk: continue")))) - (add-after 'install 'install-data - (lambda* (#:key outputs #:allow-other-keys) - (copy-recursively - "mcomix/images" - (string-append (assoc-ref outputs "out") - "/lib/python" - #$(version-major+minor - (package-version (this-package-input "python"))) - "/site-packages/mcomix/images")))) - (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap - (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)) - (add-after 'wrap 'gi-wrap - (lambda* (#:key outputs #:allow-other-keys) - (let ((bin (string-append (assoc-ref outputs "out") "/bin"))) - (for-each - (lambda (prog) - (wrap-program prog - `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH"))))) - (list (string-append bin "/mcomix"))))))))) + (add-after 'install 'install-data + (lambda* (#:key outputs #:allow-other-keys) + (copy-recursively + "mcomix/images" + (string-append (assoc-ref outputs "out") + "/lib/python" + #$(version-major+minor + (package-version (this-package-input "python"))) + "/site-packages/mcomix/images")) + (copy-recursively + "mcomix/messages" + (string-append (assoc-ref outputs "out") + "/lib/python" + #$(version-major+minor + (package-version (this-package-input "python"))) + "/site-packages/mcomix/messages")))) + (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap + (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)) + (add-after 'wrap 'gi-wrap + (lambda* (#:key outputs #:allow-other-keys) + (let ((bin (string-append (assoc-ref outputs "out") "/bin"))) + (for-each + (lambda (prog) + (wrap-program prog + `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH"))))) + (list (string-append bin "/mcomix"))))))))) (home-page "https://sourceforge.net/p/mcomix/wiki/Home/") (synopsis "Image viewer for comics") (description "MComix is a customizable image viewer that specializes as -- 2.34.0 --=-=-= Content-Type: text/plain -- --=-=-=--