GNU bug report logs - #54529
[PATCH] Added orca-lang package

Previous Next

Full log

Message #86 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christine Lemmer-Webber <cwebber <at> dustycloud.org>
To: Christopher Rodriguez <yewscion <at> gmail.com>
Cc: 54529 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#54529] Checking In
Date: Sat, 11 Jun 2022 13:55:00 -0400

Hello!  Checking in on this again.  If you give an updated version of
the patch, it can be merged I think.  With the commented out part, I'm
uncertain whether or not it was commented out because it's no longer
needed or because it was but you were debugging, based on what you've
said so that's the main concern I have.

Could you also use git format-patch for the next version you send?
That'll make it easy to apply!

Thanks!  Sorry for the delays on this review cycle!  It's busy here.
 - Christine

Christopher Rodriguez <yewscion <at> gmail.com> writes:

> [[PGP Signed Part:Undecided]]
>
> Christine Lemmer-Webber <cwebber <at> dustycloud.org> writes:
>
>> Christopher Rodriguez <yewscion <at> gmail.com> writes:
>>
>>> [[PGP Signed Part:Undecided]]
>>> Hello all,
>>>
>>> Just want to confirm if this is waiting on me for anything. Trying to stay on
>>> top of the issues I'm opening, as I'm planning to open more soon and don't want
>>> to pollute the queue with a bunch of forgotten issues.
>>>
>>> Is there anything else that needs done from my end concerning the above patch?
>>>
>>> Thanks for Your time!
>>
>> I've been overwhelmed with other things, but I did try the patch out and
>> it did work great.  Then I got overwhelmed again.  ;P
>>
>> I think I made a suggestion about the moving the binary name after
>> install bit.  Did you / could you give that a try?
>
> Hi Christine!
>
> I did give it a try, and it worked! I actually decided to do it after
> the build step, before the install.
>
> The above patch should have the updated version, though I do notice now
> (upon reading through it again) that it includes a rather large section
> I had commented out during debugging.
>
> I'll remove that and send a revised patch tonight; With the package name issue
> out of the way I believe this /should/ be ready to merge.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.