GNU bug report logs - #54525
[patchs] Let thunar support plugin search patchs and add some thunar plugins.

Previous Next

Full log

Message #27 received at 54525 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: tumashu <at> 163.com
Cc: 54525 <at> debbugs.gnu.org
Subject: Re: bug#54525: [patchs] Let thunar support plugin search patchs and
 add some thunar plugins.
Date: Tue, 29 Mar 2022 11:45:20 +0200

Hi,

tumashu <at> 163.com skribis:

> From: Feng Shu <tumashu <at> 163.com>
>
> * gnu/packages/xfce.scm (thunar)[native-search-paths]: new field.
> [source]: Add thunar-search-paths.patch.

Please add the patch to gnu/local.mk.

> +++ b/gnu/packages/patches/thunar-search-paths.patch
> @@ -0,0 +1,211 @@
> +From 848f1dfb2d2f404efa5371817285236d33b32a5c Mon Sep 17 00:00:00 2001
> +From: tumashu <tumashu <at> 163.com>
> +Date: Tue, 22 Mar 2022 20:16:19 +0000
> +Subject: [PATCH] Look for thunar plugins at $THUNARX_DIRS (Issue #748)
> +
> +THUNARX_DIRS is a list of directories where thunar plugins are looked
> +for. It is needed for distributions like NixOS/GuixOS that do not
> +install all plugins in the same directory. In NixOS/GuixOS each
> +package is installed in a self contained directory.
> +
> +MR !197

There is no such thing as “GuixOS”, it’s called “Guix System”.  :-)

Is this going to be included upstream?  If yes, could you add the URL of
the upstream discussion or merge request?

(If it’s not included upstream, I would suggest “THUNARX_PLUGIN_PATH” or
“THUNARX_PLUGIN_DIRECTORIES” for the environment variable name.)

Apart from that, this patch and the previous ones LGTM.

Could you send a v2 based on that?

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.