GNU bug report logs - #54521
[PATCH] dircolors: colorize backup files with bright black

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54521 in the body.
You can then email your comments to 54521 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ville Skyttä <ville.skytta <at> iki.fi>
To: bug-coreutils <at> gnu.org
Subject: [PATCH] dircolors: colorize backup files with bright black
Date: Tue, 22 Mar 2022 20:24:27 +0200

Useful as it makes them stand out less than non-backup files.
---
 src/dircolors.hin | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/src/dircolors.hin b/src/dircolors.hin
index 673835201..6dc5a2d74 100644
--- a/src/dircolors.hin
+++ b/src/dircolors.hin
@@ -211,5 +211,24 @@ EXEC 01;32
 .spx 00;36
 .xspf 00;36
 
+# backup files
+*~ 00;90
+*# 00;90
+.bak 00;90
+.old 00;90
+.orig 00;90
+.part 00;90
+.rej 00;90
+.swp 00;90
+.tmp 00;90
+.dpkg-dist 00;90
+.dpkg-old 00;90
+.ucf-dist 00;90
+.ucf-new 00;90
+.ucf-old 00;90
+.rpmnew 00;90
+.rpmorig 00;90
+.rpmsave 00;90
+
 # Subsequent TERM or COLORTERM entries, can be used to add / override
 # config specific to those matching environment variables.
-- 
2.25.1

Message #8 received at 54521 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Ville Skyttä <ville.skytta <at> iki.fi>, 54521 <at> debbugs.gnu.org
Subject: Re: bug#54521: [PATCH] dircolors: colorize backup files with bright
 black
Date: Wed, 23 Mar 2022 23:53:57 +0000

On 22/03/2022 18:24, Ville Skyttä wrote:
> Useful as it makes them stand out less than non-backup files.
> ---
>   src/dircolors.hin | 19 +++++++++++++++++++
>   1 file changed, 19 insertions(+)
> 
> diff --git a/src/dircolors.hin b/src/dircolors.hin
> index 673835201..6dc5a2d74 100644
> --- a/src/dircolors.hin
> +++ b/src/dircolors.hin
> @@ -211,5 +211,24 @@ EXEC 01;32
>   .spx 00;36
>   .xspf 00;36
>   
> +# backup files
> +*~ 00;90
> +*# 00;90
> +.bak 00;90
> +.old 00;90
> +.orig 00;90
> +.part 00;90
> +.rej 00;90
> +.swp 00;90
> +.tmp 00;90
> +.dpkg-dist 00;90
> +.dpkg-old 00;90
> +.ucf-dist 00;90
> +.ucf-new 00;90
> +.ucf-old 00;90
> +.rpmnew 00;90
> +.rpmorig 00;90
> +.rpmsave 00;90
> +
>   # Subsequent TERM or COLORTERM entries, can be used to add / override
>   # config specific to those matching environment variables.

I quite like that actually.
The default coloring works well on both dark and light backgrounds.
Coloring this class of files does seem useful.

+1 from me anyway.

thanks,
Pádraig

Message #13 received at 54521-done <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Ville Skyttä <ville.skytta <at> iki.fi>,
 54521-done <at> debbugs.gnu.org
Subject: Re: bug#54521: [PATCH] dircolors: colorize backup files with bright
 black
Date: Sun, 3 Apr 2022 21:24:41 +0100

On 23/03/2022 23:53, Pádraig Brady wrote:
> On 22/03/2022 18:24, Ville Skyttä wrote:
>> Useful as it makes them stand out less than non-backup files.
>> ---
>>    src/dircolors.hin | 19 +++++++++++++++++++
>>    1 file changed, 19 insertions(+)
>>
>> diff --git a/src/dircolors.hin b/src/dircolors.hin
>> index 673835201..6dc5a2d74 100644
>> --- a/src/dircolors.hin
>> +++ b/src/dircolors.hin
>> @@ -211,5 +211,24 @@ EXEC 01;32
>>    .spx 00;36
>>    .xspf 00;36
>>    
>> +# backup files
>> +*~ 00;90
>> +*# 00;90
>> +.bak 00;90
>> +.old 00;90
>> +.orig 00;90
>> +.part 00;90
>> +.rej 00;90
>> +.swp 00;90
>> +.tmp 00;90
>> +.dpkg-dist 00;90
>> +.dpkg-old 00;90
>> +.ucf-dist 00;90
>> +.ucf-new 00;90
>> +.ucf-old 00;90
>> +.rpmnew 00;90
>> +.rpmorig 00;90
>> +.rpmsave 00;90
>> +
>>    # Subsequent TERM or COLORTERM entries, can be used to add / override
>>    # config specific to those matching environment variables.
> 
> I quite like that actually.
> The default coloring works well on both dark and light backgrounds.
> Coloring this class of files does seem useful.
> 
> +1 from me anyway.

I've pushed this after some perf testing showing it had negligible perf impact.
https://git.sv.gnu.org/cgit/coreutils.git/commit/?id=52aeae2c3

Here is a small example of the output:
https://www.pixelbeat.org/patches/coreutils/ls-backup-colors.html

cheers,
Pádraig

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.