From unknown Sat Sep 06 02:03:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#54481 <54481@debbugs.gnu.org> To: bug#54481 <54481@debbugs.gnu.org> Subject: Status: 29.0.50; [PATCH] Rewrite hl-line Reply-To: bug#54481 <54481@debbugs.gnu.org> Date: Sat, 06 Sep 2025 09:03:41 +0000 retitle 54481 29.0.50; [PATCH] Rewrite hl-line reassign 54481 emacs submitter 54481 dick severity 54481 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 12:07:33 2022 Received: (at submit) by debbugs.gnu.org; 20 Mar 2022 16:07:33 +0000 Received: from localhost ([127.0.0.1]:35054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVy5b-0006BI-55 for submit@debbugs.gnu.org; Sun, 20 Mar 2022 12:07:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:45832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVxrG-0005m4-82 for submit@debbugs.gnu.org; Sun, 20 Mar 2022 11:52:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVxrF-0002HK-UG for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2022 11:52:42 -0400 Received: from [2607:f8b0:4864:20::f31] (port=36512 helo=mail-qv1-xf31.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVxrC-0003Qa-A2 for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2022 11:52:41 -0400 Received: by mail-qv1-xf31.google.com with SMTP id kc20so6122616qvb.3 for ; Sun, 20 Mar 2022 08:52:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version; bh=5T+XW82BNZdyMrDBpb8aZB67aikWXCwDniESYTnWgd4=; b=q1LXa4XgWm7a99+GcjCoXkdM7WbVDuXDqEVqnX8jp10WiniPRTfbEAgkklno+UJ/9Y v/uSVBCES+V9Z9mlKQFwvn30r5F5NyUXhbRjpcOBjeXUPOB5gn+VApbQtdxnk6wOT+qY c87+vipzONRp0FHZOyx+e5hd6UCvnD0GbeQvXyyDOmkjI/GvRlvt6DYP7+ZxzyDGUBhd iRnTcgiDxQgXAssBdbdPeHwDE+dghB2Yn5MQwNOmgIRL4RCJFEk5GW4rDskI9FS/JFmK 7C1Gj8FHntwHairNKmi+mi/fVM1tb4mpwY134JK4CWiXj1cmzgI+mr66iASF79ffANQW Nhcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=5T+XW82BNZdyMrDBpb8aZB67aikWXCwDniESYTnWgd4=; b=sfwd1FFHtDX1iPRL0NVArc+IGqp77tVq4HWzdhZHf+zcAOsu+IA8Fmqi9TknGVxWP0 eQjCPn7rHuSZ9fCcfk9p0DJPvjgvqYiV4XAAmpe+IYbIvGYnybAvD/EzmF6bpSoVLlsk HkMGyNG5DiVqwkwMkGK7ikelkw/Uep3v82iMaJU/ZhbEonBpcE55VK8bJLE276tVQiKd l5ZHOWGEKYcbZDxDES7b/iXsGYqzXDO+RRWCgcjGecA9i5XyisxjKHwt7HNL7NEr2cMc BJMa4fmWtACNql+JNMDrkyp2c8I1Zkc6mLftQ0XqNd86ik54DFpjd2P9D6TPE3MUtLst nHKg== X-Gm-Message-State: AOAM532QQG30PsPGMHxFtWLDgfu2yIXl1dSxTsRzKkY0cbkYs53wDHmu IbFHxtRvjOqanFpaAjHPTgz4ANuWeTI= X-Google-Smtp-Source: ABdhPJz0YPm0pesHu8OVyleec2d5ibF7OyouasEzthMLCaiabVr0jWu++nZxXox+VpITe9X2J/gr8g== X-Received: by 2002:a05:6214:c63:b0:441:2263:56c1 with SMTP id t3-20020a0562140c6300b00441226356c1mr1325192qvj.131.1647791556490; Sun, 20 Mar 2022 08:52:36 -0700 (PDT) Received: from localhost (pool-96-232-253-158.nycmny.fios.verizon.net. [96.232.253.158]) by smtp.gmail.com with ESMTPSA id f14-20020ac8068e000000b002dd1bc00eadsm9276163qth.93.2022.03.20.08.52.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 08:52:35 -0700 (PDT) From: dick To: bug-gnu-emacs Subject: 29.0.50; [PATCH] Rewrite hl-line Date: Sun, 20 Mar 2022 11:52:35 -0400 Message-ID: <877d8o8vuk.fsf@dick> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::f31 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::f31; envelope-from=dick.r.chiang@gmail.com; helo=mail-qv1-xf31.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 20 Mar 2022 12:07:29 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Rewrite-hl-line-mode.patch >From f61a14c16154e0a170e0b9b58851279e282face9 Mon Sep 17 00:00:00 2001 From: dickmao Date: Sun, 20 Mar 2022 11:34:56 -0400 Subject: [PATCH] Rewrite hl-line-mode The fashion of dual global and minor modes, each managing a replica of state, has long been outmoded by globalized minor modes (nee easy-mmode-define-global-mode) around the turn of the century. * lisp/calendar/todo-mode.el (todo-toggle-item-highlighting, todo-hl-line-range, todo-modes-set-2): Adapt to new hl-line-highlight-hook. * lisp/hl-line.el (hl-line-overlay): Rename hl-line--overlay. (global-hl-line-overlay, global-hl-line-overlays, global-hl-line-sticky-flag, hl-line-overlay-buffer, hl-line-range-function): Obsolesce. (hl-line--overlay): Erstwhile hl-line-overlay. (hl-line, hl-line-face): Consolidate. (hl-line-sticky-flag): Say less (Gen Z Hospital). (hl-line-overlay-priority): Make this a custom. (hl-line-highlight-hook): Prefer hook over specialized hl-line-range-function. (hl-line-mode): Say less (Gen Z Hospital). (hl-line-make-overlay): Remove (hl-line-highlight, hl-line-unhighlight): Rewrite. (hl-line-maybe-unhighlight): Remove. (hl-line-turn-on): Necessary for globalized minor mode. (global-hl-line-mode, global-hl-line-highlight, global-hl-line-highlight-all, global-hl-line-unhighlight, global-hl-line-maybe-unhighlight, global-hl-line-unhighlight-all): Prefer globalized minor mode. (hl-line-move, hl-line-unload-function): Remove. * test/lisp/calendar/todo-mode-tests.el (todo-test-item-highlighting, todo-test-done-items-separator06-bol, todo-test-done-items-separator06-eol, todo-test-done-items-separator07): Adapt to consolidated face. --- lisp/calendar/todo-mode.el | 11 +- lisp/hl-line.el | 297 ++++++-------------------- test/lisp/calendar/todo-mode-tests.el | 10 +- test/lisp/hl-line-tests.el | 51 +++++ 4 files changed, 123 insertions(+), 246 deletions(-) create mode 100644 test/lisp/hl-line-tests.el diff --git a/lisp/calendar/todo-mode.el b/lisp/calendar/todo-mode.el index 57fcd1b17e1..eed597a0337 100644 --- a/lisp/calendar/todo-mode.el +++ b/lisp/calendar/todo-mode.el @@ -1040,9 +1040,7 @@ todo-toggle-item-highlighting (eval-and-compile (require 'hl-line)) (when (memq major-mode '(todo-mode todo-archive-mode todo-filtered-items-mode)) - (if hl-line-mode - (hl-line-mode -1) - (hl-line-mode 1)))) + (hl-line-mode 'toggle))) (defvar todo--item-headers-hidden nil "Non-nil if item date-time headers in current buffer are hidden.") @@ -6676,9 +6674,8 @@ todo-modes-set-1 (defun todo-hl-line-range () "Make `todo-toggle-item-highlighting' highlight entire item." (save-excursion - (when (todo-item-end) - (cons (todo-item-start) - (todo-item-end))))) + (when (and (todo-item-end) hl-line--overlay) + (move-overlay hl-line--overlay (todo-item-start) (todo-item-end))))) (defun todo-modes-set-2 () "Make some settings that apply to multiple Todo modes." @@ -6686,7 +6683,7 @@ todo-modes-set-2 (setq buffer-read-only t) (setq-local todo--item-headers-hidden nil) (setq-local desktop-save-buffer 'todo-desktop-save-buffer) - (setq-local hl-line-range-function #'todo-hl-line-range)) + (add-hook 'hl-line-highlight-hook #'todo-hl-line-range nil t)) (defun todo-modes-set-3 () "Make some settings that apply to multiple Todo modes." diff --git a/lisp/hl-line.el b/lisp/hl-line.el index 8e60ddf6b07..daa24c4fbf3 100644 --- a/lisp/hl-line.el +++ b/lisp/hl-line.el @@ -24,274 +24,103 @@ ;;; Commentary: -;; Provides a local minor mode (toggled by M-x hl-line-mode) and -;; a global minor mode (toggled by M-x global-hl-line-mode) to -;; highlight, on a suitable terminal, the line on which point is. The -;; global mode highlights the current line in the selected window only -;; (except when the minibuffer window is selected). This was -;; implemented to satisfy a request for a feature of Lesser Editors. -;; The local mode is sticky: it highlights the line about the buffer's -;; point even if the buffer's window is not selected. Caveat: the -;; buffer's point might be different from the point of a non-selected -;; window. Set the variable `hl-line-sticky-flag' to nil to make the -;; local mode behave like the global mode. - -;; You probably don't really want to use the global mode; if the -;; cursor is difficult to spot, try changing its color, relying on -;; `blink-cursor-mode' or both. The hookery used might affect -;; response noticeably on a slow machine. The local mode may be -;; useful in non-editing buffers such as Gnus or PCL-CVS though. - -;; An overlay is used. In the non-sticky cases, this overlay is -;; active only on the selected window. A hook is added to -;; `post-command-hook' to activate the overlay and move it to the line -;; about point. - -;; You could make variable `global-hl-line-mode' buffer-local and set -;; it to nil to avoid highlighting specific buffers, when the global -;; mode is used. - -;; By default the whole line is highlighted. The range of highlighting -;; can be changed by defining an appropriate function as the -;; buffer-local value of `hl-line-range-function'. - ;;; Code: -(defvar-local hl-line-overlay nil - "Overlay used by Hl-Line mode to highlight the current line.") +(make-obsolete-variable 'hl-line-overlay nil "29.1") +(make-obsolete-variable 'global-hl-line-overlay nil "29.1") +(make-obsolete-variable 'global-hl-line-overlays nil "29.1") +(make-obsolete-variable 'global-hl-line-sticky-flag nil "29.1") +(make-obsolete-variable 'hl-line-overlay-buffer nil "29.1") +(make-obsolete-variable 'hl-line-range-function nil "29.1") -(defvar-local global-hl-line-overlay nil - "Overlay used by Global-Hl-Line mode to highlight the current line.") +(defvar-local hl-line--overlay nil + "Keep state else scan entire buffer in `post-command-hook'.") -(defvar global-hl-line-overlays nil - "Overlays used by Global-Hl-Line mode in various buffers. -Global-Hl-Line keeps displaying one overlay in each buffer -when `global-hl-line-sticky-flag' is non-nil.") +;; 1. define-minor-mode creates buffer-local hl-line--overlay +;; 2. overlay wiped by kill-all-local-variables +;; 3. post-command-hook dupes overlay +;; Solution: prevent step 2. +(put 'hl-line--overlay 'permanent-local t) (defgroup hl-line nil "Highlight the current line." :version "21.1" :group 'convenience) -(defface hl-line - '((t :inherit highlight :extend t)) - "Default face for highlighting the current line in Hl-Line mode." +(defface hl-line-face '((t :inherit highlight :extend t)) + "Default face for highlighting the current line in hl-line-mode." :version "22.1" :group 'hl-line) -(defcustom hl-line-face 'hl-line - "Face with which to highlight the current line in Hl-Line mode." - :type 'face - :group 'hl-line - :set (lambda (symbol value) - (set symbol value) - (dolist (buffer (buffer-list)) - (with-current-buffer buffer - (when (overlayp hl-line-overlay) - (overlay-put hl-line-overlay 'face hl-line-face)))) - (when (overlayp global-hl-line-overlay) - (overlay-put global-hl-line-overlay 'face hl-line-face)))) - (defcustom hl-line-sticky-flag t - "Non-nil means the HL-Line mode highlight appears in all windows. -Otherwise Hl-Line mode will highlight only in the selected -window. Setting this variable takes effect the next time you use -the command `hl-line-mode' to turn Hl-Line mode on. - -This variable has no effect in Global Highlight Line mode. -For that, use `global-hl-line-sticky-flag'." + "Non-nil to preserve highlighting overlay when focus leaves window." :type 'boolean :version "22.1" + :group 'hl-line + :set (lambda (symbol value) + (set-default symbol value) + (unless value + (let ((selected (window-buffer (selected-window)))) + (dolist (buffer (buffer-list)) + (unless (eq buffer selected) + (with-current-buffer buffer + (hl-line-unhighlight)))))))) + +(defcustom hl-line-overlay-priority -50 + "Priority used on the overlay used by hl-line." + :type 'integer + :version "22.1" :group 'hl-line) -(defcustom global-hl-line-sticky-flag nil - "Non-nil means the Global HL-Line mode highlight appears in all windows. -Otherwise Global Hl-Line mode will highlight only in the selected -window. Setting this variable takes effect the next time you use -the command `global-hl-line-mode' to turn Global Hl-Line mode on." - :type 'boolean - :version "24.1" +(defcustom hl-line-highlight-hook nil + "After hook for `hl-line-highlight'. +Currently used in calendar/todo-mode." + :type 'hook :group 'hl-line) -(defvar hl-line-range-function nil - "If non-nil, function to call to return highlight range. -The function of no args should return a cons cell; its car value -is the beginning position of highlight and its cdr value is the -end position of highlight in the buffer. -It should return nil if there's no region to be highlighted. - -This variable is expected to be made buffer-local by modes.") - -(defvar hl-line-overlay-buffer nil - "Most recently visited buffer in which Hl-Line mode is enabled.") - -(defvar hl-line-overlay-priority -50 - "Priority used on the overlay used by hl-line.") - ;;;###autoload (define-minor-mode hl-line-mode - "Toggle highlighting of the current line (Hl-Line mode). - -Hl-Line mode is a buffer-local minor mode. If -`hl-line-sticky-flag' is non-nil, Hl-Line mode highlights the -line about the buffer's point in all windows. Caveat: the -buffer's point might be different from the point of a -non-selected window. Hl-Line mode uses the function -`hl-line-highlight' on `post-command-hook' in this case. - -When `hl-line-sticky-flag' is nil, Hl-Line mode highlights the -line about point in the selected window only." + "Toggle highlighting of the current line." :group 'hl-line (if hl-line-mode (progn - ;; In case `kill-all-local-variables' is called. - (add-hook 'change-major-mode-hook #'hl-line-unhighlight nil t) (hl-line-highlight) - (setq hl-line-overlay-buffer (current-buffer)) + (add-hook 'change-major-mode-hook #'hl-line-unhighlight nil t) (add-hook 'post-command-hook #'hl-line-highlight nil t)) (remove-hook 'post-command-hook #'hl-line-highlight t) - (hl-line-unhighlight) - (remove-hook 'change-major-mode-hook #'hl-line-unhighlight t))) - -(defun hl-line-make-overlay () - (let ((ol (make-overlay (point) (point)))) - (overlay-put ol 'priority hl-line-overlay-priority) ;(bug#16192) - (overlay-put ol 'face hl-line-face) - ol)) - -(defun hl-line-highlight () - "Activate the Hl-Line overlay on the current line." - (if hl-line-mode ; Might be changed outside the mode function. - (progn - (unless (overlayp hl-line-overlay) - (setq hl-line-overlay (hl-line-make-overlay))) ; To be moved. - (overlay-put hl-line-overlay - 'window (unless hl-line-sticky-flag (selected-window))) - (hl-line-move hl-line-overlay) - (hl-line-maybe-unhighlight)) - (hl-line-unhighlight))) + (remove-hook 'change-major-mode-hook #'hl-line-unhighlight t) + (let (hl-line-sticky-flag) + (hl-line-unhighlight)))) (defun hl-line-unhighlight () - "Deactivate the Hl-Line overlay on the current line." - (when (overlayp hl-line-overlay) - (delete-overlay hl-line-overlay) - (setq hl-line-overlay nil))) + (unless hl-line-sticky-flag + (when hl-line--overlay + (delete-overlay hl-line--overlay) + (setq hl-line--overlay nil)))) -(defun hl-line-maybe-unhighlight () - "Maybe deactivate the Hl-Line overlay on the current line. -Specifically, when `hl-line-sticky-flag' is nil deactivate all -such overlays in all buffers except the current one." - (let ((hlob hl-line-overlay-buffer) - (curbuf (current-buffer))) - (when (and (buffer-live-p hlob) - (not hl-line-sticky-flag) - (not (eq curbuf hlob)) - (not (minibufferp))) - (with-current-buffer hlob - (hl-line-unhighlight))) - (when (and (overlayp hl-line-overlay) - (eq (overlay-buffer hl-line-overlay) curbuf)) - (setq hl-line-overlay-buffer curbuf)))) +(defun hl-line-highlight () + (unless (minibufferp) + (unless hl-line--overlay + (setq hl-line--overlay + (let ((ol (make-overlay (point) (point)))) + (prog1 ol + (overlay-put ol 'priority hl-line-overlay-priority) + (overlay-put ol 'face 'hl-line-face))))) + (move-overlay hl-line--overlay + (line-beginning-position) + (line-beginning-position 2)) + (run-hooks 'hl-line-highlight-hook))) + +(defun hl-line-turn-on () + (unless (minibufferp) + (let (inhibit-quit) + (hl-line-mode 1)))) ;;;###autoload -(define-minor-mode global-hl-line-mode - "Toggle line highlighting in all buffers (Global Hl-Line mode). - -If `global-hl-line-sticky-flag' is non-nil, Global Hl-Line mode -highlights the line about the current buffer's point in all live -windows. - -Global-Hl-Line mode uses the function `global-hl-line-highlight' -on `post-command-hook'." - :global t +(define-globalized-minor-mode global-hl-line-mode + hl-line-mode hl-line-turn-on :group 'hl-line - (if global-hl-line-mode - (progn - ;; In case `kill-all-local-variables' is called. - (add-hook 'change-major-mode-hook #'global-hl-line-unhighlight) - (global-hl-line-highlight-all) - (add-hook 'post-command-hook #'global-hl-line-highlight)) - (global-hl-line-unhighlight-all) - (remove-hook 'post-command-hook #'global-hl-line-highlight) - (remove-hook 'change-major-mode-hook #'global-hl-line-unhighlight))) - -(defun global-hl-line-highlight () - "Highlight the current line in the current window." - (when global-hl-line-mode ; Might be changed outside the mode function. - (unless (window-minibuffer-p) - (unless (overlayp global-hl-line-overlay) - (setq global-hl-line-overlay (hl-line-make-overlay))) ; To be moved. - (unless (member global-hl-line-overlay global-hl-line-overlays) - (push global-hl-line-overlay global-hl-line-overlays)) - (overlay-put global-hl-line-overlay 'window - (unless global-hl-line-sticky-flag - (selected-window))) - (hl-line-move global-hl-line-overlay) - (global-hl-line-maybe-unhighlight)))) - -(defun global-hl-line-highlight-all () - "Highlight the current line in all live windows." - (walk-windows (lambda (w) - (with-current-buffer (window-buffer w) - (global-hl-line-highlight))) - nil t)) - -(defun global-hl-line-unhighlight () - "Deactivate the Global-Hl-Line overlay on the current line." - (when (overlayp global-hl-line-overlay) - (delete-overlay global-hl-line-overlay) - (setq global-hl-line-overlay nil))) - -(defun global-hl-line-maybe-unhighlight () - "Maybe deactivate the Global-Hl-Line overlay on the current line. -Specifically, when `global-hl-line-sticky-flag' is nil deactivate -all such overlays in all buffers except the current one." - (mapc (lambda (ov) - (let ((ovb (overlay-buffer ov))) - (when (and (not global-hl-line-sticky-flag) - (bufferp ovb) - (not (eq ovb (current-buffer))) - (not (minibufferp))) - (with-current-buffer ovb - (global-hl-line-unhighlight))))) - global-hl-line-overlays)) - -(defun global-hl-line-unhighlight-all () - "Deactivate all Global-Hl-Line overlays." - (mapc (lambda (ov) - (let ((ovb (overlay-buffer ov))) - (when (bufferp ovb) - (with-current-buffer ovb - (global-hl-line-unhighlight))))) - global-hl-line-overlays) - (setq global-hl-line-overlays nil)) - -(defun hl-line-move (overlay) - "Move the Hl-Line overlay. -If `hl-line-range-function' is non-nil, move the OVERLAY to the position -where the function returns. If `hl-line-range-function' is nil, fill -the line including the point by OVERLAY." - (let (tmp b e) - (if hl-line-range-function - (setq tmp (funcall hl-line-range-function) - b (car tmp) - e (cdr tmp)) - (setq tmp t - b (line-beginning-position) - e (line-beginning-position 2))) - (if tmp - (move-overlay overlay b e) - (move-overlay overlay 1 1)))) - -(defun hl-line-unload-function () - "Unload the Hl-Line library." - (global-hl-line-mode -1) - (save-current-buffer - (dolist (buffer (buffer-list)) - (set-buffer buffer) - (when hl-line-mode (hl-line-mode -1)))) - ;; continue standard unloading - nil) + :version "29.1") (provide 'hl-line) diff --git a/test/lisp/calendar/todo-mode-tests.el b/test/lisp/calendar/todo-mode-tests.el index 0102b62c10f..8715a32b883 100644 --- a/test/lisp/calendar/todo-mode-tests.el +++ b/test/lisp/calendar/todo-mode-tests.el @@ -130,8 +130,8 @@ todo-test-item-highlighting (todo-toggle-item-highlighting) (let ((end (1- (todo-item-end))) (beg (todo-item-start))) - (should (eq (get-char-property beg 'face) 'hl-line)) - (should (eq (get-char-property end 'face) 'hl-line)) + (should (eq (get-char-property beg 'face) 'hl-line-face)) + (should (eq (get-char-property end 'face) 'hl-line-face)) (should (> (count-lines beg end) 1)) (should (eq (next-single-char-property-change beg 'face) (1+ end)))) (todo-toggle-item-highlighting))) ; Turn off highlighting (for test rerun). @@ -736,7 +736,7 @@ todo-test-done-items-separator06-bol (todo-test--done-items-separator) (call-interactively #'todo-toggle-item-highlighting) (ert-simulate-command '(todo-previous-item)) - (should (eq 'hl-line (get-char-property (point) 'face))))) + (should (eq 'hl-line-face (get-char-property (point) 'face))))) (ert-deftest todo-test-done-items-separator06-eol () ; bug#32343 "Test enabling item highlighting at EOL of done items separator. @@ -746,7 +746,7 @@ todo-test-done-items-separator06-eol (todo-toggle-item-highlighting) (forward-line -1) (ert-simulate-command '(todo-previous-item)) - (should (eq 'hl-line (get-char-property (point) 'face))))) + (should (eq 'hl-line-face (get-char-property (point) 'face))))) (ert-deftest todo-test-done-items-separator07 () ; bug#32343 "Test item highlighting when crossing done items separator. @@ -758,7 +758,7 @@ todo-test-done-items-separator07 (todo-next-item) ; Now on empty line above separator. (forward-line) ; Now on separator. (ert-simulate-command '(forward-line)) ; Now on first done item. - (should (eq 'hl-line (get-char-property (point) 'face))))) + (should (eq 'hl-line-face (get-char-property (point) 'face))))) (ert-deftest todo-test-current-file-in-edit-mode () ; bug#32437 "Test the value of todo-current-todo-file in todo-edit-mode." diff --git a/test/lisp/hl-line-tests.el b/test/lisp/hl-line-tests.el new file mode 100644 index 00000000000..422d4ddae7d --- /dev/null +++ b/test/lisp/hl-line-tests.el @@ -0,0 +1,51 @@ +;;; hl-line-tests.el --- Test suite for hl-line. -*- lexical-binding: t -*- + +;; Copyright (C) 2022 Free Software Foundation, Inc. + +;; This file is part of GNU Emacs. + +;; GNU Emacs is free software: you can redistribute it and/or modify +;; it under the terms of the GNU General Public License as published by +;; the Free Software Foundation, either version 3 of the License, or +;; (at your option) any later version. + +;; GNU Emacs is distributed in the hope that it will be useful, +;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;; GNU General Public License for more details. + +;; You should have received a copy of the GNU General Public License +;; along with GNU Emacs. If not, see . + +;;; Code: +(require 'ert) +(require 'hl-line) + +(ert-deftest hl-line-sticky () + (should hl-line-sticky-flag) + (with-temp-buffer + (let ((from-buffer (current-buffer))) + (hl-line-mode 1) + (save-excursion + (insert "foo")) + (hl-line-highlight) + (should (cl-some (apply-partially #'eq hl-line--overlay) + (overlays-at (point)))) + (switch-to-buffer (get-buffer-create "*scratch*")) + (hl-line-mode 1) + (save-excursion + (insert "bar")) + (hl-line-highlight) + (should (cl-some (apply-partially #'eq hl-line--overlay) + (overlays-at (point)))) + (should (buffer-local-value 'hl-line--overlay from-buffer)) + (should-not (eq (buffer-local-value 'hl-line--overlay from-buffer) + hl-line--overlay)) + (customize-set-variable 'hl-line-sticky-flag nil) + (should hl-line--overlay) + (should (buffer-live-p from-buffer)) + (should-not (buffer-local-value 'hl-line--overlay from-buffer))))) + +(provide 'hl-line-tests) + +;;; hl-line-tests.el ends here -- 2.26.2 --=-=-= Content-Type: text/plain In Commercial Emacs 0.3.1snapshot 3de8c3d in master (upstream 29.0.50, x86_64-pc-linux-gnu) built on dick Repository revision: 3de8c3da89e822c59ff7fd582cd454bd122e421f Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12013000 System Description: Ubuntu 20.04.3 LTS Configured using: 'configure --prefix=/home/dick/.local --with-tree-sitter --enable-dumping-overwrite 'CFLAGS=-g3 -O2 -I/home/dick/.local/include/' LDFLAGS=-L/home/dick/.local/lib' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON TREE_SITTER LCMS2 LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Magit Log Minor modes in effect: global-git-commit-mode: t magit-auto-revert-mode: t shell-dirtrack-mode: t global-hl-line-mode: t hl-line-mode: t global-auto-revert-mode: t projectile-mode: t flx-ido-mode: t override-global-mode: t winner-mode: t tooltip-mode: t show-paren-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/dick/gomacro-mode/gomacro-mode hides /home/dick/.emacs.d/elpa/gomacro-mode-20200326.1103/gomacro-mode /home/dick/.emacs.d/elpa/magit-3.3.0snapshot/magit-section-pkg hides /home/dick/.emacs.d/elpa/magit-section-3.3.0snapshot/magit-section-pkg /home/dick/org-gcal.el/org-gcal hides /home/dick/.emacs.d/elpa/org-gcal-0.3/org-gcal /home/dick/.emacs.d/elpa/chess-2.0.5/_pkg hides /home/dick/.local/share/emacs/site-lisp/_pkg /home/dick/.emacs.d/elpa/chess-2.0.5/chess-pos hides /home/dick/.local/share/emacs/site-lisp/chess-pos /home/dick/.emacs.d/elpa/chess-2.0.5/chess-module hides /home/dick/.local/share/emacs/site-lisp/chess-module /home/dick/.emacs.d/elpa/chess-2.0.5/chess-ucb hides /home/dick/.local/share/emacs/site-lisp/chess-ucb /home/dick/.emacs.d/elpa/chess-2.0.5/chess-scid hides /home/dick/.local/share/emacs/site-lisp/chess-scid /home/dick/.emacs.d/elpa/chess-2.0.5/chess-puzzle hides /home/dick/.local/share/emacs/site-lisp/chess-puzzle /home/dick/.emacs.d/elpa/chess-2.0.5/chess-irc hides /home/dick/.local/share/emacs/site-lisp/chess-irc /home/dick/.emacs.d/elpa/chess-2.0.5/chess-network hides /home/dick/.local/share/emacs/site-lisp/chess-network /home/dick/.emacs.d/elpa/chess-2.0.5/chess-autosave hides /home/dick/.local/share/emacs/site-lisp/chess-autosave /home/dick/.emacs.d/elpa/chess-2.0.5/chess-engine hides /home/dick/.local/share/emacs/site-lisp/chess-engine /home/dick/.emacs.d/elpa/chess-2.0.5/chess-tutorial hides /home/dick/.local/share/emacs/site-lisp/chess-tutorial /home/dick/.emacs.d/elpa/chess-2.0.5/chess-german hides /home/dick/.local/share/emacs/site-lisp/chess-german /home/dick/.emacs.d/elpa/chess-2.0.5/chess-file hides /home/dick/.local/share/emacs/site-lisp/chess-file /home/dick/.emacs.d/elpa/chess-2.0.5/chess-random hides /home/dick/.local/share/emacs/site-lisp/chess-random /home/dick/.emacs.d/elpa/chess-2.0.5/chess-stockfish hides /home/dick/.local/share/emacs/site-lisp/chess-stockfish /home/dick/.emacs.d/elpa/chess-2.0.5/chess-pgn hides /home/dick/.local/share/emacs/site-lisp/chess-pgn /home/dick/.emacs.d/elpa/chess-2.0.5/chess-kibitz hides /home/dick/.local/share/emacs/site-lisp/chess-kibitz /home/dick/.emacs.d/elpa/chess-2.0.5/chess-eco hides /home/dick/.local/share/emacs/site-lisp/chess-eco /home/dick/.emacs.d/elpa/chess-2.0.5/chess-display hides /home/dick/.local/share/emacs/site-lisp/chess-display /home/dick/.emacs.d/elpa/chess-2.0.5/chess-var hides /home/dick/.local/share/emacs/site-lisp/chess-var /home/dick/.emacs.d/elpa/chess-2.0.5/chess-test hides /home/dick/.local/share/emacs/site-lisp/chess-test /home/dick/.emacs.d/elpa/chess-2.0.5/chess-ply hides /home/dick/.local/share/emacs/site-lisp/chess-ply /home/dick/.emacs.d/elpa/chess-2.0.5/chess-message hides /home/dick/.local/share/emacs/site-lisp/chess-message /home/dick/.emacs.d/elpa/chess-2.0.5/chess-ics1 hides /home/dick/.local/share/emacs/site-lisp/chess-ics1 /home/dick/.emacs.d/elpa/chess-2.0.5/chess-phalanx hides /home/dick/.local/share/emacs/site-lisp/chess-phalanx /home/dick/.emacs.d/elpa/chess-2.0.5/chess-game hides /home/dick/.local/share/emacs/site-lisp/chess-game /home/dick/.emacs.d/elpa/chess-2.0.5/chess-log hides /home/dick/.local/share/emacs/site-lisp/chess-log /home/dick/.emacs.d/elpa/chess-2.0.5/chess-plain hides /home/dick/.local/share/emacs/site-lisp/chess-plain /home/dick/.emacs.d/elpa/chess-2.0.5/chess-perft hides /home/dick/.local/share/emacs/site-lisp/chess-perft /home/dick/.emacs.d/elpa/chess-2.0.5/chess-glaurung hides /home/dick/.local/share/emacs/site-lisp/chess-glaurung /home/dick/.emacs.d/elpa/chess-2.0.5/chess-ai hides /home/dick/.local/share/emacs/site-lisp/chess-ai /home/dick/.emacs.d/elpa/chess-2.0.5/chess-fruit hides /home/dick/.local/share/emacs/site-lisp/chess-fruit /home/dick/.emacs.d/elpa/chess-2.0.5/chess-uci hides /home/dick/.local/share/emacs/site-lisp/chess-uci /home/dick/.emacs.d/elpa/chess-2.0.5/chess-epd hides /home/dick/.local/share/emacs/site-lisp/chess-epd /home/dick/.emacs.d/elpa/chess-2.0.5/chess-database hides /home/dick/.local/share/emacs/site-lisp/chess-database /home/dick/.emacs.d/elpa/chess-2.0.5/chess-link hides /home/dick/.local/share/emacs/site-lisp/chess-link /home/dick/.emacs.d/elpa/chess-2.0.5/chess-transport hides /home/dick/.local/share/emacs/site-lisp/chess-transport /home/dick/.emacs.d/elpa/chess-2.0.5/chess-none hides /home/dick/.local/share/emacs/site-lisp/chess-none /home/dick/.emacs.d/elpa/chess-2.0.5/chess-polyglot hides /home/dick/.local/share/emacs/site-lisp/chess-polyglot /home/dick/.emacs.d/elpa/chess-2.0.5/chess-crafty hides /home/dick/.local/share/emacs/site-lisp/chess-crafty /home/dick/.emacs.d/elpa/chess-2.0.5/chess-chat hides /home/dick/.local/share/emacs/site-lisp/chess-chat /home/dick/.emacs.d/elpa/chess-2.0.5/chess hides /home/dick/.local/share/emacs/site-lisp/chess /home/dick/.emacs.d/elpa/chess-2.0.5/chess-images hides /home/dick/.local/share/emacs/site-lisp/chess-images /home/dick/.emacs.d/elpa/chess-2.0.5/chess-gnuchess hides /home/dick/.local/share/emacs/site-lisp/chess-gnuchess /home/dick/.emacs.d/elpa/chess-2.0.5/chess-fen hides /home/dick/.local/share/emacs/site-lisp/chess-fen /home/dick/.emacs.d/elpa/chess-2.0.5/chess-ics hides /home/dick/.local/share/emacs/site-lisp/chess-ics /home/dick/.emacs.d/elpa/chess-2.0.5/chess-ics2 hides /home/dick/.local/share/emacs/site-lisp/chess-ics2 /home/dick/.emacs.d/elpa/chess-2.0.5/chess-common hides /home/dick/.local/share/emacs/site-lisp/chess-common /home/dick/.emacs.d/elpa/chess-2.0.5/chess-input hides /home/dick/.local/share/emacs/site-lisp/chess-input /home/dick/.emacs.d/elpa/chess-2.0.5/chess-announce hides /home/dick/.local/share/emacs/site-lisp/chess-announce /home/dick/.emacs.d/elpa/chess-2.0.5/chess-clock hides /home/dick/.local/share/emacs/site-lisp/chess-clock /home/dick/.emacs.d/elpa/chess-2.0.5/chess-sound hides /home/dick/.local/share/emacs/site-lisp/chess-sound /home/dick/.emacs.d/elpa/chess-2.0.5/chess-sjeng hides /home/dick/.local/share/emacs/site-lisp/chess-sjeng /home/dick/.emacs.d/elpa/chess-2.0.5/chess-algebraic hides /home/dick/.local/share/emacs/site-lisp/chess-algebraic /home/dick/.emacs.d/elpa/transient-0.3.7snapshot/transient hides /home/dick/.local/share/emacs/0.3.1/lisp/transient Features: (shadow sort footnote mail-extr gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum shr pixel-fill kinsoku url-file url-dired svg dom gnus-group mm-url gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range gnus-win emacsbug git-rebase mule-util misearch multi-isearch magit-extras blamer a benchmark face-remap magit-patch-changelog magit-patch magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode diff git-commit log-edit message sendmail yank-media rmc puny dired-x dired dired-loaddefs rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader pcvs-util add-log magit-core magit-autorevert magit-margin magit-transient magit-process with-editor server magit-mode transient magit-git magit-base magit-section crm dash tramp-archive tramp-gvfs tramp-cache zeroconf dbus xml tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat shell pcomplete parse-time iso8601 ls-lisp format-spec vc-git diff-mode vc-dispatcher bug-reference cl-print help-fns radix-tree cus-start hl-line paredit-ext paredit autorevert filenotify subed subed-vtt subed-srt subed-common subed-mpv subed-debug subed-config inf-ruby ruby-mode smie company pcase haskell-interactive-mode haskell-presentation-mode haskell-process haskell-session haskell-compile haskell-mode haskell-cabal haskell-utils haskell-font-lock haskell-indentation haskell-string haskell-sort-imports haskell-lexeme rx haskell-align-imports haskell-complete-module haskell-ghc-support noutline outline flymake-proc flymake warnings etags fileloop generator xref project dabbrev haskell-customize hydra lv use-package-ensure solarized-theme solarized-definitions projectile lisp-mnt ibuf-ext ibuffer ibuffer-loaddefs thingatpt grep compile comint ansi-color gnus nnheader range mail-utils mm-util mail-prsvr gnus-util text-property-search time-date flx-ido flx google-translate-default-ui google-translate-core-ui facemenu color ido google-translate-core google-translate-tk google-translate-backend use-package-bind-key bind-key auto-complete easy-mmode advice edmacro kmacro popup cus-edit pp cus-load wid-edit emms-player-mplayer emms-player-simple emms emms-compat cl-extra help-mode use-package-core derived winner ring json-reformat-autoloads json-snatcher-autoloads finder-inf sml-mode-autoloads tornado-template-mode-autoloads info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars seq gv subr-x byte-opt bytecomp byte-compile cconv cldefs cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tree-sitter tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice simple cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray cl-preloaded button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 523472 27767) (symbols 48 32537 8) (strings 32 135993 4809) (string-bytes 1 4138773) (vectors 16 61479) (vector-slots 8 948205 17573) (floats 8 455 1428) (intervals 56 5390 3902) (buffers 992 23)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 21 11:09:43 2022 Received: (at 54481) by debbugs.gnu.org; 21 Mar 2022 15:09:43 +0000 Received: from localhost ([127.0.0.1]:37851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWJfD-0008Er-M0 for submit@debbugs.gnu.org; Mon, 21 Mar 2022 11:09:43 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWJfC-0008Eb-2f for 54481@debbugs.gnu.org; Mon, 21 Mar 2022 11:09:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Vul8bIYIab1EWEFfGAxcUO4LHh6vD5JaRIiQK6LWE9w=; b=jjp2iVnPOZalBxtVkRv2jGheoV m2OlEz9yraTYD7+0zmJjVxwF32s8MkyVW1tzkMhO07eIIIvIVPHkD1NBgXemoU7dLpw7Z0MjmgVpo 2vwjzx+wYWYOOxYVr9yF2KMsf0WTwsY+avOtZcW7yPUIN58XPYVDJRlA2eVLajLV9R1c=; Received: from 109.179.236.69.tmi.telenormobil.no ([109.179.236.69] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWJf3-0000E3-RX; Mon, 21 Mar 2022 16:09:35 +0100 From: Lars Ingebrigtsen To: dick Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line References: <877d8o8vuk.fsf@dick> Date: Mon, 21 Mar 2022 16:09:32 +0100 In-Reply-To: <877d8o8vuk.fsf@dick> (dick's message of "Sun, 20 Mar 2022 11:52:35 -0400") Message-ID: <87y213mjf7.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: dick writes: > The fashion of dual global and minor modes, each managing a replica of > state, has long been outmoded by globalized minor modes (nee > easy-mmode-define-global-mode) around the turn of the century. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54481 Cc: 54481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) dick writes: > The fashion of dual global and minor modes, each managing a replica of > state, has long been outmoded by globalized minor modes (nee > easy-mmode-define-global-mode) around the turn of the century. Makes sense to me, so I've applied the patch to Emacs 29. The one thing I was unsure about was things like this: > -(defun hl-line-unload-function () > - "Unload the Hl-Line library." We normally don't remove functions like this, but just make them obsolete. But in this case it seems unlikely to me that anybody would actually ever use these functions, so I didn't alter that part. But if anybody complains, we should take them the normal obsoletion route. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 21 11:09:47 2022 Received: (at control) by debbugs.gnu.org; 21 Mar 2022 15:09:47 +0000 Received: from localhost ([127.0.0.1]:37854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWJfG-0008F8-TF for submit@debbugs.gnu.org; Mon, 21 Mar 2022 11:09:47 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWJfF-0008Eg-U9 for control@debbugs.gnu.org; Mon, 21 Mar 2022 11:09:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+7eua8UuEJ4pCIPGtTbA/8TVAPwSqaEOYqoHTGh19N4=; b=OxTjCc16LNfYduAs35GMG471/N uryxIus/fzwiajiuf1itRhYJAvJoYvXCP9FOuJUNwzZaL5PmiTV05kfxd9glA8YGztHA8HwOYc1ME DD8/NLHiusSkJ0946BYwH681iPSRWleS9e4ttBusdyy7zYfYnlfHs/JpBX2RrUUWkVhI=; Received: from 109.179.236.69.tmi.telenormobil.no ([109.179.236.69] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWJf8-0000EB-LP for control@debbugs.gnu.org; Mon, 21 Mar 2022 16:09:40 +0100 Date: Mon, 21 Mar 2022 16:09:37 +0100 Message-Id: <87wngnmjf2.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #54481 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 54481 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 54481 29.1 quit From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 21 20:26:14 2022 Received: (at 54481) by debbugs.gnu.org; 22 Mar 2022 00:26:14 +0000 Received: from localhost ([127.0.0.1]:38796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWSLl-0005qu-RW for submit@debbugs.gnu.org; Mon, 21 Mar 2022 20:26:14 -0400 Received: from sonic303-22.consmr.mail.ne1.yahoo.com ([66.163.188.148]:44102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWSLj-0005qe-JB for 54481@debbugs.gnu.org; Mon, 21 Mar 2022 20:26:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1647908765; bh=hukANVEOsm9SQHeH9S6QDkY022gVngl2nnnssESh9Iw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=tXuG/HbRmAubzvX25NgQV7jsp5FFI/PB/fQBzQj3pt6pH10kJY1YZ2XzcaG+xZyAUZiOt/jdjwSIVTi5lrTiN4CCACCoYrODEh3iUjEDjD06IIhqT/w5KOqLsKD7J+BoHfJX6bWDcoRg1skPK2Nsav8AIicWu/AJuSEJ2f2XR/NaLGojU6qpQOrjqnjSIwUuLmx2oUkI/cHxqU/Nahbw3sw/YflLRcFUOBWn6Ei+CaSIr0Wl4+o60xxer5nhgiQ5YXHl3knreIEgQA2OA5/ypT1h3F9PXiLA8jePn7bQkfxSnaft89GGFIWL+J8E5atfp6h/aV6ubF58UCTsKH+O7w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1647908765; bh=EGYnazsC/XlnEjZANrezbcNY+AhvupF26IYuQXi1u+f=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=uW07c/6O2dW29UhiLG4v3BIFoSKzvtkAKAQCdet+OUfAq5wkMrHwaI6rSED9/Tk3y6U30ENoGq+GCETnG2Xlpyz2QGvc/A5rRAEyvRI2wvi2FgX0EWMpm3ZGRlHosz5TennFYOD/jQJQueXfc+61pr9rnXHZobASl9koE2Xu1GUh++tFAxo0Ozy8D79DeFZ/FTwa0yfYnbb5dTnmjhskA+IM+kfbtoU4D4sTN+2GaRO3yaFPWH/TFWXRkB/Pysf1THmDVGrC2OcoDvM5G9TIj9Psny+E+s7oAEaRUlh4qpy53Wh7Yz0fZ1h1wvNsjUrzBNcvVTZDTwRGb9Sy05mnTA== X-YMail-OSG: 6wvqMKEVM1koe1fm2C4hcUMDa5xLT2ag5tpZXZMxNqwbsVS9V.R1..BUqKg40jP JyQz6vstCNut465IrKH2Yj0zrZDmlxba39CrjXItHahW0SlakuUnCV3sNAuF7R_q7q6hPtkochQq EWUPqkn21Ex_41.6jlApA61bxI0jXETyRJiIZ3EHGa6ysKa5rCk0444g5f.dHjd7GQRQVr8T4nlf 9nszgYfG.DNzX58TzEAkOuyU_G05hPmGfxAmvzHZhNZ14h.kx8Ghr09DY8uU4_FrUUaFRosy6Q2x G04vJp4E86WNp5ckvQTkQb8HEoGqEAhiSr0yrmGuQEAN6mHrisWEtwTURO5oHIDIPpIP4ycQaJ5x LXmIKKJoV7nXeP0M6pwbz3lrnwZig_iLlDLEUoMJmptGmU9VyN8kaJqy5hU7H.IX2fQPnQ4I6E0W Q97XnIBKSrJtm3m5EBqmybCuxdQY7QWIlMJ10PZO8z8yVk7uvo0H0yuqXCF3QyefKWxoirJV85Y1 grdENFs4gRS.O5q6oDRsBltQALUCRJIgxEFPEpqdsi_wzKgxsSkZtHvq59BGHoWs4WBHDyW8R02h 6PH6zLDB9CNlJvuJ_fRe4Gq8hCKCwYnqUhGVmnhe4VT7qbgXCT3yS4ZoO9WRS2YqMlUV3QAT1Wis HyxqgOOhXDy65Sueb.ZN8NyybQws2Zauj8.bCDaWGMiOVwzRg7KFOCYH0hzx3NatbZWDBwrUYQfa nDhziwABrE64hRT44cHgEid9kH7XWEXgL26Ao9mtxEmnskEme8Z38Xz4Dm9kezrSxyUqG6VmzwSp 0vQezrzrRkhQYNTUAM6PLDssUwRgdEugk.cMvYwmjj3GhiD3mk_WTwsEUCqA1ISsFf10X0e3ihPL cS4LrQ6Vhg1fS9vbQrdKMPgKkNEOSsiOk78zvBqeAMYMKQ3zIFZFnML93bG0ZHqBehKFsrmf6fL3 k1u3xpQ9hR0_GOazjEFOGASag0zGCo1RIVeQyX5.LStvhCfwLlm_1xdO.jOYDJ5RtUt4Chiy8RM8 cZ11ttOgnyXCf35Ks4m.Qt9kTL_jHkj2jK3wsdfWQBgbDWP5nCbHsi_5myzAU_7jHz48CalTHvzI eUizI8u_..MswKC54uskjA_YCYIe7YHsKgae1zm6VnEMzkPdGKfJtWDb8tjcBgzrlp89s08Gy3CE F6mJ2KLcr7P0LRQchW7iae3Z68ccVGfaoX2tffo_NM.N3i9uPY.IJd7VlGuFcmpCnyZIkYBg7q_8 dZ5oQJievXMzHg_Kq5y51GALjMg5Vu9Jo4xTbgKBIMDFX1wAgQT7N52qcC6X.n_kvkhRiKjHoMx_ uYOj_JROUN8gmOqp21hZzWVnM.9PfpfEn4DjyksOoTMdPA9s1VvcQjFTZsgAtUzjXBalIxYac7pd UFOl1eTfqbd_4utIhKpjdZkubSH1hsnjPkzU4jIKqMlF6jzFNdePWmcCMIP0dKR_hI12EruEyULk t5UTdo8bxybblSUl4nDOPJ5MebvklBSbs.SzdI1dRiEpmkccvaQ45iYrYOizTBKcsOoTmc2uO4K3 ssUFJ0y3IshFgMk6uPkVVOu1rh6MNs9y0VPQeNfX6Lcpk9AVNv40yhSblakasIVcNZunH2FvEdcq 0g2sr1focYiXVGfkKf6z3LKLdCl20wadaS7Ziu_iOD8TizzvnUPFlrr5.GtFduMqmu8SdwIRBNAL bZ3pkBp3GHwuwPJBDcW7v1SiwCLNFyJVL_QuOpj_ks3UxuPTmBF7T3LCpV0R.lxoVoyFUtvcz.7r NTxjYmaSZllMwbR6lQqP0sllKe610M1XhurGjXy4Z8tVVyaWrFCmY56il3kJuM_tKdzHBbxCNrBh FyjLmVSOh.1j2sAfZhiczNcFEDWR96rJVbCAoELfuuX0C88LS600Jfgbkt7s7VbedxzfJkB5xeJp Vq4NRQHPdvpoLqbmDzKkTij.tGe.5cJDNB6ERtWRqFWf0IDzbYJbd3tWN2tlEltnr5dEEXQMBvKq MBPQhm0wC4n2wKqc99JO.AJsDT8rKMgVQgUdiUSXF9nUE0YvST8NsrLcdOeiwh9N7XrMIZM9s65T yccEJDJKfQF8jg5Uol7gSwqmk6EjH.7zqMJQp_zzrfxi8._Bg6B0o1krRtTo.CYiDifUD9nuSAOm XBeNEJBTOdEzD_7Kw2OzLR.S6gR5G1B6uRPkfc3jnNCvE4K9TNOj6Ygvjv3pVKDZkBYAJOWPAyRf FhOaWs5MJVl4LBcrPjiUwrkUmWECbHj4EYlo6LUckuAZDaBNxFptD3ycLBPkT1A-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ne1.yahoo.com with HTTP; Tue, 22 Mar 2022 00:26:05 +0000 Received: by kubenode508.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID dad9534d43705fbea4a04e5e8462a03b; Tue, 22 Mar 2022 00:26:00 +0000 (UTC) From: Po Lu To: Lars Ingebrigtsen Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line References: <877d8o8vuk.fsf@dick> <87y213mjf7.fsf@gnus.org> Date: Tue, 22 Mar 2022 08:25:55 +0800 In-Reply-To: <87y213mjf7.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 21 Mar 2022 16:09:32 +0100") Message-ID: <87tubqkf3g.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19894 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1109 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54481 Cc: 54481@debbugs.gnu.org, dick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Makes sense to me, so I've applied the patch to Emacs 29. Now, ironically, that patch introduced at least two incompatible changes which are likely to affect users: `hl-line' is no longer a face, and `hl-line-face' (a variable) has been replaced by the face. Of course, with no updates to the version field, NEWS, or the documentation. I tried to fix it, but I might've missed something. > The one thing I was unsure about was things like this: > >> -(defun hl-line-unload-function () >> - "Unload the Hl-Line library." > > We normally don't remove functions like this, but just make them > obsolete. But in this case it seems unlikely to me that anybody would > actually ever use these functions, so I didn't alter that part. But if > anybody complains, we should take them the normal obsoletion route. With that change, unloading the hl-line feature leaves stray overlays around. Which I also fixed by restoring the old definition. This function is called by Emacs automatically when hl-line is unloaded, and is not for users to call anyway. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 21 23:14:09 2022 Received: (at 54481) by debbugs.gnu.org; 22 Mar 2022 03:14:09 +0000 Received: from localhost ([127.0.0.1]:38863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWUyH-0001dj-0Z for submit@debbugs.gnu.org; Mon, 21 Mar 2022 23:14:09 -0400 Received: from mout.web.de ([217.72.192.78]:36645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWUyE-0001d3-OC for 54481@debbugs.gnu.org; Mon, 21 Mar 2022 23:14:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1647918839; bh=ETybS9bDsasYLiG6QYgf7jX+7kK72a6dGDF0aqu3sSc=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=F7WHt3UAlqNfORgalH8aHbwKhTC257n6SVtNEUwS2Hl/Erfx8j+KU/hXJCMQoG2kM cVTFYVz0GDuCNl1gWTeE/ARUYm9XY9Qe6pqEK9BSiHXevUJD32A85PnGLXUP/LFimu 2wwjxljQvk33v/aZhb5SOPo+eIsQO+jsBQCUHst8= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.60.174.212]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1M7epr-1nQh8k3D8H-008DaR; Tue, 22 Mar 2022 04:13:59 +0100 From: Michael Heerdegen To: dick Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line References: <877d8o8vuk.fsf@dick> Date: Tue, 22 Mar 2022 04:13:58 +0100 In-Reply-To: <877d8o8vuk.fsf@dick> (dick's message of "Sun, 20 Mar 2022 11:52:35 -0400") Message-ID: <87lex2vfux.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:vKfv5cYz3PCatPuzcQgcvKozQyAB2X6RpSmGf0aqRXqEmGtAIRU ++hirfGJPV14ANtLKtMUB7Kia1Ghg4evnE07nZ7PJ9yzBkw3pVY5L7aGRM3X0m+MANCh40r Vbs5JFlRYjzzdvOtwCpzsHzxCVZ6H9ka8AjowRcw5nMMyqaa5s/sBj85KAjpdky4BsyIJRj poS4olSJ5HAr8iDS1HBMg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:TQF7bsgB7qk=:vN4bEgLQv2aYGEOOjcxX5k 6s6kMe4e6Rloal61HEMlpdD0MaPcQ9UQLV70F3kRVIiG7Yc5uYnclWiUBZVrItqSHUSr7efKY sdd3XSL03ioKGNiYeIIlRT52TFCiKae//n1V7X3wLec2B94/RZLynvDn/i4hjuY31y5BK3JBg QjvJ00UIn0nA5WSx1hJ7x0qTmk6SDGtD/xKELtAsR7j6+u0YbRIESfTYCpMf8tuDV9KBeJoW+ FYtnAwhHK8rcxbpvyXZobT6HD0h+QlovIoPs+E6Newe76gg+yIHSL/Brg3ZCWnojZpJCkd614 0AyHJi/BKqetWDsllK4UHb9DOyGBkg5JDPZ3dmgFRTMwMbj2R2jDyqPX6kh0lgoK+og1s+AZ+ UwCI/X9MZP+UEXqA4gNSif90REhdz7rfqDHqmWwDxeR5EUmrla0hKIpKyTRhyiwmBp/2i6YFC 7zcxCxvTLNCD0wHwqd96EmBaVYRNEccGLaLIrd1TN87qLjhC6uTjVCZysBoYQIjilJxW/C2ce a1lD5FfcpD/xjugZaM/SUzswqBdg4ygeIoGv2yKAy48KG2lU3gHd4AJZ69lCGN40gBpGe+wkq rH9ZYb7/mjvvLj4wfUlSzJMJ1p6QM7YIC2s9yCHKyzpEJZCy6ScvhnFIEKQQ4c+ODpc/8YCC9 7XfW50TXPgma10t9K5LjonGmLtWafgM3TPByY5QuRiKquqmZ4z+1CgDAjyzI+a5uWMCp0N/At kQmY/Hh2OUUSyaE+xeODqyU/w1MCx/fanDkaKyS3PZLWYxY7mj7txvb2pT4bi35AJy4walwUu BjNTpnAxQLNAkTMy+A86+8l8JgunO7joWoBFksyLOsFNBsfDfYC/VRiX3j31ZObD3/mullyot QB3oh+fpUpJDJo89WPrrJR0DeuUCclpK+EDbwzPbqavMHYxiKHvVcj+od0QqDVm59imlVYZ/x 68Rb0mZiaHMzNHuV2+zW0NHigdf2sOVG0w1YxvTCuzDicyRKB4lSOvbRCbcxqasQHLAneFEdK NQpd3b9+Ds4x8aa7F5/brAe3TJL1FUB+Trcy2Hrc84mmqMebD589QrG2VnPRvBZXv6PQZLEcG 8tpq5FvWrLkq20= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54481 Cc: 54481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) dick writes: > (defcustom hl-line-sticky-flag t > - "Non-nil means the HL-Line mode highlight appears in all windows. > -Otherwise Hl-Line mode will highlight only in the selected > -window. Setting this variable takes effect the next time you use > -the command `hl-line-mode' to turn Hl-Line mode on. > - > -This variable has no effect in Global Highlight Line mode. > -For that, use `global-hl-line-sticky-flag'." > + "Non-nil to preserve highlighting overlay when focus leaves window." > :type 'boolean > :version "22.1" > + :group 'hl-line > + :set (lambda (symbol value) > + (set-default symbol value) > + (unless value > + (let ((selected (window-buffer (selected-window)))) > + (dolist (buffer (buffer-list)) > + (unless (eq buffer selected) > + (with-current-buffer buffer > + (hl-line-unhighlight)))))))) That gives me Debugger entered--Lisp error: (void-function hl-line-unhighlight) (hl-line-unhighlight) (#f(compiled-function (symbol value) #) hl-line-sticky-flag nil) (custom-initialize-reset hl-line-sticky-flag (funcall #'#f(compiled-function () #))) (custom-declare-variable hl-line-sticky-flag (funcall #'#f(compiled-function () #)) ...) (byte-code ...) (hl-line-mode nil) Same error for (require 'hl-line). Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 22 10:15:08 2022 Received: (at 54481) by debbugs.gnu.org; 22 Mar 2022 14:15:09 +0000 Received: from localhost ([127.0.0.1]:41486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWfHw-0006dO-MZ for submit@debbugs.gnu.org; Tue, 22 Mar 2022 10:15:08 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWfHu-0006W6-TE for 54481@debbugs.gnu.org; Tue, 22 Mar 2022 10:15:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5MA/kje0MBQ4Xmkmvqn2kacsYfU2Uw6Md+m0zqFu8J8=; b=RB+4CB88dyLZAQqG0bxojXpSMl yk44PYf1Jk7JmwphD2qdADPr0PBuRbhB7n3T660UUDQY63+0SVto2wMmV1pI0Cw4EEYUH0LNLkXEb 5iy3HgcgmFYS5pecsm1cS9A8Cw6rtaPqjC6ZLMa1K8kllXpHdjhBYE8VU3XhzOmEfagw=; Received: from 109.179.236.69.tmi.telenormobil.no ([109.179.236.69] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWfHn-0006cN-4N; Tue, 22 Mar 2022 15:15:01 +0100 From: Lars Ingebrigtsen To: Michael Heerdegen Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line References: <877d8o8vuk.fsf@dick> <87lex2vfux.fsf@web.de> Date: Tue, 22 Mar 2022 15:14:57 +0100 In-Reply-To: <87lex2vfux.fsf@web.de> (Michael Heerdegen's message of "Tue, 22 Mar 2022 04:13:58 +0100") Message-ID: <87zglikra6.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Heerdegen writes: > That gives me > > Debugger entered--Lisp error: (void-function hl-line-unhighlight) > (hl-line-unhighlight) > (#f(compiled-function (symbol value) #) > hl-line-sticky-fl [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54481 Cc: 54481@debbugs.gnu.org, dick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Michael Heerdegen writes: > That gives me > > Debugger entered--Lisp error: (void-function hl-line-unhighlight) > (hl-line-unhighlight) > (#f(compiled-function (symbol value) #) > hl-line-sticky-flag nil) > (custom-initialize-reset hl-line-sticky-flag (funcall > #'#f(compiled-function () #))) > (custom-declare-variable hl-line-sticky-flag (funcall > #'#f(compiled-function () #)) ...) > (byte-code ...) > (hl-line-mode nil) > > Same error for (require 'hl-line). "emacs -Q" and (require 'hl-line) gives you an error? I'm unable to reproduce that on the current trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 22 10:19:44 2022 Received: (at 54481) by debbugs.gnu.org; 22 Mar 2022 14:19:44 +0000 Received: from localhost ([127.0.0.1]:41495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWfMN-0000SE-Ek for submit@debbugs.gnu.org; Tue, 22 Mar 2022 10:19:44 -0400 Received: from mail-qk1-f180.google.com ([209.85.222.180]:40620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWfFV-0006QS-Vm for 54481@debbugs.gnu.org; Tue, 22 Mar 2022 10:12:38 -0400 Received: by mail-qk1-f180.google.com with SMTP id i65so8208170qkd.7 for <54481@debbugs.gnu.org>; Tue, 22 Mar 2022 07:12:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=datYeIO8fD5QI1jIuV4fo5c47e4JiKwwSrZGIBmRM4o=; b=nEBYu+ZC8yAgKVD4RMfipSPHBL+Zk4+dSOpx7+1cS99yb0Hcw1DFKBp9sUMFZyWfw0 rtPUXeqVPckllzKYCP7MzFL6BW3spRhXQkujjxLUq1F/8GUW/8igYD2pag5AT4bRHh7a gvUwM0K95W1xJVrNKWiPT2CPe8MjLvYSkqOJAUDbboNVzb0XxRPLL2mQ3EWH8UM/qMS9 JUK8uUJSkjtg+3OjGkax0lZTl8ZUO22eIUx4OTfte9LfXGru8XrsajLmsS0bX/4Zr5Le k/F6gTJxGp+rueLriN00MIT+A6hHIlm/uBUL+ruIVbEE/xLtZgbtZ7ZWhE/BeKsl6SYz Yj+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=datYeIO8fD5QI1jIuV4fo5c47e4JiKwwSrZGIBmRM4o=; b=V/kuruLrzmg376SjVByrbmh8wFE28PtAmzZF989i9s05LmEEh5ffIpD7njLioYtgbx XUAtd5hKzM7bWM14gZn4mvpB5py1C3I7JzcadkMLkEkvrTUzbK+eYJR9ISNsR3nxh7C6 3g015fl4WAASJ2B7YNOmE8+yiixX2DYsyRWZ03A2aTcaT6K9mmgxB3Tubh38nDZHpdu0 rbJq6KeC6+cT6uY4kErLKIasscCN9AqadYiL8OTDsdKXsGPdeGNV6rVQhfv4h9Zxiw0W tTEJKmx/y2gnbNgJWmCxzRsYdsoByom8RzUFuFK232JWvXgplkdNGTv9G8l6sAjjd7Gi RCGw== X-Gm-Message-State: AOAM53387MuNVm8wvfkLUSDXc2tjxHetO6zEomeEYORBsH/rRfF86hHF neb09VBA5WfFv0pf/LydHDw= X-Google-Smtp-Source: ABdhPJzuGXEKuRyL9VnRkF3+bl6iVQ1uameuGBIdazqCZvWwfAEXIKOjgtIMSrjNh5r8MQL7DUow1Q== X-Received: by 2002:a05:620a:271d:b0:67d:bb5f:8a7d with SMTP id b29-20020a05620a271d00b0067dbb5f8a7dmr15461378qkp.154.1647958352342; Tue, 22 Mar 2022 07:12:32 -0700 (PDT) Received: from localhost (pool-96-232-253-158.nycmny.fios.verizon.net. [96.232.253.158]) by smtp.gmail.com with ESMTPSA id k13-20020a05622a03cd00b002e21621c243sm3767277qtx.39.2022.03.22.07.12.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Mar 2022 07:12:31 -0700 (PDT) From: dick To: Michael Heerdegen Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line References: <877d8o8vuk.fsf@dick> <87lex2vfux.fsf@web.de> Date: Tue, 22 Mar 2022 10:12:30 -0400 In-Reply-To: <87lex2vfux.fsf@web.de> (Michael Heerdegen's message of "Tue, 22 Mar 2022 04:13:58 +0100") Message-ID: <87bkxy3wkx.fsf@dick> User-Agent: Gnus/5.14 (Gnus v5.14) Commercial/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54481 X-Mailman-Approved-At: Tue, 22 Mar 2022 10:19:41 -0400 Cc: 54481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain I seem to have broken hl-line-sticky-flag. Sorry about that. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-I-broke-hl-line-sticky-flag.patch >From 27d1629000236f036988a0cbc768e71846880775 Mon Sep 17 00:00:00 2001 From: dickmao Date: Tue, 22 Mar 2022 09:58:09 -0400 Subject: [PATCH] I broke hl-line-sticky-flag Turns out `hl-line--buffer` (nee `hl-line-overlay-buffer`) wasn't cruft. It was the poor man's previous-buffer tracker, of which the rich man's version is some highly nontrivial inference from `window-prev-buffers`, the details of which I've yet to elicit. * lisp/hl-line.el (hl-line-overlay, hl-line-overlay-buffer): Correct replacement variable. (hl-line--overlay): Clearer doc. (hl-line--buffer): Nee hl-line-overlay-buffer (hl-line-sticky-flag): Custom initialization is unfathomable. (hl-line-mode, hl-line-unhighlight): Orthogonalize sticky. (hl-line-highlight): Remove highlight from previous buffer. * test/lisp/calendar/todo-mode-tests.el (todo-test-item-highlighting, todo-test-done-items-separator06-bol, todo-test-done-items-separator06-eol, todo-test-done-items-separator07): Fallout f36d929. * test/lisp/hl-line-tests.el (hl-line-sticky, hl-line-tests-verify): (hl-line-tests-sticky-across-frames, hl-line-tests-sticky): Test. --- lisp/hl-line.el | 33 +++++--- test/lisp/calendar/todo-mode-tests.el | 10 +-- test/lisp/hl-line-tests.el | 108 ++++++++++++++++++++------ 3 files changed, 113 insertions(+), 38 deletions(-) diff --git a/lisp/hl-line.el b/lisp/hl-line.el index 70ba0fcfc28..3faa2946115 100644 --- a/lisp/hl-line.el +++ b/lisp/hl-line.el @@ -24,17 +24,27 @@ ;;; Commentary: +;; Proper scuttling of unsticky overlays relies on `post-command-hook` +;; being called on a buffer switch and the stationarity of +;; `hl-line--buffer` across switches. One could easily imagine +;; programatically defeating unsticky overlays by bypassing +;; `post-command-hook`. + ;;; Code: -(make-obsolete-variable 'hl-line-overlay nil "29.1") +(make-obsolete-variable 'hl-line-overlay 'hl-line--overlay "29.1") (make-obsolete-variable 'global-hl-line-overlay nil "29.1") (make-obsolete-variable 'global-hl-line-overlays nil "29.1") (make-obsolete-variable 'global-hl-line-sticky-flag nil "29.1") -(make-obsolete-variable 'hl-line-overlay-buffer nil "29.1") +(make-obsolete-variable 'hl-line-overlay-buffer 'hl-line--buffer "29.1") (make-obsolete-variable 'hl-line-range-function nil "29.1") (defvar-local hl-line--overlay nil - "Keep state else scan entire buffer in `post-command-hook'.") + "The prevailing highlighting overlay per buffer.") + +(defvar hl-line--buffer nil + "Track last buffer in lieu of nontrivial inference from +`window-prev-buffers`.") ;; 1. define-minor-mode creates buffer-local hl-line--overlay ;; 2. overlay wiped by kill-all-local-variables @@ -68,6 +78,7 @@ hl-line-sticky-flag :type 'boolean :version "22.1" :group 'hl-line + :initialize #'custom-initialize-default :set (lambda (symbol value) (set-default symbol value) (unless value @@ -100,14 +111,12 @@ hl-line-mode (add-hook 'post-command-hook #'hl-line-highlight nil t)) (remove-hook 'post-command-hook #'hl-line-highlight t) (remove-hook 'change-major-mode-hook #'hl-line-unhighlight t) - (let (hl-line-sticky-flag) - (hl-line-unhighlight)))) + (hl-line-unhighlight))) (defun hl-line-unhighlight () - (unless hl-line-sticky-flag - (when hl-line--overlay - (delete-overlay hl-line--overlay) - (setq hl-line--overlay nil)))) + (when hl-line--overlay + (delete-overlay hl-line--overlay) + (setq hl-line--overlay nil))) (defun hl-line-highlight () (unless (minibufferp) @@ -120,6 +129,12 @@ hl-line-highlight (move-overlay hl-line--overlay (line-beginning-position) (line-beginning-position 2)) + (when (and (not (eq hl-line--buffer (current-buffer))) + (not hl-line-sticky-flag) + (buffer-live-p hl-line--buffer)) + (with-current-buffer hl-line--buffer + (hl-line-unhighlight))) + (setq hl-line--buffer (current-buffer)) (run-hooks 'hl-line-highlight-hook))) (defun hl-line-turn-on () diff --git a/test/lisp/calendar/todo-mode-tests.el b/test/lisp/calendar/todo-mode-tests.el index 8715a32b883..0102b62c10f 100644 --- a/test/lisp/calendar/todo-mode-tests.el +++ b/test/lisp/calendar/todo-mode-tests.el @@ -130,8 +130,8 @@ todo-test-item-highlighting (todo-toggle-item-highlighting) (let ((end (1- (todo-item-end))) (beg (todo-item-start))) - (should (eq (get-char-property beg 'face) 'hl-line-face)) - (should (eq (get-char-property end 'face) 'hl-line-face)) + (should (eq (get-char-property beg 'face) 'hl-line)) + (should (eq (get-char-property end 'face) 'hl-line)) (should (> (count-lines beg end) 1)) (should (eq (next-single-char-property-change beg 'face) (1+ end)))) (todo-toggle-item-highlighting))) ; Turn off highlighting (for test rerun). @@ -736,7 +736,7 @@ todo-test-done-items-separator06-bol (todo-test--done-items-separator) (call-interactively #'todo-toggle-item-highlighting) (ert-simulate-command '(todo-previous-item)) - (should (eq 'hl-line-face (get-char-property (point) 'face))))) + (should (eq 'hl-line (get-char-property (point) 'face))))) (ert-deftest todo-test-done-items-separator06-eol () ; bug#32343 "Test enabling item highlighting at EOL of done items separator. @@ -746,7 +746,7 @@ todo-test-done-items-separator06-eol (todo-toggle-item-highlighting) (forward-line -1) (ert-simulate-command '(todo-previous-item)) - (should (eq 'hl-line-face (get-char-property (point) 'face))))) + (should (eq 'hl-line (get-char-property (point) 'face))))) (ert-deftest todo-test-done-items-separator07 () ; bug#32343 "Test item highlighting when crossing done items separator. @@ -758,7 +758,7 @@ todo-test-done-items-separator07 (todo-next-item) ; Now on empty line above separator. (forward-line) ; Now on separator. (ert-simulate-command '(forward-line)) ; Now on first done item. - (should (eq 'hl-line-face (get-char-property (point) 'face))))) + (should (eq 'hl-line (get-char-property (point) 'face))))) (ert-deftest todo-test-current-file-in-edit-mode () ; bug#32437 "Test the value of todo-current-todo-file in todo-edit-mode." diff --git a/test/lisp/hl-line-tests.el b/test/lisp/hl-line-tests.el index 422d4ddae7d..6bff09135b2 100644 --- a/test/lisp/hl-line-tests.el +++ b/test/lisp/hl-line-tests.el @@ -21,30 +21,90 @@ (require 'ert) (require 'hl-line) -(ert-deftest hl-line-sticky () - (should hl-line-sticky-flag) - (with-temp-buffer - (let ((from-buffer (current-buffer))) - (hl-line-mode 1) - (save-excursion - (insert "foo")) - (hl-line-highlight) - (should (cl-some (apply-partially #'eq hl-line--overlay) - (overlays-at (point)))) - (switch-to-buffer (get-buffer-create "*scratch*")) - (hl-line-mode 1) - (save-excursion - (insert "bar")) - (hl-line-highlight) - (should (cl-some (apply-partially #'eq hl-line--overlay) - (overlays-at (point)))) - (should (buffer-local-value 'hl-line--overlay from-buffer)) - (should-not (eq (buffer-local-value 'hl-line--overlay from-buffer) - hl-line--overlay)) - (customize-set-variable 'hl-line-sticky-flag nil) - (should hl-line--overlay) - (should (buffer-live-p from-buffer)) - (should-not (buffer-local-value 'hl-line--overlay from-buffer))))) +(defsubst hl-line-tests-verify (_label on-p) + (eq on-p (cl-some (apply-partially #'eq hl-line--overlay) + (overlays-at (point))))) + +(ert-deftest hl-line-tests-sticky-across-frames () + (skip-unless (display-graphic-p)) + (customize-set-variable 'hl-line-sticky-flag t) + (call-interactively #'global-hl-line-mode) + (let ((first-frame (selected-frame)) + (first-buffer "foo") + (second-buffer "bar") + second-frame) + (unwind-protect + (progn + (switch-to-buffer first-buffer) + (save-excursion + (insert (buffer-name))) + (run-hooks 'post-command-hook) + (should (hl-line-tests-verify 111 t)) + (select-frame (setq second-frame (make-frame))) + (switch-to-buffer second-buffer) + (save-excursion + (insert (buffer-name))) + (run-hooks 'post-command-hook) + (should (hl-line-tests-verify 762 t)) + (with-current-buffer first-buffer + (should (hl-line-tests-verify 534 t))) + (call-interactively #'global-hl-line-mode) + (should (hl-line-tests-verify 125 nil)) + (with-current-buffer first-buffer + (should (hl-line-tests-verify 892 nil))) + + ;; now do unsticky + (customize-set-variable 'hl-line-sticky-flag nil) + (call-interactively #'global-hl-line-mode) + (run-hooks 'post-command-hook) + (should (hl-line-tests-verify 467 t)) + (with-current-buffer first-buffer + (should (hl-line-tests-verify 765 nil))) + (select-frame first-frame) + (should (equal (buffer-name) first-buffer)) + (run-hooks 'post-command-hook) + (should (hl-line-tests-verify 423 t)) + (with-current-buffer second-buffer + (should (hl-line-tests-verify 897 nil)))) + (let (kill-buffer-query-functions) + (ignore-errors (kill-buffer first-buffer)) + (ignore-errors (kill-buffer second-buffer)) + (ignore-errors (delete-frame second-frame)))))) + +(ert-deftest hl-line-tests-sticky () + (customize-set-variable 'hl-line-sticky-flag t) + (let ((first-buffer "foo") + (second-buffer "bar")) + (unwind-protect + (progn + (switch-to-buffer first-buffer) + (hl-line-mode 1) + (save-excursion + (insert (buffer-name))) + (run-hooks 'post-command-hook) + (should (hl-line-tests-verify 123 t)) + (switch-to-buffer second-buffer) + (hl-line-mode 1) + (save-excursion + (insert (buffer-name))) + (run-hooks 'post-command-hook) + (should (hl-line-tests-verify 56 t)) + (with-current-buffer first-buffer + (should (hl-line-tests-verify 67 t))) + + ;; now do unsticky + (customize-set-variable 'hl-line-sticky-flag nil) + (should (hl-line-tests-verify 234 t)) + (with-current-buffer first-buffer + (should (hl-line-tests-verify 231 nil))) + (switch-to-buffer first-buffer) + (run-hooks 'post-command-hook) + (should (hl-line-tests-verify 257 t)) + (with-current-buffer second-buffer + (should (hl-line-tests-verify 999 nil))))) + (let (kill-buffer-query-functions) + (ignore-errors (kill-buffer first-buffer)) + (ignore-errors (kill-buffer second-buffer))))) (provide 'hl-line-tests) -- 2.26.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 22 10:19:45 2022 Received: (at 54481) by debbugs.gnu.org; 22 Mar 2022 14:19:45 +0000 Received: from localhost ([127.0.0.1]:41497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWfMO-0000SO-Kc for submit@debbugs.gnu.org; Tue, 22 Mar 2022 10:19:45 -0400 Received: from mail-qt1-f176.google.com ([209.85.160.176]:35338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWfFj-0006Rd-Ly for 54481@debbugs.gnu.org; Tue, 22 Mar 2022 10:12:52 -0400 Received: by mail-qt1-f176.google.com with SMTP id v14so14514297qta.2 for <54481@debbugs.gnu.org>; Tue, 22 Mar 2022 07:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=datYeIO8fD5QI1jIuV4fo5c47e4JiKwwSrZGIBmRM4o=; b=ih7ciQQg+6O6oDaDe/vZhyANS7pGJunGEG9sJOkwS9N0YkouZ3HpqDIR1YMaxHaD/n AqATTTiVEUHoXltJ0g67TN5YH004WvIIArqdXBEB70TegaWn7hPoSGwuvxSUxJ5jtl0J J21dBiTuI+Gz5+4tky91YAsd8IdPjtYs3Wv8f74SgE9I0IX3sj99UNhsYrBqeZu5Oxvl MylOUKmF0+/IZLGSHJ1Byw2ONtD0MFgs/12E1BUUTeI8CcR1KGqkkmlbrjop2LYJRaFP bC+yw8Rz4JjEHon5++qfB1Tivf1mVzQ+4OYaej5XmjoZQ2DrosJ1BDRNZxuRtWh3YQTV Tliw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=datYeIO8fD5QI1jIuV4fo5c47e4JiKwwSrZGIBmRM4o=; b=uykWzC+n3kD6+wlPXP/A0QFBfGd+0awU45mIyaS8UthOUB8wBiKhGaN++NcTm76r1e 2KscTomkwbkIzNdqN4V+z7rZ4V+3Go/pKnWjypPQ3j+BhbPgSNGteSBTGAiz/lOYCL59 nzlK/g8BsqDR8FiRyeB4HeiThhNsc6AcUszDam8EHqVCO/JYPTD+GsHZArXW13k8u+iP cEc5EYaKHg0n0JkRPiRV41zcQNONfAF7KW7rD9ZYAFW4l1y8+tCDVasGI0VWrm640qFw Xbp8JQi1G7yZ7B4gG27rQv+HfEJpcLPOuDE/34qqNfcATF1XRTrkVPLnKAPkBU3oQ6fI C5xg== X-Gm-Message-State: AOAM533NnQGCBcTbHb1rnQggKmeOlKUXqiiZH5JJMFUbPK/DmunRZZTW HfpbLoramVIArs+QoOpenCM= X-Google-Smtp-Source: ABdhPJzEu0wWcMMaeHLnbSYkcubuq+LJsrmbN9F5dXNt3Q86Qtt5RWehjN6Vs7+o0FlmLisHENzsWQ== X-Received: by 2002:a05:622a:508:b0:2e1:deae:22bd with SMTP id l8-20020a05622a050800b002e1deae22bdmr19760163qtx.597.1647958366229; Tue, 22 Mar 2022 07:12:46 -0700 (PDT) Received: from localhost (pool-96-232-253-158.nycmny.fios.verizon.net. [96.232.253.158]) by smtp.gmail.com with ESMTPSA id n131-20020a372789000000b0067bce1ac001sm9207502qkn.71.2022.03.22.07.12.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Mar 2022 07:12:45 -0700 (PDT) From: dick To: Michael Heerdegen Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line In-Reply-To: <87lex2vfux.fsf@web.de> (Michael Heerdegen's message of "Tue, 22 Mar 2022 04:13:58 +0100") References: <877d8o8vuk.fsf@dick> <87lex2vfux.fsf@web.de> User-Agent: Gnus/5.14 (Gnus v5.14) Commercial/29.0.50 (gnu/linux) Date: Tue, 22 Mar 2022 10:12:44 -0400 Message-ID: <87a6di3wkj.fsf@dick> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54481 X-Mailman-Approved-At: Tue, 22 Mar 2022 10:19:41 -0400 Cc: 54481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain I seem to have broken hl-line-sticky-flag. Sorry about that. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-I-broke-hl-line-sticky-flag.patch >From 27d1629000236f036988a0cbc768e71846880775 Mon Sep 17 00:00:00 2001 From: dickmao Date: Tue, 22 Mar 2022 09:58:09 -0400 Subject: [PATCH] I broke hl-line-sticky-flag Turns out `hl-line--buffer` (nee `hl-line-overlay-buffer`) wasn't cruft. It was the poor man's previous-buffer tracker, of which the rich man's version is some highly nontrivial inference from `window-prev-buffers`, the details of which I've yet to elicit. * lisp/hl-line.el (hl-line-overlay, hl-line-overlay-buffer): Correct replacement variable. (hl-line--overlay): Clearer doc. (hl-line--buffer): Nee hl-line-overlay-buffer (hl-line-sticky-flag): Custom initialization is unfathomable. (hl-line-mode, hl-line-unhighlight): Orthogonalize sticky. (hl-line-highlight): Remove highlight from previous buffer. * test/lisp/calendar/todo-mode-tests.el (todo-test-item-highlighting, todo-test-done-items-separator06-bol, todo-test-done-items-separator06-eol, todo-test-done-items-separator07): Fallout f36d929. * test/lisp/hl-line-tests.el (hl-line-sticky, hl-line-tests-verify): (hl-line-tests-sticky-across-frames, hl-line-tests-sticky): Test. --- lisp/hl-line.el | 33 +++++--- test/lisp/calendar/todo-mode-tests.el | 10 +-- test/lisp/hl-line-tests.el | 108 ++++++++++++++++++++------ 3 files changed, 113 insertions(+), 38 deletions(-) diff --git a/lisp/hl-line.el b/lisp/hl-line.el index 70ba0fcfc28..3faa2946115 100644 --- a/lisp/hl-line.el +++ b/lisp/hl-line.el @@ -24,17 +24,27 @@ ;;; Commentary: +;; Proper scuttling of unsticky overlays relies on `post-command-hook` +;; being called on a buffer switch and the stationarity of +;; `hl-line--buffer` across switches. One could easily imagine +;; programatically defeating unsticky overlays by bypassing +;; `post-command-hook`. + ;;; Code: -(make-obsolete-variable 'hl-line-overlay nil "29.1") +(make-obsolete-variable 'hl-line-overlay 'hl-line--overlay "29.1") (make-obsolete-variable 'global-hl-line-overlay nil "29.1") (make-obsolete-variable 'global-hl-line-overlays nil "29.1") (make-obsolete-variable 'global-hl-line-sticky-flag nil "29.1") -(make-obsolete-variable 'hl-line-overlay-buffer nil "29.1") +(make-obsolete-variable 'hl-line-overlay-buffer 'hl-line--buffer "29.1") (make-obsolete-variable 'hl-line-range-function nil "29.1") (defvar-local hl-line--overlay nil - "Keep state else scan entire buffer in `post-command-hook'.") + "The prevailing highlighting overlay per buffer.") + +(defvar hl-line--buffer nil + "Track last buffer in lieu of nontrivial inference from +`window-prev-buffers`.") ;; 1. define-minor-mode creates buffer-local hl-line--overlay ;; 2. overlay wiped by kill-all-local-variables @@ -68,6 +78,7 @@ hl-line-sticky-flag :type 'boolean :version "22.1" :group 'hl-line + :initialize #'custom-initialize-default :set (lambda (symbol value) (set-default symbol value) (unless value @@ -100,14 +111,12 @@ hl-line-mode (add-hook 'post-command-hook #'hl-line-highlight nil t)) (remove-hook 'post-command-hook #'hl-line-highlight t) (remove-hook 'change-major-mode-hook #'hl-line-unhighlight t) - (let (hl-line-sticky-flag) - (hl-line-unhighlight)))) + (hl-line-unhighlight))) (defun hl-line-unhighlight () - (unless hl-line-sticky-flag - (when hl-line--overlay - (delete-overlay hl-line--overlay) - (setq hl-line--overlay nil)))) + (when hl-line--overlay + (delete-overlay hl-line--overlay) + (setq hl-line--overlay nil))) (defun hl-line-highlight () (unless (minibufferp) @@ -120,6 +129,12 @@ hl-line-highlight (move-overlay hl-line--overlay (line-beginning-position) (line-beginning-position 2)) + (when (and (not (eq hl-line--buffer (current-buffer))) + (not hl-line-sticky-flag) + (buffer-live-p hl-line--buffer)) + (with-current-buffer hl-line--buffer + (hl-line-unhighlight))) + (setq hl-line--buffer (current-buffer)) (run-hooks 'hl-line-highlight-hook))) (defun hl-line-turn-on () diff --git a/test/lisp/calendar/todo-mode-tests.el b/test/lisp/calendar/todo-mode-tests.el index 8715a32b883..0102b62c10f 100644 --- a/test/lisp/calendar/todo-mode-tests.el +++ b/test/lisp/calendar/todo-mode-tests.el @@ -130,8 +130,8 @@ todo-test-item-highlighting (todo-toggle-item-highlighting) (let ((end (1- (todo-item-end))) (beg (todo-item-start))) - (should (eq (get-char-property beg 'face) 'hl-line-face)) - (should (eq (get-char-property end 'face) 'hl-line-face)) + (should (eq (get-char-property beg 'face) 'hl-line)) + (should (eq (get-char-property end 'face) 'hl-line)) (should (> (count-lines beg end) 1)) (should (eq (next-single-char-property-change beg 'face) (1+ end)))) (todo-toggle-item-highlighting))) ; Turn off highlighting (for test rerun). @@ -736,7 +736,7 @@ todo-test-done-items-separator06-bol (todo-test--done-items-separator) (call-interactively #'todo-toggle-item-highlighting) (ert-simulate-command '(todo-previous-item)) - (should (eq 'hl-line-face (get-char-property (point) 'face))))) + (should (eq 'hl-line (get-char-property (point) 'face))))) (ert-deftest todo-test-done-items-separator06-eol () ; bug#32343 "Test enabling item highlighting at EOL of done items separator. @@ -746,7 +746,7 @@ todo-test-done-items-separator06-eol (todo-toggle-item-highlighting) (forward-line -1) (ert-simulate-command '(todo-previous-item)) - (should (eq 'hl-line-face (get-char-property (point) 'face))))) + (should (eq 'hl-line (get-char-property (point) 'face))))) (ert-deftest todo-test-done-items-separator07 () ; bug#32343 "Test item highlighting when crossing done items separator. @@ -758,7 +758,7 @@ todo-test-done-items-separator07 (todo-next-item) ; Now on empty line above separator. (forward-line) ; Now on separator. (ert-simulate-command '(forward-line)) ; Now on first done item. - (should (eq 'hl-line-face (get-char-property (point) 'face))))) + (should (eq 'hl-line (get-char-property (point) 'face))))) (ert-deftest todo-test-current-file-in-edit-mode () ; bug#32437 "Test the value of todo-current-todo-file in todo-edit-mode." diff --git a/test/lisp/hl-line-tests.el b/test/lisp/hl-line-tests.el index 422d4ddae7d..6bff09135b2 100644 --- a/test/lisp/hl-line-tests.el +++ b/test/lisp/hl-line-tests.el @@ -21,30 +21,90 @@ (require 'ert) (require 'hl-line) -(ert-deftest hl-line-sticky () - (should hl-line-sticky-flag) - (with-temp-buffer - (let ((from-buffer (current-buffer))) - (hl-line-mode 1) - (save-excursion - (insert "foo")) - (hl-line-highlight) - (should (cl-some (apply-partially #'eq hl-line--overlay) - (overlays-at (point)))) - (switch-to-buffer (get-buffer-create "*scratch*")) - (hl-line-mode 1) - (save-excursion - (insert "bar")) - (hl-line-highlight) - (should (cl-some (apply-partially #'eq hl-line--overlay) - (overlays-at (point)))) - (should (buffer-local-value 'hl-line--overlay from-buffer)) - (should-not (eq (buffer-local-value 'hl-line--overlay from-buffer) - hl-line--overlay)) - (customize-set-variable 'hl-line-sticky-flag nil) - (should hl-line--overlay) - (should (buffer-live-p from-buffer)) - (should-not (buffer-local-value 'hl-line--overlay from-buffer))))) +(defsubst hl-line-tests-verify (_label on-p) + (eq on-p (cl-some (apply-partially #'eq hl-line--overlay) + (overlays-at (point))))) + +(ert-deftest hl-line-tests-sticky-across-frames () + (skip-unless (display-graphic-p)) + (customize-set-variable 'hl-line-sticky-flag t) + (call-interactively #'global-hl-line-mode) + (let ((first-frame (selected-frame)) + (first-buffer "foo") + (second-buffer "bar") + second-frame) + (unwind-protect + (progn + (switch-to-buffer first-buffer) + (save-excursion + (insert (buffer-name))) + (run-hooks 'post-command-hook) + (should (hl-line-tests-verify 111 t)) + (select-frame (setq second-frame (make-frame))) + (switch-to-buffer second-buffer) + (save-excursion + (insert (buffer-name))) + (run-hooks 'post-command-hook) + (should (hl-line-tests-verify 762 t)) + (with-current-buffer first-buffer + (should (hl-line-tests-verify 534 t))) + (call-interactively #'global-hl-line-mode) + (should (hl-line-tests-verify 125 nil)) + (with-current-buffer first-buffer + (should (hl-line-tests-verify 892 nil))) + + ;; now do unsticky + (customize-set-variable 'hl-line-sticky-flag nil) + (call-interactively #'global-hl-line-mode) + (run-hooks 'post-command-hook) + (should (hl-line-tests-verify 467 t)) + (with-current-buffer first-buffer + (should (hl-line-tests-verify 765 nil))) + (select-frame first-frame) + (should (equal (buffer-name) first-buffer)) + (run-hooks 'post-command-hook) + (should (hl-line-tests-verify 423 t)) + (with-current-buffer second-buffer + (should (hl-line-tests-verify 897 nil)))) + (let (kill-buffer-query-functions) + (ignore-errors (kill-buffer first-buffer)) + (ignore-errors (kill-buffer second-buffer)) + (ignore-errors (delete-frame second-frame)))))) + +(ert-deftest hl-line-tests-sticky () + (customize-set-variable 'hl-line-sticky-flag t) + (let ((first-buffer "foo") + (second-buffer "bar")) + (unwind-protect + (progn + (switch-to-buffer first-buffer) + (hl-line-mode 1) + (save-excursion + (insert (buffer-name))) + (run-hooks 'post-command-hook) + (should (hl-line-tests-verify 123 t)) + (switch-to-buffer second-buffer) + (hl-line-mode 1) + (save-excursion + (insert (buffer-name))) + (run-hooks 'post-command-hook) + (should (hl-line-tests-verify 56 t)) + (with-current-buffer first-buffer + (should (hl-line-tests-verify 67 t))) + + ;; now do unsticky + (customize-set-variable 'hl-line-sticky-flag nil) + (should (hl-line-tests-verify 234 t)) + (with-current-buffer first-buffer + (should (hl-line-tests-verify 231 nil))) + (switch-to-buffer first-buffer) + (run-hooks 'post-command-hook) + (should (hl-line-tests-verify 257 t)) + (with-current-buffer second-buffer + (should (hl-line-tests-verify 999 nil))))) + (let (kill-buffer-query-functions) + (ignore-errors (kill-buffer first-buffer)) + (ignore-errors (kill-buffer second-buffer))))) (provide 'hl-line-tests) -- 2.26.2 --=-=-=-- From unknown Sat Sep 06 02:03:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug No longer marked as fixed in versions 29.1 and reopened. Date: Tue, 22 Mar 2022 14:20:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug No longer marked as fixed in versions 29.1 and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 22 10:19:43 2022 Received: (at control) by debbugs.gnu.org; 22 Mar 2022 14:19:43 +0000 Received: from localhost ([127.0.0.1]:41493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWfMN-0000S6-4q for submit@debbugs.gnu.org; Tue, 22 Mar 2022 10:19:43 -0400 Received: from mail-qv1-f46.google.com ([209.85.219.46]:38571) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWfBg-0006K4-8m for control@debbugs.gnu.org; Tue, 22 Mar 2022 10:08:42 -0400 Received: by mail-qv1-f46.google.com with SMTP id jo24so6281238qvb.5 for ; Tue, 22 Mar 2022 07:08:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:to:from:subject; bh=EgpKAzeKrysyRJ7c+3UXE9pxnWGlpz7/5uQFXGB82aI=; b=pX1h++WBVaw6giUPx0FV2cpFLF10S8ssDsnBoGJPBm3HWOwGScQ9aiJfD7z3zZiYrJ 2OB7Gg2zwqWlmgSTIDAj1wwzhLZniEXkQ39juGtP2U5laTF3ZDVFs1ePm56ZJ4kW41hf 8S9UV+oJaXdkSmBuvWHOxM8sChPmbHp4E3sKXGpSlwvLbbzuM69Hj7lyeTySUGlxOE+k 4L36WgxfY1P3Pvx912fRmSmhDnn31E6CWCnkXvm6he5KxY5Quf8i/syXtF2I5kJyElh3 mX90uUrkTk3eaYJkc92g4bRIuZ6+YMomNA56umFu3MvoEOyGqlnGle6w3n8wchD4J6R1 Qxuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:to:from:subject; bh=EgpKAzeKrysyRJ7c+3UXE9pxnWGlpz7/5uQFXGB82aI=; b=Oa6QPOwroyFACPz6Vp4y2IL1D5KCR6sIsMc0sOSoYjTeZUN7Z/TPZljFac9h2UWvOM RlPRZRCRE60P/NxJmYZC0wQe+693A8Av4cGqS37WU9h666k2FhbVlXbvBUKTEeUWaC/h nX+B9K/ZqQNPxNVh8kb3/Bz5hGEy4yFv2VaAlt8fUm1NnGBAeI5EW2Obby6dQJejQrPV xENC7VyNYbP0odi5ytJwo7bgtvj2p74OENouLtgQMEl8kdq59DiybbMUrC/fVDvivw01 89bOPCne/xE7VDBwoldoyfGo43vbQk8vdbyYCpkr3mxQjXCkCQVNLHE+lHchM3o3NTde 1uRA== X-Gm-Message-State: AOAM531lakVOXsyLrJKWNVN0JFqWnpq8xtntgfY2LWLngvJlQBwwU0dk vibABKkDHMgLHXYk9DnpFD9CbYZ2b0k= X-Google-Smtp-Source: ABdhPJx4yBme3dVzzAXnl18G5m176ZH/3dhyPpM81qt7BzQqHBzz0Dlgiar7Tb1Csci6bTwRHUo/8Q== X-Received: by 2002:a0c:f806:0:b0:440:f78f:1f67 with SMTP id r6-20020a0cf806000000b00440f78f1f67mr17352984qvn.95.1647958114172; Tue, 22 Mar 2022 07:08:34 -0700 (PDT) Received: from localhost (pool-96-232-253-158.nycmny.fios.verizon.net. [96.232.253.158]) by smtp.gmail.com with ESMTPSA id 197-20020a3703ce000000b0067af869ffa6sm8955872qkd.127.2022.03.22.07.08.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Mar 2022 07:08:33 -0700 (PDT) Message-ID: <6239d861.1c69fb81.48147.f2ba@mx.google.com> Date: Tue, 22 Mar 2022 10:08:32 -0400 To: control@debbugs.gnu.org From: dick Subject: control message for bug #54481 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-Mailman-Approved-At: Tue, 22 Mar 2022 10:19:41 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) reopen 54481 tags 54481 - fixed patch quit From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 22 10:34:05 2022 Received: (at 54481) by debbugs.gnu.org; 22 Mar 2022 14:34:05 +0000 Received: from localhost ([127.0.0.1]:41560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWfaG-0003G0-NE for submit@debbugs.gnu.org; Tue, 22 Mar 2022 10:34:05 -0400 Received: from mail-qv1-f54.google.com ([209.85.219.54]:41769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWfR9-0000ht-0n for 54481@debbugs.gnu.org; Tue, 22 Mar 2022 10:24:39 -0400 Received: by mail-qv1-f54.google.com with SMTP id gh15so9179321qvb.8 for <54481@debbugs.gnu.org>; Tue, 22 Mar 2022 07:24:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XTozvFBt9vzySh5QsXmISaYUG+L0I4TFNigoKEpK0Wg=; b=XZnFePhngHhhCA8OIbNgDHCI4Kob0FrxdjVKmO6+Sz45xVh9yCTHkri4Et4Z12h7Hr qjpmcwh7CMAcgAYAgDzGYT7U9Galhn09zWIPRQVnqmb4ObJdMlcZmKasD6lvWxfLdiJw iqU/uHn3edflQ+l9lxLg29WThgH033GqV57bZXkoDxJ4b1LVsNCKY9+wLlnhkaS5NDrl fwWscAE+h0E5FZZTNg1cOwbV8tc7ZdTJZuRMRQkKKAsVwxK/K6XljczctCqpUVWUhl// +iVHNJ1+xXquGhrffDR8dtCWtpDic+9a8rz4Qyu76qGpCcBNf6TOkVSEZ+qSl06HZuQN Uacg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=XTozvFBt9vzySh5QsXmISaYUG+L0I4TFNigoKEpK0Wg=; b=bni9JUS2TYAVKcRB4+eTEd7CZCRilpbtNlbYQaMd0lDqYT5aDtWszb/2C2zZBM3ZAx hWc0isNu6oH2QmLyK0hl39zdysXW9t8lsCTSSEe0qWKeyOlRo23xgZ7khY9JRtQFkr1X EmijvOldwK34YNB27ChBUWKM2ZV4I+Thux/czeKYRhuVDWrrVRrux+ZUuEJJz/VWJxSW GZMe6UXU76HtasJ7lFyJLneiCjLfYEz+lE4xAGugwOmhWipXUHWte9T08Of7ddlK4y/R S/lcAWteLly6ehypOlYYoGd2VpFf3BpWfPF7tdh6zulf9zdooQba9CJZc8lSPSffXaUV C0QQ== X-Gm-Message-State: AOAM532dr0mbL8/9/x3Msa4SQ/lbbV+g6ma+UAlzRP2JBCftePlW++d6 BKxTyoJ3iyTsuVGKaxLQQkk= X-Google-Smtp-Source: ABdhPJx2wwtdxpM/nzTN3I/PwkJdzXYse+1nihs90H8G3kMZfXmyRyetr3aRybBjCYxEUpwJoFg2VA== X-Received: by 2002:a05:6214:21eb:b0:440:42c2:2e82 with SMTP id p11-20020a05621421eb00b0044042c22e82mr19978492qvj.28.1647959073273; Tue, 22 Mar 2022 07:24:33 -0700 (PDT) Received: from localhost (pool-96-232-253-158.nycmny.fios.verizon.net. [96.232.253.158]) by smtp.gmail.com with ESMTPSA id bk15-20020a05620a1a0f00b0067e5bd7a9ccsm6144951qkb.50.2022.03.22.07.24.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Mar 2022 07:24:32 -0700 (PDT) From: dick To: Lars Ingebrigtsen Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line References: <877d8o8vuk.fsf@dick> <87lex2vfux.fsf@web.de> <87zglikra6.fsf@gnus.org> Date: Tue, 22 Mar 2022 10:24:32 -0400 In-Reply-To: <87zglikra6.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 22 Mar 2022 15:14:57 +0100") Message-ID: <875yo63w0v.fsf@dick> User-Agent: Gnus/5.14 (Gnus v5.14) Commercial/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54481 X-Mailman-Approved-At: Tue, 22 Mar 2022 10:34:03 -0400 Cc: Michael Heerdegen , 54481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Reproduce via: src/emacs -Q -nw --eval "(setq debug-on-error t)" --eval "(custom-set-variables '(hl-line-sticky-flag nil))" -f global-hl-line-mode Incidentally, I sent my previous mail twice, something bbdb always tricks me into doing. >>>>> "LI" == Lars Ingebrigtsen writes: LI> Michael Heerdegen writes: >> That gives me >> >> Debugger entered--Lisp error: (void-function hl-line-unhighlight) >> (hl-line-unhighlight) >> (#f(compiled-function (symbol value) #) >> hl-line-sticky-flag nil) >> (custom-initialize-reset hl-line-sticky-flag (funcall >> #'#f(compiled-function () #))) >> (custom-declare-variable hl-line-sticky-flag (funcall >> #'#f(compiled-function () #)) ...) >> (byte-code ...) >> (hl-line-mode nil) >> >> Same error for (require 'hl-line). LI> "emacs -Q" and (require 'hl-line) gives you an error? I'm unable to LI> reproduce that on the current trunk. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 22 10:35:30 2022 Received: (at 54481) by debbugs.gnu.org; 22 Mar 2022 14:35:30 +0000 Received: from localhost ([127.0.0.1]:41564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWfbe-0003IF-Ag for submit@debbugs.gnu.org; Tue, 22 Mar 2022 10:35:30 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWfbc-0003Hx-M5 for 54481@debbugs.gnu.org; Tue, 22 Mar 2022 10:35:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hiFZ9SzXjYaUZNuQJIf9TM6YHLLyjevWMHmhUFMn9vc=; b=p5WWdVySB88bBmOFSkCfcNr3zQ B1hLiyvGMNH5Y+33+rC5XUKMRcIKvvzqEkoJsGWqhPLIKPXdhqphAvbr0d0/Kh3sRVzll8CGj6jiU h497RpfPmjJY1mGh1idvpVJNlPWA+74l0NbietT01fu9x3SdxpeuT7KRI65lc/1D9t5s=; Received: from 109.179.236.69.tmi.telenormobil.no ([109.179.236.69] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWfbU-0006pr-JF; Tue, 22 Mar 2022 15:35:22 +0100 From: Lars Ingebrigtsen To: dick Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line References: <877d8o8vuk.fsf@dick> <87lex2vfux.fsf@web.de> <87zglikra6.fsf@gnus.org> <875yo63w0v.fsf@dick> Date: Tue, 22 Mar 2022 15:35:19 +0100 In-Reply-To: <875yo63w0v.fsf@dick> (dick's message of "Tue, 22 Mar 2022 10:24:32 -0400") Message-ID: <87lex2kqc8.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: dick writes: > Reproduce via: > > src/emacs -Q -nw --eval "(setq debug-on-error t)" --eval "(custom-set-variables '(hl-line-sticky-flag nil))" -f global-hl-line-mode Thanks; fixed now. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54481 Cc: Michael Heerdegen , 54481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) dick writes: > Reproduce via: > > src/emacs -Q -nw --eval "(setq debug-on-error t)" --eval "(custom-set-variables '(hl-line-sticky-flag nil))" -f global-hl-line-mode Thanks; fixed now. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 22 10:59:38 2022 Received: (at 54481) by debbugs.gnu.org; 22 Mar 2022 14:59:38 +0000 Received: from localhost ([127.0.0.1]:41605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWfz0-00063W-L2 for submit@debbugs.gnu.org; Tue, 22 Mar 2022 10:59:38 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWfyy-00063F-94 for 54481@debbugs.gnu.org; Tue, 22 Mar 2022 10:59:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=se5rudGp0BMLU7FuS0x1KT4XDEExwUPdZSjNxBWCc14=; b=WfJaeRL5amqI+oDjbj2cdbJofm DiSi4NZdEdLsAz8zJMIr5QJw3XYDc6FQhHZgMG4gd22JrAIoU7EBinNk2ifZ2v/mHgyftfNr+y2Rk UJHmjZFDsIeVvjVsVTV2XTvjh2ygJvju0jj62uE8uPjCYzZVbO3Huegvg6IJ9xxOB8tk=; Received: from 109.179.236.69.tmi.telenormobil.no ([109.179.236.69] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWfyp-00076k-Nb; Tue, 22 Mar 2022 15:59:30 +0100 From: Lars Ingebrigtsen To: dick Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line References: <877d8o8vuk.fsf@dick> <87lex2vfux.fsf@web.de> <87a6di3wkj.fsf@dick> Date: Tue, 22 Mar 2022 15:59:25 +0100 In-Reply-To: <87a6di3wkj.fsf@dick> (dick's message of "Tue, 22 Mar 2022 10:12:44 -0400") Message-ID: <878rt2kp82.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: dick writes: > I seem to have broken hl-line-sticky-flag. Sorry about that. Thanks; pushed to Emacs 29. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54481 Cc: Michael Heerdegen , 54481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) dick writes: > I seem to have broken hl-line-sticky-flag. Sorry about that. Thanks; pushed to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 22 11:26:15 2022 Received: (at control) by debbugs.gnu.org; 22 Mar 2022 15:26:15 +0000 Received: from localhost ([127.0.0.1]:41640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWgOl-0006jj-7B for submit@debbugs.gnu.org; Tue, 22 Mar 2022 11:26:15 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWgOi-0006jX-GD for control@debbugs.gnu.org; Tue, 22 Mar 2022 11:26:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+7eua8UuEJ4pCIPGtTbA/8TVAPwSqaEOYqoHTGh19N4=; b=bJ3lLeM8rwHLOl/4e5hT3Vxsfu j8i/88tRubhkBgQ/igpYwCyqqmTgQXidPCIJOwMJoBHqhSLYHGv1Oseu6W/S1+OIiINnk+q2TijXn JLTiQRN/ng+u97gOkvt2NpFDH6+o0PCGTf0MpKCmroJnRsg55y83vGn1kxSMjhxxuhno=; Received: from 109.179.236.69.tmi.telenormobil.no ([109.179.236.69] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWgOa-0007NC-AB for control@debbugs.gnu.org; Tue, 22 Mar 2022 16:26:06 +0100 Date: Tue, 22 Mar 2022 16:26:03 +0100 Message-Id: <8735jaknzo.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #54481 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 54481 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 54481 29.1 quit From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 22 22:21:36 2022 Received: (at 54481) by debbugs.gnu.org; 23 Mar 2022 02:21:36 +0000 Received: from localhost ([127.0.0.1]:42251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWqcy-0006bh-BA for submit@debbugs.gnu.org; Tue, 22 Mar 2022 22:21:36 -0400 Received: from mout.web.de ([212.227.17.12]:53185) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWqcx-0006bS-6P for 54481@debbugs.gnu.org; Tue, 22 Mar 2022 22:21:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1648002088; bh=ARYEDcGII6ElaZ4hJslNbZQQ0yCtvu0ALk4nwqvkZwg=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=GeYQ4qHA5dcqOmCGHX10F9WmPfvPQe2lyCpSfgCHAw3J3aTvmb4RWW/sSpscZnyUC 8gw8Ruugi2Pyw90wHyfVQJJg/VcS9facIn3/dYOj2AOTfZ9c+/ze29xABISVMlVmtG g3Jir+9dT+P29ygahvSd1fDggyd16j6BWz6Al4LM= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.60.174.212]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N7gbY-1o9sgU0WIM-014opB; Wed, 23 Mar 2022 03:21:28 +0100 From: Michael Heerdegen To: dick Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line References: <877d8o8vuk.fsf@dick> <87lex2vfux.fsf@web.de> <87zglikra6.fsf@gnus.org> <875yo63w0v.fsf@dick> Date: Wed, 23 Mar 2022 03:21:27 +0100 In-Reply-To: <875yo63w0v.fsf@dick> (dick's message of "Tue, 22 Mar 2022 10:24:32 -0400") Message-ID: <87czidmms8.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:T2T75hLY0doIewLPJf47e/p+4hjRX9trmE96JbEoD700E8J+qmp KNnihGSAF5I7Z3mYJdqU7+lmQUAwLpbmQDUqaO7ZyD93jXHFn6VVVVS8eUDKHM9/4ju+1sM iuU9eJreurVR6VsQb9JWlSz2j9s+XC4NWLpULRgPFFBF2VUNhEazrSFnG0eE2phBzRqiF2a xKfyM6ujuqG9HEcZREUvA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Q3p+3HCzxEU=:cEsUTY/+B6Q5ldnqr41OY4 Q8eX8/8SNJZ+eMcvdKvf0zCftu+Ks2qJ2N5mgVhwjvLAwVUB+hEJQxbBhPNqAu3CLXMbAzbPO DAQnuFv+M6/ULITz6Ep2g3hCrKViVaXxVnxMxcsPqrWRCnnpw/ouJkHzw+ahro9gOcpns9v+2 Xmt8VPajIax4yIYsLlGbp2TVF4AqouYOSdmg6bS2Axo9doti+XIMkZYtPu6Vh+bi+8jdsx+Jh T4z7LlgApHAxYNpCEhb+RDrYlf5VcPFullP5pr+rKYlp15hXYckct16shiOEekSA6m21Wnb7u 42+BOKwsjPenaMGGUIUeXQ/DZOwLEA+8J8JzqbcAYSqvPfdV5QntHD0j3VfpL+lNVdAczhF0y Wzya/aeDuMVv63OirQ7O12vWMSfbk+Iq/QocVxRBD2/eRmUkhcR/os0fZVNgPGBixFQ8bYc2s xzSFfUBKXmja/SiZY7rgMUUDYXdPtMjAKyGpHNBLiEaef19yYDV9BtNDtmfEBHVOR3yqpsrKv csnffFlqI9k4wWS8o6z5h5ScxA/lQIqZvENjhwgIc2V/NWhDzo8GDkH9xHUyIxJmetBgvvdfJ hnTBD3e5uS8ZSUdKjvu7MNdn4DgqOZa9ynxaLJfyRLJQ3XpRX81irxrazKDsfBtQ6GShzTl5a BGfM8MuzGrvL68pRUqerrj0vAPUqXUsnKalGhUrSYBR6t/xwYQYGSwWs06HvAHp511BXddA75 QwEij1nZi4zCnt+8OhMGXzphX1dCusolDNr7dqxznjtJC0Z9lPUAf/sTlomY+ivv2EEc13LdN JawZnJq/xwCQTM2Z658VNspc2WDoAniSZHEr+ggtt1B9N3Y2Hb5QCXZcTDUp/FUqSfjOfYBqQ /hCf8SbVLqgWvnPv6jEfGG2ryBxX7osw6dChbN/u/AVb3rAlGWLvQT3FBI949B2uUOn84H819 j8LVD44xXYTW3egCBF/rJ8IIC7k7QyEYA1LhramMPXT1yBKwSRocqeVoueCmuaI+IxYn2vvJi RD+MpoyDVxcJHDQRmMOBmbnpXHa+mdcUYTD977n8TDL+OCtNQnL2dTAfhztTTgULiYdSM7b4Y 5GUV4UsOLdTsCk= X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54481 Cc: Lars Ingebrigtsen , 54481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) dick writes: > Reproduce via: > > src/emacs -Q -nw --eval "(setq debug-on-error t)" --eval > "(custom-set-variables '(hl-line-sticky-flag nil))" -f > global-hl-line-mode I'm sorry about the missing recipe, it had been very late when I had discovered the problem. Anyway, you were able to fix it nonetheless, thank you. Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 23 04:48:42 2022 Received: (at 54481) by debbugs.gnu.org; 23 Mar 2022 08:48:42 +0000 Received: from localhost ([127.0.0.1]:42718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWwfZ-0004Iz-GN for submit@debbugs.gnu.org; Wed, 23 Mar 2022 04:48:42 -0400 Received: from sonic306-20.consmr.mail.ne1.yahoo.com ([66.163.189.82]:39432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWwfW-0004Ii-KJ for 54481@debbugs.gnu.org; Wed, 23 Mar 2022 04:48:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648025311; bh=i9LFlcFcg73aDffnAjvxwWhY5BG/RI3MFwqJ81R7Jl0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=Eiywfm/sJn9t5rF7OZvHed6JRAnNAbqWJT34LcZjQ+d9an3ByO+5ZN6Y3x6VBearc/CrAv5aa/IbxOzcz2qFcIqcBvgkSLC5jvRnvjeVI478J1VEEe1rxQ9GNKUys6J1Sm9oHoemT64vRVerTBXtDPIgtnm4TYg7qhk9yJI2N7epIihXlLPA66vGJvlXu3NUobhfiJbW5qMRX5GVbVdEqw1hRAn/WZdaMK+2a9pIayVEWPDAYYVEmRzCA7cT4QZkOQ0BuzvA22m/w4yigYOGaXljGP/UC+RpVbjR7Ww/JSczSQZykXBxeXEUyde8pwn2B51eEy/ZRA0jdehdQtDk6A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648025311; bh=CjJdlVapfdMyXEiSxG/W2ytDc599aa/KFassNdMQs4+=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=dr8UMBUIV6TnX1R3iZ5XX8CjlbK+pksKOKAtxsBTZQqXnKznccOwoYnRsLUMA/K8+D16tLhpGAMTohpPP06rTvuF7pUZO4RuW6qRI87c95EyEaUnph8BXkvmtYPtDiTxNj/jc4OgzUeBKjqywu9zlahaQb0KyV8J46XvSd4tinE+fu8DArRe/z3kCDFpaWmd8uxWXUJGlFKCIrlj//l08PYiTkkP6BwN3lZhCHLtqu7+jHqKa6ylPA9V/COkK0k2m/a4VjMy15iuII4sWkfB/g9NoNYbzOw0uvwKc5l18ekkyh6mU3PmYAS59hKlkdU4DOQcJR26ukaZBoXuqTIEZA== X-YMail-OSG: S6MRKTEVM1mrwQxfZoKpqNVp8LnGEAubTQGRCaVVC9f5LlThX_pU9QVPiCGQX5_ 2oqVgvbGQaHPvEok4J_Z5GH49CAB0VNo9PnGefJYJFc4tT_4pDl69UY5txZSUeyhUriH1G_.XrIa HJsf7nczGTKBg.erzuXuwd52YV20fxi_oWEXovE8d6elP1UR927IUD3U14KUitrUTDjElLidDIBP 4HwQelzBldvdL8uIyVjKLsiFGGErexv8RzIFpVM1J7Ip1Zsyx.2xFfQU1Yd66S4qAT425iqgw4XA euOsIztbb9FduTThZ.Vjze3A.48mFTPl_abkJm.l6icJn__GMgDAJTc2lroBlX._z1dxt1J_e.Yq thLwbBlVpaNpXrEvsTNedUHgL48pf6ql4bgYr3T1H8oecj2qCzBkBSGSTunrwprhvuxSQlXkBQsd TUstw6SNTKYXnSyPFWkhJQ_VEGJPfqWY9nMyJGDR7j0Nl29otEOsG9shVVTIfQpmI5Ft4MKf5e_4 4s3amn2iM.wmGLXYPL.OxhiA.N7MMKB0mhExO015JpUsoKvpfP1Ye5isHDgfFrSMZzQW_P.yDK9E HUkIVb8HUq84FxsJGSCWK8xLhnX8qUfSXRCWk0KL4llT.Jd3B1zHKhAPrbNMCUgmTOLsPd5L2GK7 3PmFBWPb8FqvM.Wcl8SIOZY69sxqn5LaFp6FnMTzKmfFYbrE0S.fDWN6rgXVPuw9_YLsZM79AQ27 XzHVdizhEn1tNqtTNptIjd8mldC2TQHx1.MhA1Yk3INxbOKi_IgzhJ1JkPchLhaFyGj3rNm9Xybo sV96xpif1IAyUeUPoim806zg9iOy1540m62cOFSvG7_2PtweOdRoKHGvuTmJlgMpXtuYjPqfA8UJ sbYLNJGvIckfkvjcoi9rnjycBY.8MsGBI2ZOucDsT1gA19N2fYlOBIEEBmeE2fXlUzD9X8oeqJnh lUbfs9r4gPkVxeV_RBI6alzzJp9kuwT9vDVFtZhxgloZiIPES2_ycGY67Dx2HXVfg3AsxWq_Cjrg wuktY87pISHcPHknSQCWLVIgvneqb1ipSHdyZJITpM8I5.d4gHGLUnO.B80NAR2i5Y5YRGbf3GAx ZMKZFThDatWnHIfuZqG.TP0VjM8V63audMltaoFLy3pq3PIEL14J1MchGWKgoai3N0eTXXwM0UG7 moR5vsCO2B1Diq9iYGVi.Ei8S71bK9AD2no..O2l7FPNE.lZzbG.RbMgaJ4hyCgAY3nC.A8MvaWK sj8jRtxXL3SvSFCGyDs31OSRNgGJtdM.9wFR.sVAIfg9_efC0nWBdrOsl6dUsQDlpXW8Nt0Mm0cU 6WUn.N45RrmaoFV_lOj5akKrCTC5pvJp3zQ2eiJardQ3h0CXSddgkDsoJ7fuW8EzmciK54Cy_ngF kn4qB_gpVmMSclA9j1PXmJP7tVqBfiYogMKqmJONJtOFmcLonM4ocns1k.gv9pV8a_kA8Uxh1FOl ORHD78ViVwxXI5bC3X.6rNnVST4R4Uofl.oRd7RHpkbIbjSxFqXqcVD8JDBO939YKmA2200bdg4s 8sYA9dtZLM0syM_NKaSq77oAQFe1TMH9OLX4Zp0CusOFjKKDpy07O6CfHf8ip.xLNF734KmVFQlQ RcaV5mEfySb.p85iyciUPplzn5dwMKiVMbQkyZGfRB3N_h.5Kehvt2fBLIUosO7p.6xmjmLDVS_5 q1Kz.Vef6L_IHRmSR3qnaeOzDyxYXS_DBdKnEk191GkSTxrWYboAGlB054kA1dYNrZggYjrgIozK qb0Yutw2Rh4b09bbUllLygw_.xS3i2FdOS1sswosjYtNRXAerKozu30bvRCH_65R7LIUpRwd2FwO Mn18TNn4IGyeOgQQUJBc75y84VV7ufLtvqDh0RGrI4KiMl4hX_LOmJwO.Oppqy90YaaDckERUu.u VtTlObvDNdVqDfzBw0_CqocivlV9ViHcbBT.NS_aT98c4ohXf9Jm6TL7d3_aPN_wvdDZkgjSn94i gL6ph2.uuwqts9lQWWkb.30YWpsMiy4taFK4spvMZZvZVbwN1.X9WsHAj3Alr3Epbx7CZLMU8FRB e6xI5HmavLb8htK7uopHItsLwzsixcboU3ErKr86uWPH9j5i9ADalJY2t1CP3B5hEZCkfhYJDupT dXeup3dOnsPZL4GgsMtw79Ut0omIAoe_rWsO.ygPuATXWmmtZvcyr2W2RruYIJ28ng_OIweWPrYI 1vR3cqISWVC7cuf8.cLaz9ONSsxlR04s0AjXyQsI.bde718GRKWaYfArukuhWedhM X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Wed, 23 Mar 2022 08:48:31 +0000 Received: by kubenode518.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 995bbe2a5419412c53b82d4d706f6605; Wed, 23 Mar 2022 08:48:25 +0000 (UTC) From: Po Lu To: Lars Ingebrigtsen Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line References: <877d8o8vuk.fsf@dick> <87y213mjf7.fsf@gnus.org> <87tubqkf3g.fsf@yahoo.com> Date: Wed, 23 Mar 2022 16:48:21 +0800 In-Reply-To: <87tubqkf3g.fsf@yahoo.com> (Po Lu's message of "Tue, 22 Mar 2022 08:25:55 +0800") Message-ID: <87czidcawa.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19894 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 14592 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54481 Cc: 54481@debbugs.gnu.org, dick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Po Lu writes: > Now, ironically, that patch introduced at least two incompatible changes > which are likely to affect users: `hl-line' is no longer a face, and > `hl-line-face' (a variable) has been replaced by the face. > > Of course, with no updates to the version field, NEWS, or the > documentation. I tried to fix it, but I might've missed something. And that was before I realized there's no way to set stickyness separately for the global mode and minor mode anymore. Not to mention the plethora of unwarranted (and undocumented) obsoletions, especially that of `hl-line-range-function', which is supposed to be used by packages to customize the position of the highlight overlay. So how about this to get us back to where we were, with the one real improvement of `hl-line-overlay-priority' being made a defcustom? diff --git a/lisp/hl-line.el b/lisp/hl-line.el index f1c2e1ebf2..20b3f4160f 100644 --- a/lisp/hl-line.el +++ b/lisp/hl-line.el @@ -24,40 +24,58 @@ ;;; Commentary: -;; Proper scuttling of unsticky overlays relies on `post-command-hook` -;; being called on a buffer switch and the stationarity of -;; `hl-line--buffer` across switches. One could easily imagine -;; programatically defeating unsticky overlays by bypassing -;; `post-command-hook`. +;; Provides a local minor mode (toggled by M-x hl-line-mode) and +;; a global minor mode (toggled by M-x global-hl-line-mode) to +;; highlight, on a suitable terminal, the line on which point is. The +;; global mode highlights the current line in the selected window only +;; (except when the minibuffer window is selected). This was +;; implemented to satisfy a request for a feature of Lesser Editors. +;; The local mode is sticky: it highlights the line about the buffer's +;; point even if the buffer's window is not selected. Caveat: the +;; buffer's point might be different from the point of a non-selected +;; window. Set the variable `hl-line-sticky-flag' to nil to make the +;; local mode behave like the global mode. -;;; Code: +;; You probably don't really want to use the global mode; if the +;; cursor is difficult to spot, try changing its color, relying on +;; `blink-cursor-mode' or both. The hookery used might affect +;; response noticeably on a slow machine. The local mode may be +;; useful in non-editing buffers such as Gnus or PCL-CVS though. + +;; An overlay is used. In the non-sticky cases, this overlay is +;; active only on the selected window. A hook is added to +;; `post-command-hook' to activate the overlay and move it to the line +;; about point. + +;; You could make variable `global-hl-line-mode' buffer-local and set +;; it to nil to avoid highlighting specific buffers, when the global +;; mode is used. -(make-obsolete-variable 'hl-line-overlay 'hl-line--overlay "29.1") -(make-obsolete-variable 'global-hl-line-overlay nil "29.1") -(make-obsolete-variable 'global-hl-line-overlays nil "29.1") -(make-obsolete-variable 'global-hl-line-sticky-flag nil "29.1") -(make-obsolete-variable 'hl-line-overlay-buffer 'hl-line--buffer "29.1") -(make-obsolete-variable 'hl-line-range-function nil "29.1") +;; By default the whole line is highlighted. The range of highlighting +;; can be changed by defining an appropriate function as the +;; buffer-local value of `hl-line-range-function'. -(defvar-local hl-line--overlay nil - "The prevailing highlighting overlay per buffer.") +;;; Code: + +(defvar-local hl-line-overlay nil + "Overlay used by Hl-Line mode to highlight the current line.") -(defvar hl-line--buffer nil - "Used to track last buffer.") +(defvar-local global-hl-line-overlay nil + "Overlay used by Global-Hl-Line mode to highlight the current line.") -;; 1. define-minor-mode creates buffer-local hl-line--overlay -;; 2. overlay wiped by kill-all-local-variables -;; 3. post-command-hook dupes overlay -;; Solution: prevent step 2. -(put 'hl-line--overlay 'permanent-local t) +(defvar global-hl-line-overlays nil + "Overlays used by Global-Hl-Line mode in various buffers. +Global-Hl-Line keeps displaying one overlay in each buffer +when `global-hl-line-sticky-flag' is non-nil.") (defgroup hl-line nil "Highlight the current line." :version "21.1" :group 'convenience) -(defface hl-line '((t :inherit highlight :extend t)) - "Default face for highlighting the current line in hl-line-mode." +(defface hl-line + '((t :inherit highlight :extend t)) + "Default face for highlighting the current line in Hl-Line mode." :version "22.1" :group 'hl-line) @@ -69,77 +87,204 @@ hl-line-face (set symbol value) (dolist (buffer (buffer-list)) (with-current-buffer buffer - (when hl-line--overlay - (overlay-put hl-line--overlay 'face hl-line-face)))))) + (when (overlayp hl-line-overlay) + (overlay-put hl-line-overlay 'face hl-line-face)))) + (when (overlayp global-hl-line-overlay) + (overlay-put global-hl-line-overlay 'face hl-line-face)))) (defcustom hl-line-sticky-flag t - "Non-nil to preserve highlighting overlay when focus leaves window." + "Non-nil means the HL-Line mode highlight appears in all windows. +Otherwise Hl-Line mode will highlight only in the selected +window. Setting this variable takes effect the next time you use +the command `hl-line-mode' to turn Hl-Line mode on. + +This variable has no effect in Global Highlight Line mode. +For that, use `global-hl-line-sticky-flag'." :type 'boolean :version "22.1" - :group 'hl-line - :initialize #'custom-initialize-default - :set (lambda (symbol value) - (set-default symbol value) - (unless value - (let ((selected (window-buffer (selected-window)))) - (dolist (buffer (buffer-list)) - (unless (eq buffer selected) - (with-current-buffer buffer - (hl-line-unhighlight)))))))) + :group 'hl-line) + +(defcustom global-hl-line-sticky-flag nil + "Non-nil means the Global HL-Line mode highlight appears in all windows. +Otherwise Global Hl-Line mode will highlight only in the selected +window. Setting this variable takes effect the next time you use +the command `global-hl-line-mode' to turn Global Hl-Line mode on." + :type 'boolean + :version "24.1" + :group 'hl-line) + +(defvar hl-line-range-function nil + "If non-nil, function to call to return highlight range. +The function of no args should return a cons cell; its car value +is the beginning position of highlight and its cdr value is the +end position of highlight in the buffer. +It should return nil if there's no region to be highlighted. + +This variable is expected to be made buffer-local by modes.") + +(defvar hl-line-overlay-buffer nil + "Most recently visited buffer in which Hl-Line mode is enabled.") (defcustom hl-line-overlay-priority -50 "Priority used on the overlay used by hl-line." :type 'integer - :version "22.1" - :group 'hl-line) - -(defcustom hl-line-highlight-hook nil - "After hook for `hl-line-highlight'. -Currently used in calendar/todo-mode." - :type 'hook + :version "28.1" :group 'hl-line) ;;;###autoload (define-minor-mode hl-line-mode - "Toggle highlighting of the current line." + "Toggle highlighting of the current line (Hl-Line mode). + +Hl-Line mode is a buffer-local minor mode. If +`hl-line-sticky-flag' is non-nil, Hl-Line mode highlights the +line about the buffer's point in all windows. Caveat: the +buffer's point might be different from the point of a +non-selected window. Hl-Line mode uses the function +`hl-line-highlight' on `post-command-hook' in this case. + +When `hl-line-sticky-flag' is nil, Hl-Line mode highlights the +line about point in the selected window only." :group 'hl-line (if hl-line-mode (progn - (hl-line-highlight) + ;; In case `kill-all-local-variables' is called. (add-hook 'change-major-mode-hook #'hl-line-unhighlight nil t) + (hl-line-highlight) + (setq hl-line-overlay-buffer (current-buffer)) (add-hook 'post-command-hook #'hl-line-highlight nil t)) (remove-hook 'post-command-hook #'hl-line-highlight t) - (remove-hook 'change-major-mode-hook #'hl-line-unhighlight t) + (hl-line-unhighlight) + (remove-hook 'change-major-mode-hook #'hl-line-unhighlight t))) + +(defun hl-line-make-overlay () + (let ((ol (make-overlay (point) (point)))) + (overlay-put ol 'priority hl-line-overlay-priority) ;(bug#16192) + (overlay-put ol 'face hl-line-face) + ol)) + +(defun hl-line-highlight () + "Activate the Hl-Line overlay on the current line." + (if hl-line-mode ; Might be changed outside the mode function. + (progn + (unless (overlayp hl-line-overlay) + (setq hl-line-overlay (hl-line-make-overlay))) ; To be moved. + (overlay-put hl-line-overlay + 'window (unless hl-line-sticky-flag (selected-window))) + (hl-line-move hl-line-overlay) + (hl-line-maybe-unhighlight)) (hl-line-unhighlight))) (defun hl-line-unhighlight () - (when hl-line--overlay - (delete-overlay hl-line--overlay) - (setq hl-line--overlay nil))) + "Deactivate the Hl-Line overlay on the current line." + (when (overlayp hl-line-overlay) + (delete-overlay hl-line-overlay) + (setq hl-line-overlay nil))) -(defun hl-line-highlight () - (unless (minibufferp) - (unless hl-line--overlay - (setq hl-line--overlay - (let ((ol (make-overlay (point) (point)))) - (prog1 ol - (overlay-put ol 'priority hl-line-overlay-priority) - (overlay-put ol 'face hl-line-face))))) - (move-overlay hl-line--overlay - (line-beginning-position) - (line-beginning-position 2)) - (when (and (not (eq hl-line--buffer (current-buffer))) +(defun hl-line-maybe-unhighlight () + "Maybe deactivate the Hl-Line overlay on the current line. +Specifically, when `hl-line-sticky-flag' is nil deactivate all +such overlays in all buffers except the current one." + (let ((hlob hl-line-overlay-buffer) + (curbuf (current-buffer))) + (when (and (buffer-live-p hlob) (not hl-line-sticky-flag) - (buffer-live-p hl-line--buffer)) - (with-current-buffer hl-line--buffer + (not (eq curbuf hlob)) + (not (minibufferp))) + (with-current-buffer hlob (hl-line-unhighlight))) - (setq hl-line--buffer (current-buffer)) - (run-hooks 'hl-line-highlight-hook))) + (when (and (overlayp hl-line-overlay) + (eq (overlay-buffer hl-line-overlay) curbuf)) + (setq hl-line-overlay-buffer curbuf)))) + +;;;###autoload +(define-minor-mode global-hl-line-mode + "Toggle line highlighting in all buffers (Global Hl-Line mode). + +If `global-hl-line-sticky-flag' is non-nil, Global Hl-Line mode +highlights the line about the current buffer's point in all live +windows. + +Global-Hl-Line mode uses the function `global-hl-line-highlight' +on `post-command-hook'." + :global t + :group 'hl-line + (if global-hl-line-mode + (progn + ;; In case `kill-all-local-variables' is called. + (add-hook 'change-major-mode-hook #'global-hl-line-unhighlight) + (global-hl-line-highlight-all) + (add-hook 'post-command-hook #'global-hl-line-highlight)) + (global-hl-line-unhighlight-all) + (remove-hook 'post-command-hook #'global-hl-line-highlight) + (remove-hook 'change-major-mode-hook #'global-hl-line-unhighlight))) + +(defun global-hl-line-highlight () + "Highlight the current line in the current window." + (when global-hl-line-mode ; Might be changed outside the mode function. + (unless (window-minibuffer-p) + (unless (overlayp global-hl-line-overlay) + (setq global-hl-line-overlay (hl-line-make-overlay))) ; To be moved. + (unless (member global-hl-line-overlay global-hl-line-overlays) + (push global-hl-line-overlay global-hl-line-overlays)) + (overlay-put global-hl-line-overlay 'window + (unless global-hl-line-sticky-flag + (selected-window))) + (hl-line-move global-hl-line-overlay) + (global-hl-line-maybe-unhighlight)))) + +(defun global-hl-line-highlight-all () + "Highlight the current line in all live windows." + (walk-windows (lambda (w) + (with-current-buffer (window-buffer w) + (global-hl-line-highlight))) + nil t)) + +(defun global-hl-line-unhighlight () + "Deactivate the Global-Hl-Line overlay on the current line." + (when (overlayp global-hl-line-overlay) + (delete-overlay global-hl-line-overlay) + (setq global-hl-line-overlay nil))) -(defun hl-line-turn-on () - (unless (minibufferp) - (let (inhibit-quit) - (hl-line-mode 1)))) +(defun global-hl-line-maybe-unhighlight () + "Maybe deactivate the Global-Hl-Line overlay on the current line. +Specifically, when `global-hl-line-sticky-flag' is nil deactivate +all such overlays in all buffers except the current one." + (mapc (lambda (ov) + (let ((ovb (overlay-buffer ov))) + (when (and (not global-hl-line-sticky-flag) + (bufferp ovb) + (not (eq ovb (current-buffer))) + (not (minibufferp))) + (with-current-buffer ovb + (global-hl-line-unhighlight))))) + global-hl-line-overlays)) + +(defun global-hl-line-unhighlight-all () + "Deactivate all Global-Hl-Line overlays." + (mapc (lambda (ov) + (let ((ovb (overlay-buffer ov))) + (when (bufferp ovb) + (with-current-buffer ovb + (global-hl-line-unhighlight))))) + global-hl-line-overlays) + (setq global-hl-line-overlays nil)) + +(defun hl-line-move (overlay) + "Move the Hl-Line overlay. +If `hl-line-range-function' is non-nil, move the OVERLAY to the position +where the function returns. If `hl-line-range-function' is nil, fill +the line including the point by OVERLAY." + (let (tmp b e) + (if hl-line-range-function + (setq tmp (funcall hl-line-range-function) + b (car tmp) + e (cdr tmp)) + (setq tmp t + b (line-beginning-position) + e (line-beginning-position 2))) + (if tmp + (move-overlay overlay b e) + (move-overlay overlay 1 1)))) (defun hl-line-unload-function () "Unload the Hl-Line library." @@ -151,12 +296,6 @@ hl-line-unload-function ;; continue standard unloading nil) -;;;###autoload -(define-globalized-minor-mode global-hl-line-mode - hl-line-mode hl-line-turn-on - :group 'hl-line - :version "29.1") - (provide 'hl-line) ;;; hl-line.el ends here From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 23 07:55:45 2022 Received: (at 54481) by debbugs.gnu.org; 23 Mar 2022 11:55:45 +0000 Received: from localhost ([127.0.0.1]:42945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWzab-00039q-0T for submit@debbugs.gnu.org; Wed, 23 Mar 2022 07:55:45 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWzaZ-00039a-UB for 54481@debbugs.gnu.org; Wed, 23 Mar 2022 07:55:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qKM7PjUD6o1ds/La629aAjFxvCXSDVFVM4cej4LkzDI=; b=fp6S7HJ55mJKuDRDJkndGWfTZM 937QVyE4v8OhK06MC6F7wlMfHBarx1vsy7QglDs3aSSjxueIYyGjB1dp1xeIS6KLkCJ8qnj2+fbxt hLUKLihJCbkTMa09Tg4r3IwL7r3rCrEbn1+GQYvS4zRU6y6TN0LL2I58WfU6r6zDLaAY=; Received: from 109.179.236.69.tmi.telenormobil.no ([109.179.236.69] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWzaR-0003BS-GR; Wed, 23 Mar 2022 12:55:37 +0100 From: Lars Ingebrigtsen To: Po Lu Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line References: <877d8o8vuk.fsf@dick> <87y213mjf7.fsf@gnus.org> <87tubqkf3g.fsf@yahoo.com> <87czidcawa.fsf@yahoo.com> Date: Wed, 23 Mar 2022 12:55:34 +0100 In-Reply-To: <87czidcawa.fsf@yahoo.com> (Po Lu's message of "Wed, 23 Mar 2022 16:48:21 +0800") Message-ID: <87pmmcannt.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Po Lu writes: > So how about this to get us back to where we were, with the one real > improvement of `hl-line-overlay-priority' being made a defcustom? Yeah, I guess so. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54481 Cc: 54481@debbugs.gnu.org, dick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Po Lu writes: > So how about this to get us back to where we were, with the one real > improvement of `hl-line-overlay-priority' being made a defcustom? Yeah, I guess so. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 23 09:02:38 2022 Received: (at 54481) by debbugs.gnu.org; 23 Mar 2022 13:02:38 +0000 Received: from localhost ([127.0.0.1]:43088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nX0dK-0000zx-3A for submit@debbugs.gnu.org; Wed, 23 Mar 2022 09:02:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nX0dH-0000zh-R6 for 54481@debbugs.gnu.org; Wed, 23 Mar 2022 09:02:36 -0400 Received: from [2001:470:142:3::e] (port=35654 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nX0dC-0005NG-Cv; Wed, 23 Mar 2022 09:02:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aCsIFtW54WpuIPdv2tbNW6WXfaLACkc6yr7wogpjrhw=; b=QkSszZl9VU7o Xu0IrdVfbAa1LPb+ogn7K1hFV6gy9xJ/ZlUeKglRUGAGTCFhI1x79UPoYVU9Horcqr7kzrxaJxJv9 9GUXN37yAaAnQILpbruGc3fhuIbAw5Ef3moB9g6seOrdT1REaZAPZXeWPuqXboAw812wHWhWK9n6L YD76Ol6NtKCQNRjWrLHXpW1jw6Yg4yzBhmQg0gVQpD6wa3ygXxHbbTeriZ2+3z/rlZhD9NANNMkBb iLbrfnwwXBM9Q6AJiIbAz5L0URCi3k+gHFHz93KWZgRwMiqyFRtx8MYjiyqAwZ8xIrKJ9643iXUtz It9jLeiosebUUSxjOiy4sA==; Received: from [87.69.77.57] (port=3815 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nX0dB-0002Bh-SE; Wed, 23 Mar 2022 09:02:30 -0400 Date: Wed, 23 Mar 2022 15:02:18 +0200 Message-Id: <83ils4es9x.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <87czidcawa.fsf@yahoo.com> (bug-gnu-emacs@gnu.org) Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line References: <877d8o8vuk.fsf@dick> <87y213mjf7.fsf@gnus.org> <87tubqkf3g.fsf@yahoo.com> <87czidcawa.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54481 Cc: larsi@gnus.org, 54481@debbugs.gnu.org, dick.r.chiang@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 54481@debbugs.gnu.org, dick > Date: Wed, 23 Mar 2022 16:48:21 +0800 > From: Po Lu via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > +(defun hl-line-move (overlay) > + "Move the Hl-Line overlay. > +If `hl-line-range-function' is non-nil, move the OVERLAY to the position > +where the function returns. If `hl-line-range-function' is nil, fill ^^^^^ Not "where", "which". "Position where the function returns" might be easily misinterpreted. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 23 09:39:03 2022 Received: (at 54481) by debbugs.gnu.org; 23 Mar 2022 13:39:04 +0000 Received: from localhost ([127.0.0.1]:43178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nX1CZ-0004C5-Kw for submit@debbugs.gnu.org; Wed, 23 Mar 2022 09:39:03 -0400 Received: from mail-qv1-f41.google.com ([209.85.219.41]:37502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWzHX-0002aJ-AX for 54481@debbugs.gnu.org; Wed, 23 Mar 2022 07:36:03 -0400 Received: by mail-qv1-f41.google.com with SMTP id k7so957523qvc.4 for <54481@debbugs.gnu.org>; Wed, 23 Mar 2022 04:36:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=hX2G5LQpZE/zxDW+AR8uZE99d93ANoVaDypAlfDpMsg=; b=AqrXgiNTHaxfCG6vVh12rlREaAsv39f+JzanHi2eHCZoNxfS3ieVZPeJ5n7XnnLeX5 z6tMatS8zPRG5wDqWO0PdNQgTZOD4SXNI01zOlxkKGyy9IyEadkoCXULNhlBmX49CNt1 xmkYV+8GTz6Yucsdm7MQKunW8fJVvxUX0bhUrrXJJ95iZ3PfbcFvfB7N4vD7MgU1eEqG +32xk6vHlIHw8cOubD2lnTn3/bvnzGB5yaBpOBpSTA9AA+d5Qy69wFSAkY8y6kM20XBg AsfEGBqgk1k3XXK7GbCposA/H/z7GPrevqDsLXHVOhNn9xaC9Y4HOHsJG5VePkjZZGbb A/jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=hX2G5LQpZE/zxDW+AR8uZE99d93ANoVaDypAlfDpMsg=; b=sSGdStbYYUQh2G+qk4sOp5Yvp90VQXmmn2f14tDP+ntqs4P+Z5LDvGx3z0gIQKnlHq ENH/Y1Kh0pYbAZbWxSbS93tnxVoGBXu+jNgBkjCptx1+2U5YexVajf1uEDbdm0ArrMHb 8cwhJLOwcKUWelZ8N1yhK6lECyasEpz62N0A4nVA6k1XGfGbLLamg1VjVgI1EN1X950n 3EzbkGXfbamOwnGAvo8AjQGwFANWQyaBWwjWwrQIGLbx8GK4HjzTjSd0N/aD8p3UDZAM t5FypX8ZG31T+DWH/W1hu7XpCBymWK8ysT53HDE2fRZNcPQ3UAB/siUL9cRwlh7WdCX6 /IAw== X-Gm-Message-State: AOAM531sPcodJI5zFHpC7Z2NxS3qG4kuCAJJkduPU+kFagac0W5N5r1T LChqwyWduVeTnYaL4XSDBnY= X-Google-Smtp-Source: ABdhPJxB5hRtZQWMsFyCadvyOEf92q2cT71Cgg+TAHs3+kYx+gVdP6GMVgE6d/2CycC87YWFy5dhSg== X-Received: by 2002:a05:6214:2305:b0:432:f1d4:6177 with SMTP id gc5-20020a056214230500b00432f1d46177mr23632634qvb.107.1648035357823; Wed, 23 Mar 2022 04:35:57 -0700 (PDT) Received: from localhost (pool-96-232-253-158.nycmny.fios.verizon.net. [96.232.253.158]) by smtp.gmail.com with ESMTPSA id br35-20020a05620a462300b0067e890073cbsm5296019qkb.6.2022.03.23.04.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 04:35:57 -0700 (PDT) From: dick To: Po Lu Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line References: <877d8o8vuk.fsf@dick> <87y213mjf7.fsf@gnus.org> <87tubqkf3g.fsf@yahoo.com> <87czidcawa.fsf@yahoo.com> Date: Wed, 23 Mar 2022 07:35:56 -0400 In-Reply-To: <87czidcawa.fsf@yahoo.com> (Po Lu's message of "Wed, 23 Mar 2022 16:48:21 +0800") Message-ID: <875yo4dhpf.fsf@dick> User-Agent: Gnus/5.14 (Gnus v5.14) Commercial/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54481 X-Mailman-Approved-At: Wed, 23 Mar 2022 09:39:03 -0400 Cc: Lars Ingebrigtsen , 54481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > So how about this to get us back to where we were, with the one real > improvement of `hl-line-overlay-priority' being made a defcustom? You hold all the cards, sir. Nothing in the past has prevented you from unilaterally quashing my changes. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 23 23:23:43 2022 Received: (at 54481) by debbugs.gnu.org; 24 Mar 2022 03:23:43 +0000 Received: from localhost ([127.0.0.1]:46517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXE4d-0006Jm-CL for submit@debbugs.gnu.org; Wed, 23 Mar 2022 23:23:43 -0400 Received: from mout.web.de ([217.72.192.78]:48311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXE4b-0006JW-RG for 54481@debbugs.gnu.org; Wed, 23 Mar 2022 23:23:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1648092214; bh=qxZk432AU2pfkYYt/IWspjFkp++YYgukG3mcwsuNxuE=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=bIDbRG6+mgc+iU6dsmvYs26GR5GqdjXAoKdQncIlHfMbB9FeTNT7YgPi8ioJVki7Q SOoEIJWDbDsMLBEvCIvoi+KFv22ATjtGP47b+Mg9TWDxD9jq6R3ZbA63eSXl9wQeaz U4A6I9TuFj0oRxQ/6OPGhRFPe3blbdmMkysNvG9s= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.60.174.212]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MOUxo-1nijLE3HHK-00PwAh; Thu, 24 Mar 2022 04:23:34 +0100 From: Michael Heerdegen To: dick Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line References: <877d8o8vuk.fsf@dick> <87lex2vfux.fsf@web.de> <87zglikra6.fsf@gnus.org> <875yo63w0v.fsf@dick> <87czidmms8.fsf@web.de> Date: Thu, 24 Mar 2022 04:23:34 +0100 In-Reply-To: <87czidmms8.fsf@web.de> (Michael Heerdegen's message of "Wed, 23 Mar 2022 03:21:27 +0100") Message-ID: <87a6dg58zt.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:eNARPtTxwFYJGhbL8CzgWKv/V7jZ4R2h83UdJGn9lxsejuTo+eG h4KGI4jaTh/8BSZnIfXHuow8UU/VthHHSMCWvOAKZedT1ES8W+9M1nAQjrXQmQrw8yZx9J8 Bm0bsQjVxe3gw2zJhbkD1K1i2FHMKkJ48q8jsWyLZZaKgrw0HskzQaXULQ0x4+XqtWV8jZ3 blnNC8FrmVEtkpn3+H8Jw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:aVklUxrRQMQ=:LaejMUfoRtq1I+jg8qE6nr bzQLEVkwYaUMlS1XJBgGKT/oeURrNv1YQxeA5avq6uM9bLZLzSpIYdX8a6w1vNlTEs2eaRA+M skLysYA1RmphAKTBshsoLAuNqGtMGtsb6M5L78lY9EAIa1Mgv43Jux/7q/Zxsv8eVmtO3ZIua FhUI/iarQ49LalS91P1STiLJmJBUFbow52Bg48rFq86YaKsMYlFmdMIPATEttC2tbNAw4veiD ZLJ6ZoMC3x3T1zfxBBE8GlfGHn9zoti2pPzjITPFDaXI9V7o5tsPHbjPA1wTa6cqHAmwVwbIC ezNh73gBaG4TaEMwjQpgcsmrOJtCtGxTQvuTq50AXbK3ZPJ9lCbMexH0hhrv9HUd9zT6zUI3U SAvM8Nek8227YXS6o0lzESx+w6IZEgY6ebkYZIhUDCQclamVtWVSRSHv2mhaFZhOSvNxxUF5/ bdJwWU83YxPbr5xWoPldwpg3/jtcZ3KqZB7DZMiQlFK7fL25SzcAq8ep74IOegpdqh3kb6L9U EpTG37Av3Vs78hcb6wh5R0Hk7NyfsLT/4ksBjMdqaIfyTKALHMWLhhiO0in1+8Cw6H/5418GP IWwvRCIRrHnoXYu5HJdQ9PmArux8NM7HmNlgXGxYzrRxOaOkWiwEoyvhgBhVao4eeGBQ3GrbW 7tLBDDu/PuCG3IGUvd45bpUT7hkPFXr1OF0tOQyZL5PZU/3MD+uBOQeqXaAzbbe3v89ymHJoM m56mcOKSNct6quBHceU53uh5DmTcah3NOLKJx8u1zbcXkTpf1ogGcR7nU6xpyfrh9qN2ywFFx Rkhhib2FRH4Bax/3ukS71d4cceJ0Vqr3z+smyQYf1Yso7BI8xf5QZfLow8nY7Jk9+TV+iYLhW Rh84TacLLr6/ZLHSLoiPHHguL/LYPWgQ6eZCoSU2FI9LnZQ1Yh9cLrqaRIdbXqsVJFTfbvf5Q k9S1PNKrNLzfpGy7vNBhoO1LmJHk37afcl57sqYPr0//CdGM8ILG3dizAjQaj+OMa/PMkgx0h M1tKvKaPKykY8m9yDr6K7Cnz1xG45J+qWnqS2ag8j0aV1u+rBLuFdg8QJeqguuA1FB61jagX4 YlHAMBYKvb8D3U= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54481 Cc: Lars Ingebrigtsen , 54481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Michael Heerdegen writes: > Anyway, you were able to fix it nonetheless, thank you. Seems it is broken again. Who was it this time? TIA, Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 23 23:39:32 2022 Received: (at 54481) by debbugs.gnu.org; 24 Mar 2022 03:39:32 +0000 Received: from localhost ([127.0.0.1]:46522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXEJs-0006iY-Mg for submit@debbugs.gnu.org; Wed, 23 Mar 2022 23:39:32 -0400 Received: from mout.web.de ([217.72.192.78]:56089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXEJb-0006i3-K0 for 54481@debbugs.gnu.org; Wed, 23 Mar 2022 23:39:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1648093142; bh=jxUFe0NJE6g7nm4KCH0+GkajIJ1riC33fzlI0MAMlNc=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=e9han+RVKvdcPQo4rtJlMCgzNDxHnTMm0QvTparv1OrUd4VHxplIt8jxJaJ90hxEh K6k72MUbALvQwDAolsTOjgdRwNQ1iH3vlHV9+pHxXPmRUDW5BE0gu2EjX6539N0dR4 uETYA0hRa7H5djPkU/xEWXvnBH44vzDqAibqXqJk= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.60.174.212]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MbCDq-1o469u10Ei-00bXho; Thu, 24 Mar 2022 04:39:02 +0100 From: Michael Heerdegen To: luangruo@yahoo.com Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line References: <877d8o8vuk.fsf@dick> <87lex2vfux.fsf@web.de> <87zglikra6.fsf@gnus.org> <875yo63w0v.fsf@dick> <87czidmms8.fsf@web.de> <87a6dg58zt.fsf@web.de> Date: Thu, 24 Mar 2022 04:39:01 +0100 In-Reply-To: <87a6dg58zt.fsf@web.de> (Michael Heerdegen's message of "Thu, 24 Mar 2022 04:23:34 +0100") Message-ID: <877d8kxbmy.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:n/Hxy4uHKOiKM3QBmZS9t/En1PJXEsF8+YOd8n/yXR1tbg1bMk8 dCdS2AqbDK9Wkimreea+SQocsKzuf+ZjoXeigilVEBZ0ZyKrRfjGnr6D5CSbd9A4eJIKJQe gVnt3s2C1nkkOfKWvZmlyW9VJgJRaGQ8Mh2oORuC+e7Lv05C6FYrOcWWLy+MJk3h/6ZIe0D Gl5/PJfwTN61iJg9bwa6A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ZcZhSwZEcBE=:6X5ajunSI4poHWw6C2tgNA nTIEOqQ+6/nI+nSvJ4w84CF+j25m8mFK/0YexEkAk3a964hW0RO++rovi4JhMmOsrbfx47N1N zCuji1qzyT8FubALZgstFtIx6nMc5VtuFWhFnNSRre4zuHbUkMuxvB1eKtnLdQXyb3Ab26hxT l/qgwS486tcKlCoj3tTCOworfhvMDD4xXX8unQyVp0hS8Dh03TXty+Z9FNx/YndpyVvZcnmxS opnuJ1y8Bug5yaXFMQ6D84XMt/LWKacvepwW41+3l92hs4GECpd/b+ywTCIJqNhNnizvD0Tnk 6ZmJhZWEXH0/l3CFWEaA+OgqFFbly4/FBBP3LBGvu/UX64zaDjhSqA7SyTfav5ifaBrdCgamN lf0nKf8yjJl3P4v73AgrFOUAMLAo/Ci0pGjDnakiZx7hkl8a6FGyITgcnsDD81TESO75K1Got U/KILpcrf72mqmpDC/cI9hwfM4lMdhKv+d7b7J4d5P0wr8trChuckRxf4b6Ks3WKNwC/nzkS3 Heat3eCmUyjki7JyW4BvJbb8cBTrdYGN6Et2sQNXA8o6Ncgv5DhqRqyIAweNFaUVhv1ugMYiH OPIu21vle/hzCvkVgL0q/EmnC7XlzbGZIOY4uZae0ES90C1b11UwBvUoDYXfNt+Q80xaXrWOK U1M1vuVDkTb92A1nHDr6Rep661Wz+zc3uOIgp86MhPPfPsb8HdHS761/ZSbTDlOBIgN7x5gLq UC+GjF5DI2H0Gpc1WGDM9AlX1f7EHWL31lyums1L94/IA9fGUB5bE83tZI5cRYeNGnSyW96Wq dkCyIrNtPV2rv1vkkBHHjvjxcA/7O0qZCKcDhoP6RpiJrCiGfinz7XM+QuBBONTV4YSdQN1ab 9RVNPzF23fYZDvOZt3MzuKtJrCK5rGpucCoFnSp1m/abVYsdxCVkPe/Qq4mLefyf9zCNbhpzo F972a6m+7eCoh4oeIF8iex7W/w1OIhFyPhYr19xP8z7+MJtOBxgqUZED2HYLS/IZHFm1wq0ej t1hrq5fL30qkDog0lX82RoxsstGCK4XmYDZncJAUEzAqFLRG4FBCywPjHutgyolqzUP5JTlv0 PpBAG9y4kuShEQ= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 54481 Cc: Lars Ingebrigtsen , 54481@debbugs.gnu.org, dick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Michael Heerdegen writes: > Seems it is broken again. Who was it this time? I think it was: 5811741eda "Fix hl-line tests", Po Lu 2022-03-23 Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 23 23:53:40 2022 Received: (at 54481) by debbugs.gnu.org; 24 Mar 2022 03:53:40 +0000 Received: from localhost ([127.0.0.1]:46537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXEXc-00076h-JV for submit@debbugs.gnu.org; Wed, 23 Mar 2022 23:53:40 -0400 Received: from sonic313-10.consmr.mail.ne1.yahoo.com ([66.163.185.33]:38752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXEXa-00076S-QF for 54481@debbugs.gnu.org; Wed, 23 Mar 2022 23:53:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648094012; bh=3OvdUJgYK5uB/h7K015qInpK0xjkkkQSLopVsfBswwA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=CSFUrvA8RgTRLphArVpJehO1yAQI0dJLh+HuZRLOHmjEb9gJUBSII5e9Zy3/pDBsFXOiK/ek25OFpofZjDkxlO4X8CDto9uAGGOn+VbYbPoF6sMBWtkqy3gniSY+MpaJZFJb2z71srvepqAB/ixEK7+H5bcFgUfZU4EV7Vtp4aZVCfrhdcGnzrnsYwtKQ5DFGa5jE41Ml4O53xQVaunsOOT6LY6XqSwrytLdbgUEQRNqwSUgXXT3O/Mjnl/gIwVKtLwFfTdwikODGudfvnwv3PgUhbP3pqwhBiJ4dQSnf+g8SV3iL2+9qn1ZSFbbkeCfaE2piZBh1Mi3pSGOYFjNCA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648094012; bh=OLJ3Effdq37ig38ekgNngbBqpeur9eR0OArdLskS7Pq=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=DdFe/I0NquIlfSv0oNhIOBDqOvj2Z5jkU8iB56OpvihSrWTwKzfOK83WK/S9zREPg2vEEXjMucBl0IsjED5OKw+5yRjj+41OOAHrSLUbupI+QDuiEMQzlwC4iZlL+1ADBAKz/QFzJ+2772A7tsK92j14gxdRongB2vQZC9sgy6xwH0zj+50/efCEesYimOfqqRc7yxcOdBNw5Nl9gi+/Zbd/eF8CsxJmcZjvmkfdImBwDaTpmCkJzEMg9XHvTBsyRDjmnYgMU2o5L5wFUqLcngrFA7ITIy3R3buJTCnEVHUdnkm5HO4tEVy5TaW7h3MzCYPYqPacJtvC5jw/V3HdrA== X-YMail-OSG: XvngMRoVM1n.Be2YYx8Wvr0bzFa.bdOuDVHYNmLC43aOyC_QiZzJB8D6uSNH2Dq LIdOukhLQmwJPQyZS7os7BPZlfNaSIuZHlAevWfyCpFnSPmKh6TmEz17A0IkzciISAmniXEGgabU E9Z2_o9ci4zg0t2pm82_Ty0xbYsPBgzidvl1hvYJ1ptfwtoGjZUfJQuvQtqhgFw_9XKGMzO7sGID 4cqHd1nOVHZU_jBdD4tlcPHQ4T.NYfyMIB4dvXE7I4VQnkjywo8BpP5I_g3ReoU6cJF3uHzTBHKJ fIJH5v8HmT_T5ue43Hl8RNo5qf3fxErnjCgFHf2FMWM5CFJZgKI3ivZVJPrh6Q7.GaDfGNe0CA.L ohYDKwZ8RJHqHTCZvBvIfXCOz9OT5yMNawVvRW9_JmBmMfxplyfc.78jLBS3wA6ilTBv4djqtXvd pWml.Yl.3p.UXqcEVA_w5KlJ.qLKRL_IW_TJ8RWwC81I3auzkQJq2i9tVQwrbGePCoW4eYSb_6C. TzPvR.1fXA12_vaxhuWDTCGeVsyOxPMUl77LY4umd7ZTxgkS2Nl2es.h4qD2Txh.1ZIUSnIHWI.y kh7sWPJe9TNNNvSzSM_cO.y45SQ_v1TU7fFjcU5hHtq3QTmZ9_zwBkbMSmMogusJpebRXhiONBh8 Oc2e_ysZsCljWff8jUUXA6vpis.ugA0E0pgMWL3uxpus6dAKk4xxIQCst3V4RYqwy2iqUwL229dR blEp9PGNsDekLcq6c9UrhPDamQVUxwfKG6ofqQynyyQ9DsjxLUeB_Gh4utvaxTU8mnrW6IVuu__x oMhvsIlZ4QMNN1ORYk0rFmxDSouyXNkyJflfKHq73w5QxlgamUYz7ZEl.VGHenwoP2n0C04vNb9B G349ivqaT_0jYF4dyHdZ249vXm3UrDhWRgt0L1fVnJWKHuokWt_Qd2lGBo0kkJRScBpffyglB49Q f0Ec6qUrqG09ilEsBSnmT6L82njQdXC7zeSvAT0hL6L9azsEDTlgx.FOyR_4Cw55.RTVuDsTZDjw TzZ7.jhBTrZhaK.rQLy76dPFxlZ8zkjp5ngF3TdbqfSpG4WgYXNAQygShGuxdX9xJtdUwVmIgSql uIVp6R9ogpn4SuntMiV7qwvn_h4E4MmymePznccnaoYM69KRVll3sYSeBJ1Jnwf.pGN2iWNSDc91 BLVrOUYoKEgKDSoEuNrl3LknrAPNwIVlTfsVVgdy_fJ_yMB3V6t.qB6Z1r.Dq1gmmarGPUOS6nZs 7LJ5u1L8D_LonI_rL166tsZb8S9YXWawL1SLNlapoM32P71iFVygbokcfe8q5KFyQLVfNZ7y_gnP PWLDCgJ7x2Bcj5hA7Re2cdiQRGjCfEzFffgICVChWe6UUBoGwcvv37WUisEN99lJMafOsJh2ggPy U_hcfEQ4EfUkQAspJovvBUBRgSrUwmm05w7WX_XqKdqT4cCNhrr1KvCrSRkhSpZKfSFj1q9py7mj hcFeSOVlPkFtPB7RnIKwKxvio.mUbOcAcDyJ0ssBetGEzwWA130e2md_vGy9ryoxrJuXaOCiHwhx 4M6HePq.YA.aAC4gSGydPg8hS5Et3A34gEdsbllkpCHn_eSCHqrHEviiwBpPuXzZ_RLCCYaXbQym _RN0cXHaGSplu8qV6Y9g_x3LbLMT9JcLvKnAPjFVhbXfINpcGhs1WT7m9ukiqXBAO4l8mvc2xG3u C__O81AH9J0Fd8Kbr57O.69CBhfcgY20yBohvqVUmzg4HI_ZFhA2.BOuWxougwQcwzGpsvjcHG.j 809EjdiUAFn9hkk08.zK8pPu8W5AQ2K5yXGuy22adEkSIUfhd6k9VbfjgPO.KJonSXwBDyvdLjAH zTcYcJEUZTelDcMgD_7Lq2PmkOluxdpLg_1sW807n7evq36rQVQjE84bg3Ga8u9tIwwnaXseXH_W SH_k7JQX2lZH.P0ksvkEZUNydQUOCE1kO5OLAcL1AyBp2vI.T9ASH_Kb9Hc4Me7mKM510daTsrXZ 2SM9zjJcE.71Zpftr7ecRdtXYfgDnveGmegjQMZnd.DpBgf0rr6nxRwigYFtZOwgeshbOZi130B_ 4DbU4YtAcTq344szXo3iurXDifa3K3FLY74OsHkA4UXHp4NzNI7Up8cSalqFYMFvjny2Vj15nTxi vkJ8QYOaURjLhiIqSyhQJ_dggdB_WsYQFuspeVT9Je6xTm1iuhrtJO9wR4Vh_ZQfA.YdtKKaQO_d MnXkcJ.YA9AVAapfee8zniemtVOpWZzJNp..bg8wfvINyIMLLFKT9BUkNKryVIWs- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Thu, 24 Mar 2022 03:53:32 +0000 Received: by kubenode512.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 01e1a1c4878939fb2ebcd8087931d98a; Thu, 24 Mar 2022 03:53:29 +0000 (UTC) From: Po Lu To: Michael Heerdegen Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line References: <877d8o8vuk.fsf@dick> <87lex2vfux.fsf@web.de> <87zglikra6.fsf@gnus.org> <875yo63w0v.fsf@dick> <87czidmms8.fsf@web.de> <87a6dg58zt.fsf@web.de> <877d8kxbmy.fsf@web.de> Date: Thu, 24 Mar 2022 11:53:24 +0800 In-Reply-To: <877d8kxbmy.fsf@web.de> (Michael Heerdegen's message of "Thu, 24 Mar 2022 04:39:01 +0100") Message-ID: <87o81watvv.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19987 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 219 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54481 Cc: Lars Ingebrigtsen , 54481@debbugs.gnu.org, dick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Heerdegen writes: >> Seems it is broken again. Who was it this time? I think the context got lost in the spam filter. Could you please forward a copy of the message you replied to? From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 24 00:42:18 2022 Received: (at submit) by debbugs.gnu.org; 24 Mar 2022 04:42:18 +0000 Received: from localhost ([127.0.0.1]:46575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXFIg-0008K4-0G for submit@debbugs.gnu.org; Thu, 24 Mar 2022 00:42:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:39686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXFIe-0008Jx-UA for submit@debbugs.gnu.org; Thu, 24 Mar 2022 00:42:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXFIe-0007MV-Lw for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2022 00:42:16 -0400 Received: from mout.web.de ([217.72.192.78]:52323) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXFId-0001xb-2z for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2022 00:42:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1648096922; bh=sHMXkrnRLwA7zX3sqkV6z0D/+BmWj4ABLdZvQAn3BTU=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=RPOZn/0Zze+cGWDpN6yZxVViHcjrV+qJniSyDBGgjfeMP8sVKw/4UWXGJlx0ak5x7 HFnrPWE5On46Vn9TZgHW3Bh3u5j1vYev6IfOlfgTmbPPpr207CVDRTaoyVErVzctBD H6wFbNdta1yjYzQrK07J6Z1LwwU84BtIooXFCnGM= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.60.174.212]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MmQYd-1nxCKR1LDl-00iSh7; Thu, 24 Mar 2022 05:42:02 +0100 From: Michael Heerdegen To: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line References: <877d8o8vuk.fsf@dick> <87lex2vfux.fsf@web.de> <87zglikra6.fsf@gnus.org> <875yo63w0v.fsf@dick> <87czidmms8.fsf@web.de> <87a6dg58zt.fsf@web.de> <877d8kxbmy.fsf@web.de> <87o81watvv.fsf@yahoo.com> Date: Thu, 24 Mar 2022 05:42:01 +0100 In-Reply-To: <87o81watvv.fsf@yahoo.com> (Po Lu via's message of "Thu, 24 Mar 2022 11:53:24 +0800") Message-ID: <8735j8x8py.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:sCUgw9ZZV+I5oU0cd6KoH/bGzON0FqQmt711K7oEW0d5Rs4M1FM fP6ns27yMhzbTFAaI4g68DHrh6p2sDygXcQduzXnL6E3zbjqZNTLilbms05CW5NKyMJ8mJI 7yLcUrvNrx4mVbOjRZ/zZsiqwgsrkbXWMmDH0BAO3hr+W+gAYgKQjJEuSM3DUKFidgWocik rsjzbLhb8CGuy1keLwsog== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:dLp4RvNjx80=:08uAFNc4XF4n9w2hREUcNn KSfYK2f0okL9G73JoAPaRp1jBZ9l5u/WOR+vi1mpSZXenzN68mFgHBNvCgDHdeLYow7jZAird 0oVnkAiS5BEkgyNXcrJ1OYckYpgKSw3O1oGtufqR0+PUvFZfTJIAq8SYj2aVNInFB5ZJnF3q1 DaahHnycnxlyVwtwuSEqLoxdVfw9OZIuQYArl47+sL5sLryFEFgfLig6nwVl1fiXUIXlRnwWo GFU9XvESTf1hmjqy7sov6zsQn4rmUFtsi1eUjmp3KCL2E+GenjOJdgMI1TIR6mm06h1eUxogE hppxrRdDKeb7BlBm5sW5HjVsFQlExuekRKFFzrNF3uk5BspO0LBuFZ2yPNTF7RXNrcH5roW0T qBnpTGP4GRXRBGqRILYihcEZv4xCinaUwYGlFSSpjOslRCtR+IALC3CpULKbzF71cPgDYbjnV eMXCi/ersEpdOGarOeVd+X69UNFUee2OhO4KJn4juiRgqcvTT/Lh3P/YtXChCsf+QSG+hDk+X KKw3hzmhXTioF+NIziu4sthlivg5hG1Pf9hBaF2amgNOhn472mnHFottifS9fWiPouHa3emxd MVKn4BezzTwKERnobq06cUp+FFdhVVb2r1uwA9WkXuWazftK6GIk9EW/bM3mUHn9bl5I8+az4 aXmw05jcbAmPRYq2CTb9RDpsCPOHeJw8/cWin01gdQqdtNqN9qgOee4kaZf13t0RLWFT0G/3B sTL+FSxU65v6kEN78I32pd9z6nZsG8iiN4nAwyPi1TSoiusS1+qCoQSvbgIVVVbBay2m4mQv5 V7O5+P3yJu0eKbJRqBxkDo6XYh+LitJtZhKopKDdZ84CQkL+mrIniY4lLm3RdQ7xMvbo646BP cHFR2TvyVyf5FKzHNFpuI/+fMGpsOgFFsLaWaJ8wIlTwfPAmN+bUSph+Jh42I6p0Qfn2TJW3N 28K6qQIQNc8E0jbb15okxUnBnbphs6tOPQrhvSSYgPNzszopsDbUGji2NevWJZD8RxaNzBVPA bLY3gAm9aE3AMYjb29mLmtITGKSkqZsDCQWlU2H8Ml76baYVlMFnX06qnKIyGUeuWd1APh+6N LWMy9Iae/eyRDk= Received-SPF: pass client-ip=217.72.192.78; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Po Lu , Lars Ingebrigtsen , 54481@debbugs.gnu.org, dick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > I think the context got lost in the spam filter. > Could you please forward a copy of the message you replied to? Your commit 5811741eda "Fix hl-line tests" reintroduced the "void function hl-line-unhighlight" bug for me. You restored the problematic setter. What we have now is not really the original state. Was this intended? Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 24 00:56:13 2022 Received: (at 54481) by debbugs.gnu.org; 24 Mar 2022 04:56:13 +0000 Received: from localhost ([127.0.0.1]:46581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXFW9-0000Ih-82 for submit@debbugs.gnu.org; Thu, 24 Mar 2022 00:56:13 -0400 Received: from sonic313-10.consmr.mail.ne1.yahoo.com ([66.163.185.33]:39280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXFW7-0000IN-5B for 54481@debbugs.gnu.org; Thu, 24 Mar 2022 00:56:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648097764; bh=yT/ZRiz8n/Q60R1dKX9rsEkmuNbRiLUIK3oeE9jwoJM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=BMhdvddFoekiSH7TAK/99qK+bIOKHwCzJ5dInWhQcJhFResoB6RJu9Tq0eO1aU54ZJ35v2iC5a5sSgDoQX1ZfNiTUQTV4CNwraMDm+dJYBZm9cwj9AUXTFQcskO5V8KZKIiIvFQ1AfW5+c+Knq4Exc53PJjA/V8jDkBCOVaJlx/CXqs9wTK2TdZX17ROEej2MVEvyd9pDTHTKguP1vzII4GlLnw819CQh+HB3PkwuWZ8Ge7cCQq+y9OK4P1ZuIO22TKl2twiX3Cmn7Yby/b4p9kOCFKRXPQZ3ApI7JynY7QMy3qpQP0AAYi6IhjUx5fb2R8B5Z29G/jDfweU9TzT1w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648097764; bh=KzHq+2Csqa/nufqqXSfLboXg5b8kjoOT79dagvJKQs9=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Jl/OowPZwwmx4SqpLGK2b4kIvXt+phE1FEZ4gkihHE4DN+z4HBV0M4nh19JF41enCFE/3WDuL209Q6UYFQFcvwlq2xVsq2MkXQ9AZ/Jnh84U6Y7T8Xuu3u394M+eAx8SVgOE6/MFtRlLwgtg+RXz8QhCRaouvDpUMttPy3bDQMYduo/jHxkVgT7RzCLHnc32LRjJKBfZo8euZXA5Swca+TKzdkhleK4VIwIn/gyIIQfqaydBCtTxwnoIJM+mFoStHh5nGqQIJsdyKOoxkptjaGhdvU5ywJlgGeU9lIvAKQCO4VZCNZ/u2NNyb0rnqiUeKk5Ess4KMOe+zhGjL52jOg== X-YMail-OSG: q3CitoEVM1kzf0tL11bM6k8TAxeLi7RcHHM0NYeqUYSIgg8ZQAfYYh6Z35ABC6K ZwCcQ_QVbUC4C_jsHYr1r1xgF9QJ7odz6BNJjkZdTKxlXkfRhGCanTnHGxqH_GyCyxXWfwKVCgad FZgEYxOZj2IpQ_1iVLIyZt6AnwQPrfM_Q5aourKLdOM8UfXMhMV8LPhEb7pZJtS71glPA9iIM9oU GPds3CjIs7a5DgWnx1IeWQYQV0PjIRsPBY5wx62mF_G7QYn6T8FUU2uqVbR87zcParRhh4YtXG2D FwolMIQiLMWrwOxx8ZUQQHZKljewzMa7l2Kr0iedH_Qe4.ll6qDRQR1vFZ.M9tgOhQLh5Y_OOpu_ fwUpSWLdgcjdMPHmZ6i7NO7JJ4JBMZLFz0bVwJlAU__1qBKZxdtRDTf2cvAj2wmCoHingpkfUZtD pSOZtCEAiH1dlV4H0xDNuMkFWxo9VxEbPqfpPimL5zjujbzNSAHKgC0W_WBUaZGWLNDMesntPDEp 9PBaIy7nQU13.imsVHcpv.55WxhNIGwlD0LjFYlujXjK42srS03tfnv5F1W1wCfdOeOVfGsORz5X PyTACsEo7aRKw19smTo1cXTe7XO7Xe2XjhzTBmHgwWWHjuyi8yOIBo3djsPD9EMg9o6.Ub0admBo zfrvYo6kkUnL9JS0mKpy9kM8ZaLsZO3kC_66FfXeQDfvOolD8V60Rm_0iHH6yDVWGUEQ9wIiJykV VcfX6peYXo7ez9LqMQtfcc5PfxWqB262U0xitr__EjU9RHJfttQX9SSzrCew93k6nV0HBa5H0S.R 0A0hKQjwSaV.yxbkCUQJ6_yiextSOT1HvzbveXbajXj3Q3sfanBjNQ1A9QfoD1B62pORlZEstT6h 5qVFcTcjLbioBVo.J5p_tFe5YrCSr19NK12Ap.pAvNPYg5aoZyXdhXOg50mnQ3RuaSE0eYTqXE7z NJMuwJTaZnp8nheq6dwRt.xNCnWYNhV7B6saqTz7nx_TRBvWMXa9aaTmJa_sVqHe3MfBr8SztGm0 TnLeV.q_libAckgJcZcPNqNok3MXUXpevFlsDHOgWx1Tg5WuRJjFsB_HkPDeAlLG5Az7OeRs82Gj PT3eSUA1mLievwnHv5FiHWTElJ53aiFuQi688wd5YisM_XaW0O8kKBLmEsA32H_Z3Yzno6vJ6PeU nfRsOmHj9XgtqzTn2rIjB4IgEjLmpM1WO7biMM7lTr69KORR7xhRMjPJwaP_9Xlf29CfRZGmEHw2 PcVhwBwkKHzfghZMP5XrBxE3OVTtqESmQyhCGpwy1dsKSCnuUp8jfnHfwfW1E.HBzDDf156NnWo1 jnAugNGJlAS_29d9RYPxyGU8XcT29xKd8deP.vqtlUSDXovNHadjXLOE5CudE.ltO2YrmxJr2dc1 jZ2lhbZ0d1YgaTddMKr5GZUr9P_xzHuMW6.rnEUtGo2yHM6YLZeQ_LhYShJEnNVnIKsw89DfLNKQ YCmco39bSMla0hWOBN4mIE_wL0NED9ZzfjxunWFCBSbUmtim_7nhSGTpQt6LzIiNGtfeGKCBFb7G s2WNbxTgu_qXbPLZXuGTx2WFAmbSfmiOON.d2S8dxgrkzb764o.QpPdIHHstS7Tm5hv4GjkdW6GP G5BjZrv33UBwoqbA.5AOrAD2yzJuROqzgEFjr0JYy2F.7GpAvcm8YCJnDo4kfOybyTDj4lng1y2h XHLghp4obBC47p1sLfrAhfLJjVOa8z7ulgzw9r98T_nXHsLva6NhmaRvu7_nyDpTPPP8RXzgsJci wSkDzKRBQzbD_Z3kTltSly0.mdUJaFl2z4ZISOXnJsRsb5QbW5rqaQLosKYEvsCIEx2nz.yFdVvn m23DN35ZgcvGoi3R_ImUXB3oNoGdVW6xqekKCY2Nrw6GrnOunwqCeN_4zqsxwfTRY_XaxTvJWV.I fuaTKG5UOELeP17_.kVcmIypfxRQ0k9yz9eoFcSCun0oP_YRbV5d2xfoscxljNEfFpRL6I4lrJ.g p0SrGCyXIocim4Uqc6aHteMmDEgLGh8FvtVSUSb_zCBYq_63L36vOmoP_24Bss.hfQzaAEQq6qSB GfGYCWjLddMmuMp5bqyyBIcQC5Dyej4c2Rv4PDTwgu_rlCnnEuOEr0VlcvCK4wxyYJaWXKMYGpMm L2wTOOZi9pJujjG8OuFMpppBQcIKEuR4xn09VAED.m.rPJKgN_kRWrj_CLKRR6ev_M_92K5tV2Yz D136URWmBhlyDO6OeobMX96UN4t_46xJ851B3ybVH2mWz7hrRYp8dK3YIBXQtm3o- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Thu, 24 Mar 2022 04:56:04 +0000 Received: by kubenode508.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 13537d0f5eedabf8c1ac1ccee783e549; Thu, 24 Mar 2022 04:55:59 +0000 (UTC) From: Po Lu To: Michael Heerdegen Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line References: <877d8o8vuk.fsf@dick> <87lex2vfux.fsf@web.de> <87zglikra6.fsf@gnus.org> <875yo63w0v.fsf@dick> <87czidmms8.fsf@web.de> <87a6dg58zt.fsf@web.de> <877d8kxbmy.fsf@web.de> <87o81watvv.fsf@yahoo.com> <8735j8x8py.fsf@web.de> Date: Thu, 24 Mar 2022 12:55:54 +0800 In-Reply-To: <8735j8x8py.fsf@web.de> (Michael Heerdegen's message of "Thu, 24 Mar 2022 05:42:01 +0100") Message-ID: <87ils4aqzp.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19987 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 448 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54481 Cc: Lars Ingebrigtsen , 54481@debbugs.gnu.org, dick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Heerdegen writes: > Your commit 5811741eda "Fix hl-line tests" reintroduced the "void > function hl-line-unhighlight" bug for me. You restored the problematic > setter. What we have now is not really the original state. Was this > intended? I put it in to fix the hl-line tests. That setter did not exist in the Emacs 28 hl-line code. Can you show me how to reproduce the bug you're experiencing? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 24 01:14:15 2022 Received: (at submit) by debbugs.gnu.org; 24 Mar 2022 05:14:15 +0000 Received: from localhost ([127.0.0.1]:46597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXFnb-0000z7-Gz for submit@debbugs.gnu.org; Thu, 24 Mar 2022 01:14:15 -0400 Received: from lists.gnu.org ([209.51.188.17]:42446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXFnZ-0000z0-WB for submit@debbugs.gnu.org; Thu, 24 Mar 2022 01:14:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXFnZ-00032v-Pl for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2022 01:14:13 -0400 Received: from mout.web.de ([212.227.15.4]:50869) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXFnX-0001Pu-31 for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2022 01:14:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1648098838; bh=ohui/P1Fd5j7JMhJhiu8JOCrqRmLFBzWiP2+BhDmgsI=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=KSCMCo9EBJ060DKZO97QJI+C+pXyGWFn0U9OWMGMZKr9Un04ziakWJf0xbw+MnePv MbP+FNQOwSaA8CMZgV/mHw2eNVv75RjUgrTOCoS8NXxQvHQHhHuSa2H+0jwjJzN5hd BEomPDl9KobbKd7ypGJkRZ1dmJr2Zms3UoeiKiUU= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.60.174.212]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MgAJ8-1o0EUF44Ra-00hTGX; Thu, 24 Mar 2022 06:13:58 +0100 From: Michael Heerdegen To: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line References: <877d8o8vuk.fsf@dick> <87lex2vfux.fsf@web.de> <87zglikra6.fsf@gnus.org> <875yo63w0v.fsf@dick> <87czidmms8.fsf@web.de> <87a6dg58zt.fsf@web.de> <877d8kxbmy.fsf@web.de> <87o81watvv.fsf@yahoo.com> <8735j8x8py.fsf@web.de> <87ils4aqzp.fsf@yahoo.com> Date: Thu, 24 Mar 2022 06:13:56 +0100 In-Reply-To: <87ils4aqzp.fsf@yahoo.com> (Po Lu via's message of "Thu, 24 Mar 2022 12:55:54 +0800") Message-ID: <87y210vsob.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:ksDFk54ShhzjoNHbhMTdLRS4NV/dfMjOWAMnFZWohEwGTXNwksL xgdl1vGC3avc1da5q6oWV6hL6i3rlgp5yGuqni+2sMD7JPOrWPme2J5UNuAzrq/vZiV48EL eAj5RlFLmqPn8TY+sI88pGxAx64LjILXSZ/Zfin6vTp1aivITi2CC/ljVm54AgciEWVayCm 9GkSF9Ygn6QgkYsuTYEUQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:lUlEPQan108=:OnwWP2iNWIZw11qIQv809k UClvzzhfhM8RHEgJq+sC23F3Xa1y1FjhS+BWNR4biIeG/KaaKpsINCIf6LhJqHBuJRXOsP1sW BqB94IPt7CRgcW0AEyg3diqArS9eT0RHm0tRDkeTIL+CpNjs8Qx6k0Ry+UOGvsVZH4rAttcDD OSlhugo9Hr4OtIhnd4WEJ37IMPkOSXzSG3xc33tVU6efa8bAM4CRpNVyEFMYf2kopzH4wvLSE 7mKmdLHZfqk4bXoyHWiRkdeDcPvSNw+bhUBpIqVan9Nw88SLm/6FOddLcuCHuQmCEJJIpewbU hPUHiSUbBOghxS57nYrJKFAkcZ8sXntTIPQfWRnYmAIryVlsMFTStMr3fHmI3KqHTIi8nlHYE RSMNlfZLP0Dqe7T7pTvPfeHSAMZQHyeRGNSbtBzGSUg9ZCX+KA6rEHVm2y4LcsGZHwxKcI2xm GaUbZZU0iuyx9qTPdJMeNvqnX0bLji7a92DYyYJh5SofKfnbOK4iG1YhLTX+KVohcC9VkWr36 z8MJ+RxR5d6OTlallPzpa8deDYz+g0q3typn3d+dkukMb1XXe58+cCO/zODgK+wN9EDKPeuON DRLc0zM8LygsDmD/uEKlVgyNocHWnl277XVCExlzPiuLr555QddatbNJmSdqpnrFWCXKfxFbU E4waF6wbA6APgxBDt6f13vqslgBEhwdayiB2Q3BvCKA6cEPQeHeXQVt7Kn7a/uO8VxXtNR1tM 6z1+odqe1x025aFT9V4s4avMTvTL5JRWqDolX8iLE2h0fgyCg4x558S8lb0FYiCEQoJ7R2cJF rY1XN39oCTBofQHC57DzDOAGQsc6k78WESB5omPvskMDsbX0JZpRhieHG3W6OMU/dLOdCKrgc VR5Ud7D10YLQ5326tqosqaL6HqxfZHQfhFw2elp212x9oLsp2jblTxyWVvEwYiSPoLuc9+Ol6 7rGCrxXzp91EKZyguaGlXy13MiZn3EZ+QDnWSlFv4W+mwQSyZhm3v62IALh1omQlGMTnqiSUR ZdyFlv+9PozXbeYl+eD90LKdkak4RqzF7u4mi6O0DrnGO/198t/HBy4ZhIi4Eeu4pEvEvs/wf WSv2yyzT3Dd8TY= Received-SPF: pass client-ip=212.227.15.4; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Po Lu , Lars Ingebrigtsen , 54481@debbugs.gnu.org, dick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > I put it in to fix the hl-line tests. That setter did not exist in the > Emacs 28 hl-line code. Can you show me how to reproduce the bug you're > experiencing? Same recipe as the last time (from dick) works again: src/emacs -Q -nw --eval "(setq debug-on-error t)" --eval "(custom-set-variables '(hl-line-sticky-flag nil))" -f global-hl-line-mode Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 24 01:51:56 2022 Received: (at 54481) by debbugs.gnu.org; 24 Mar 2022 05:51:57 +0000 Received: from localhost ([127.0.0.1]:46617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXGO4-00023d-NY for submit@debbugs.gnu.org; Thu, 24 Mar 2022 01:51:56 -0400 Received: from sonic307-10.consmr.mail.ne1.yahoo.com ([66.163.190.33]:44610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXGO2-00023P-GG for 54481@debbugs.gnu.org; Thu, 24 Mar 2022 01:51:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648101108; bh=CUgY+qIcXEz9D4jmMymFDNwRnw6iHDNwjXpx4kfgar0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=UWzWOK6w5aq35choUMogdLsNh5eBcANfC+YY1p1rpI18vqnl1micx5OMG00kc6Br01YEvliyjgUUALEShpjDuS/P0hUHky2BvVUnkYkUOqDlJkE0KNBxmtcFVZ02GoXtNShzzcoioSEc/tUSsB4DgAOebadOdeuNiwUbtvAGUqdOtt36A7Vb/K4i4UfIDs9Cnx5+GVsxxGWYz0MIzBgDIksQN372Y48g/MwTCCoUdrHStYlznbEgvumd7O+qL2KRuSpONN8ek0021qhOIBKS6DW8yZpyXek2Xm1Bi3/Nc8sgckTbsHnkL1PhkJZBsn7K36JRqQIJGp8yzRjxgbWAlQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648101108; bh=/TH7cAmpqC54+nMYGEKsNDlce4BJow+6sYSBF/AJt7M=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=mXIMJCcmbYzdFwcddOhuqUtCAcviVXX/IWMl8xbAiH6+bAzHAIXHB44jVjCf13seAIgPBy+DqrkCbbrKrVqAcOu7mknjV+x5dQbHyQZTHbLn70rANwpoFbxxA/yqA6SD3JmxGKwlaNOya5gExuX2DR0PUXIN2JAL/Vznd/WtB2KybuyNhf0P2mq9YXbZlmQ4N1VswmS4DlTXn3PTbZjHGOw2tZX4WcTwU9iIM/9EsIkZNiyeWVQFhYI9Vy4ZfHHUw9vAJ/yjv9RJmOjWX33teSmUTbDaE/umgcy1gSDTK/EnQJ7JTe1d9UXgJ3i7uJH++n8tVPbnOKUw23ZmKETHQA== X-YMail-OSG: QtfEx6wVM1luQ705dw8Zv5w9I2iF51ggQ.Q706w4m.JwwxcVTgS9OGlS6ZQr48e O.HqwfvEQ5NjnaT8rJSv_DENTeh4TsYzRGA8k6Sbd8XmSukklSNkKeU7CvDIRd2urB3jhoYLHdfQ EQ_MWSz7N6F60zTVtTIk0bO6BtFMwQuRIKYZQv1RCUE0jDal_ABgLGAWmCH6dIzta3KAqGJSR63Y WIlgnUnxEW5iQQG43HcFbtw5ZppYF1O7dqkPHLYfCnJag0RN3xYYa5IZ5RUZRIKvOKPS6JvLT0iC Ex1dgsT5aux2oNsoVYnKYKWBvaS03G8R8xljCEmk_slZAhFq96DpB43WXxHXHkckZlWnMfqT88Ne 7OvEr8Iemtn7nRKVD4TIGFjb4JG4oNoyyByHfzVP_iKTN2MXlwN010QrJ02HS6fEcSh8kLcsWz3f dMrlEbjw5JP8BkRuT.JFGJKilmhbRBLetJenF7FSsf.TOkAuUjBXektcba6WPgLmnJntUjHN7cMD 19gJza6YMckKTWWVzGJLTdKq3DANmyQo1zXPPrHUYplAfBU2MWmJFytFhrTde365Dj14M9CVIzfc ihNX3O44Hbrsbpwla18MlqKJEngtmJUZAPtns2qR9hu9GVZZ0QEWMBAgTmujytzsMIYWLJbqnocr Q38jRHIng7mG0XILfLIastNv9rPZs8IUKDCjyJNtHPlaBQHu0Q5MuOubTnMvWxlYj7nF8E6ZpttN 8k0DitUg.gnGSw.YxIYA3LdFEpledC64o1AsZS8NyOWrdnMBLBsj8oqJLeRak0vYgvvyEQjHyPcg b1wHwoiDdSPbZ4lcOFehQKKG1lpJGcxy4YXCRf40MBqdLSYelq0CUhjY80iEQH6Hix2v6_kXcjlW xyTYdqrLVFFsZhAsRiBpp.5HJJOkXP0mIuUrKJz.wJk1h62l3Xo1v6sNKhspVpNpU0A_6b50_QWS Rxmpg9xofB4fdjLuloa.R7hirG9hdYOCd8OqJq9q_83cg5Iu82tWXiig6UXxKd0kAxyHTrxUnGxz Ii0lwbQCRAjNADzoWYLQI0KVzCr97qD5cBTBJwnGOp_BhZBB9V5RZmduMMwwCFYqPrYBoVVMrBjq 3HAq_jRqXeMCSjQOdDFUE6gc5qku0mUOgNLV1uUh0WA9fRfT8wAt13Mf9gmbe.ZF3zfLZ95KY48t rVs.usb8kc9FLr1TGpDv_.Q5az2CO4Lf1u5FeyAAqVvBMoMovlBE4WLZW188oWoUVQEnGwNKhAZe KPTozxnWkclAnesV_coaNLEk4a1nV3cAvRGKwDnZ1MkJw5ZdCDvh6T9hQUIiCFDfhq.CCd6D8FV6 q5PYNQZ6RnGGKiz4_qW7W9Xb6HLEIsjlLfX16J97rtiZa5.PocqX2H7dNoJ4.KObObKJGQJk5hPj .sgLp0aoRxniiQN7LUomB8K791khPwN.WbrBsujreoPuceI66IoHJO.LDJ4zhYMgb4qLrBfUCIkI bowagM8LycLTgl_JDb4XotjU1RGm1SCZqe1Xu1tPEtgZycgaswTBnAOX_Yp3_1M5ebjRGbB5DooF 6tyOncX7ZlHzOb3SxJ42vpxQLfkuU8C1lvkVY_S1KCoTu8oYTf0a1YNPApQVywX7xo9XsdDIGKpy 2nZgysqxBFZQTTYtGfR4y34j1L7lZBQkpiG.N9C6wmbS7g0EBFeK9iW9zfC02c.JHuQMygGcdayT MfYLT_sVGveCPFiEYS5jAdu.O37XpARED4Lal2y5ZimyUfgX0AE0wgLMGZEbx_qZ_BysuVbsDfDa QWUTKckrFbFg4KwY7H1xY93uNyyI2CSXnK9DgIYx2ZlGl03KeVYRA06w8jc5kYkAgvqj9BzV3Lje WyguY8j__jvXonsuT5sNdVQcQN5dDyhZnSvLl4S.E8gQukiPH.znvLHh.NC63v.3WHZP4.VO44O8 1LRGoE1mdKFmnwz0EXDp2IQNzmCiRuqYuXNo5dCrTGLCqkHA6xzTeeHBVxmNYBm_ZnsXOcFn7aY_ IUfp24o2kuunv7SsIJV4LiYnz28aHsQHbBm3q_K2XT0vvtL2sYf1Kd1DrsimlCo6BMT9G6PqjiDl XQdGoAuBJm4Ja_GseRg5HNf_Xyo_1TpF8r.pJ5Qi4DwAOwY6X8Sq.wId_2qMeF.TyzmF3ZboXusY VRHOgwH7YH2di1_k6Je08JVpqbGXhpim7HVqP3jnPdJWiGbQHMSr_ZzxCV56mw3DhoQSvjVceD4K j4elAkhL2vhLmJ4IJCIiPWvjLZ_VcVyN1Gx5mKhY4UpBfLLvdmHYCsXltgp.VERTI X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Thu, 24 Mar 2022 05:51:48 +0000 Received: by kubenode510.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 42d4fbc020ed81848d9ddf8fbaf2ddc7; Thu, 24 Mar 2022 05:51:45 +0000 (UTC) From: Po Lu To: Michael Heerdegen Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line References: <877d8o8vuk.fsf@dick> <87lex2vfux.fsf@web.de> <87zglikra6.fsf@gnus.org> <875yo63w0v.fsf@dick> <87czidmms8.fsf@web.de> <87a6dg58zt.fsf@web.de> <877d8kxbmy.fsf@web.de> <87o81watvv.fsf@yahoo.com> <8735j8x8py.fsf@web.de> <87ils4aqzp.fsf@yahoo.com> <87y210vsob.fsf@web.de> Date: Thu, 24 Mar 2022 13:51:40 +0800 In-Reply-To: <87y210vsob.fsf@web.de> (Michael Heerdegen's message of "Thu, 24 Mar 2022 06:13:56 +0100") Message-ID: <87bkxvc2z7.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19987 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 568 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54481 Cc: Lars Ingebrigtsen , 54481@debbugs.gnu.org, dick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Heerdegen writes: > Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text > editors" writes: > >> I put it in to fix the hl-line tests. That setter did not exist in the >> Emacs 28 hl-line code. Can you show me how to reproduce the bug you're >> experiencing? > > Same recipe as the last time (from dick) works again: > > src/emacs -Q -nw --eval "(setq debug-on-error t)" --eval > "(custom-set-variables '(hl-line-sticky-flag nil))" -f > global-hl-line-mode > > Michael. Should be fixed now. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 24 23:45:36 2022 Received: (at 54481) by debbugs.gnu.org; 25 Mar 2022 03:45:36 +0000 Received: from localhost ([127.0.0.1]:49771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXatM-0000sw-0c for submit@debbugs.gnu.org; Thu, 24 Mar 2022 23:45:36 -0400 Received: from mout.web.de ([212.227.15.14]:60303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXatK-0000si-6F for 54481@debbugs.gnu.org; Thu, 24 Mar 2022 23:45:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1648179925; bh=QMsSo2BnYuqeWsnTWsH39wVn8Gg7fhJPzlEAJSf0fBc=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=TVuUrPZKom3IHAzxpZ5ur7gwONvwB/ZhX08c8DAGyE3V1OjxB0ZcAzJrrZ1Vhx+Cq lqYLkJh9IMYmCPZ0eLpeRTo/NV1A4DAnf6atla3/jh306MTefpHNNInwAWusz3IFml mtrNN6lRhiVANlS60l6fPNlqCRvuC+yy7CDvBpEU= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.60.174.212]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MhFhe-1o33kl2viM-00eAlQ; Fri, 25 Mar 2022 04:45:25 +0100 From: Michael Heerdegen To: Po Lu Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line References: <877d8o8vuk.fsf@dick> <87lex2vfux.fsf@web.de> <87zglikra6.fsf@gnus.org> <875yo63w0v.fsf@dick> <87czidmms8.fsf@web.de> <87a6dg58zt.fsf@web.de> <877d8kxbmy.fsf@web.de> <87o81watvv.fsf@yahoo.com> <8735j8x8py.fsf@web.de> <87ils4aqzp.fsf@yahoo.com> <87y210vsob.fsf@web.de> <87bkxvc2z7.fsf@yahoo.com> Date: Fri, 25 Mar 2022 04:45:24 +0100 In-Reply-To: <87bkxvc2z7.fsf@yahoo.com> (Po Lu's message of "Thu, 24 Mar 2022 13:51:40 +0800") Message-ID: <87mthezodn.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:xBMSQs/iPAhevEhjo51iRwmEvvqslb2OUP8c+tSHOq7ZKdCfoGk /R9uAQDDpZu+Nl6On8UUE6uYWi+M8HyL8uaryU1HX4Q5pU2KpS+SOBkRhjbkA5V2cKND/L6 9m9Gq8++DTcnZY3Hq8SdhKrxH7MpDJ88FDwZak7kVPm7ThZvBeVTBAaBBxGRA7It9wCp6sZ rjClMMTffvYYSi4IuN29g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:lZYrt4D/1eM=:go0b6z1Axm0Mbefb3FIwoj dUYZ0rfLRsKcgFEPIaT4tv6h4iPw8zacQPr8Al0qPVtFXDDcc2nAYqtETdOO+tiV+mqe9/c+K yS1KcyXnZPJbmO4rP+PYph1McymjAUS56Q2VethEDznzUAlcYAyySrxtG4+YP2fqXt1QYN7Qz YIx+/X/djvEdzF4Fpz/k1DZ+r9x/za8nD7kYa8xYZoKrSxmzbmCWPFtKsY+LI2HWLAsA5cvvB AH5nX7y3X0+GFzvFYBvIp62t6Rv7GA8eY8w1uMm+uCsIDo4tVLJEV4nfF6u+o2DkUsfvhTql0 u3chFVkYReak5GFZeYf/MipPzz5HYF4yhy0R6kygBJVSDGIv7+3t307gQFtGiub9Fx3Bifiz6 UFq9uP5+tRiIEa/vlFch3vHCgjzlMvOzP/IO+9LH3WP3PUSoWIui8ISXTjUVNLQzwkTx8o78p pE73R7cq0BnzKb//KMwRS4y04anOAwtCY331RvPrTRxpOa1NkINPrjGOpRAkuqY8lPBRhJEzr ZRZJWVtfa2KxZj64sm1Tr4lGwTZ1PpxITxz9GDYlCwOvazxfExXeVxSIDp9KqplOpS8sBPmhD QzXIYRq/lrOO8BfbLxjYnf/mZSHYWJjdVa93sS7NrTpNsP5Np929AtI/ckhardaK1IPxbvqlf cubobjP1NVWD2kKnXo+DYyYKF55gyDcJBQpkZTk8ADzZze4zsNw0dWT55Yqh04XvQxHAhlL8E bOYgHk9pYpJ6wrUW6E4sKf4BqGKR2tlTK/wJZ3qV6ZWB0rhDde6GADZmikEOnc5779bFTk0zu a1GGvVR5CJBAWm7TFf2s3PPhgLoizl1ZNwDkqOJ9D0gcPrkbQGCejYmU0TlKa5WiSGsFkOuoT ctuk2dt3ytK3wjTEYNJtwjBZu7a5dAGIniJ9mW/jT2j7OXo614fVMtlWv/PyjDpnlaB1jXHiN K2e/KUx75+jSCligh5i4CMlesQONHa28Qb0C8GkkFp3d+vwRhqqei6NOoTEHe5ATYoFoBySr3 fEw+0/uXgz85ZDaNbWPz5qGjyrFi6jUPBO2NNySeCYolw1GkTTSwUl538d3OFgl5Z268KO8Ft X8ClwV3rJzAAVY= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54481 Cc: Lars Ingebrigtsen , 54481@debbugs.gnu.org, dick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Po Lu writes: > Should be fixed now. Confirmed - thanks. Michael. From unknown Sat Sep 06 02:03:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 22 Apr 2022 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator