Subject: Re: [PATCH] gnu: games: Add robotfindskitten.

From: Liliana Marie Prikler <[email-masked]>
Date: Mon, 21 Mar 2022 07:59:45 +0100

Hi Roman,

Am Sonntag, dem 20.03.2022 um 16:28 +0200 schrieb Roman Riabenko:

> +    ;; Despite what guix lint says, version 2.8284271.702 is newer
> then
> +    ;; 1600003_201b. See ChangeLog for version history.
> +    (version "2.8284271.702")
> +    ;; The git version is the same as in the release tarball, but it
> bundles
> +    ;; convenient .desktop files, which were requested for Debian.
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url
> +                    
> "https://github.com/robotfindskitten/robotfindskitten")
> +                    (commit
> "1cae36621f9c19d19a40eacf63789913d4ef5d5c")))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +               
> "0ps3xrl1yh0h7jhl3bwhx5xw2hvhzync03y08i66rzw098r530qq"))))
Looking at the git repository, those are *not* the same.  Use git-
version or use the tag as commit, but don't mix conventions.
> +                  (replace 'bootstrap
> +                    (lambda _
> +                      (invoke "autoreconf" "-ifv"))) ;per README.md
The existing bootstrap should already correctly invoke autoreconf if no
bootstrap script exists.
> +                  (add-after 'unpack 'fix-install-path
> +                    (lambda _
> +                      ;; It is configured to install executable to
> /games or
> +                      ;; /usr/local/games per Filesystem Hierarchy
> Standard.
> +                      ;; We change that to get it in $PATH.
> +                      (substitute* "src/Makefile.am"
> +                        (("\\$\\(prefix\\)/games") "$(prefix)/bin"))
We could change this by using #:make-flags instead, I believe.
> +                      ;; When built with guix, all characters are
> displayed in
> +                      ;; the background colour pair. If it is not
> set manually,
> +                      ;; this is not happening, so we get back
> colour into the
> +                      ;; game. The background is redrawn anyway. See
> man bkgd.
> +                      (substitute* "src/robotfindskitten.c"
> +                        (("\\(void\\) bkgd \\( \\(chtype\\)
> COLOR_PAIR\\(WHITE\\) \\);")
> +                         "")))))
This should probably go into a "patch-source" phase.

> +    (synopsis "Zen Simulation of robot finding kitten")
> +    (description
> +     "In this simulation, you play the part of robot.  Your task is
> to
> +complete the simulation by finding kitten, as is your destiny, and
> indeed your
> +wont.  You (robot) are represented by the # character, and you move
> around with
> +the arrow keys touching things.  If the thing you touch is kitten,
> you get a
> +cute little animation (which was cuter in the DOS version) and the
> simulation
> +ends.  Otherwise, you get a brief description of what it is you
> touched.")
Both synopsis and description could use some love.  Plain copypasta
with grammatical errors is not good optics.

Cheers