From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 10:29:06 2022 Received: (at submit) by debbugs.gnu.org; 20 Mar 2022 14:29:06 +0000 Received: from localhost ([127.0.0.1]:34910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVwYG-0001GW-Up for submit@debbugs.gnu.org; Sun, 20 Mar 2022 10:29:06 -0400 Received: from lists.gnu.org ([209.51.188.17]:47998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVwYF-0001GP-Hy for submit@debbugs.gnu.org; Sun, 20 Mar 2022 10:28:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52064) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVwYF-0005jq-2H for guix-patches@gnu.org; Sun, 20 Mar 2022 10:28:59 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:56903) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVwYC-0000Lc-FH for guix-patches@gnu.org; Sun, 20 Mar 2022 10:28:58 -0400 Received: (Authenticated sender: roman@riabenko.com) by mail.gandi.net (Postfix) with ESMTPSA id B30D31BF203 for ; Sun, 20 Mar 2022 14:28:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riabenko.com; s=gm1; t=1647786532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=h1blsjiV3GtamXSIc0LdLIpeS/LfKvOoYRLffydgoAs=; b=NJHyMhxUitwoCZ246n9L6GC/vFRR+nUlObElaaB8jgatcGfYustv1Pekv7LdvXSfzo1q87 2OwwErW9t/qz60vZcz0H9wasZ9v6lq5t24/bb9PBinFsDCqxjraQ5nNmCmyTBxIv56WMjJ 3ReH7G3vDuSUfTnVJf3N/xvRoIX9QbDITmYOGtJjPajUngxu9YsGlmkimEifIV4gylZjb8 UUjPiJTMKROZFdh5xgKQxDHeqwd/c3dKFS6sfOfhpygBYJ69D27WBDyiNVBwQwSf3e9YMO KAQa7M+3Sx0B01bNgF04OFfC20qTruPDeWHYtiU/3mrX1g+WCkSZEr1SyGYHzw== Message-ID: Subject: [PATCH] gnu: games: Add robotfindskitten. From: Roman Riabenko To: guix-patches@gnu.org Date: Sun, 20 Mar 2022 16:28:49 +0200 Content-Type: multipart/mixed; boundary="=-gKUO9Y86SR192lh+Sm80" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Received-SPF: pass client-ip=217.70.183.201; envelope-from=roman@riabenko.com; helo=relay8-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-gKUO9Y86SR192lh+Sm80 Content-Type: text/plain Content-Transfer-Encoding: 7bit This patch adds robotfindskitten. Roman --=-gKUO9Y86SR192lh+Sm80 Content-Disposition: attachment; filename="0001-gnu-games-Add-robotfindskitten.patch" Content-Type: text/x-patch; name="0001-gnu-games-Add-robotfindskitten.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSBjMzVjNDI4M2EyZTY2YzAzNjkzMTY0ZGYxYjllNjI1MTQ0NzhiYjFjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb21hbiBSaWFiZW5rbyA8cm9tYW5AcmlhYmVua28uY29tPgpE YXRlOiBUaHUsIDE3IE1hciAyMDIyIDE0OjM0OjI1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gZ251 OiBnYW1lczogQWRkIHJvYm90ZmluZHNraXR0ZW4uCgoqIGdudS9wYWNrYWdlcy9nYW1lcy5zY20g KHJvYm90ZmluZHNraXR0ZW4pOiBOZXcgdmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL2dhbWVz LnNjbSB8IDU2ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBm aWxlIGNoYW5nZWQsIDU2IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMv Z2FtZXMuc2NtIGIvZ251L3BhY2thZ2VzL2dhbWVzLnNjbQppbmRleCA4Y2MyOWIzNDg3Li45ZWQw Y2FkODAyIDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvZ2FtZXMuc2NtCisrKyBiL2dudS9wYWNr YWdlcy9nYW1lcy5zY20KQEAgLTY5LDYgKzY5LDcgQEAKIDs7OyBDb3B5cmlnaHQgwqkgMjAyMSBD aHJpc3RvcGhlciBCYWluZXMgPG1haWxAY2JhaW5lcy5uZXQ+CiA7OzsgQ29weXJpZ2h0IMKpIDIw MjEgRm9vIENodWFuIFdlaSA8Y2h1YW53ZWkuZm9vQGhvdG1haWwuY29tPgogOzs7IENvcHlyaWdo dCDCqSAyMDIyIFlvdmFuIE5hdW1vdnNraSA8eW92YW5AZ29yc2tpLnN0cmVhbT4KKzs7OyBDb3B5 cmlnaHQgwqkgMjAyMiBSb21hbiBSaWFiZW5rbyA8cm9tYW5AcmlhYmVua28uY29tPgogOzs7CiA7 OzsgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCiA7OzsKQEAgLTIyNTAsNiArMjI1MSw2 MSBAQCAoZGVmaW5lLXB1YmxpYyByZXR1eAogICAgICAgICAgICAgICAgICAgICAgbGljZW5zZTpn cGwyKwogICAgICAgICAgICAgICAgICAgICAgbGljZW5zZTpncGwzKykpKSkpCiAKKyhkZWZpbmUt cHVibGljIHJvYm90ZmluZHNraXR0ZW4KKyAgKHBhY2thZ2UKKyAgICAobmFtZSAicm9ib3RmaW5k c2tpdHRlbiIpCisgICAgOzsgRGVzcGl0ZSB3aGF0IGd1aXggbGludCBzYXlzLCB2ZXJzaW9uIDIu ODI4NDI3MS43MDIgaXMgbmV3ZXIgdGhlbgorICAgIDs7IDE2MDAwMDNfMjAxYi4gU2VlIENoYW5n ZUxvZyBmb3IgdmVyc2lvbiBoaXN0b3J5LgorICAgICh2ZXJzaW9uICIyLjgyODQyNzEuNzAyIikK KyAgICA7OyBUaGUgZ2l0IHZlcnNpb24gaXMgdGhlIHNhbWUgYXMgaW4gdGhlIHJlbGVhc2UgdGFy YmFsbCwgYnV0IGl0IGJ1bmRsZXMKKyAgICA7OyBjb252ZW5pZW50IC5kZXNrdG9wIGZpbGVzLCB3 aGljaCB3ZXJlIHJlcXVlc3RlZCBmb3IgRGViaWFuLgorICAgIChzb3VyY2UgKG9yaWdpbgorICAg ICAgICAgICAgICAobWV0aG9kIGdpdC1mZXRjaCkKKyAgICAgICAgICAgICAgKHVyaSAoZ2l0LXJl ZmVyZW5jZQorICAgICAgICAgICAgICAgICAgICAodXJsCisgICAgICAgICAgICAgICAgICAgICAi aHR0cHM6Ly9naXRodWIuY29tL3JvYm90ZmluZHNraXR0ZW4vcm9ib3RmaW5kc2tpdHRlbiIpCisg ICAgICAgICAgICAgICAgICAgIChjb21taXQgIjFjYWUzNjYyMWY5YzE5ZDE5YTQwZWFjZjYzNzg5 OTEzZDRlZjVkNWMiKSkpCisgICAgICAgICAgICAgIChmaWxlLW5hbWUgKGdpdC1maWxlLW5hbWUg bmFtZSB2ZXJzaW9uKSkKKyAgICAgICAgICAgICAgKHNoYTI1NgorICAgICAgICAgICAgICAgKGJh c2UzMgorICAgICAgICAgICAgICAgICIwcHMzeHJsMXloMGg3amhsM2J3aHg1eHcyaHZoenluYzAz eTA4aTY2cnp3MDk4cjUzMHFxIikpKSkKKyAgICAoYnVpbGQtc3lzdGVtIGdudS1idWlsZC1zeXN0 ZW0pCisgICAgKGFyZ3VtZW50cworICAgICAnKCM6cGhhc2VzIChtb2RpZnktcGhhc2VzICVzdGFu ZGFyZC1waGFzZXMKKyAgICAgICAgICAgICAgICAgIChyZXBsYWNlICdib290c3RyYXAKKyAgICAg ICAgICAgICAgICAgICAgKGxhbWJkYSBfCisgICAgICAgICAgICAgICAgICAgICAgKGludm9rZSAi YXV0b3JlY29uZiIgIi1pZnYiKSkpIDtwZXIgUkVBRE1FLm1kCisgICAgICAgICAgICAgICAgICAo YWRkLWFmdGVyICd1bnBhY2sgJ2ZpeC1pbnN0YWxsLXBhdGgKKyAgICAgICAgICAgICAgICAgICAg KGxhbWJkYSBfCisgICAgICAgICAgICAgICAgICAgICAgOzsgSXQgaXMgY29uZmlndXJlZCB0byBp bnN0YWxsIGV4ZWN1dGFibGUgdG8gL2dhbWVzIG9yCisgICAgICAgICAgICAgICAgICAgICAgOzsg L3Vzci9sb2NhbC9nYW1lcyBwZXIgRmlsZXN5c3RlbSBIaWVyYXJjaHkgU3RhbmRhcmQuCisgICAg ICAgICAgICAgICAgICAgICAgOzsgV2UgY2hhbmdlIHRoYXQgdG8gZ2V0IGl0IGluICRQQVRILgor ICAgICAgICAgICAgICAgICAgICAgIChzdWJzdGl0dXRlKiAic3JjL01ha2VmaWxlLmFtIgorICAg ICAgICAgICAgICAgICAgICAgICAgKCgiXFwkXFwocHJlZml4XFwpL2dhbWVzIikgIiQocHJlZml4 KS9iaW4iKSkKKyAgICAgICAgICAgICAgICAgICAgICA7OyBXaGVuIGJ1aWx0IHdpdGggZ3VpeCwg YWxsIGNoYXJhY3RlcnMgYXJlIGRpc3BsYXllZCBpbgorICAgICAgICAgICAgICAgICAgICAgIDs7 IHRoZSBiYWNrZ3JvdW5kIGNvbG91ciBwYWlyLiBJZiBpdCBpcyBub3Qgc2V0IG1hbnVhbGx5LAor ICAgICAgICAgICAgICAgICAgICAgIDs7IHRoaXMgaXMgbm90IGhhcHBlbmluZywgc28gd2UgZ2V0 IGJhY2sgY29sb3VyIGludG8gdGhlCisgICAgICAgICAgICAgICAgICAgICAgOzsgZ2FtZS4gVGhl IGJhY2tncm91bmQgaXMgcmVkcmF3biBhbnl3YXkuIFNlZSBtYW4gYmtnZC4KKyAgICAgICAgICAg ICAgICAgICAgICAoc3Vic3RpdHV0ZSogInNyYy9yb2JvdGZpbmRza2l0dGVuLmMiCisgICAgICAg ICAgICAgICAgICAgICAgICAoKCJcXCh2b2lkXFwpIGJrZ2QgXFwoIFxcKGNodHlwZVxcKSBDT0xP Ul9QQUlSXFwoV0hJVEVcXCkgXFwpOyIpCisgICAgICAgICAgICAgICAgICAgICAgICAgIiIpKSkp KQorICAgICAgICM6Y29uZmlndXJlLWZsYWdzCisgICAgICAgJygiLS1lbmFibGUtc2lsZW50LXJ1 bGVzIikpKQorICAgIChuYXRpdmUtaW5wdXRzIChsaXN0IGF1dG9jb25mIGF1dG9tYWtlIGxpYnRv b2wgdGV4aW5mbykpCisgICAgKGlucHV0cyAobGlzdCBuY3Vyc2VzKSkKKyAgICAob3V0cHV0cyAn KCJvdXQiICJkZWJ1ZyIpKQorICAgIDs7IFRoZSBmb2xsb3dpbmcgd2FzIGNvcGllZCBmcm9tIHRo ZSBidW5kbGVkIFhNTCBmaWxlIGFuZCBmb3JtYXR0ZWQuCisgICAgKHN5bm9wc2lzICJaZW4gU2lt dWxhdGlvbiBvZiByb2JvdCBmaW5kaW5nIGtpdHRlbiIpCisgICAgKGRlc2NyaXB0aW9uCisgICAg ICJJbiB0aGlzIHNpbXVsYXRpb24sIHlvdSBwbGF5IHRoZSBwYXJ0IG9mIHJvYm90LiAgWW91ciB0 YXNrIGlzIHRvCitjb21wbGV0ZSB0aGUgc2ltdWxhdGlvbiBieSBmaW5kaW5nIGtpdHRlbiwgYXMg aXMgeW91ciBkZXN0aW55LCBhbmQgaW5kZWVkIHlvdXIKK3dvbnQuICBZb3UgKHJvYm90KSBhcmUg cmVwcmVzZW50ZWQgYnkgdGhlICMgY2hhcmFjdGVyLCBhbmQgeW91IG1vdmUgYXJvdW5kIHdpdGgK K3RoZSBhcnJvdyBrZXlzIHRvdWNoaW5nIHRoaW5ncy4gIElmIHRoZSB0aGluZyB5b3UgdG91Y2gg aXMga2l0dGVuLCB5b3UgZ2V0IGEKK2N1dGUgbGl0dGxlIGFuaW1hdGlvbiAod2hpY2ggd2FzIGN1 dGVyIGluIHRoZSBET1MgdmVyc2lvbikgYW5kIHRoZSBzaW11bGF0aW9uCitlbmRzLiAgT3RoZXJ3 aXNlLCB5b3UgZ2V0IGEgYnJpZWYgZGVzY3JpcHRpb24gb2Ygd2hhdCBpdCBpcyB5b3UgdG91Y2hl ZC4iKQorICAgIChob21lLXBhZ2UgImh0dHA6Ly9yb2JvdGZpbmRza2l0dGVuLm9yZy8iKQorICAg IChsaWNlbnNlIGxpY2Vuc2U6Z3BsMispKSkKKwogKGRlZmluZS1wdWJsaWMgcm9ndWVib3gtYWR2 ZW50dXJlcwogICAocGFja2FnZQogICAgIChuYW1lICJyb2d1ZWJveC1hZHZlbnR1cmVzIikKCmJh c2UtY29tbWl0OiA4YTA3MTNhZWYyYThkNzA5NTUxZDUxZmVmZmY0NWY0NjExZDA1YzY2Ci0tIAoy LjM0LjAKCg== --=-gKUO9Y86SR192lh+Sm80-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 21 02:59:55 2022 Received: (at 54476) by debbugs.gnu.org; 21 Mar 2022 06:59:55 +0000 Received: from localhost ([127.0.0.1]:35705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWC1C-0005Kz-Mh for submit@debbugs.gnu.org; Mon, 21 Mar 2022 02:59:54 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:35651) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWC1B-0005Kn-7Z for 54476@debbugs.gnu.org; Mon, 21 Mar 2022 02:59:53 -0400 Received: by mail-ed1-f68.google.com with SMTP id k10so2949188edj.2 for <54476@debbugs.gnu.org>; Sun, 20 Mar 2022 23:59:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=hTk6+jl5flvZ/kaj3SZr3Osgua9L1II/uVNL+vh9Buc=; b=J0PF5INM9beKET3GJklWQs4GEk4JMFFUPSm2IpOyZE9RfWRRTP1jziH2V2aRsNnIXy fsJtkXoUM1uKN34jxR/OtBbhSdtl+e2874Aow5IcQ+5VnlrrCJf6kksm4XTxXgxEjgxU gvIJYYbMbu1Owfu3UYeIc66H7IdhTJWIddCw8D7RFyZj/1FVWMqL561xfoDc40gjVk3g aBMnD/wQRyyur5+JaWC/L8KM5ap0viFexz02epzjPiM3WB4GTwJVx7dIXK5XZDW5/wVm bljb0bnoyqo4z/UJ3eHUnuooVqLnDjhH7NFNTqQ4s18+IYekszbOy1Lgzmw7jMymnfT9 Oy7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=hTk6+jl5flvZ/kaj3SZr3Osgua9L1II/uVNL+vh9Buc=; b=xIS8uhME6XdEC4wGk/KfuQsDDfejTst1VqOutKjporO8Q1Nug9PVpcz5KyPLPkjJKQ DApOlSR+Fx/s3nPqZxEroNta8JAzi1XWtfCaBEyCx5nnXm6bhm7pSnFZpWRNRpR5NNjR 9qfcWr51sSFhKi8Jzlckt+JJ7f5bWZdqEYgOmKqfw/uWXfpJ9kNpwpw9o8sYqZSFRvel ZqtEpT0rQIJd47cY0/Ph0zAPVUF3URpk0eXnXRfUfslNWoiI7AImJIsUrJJlCHLhsMcw EzTIhibegBJND+G9IUzLSyzxvvqgSr9f0xsTP3i2INcJsaGFqXbkkIqamtaaHtfIlGfk nmag== X-Gm-Message-State: AOAM532E2cJZu5dED6PNER9TuDYIdQHqYhwumrgVi3JPyCCLLPMWg+qD IDPTuPdP9est7ce/Ns4bzDg= X-Google-Smtp-Source: ABdhPJz5I9LK5lZiLpDNLhq2CAc53/j5okv981XvHFmxa0sQtWV3dbbL8mltnK3PzyQj+/dK5RMW6w== X-Received: by 2002:aa7:da81:0:b0:419:11e8:1039 with SMTP id q1-20020aa7da81000000b0041911e81039mr13711076eds.285.1647845987142; Sun, 20 Mar 2022 23:59:47 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id y14-20020a056402440e00b00416046b623csm7882383eda.2.2022.03.20.23.59.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 23:59:46 -0700 (PDT) Message-ID: Subject: Re: [PATCH] gnu: games: Add robotfindskitten. From: Liliana Marie Prikler To: Roman Riabenko , 54476@debbugs.gnu.org Date: Mon, 21 Mar 2022 07:59:45 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54476 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Roman, Am Sonntag, dem 20.03.2022 um 16:28 +0200 schrieb Roman Riabenko: > + ;; Despite what guix lint says, version 2.8284271.702 is newer > then > + ;; 1600003_201b. See ChangeLog for version history. > + (version "2.8284271.702") > + ;; The git version is the same as in the release tarball, but it > bundles > + ;; convenient .desktop files, which were requested for Debian. > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url > + > "https://github.com/robotfindskitten/robotfindskitten") > + (commit > "1cae36621f9c19d19a40eacf63789913d4ef5d5c"))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + > "0ps3xrl1yh0h7jhl3bwhx5xw2hvhzync03y08i66rzw098r530qq")))) Looking at the git repository, those are *not* the same. Use git- version or use the tag as commit, but don't mix conventions. > + (replace 'bootstrap > + (lambda _ > + (invoke "autoreconf" "-ifv"))) ;per README.md The existing bootstrap should already correctly invoke autoreconf if no bootstrap script exists. > + (add-after 'unpack 'fix-install-path > + (lambda _ > + ;; It is configured to install executable to > /games or > + ;; /usr/local/games per Filesystem Hierarchy > Standard. > + ;; We change that to get it in $PATH. > + (substitute* "src/Makefile.am" > + (("\\$\\(prefix\\)/games") "$(prefix)/bin")) We could change this by using #:make-flags instead, I believe. > + ;; When built with guix, all characters are > displayed in > + ;; the background colour pair. If it is not > set manually, > + ;; this is not happening, so we get back > colour into the > + ;; game. The background is redrawn anyway. See > man bkgd. > + (substitute* "src/robotfindskitten.c" > + (("\\(void\\) bkgd \\( \\(chtype\\) > COLOR_PAIR\\(WHITE\\) \\);") > + ""))))) This should probably go into a "patch-source" phase. > + (synopsis "Zen Simulation of robot finding kitten") > + (description > + "In this simulation, you play the part of robot. Your task is > to > +complete the simulation by finding kitten, as is your destiny, and > indeed your > +wont. You (robot) are represented by the # character, and you move > around with > +the arrow keys touching things. If the thing you touch is kitten, > you get a > +cute little animation (which was cuter in the DOS version) and the > simulation > +ends. Otherwise, you get a brief description of what it is you > touched.") Both synopsis and description could use some love. Plain copypasta with grammatical errors is not good optics. Cheers From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 24 11:38:28 2022 Received: (at 54476) by debbugs.gnu.org; 24 Mar 2022 15:38:28 +0000 Received: from localhost ([127.0.0.1]:49234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXPXb-0007XL-Pv for submit@debbugs.gnu.org; Thu, 24 Mar 2022 11:38:27 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:42737) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXPXZ-0007X3-8b for 54476@debbugs.gnu.org; Thu, 24 Mar 2022 11:38:22 -0400 Received: (Authenticated sender: roman@riabenko.com) by mail.gandi.net (Postfix) with ESMTPSA id E07591BF20F; Thu, 24 Mar 2022 15:38:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riabenko.com; s=gm1; t=1648136294; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uhuSjIyxZyd5N8eEkV+xNulIVJ6jAF6Hvaz913+MGwk=; b=iOvsslBX7xPtYL/fzGvWluXJe/M90swgIEIDxX25xCTsrUvopgrN9nLRCLm7f6+w/OGiuY eVoRX8MkMJ9H2S1ES78kmLSBtldYWA0Vpnzk1S6uk3I4z1eHda0DR+17we3p1uyLP/C+dT ptAG/J2bcuPoWNJXc2C2f/y9e5NDiLWWoVanUxX0LS1AK88355HWRM4apv8Mb2QEsrVNIG qudHMlXjIE26RXJt/XH1/M7fOa5fA0ULoFU2sxBl29LeeHG0huxqiEqljy1RN8E5RBnrgr 7yw4t8RWCNO3QAyNrKQu1nBsJ7vwNEHHAZCvS8dyLWydZq38WNF1XIQzgkVAgQ== Message-ID: <0eac7e2692804e6668a0246f79c0e88c495b336e.camel@riabenko.com> Subject: Re: [PATCH] gnu: games: Add robotfindskitten. From: Roman Riabenko To: Liliana Marie Prikler , 54476@debbugs.gnu.org Date: Thu, 24 Mar 2022 17:38:12 +0200 In-Reply-To: References: Content-Type: multipart/mixed; boundary="=-PaPr30M8Mdtk0ckCrq0j" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: 54476 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-PaPr30M8Mdtk0ckCrq0j Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Hi Liliana (Copying the mailing list.) Thank you for helping to improve this! У пн, 2022-03-21 у 07:59 +0100, Liliana Marie Prikler пише: > Hi Roman, >  > Am Sonntag, dem 20.03.2022 um 16:28 +0200 schrieb Roman Riabenko: >  > > +    ;; Despite what guix lint says, version 2.8284271.702 is newer > > then > > +    ;; 1600003_201b. See ChangeLog for version history. > > +    (version "2.8284271.702") > > +    ;; The git version is the same as in the release tarball, but > > it > > bundles > > +    ;; convenient .desktop files, which were requested for Debian. > > +    (source (origin > > +              (method git-fetch) > > +              (uri (git-reference > > +                    (url > > +                     > > "https://github.com/robotfindskitten/robotfindskitten") > > +                    (commit > > "1cae36621f9c19d19a40eacf63789913d4ef5d5c"))) > > +              (file-name (git-file-name name version)) > > +              (sha256 > > +               (base32 > > +                > > "0ps3xrl1yh0h7jhl3bwhx5xw2hvhzync03y08i66rzw098r530qq")))) > Looking at the git repository, those are *not* the same.  Use git- > version or use the tag as commit, but don't mix conventions. I thought the commit log is misleading. Before submitting the patch, I checked the code and data files, but now that I checked documentation too, I see that the release, including packages in Debian and Fedora, do not have the latest fixes to documentation. It bugged me as cruel towards users to package the release version with wrong documentation, but, at a more thorough inspection, the inconsistency in documentation can be figured out after all. If the authors and maintainers did not deem it worth a release, I do not feel confident to. After all, I cannot rule out that, theoretically, someone may even rely on "man robotfindskitten" output for something. The checkout of the git tag which corresponds to the release version number is, strictly speaking, somewhat different from the release tarball. Among other things, it has "contrib" directory with PalmOS port code. Debian also has the same tarball for original source. Considering all that, I'd rather go with the tarball than git. > > +                  (replace 'bootstrap > > +                    (lambda _ > > +                      (invoke "autoreconf" "-ifv"))) ;per > > README.md > The existing bootstrap should already correctly invoke autoreconf if > no > bootstrap script exists. I recall having some issue without this modification, but I cannot reproduce it now. Removing. > > +                  (add-after 'unpack 'fix-install-path > > +                    (lambda _ > > +                      ;; It is configured to install executable to > > /games or > > +                      ;; /usr/local/games per Filesystem Hierarchy > > Standard. > > +                      ;; We change that to get it in $PATH. > > +                      (substitute* "src/Makefile.am" > > +                        (("\\$\\(prefix\\)/games") > > "$(prefix)/bin")) > We could change this by using #:make-flags instead, I believe. Thank you for the hint. I didn't expect it to be that simple. > > +                      ;; When built with guix, all characters are > > displayed in > > +                      ;; the background colour pair. If it is not > > set manually, > > +                      ;; this is not happening, so we get back > > colour into the > > +                      ;; game. The background is redrawn anyway. > > See > > man bkgd. > > +                      (substitute* "src/robotfindskitten.c" > > +                        (("\\(void\\) bkgd \\( \\(chtype\\) > > COLOR_PAIR\\(WHITE\\) \\);") > > +                         ""))))) > This should probably go into a "patch-source" phase. I moved this part to a source origin snippet. > > +    (synopsis "Zen Simulation of robot finding kitten") > > +    (description > > +     "In this simulation, you play the part of robot.  Your task > > is > > to > > +complete the simulation by finding kitten, as is your destiny, and > > indeed your > > +wont.  You (robot) are represented by the # character, and you > > move > > around with > > +the arrow keys touching things.  If the thing you touch is kitten, > > you get a > > +cute little animation (which was cuter in the DOS version) and the > > simulation > > +ends.  Otherwise, you get a brief description of what it is you > > touched.") > Both synopsis and description could use some love.  Plain copypasta > with grammatical errors is not good optics. My first impression was that it needs some improvement. But I was quickly discouraged and here is why. The problem I have with it is that it apparently attempts to pretend to be something more, not even a game at all, but the Zen Simulation. The authors invite the audience to a make-believe and this starts with the synopsis and description and continues in the game and in its documentation. The story begins with such synopsis and description in other distributions and package managers too. I really feel as intruding into the game against the authors intentions by attempting to modify those. As to the grammar and spelling, I am embarrassed of my ignorance and fond of learning something new, which is one of the reasons that I like this game. When I saw the word "wont", I couldn't imagine that it is a valid English word, until I verified it with a dictionary. The words "robot" and "kitten" are consistently used without an article (including in-game texts and documentation) treating them specially as characters of the story. The same goes for both words of "Zen Simulation" being capitalised. So I leave it as is for now. I attach a different patch as my new offer. Roman --=-PaPr30M8Mdtk0ckCrq0j Content-Disposition: attachment; filename="0001-gnu-games-Add-robotfindskitten.patch" Content-Type: text/x-patch; name="0001-gnu-games-Add-robotfindskitten.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSA3ZTI5ZjI2Mjg4YmYyYTY3NjRmMGI5MGNkN2ViMzZjMmI0OGU1ZTdlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb21hbiBSaWFiZW5rbyA8cm9tYW5AcmlhYmVua28uY29tPgpE YXRlOiBUaHUsIDI0IE1hciAyMDIyIDE3OjEyOjMwICswMjAwClN1YmplY3Q6IFtQQVRDSF0gZ251 OiBnYW1lczogQWRkIHJvYm90ZmluZHNraXR0ZW4uCgoqIGdudS9wYWNrYWdlcy9nYW1lcy5zY20g KHJvYm90ZmluZHNraXR0ZW4pOiBOZXcgdmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL2dhbWVz LnNjbSB8IDUzICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBm aWxlIGNoYW5nZWQsIDUzIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMv Z2FtZXMuc2NtIGIvZ251L3BhY2thZ2VzL2dhbWVzLnNjbQppbmRleCA4Y2MyOWIzNDg3Li5mMTM1 MjNhMTkwIDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvZ2FtZXMuc2NtCisrKyBiL2dudS9wYWNr YWdlcy9nYW1lcy5zY20KQEAgLTY5LDYgKzY5LDcgQEAKIDs7OyBDb3B5cmlnaHQgwqkgMjAyMSBD aHJpc3RvcGhlciBCYWluZXMgPG1haWxAY2JhaW5lcy5uZXQ+CiA7OzsgQ29weXJpZ2h0IMKpIDIw MjEgRm9vIENodWFuIFdlaSA8Y2h1YW53ZWkuZm9vQGhvdG1haWwuY29tPgogOzs7IENvcHlyaWdo dCDCqSAyMDIyIFlvdmFuIE5hdW1vdnNraSA8eW92YW5AZ29yc2tpLnN0cmVhbT4KKzs7OyBDb3B5 cmlnaHQgwqkgMjAyMiBSb21hbiBSaWFiZW5rbyA8cm9tYW5AcmlhYmVua28uY29tPgogOzs7CiA7 OzsgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCiA7OzsKQEAgLTIyNTAsNiArMjI1MSw1 OCBAQCAoZGVmaW5lLXB1YmxpYyByZXR1eAogICAgICAgICAgICAgICAgICAgICAgbGljZW5zZTpn cGwyKwogICAgICAgICAgICAgICAgICAgICAgbGljZW5zZTpncGwzKykpKSkpCiAKKyhkZWZpbmUt cHVibGljIHJvYm90ZmluZHNraXR0ZW4KKyAgOzsgRGVzcGl0ZSB3aGF0IGd1aXggbGludCBzYXlz LCB2ZXJzaW9uIDIuODI4NDI3MS43MDIgaXMgbmV3ZXIgdGhhbgorICA7OyAxNjAwMDAzXzIwMWIu IFNlZSBDaGFuZ2VMb2cgZm9yIHZlcnNpb24gaGlzdG9yeS4KKyAgKHBhY2thZ2UKKyAgICAobmFt ZSAicm9ib3RmaW5kc2tpdHRlbiIpCisgICAgKHZlcnNpb24gIjIuODI4NDI3MS43MDIiKQorICAg IChzb3VyY2UKKyAgICAgIChvcmlnaW4KKyAgICAgICAgKG1ldGhvZCB1cmwtZmV0Y2gpCisgICAg ICAgICh1cmkgKHN0cmluZy1hcHBlbmQgImh0dHBzOi8vZ2l0aHViLmNvbS8iCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgbmFtZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICIvIgor ICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5hbWUKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAiL3JlbGVhc2VzL2Rvd25sb2FkLyIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICB2 ZXJzaW9uCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIi8iCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgbmFtZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICItIgorICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHZlcnNpb24KKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAiLnRhci5neiIpKQorICAgICAgICAoc2hhMjU2CisgICAgICAgICAoYmFzZTMyCisgICAgICAg ICAgIjFid3JreG04M3I5YWpwa2Q2eDAzbnF2bWRmcGY1dno2eWZ5MGM5N3BxM3YzeWtqNzQwODIi KSkKKyAgICAgICAgOzsgV2hlbiBidWlsdCB3aXRoIGd1aXgsIGFsbCBjaGFyYWN0ZXJzIGFyZSBk aXNwbGF5ZWQgaW4gdGhlIGJhY2tncm91bmQKKyAgICAgICAgOzsgY29sb3VyIHBhaXIgZm9yIHNv bWUgcmVhc29uLiBJZiBpdCBpcyBub3Qgc2V0IGJ5IHRoZSBwcm9ncmFtLCB0aGlzCisgICAgICAg IDs7IGlzIG5vdCBoYXBwZW5pbmcsIHNvIHRoZSBnYW1lIGlzIGNvbG91cmVkIHByb3Blcmx5Lgor ICAgICAgICAobW9kdWxlcyAnKChndWl4IGJ1aWxkIHV0aWxzKSkpCisgICAgICAgIChzbmlwcGV0 CisgICAgICAgICAjfihiZWdpbgorICAgICAgICAgICAgKHN1YnN0aXR1dGUqICJzcmMvcm9ib3Rm aW5kc2tpdHRlbi5jIgorICAgICAgICAgICAgICgoIlxcKHZvaWRcXCkgYmtnZCBcXCggXFwoY2h0 eXBlXFwpIENPTE9SX1BBSVJcXChXSElURVxcKSBcXCk7IikKKyAgICAgICAgICAgICAgICIiKSkp KSkpCisgICAgKGJ1aWxkLXN5c3RlbSBnbnUtYnVpbGQtc3lzdGVtKQorICAgIChhcmd1bWVudHMK KyAgICAgJygjOmNvbmZpZ3VyZS1mbGFncyAnKCItLWVuYWJsZS1zaWxlbnQtcnVsZXMiKQorICAg ICAgICM6bWFrZS1mbGFncyA7aW5zdGFsbCB0byAvYmluIGluc3RlYWQgb2YgL2dhbWUKKyAgICAg ICAobGlzdCAoc3RyaW5nLWFwcGVuZCAiZXhlY2dhbWVzZGlyPSIKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAoYXNzb2MtcmVmICVvdXRwdXRzICJvdXQiKSAiL2JpbiIpKSkpCisgICAgKGlu cHV0cyAobGlzdCBuY3Vyc2VzKSkKKyAgICAob3V0cHV0cyAnKCJvdXQiICJkZWJ1ZyIpKQorICAg IDs7IFRoZSBmb2xsb3dpbmcgYXJlIHRoZSBvcmlnaW5hbCBzeW5vcHNpcyBhbmQgZGVzY3JpcHRp b24gYnkgdGhlIGF1dGhvcnMuCisgICAgKHN5bm9wc2lzICJaZW4gU2ltdWxhdGlvbiBvZiByb2Jv dCBmaW5kaW5nIGtpdHRlbiIpCisgICAgKGRlc2NyaXB0aW9uCisgICAgICJJbiB0aGlzIHNpbXVs YXRpb24sIHlvdSBwbGF5IHRoZSBwYXJ0IG9mIHJvYm90LiAgWW91ciB0YXNrIGlzIHRvCitjb21w bGV0ZSB0aGUgc2ltdWxhdGlvbiBieSBmaW5kaW5nIGtpdHRlbiwgYXMgaXMgeW91ciBkZXN0aW55 LCBhbmQgaW5kZWVkIHlvdXIKK3dvbnQuICBZb3UgKHJvYm90KSBhcmUgcmVwcmVzZW50ZWQgYnkg dGhlICMgY2hhcmFjdGVyLCBhbmQgeW91IG1vdmUgYXJvdW5kIHdpdGgKK3RoZSBhcnJvdyBrZXlz IHRvdWNoaW5nIHRoaW5ncy4gIElmIHRoZSB0aGluZyB5b3UgdG91Y2ggaXMga2l0dGVuLCB5b3Ug Z2V0IGEKK2N1dGUgbGl0dGxlIGFuaW1hdGlvbiAod2hpY2ggd2FzIGN1dGVyIGluIHRoZSBET1Mg dmVyc2lvbikgYW5kIHRoZSBzaW11bGF0aW9uCitlbmRzLiAgT3RoZXJ3aXNlLCB5b3UgZ2V0IGEg YnJpZWYgZGVzY3JpcHRpb24gb2Ygd2hhdCBpdCBpcyB5b3UgdG91Y2hlZC4iKQorICAgIChob21l LXBhZ2UgImh0dHA6Ly9yb2JvdGZpbmRza2l0dGVuLm9yZy8iKQorICAgIChsaWNlbnNlIGxpY2Vu c2U6Z3BsMispKSkKKwogKGRlZmluZS1wdWJsaWMgcm9ndWVib3gtYWR2ZW50dXJlcwogICAocGFj a2FnZQogICAgIChuYW1lICJyb2d1ZWJveC1hZHZlbnR1cmVzIikKCmJhc2UtY29tbWl0OiAxODEx OWZlMjg4MTY2ZmY0ODBjYTI3YTEzNTFiMDllOWMzMWMxNDYzCi0tIAoyLjM0LjAKCg== --=-PaPr30M8Mdtk0ckCrq0j-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 28 09:56:24 2022 Received: (at 54476) by debbugs.gnu.org; 28 Mar 2022 13:56:24 +0000 Received: from localhost ([127.0.0.1]:58891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYpr5-0002WT-LA for submit@debbugs.gnu.org; Mon, 28 Mar 2022 09:56:24 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:34873) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYpr2-0002WE-4J for 54476@debbugs.gnu.org; Mon, 28 Mar 2022 09:56:21 -0400 Received: (Authenticated sender: roman@riabenko.com) by mail.gandi.net (Postfix) with ESMTPSA id 2098D240017; Mon, 28 Mar 2022 13:56:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riabenko.com; s=gm1; t=1648475773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Yb+vGNW5gChaY+rhWSDI6B56g4uzJXYUXZpKIvFyGtg=; b=A/DpjsZjcXhKXATJLDkyP/EhvQWuZ6FgTxiRSHkhoNl4UIXkvMe1fWY1dwKFoLiNrCbPE7 03Lww2r06rqmmOZqbkbA6DZmVhWfrg+zeoTKi5ki/nkUum1pfov7U+LoL39tFCLlW+71XE XPiPdJ/WLCMiCrzmS7bskwxWRl81NIEf1Xd+C4VUBcr9zvsBWsN/s5OJObjExJxGDLAEyF PCVBkbQK+iGroUEaCMAYcG3CRofubY6atgRENH/sEq6o4Kxa1hzk7t/AX3+hJdBBDA1sH2 DVmGjYJ7vQAJy1210M/DWzmmr7I3mgEeOZPtMZnotJUrd3pSb6wtYnKUqMxryg== Message-ID: <8a0d6013e738fe0ea9fb7808aae2d1e7bc014669.camel@riabenko.com> Subject: Re: [PATCH] gnu: games: Add robotfindskitten. From: Roman Riabenko To: 54476@debbugs.gnu.org Date: Mon, 28 Mar 2022 16:56:10 +0300 In-Reply-To: <0eac7e2692804e6668a0246f79c0e88c495b336e.camel@riabenko.com> References: <0eac7e2692804e6668a0246f79c0e88c495b336e.camel@riabenko.com> Content-Type: multipart/mixed; boundary="=-kbLsYeO2UF6dDde8R2Jc" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: 54476 Cc: Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-kbLsYeO2UF6dDde8R2Jc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Hello I thought that I was working around a local implementation of ncurses, but now I am convinced that there is a local bug, which I filed a report against. See issue 54607. [1] [1]: https://issues.guix.gnu.org/54607 Assuming that the bug will be fixed, there is no need for the snippet which I proposed in previous patches. I attach a new patch to add robotfindskitten, which is my offer in place of previous patches. Meanwhile, even with that bug not being fixed, robotfindskitten is still playable. It is just monochrome, which is a mode natively supported by the game design. Roman --=-kbLsYeO2UF6dDde8R2Jc Content-Disposition: attachment; filename="0001-gnu-games-Add-robotfindskitten.patch" Content-Type: text/x-patch; name="0001-gnu-games-Add-robotfindskitten.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSA0NzBhYjlkMjM2YTc4MDQyNTY3OWY0ZDI0Nzc2NjQwZTdiYjc2NmNjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb21hbiBSaWFiZW5rbyA8cm9tYW5AcmlhYmVua28uY29tPgpE YXRlOiBNb24sIDI4IE1hciAyMDIyIDE2OjQ5OjAzICswMzAwClN1YmplY3Q6IFtQQVRDSF0gZ251 OiBnYW1lczogQWRkIHJvYm90ZmluZHNraXR0ZW4uCgoqIGdudS9wYWNrYWdlcy9nYW1lcy5zY20g KHJvYm90ZmluZHNraXR0ZW4pOiBOZXcgdmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL2dhbWVz LnNjbSB8IDQzICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBm aWxlIGNoYW5nZWQsIDQzIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMv Z2FtZXMuc2NtIGIvZ251L3BhY2thZ2VzL2dhbWVzLnNjbQppbmRleCA4Y2MyOWIzNDg3Li43YTIz MTQwNTA4IDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvZ2FtZXMuc2NtCisrKyBiL2dudS9wYWNr YWdlcy9nYW1lcy5zY20KQEAgLTY5LDYgKzY5LDcgQEAKIDs7OyBDb3B5cmlnaHQgwqkgMjAyMSBD aHJpc3RvcGhlciBCYWluZXMgPG1haWxAY2JhaW5lcy5uZXQ+CiA7OzsgQ29weXJpZ2h0IMKpIDIw MjEgRm9vIENodWFuIFdlaSA8Y2h1YW53ZWkuZm9vQGhvdG1haWwuY29tPgogOzs7IENvcHlyaWdo dCDCqSAyMDIyIFlvdmFuIE5hdW1vdnNraSA8eW92YW5AZ29yc2tpLnN0cmVhbT4KKzs7OyBDb3B5 cmlnaHQgwqkgMjAyMiBSb21hbiBSaWFiZW5rbyA8cm9tYW5AcmlhYmVua28uY29tPgogOzs7CiA7 OzsgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCiA7OzsKQEAgLTIyNTAsNiArMjI1MSw0 OCBAQCAoZGVmaW5lLXB1YmxpYyByZXR1eAogICAgICAgICAgICAgICAgICAgICAgbGljZW5zZTpn cGwyKwogICAgICAgICAgICAgICAgICAgICAgbGljZW5zZTpncGwzKykpKSkpCiAKKyhkZWZpbmUt cHVibGljIHJvYm90ZmluZHNraXR0ZW4KKyAgOzsgRGVzcGl0ZSB3aGF0IGd1aXggbGludCBzYXlz LCB2ZXJzaW9uIDIuODI4NDI3MS43MDIgaXMgbmV3ZXIgdGhhbgorICA7OyAxNjAwMDAzXzIwMWIu IFNlZSBDaGFuZ2VMb2cgZm9yIHZlcnNpb24gaGlzdG9yeS4KKyAgKHBhY2thZ2UKKyAgICAobmFt ZSAicm9ib3RmaW5kc2tpdHRlbiIpCisgICAgKHZlcnNpb24gIjIuODI4NDI3MS43MDIiKQorICAg IChzb3VyY2UgKG9yaWdpbgorICAgICAgICAgICAgICAobWV0aG9kIHVybC1mZXRjaCkKKyAgICAg ICAgICAgICAgKHVyaSAoc3RyaW5nLWFwcGVuZCAiaHR0cHM6Ly9naXRodWIuY29tLyIKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBuYW1lCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIi8iCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbmFtZQor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIvcmVsZWFzZXMvZG93bmxvYWQvIgor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZlcnNpb24KKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAiLyIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBuYW1lCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIi0iCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgdmVyc2lvbgorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICIudGFyLmd6IikpCisgICAgICAgICAgICAgIChzaGEyNTYKKyAgICAgICAgICAg ICAgIChiYXNlMzIKKyAgICAgICAgICAgICAgICAiMWJ3cmt4bTgzcjlhanBrZDZ4MDNucXZtZGZw ZjV2ejZ5ZnkwYzk3cHEzdjN5a2o3NDA4MiIpKSkpCisgICAgKGJ1aWxkLXN5c3RlbSBnbnUtYnVp bGQtc3lzdGVtKQorICAgIChhcmd1bWVudHMKKyAgICAgJygjOmNvbmZpZ3VyZS1mbGFncyAnKCIt LWVuYWJsZS1zaWxlbnQtcnVsZXMiKQorICAgICAgICM6bWFrZS1mbGFncyA7aW5zdGFsbCB0byAv YmluIGluc3RlYWQgb2YgL2dhbWUKKyAgICAgICAobGlzdCAoc3RyaW5nLWFwcGVuZCAiZXhlY2dh bWVzZGlyPSIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAoYXNzb2MtcmVmICVvdXRwdXRz ICJvdXQiKSAiL2JpbiIpKSkpCisgICAgKGlucHV0cyAobGlzdCBuY3Vyc2VzKSkKKyAgICAob3V0 cHV0cyAnKCJvdXQiICJkZWJ1ZyIpKQorICAgIDs7IFRoZSBmb2xsb3dpbmcgYXJlIHRoZSBvcmln aW5hbCBzeW5vcHNpcyBhbmQgZGVzY3JpcHRpb24gYnkgdGhlIGF1dGhvcnMuCisgICAgKHN5bm9w c2lzICJaZW4gU2ltdWxhdGlvbiBvZiByb2JvdCBmaW5kaW5nIGtpdHRlbiIpCisgICAgKGRlc2Ny aXB0aW9uCisgICAgICJJbiB0aGlzIHNpbXVsYXRpb24sIHlvdSBwbGF5IHRoZSBwYXJ0IG9mIHJv Ym90LiAgWW91ciB0YXNrIGlzIHRvCitjb21wbGV0ZSB0aGUgc2ltdWxhdGlvbiBieSBmaW5kaW5n IGtpdHRlbiwgYXMgaXMgeW91ciBkZXN0aW55LCBhbmQgaW5kZWVkIHlvdXIKK3dvbnQuICBZb3Ug KHJvYm90KSBhcmUgcmVwcmVzZW50ZWQgYnkgdGhlICMgY2hhcmFjdGVyLCBhbmQgeW91IG1vdmUg YXJvdW5kIHdpdGgKK3RoZSBhcnJvdyBrZXlzIHRvdWNoaW5nIHRoaW5ncy4gIElmIHRoZSB0aGlu ZyB5b3UgdG91Y2ggaXMga2l0dGVuLCB5b3UgZ2V0IGEKK2N1dGUgbGl0dGxlIGFuaW1hdGlvbiAo d2hpY2ggd2FzIGN1dGVyIGluIHRoZSBET1MgdmVyc2lvbikgYW5kIHRoZSBzaW11bGF0aW9uCitl bmRzLiAgT3RoZXJ3aXNlLCB5b3UgZ2V0IGEgYnJpZWYgZGVzY3JpcHRpb24gb2Ygd2hhdCBpdCBp cyB5b3UgdG91Y2hlZC4iKQorICAgIChob21lLXBhZ2UgImh0dHA6Ly9yb2JvdGZpbmRza2l0dGVu Lm9yZy8iKQorICAgIChsaWNlbnNlIGxpY2Vuc2U6Z3BsMispKSkKKwogKGRlZmluZS1wdWJsaWMg cm9ndWVib3gtYWR2ZW50dXJlcwogICAocGFja2FnZQogICAgIChuYW1lICJyb2d1ZWJveC1hZHZl bnR1cmVzIikKCmJhc2UtY29tbWl0OiA3MzhkYTY2MGZmNTFlMDNiNWVmNjNhZjlmYTgxZWI1MGNi MjIyOTI4Ci0tIAoyLjM0LjAKCg== --=-kbLsYeO2UF6dDde8R2Jc-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 28 14:34:51 2022 Received: (at 54476) by debbugs.gnu.org; 28 Mar 2022 18:34:52 +0000 Received: from localhost ([127.0.0.1]:59181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYuCZ-0001Gq-Kq for submit@debbugs.gnu.org; Mon, 28 Mar 2022 14:34:51 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:33739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYuCX-0001Gd-9x for 54476@debbugs.gnu.org; Mon, 28 Mar 2022 14:34:49 -0400 Received: by mail-ed1-f68.google.com with SMTP id r23so18001932edb.0 for <54476@debbugs.gnu.org>; Mon, 28 Mar 2022 11:34:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=IIpBnRUhQCdEQMt75s7MlBSrtlMpwMaKy2GCjlYVqUE=; b=QToJf3UoyXVIg3WVoIyw/UW4hxyvK4kLZ2jaH+g6v3av9LveA3P1X6BqU23UzEl49x 3efZxHVfeSUvPAVZTErDXf13viIQlNn5jZiKNMO4JlzxTI/Jy4nib09qkxTdURK0qYwl FCSsxlw/QLnwVerKGEnWIJu5VVKIeT8oiU5h5dsPkupCRQwyZNWUMc1ojpfFzdqrAMcQ /2sgdERqAjpNh0uvYGgeTMuRdlOrU1XpAGSRFXH1zL2D7q0FkrctVh/boMcxG9x6PfOu nepGJyb+y3Y1bK1VDfRIpB5dZ4nWqZwmVNvc8Pq0Om2/LEYA3U0/3AFSmccmuETLynDr R9QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=IIpBnRUhQCdEQMt75s7MlBSrtlMpwMaKy2GCjlYVqUE=; b=Ee4c/94GKyQijVt6sK7P6aZ8ydv3UawNYqdFXE+xyEynmlSShuYbT+PwhFKGsGRTsw 6TDTxSOgb0ScY/4m+UU2C/MXqVLgVMImQriEUA7Euzcf9jzmntScJI52g3svvS6neMph KyAEl7BxlBEE8nQ6rnEGH8iYyq5m8GkdVQzc7fjpOqpQ1wJMMEQvVhwCwPeTDEUJLWgp XrzYSBDAY3IS+Xs+NpiI+AiSFKwkCIlISRX/oCzQWM3hXhteq5/mr41QOcuadJt3aD5Y E70Zz+F3H9IH2EY/Rdupl4dg1/G8iiPEDu1VYj/jDrg/S9K9ySg4+QJ06Uxtg/t1TlO/ oEBQ== X-Gm-Message-State: AOAM531fvFwzMmNuqWv15TjdAkHsWJbwq6nMDjH7xYFF645gAYZ6RK9E e51IWUcUn69SZBDlSG6rjbQ= X-Google-Smtp-Source: ABdhPJxY0UuDy04XN31wWwKpShkB3bg4a0+nO/bZUDIk5h9aUji6rzSA5sH409TnyerESULQwjycSQ== X-Received: by 2002:a05:6402:27d4:b0:419:5105:f7e7 with SMTP id c20-20020a05640227d400b004195105f7e7mr17998991ede.356.1648492483249; Mon, 28 Mar 2022 11:34:43 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id qk30-20020a1709077f9e00b006dfae33d969sm6200017ejc.216.2022.03.28.11.34.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 11:34:42 -0700 (PDT) Message-ID: <38b2054628730328b7bd2544597a7db9c0431acb.camel@gmail.com> Subject: Re: [PATCH] gnu: games: Add robotfindskitten. From: Liliana Marie Prikler To: Roman Riabenko , 54476@debbugs.gnu.org Date: Mon, 28 Mar 2022 20:34:41 +0200 In-Reply-To: <8a0d6013e738fe0ea9fb7808aae2d1e7bc014669.camel@riabenko.com> References: <0eac7e2692804e6668a0246f79c0e88c495b336e.camel@riabenko.com> <8a0d6013e738fe0ea9fb7808aae2d1e7bc014669.camel@riabenko.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54476 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Montag, dem 28.03.2022 um 16:56 +0300 schrieb Roman Riabenko: > Hello > > I thought that I was working around a local implementation of > ncurses, but now I am convinced that there is a local bug, which I > filed a report against. See issue 54607. [1] > > [1]: https://issues.guix.gnu.org/54607 > > Assuming that the bug will be fixed, there is no need for the snippet > which I proposed in previous patches. I attach a new patch to add > robotfindskitten, which is my offer in place of previous patches. For the record, you are still allowed to patch the source in a snippet or build phase, but you should add a comment referring to this bug when doing so. > Meanwhile, even with that bug not being fixed, robotfindskitten is > still playable. It is just monochrome, which is a mode natively > supported by the game design. Is that purely an aesthetic choice or are there other things to consider w.r.t. your previous phase? If "monochrome" means black on white or vice versa and the game only needs those colors, then sure, waiting for ncurses to be fixed might be the wiser option. > + (uri (string-append "https://github.com/" > + name > + "/" > + name > + "/releases/download/" > + version > + "/" > + name > + "-" > + version > + ".tar.gz")) Guix style does not always result in the best possible indentation and is to be taken with a grain of salt. > + (synopsis "Zen Simulation of robot finding kitten") > + (description > + "In this simulation, you play the part of robot. Your task is > to > +complete the simulation by finding kitten, as is your destiny, and > indeed your > +wont. You (robot) are represented by the # character, and you move > around with > +the arrow keys touching things. If the thing you touch is kitten, > you get a > +cute little animation (which was cuter in the DOS version) and the > simulation > +ends. Otherwise, you get a brief description of what it is you > touched.") Again, this synopsis and description need some love (grammatically speaking), but it should also cut down on advertisements for proprietary systems. Cheers From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 11 06:34:51 2022 Received: (at 54476) by debbugs.gnu.org; 11 Apr 2022 10:34:51 +0000 Received: from localhost ([127.0.0.1]:42642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ndrNj-0003qX-7F for submit@debbugs.gnu.org; Mon, 11 Apr 2022 06:34:51 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:59377) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ndrNg-0003qH-E2 for 54476@debbugs.gnu.org; Mon, 11 Apr 2022 06:34:49 -0400 Received: (Authenticated sender: roman@riabenko.com) by mail.gandi.net (Postfix) with ESMTPSA id F10F724000B; Mon, 11 Apr 2022 10:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riabenko.com; s=gm1; t=1649673281; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2k8q/1er0Fxhp/LoXDh99N4lliOmFqxYAuNEfxgLG4Y=; b=UG7I/HIelZcYD6amqflaz/S/iLZPNuLkgrjEKl1FYH9nqWdtnlYsgxrH8WjWk14w8QJPwz 689ZYDDMNY+U2dGfFPYmzBL02fyD9lv6FsNsBoFN1cFnnnn6/yQPbvevJ98FGlb7qvk3LC aiqSYObZ6GKYW/bGoqIFwVPtuCElPwW3bSz7wMPUV4/pp1e7Hld2nLK/kJ82YS2MEoFKyQ Hzqw4gV0Z0gmr0AV49oWvcznp1knrFusp3mhSc9XmrsWWcZ/qqPFG7wFvbMKDyh0wJo6PE 29zwHPTjpef4NL38l3wP4TzZJ/R6EY9sMSGoT9h53Jn0/qJYrlubDUZWph51Zw== Message-ID: Subject: Re: [PATCH] gnu: games: Add robotfindskitten. From: Roman Riabenko To: Liliana Marie Prikler , 54476@debbugs.gnu.org Date: Mon, 11 Apr 2022 13:34:39 +0300 In-Reply-To: <38b2054628730328b7bd2544597a7db9c0431acb.camel@gmail.com> References: <0eac7e2692804e6668a0246f79c0e88c495b336e.camel@riabenko.com> <8a0d6013e738fe0ea9fb7808aae2d1e7bc014669.camel@riabenko.com> <38b2054628730328b7bd2544597a7db9c0431acb.camel@gmail.com> Content-Type: multipart/mixed; boundary="=-R13fUJg9QExpzSXUpwn4" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: 54476 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-R13fUJg9QExpzSXUpwn4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Hi Liliana I attach a replacement patch that should address all concerns. Roman --=-R13fUJg9QExpzSXUpwn4 Content-Disposition: attachment; filename="0001-gnu-games-Add-robotfindskitten.patch" Content-Type: text/x-patch; name="0001-gnu-games-Add-robotfindskitten.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSBhNmY2N2U3ZjE3Yjg5MjRkOTI4ZjI2Y2FjYTcwZDBiN2RkZmM1YTA0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb21hbiBSaWFiZW5rbyA8cm9tYW5AcmlhYmVua28uY29tPgpE YXRlOiBNb24sIDExIEFwciAyMDIyIDEzOjI3OjA4ICswMzAwClN1YmplY3Q6IFtQQVRDSF0gZ251 OiBnYW1lczogQWRkIHJvYm90ZmluZHNraXR0ZW4uCgoqIGdudS9wYWNrYWdlcy9nYW1lcy5zY20g KHJvYm90ZmluZHNraXR0ZW4pOiBOZXcgdmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL2dhbWVz LnNjbSB8IDMxICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2Vk LCAzMSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL2dhbWVzLnNjbSBi L2dudS9wYWNrYWdlcy9nYW1lcy5zY20KaW5kZXggOGNjMjliMzQ4Ny4uZjFhZTkwZDg0NyAxMDA2 NDQKLS0tIGEvZ251L3BhY2thZ2VzL2dhbWVzLnNjbQorKysgYi9nbnUvcGFja2FnZXMvZ2FtZXMu c2NtCkBAIC02OSw2ICs2OSw3IEBACiA7OzsgQ29weXJpZ2h0IMKpIDIwMjEgQ2hyaXN0b3BoZXIg QmFpbmVzIDxtYWlsQGNiYWluZXMubmV0PgogOzs7IENvcHlyaWdodCDCqSAyMDIxIEZvbyBDaHVh biBXZWkgPGNodWFud2VpLmZvb0Bob3RtYWlsLmNvbT4KIDs7OyBDb3B5cmlnaHQgwqkgMjAyMiBZ b3ZhbiBOYXVtb3Zza2kgPHlvdmFuQGdvcnNraS5zdHJlYW0+Cis7OzsgQ29weXJpZ2h0IMKpIDIw MjIgUm9tYW4gUmlhYmVua28gPHJvbWFuQHJpYWJlbmtvLmNvbT4KIDs7OwogOzs7IFRoaXMgZmls ZSBpcyBwYXJ0IG9mIEdOVSBHdWl4LgogOzs7CkBAIC0yMjUwLDYgKzIyNTEsMzYgQEAgKGRlZmlu ZS1wdWJsaWMgcmV0dXgKICAgICAgICAgICAgICAgICAgICAgIGxpY2Vuc2U6Z3BsMisKICAgICAg ICAgICAgICAgICAgICAgIGxpY2Vuc2U6Z3BsMyspKSkpKQogCisoZGVmaW5lLXB1YmxpYyByb2Jv dGZpbmRza2l0dGVuCisgIChwYWNrYWdlCisgICAgKG5hbWUgInJvYm90ZmluZHNraXR0ZW4iKQor ICAgICh2ZXJzaW9uICIyLjgyODQyNzEuNzAyIikgICAgICAgICAgICA7IDE2MDAwMDNfMjAxYiBp cyBvbGRlciwgc2VlIENoYW5nZUxvZworICAgIChzb3VyY2UgKG9yaWdpbgorICAgICAgICAgICAg ICAobWV0aG9kIHVybC1mZXRjaCkKKyAgICAgICAgICAgICAgKHVyaSAoc3RyaW5nLWFwcGVuZCAi aHR0cHM6Ly9naXRodWIuY29tLyIgbmFtZSAiLyIgbmFtZQorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICIvcmVsZWFzZXMvZG93bmxvYWQvIiB2ZXJzaW9uICIvIgorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIG5hbWUgIi0iIHZlcnNpb24gIi50YXIuZ3oiKSkKKyAg ICAgICAgICAgICAgKHNoYTI1NgorICAgICAgICAgICAgICAgIChiYXNlMzIKKyAgICAgICAgICAg ICAgICAgIjFid3JreG04M3I5YWpwa2Q2eDAzbnF2bWRmcGY1dno2eWZ5MGM5N3BxM3YzeWtqNzQw ODIiKSkpKQorICAgIChidWlsZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3RlbSkKKyAgICAoYXJndW1l bnRzCisgICAgICAobGlzdCAjOnRlc3RzPyAjZiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg OyB0aGVyZSBhcmUgbm8gdGVzdHMKKyAgICAgICAgICAgICM6bWFrZS1mbGFncworICAgICAgICAg ICAgI34obGlzdCAiQ0ZMQUdTPS1EX1hPUEVOX1NPVVJDRT02MDAiICAgIDsgaHR0cDovL2J1Z3Mu Z251Lm9yZy81NDYwNworICAgICAgICAgICAgICAgICAgICAoc3RyaW5nLWFwcGVuZCAiZXhlY2dh bWVzZGlyPSIgIyRvdXRwdXQgIi9iaW4iKSkpKSA7IC9nYW1lcworICAgIChpbnB1dHMgKGxpc3Qg bmN1cnNlcykpCisgICAgKG91dHB1dHMgKGxpc3QgIm91dCIgImRlYnVnIikpCisgICAgKHN5bm9w c2lzICJUaGVtYXRpYyBtZWRpdGF0aXZlIGdhbWUgZm9yIHRlcm1pbmFscyIpCisgICAgKGRlc2Ny aXB0aW9uCisgICAgICJQbGF5IGZvciBhIHJvYm90IGluIGEgcmVhbG0gYXBwZWFyaW5nIGFzIGEg cmVjdGFuZ2xlIGZpbGxlZCB3aXRoIEFTQ0lJCitjaGFyYWN0ZXJzLiAgTW92ZSB3aXRoIGRldGVy bWluYXRpb24gdG8gZmluZCB0aGUga2l0dGVuIHdoaWxlIGV4YW1pbmluZyB1c2VsZXNzCitpdGVt cyB3aXRoIG9mdGVuIGFtdXNpbmcgZGVzY3JpcHRpb25zIGFuZCB0aHVzIGV4cGVyaWVuY2UgdGhp cyBcIlplbgorc2ltdWxhdGlvbi5cIiAgVGhlIHRoZW1lIG9mIHRoZSBnYW1lIGNvbnRpbnVlcyBp biBpdHMgZG9jdW1lbnRhdGlvbi4gIFlvdSBjYW4KK2Fsc28gcmVwbGFjZSB0aGUgZGVzY3JpcHRp b25zIG9mIHRoZSBpdGVtcyB3aXRoIGEgY3VzdG9tIGZpbGUuIikKKyAgICAoaG9tZS1wYWdlICJo dHRwOi8vcm9ib3RmaW5kc2tpdHRlbi5vcmcvIikKKyAgICAobGljZW5zZSBsaWNlbnNlOmdwbDIr KSkpCisKIChkZWZpbmUtcHVibGljIHJvZ3VlYm94LWFkdmVudHVyZXMKICAgKHBhY2thZ2UKICAg ICAobmFtZSAicm9ndWVib3gtYWR2ZW50dXJlcyIpCgpiYXNlLWNvbW1pdDogN2RhOTA3ZjkwZTc0 YTRlZGY5NmQ3NmVlNDU3ZmY5NTgyNjVlZjhkNAotLSAKMi4zNS4xCgo= --=-R13fUJg9QExpzSXUpwn4-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 12 07:59:14 2022 Received: (at 54476) by debbugs.gnu.org; 12 Apr 2022 11:59:14 +0000 Received: from localhost ([127.0.0.1]:47825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1neFAt-0006tg-FM for submit@debbugs.gnu.org; Tue, 12 Apr 2022 07:59:14 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:47208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1neFAr-0006tX-07 for 54476@debbugs.gnu.org; Tue, 12 Apr 2022 07:59:09 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by xavier.telenet-ops.be with bizsmtp id Hnz62700N4UW6Th01nz7SQ; Tue, 12 Apr 2022 13:59:07 +0200 Message-ID: <4ae286e98001423fe90480d0cb19b1b66c1c10d6.camel@telenet.be> Subject: Re: [bug#54476] [PATCH] gnu: games: Add robotfindskitten. From: Maxime Devos To: Roman Riabenko , 54476@debbugs.gnu.org Date: Tue, 12 Apr 2022 13:59:01 +0200 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-RXReFZNtUwSfpgFAEEuk" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1649764747; bh=fjN8KVaqiVOj3YVtgFJ/sxbh8N8FlWCnBqBG+YLBaN0=; h=Subject:From:To:Date:In-Reply-To:References; b=Vv7aO7uJIXmgvu014LBRe/uHpl1kHeJ2IvJ3HstbcTIXv3sNqzyAnLYzXoDXT4T5U Wf96uCQx73t4RXbdjTIEqGhcNiZN3WjDF8WfGjtnIW/3FtiHIZGHLwkX1cLG7rarS9 RRwCYoxBb0o+dM5l3byhwL72JhAo/tLMGEJVwF6JyctTIazBrKdrnBk4PF8eNSschh M811czuC/AYSnwdKzEQXCVBixA/OYbzZVgXnR4EOyI6/F8pmAyXc2c6wf/35hbicT0 ja7C2bjE5M636luIwjtjger08dFz7QMHA8SaU0lXvUMkXSIZ6lV3fSllhcFa3+i715 CfaxNuXgcMdjA== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54476 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-RXReFZNtUwSfpgFAEEuk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Roman Riabenko schreef op zo 20-03-2022 om 16:28 [+0200]: > +(define-public robotfindskitten > +=C2=A0 (package > +=C2=A0=C2=A0=C2=A0 (name "robotfindskitten") > +=C2=A0=C2=A0=C2=A0 ;; Despite what guix lint says, version 2.8284271.702= is newer > then > +=C2=A0=C2=A0=C2=A0 ;; 1600003_201b. See ChangeLog for version history. > +=C2=A0=C2=A0=C2=A0 (version "2.8284271.702") You can try teaching "guix lint" (actually, (guix import git)) to recognise the 2.8284271.702 as newest version. Possibly adding (properties '((release-tag-version-delimiter . "."))) like done for the 'upower' package is sufficient. Greetings, Maxime. --=-RXReFZNtUwSfpgFAEEuk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYlVphRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7kCXAQCwRKpreXY+Eb2wY5Jng7U8iSyR IRLsmQD85PGK8qTXPAD/ZKNUN3CY395oXOHAkXveQS/zFMvPmBwSWsI6SuF6CQM= =fgyB -----END PGP SIGNATURE----- --=-RXReFZNtUwSfpgFAEEuk-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 12 14:43:44 2022 Received: (at 54476-done) by debbugs.gnu.org; 12 Apr 2022 18:43:44 +0000 Received: from localhost ([127.0.0.1]:49904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1neLUN-0006pj-RE for submit@debbugs.gnu.org; Tue, 12 Apr 2022 14:43:43 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:45665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1neLUM-0006pV-FX for 54476-done@debbugs.gnu.org; Tue, 12 Apr 2022 14:43:42 -0400 Received: by mail-ed1-f66.google.com with SMTP id v15so13389558edb.12 for <54476-done@debbugs.gnu.org>; Tue, 12 Apr 2022 11:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=VStI8NyTHYHQWQpKNlnfMhdI/EQqxW9fLcQVzIA3TM8=; b=Pul1poETG/bCdYUnXDlEf/zH04aMEa0nJm5y/+i/9tSNSHKBW6gFaMUAPVNZhOIjRa pbReXX27jGw6S+vYYfXQYGs6Zm4DrN+nezgXMRqrr/0WaY6mTR5Mqn9i+p/ZaNFKmsdT HhMVb4ENVzQtBrw6pWC2rgdohXFO6GLgMns6vkdU7BN5fsy9a8eITcRJKtsCzomco627 ZtLK/m8tfFtJu4i5vm3JrSF3YNWZar59gFRiIesJCnnE4yN9qhsVcbCrH/Cjo186zCB5 2IvcBBgbx0Owhu9unGDDspxRb9qMDzmcoSEHsfzGXuPEWStl+ARtCdNuWh1zFCkBxo5Z RARA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=VStI8NyTHYHQWQpKNlnfMhdI/EQqxW9fLcQVzIA3TM8=; b=zMJ+YBydfSaZFOxRpFrr0R1oI+CbEWNPevVVBGJcCBKlYR3wPXYFZbAlT3QzGwOyKf hj8O0sYVLvlFv6ncY1swtoSJz++QXytB+ebNbOV0V6GeE9X3J4d7q0AKCAByv0Odzm4s TKDVjYSk1Wkr3RKaPc7SMymLzJRBBM9qYqMe8vjVI7TajuJijB8WE9IKk8eQU+OL91Pi Jx4wzCoWsU0s5m6YO1OdzLirX2ddX4Xhp4M/WVVp3LLVlw9BpH4JFVatSWQAbXxdK/RX kAIy2YSk1OU8IDjVwFWQfoj0MYFsqdz4GbtnjXbclx4u21CLTw+Yd8p9qjussdcSCASB Dzog== X-Gm-Message-State: AOAM533ytf5nGTccW1RMJwnvsuekSiZQSuOGCBD21aw64D/8YSpByIxo BUJ1XBfS2xzRQB+Uow7OuMU= X-Google-Smtp-Source: ABdhPJxE5WWpiM1FgMK/41QwVqcFuKGsqu4vpOw1DmzJ7obQCQExB9QCtezR4e2X0MPC/S2Vn4e9ow== X-Received: by 2002:a05:6402:2788:b0:41b:c871:715b with SMTP id b8-20020a056402278800b0041bc871715bmr40344527ede.53.1649789016395; Tue, 12 Apr 2022 11:43:36 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id ce21-20020a170906b25500b006e89869cbf9sm2393180ejb.105.2022.04.12.11.43.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 11:43:36 -0700 (PDT) Message-ID: <0883d1920d6dc54e2c5b8e563e17767cd6f61bc9.camel@gmail.com> Subject: Re: [PATCH] gnu: games: Add robotfindskitten. From: Liliana Marie Prikler To: Roman Riabenko , 54476-done@debbugs.gnu.org Date: Tue, 12 Apr 2022 20:43:34 +0200 In-Reply-To: References: <0eac7e2692804e6668a0246f79c0e88c495b336e.camel@riabenko.com> <8a0d6013e738fe0ea9fb7808aae2d1e7bc014669.camel@riabenko.com> <38b2054628730328b7bd2544597a7db9c0431acb.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54476-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Montag, dem 11.04.2022 um 13:34 +0300 schrieb Roman Riabenko: > Hi Liliana > > I attach a replacement patch that should address all concerns. Pushed with some slight adjustments, thanks! From unknown Sun Aug 17 09:10:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 11 May 2022 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator