GNU bug report logs - #54476
[PATCH] gnu: games: Add robotfindskitten.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54476 in the body.
You can then email your comments to 54476 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roman Riabenko <roman <at> riabenko.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: games: Add robotfindskitten.
Date: Sun, 20 Mar 2022 16:28:49 +0200

[Message part 1 (text/plain, inline)]

This patch adds robotfindskitten.

Roman

[0001-gnu-games-Add-robotfindskitten.patch (text/x-patch, attachment)]

Message #8 received at 54476 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Roman Riabenko <roman <at> riabenko.com>, 54476 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: games: Add robotfindskitten.
Date: Mon, 21 Mar 2022 07:59:45 +0100

Hi Roman,

Am Sonntag, dem 20.03.2022 um 16:28 +0200 schrieb Roman Riabenko:

> +    ;; Despite what guix lint says, version 2.8284271.702 is newer
> then
> +    ;; 1600003_201b. See ChangeLog for version history.
> +    (version "2.8284271.702")
> +    ;; The git version is the same as in the release tarball, but it
> bundles
> +    ;; convenient .desktop files, which were requested for Debian.
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url
> +                    
> "https://github.com/robotfindskitten/robotfindskitten")
> +                    (commit
> "1cae36621f9c19d19a40eacf63789913d4ef5d5c")))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +               
> "0ps3xrl1yh0h7jhl3bwhx5xw2hvhzync03y08i66rzw098r530qq"))))
Looking at the git repository, those are *not* the same.  Use git-
version or use the tag as commit, but don't mix conventions.
> +                  (replace 'bootstrap
> +                    (lambda _
> +                      (invoke "autoreconf" "-ifv"))) ;per README.md
The existing bootstrap should already correctly invoke autoreconf if no
bootstrap script exists.
> +                  (add-after 'unpack 'fix-install-path
> +                    (lambda _
> +                      ;; It is configured to install executable to
> /games or
> +                      ;; /usr/local/games per Filesystem Hierarchy
> Standard.
> +                      ;; We change that to get it in $PATH.
> +                      (substitute* "src/Makefile.am"
> +                        (("\\$\\(prefix\\)/games") "$(prefix)/bin"))
We could change this by using #:make-flags instead, I believe.
> +                      ;; When built with guix, all characters are
> displayed in
> +                      ;; the background colour pair. If it is not
> set manually,
> +                      ;; this is not happening, so we get back
> colour into the
> +                      ;; game. The background is redrawn anyway. See
> man bkgd.
> +                      (substitute* "src/robotfindskitten.c"
> +                        (("\\(void\\) bkgd \\( \\(chtype\\)
> COLOR_PAIR\\(WHITE\\) \\);")
> +                         "")))))
This should probably go into a "patch-source" phase.

> +    (synopsis "Zen Simulation of robot finding kitten")
> +    (description
> +     "In this simulation, you play the part of robot.  Your task is
> to
> +complete the simulation by finding kitten, as is your destiny, and
> indeed your
> +wont.  You (robot) are represented by the # character, and you move
> around with
> +the arrow keys touching things.  If the thing you touch is kitten,
> you get a
> +cute little animation (which was cuter in the DOS version) and the
> simulation
> +ends.  Otherwise, you get a brief description of what it is you
> touched.")
Both synopsis and description could use some love.  Plain copypasta
with grammatical errors is not good optics.

Cheers

Message #11 received at 54476 <at> debbugs.gnu.org (full text, mbox):

From: Roman Riabenko <roman <at> riabenko.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 54476 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: games: Add robotfindskitten.
Date: Thu, 24 Mar 2022 17:38:12 +0200

[Message part 1 (text/plain, inline)]

Hi Liliana

(Copying the mailing list.)

Thank you for helping to improve this!

У пн, 2022-03-21 у 07:59 +0100, Liliana Marie Prikler пише:
> Hi Roman,
> 
> Am Sonntag, dem 20.03.2022 um 16:28 +0200 schrieb Roman Riabenko:
> 
> > +    ;; Despite what guix lint says, version 2.8284271.702 is newer
> > then
> > +    ;; 1600003_201b. See ChangeLog for version history.
> > +    (version "2.8284271.702")
> > +    ;; The git version is the same as in the release tarball, but
> > it
> > bundles
> > +    ;; convenient .desktop files, which were requested for Debian.
> > +    (source (origin
> > +              (method git-fetch)
> > +              (uri (git-reference
> > +                    (url
> > +                    
> > "https://github.com/robotfindskitten/robotfindskitten")
> > +                    (commit
> > "1cae36621f9c19d19a40eacf63789913d4ef5d5c")))
> > +              (file-name (git-file-name name version))
> > +              (sha256
> > +               (base32
> > +               
> > "0ps3xrl1yh0h7jhl3bwhx5xw2hvhzync03y08i66rzw098r530qq"))))
> Looking at the git repository, those are *not* the same.  Use git-
> version or use the tag as commit, but don't mix conventions.

I thought the commit log is misleading. Before submitting the patch, I
checked the code and data files, but now that I checked documentation
too, I see that the release, including packages in Debian and Fedora,
do not have the latest fixes to documentation.

It bugged me as cruel towards users to package the release version with
wrong documentation, but, at a more thorough inspection, the
inconsistency in documentation can be figured out after all. If the
authors and maintainers did not deem it worth a release, I do not feel
confident to. After all, I cannot rule out that, theoretically, someone
may even rely on "man robotfindskitten" output for something.

The checkout of the git tag which corresponds to the release version
number is, strictly speaking, somewhat different from the release
tarball. Among other things, it has "contrib" directory with PalmOS
port code. Debian also has the same tarball for original source.
Considering all that, I'd rather go with the tarball than git.

> > +                  (replace 'bootstrap
> > +                    (lambda _
> > +                      (invoke "autoreconf" "-ifv"))) ;per
> > README.md
> The existing bootstrap should already correctly invoke autoreconf if
> no
> bootstrap script exists.

I recall having some issue without this modification, but I cannot
reproduce it now. Removing.

> > +                  (add-after 'unpack 'fix-install-path
> > +                    (lambda _
> > +                      ;; It is configured to install executable to
> > /games or
> > +                      ;; /usr/local/games per Filesystem Hierarchy
> > Standard.
> > +                      ;; We change that to get it in $PATH.
> > +                      (substitute* "src/Makefile.am"
> > +                        (("\\$\\(prefix\\)/games")
> > "$(prefix)/bin"))
> We could change this by using #:make-flags instead, I believe.

Thank you for the hint. I didn't expect it to be that simple.

> > +                      ;; When built with guix, all characters are
> > displayed in
> > +                      ;; the background colour pair. If it is not
> > set manually,
> > +                      ;; this is not happening, so we get back
> > colour into the
> > +                      ;; game. The background is redrawn anyway.
> > See
> > man bkgd.
> > +                      (substitute* "src/robotfindskitten.c"
> > +                        (("\\(void\\) bkgd \\( \\(chtype\\)
> > COLOR_PAIR\\(WHITE\\) \\);")
> > +                         "")))))
> This should probably go into a "patch-source" phase.

I moved this part to a source origin snippet.

> > +    (synopsis "Zen Simulation of robot finding kitten")
> > +    (description
> > +     "In this simulation, you play the part of robot.  Your task
> > is
> > to
> > +complete the simulation by finding kitten, as is your destiny, and
> > indeed your
> > +wont.  You (robot) are represented by the # character, and you
> > move
> > around with
> > +the arrow keys touching things.  If the thing you touch is kitten,
> > you get a
> > +cute little animation (which was cuter in the DOS version) and the
> > simulation
> > +ends.  Otherwise, you get a brief description of what it is you
> > touched.")
> Both synopsis and description could use some love.  Plain copypasta
> with grammatical errors is not good optics.

My first impression was that it needs some improvement. But I was
quickly discouraged and here is why.

The problem I have with it is that it apparently attempts to pretend to
be something more, not even a game at all, but the Zen Simulation. The
authors invite the audience to a make-believe and this starts with the
synopsis and description and continues in the game and in its
documentation. The story begins with such synopsis and description in
other distributions and package managers too. I really feel as
intruding into the game against the authors intentions by attempting to
modify those.

As to the grammar and spelling, I am embarrassed of my ignorance and
fond of learning something new, which is one of the reasons that I like
this game. When I saw the word "wont", I couldn't imagine that it is a
valid English word, until I verified it with a dictionary. The words
"robot" and "kitten" are consistently used without an article
(including in-game texts and documentation) treating them specially as
characters of the story. The same goes for both words of "Zen
Simulation" being capitalised.

So I leave it as is for now.

I attach a different patch as my new offer.

Roman

[0001-gnu-games-Add-robotfindskitten.patch (text/x-patch, attachment)]

Message #14 received at 54476 <at> debbugs.gnu.org (full text, mbox):

From: Roman Riabenko <roman <at> riabenko.com>
To: 54476 <at> debbugs.gnu.org
Cc: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [PATCH] gnu: games: Add robotfindskitten.
Date: Mon, 28 Mar 2022 16:56:10 +0300

[Message part 1 (text/plain, inline)]

Hello

I thought that I was working around a local implementation of ncurses,
but now I am convinced that there is a local bug, which I filed a
report against. See issue 54607. [1]

[1]: https://issues.guix.gnu.org/54607

Assuming that the bug will be fixed, there is no need for the snippet
which I proposed in previous patches. I attach a new patch to add
robotfindskitten, which is my offer in place of previous patches.

Meanwhile, even with that bug not being fixed, robotfindskitten is
still playable. It is just monochrome, which is a mode natively
supported by the game design.

Roman

[0001-gnu-games-Add-robotfindskitten.patch (text/x-patch, attachment)]

Message #17 received at 54476 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Roman Riabenko <roman <at> riabenko.com>, 54476 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: games: Add robotfindskitten.
Date: Mon, 28 Mar 2022 20:34:41 +0200

Am Montag, dem 28.03.2022 um 16:56 +0300 schrieb Roman Riabenko:
> Hello
> 
> I thought that I was working around a local implementation of
> ncurses, but now I am convinced that there is a local bug, which I
> filed a report against. See issue 54607. [1]
> 
> [1]: https://issues.guix.gnu.org/54607
> 
> Assuming that the bug will be fixed, there is no need for the snippet
> which I proposed in previous patches. I attach a new patch to add
> robotfindskitten, which is my offer in place of previous patches.
For the record, you are still allowed to patch the source in a snippet
or build phase, but you should add a comment referring to this bug when
doing so.

> Meanwhile, even with that bug not being fixed, robotfindskitten is
> still playable. It is just monochrome, which is a mode natively
> supported by the game design.
Is that purely an aesthetic choice or are there other things to
consider w.r.t. your previous phase?  If "monochrome" means black on
white or vice versa and the game only needs those colors, then sure,
waiting for ncurses to be fixed might be the wiser option.

> +              (uri (string-append "https://github.com/"
> +                                  name
> +                                  "/"
> +                                  name
> +                                  "/releases/download/"
> +                                  version
> +                                  "/"
> +                                  name
> +                                  "-"
> +                                  version
> +                                  ".tar.gz"))
Guix style does not always result in the best possible indentation and
is to be taken with a grain of salt.

> +    (synopsis "Zen Simulation of robot finding kitten")
> +    (description
> +     "In this simulation, you play the part of robot.  Your task is
> to
> +complete the simulation by finding kitten, as is your destiny, and
> indeed your
> +wont.  You (robot) are represented by the # character, and you move
> around with
> +the arrow keys touching things.  If the thing you touch is kitten,
> you get a
> +cute little animation (which was cuter in the DOS version) and the
> simulation
> +ends.  Otherwise, you get a brief description of what it is you
> touched.")
Again, this synopsis and description need some love (grammatically
speaking), but it should also cut down on advertisements for
proprietary systems.

Cheers

Message #20 received at 54476 <at> debbugs.gnu.org (full text, mbox):

From: Roman Riabenko <roman <at> riabenko.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 54476 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: games: Add robotfindskitten.
Date: Mon, 11 Apr 2022 13:34:39 +0300

[Message part 1 (text/plain, inline)]

Hi Liliana

I attach a replacement patch that should address all concerns.

Roman

[0001-gnu-games-Add-robotfindskitten.patch (text/x-patch, attachment)]

Message #23 received at 54476 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Roman Riabenko <roman <at> riabenko.com>, 54476 <at> debbugs.gnu.org
Subject: Re: [bug#54476] [PATCH] gnu: games: Add robotfindskitten.
Date: Tue, 12 Apr 2022 13:59:01 +0200

[Message part 1 (text/plain, inline)]

Roman Riabenko schreef op zo 20-03-2022 om 16:28 [+0200]:
> +(define-public robotfindskitten
> +  (package
> +    (name "robotfindskitten")
> +    ;; Despite what guix lint says, version 2.8284271.702 is newer
> then
> +    ;; 1600003_201b. See ChangeLog for version history.
> +    (version "2.8284271.702")

You can try teaching "guix lint" (actually, (guix import git)) to
recognise the 2.8284271.702 as newest version.  Possibly adding

  (properties '((release-tag-version-delimiter . ".")))

like done for the 'upower' package is sufficient.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 54476-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Roman Riabenko <roman <at> riabenko.com>, 54476-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: games: Add robotfindskitten.
Date: Tue, 12 Apr 2022 20:43:34 +0200

Am Montag, dem 11.04.2022 um 13:34 +0300 schrieb Roman Riabenko:
> Hi Liliana
> 
> I attach a replacement patch that should address all concerns.
Pushed with some slight adjustments, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.