From unknown Wed Jun 18 00:25:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54473: 28.0.91; [PATCH] Eldoc: Handle invisible text when truncating strings Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Mar 2022 12:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 54473 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 54473@debbugs.gnu.org Cc: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , andreyk.mad@gmail.com X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.164777803221716 (code B ref -1); Sun, 20 Mar 2022 12:08:02 +0000 Received: (at submit) by debbugs.gnu.org; 20 Mar 2022 12:07:12 +0000 Received: from localhost ([127.0.0.1]:33038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVuL1-0005eB-PI for submit@debbugs.gnu.org; Sun, 20 Mar 2022 08:07:12 -0400 Received: from lists.gnu.org ([209.51.188.17]:57428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVuKz-0005e2-Ny for submit@debbugs.gnu.org; Sun, 20 Mar 2022 08:07:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVuKw-0000gj-BY for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2022 08:07:08 -0400 Received: from [2a00:1450:4864:20::634] (port=37641 helo=mail-ej1-x634.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVuKq-0002xt-UN for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2022 08:07:02 -0400 Received: by mail-ej1-x634.google.com with SMTP id bg10so25008813ejb.4 for ; Sun, 20 Mar 2022 05:06:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:user-agent:mime-version; bh=pnwz0tNPXmH4jtQdC1lTLmPj7YI/i3ShpdU7pZkU22Y=; b=Y2Uphet9RDnTMKLMNsJEVatpOn1Or+5yQWrumljpW2GTczdBm4B4+ztEdFiIfGWP7+ knja+NSQ2OJvwkXWMYD7xj1SvVSMchumFWiqBvfpq6fi+FunTakq2+VD4yhqryItRsO2 Sc5a/lYgH7T4hWvv8TrU5X0M5rkPo52/moVbXHhrYJ0bReP8bHyoKBcjz6L5xqsxgweU iWWAUlHLwNU/85miuEzzI2is4calGWIUyDDJnYqrfyHSBLFe6zO6rJEL0kiai/AXOoQL Nrhmpehw/n7aIgjzJsQRxFWvAd52vfYSJwpFKB4/LGmcj5DWUbLJ2WojPsieikA0+z2J iWsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :mime-version; bh=pnwz0tNPXmH4jtQdC1lTLmPj7YI/i3ShpdU7pZkU22Y=; b=6Vtu/mZ872XW3dnAAR4MH6BYzRwrGRg4cy3CESrGLML75TMmkfo5UaZ6iR/2+lxShs yyL6ojNcX62jNGGtSwGiLcI/6EgD5cssRdMIq1m+3hdXQrED3rluoCD1g7FDjsBh1fsC Zq7vui69HvDBs3hUSFzxSTxBT+ZemLaUgIus+2EAhWFsbMWilIjL800jJy4htzFbqDqx x1lM4yoR0tjSWG8C/huZUUxtczA5SPV9P4/UmZ6d6Wa+jnSpB2bJxPD1XBjLBIZPwJmL J/PtDmw/ZkzU6LUNidItg73q9e4/Y2fRkiDxcxheyyfiB8Nl2PNOoSNrQx67Y++ZRsai soJg== X-Gm-Message-State: AOAM531fNwqeZ2XgnmWvJIBq9TFhhiiMAMVmNKZauguxn5X56u301g8P /oYaTu9I6yZgrTw/rmbVgnU= X-Google-Smtp-Source: ABdhPJxIk2ldIF3mfjk4dN/Ddmhef/aTL5+dUPXHlxsk3mPNMQ36ziiz6FXQz3lFUhRHLBK+HrLcRg== X-Received: by 2002:a17:906:168f:b0:6df:b4ed:7c49 with SMTP id s15-20020a170906168f00b006dfb4ed7c49mr10688872ejd.36.1647778018119; Sun, 20 Mar 2022 05:06:58 -0700 (PDT) Received: from ars3 ([2a02:8109:8ac0:56d0::758e]) by smtp.gmail.com with ESMTPSA id o14-20020a170906774e00b006d5b915f27dsm5746413ejn.169.2022.03.20.05.06.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 05:06:57 -0700 (PDT) From: Augusto Stoffel Date: Sun, 20 Mar 2022 13:06:56 +0100 Message-ID: <87o8203k0v.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::634 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::634; envelope-from=arstoffel@gmail.com; helo=mail-ej1-x634.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain This should solve the Eglot-related problem described in this Github comment: https://github.com/joaotavora/eglot/issues/865#issuecomment-1065565845 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Eldoc-Handle-invisible-text-when-truncating-strings.patch >From c52b891b4197ee5cf9cec39993117487b0b4015f Mon Sep 17 00:00:00 2001 From: Augusto Stoffel Date: Sun, 20 Mar 2022 12:59:14 +0100 Subject: [PATCH] Eldoc: Handle invisible text when truncating strings * lisp/emacs-lisp/eldoc.el (eldoc--echo-area-substring, eldoc-display-in-echo-area): Take invisible text into consideration when counting lines to crop an echo-area message. --- lisp/emacs-lisp/eldoc.el | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/lisp/emacs-lisp/eldoc.el b/lisp/emacs-lisp/eldoc.el index 73713a3dec..16c08e1e10 100644 --- a/lisp/emacs-lisp/eldoc.el +++ b/lisp/emacs-lisp/eldoc.el @@ -102,7 +102,7 @@ eldoc-echo-area-use-multiline-p directly, while a float specifies the number of lines as a proportion of the echo area frame's height. -If value is the symbol `truncate-sym-name-if-fit' t, the part of +If value is the symbol `truncate-sym-name-if-fit', the part of the doc string that represents a symbol's name may be truncated if it will enable the rest of the doc string to fit on a single line, without resizing the echo area. @@ -525,7 +525,8 @@ eldoc--echo-area-substring (goto-char (point-min)) (skip-chars-forward " \t\n") (point)) - (goto-char (line-end-position available)) + (forward-visible-line (1- available)) + (end-of-visible-line) (skip-chars-backward " \t\n"))) (truncated (save-excursion (skip-chars-forward " \t\n") @@ -535,7 +536,8 @@ eldoc--echo-area-substring ((and truncated (> available 1) eldoc-echo-area-display-truncation-message) - (goto-char (line-end-position 0)) + (forward-visible-line -1) + (end-of-visible-line) (concat (buffer-substring start (point)) (format "\n(Documentation truncated. Use `%s' to see rest)" @@ -610,7 +612,8 @@ eldoc-display-in-echo-area (let ((string (with-current-buffer (eldoc--format-doc-buffer docs) (buffer-substring (goto-char (point-min)) - (line-end-position 1))))) + (progn (end-of-visible-line) + (point)))))) (if (> (length string) width) ; truncation to happen (unless (eldoc--echo-area-prefer-doc-buffer-p t) (truncate-string-to-width string width)) -- 2.35.1 --=-=-=-- From unknown Wed Jun 18 00:25:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54473: 28.0.91; [PATCH] Eldoc: Handle invisible text when truncating strings Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Mar 2022 13:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54473 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Augusto Stoffel Cc: 54473@debbugs.gnu.org, andreyk.mad@gmail.com X-Debbugs-Original-Cc: "simon254--- via Bug reports for GNU Emacs, the Swiss army knife of text editors" , Andrii Kolomoiets Received: via spool by submit@debbugs.gnu.org id=B.164778180727803 (code B ref -1); Sun, 20 Mar 2022 13:11:02 +0000 Received: (at submit) by debbugs.gnu.org; 20 Mar 2022 13:10:07 +0000 Received: from localhost ([127.0.0.1]:33174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVvJv-0007EN-Fi for submit@debbugs.gnu.org; Sun, 20 Mar 2022 09:10:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:44018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVvJu-0007EG-EU for submit@debbugs.gnu.org; Sun, 20 Mar 2022 09:10:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVvJu-0005Ze-AR for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2022 09:10:06 -0400 Received: from [2607:f8b0:4864:20::236] (port=41560 helo=mail-oi1-x236.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVvJs-0006CY-Fs for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2022 09:10:05 -0400 Received: by mail-oi1-x236.google.com with SMTP id ay7so13740145oib.8 for ; Sun, 20 Mar 2022 06:10:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=55RjGWC7zuMbMnZ46Qa/wlQN92hyUs8Kg5zVUIpC5Jw=; b=ngYnZlCMyh751qpq2pgWoo7WWzMfdIjQ3D1S7yktJfUJqTCJ9SEX3IV07f0W2Sx7a5 M45sk9rWbyorZoAHZQD4uhHr8IvFI4vErISI8K6M8jYuq53IwwdcXVfRwLUJe8sDVLqD +K8ZUKMuXAEQ2TAjIUpUqaaMOXGMMiJ8d8++XLdUKYaK+R8oaMAZiaFuY8ag0QnjBzAS WYLr99frwG+MkPgV2wu7dxgaj62NHjdg61YsbnHUm/owI1994/yp9v48gS4kfEj1tyjh xaW/04D5kVV9IXpNZ4fVMp1Jif/IFT2X6R/tqj1XX0BVim2hJMsz5nTgHaOKuYZ0376x 7GkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=55RjGWC7zuMbMnZ46Qa/wlQN92hyUs8Kg5zVUIpC5Jw=; b=ynRAj/NKazwoM1MZiA3SaQSg4/oJlwMC2LjNo+zIU9xscdqa8Q5Y/6Bve2cm9EcNl2 UwGbyB0W95kkzUZvvfM9wSp12BTeh+K/HrzE2vgmuRRe/PRcbRKSS/oNVnAOXc2cejEw LgvI0Ag95tbgWGu1178KozKQl9Biapu0WTDFtwfFHDJ6iTPJdYYu6gAtoxqVNfZZRrXb cL+4ck3RXZDNuhqoY07sspU4j819rR9QVLbzlKz4pB1zk7aViW1KePl1H1WrrLeQFsGB T2dCRTrhRD8v65N3fXAqs4rQjz14yTy66IwAS47rLFmI+TaYRYG1z2Wq496q8UvKFI3p xxow== X-Gm-Message-State: AOAM531hhYL+xMp1F+GTXQjyxgJqRJcxmOoSjq+IJI152U4xc/hPlsZ8 X6ccFQvd6bHbbCYjY5LicgR6vXaGsqQBuqi0uYU= X-Google-Smtp-Source: ABdhPJy7QOgqZLvNS2z+sN08y/NG4oR3hBREuh3TxOXxodvztcd+Z2CFSoPw2J1H7jAGWAwQVi8G58QgwCsTvCOOBqQ= X-Received: by 2002:aca:2b0d:0:b0:2d9:dc99:3898 with SMTP id i13-20020aca2b0d000000b002d9dc993898mr11324576oik.209.1647781803131; Sun, 20 Mar 2022 06:10:03 -0700 (PDT) MIME-Version: 1.0 References: <87o8203k0v.fsf@gmail.com> In-Reply-To: <87o8203k0v.fsf@gmail.com> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Sun, 20 Mar 2022 13:10:54 +0000 Message-ID: Content-Type: multipart/alternative; boundary="0000000000000b052105daa6198d" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::236 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::236; envelope-from=joaotavora@gmail.com; helo=mail-oi1-x236.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --0000000000000b052105daa6198d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Looks fine, but would need, I think, a decent amount of testing: * In eglot.el, being validated by both Andrii and you for your particular use cases. * In bare emacs-lisp-mode, with multiple eldoc-documentation-strategy options. It should behave exactly the same before and after the patch, as elisp doesn't use invisible stuff. * In other situations you can think of. Like variations on eldoc-area-use-multiline-p and eldoc-echo-area-display-truncation-messages. Again, here the behaviour should be equivalent pre- and post- patch. Just noting this because in my memory this code is somewhat hairy. That said, the patch "looks" really fine :-) Thanks, Jo=C3=A3o On Sun, Mar 20, 2022 at 12:06 PM Augusto Stoffel wrote: > This should solve the Eglot-related problem described in this Github > comment: > > https://github.com/joaotavora/eglot/issues/865#issuecomment-1065565845 > > --=20 Jo=C3=A3o T=C3=A1vora --0000000000000b052105daa6198d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Looks fine, but would need, I think, a decent amount = of testing:

* In eglot.el, being validated by both= Andrii and you for your particular use cases.
* In bare emac= s-lisp-mode, with multiple eldoc-documentation-strategy options.=C2=A0 It s= hould
=C2=A0 behave exactly the same before and after the pa= tch, as elisp doesn't use invisible stuff.
* In other sit= uations you can think of.=C2=A0 Like variations on eldoc-area-use-multiline= -p and
=C2=A0 eldoc-echo-area-display-truncation-messages.= =C2=A0 Again, here the behaviour should be
=C2=A0 equivalent pre-= and post- patch.

Just noting this because in my m= emory this code is somewhat hairy.=C2=A0 That
said, the patc= h "looks" really fine :-)

Thanks,
Jo=C3=A3o

On Sun, Mar 20, 2022 at 12:06 PM Augusto Sto= ffel <arstoffel@gmail.com>= wrote:
This sho= uld solve the Eglot-related problem described in this Github comment:

https://github.com/joaotavora/= eglot/issues/865#issuecomment-1065565845



--
Jo=C3=A3o T=C3=A1vora
--0000000000000b052105daa6198d-- From unknown Wed Jun 18 00:25:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54473: 28.0.91; [PATCH] Eldoc: Handle invisible text when truncating strings Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Mar 2022 13:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54473 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Augusto Stoffel Cc: 54473@debbugs.gnu.org, joaotavora@gmail.com, andreyk.mad@gmail.com Received: via spool by 54473-submit@debbugs.gnu.org id=B54473.164778437832372 (code B ref 54473); Sun, 20 Mar 2022 13:53:01 +0000 Received: (at 54473) by debbugs.gnu.org; 20 Mar 2022 13:52:58 +0000 Received: from localhost ([127.0.0.1]:33275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVvzO-0008Q3-BH for submit@debbugs.gnu.org; Sun, 20 Mar 2022 09:52:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVvzN-0008Ps-5c for 54473@debbugs.gnu.org; Sun, 20 Mar 2022 09:52:57 -0400 Received: from [2001:470:142:3::e] (port=53414 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVvzH-0002aL-SQ; Sun, 20 Mar 2022 09:52:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=HW/GScaYyleN4LW9fSbLtMR1iwX8vsVYvLjFs0hdO+g=; b=QDu0OBMTK3jfUchBO1Bc O7DaWJT+/DSTKu6Wr9dFkV2V1Q/NbMnHknE6W38jj8CoZH8deqPPWdfQDo4IYz8XyKGqEltvDnAL4 uWPjV59nH52snCwwI7LoktGpMBrY9BfZXMbXXvKcBgjRiTmRIdweQS0/CrxHSOSj6RCQ0n8lLZaAB 6nWvj9a78EedSpn6XpCQ9vDiRHu1kHP6f0J6ZLD/BLEeX2xqklpaahs0MDjpnczJIzArt5sc6Af+S NWEe8ie/WxKQJStR11m4gsBVN9iFz1GIS3PvaP1reJA98Lzr4rNmI0PVrFQiH3pUPQZzCmzsx05EQ aQFyfOc1yzBaxw==; Received: from [87.69.77.57] (port=4223 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVvzH-0001HU-BX; Sun, 20 Mar 2022 09:52:51 -0400 Date: Sun, 20 Mar 2022 15:52:32 +0200 Message-Id: <838rt4g28v.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87o8203k0v.fsf@gmail.com> (message from Augusto Stoffel on Sun, 20 Mar 2022 13:06:56 +0100) References: <87o8203k0v.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Augusto Stoffel > Date: Sun, 20 Mar 2022 13:06:56 +0100 > Cc: João Távora , > andreyk.mad@gmail.com > > This should solve the Eglot-related problem described in this Github comment: > > https://github.com/joaotavora/eglot/issues/865#issuecomment-1065565845 If this is proposed for the release branch, then can you tell more? The discussion to which you pointed seems to be caused by some recent change to Eglot that you installed several days ago, so how does it affect the current pretest of Emacs 28? I need to understand this to decide whether to consider the change for the release branch. Thanks. From unknown Wed Jun 18 00:25:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54473: 28.0.91; [PATCH] Eldoc: Handle invisible text when truncating strings Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Mar 2022 14:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54473 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 54473@debbugs.gnu.org, Augusto Stoffel , Andrii Kolomoiets Received: via spool by 54473-submit@debbugs.gnu.org id=B54473.16477849562542 (code B ref 54473); Sun, 20 Mar 2022 14:03:02 +0000 Received: (at 54473) by debbugs.gnu.org; 20 Mar 2022 14:02:36 +0000 Received: from localhost ([127.0.0.1]:34885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVw8h-0000ev-Og for submit@debbugs.gnu.org; Sun, 20 Mar 2022 10:02:36 -0400 Received: from mail-ot1-f45.google.com ([209.85.210.45]:37738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVw8f-0000ej-QK for 54473@debbugs.gnu.org; Sun, 20 Mar 2022 10:02:34 -0400 Received: by mail-ot1-f45.google.com with SMTP id k25-20020a056830151900b005b25d8588dbso8932486otp.4 for <54473@debbugs.gnu.org>; Sun, 20 Mar 2022 07:02:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RH1SMjG6f0VS9BdcnUlS1F6Gj6CEerq6EHdOT/ky58Y=; b=E4Oi/oNAQS90EAQ4gK6t0gnyV2fkSLu9bk7LDVYTNeIZ4STYGzL59d9w6A6AHgBrwQ 844SJFtMyoWOd/D5kz3k2njQBpc0pNW0gExGk0rovxAxusJ3ylHgouLt/Qesx57lx+Hb O+7dRjzdBm89RHvOMjPeu9pyBiufTuAfgYk3ePDPTDHac67egrqbqWnX6R0FalBi5NnA jeMNsdBmL23Om1n1oer1YlDLrggnvRFUtJ3ZPxCvYzkls8Ti5zuXq6GkByaiWDKXL1t5 /irEGg8dwoHEt3ghIvRNdjBjnywmlTJnZ0H5xfGehQo/a1K3GMtMap0OLAcCgZoRBAeO NjDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RH1SMjG6f0VS9BdcnUlS1F6Gj6CEerq6EHdOT/ky58Y=; b=uUj0uh9Vdq/yZBdVtXYJ4m1k8lHxw+DORQqMT9+hD6NqZS9Bn0S4A+QLZbZ5IneuVA X5UjMavVACUjOqi45RtLz/FEVSm0wGVakB9scfZfZKzi7h89iI9TP3syC7kKT3rY8UZ5 EO2Itenh+mXe5A8eFehzJI5OxZ7s8BTzAohCPwT+69F6+4akbBgcJQDMvIIJD6czrhon ExKXAU5Y2cKLK+LUyQGF8oeA4iDQRr8Z6bG8BOIqM+9ViZoiHiTflqT0QDKrZXHCQhbg OmOd+aS953Pveg8+KcgOSdbjZi0ty25zlgVzTGdKFmpuYIFsyRHPiz9OqtnCfUC58CPE ayFA== X-Gm-Message-State: AOAM530iJAodCOwmLzGINci293BgO7vsq6IyOe/ana1F5lNTjEIzcprW xqotEjjj9SjKFTpqGyjZTsXh6SxHFOqqnnGzTkU= X-Google-Smtp-Source: ABdhPJwK0fI0Lk+adb+KQoWbeQ9JChMhQwhcQQwjK5udaTTJjqztGI/fZP8WBCyK2JnZAWHv6O7Sn2NMWYsG2ewL1Dw= X-Received: by 2002:a05:6830:2714:b0:5c9:7a58:4325 with SMTP id j20-20020a056830271400b005c97a584325mr6099809otu.317.1647784948119; Sun, 20 Mar 2022 07:02:28 -0700 (PDT) MIME-Version: 1.0 References: <87o8203k0v.fsf@gmail.com> <838rt4g28v.fsf@gnu.org> In-Reply-To: <838rt4g28v.fsf@gnu.org> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Sun, 20 Mar 2022 14:03:16 +0000 Message-ID: Content-Type: multipart/alternative; boundary="0000000000007fbdaf05daa6d455" X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000007fbdaf05daa6d455 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Mar 20, 2022 at 1:52 PM Eli Zaretskii wrote: > > From: Augusto Stoffel > > Date: Sun, 20 Mar 2022 13:06:56 +0100 > > Cc: Jo=C3=A3o T=C3=A1vora , > > andreyk.mad@gmail.com > > > > This should solve the Eglot-related problem described in this Github > comment: > > > > https://github.com/joaotavora/eglot/issues/865#issuecomment-1065565845 > > If this is proposed for the release branch, then can you tell more? > The discussion to which you pointed seems to be caused by some recent > change to Eglot that you installed several days ago, so how does it > affect the current pretest of Emacs 28? > > I need to understand this to decide whether to consider the change for > the release branch. > Eglot, the Eldoc user, now simply doesn't strip _any_ properties from the text it sends Eldoc. I think is a conceptually correct change to Eglot. It's just that Eldoc just doesn't have a way to deal with that yet. If the patch is tested correctly, it is effectively fixing a bug in eldoc.el, whose current formatting/display code is oblivious to invisible text when calculating how much actual (read visual) free space it has in the echo area. And, presumably, this patch fixes that shortcoming. However, to err on the safe side, I'd say don't push it to the release branch. Eldoc is a "core ELPA package" so it can be distributed to the soon-to-be 28 release, by simply bumping the ELPA package version and then asking for users to update their packages. This is how bugs in flymake.el, eldoc.el, project.el have been fixed recently: no need to wait for an Emacs release. Maybe Augusto can fill in any details, if I haven't been clear. Jo=C3=A3o --0000000000007fbdaf05daa6d455 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Mar 20, 2022 at 1:52 PM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Augusto Stoffel <arstoffel@gmail.com>
> Date: Sun, 20 Mar 2022 13:06:56 +0100
> Cc: Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com>,
>=C2=A0 andre= yk.mad@gmail.com
>
> This should solve the Eglot-related problem described in this Github c= omment:
>
> https://github.com/joaota= vora/eglot/issues/865#issuecomment-1065565845

If this is proposed for the release branch, then can you tell more?
The discussion to which you pointed seems to be caused by some recent
change to Eglot that you installed several days ago, so how does it
affect the current pretest of Emacs 28?

I need to understand this to decide whether to consider the change for
the release branch.

Eglot, the Eld= oc user, now simply doesn't strip _any_ properties from the text
<= div>it sends Eldoc.=C2=A0 I think is a conceptually correct change to Eglot= . It's just that
Eldoc just doesn't have a way to deal wi= th that yet.

If the patch is tested correctly= , it is effectively fixing a bug in eldoc.el,
whose current forma= tting/display code is oblivious to invisible text when
calcu= lating how much actual (read visual) free space it has in the echo area.=C2= =A0
And, presumably, this patch fixes that shortcoming.

However, to err on the safe side, I'd = say don't push it to the release branch. Eldoc
is a "cor= e ELPA package" so it can be distributed to the soon-to-be 28 release,=
by simply bumping the ELPA package version and then asking for u= sers
to update their packages.=C2=A0 This is how bugs in flymake.= el, eldoc.el, project.el
have been fixed recently: no need to wai= t for an Emacs release.

Maybe Augus= to can fill in any details, if I haven't been clear.

Jo=C3=A3o
--0000000000007fbdaf05daa6d455-- From unknown Wed Jun 18 00:25:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54473: 28.0.91; [PATCH] Eldoc: Handle invisible text when truncating strings Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Mar 2022 14:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54473 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: Eli Zaretskii , 54473@debbugs.gnu.org, Andrii Kolomoiets Received: via spool by 54473-submit@debbugs.gnu.org id=B54473.16477869065558 (code B ref 54473); Sun, 20 Mar 2022 14:36:01 +0000 Received: (at 54473) by debbugs.gnu.org; 20 Mar 2022 14:35:06 +0000 Received: from localhost ([127.0.0.1]:34915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVwe9-0001Ra-Ug for submit@debbugs.gnu.org; Sun, 20 Mar 2022 10:35:06 -0400 Received: from mail-ej1-f53.google.com ([209.85.218.53]:40809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVwe8-0001R0-0I for 54473@debbugs.gnu.org; Sun, 20 Mar 2022 10:35:04 -0400 Received: by mail-ej1-f53.google.com with SMTP id p15so25373802ejc.7 for <54473@debbugs.gnu.org>; Sun, 20 Mar 2022 07:35:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=UCvxs/0s7raKNxRc9YleF6Ny8zCWiI8sJS3ZqG+4uxE=; b=J86w3rfgknLDUNAoV78RrWZEpQ85H4tQHNCnFoVqxQ5tZ8ayAihCaUino0pKBoBP9I yVbrWVDHAzDQXsoiXBpCopTooRtxalBpYp0n32fQMatOsMjIcS9b3pQlAg9hDTYFVqdV EnCRFNTfW6HUozT1GUgTHd4sgKOl7nvstvHoLkFKrd2wttbQl5xCSY+Yk1hAZ1kAspbZ 7VBaDXUdglPHdDeGR7j1kqxUEOVt+RqJjkYQZbJvULopdaZZNlaf7NnOxwORTpY5CZJf ZL+oeKyTEi1vV+oyy0Pi9d96VfWxnmZgJa53lsafAsmJv+GY2W1LG2RO4edE7kHbrdGA xj6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=UCvxs/0s7raKNxRc9YleF6Ny8zCWiI8sJS3ZqG+4uxE=; b=VpH9zI3QFof/vBN9XbOpSVvIIhKcszZuxOm6iWF284D+hwrDdDrr/dcipRrcdqxAJ6 Qzq4oxmhq41oiijF+5yDAFK8mCnKpNHHZkZxXOhNIqMT5gCwPd3oxeu8V2YS/J5su2rw UAtiSLMYT9v3dc9BCJvapIhJhn64fh5UmkW3CPJIFC7RfDvTyEa2J0tKdeb9fk+uBnRW fMavECgPFSjcPbMe1Izeoj5zlpmJSF86DrxIIfZCNffDlIkDUOJLPtfhwN7LlJnq3cwV 9I6wTXWqGlDZZZNtWpERgfVYJ8jaJIlT2wQckP21ozJ4U0bvvN1HzeJm48XfCBWGXeQA oXuw== X-Gm-Message-State: AOAM533JPnO4Xv1Dmd7EnwhjS/w6vOyMhYJwexWB1Z1OokcBaywF8zZ2 LK5Cd6LmKBskivzj23GrLkc= X-Google-Smtp-Source: ABdhPJwndM9w9lvzIwBdN8wg47LLSPzU9RXxtV4PvNbeeUxeR0kUoWy336dV3jYu2SNkcXYVQjLidQ== X-Received: by 2002:a17:906:3082:b0:6e0:111f:8986 with SMTP id 2-20020a170906308200b006e0111f8986mr428038ejv.677.1647786898209; Sun, 20 Mar 2022 07:34:58 -0700 (PDT) Received: from ars3 ([2a02:8109:8ac0:56d0::758e]) by smtp.gmail.com with ESMTPSA id t22-20020a056402525600b00416cb5fdc56sm6800768edd.57.2022.03.20.07.34.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 07:34:57 -0700 (PDT) From: Augusto Stoffel References: <87o8203k0v.fsf@gmail.com> <838rt4g28v.fsf@gnu.org> Date: Sun, 20 Mar 2022 15:34:56 +0100 In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sun, 20 Mar 2022 14:03:16 +0000") Message-ID: <87sfrcitf3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) In short, this should definitely not be merged into Emacs 28. From unknown Wed Jun 18 00:25:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54473: 28.0.91; [PATCH] Eldoc: Handle invisible text when truncating strings Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Mar 2022 15:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54473 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Augusto Stoffel Cc: 54473@debbugs.gnu.org, joaotavora@gmail.com, andreyk.mad@gmail.com Received: via spool by 54473-submit@debbugs.gnu.org id=B54473.164779188322718 (code B ref 54473); Sun, 20 Mar 2022 15:59:02 +0000 Received: (at 54473) by debbugs.gnu.org; 20 Mar 2022 15:58:03 +0000 Received: from localhost ([127.0.0.1]:35051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVxwR-0005uM-7U for submit@debbugs.gnu.org; Sun, 20 Mar 2022 11:58:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVxwQ-0005tp-5U for 54473@debbugs.gnu.org; Sun, 20 Mar 2022 11:58:02 -0400 Received: from [2001:470:142:3::e] (port=54268 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVxwK-0004lE-Qj; Sun, 20 Mar 2022 11:57:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GwGUepyDqGMLGx9/DjYz8GzaOo7ItK1hSRB7aKrjmF4=; b=iPxonPHQq0K+ rWdzRmWM2TtEWkVryNlBZT/SDUp6w8uHVsmVm71HcKGMDS4zKvKS3we4ClZm2MtBwSN6qGPAEYPRL KKaAH0NZFmpR0IZrQkakV416ozQCKKif7P8W37eEO5upxJWSIjuJUScGO1oETB8diSpqnlEQssIOS YkkNiahZC65VHU+PcdbVt9cxao3UJv5a6IwvPm3uV1bjVUCclyng6bMPIll2uowW0uom6Kzq2oJlX 4lQVFC9AB8dd2z1hDS302hHfx9kTG84am9VpJlvN+5aBzcRxl1hWCyVWe3+cxv8maB+LS6MNXmfSm jyTp1VNF0vgeVK1R40+2TA==; Received: from [87.69.77.57] (port=3894 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVxwK-00015N-BM; Sun, 20 Mar 2022 11:57:56 -0400 Date: Sun, 20 Mar 2022 17:57:38 +0200 Message-Id: <837d8ofwgd.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87sfrcitf3.fsf@gmail.com> (message from Augusto Stoffel on Sun, 20 Mar 2022 15:34:56 +0100) References: <87o8203k0v.fsf@gmail.com> <838rt4g28v.fsf@gnu.org> <87sfrcitf3.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Augusto Stoffel > Cc: Eli Zaretskii , 54473@debbugs.gnu.org, Andrii Kolomoiets > > Date: Sun, 20 Mar 2022 15:34:56 +0100 > > In short, this should definitely not be merged into Emacs 28. OK, thanks to both of you. From unknown Wed Jun 18 00:25:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54473: 28.0.91; [PATCH] Eldoc: Handle invisible text when truncating strings Resent-From: Andrii Kolomoiets Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Mar 2022 21:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54473 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Augusto Stoffel Cc: 54473@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Received: via spool by 54473-submit@debbugs.gnu.org id=B54473.164781146429939 (code B ref 54473); Sun, 20 Mar 2022 21:25:01 +0000 Received: (at 54473) by debbugs.gnu.org; 20 Mar 2022 21:24:24 +0000 Received: from localhost ([127.0.0.1]:35233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nW32G-0007mo-BZ for submit@debbugs.gnu.org; Sun, 20 Mar 2022 17:24:24 -0400 Received: from mail-qv1-f41.google.com ([209.85.219.41]:43696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nW32D-0007md-Pp for 54473@debbugs.gnu.org; Sun, 20 Mar 2022 17:24:22 -0400 Received: by mail-qv1-f41.google.com with SMTP id f3so4677861qvz.10 for <54473@debbugs.gnu.org>; Sun, 20 Mar 2022 14:24:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=wEf+0hXzIP1oQLK8YKOeX2UR4y6107b8QQY4bnQpoiA=; b=qVXo+7mbq+t8Rk4veaSuCQbblQPajeI2W2Cgpua2ptiM0ui7D4xyaAFNt76Xhpkf19 V527B8YArTHLpCoCYDyh3ojzIvKYiBg7qDTE4pgLhucDoDph0ye4M3GDIWqa0Lpb8T8p NLjqaQ29YUq3b4asLjGqTesCK1pnXi63ntro8palk4CNNi1WakhMOqBy7OWMSEspMKo3 nMfeGRPggRiY5BbWdUJ/eJJzNdQyP+dCNU5/tO26vgtG9d/9A/qK4JApU3uFC9a6NfDN RC3eJue0XpcS4emuK3BpjL1SFGHYL8Q3Xpj8awHwMH6FZz5B545ujG6xpV8UBrAELFJn dYZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=wEf+0hXzIP1oQLK8YKOeX2UR4y6107b8QQY4bnQpoiA=; b=nA/1WRRv+QQdGCS/S2e+7WDpZr4o9hwezkMeL/f20ncdo8B0CdML9wx2Bd6bnMDH0L RSktpNU0usUiaALjjhwDKq5BiQR+TJddJc6MOsPuA+UUW9NSFq/GKl36DNeq7stURjTB VB/UJ2ymrSjXP38NSd+9xfXWWMcLhDUemFywbr7MWu2Ygy+BbSMPXKBw2nIlg1Bqrr+e KdlR/RWVO9G930uK3aNGe2FphmFJMu1UiFDlo5J6+XdkOI10ZzF1YqanV/a1ra5ju3af HEtRtFJcP/zIQcvgzJYRbZ713uJk/ACZbBPloWHOAtjDia1xG2r7eiebBe2ndtpQR0FG MLUw== X-Gm-Message-State: AOAM5317MmPnpieVYmpwLlqSXF0WGwLLDjRINZx2r8R+CbE0xAuEX+Fr cjEtLTZp4unvFxtzqmUESj8= X-Google-Smtp-Source: ABdhPJypKRCO7PzNBWNa0h2g90/RJ8XTJ49zRSI63HNDK/+O1uCeGdM+M+FgbHIRiKGSeqD63sfMew== X-Received: by 2002:a05:6214:d67:b0:435:bafb:5b23 with SMTP id 7-20020a0562140d6700b00435bafb5b23mr14203409qvs.118.1647811456247; Sun, 20 Mar 2022 14:24:16 -0700 (PDT) Received: from muffinmac ([91.206.110.212]) by smtp.gmail.com with ESMTPSA id e7-20020a37ac07000000b0067d7cd47af4sm6917087qkm.31.2022.03.20.14.24.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 14:24:15 -0700 (PDT) From: Andrii Kolomoiets References: <87o8203k0v.fsf@gmail.com> Date: Sun, 20 Mar 2022 23:24:12 +0200 In-Reply-To: <87o8203k0v.fsf@gmail.com> (Augusto Stoffel's message of "Sun, 20 Mar 2022 13:06:56 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Augusto Stoffel writes: > This should solve the Eglot-related problem described in this Github comment: > > https://github.com/joaotavora/eglot/issues/865#issuecomment-1065565845 I've tested this patch with recent Emacs master and Eglot versions, with various values for the `eldoc-echo-area-use-multiline-p' variable (truncate-sym-name-if-fit, 2, 1). All works as expected. Thanks Augusto! From unknown Wed Jun 18 00:25:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54473: 28.0.91; [PATCH] Eldoc: Handle invisible text when truncating strings Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Mar 2022 15:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54473 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Andrii Kolomoiets , eliz@gnu.org Cc: 54473@debbugs.gnu.org, Augusto Stoffel Received: via spool by 54473-submit@debbugs.gnu.org id=B54473.164813546527512 (code B ref 54473); Thu, 24 Mar 2022 15:25:01 +0000 Received: (at 54473) by debbugs.gnu.org; 24 Mar 2022 15:24:25 +0000 Received: from localhost ([127.0.0.1]:49190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXPK5-00079g-1g for submit@debbugs.gnu.org; Thu, 24 Mar 2022 11:24:25 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:41531) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXPK4-00079S-6t for 54473@debbugs.gnu.org; Thu, 24 Mar 2022 11:24:24 -0400 Received: by mail-wr1-f45.google.com with SMTP id h23so7118389wrb.8 for <54473@debbugs.gnu.org>; Thu, 24 Mar 2022 08:24:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=HxxAxq4P4ob9eUNfVhrE5uIZ1x9Jynq4ucm7XV0f4RA=; b=pq2OYVUssXRe6OshAsK9/YjSm/8/79BmTZrrC4/yHr3lawyPRhdl8PW1ci7iOckr1w 12d2hSIvB8bzy/w3s59YBLeBHmN5posNMcFo0YM/0l3PZfQePpMKPIKaisjf+sAWDpTs mHYufoWZhB410CMTmf7XkbWAqdNWqo+9x5F5TPbLXl6NViH3O3qh+P0x+IYu4h1PYO8e /8X2uXiuK8BNHdovVuRiIixoGpq0Z0h4iI5iQQ+FzHe2991kAJarVrWC1qyZ2AoIKkRz +dUCq79v6e/s4XcJrZSj5Gi+i2Q6sQrMdJdmOHJy87B3Nil6Lo/mDonnXnyzXVggrxY6 16mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=HxxAxq4P4ob9eUNfVhrE5uIZ1x9Jynq4ucm7XV0f4RA=; b=j2LkKFnLcz45O3fab7UUoTjBaVpkxGkAmuizJcaK9p4vIaUCFtQzNHuqucaOcjKFTj wSJymL9nWVlRE2ay9UxBeXUCCgCWvWUW5C5NF2hFdszNcssD+g5YRvRMQVF1imrfzsw3 UTTmIJkrquA3z2x4gjg+cm39ydKjVTQ1lbbT5jIMqZ1lB9nF5iB98aoH7ulQ8x408Oxx CbFWTf1K0r6/yW8Di/RHbXDNSTD4GXZW3xE9g6psIGhziMwDRj1VB1KS0uM2oXGI8zx5 ZcBzjNv7cY1xC6npLs+4ddJdwMKcbCLuLn0M6OL8VoC3gTPWi9ctJRihTVnkq0i/25WO uL0w== X-Gm-Message-State: AOAM531T8de6aPmyYd4NeJmBcTwIW4y2zXpxPbvU9AdjlPfm4q0CmJ5i +E+JvVlaT0J1CpflQxbCgY8i5aJv18W7zw== X-Google-Smtp-Source: ABdhPJw6aEdXCi93sdft8FTGdualyMhgDpw5p0OIm3QqB4tMJ0DNS0FYPdtVGNqUWSdwGf9HGagQ0Q== X-Received: by 2002:a5d:5987:0:b0:204:1f21:6a29 with SMTP id n7-20020a5d5987000000b002041f216a29mr5127780wri.716.1648135457952; Thu, 24 Mar 2022 08:24:17 -0700 (PDT) Received: from krug (87-196-72-45.net.novis.pt. [87.196.72.45]) by smtp.gmail.com with ESMTPSA id j5-20020a05600c1c0500b0038ca4fdf7a5sm9614801wms.9.2022.03.24.08.24.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Mar 2022 08:24:17 -0700 (PDT) From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= References: <87o8203k0v.fsf@gmail.com> Date: Thu, 24 Mar 2022 15:25:19 +0000 In-Reply-To: (Andrii Kolomoiets's message of "Sun, 20 Mar 2022 23:24:12 +0200") Message-ID: <87tubne5k0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 3.5 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Andrii Kolomoiets writes: > Augusto Stoffel writes: > >> This should solve the Eglot-related problem described in this Github comment: >> >> https://github.com/joaotavora/eglot/issues/865#issuecomment-1065565845 > > I've tes [...] Content analysis details: (3.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [87.196.72.45 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (joaotavora[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.45 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.45 listed in wl.mailspike.net] -0.0 T_SCC_BODY_TEXT_LINE No description available. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Andrii Kolomoiets writes: > Augusto Stoffel writes: > >> This should solve the Eglot-related problem described in this Github comment: >> >> https://github.com/joaotavora/eglot/issues/865#issuecomment-1065565845 > > I've tes [...] Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.45 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.45 listed in wl.mailspike.net] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [87.196.72.45 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (joaotavora[at]gmail.com) -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Andrii Kolomoiets writes: > Augusto Stoffel writes: > >> This should solve the Eglot-related problem described in this Github com= ment: >> >> https://github.com/joaotavora/eglot/issues/865#issuecomment-1065565845 > > I've tested this patch with recent Emacs master and Eglot versions, with > various values for the `eldoc-echo-area-use-multiline-p' variable > (truncate-sym-name-if-fit, 2, 1). > > All works as expected. > > Thanks Augusto! I've pushed this change to master and bumped the eldoc.el package version. Jo=C3=A3o From unknown Wed Jun 18 00:25:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54473: 28.0.91; [PATCH] Eldoc: Handle invisible text when truncating strings Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Jun 2022 17:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54473 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: Augusto Stoffel , eliz@gnu.org, 54473@debbugs.gnu.org, Andrii Kolomoiets Received: via spool by 54473-submit@debbugs.gnu.org id=B54473.165600505712668 (code B ref 54473); Thu, 23 Jun 2022 17:25:02 +0000 Received: (at 54473) by debbugs.gnu.org; 23 Jun 2022 17:24:17 +0000 Received: from localhost ([127.0.0.1]:39763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4QYy-0003IF-Lw for submit@debbugs.gnu.org; Thu, 23 Jun 2022 13:24:16 -0400 Received: from mail-pl1-f171.google.com ([209.85.214.171]:37881) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4QYw-0003Hu-Gi for 54473@debbugs.gnu.org; Thu, 23 Jun 2022 13:24:14 -0400 Received: by mail-pl1-f171.google.com with SMTP id k14so7239127plh.4 for <54473@debbugs.gnu.org>; Thu, 23 Jun 2022 10:24:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc :content-transfer-encoding; bh=KrgSb0q1DZPhZ3IjzIWRCbVAhdd0XEFzS4qTbArQf5o=; b=ESi6c3Lwn443XNWSwEqHZIi1uyQKQJKqYgrMt59C4Ds0XxCXXJAECBlRqhJo1kO7w0 UkVbtV81N30dokjXgU9QSSrzGMQIT5Hq2CoikwP3ozqomiWeVDbwFDhnagK4BL/1oBQO sVXc8/r1BZGcfueSXr3zRvuSZLjtioBwGeoGv5apROsUM8mL38NxsOmhwnr0wZOAdePZ dVizoH5BewTt07i/f2E6HBpaPZn3TlCQoVVIMj+CxO0J0z4Fa/9J5TUwunmrmBAbvaDi sLFwOgF82uPVT73t3eocTB1gDSF/ExW/wFm7I701dm5PjQMQivtHY+qsZJLkyYH+c6Xl fvZw== X-Gm-Message-State: AJIora861J1B/8XaUnmBmkAepB4nPqce9SfHJM6eHTYw8wahAT/lzE/A 6fZfVPmeXvhDep+Lg9G33B0cPKUM4k8Qd8ikZPI= X-Google-Smtp-Source: AGRyM1v4yp0tkGrKChGcn5B/GgXHjW/SZSMuVGITtq1wF8dNwuVES4fsZcdUUSspNZK6VwQIh9mpTAIfAz/v9Moub3s= X-Received: by 2002:a17:90a:4a97:b0:1ea:fa24:467c with SMTP id f23-20020a17090a4a9700b001eafa24467cmr9402pjh.1.1656005048508; Thu, 23 Jun 2022 10:24:08 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 23 Jun 2022 12:24:07 -0500 From: Stefan Kangas In-Reply-To: <87tubne5k0.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Thu, 24 Mar 2022 15:25:19 +0000") References: <87o8203k0v.fsf@gmail.com> <87tubne5k0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Date: Thu, 23 Jun 2022 12:24:07 -0500 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) close 54473 29.1 thanks Jo=C3=A3o T=C3=A1vora writes: > I've pushed this change to master and bumped the eldoc.el package > version. This was pushed to master, so I'm closing this bug: commit 45978f97be89ae989ecf9e7129b88592e70a1f24 Author: Augusto Stoffel Date: Thu Mar 24 15:05:39 2022 +0000 Handle invisible text in Eldoc when calculating size Co-authored-by: Jo=C3=A3o T=C3=A1vora * lisp/emacs-lisp/eldoc.el (eldoc--echo-area-substring, eldoc-display-in-echo-area): Take invisible text into consideratio= n when counting lines to crop an echo-area message. (Version): Bump.