GNU bug report logs - #54437
28.0.92; command-modes returns nil for native compiled functions

Previous Next

Full log

View this message in rfc822 format

From: Andrea Corallo <akrl <at> sdf.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: kahatlen <at> gmail.com, Eli Zaretskii <eliz <at> gnu.org>, 54437 <at> debbugs.gnu.org
Subject: bug#54437: 28.0.92; command-modes returns nil for native compiled functions
Date: Mon, 21 Mar 2022 09:56:00 +0000

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Andrea Corallo <akrl <at> sdf.org> writes:
>
>> Yes, we'd still need to store the information in each .eln and update
>> the value of this new global hash table each time (probably in
>> comp--register-subr).  So some C should be modified anyway even if
>> (maybe?) less, I doubt is doable in the realease branch at this point
>> anyway.
>
> There's also the problem with stale entries -- if you're re-loading an
> .eln with different functions with different command modes, you'd need
> some way to nix out the old ones (for instance, if a command goes from
> having modes to not).  Or you'd have to register all the commands in the
> hash table, which seems awkward.

In comp--register-subr I'd add the entry into the hash table if the
function being loaded is connected to some mode or I'd clean the entry
in case the new function being defined has no mode but an entry is
already present.

But that said I agree with you that given the resulting patch would not
be trivial and we have to touch some C anyway having two codes to solve
the same issue doesn't sound like a good idea.

> I think if we want this in Emacs 28, it's probably safer to just
> cherry-pick the commit to master, as invasive as that is.  On the other
> hand, the command-modes stuff is new functionality in Emacs 28, so just
> documenting that it doesn't work with native-comp (yet) would also be
> fine, and then perhaps do an Emacs 28.2 later with the patch.

Agree

Thanks

  Andrea

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.