Subject: Re: bug#54434: [PATCH 0/6] XFCE Updates

From: Ludovic Courtès <[email-masked]>
Date: Sun, 03 Apr 2022 12:25:56 +0200

Hi,

'Brendan Tildesley <[email-masked]> writes:

> From: Brendan Tildesley <[email-masked]>
>
> * gnu/packages/xfce.scm (mate-polkit-for-xfce): Package doesn't
> particularly need to be hidden.
> [name]: Provide a unique name for this variant.
> [description]: Explain packages purpose.

[...]

>    (package/inherit mate-polkit
> +    (name "mate-polkit-for-xfce")
>      (arguments
>       `(#:phases
>         (modify-phases %standard-phases
> @@ -924,7 +926,14 @@ (define-public mate-polkit-for-xfce
>                 (substitute* old (("MATE;") "XFCE;"))
>                 ;; To avoid a conflict if both MATE and XFCE are installed.
>                 (rename-file old new)))))))
> -    (properties `((hidden? . #t)))))
> +    (synopsis "PolicyKit Authentication agent for XFCE")
> +    (description
> +     (string-append
> +      (package-description mate-polkit) "\n\n"
> +      (P_ "This package variant provides the MATE PolicyKit authentication
> +agent configured to autostart for XFCE.  This is because the XFCE project does
> +not have its own official authentication agent, so we pick MATE PolicyKit as a
> +reasonable fit.")))))

“Polkit” is really called “Polkit”; “PolicyKit” was its predecessor and
it’s important to distinguish them.

I’m not convinced this package needs to be made public though because
it’s not meant to be installed manually.

WDYT?

Ludo’.