GNU bug report logs -
#54432
[PATCH] gnu: rtl8812au-aircrack-ng-linux-module: Update to 37e27f9.
Previous Next
Reported by: "J. Sims" <jtsims <at> protonmail.com>
Date: Thu, 17 Mar 2022 01:27:01 UTC
Severity: normal
Tags: patch
Done: Leo Famulari <leo <at> famulari.name>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54432 in the body.
You can then email your comments to 54432 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org:
bug#54432; Package
guix-patches.
(Thu, 17 Mar 2022 01:27:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
"J. Sims" <jtsims <at> protonmail.com>:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org.
(Thu, 17 Mar 2022 01:27:01 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
This fixes issues with Linux 5.17 and adds optimizations for 5.15:
https://github.com/aircrack-ng/rtl8812au/pull/942
https://github.com/aircrack-ng/rtl8812au/commit/2f52f84096ae09d36012d455d29b73e6cb37f740
It also runs `guix style`.
* gnu/packages/linux.scm (rtl8812au-aircrack-ng-linux-module):
Update to commit 37e27f9.
---
gnu/packages/linux.scm | 33 ++++++++++++++-------------------
1 file changed, 14 insertions(+), 19 deletions(-)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 0dc5c8260e..a49443bb3d 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -1383,29 +1383,24 @@ (define-public rtl8821ce-linux-module
(license license:gpl2))))
(define-public rtl8812au-aircrack-ng-linux-module
- (let ((commit "307d694076b056588c652c2bdaa543a89eb255d9")
- (revision "6"))
+ (let ((commit "37e27f9165300c89607144b646545fac576ec510") (revision "7"))
(package
(inherit rtl8821ce-linux-module)
(name "rtl8812au-aircrack-ng-linux-module")
(version (git-version "5.6.4.2" revision commit))
- (source
- (origin
- (method git-fetch)
- (uri (git-reference
- (url "https://github.com/aircrack-ng/rtl8812au")
- (commit commit)))
- (file-name (git-file-name name version))
- (sha256
- (base32 "1g2zga7jqzp4azwqpgxxx3lg07ijaaqw3zqnaa3i2brycwlnf8l9"))
- (modules '((guix build utils)))
- (snippet
- #~(begin
- ;; Remove bundled tarballs, APKs, word lists, speadsheets,
- ;; and other unnecessary unlicenced things.
- (for-each delete-file-recursively (list "android"
- "docs"
- "tools"))))))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/aircrack-ng/rtl8812au")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "09n814pa6i0b0xkgssymcmbcdic05y9z5bsr6sxjfs40wawsk6af"))
+ (modules '((guix build utils)))
+ (snippet #~(begin
+ (for-each delete-file-recursively
+ (list "android" "docs" "tools"))))))
(supported-systems '("x86_64-linux" "i686-linux"))
(home-page "https://github.com/aircrack-ng/rtl8812au")
(synopsis "Linux driver for Realtek USB wireless network adapters")
--
2.34.0
Information forwarded
to
guix-patches <at> gnu.org:
bug#54432; Package
guix-patches.
(Thu, 17 Mar 2022 15:07:01 GMT)
Full text and
rfc822 format available.
Message #8 received at 54432 <at> debbugs.gnu.org (full text, mbox):
Hi,
Am Donnerstag, dem 17.03.2022 um 01:12 +0000 schrieb J. Sims:
> This fixes issues with Linux 5.17 and adds optimizations for 5.15:
>
> https://github.com/aircrack-ng/rtl8812au/pull/942
> https://github.com/aircrack-ng/rtl8812au/commit/2f52f84096ae09d36012d455d29b73e6cb37f740
>
> It also runs `guix style`.
>
> * gnu/packages/linux.scm (rtl8812au-aircrack-ng-linux-module):
> Update to commit 37e27f9.
> ---
> gnu/packages/linux.scm | 33 ++++++++++++++-------------------
> 1 file changed, 14 insertions(+), 19 deletions(-)
>
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 0dc5c8260e..a49443bb3d 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -1383,29 +1383,24 @@ (define-public rtl8821ce-linux-module
> (license license:gpl2))))
>
> (define-public rtl8812au-aircrack-ng-linux-module
> - (let ((commit "307d694076b056588c652c2bdaa543a89eb255d9")
> - (revision "6"))
> + (let ((commit "37e27f9165300c89607144b646545fac576ec510")
> (revision "7"))
This indentation fix should not have been done. Bad `guix style'.
> (package
> (inherit rtl8821ce-linux-module)
> (name "rtl8812au-aircrack-ng-linux-module")
> (version (git-version "5.6.4.2" revision commit))
> - (source
> - (origin
> - (method git-fetch)
> - (uri (git-reference
> - (url "https://github.com/aircrack-ng/rtl8812au")
> - (commit commit)))
> - (file-name (git-file-name name version))
> - (sha256
> - (base32
> "1g2zga7jqzp4azwqpgxxx3lg07ijaaqw3zqnaa3i2brycwlnf8l9"))
> - (modules '((guix build utils)))
> - (snippet
> - #~(begin
> - ;; Remove bundled tarballs, APKs, word lists,
> speadsheets,
> - ;; and other unnecessary unlicenced things.
> - (for-each delete-file-recursively (list "android"
> - "docs"
> - "tools"))))))
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url
> "https://github.com/aircrack-ng/rtl8812au")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> +
> "09n814pa6i0b0xkgssymcmbcdic05y9z5bsr6sxjfs40wawsk6af"))
> + (modules '((guix build utils)))
> + (snippet #~(begin
> + (for-each delete-file-recursively
> + (list "android" "docs"
> "tools"))))))
The comment regarding what has been removed ought to be preserved.
Other than that fair enough.
Information forwarded
to
guix-patches <at> gnu.org:
bug#54432; Package
guix-patches.
(Thu, 17 Mar 2022 21:44:02 GMT)
Full text and
rfc822 format available.
Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):
On Thu, Mar 17, 2022 at 01:12:33AM +0000, J. Sims via Guix-patches via wrote:
> This fixes issues with Linux 5.17 and adds optimizations for 5.15:
>
> https://github.com/aircrack-ng/rtl8812au/pull/942
> https://github.com/aircrack-ng/rtl8812au/commit/2f52f84096ae09d36012d455d29b73e6cb37f740
>
> It also runs `guix style`.
>
> * gnu/packages/linux.scm (rtl8812au-aircrack-ng-linux-module):
> Update to commit 37e27f9.
Thanks for paying attention to this package!
I pushed the update as commit a28dd4719267914482ee88250a2a6dfbdd81eca7,
although I did omit the style changes in light of Liliana's comments.
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=a28dd4719267914482ee88250a2a6dfbdd81eca7
We can use `guix style` but I prefer that we do it in its own commit,
and maybe even on the entire gnu/packages/linux.scm module at once.
That will make it easier to hide purely stylistic changes from `git
blame`, improving long-term utility of the Git history.
And as Liliana pointed out, maybe `guix style` needs some tweaks before
we use it here.
Reply sent
to
Leo Famulari <leo <at> famulari.name>:
You have taken responsibility.
(Thu, 17 Mar 2022 21:44:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
"J. Sims" <jtsims <at> protonmail.com>:
bug acknowledged by developer.
(Thu, 17 Mar 2022 21:44:03 GMT)
Full text and
rfc822 format available.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org.
(Fri, 15 Apr 2022 11:24:06 GMT)
Full text and
rfc822 format available.
This bug report was last modified 3 years and 122 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.