From unknown Sat Jun 21 10:38:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54429: 29.0.50; message-resend should not use the original sender's address for the envelope-from Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Mar 2022 20:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 54429 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 54429@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.164746221415576 (code B ref -1); Wed, 16 Mar 2022 20:24:02 +0000 Received: (at submit) by debbugs.gnu.org; 16 Mar 2022 20:23:34 +0000 Received: from localhost ([127.0.0.1]:52370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUaBB-000438-SP for submit@debbugs.gnu.org; Wed, 16 Mar 2022 16:23:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:56230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUaBA-000431-DZ for submit@debbugs.gnu.org; Wed, 16 Mar 2022 16:23:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59086) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUaBA-0001rg-8F for bug-gnu-emacs@gnu.org; Wed, 16 Mar 2022 16:23:32 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:45889) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUaB8-0006VV-4X for bug-gnu-emacs@gnu.org; Wed, 16 Mar 2022 16:23:31 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id D5DCB5C01D7 for ; Wed, 16 Mar 2022 16:23:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 16 Mar 2022 16:23:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm3; bh=P Id5T3GJHUde+yAfbbrKI2n9UYF3P6gFzPGyyIh1ubc=; b=WG1wi84b0MWLOp6D0 R5z300F4Sd+0cuOqR/k9dsp18eTYvbrU4iAKlTeD4J4oXRlQgpIT3McswPGJuhIV w498pgZ586+xo4RBXOQrism52HRTY1Hr2KZ2LLbefAFvMk2oizOpzbtwX8X7UrCS HpAZlqNTCV2xAWQhZqJ4SZUHDUacQ29HK/LTlAHGqCzJ8SH6o72TKzTe+a3K5Jkd HB3pmFNe3gIZNLQuELsDt6RgQyh7FxpafT+6kuQPAOUEfW67vTxv9/o76PGHURSy Sf7E+AXgboq/yxdqydKETIMbPJQAT74JTzMZYbQm69gX8Vlu8yO0D0j+Pnfg1rsH yFsxA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=PId5T3GJHUde+yAfbbrKI2n9UYF3P6gFzPGyyIh1u bc=; b=k3Z+wwDP9NhbBIipk7LdJv4JIy9F4ok6e3u6hTW9v8bCfoXgqJoKYQXqn VGMZGdPssrtYgrpnOPaJ3+ZrgRJqx/HbsXIopVmPICBtJltHgn6b6Ls7DVRczmmc EP6jhkuPTS0bPKQXnPwQTI0KZ2HzJ5ty//FvxF2glscNRDIu8FPpwM1JMMVTv+nn d39AG6EBb2uT4fxawBUOwCPZOd3ywaY+wfkkBP3vIwGSS07Gjh30ooNUwQ/s7ZG3 qRDRK0p9Lr8lIP2AtiN9Tx5c0lROnsm+cuzk1rzVmrq6WX1nozH9uNRVZf1T8sBx 2hXfU2YNLS2w4yDDOaH1We0MbErfA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudefvddgudeffecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufgffffkgggtsehmtddtre dtredtnecuhfhrohhmpefuvggrnhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehs phifhhhithhtohhnrdhnrghmvgeqnecuggftrfgrthhtvghrnhepkeeggeeujeeludegve evveeljeffhfelhfegfffhudehhffhkedvheeftedvueelnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhih htthhonhdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 16 Mar 2022 16:23:27 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 4F5297E17D3; Wed, 16 Mar 2022 13:23:26 -0700 (MST) From: Sean Whitton User-Agent: Notmuch/0.31.4 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Date: Wed, 16 Mar 2022 13:23:26 -0700 Message-ID: <87zglpy7cx.fsf@melete.silentflame.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=66.111.4.29; envelope-from=spwhitton@spwhitton.name; helo=out5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) --=-=-= Content-Type: text/plain If `message-sendmail-envelope-from' is `header' then the envelope-from will be the original sender's address, not the resender's. But when resending, the envelope-from should be the resender's address. Defuse that particular case. -- Sean Whitton --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Don-t-use-the-original-sender-s-address-as-the-envel.patch >From 03abba1ccdc8604ff7e59ab8b4c55d18185d0fd1 Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Wed, 16 Mar 2022 13:19:57 -0700 Subject: [PATCH] Don't use the original sender's address as the envelope-from * lisp/gnus/message.el (message-resend): Avoid setting the envelope-from to the original sender's address rather than the resender's. --- lisp/gnus/message.el | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el index 800c7dcea0..ad04a5e865 100644 --- a/lisp/gnus/message.el +++ b/lisp/gnus/message.el @@ -8016,7 +8016,18 @@ message-resend (select-safe-coding-system-function nil) message-required-mail-headers message-generate-hashcash - rfc2047-encode-encoded-words) + rfc2047-encode-encoded-words + ;; If `message-sendmail-envelope-from' is `header' then + ;; the envelope-from will be the original sender's + ;; address, not the resender's. But when resending, the + ;; envelope-from should be the resender's address. Defuse + ;; that particular case. + (message-sendmail-envelope-from + (and (not (and (eq message-sendmail-envelope-from + 'obey-mail-envelope-from) + (eq mail-envelope-from 'header))) + (not (eq message-sendmail-envelope-from 'header)) + message-sendmail-envelope-from))) (message-send-mail)) (when gcc (message-goto-eoh) -- 2.30.2 --=-=-=-- From unknown Sat Jun 21 10:38:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54429: 29.0.50; message-resend should not use the original sender's address for the envelope-from Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Mar 2022 10:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54429 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: 54429@debbugs.gnu.org Received: via spool by 54429-submit@debbugs.gnu.org id=B54429.164751465824113 (code B ref 54429); Thu, 17 Mar 2022 10:58:01 +0000 Received: (at 54429) by debbugs.gnu.org; 17 Mar 2022 10:57:38 +0000 Received: from localhost ([127.0.0.1]:53160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUnp4-0006Gr-HZ for submit@debbugs.gnu.org; Thu, 17 Mar 2022 06:57:38 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUnp2-0006Ga-Q3 for 54429@debbugs.gnu.org; Thu, 17 Mar 2022 06:57:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vIxb/venDEIJn02JGSWqvLr1puSChg6pSwGFq4ARlv4=; b=ATdtE7575XtcmJpA1h0/O0f1+o DGsJwbp0sZC7jgi/5MfGt2sh5XaYGuG1YADFERq7Zqg1TQI4TqIjlykRsCgpdGj97QaqWgXCoSdMV DFw7fWSc8nsUBmf31f7NVhGA6G3D716VBY5HLgkWEsP0lto3ntQV0jEkgmYjhAo9gcJA=; Received: from 109.179.236.69.tmi.telenormobil.no ([109.179.236.69] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUnot-0006M8-KG; Thu, 17 Mar 2022 11:57:29 +0100 From: Lars Ingebrigtsen References: <87zglpy7cx.fsf@melete.silentflame.com> Date: Thu, 17 Mar 2022 11:57:26 +0100 In-Reply-To: <87zglpy7cx.fsf@melete.silentflame.com> (Sean Whitton's message of "Wed, 16 Mar 2022 13:23:26 -0700") Message-ID: <87k0csvobt.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Sean Whitton writes: > If `message-sendmail-envelope-from' is `header' then the envelope-from > will be the original sender's address, not the resender's. But when > resending, the envelope-from should be the resender's a [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Sean Whitton writes: > If `message-sendmail-envelope-from' is `header' then the envelope-from > will be the original sender's address, not the resender's. But when > resending, the envelope-from should be the resender's address. Defuse > that particular case. Thanks; pushed to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 17 06:57:44 2022 Received: (at control) by debbugs.gnu.org; 17 Mar 2022 10:57:44 +0000 Received: from localhost ([127.0.0.1]:53163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUnp9-0006HA-OC for submit@debbugs.gnu.org; Thu, 17 Mar 2022 06:57:44 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUnp8-0006Gj-BL for control@debbugs.gnu.org; Thu, 17 Mar 2022 06:57:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KI1RR6GZAQIZaUNkA56pXr10GzaLaTOM8CG5+gC5dIw=; b=K5rCuD0s9URGTwx6WJ2SxedLTi MObJPnwdKhOTjg7Oqf8r4pUADxz6/2Ckkl6U8PuzrcnLW8pTi7SedHCLw2H4Gm7VbJCUlBuoB0k5b JWNkC1bGkOpm3nwZB+gDhQfrhqfwOAgEmuUc/25sLJtPCBFg7hrkRZfyglxph/Vdi4Vk=; Received: from 109.179.236.69.tmi.telenormobil.no ([109.179.236.69] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUnp0-0006MG-MN for control@debbugs.gnu.org; Thu, 17 Mar 2022 11:57:36 +0100 Date: Thu, 17 Mar 2022 11:57:33 +0100 Message-Id: <87ilscvobm.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #54429 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 54429 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 54429 29.1 quit