From unknown Sat Jun 21 03:29:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54410: One cl-defgeneric in xref.el should be cl-defmethod Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Mar 2022 23:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 54410 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 54410@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.164738577323701 (code B ref -1); Tue, 15 Mar 2022 23:10:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 Mar 2022 23:09:33 +0000 Received: from localhost ([127.0.0.1]:49813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUGIG-0006AD-ML for submit@debbugs.gnu.org; Tue, 15 Mar 2022 19:09:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:39902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUGIF-0006A3-8Y for submit@debbugs.gnu.org; Tue, 15 Mar 2022 19:09:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUGIF-0007Ha-3f for bug-gnu-emacs@gnu.org; Tue, 15 Mar 2022 19:09:31 -0400 Received: from [2a00:1450:4864:20::62a] (port=33365 helo=mail-ej1-x62a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nUGID-0005Ha-JF for bug-gnu-emacs@gnu.org; Tue, 15 Mar 2022 19:09:30 -0400 Received: by mail-ej1-x62a.google.com with SMTP id pv16so836137ejb.0 for ; Tue, 15 Mar 2022 16:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version; bh=jJrWyVkF6JQomhaQSze4k1PeZzwYmpXFmVD6jWSU920=; b=mrwB+h17Xo17BhXKlZTY2+Fyg2kvhjYA6dqER3sn/N8lDKCKqC1cK0e9f5p5RetQ2S a5s97Zrg59r6BgvboIkwEOHk64boB4LfHXvSw9KzJ9qMIO6JAshZ7eR9Ab81xMH/i/4k wM8yF95bxEvwkd+u2wXFVqDDuPm1pyhUHVxsHRx4+iuLA66+PfPW+x9Ff9vi9QLY3ZSt 8hJ+06nTV4u5Tn1OjVJTLVa0po4i/55ZnKLRnYzRD0gCh0tRw1QI1sisAB4+01FfOt82 uo7SH7KLAF7OYc6g+WFnfODbcbLWL+VFkJ8/6Y21rHCk7Vtqmown5A087p+gXvYQezLz LRcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=jJrWyVkF6JQomhaQSze4k1PeZzwYmpXFmVD6jWSU920=; b=lZCjDbXW9dkRXGGvEb/VhrsHvj9k0XCB5GJa1gvvQpOfeLQGgbZN1AylipLy11C6Jn kEtlKgf2BMiFKR5hu2QyNLMczIkHwTnjDfqu5bx4aMzWWM2bcwQIMIBRNdBh3w3hb+lx gh0O+xM8Ob7dqazaotpbk9fMqC9XWwQcseyKrbIdzF1dmoetJw14TSMpo5VMGhPXhzoQ 0AYKmypGTkOqeeb5lZikucSNienA9D3dS8NTQ6APQjnyaTQmntI0QKq277mi9L0ClEz6 pbO4/8E2VLN5NjMZ0YgXGOKA7q2BAR8cyvuYk5Z2hSfHdZfbD8A/MDg0CcXFMQKeDQ2T obQw== X-Gm-Message-State: AOAM531qtFIrnY7iQ9lyVfpvUI9cugaZVADYNImDP+am7hXKcYHwn1mv miRrkD8YRmvq0YDCJU+qL7LmK3LzEUo= X-Google-Smtp-Source: ABdhPJzUnF+39sdElLpT5xxbI0KvXXnrAqwWKuF4XdOVl4bvIw/Y8Pe8Er4srqSiBSjyFuRlI3mlgw== X-Received: by 2002:a17:906:c048:b0:6ce:a6f5:b23a with SMTP id bm8-20020a170906c04800b006cea6f5b23amr24235353ejb.350.1647385767201; Tue, 15 Mar 2022 16:09:27 -0700 (PDT) Received: from phst ([2a02:2455:2a4:dc00:7dd1:b754:ae65:7605]) by smtp.gmail.com with ESMTPSA id m21-20020a17090677d500b006df766974basm162347ejn.3.2022.03.15.16.09.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Mar 2022 16:09:26 -0700 (PDT) From: Philipp Stephani Date: Wed, 16 Mar 2022 00:09:23 +0100 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::62a (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=p.stephani2@gmail.com; helo=mail-ej1-x62a.google.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Tags: patch Is the following patch good for the release branch? In GNU Emacs 28.0.92 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.31, cairo version 1.16.0) of 2022-03-14 Repository revision: 8e7a3f21e00649bacc01be627edd45ff01b51a33 Repository branch: emacs-28 [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (p.stephani2[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (p.stephani2[at]gmail.com) 0.0 RCVD_IN_MSPIKE_H5 RBL: Excellent reputation (+5) [209.51.188.17 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. 1.5 SPOOFED_FREEMAIL No description available. 0.8 SPOOF_GMAIL_MID From Gmail but it doesn't seem to be... X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain Tags: patch Is the following patch good for the release branch? In GNU Emacs 28.0.92 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.31, cairo version 1.16.0) of 2022-03-14 Repository revision: 8e7a3f21e00649bacc01be627edd45ff01b51a33 Repository branch: emacs-28 Windowing system distributor 'The X.Org Foundation', version 11.0.12014000 System Description: Debian GNU/Linux rodete Configured using: 'configure --enable-gcc-warnings=warn-only --enable-gtk-deprecation-warnings --without-pop --with-mailutils --enable-checking=all --enable-check-lisp-object-type --with-modules 'CFLAGS=-O0 -ggdb3'' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=xref-defmethod.patch diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 2fd5e19237..aefee31897 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -220,7 +220,7 @@ xref-location-group "A match xref item describes a search result." length) -(cl-defgeneric xref-match-length ((item xref-match-item)) +(cl-defmethod xref-match-length ((item xref-match-item)) "Return the length of the match." (xref-match-item-length item)) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Liana Sebastian Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Falls Sie diese f=C3=A4lschlicherweise erhal= ten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, l=C3=B6sche= n Sie alle Kopien und Anh=C3=A4nge davon und lassen Sie mich bitte wissen, dass d= ie E-Mail an die falsche Person gesendet wurde. This e-mail is confidential. If you received this communication by mistake, please don=E2=80=99t forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. --=-=-=-- From unknown Sat Jun 21 03:29:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54410: One cl-defgeneric in xref.el should be cl-defmethod Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Mar 2022 03:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54410 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philipp Stephani Cc: 54410@debbugs.gnu.org Received: via spool by 54410-submit@debbugs.gnu.org id=B54410.164740136818064 (code B ref 54410); Wed, 16 Mar 2022 03:30:02 +0000 Received: (at 54410) by debbugs.gnu.org; 16 Mar 2022 03:29:28 +0000 Received: from localhost ([127.0.0.1]:49984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUKLo-0004hI-HG for submit@debbugs.gnu.org; Tue, 15 Mar 2022 23:29:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUKLn-0004h6-HX for 54410@debbugs.gnu.org; Tue, 15 Mar 2022 23:29:27 -0400 Received: from [2001:470:142:3::e] (port=52310 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUKLi-0002EX-A8; Tue, 15 Mar 2022 23:29:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pLmkWUwiT+WOEfttpFSRomWC8jR0G90e8uQQRLXAjGY=; b=Z0+ra9f8m83F TFbreCIz6JUc8rnouNqwj+wff+//3IutHJqwuh/zKxeVT8eZ2o7mSfJS7zonVRIGmSfZ7qDSAxCfF DOVdmdOPhTdTGCk1QeadrOFxStuLV/BmF2RKrOvx5+Q5RPtThzKNX3e6VtBlwTlfOnPtZYUgWyjeT PHXBY4zNdSmjej7kfOzszWVQfwl0zmwa9J0O1jp3o8E3UKFsMgNFCRQds9MCF6asjsTTIVW+MtQ1t cbWT9TaHaYLUUxIrRAV+CG4aGcVUfKu20K9bAlipn1QGSet4e59huMz2fiNTdspU9i6yqJlNvLLJY w+HfRLBVVYcb90wc3lqS6A==; Received: from [87.69.77.57] (port=3197 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUKLh-00016D-Ku; Tue, 15 Mar 2022 23:29:22 -0400 Date: Wed, 16 Mar 2022 05:29:13 +0200 Message-Id: <838rtainhy.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Philipp Stephani on Wed, 16 Mar 2022 00:09:23 +0100) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philipp Stephani > Date: Wed, 16 Mar 2022 00:09:23 +0100 > > Is the following patch good for the release branch? What problems are caused by the current code? In general, I'd prefer to leave the release branch alone at this time, so we could release Emacs 28.1 soon. It seems quite ready. From unknown Sat Jun 21 03:29:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54410: One cl-defgeneric in xref.el should be cl-defmethod Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Mar 2022 12:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54410 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , Philipp Stephani Cc: 54410@debbugs.gnu.org Received: via spool by 54410-submit@debbugs.gnu.org id=B54410.16474328893505 (code B ref 54410); Wed, 16 Mar 2022 12:15:02 +0000 Received: (at 54410) by debbugs.gnu.org; 16 Mar 2022 12:14:49 +0000 Received: from localhost ([127.0.0.1]:50437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUSYD-0000uP-CL for submit@debbugs.gnu.org; Wed, 16 Mar 2022 08:14:49 -0400 Received: from mail-ej1-f54.google.com ([209.85.218.54]:41952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUSYB-0000u3-R7 for 54410@debbugs.gnu.org; Wed, 16 Mar 2022 08:14:48 -0400 Received: by mail-ej1-f54.google.com with SMTP id a8so3719451ejc.8 for <54410@debbugs.gnu.org>; Wed, 16 Mar 2022 05:14:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Q0XmRRYJAuq3VltIOylqHscd/fH6+F0pnfTEKXmMb1A=; b=KBZxywdqZZFozHzA5QzjV+Rk6wNOI9AljxL9NqOR+Zw1HA47V/J6PlGIWj1oilsz1c kfvPGRH0t5Ff0KZRqwdLIHrGs6c7tDd6qzuArSemt5E2QbEHkhuZVYnENgiHW+8yFHN5 tb26vgC+HsMJYysifxEZ/HNQqkyZGmccSSgrmnVMSVQmq1qP2t/0brw6lGsYpR6CCOIj DxMLBBr7EPNX7zn1xnaKq6vDRmeaHa7TaIUYuXjzd4ugVQ5kFcroQi/0HVzNNKzxzkbp +LeRlml+u/gsFlnItowUVgBYdwGdxvi7N3mnL5os6FiuKUAOK3SmxnKXkhke4ysqp9lo ueEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Q0XmRRYJAuq3VltIOylqHscd/fH6+F0pnfTEKXmMb1A=; b=qWTaf2IEy5pS8CyE5AQsitcqUUr5J5CC4piJI811tqoIYnge5AwZQUyofGS2kfpeVS TTrH/1Rgs6dPuDUhI2Z8/+tnH1NNKGtLmuRl1hHnVDAC5RH9D36CkIZ5QCkAl12v+L2m dHwDMAuO8cpl/nFZdCr3pNg7iwhMx93tVPRUP/HUgvGMELc4tSyjavaUeE56tvZHrcB+ rMnnmsoj4vQDO1dbNbj8My40+zFA7POlhPp8ETUb/C2uAz5DnOmFQpI5x6h2NpGZ2JiP OzNbPJJezJnhruQZpxIAyWjoH0J33o71+YBjN/zZyl6i7u3xABFvzSTjAetJWYCzoNBH JEDQ== X-Gm-Message-State: AOAM530QKplmPVshL+W0RblCAc0WCe4kakNojqDubE2rvVKBX5NBRqiR 59u9UN14ih/yC7hAbyJ7o7U= X-Google-Smtp-Source: ABdhPJyGWA/qHJohO7z7kmfHP5BvCtx0RK2+pxZEPATTq03Iw8bx/UF9famEAc4QbBEXTSgQx/peAw== X-Received: by 2002:a17:906:b288:b0:6da:825e:a2ee with SMTP id q8-20020a170906b28800b006da825ea2eemr26193933ejz.254.1647432881342; Wed, 16 Mar 2022 05:14:41 -0700 (PDT) Received: from [192.168.236.48] ([173.237.64.48]) by smtp.googlemail.com with ESMTPSA id jl2-20020a17090775c200b006dabe8887b8sm837265ejc.21.2022.03.16.05.14.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Mar 2022 05:14:40 -0700 (PDT) Message-ID: Date: Wed, 16 Mar 2022 14:14:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US References: <838rtainhy.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <838rtainhy.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 16.03.2022 05:29, Eli Zaretskii wrote: > What problems are caused by the current code? I think it will cause no change in observable behavior, it's closer to the realm of better documentation. The change should be very safe accordingly, though. From unknown Sat Jun 21 03:29:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54410: One cl-defgeneric in xref.el should be cl-defmethod Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Mar 2022 12:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54410 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dmitry Gutov Cc: p.stephani2@gmail.com, 54410@debbugs.gnu.org Received: via spool by 54410-submit@debbugs.gnu.org id=B54410.16474339145251 (code B ref 54410); Wed, 16 Mar 2022 12:32:01 +0000 Received: (at 54410) by debbugs.gnu.org; 16 Mar 2022 12:31:54 +0000 Received: from localhost ([127.0.0.1]:50497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUSok-0001Md-El for submit@debbugs.gnu.org; Wed, 16 Mar 2022 08:31:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUSoj-0001MQ-1k for 54410@debbugs.gnu.org; Wed, 16 Mar 2022 08:31:53 -0400 Received: from [2001:470:142:3::e] (port=58952 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUSod-0002TT-M0; Wed, 16 Mar 2022 08:31:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+at4AHcV39JaaSfkhE19h9qqzpLq9bj5pJnRspj3tJ0=; b=sb1WVEHtqe7f P866hSHT2oWGsNS8LJnSsRFBN0ocPi/rswApZWkrTqUCEhGBb7MVgtOqX/dVuS/fFd4IIAwVFhgZU JITvOaQ2a30nOeqk8Zk9nGpNP5YzR1piXtCgAEMGjxnKegxr9TSmI83magU+t8+BqWiXCecNaMsiT TVcxAMKDLG3dPdbsWSjF7AvR9c4ME7gqNVDI/8bzKg/v1HF8wcOqoLt7KmvugGuT2Goa1YbTgu0hl FNr1j6lHxtuxuUP3NJLcjyM9YFKZFkYrOiN8AXmY2w7r2CXqzOgaqB08sMSSfoTtvBCXBwU4K4EI7 +6HxzEmwZNBc1OfoYBia2w==; Received: from [87.69.77.57] (port=4433 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUSoc-0002L4-V3; Wed, 16 Mar 2022 08:31:47 -0400 Date: Wed, 16 Mar 2022 14:31:39 +0200 Message-Id: <834k3yhydw.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Dmitry Gutov on Wed, 16 Mar 2022 14:14:38 +0200) References: <838rtainhy.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 16 Mar 2022 14:14:38 +0200 > Cc: 54410@debbugs.gnu.org > From: Dmitry Gutov > > On 16.03.2022 05:29, Eli Zaretskii wrote: > > What problems are caused by the current code? > > I think it will cause no change in observable behavior, it's closer to > the realm of better documentation. Thanks, but that's not exactly what I asked. From unknown Sat Jun 21 03:29:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54410: One cl-defgeneric in xref.el should be cl-defmethod Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Mar 2022 11:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54410 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dmitry Gutov Cc: Eli Zaretskii , Philipp Stephani , 54410@debbugs.gnu.org Received: via spool by 54410-submit@debbugs.gnu.org id=B54410.164751490630867 (code B ref 54410); Thu, 17 Mar 2022 11:02:01 +0000 Received: (at 54410) by debbugs.gnu.org; 17 Mar 2022 11:01:46 +0000 Received: from localhost ([127.0.0.1]:53186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUnt4-00081Z-8f for submit@debbugs.gnu.org; Thu, 17 Mar 2022 07:01:46 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUnt1-0007vF-6J for 54410@debbugs.gnu.org; Thu, 17 Mar 2022 07:01:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1GDKD2X+2h/UyuM6bhSakDPyFRyyRGwIHNRDQK/hQMg=; b=qp4mGCEupAxjpl7c3fxmw/z7/H wOWRgBLIL+GOyheIaFhZKvj6tn2QDgrWYTB9kkAZMjl8KRfJULQLTYwN3pyvSKVSQJsl3iq75pPE2 jpOGQQakNaWh4b2T9NFkdrIfLb6T8FlFESICygtnzkv1gUkghLKwZNgN9b4ZpBcv38hw=; Received: from 109.179.236.69.tmi.telenormobil.no ([109.179.236.69] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUnst-0006OT-8y; Thu, 17 Mar 2022 12:01:37 +0100 From: Lars Ingebrigtsen References: <838rtainhy.fsf@gnu.org> Date: Thu, 17 Mar 2022 12:01:34 +0100 In-Reply-To: (Dmitry Gutov's message of "Wed, 16 Mar 2022 14:14:38 +0200") Message-ID: <877d8svo4x.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > I think it will cause no change in observable behavior, it's closer to > the realm of better documentation. > > The change should be very safe accordingly, though. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Dmitry Gutov writes: > I think it will cause no change in observable behavior, it's closer to > the realm of better documentation. > > The change should be very safe accordingly, though. I think it would be better to push it to master. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sat Jun 21 03:29:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54410: One cl-defgeneric in xref.el should be cl-defmethod Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Mar 2022 11:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54410 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: Philipp Stephani , 54410@debbugs.gnu.org Received: via spool by 54410-submit@debbugs.gnu.org id=B54410.164751620910980 (code B ref 54410); Thu, 17 Mar 2022 11:24:01 +0000 Received: (at 54410) by debbugs.gnu.org; 17 Mar 2022 11:23:29 +0000 Received: from localhost ([127.0.0.1]:53205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUoE4-0002r2-RP for submit@debbugs.gnu.org; Thu, 17 Mar 2022 07:23:28 -0400 Received: from mail-ej1-f46.google.com ([209.85.218.46]:38879) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUoE3-0002qp-77 for 54410@debbugs.gnu.org; Thu, 17 Mar 2022 07:23:27 -0400 Received: by mail-ej1-f46.google.com with SMTP id r13so10005770ejd.5 for <54410@debbugs.gnu.org>; Thu, 17 Mar 2022 04:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=JIhS+03UAvlfcNlBH9HnTXaYLDXMgt0Q9wnipz20psI=; b=kymhf/hWXuJ7VrUC2NYYCAI5KgKY+OPYl/3bWgkwQ/0sMbNEhi/NgFEjEPOBDOJ7n/ T6FlW0xLJYXIL3k6MrsxleT1ROGJsxe09MSCu2dfNXVjkA44zGZhUis+6PAJtWb1W8Pw XUIPuJQL9GB/R7xQRHAt7cqXmFTOPATuE50/6cqmikjuGHHayXmN37gJjibpu22QGNTu 3YC7Qdl2GT6Fq0Bmviw3x4N80cKSd6nr841FPaMLx/h+pbvmFFcuGaAyPOMiA7JHgPLJ SIpAxZ/cGrUpGrIrRXC4HTEZ90GVWnlcDCVZRfNp65TDu7MhzAiKT/VPsMJqRcUCLX8u WJXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=JIhS+03UAvlfcNlBH9HnTXaYLDXMgt0Q9wnipz20psI=; b=sVF7uVniwRYQZ2r+AlZczo9pHTBaeHjal6fUE2CaEhtPRMGlAlPYWzQYr0GCSN5Zid tue9w4iB0oZZkXR7voaa2wPgdMaRAVgBGqtaCd6RI0rxcrbBMcemF5VGIN19DC3O94qG VsgM5zNNjfRUknSDpCoNGeB8xNPB7kXR/mS9g+Henyo4Bn4xtq7Dg11q+BoYv2/YHfn4 D1SKS97J7mh0+JXrMr3lqDbGxrs4hWcFuOdLxjl+dNxoNqwvw4PMpd743PNDG/Nx+uFm xgrm0wmkNFe+UNePnl1i4LsUlvXLOdUuWi901aKKX15pH3rVyqlqfi6GZjR4AtIQSmma dKwA== X-Gm-Message-State: AOAM533iSk/H9fSagK3Xj35l/eIfK87VwAw0mfF8Sh5/MzITpb9Jd6hx ItmWdSiLtSEmLB/hYnC0jmE= X-Google-Smtp-Source: ABdhPJwGCshUB3bBzF3zNaJBPDnu42w2k8jQdmYi+8Wv11A1LBvdYclkjdzBDQ1XTnvrnqz8rQvpjQ== X-Received: by 2002:a17:907:2d0a:b0:6df:8bc8:236f with SMTP id gs10-20020a1709072d0a00b006df8bc8236fmr3412545ejc.527.1647516201094; Thu, 17 Mar 2022 04:23:21 -0700 (PDT) Received: from [192.168.236.48] ([173.237.64.48]) by smtp.googlemail.com with ESMTPSA id z7-20020a05640240c700b00416cee953dasm2555380edb.24.2022.03.17.04.23.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Mar 2022 04:23:20 -0700 (PDT) Message-ID: <57e6fc21-1e88-c114-63a4-0b405383b24b@yandex.ru> Date: Thu, 17 Mar 2022 13:23:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US References: <838rtainhy.fsf@gnu.org> <877d8svo4x.fsf@gnus.org> From: Dmitry Gutov In-Reply-To: <877d8svo4x.fsf@gnus.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 17.03.2022 13:01, Lars Ingebrigtsen wrote: > I think it would be better to push it to master. Fine with me. From unknown Sat Jun 21 03:29:45 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Philipp Stephani Subject: bug#54410: closed (Re: bug#54410: One cl-defgeneric in xref.el should be cl-defmethod) Message-ID: References: X-Gnu-PR-Message: they-closed 54410 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 54410@debbugs.gnu.org Date: Thu, 17 Mar 2022 12:09:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1647518942-32629-1" This is a multi-part message in MIME format... ------------=_1647518942-32629-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #54410: One cl-defgeneric in xref.el should be cl-defmethod which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 54410@debbugs.gnu.org. --=20 54410: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D54410 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1647518942-32629-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 54410-done) by debbugs.gnu.org; 17 Mar 2022 12:08:17 +0000 Received: from localhost ([127.0.0.1]:53414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUovK-0008TB-2i for submit@debbugs.gnu.org; Thu, 17 Mar 2022 08:08:17 -0400 Received: from mail-oo1-f41.google.com ([209.85.161.41]:42620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUovJ-0008Sz-A2 for 54410-done@debbugs.gnu.org; Thu, 17 Mar 2022 08:08:09 -0400 Received: by mail-oo1-f41.google.com with SMTP id s203-20020a4a3bd4000000b003191c2dcbe8so6121291oos.9 for <54410-done@debbugs.gnu.org>; Thu, 17 Mar 2022 05:08:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=mlIRGiuNKdajABQf0snuriAf9GUOSlXp8LO+PaB0LN4=; b=HFnznij+x37oasMCk53EN/f6CCJkuQDKZ0dRZftwsfn0eRxrpSbavnM3KqZ4pRyePw 2T/pIHvimvCFx7UBjCU5yf5uhAECVgMeRr7kr159mSTR9xEYB4J253Tew7wq6hNpIB+Z qwnmzfAmLrvYi4eecIRIcFL0Cl905k8PfGPoj+g5lBIbcvFPVQ5YauiDoL0SmNS9e3Ka x8SwRpNIBk1xbhHGqjVkmxq6FM3jF0uU0/SCbmzpWMrX8T4+ybk+dlYMUSnamKTjCxw+ 14zv1tNHgEhqlZm+bhW5LdQKsiYiWls+lVuq/k+1O5BlIK7bJhQPhf7RgWtWpnQXvKH4 UAAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=mlIRGiuNKdajABQf0snuriAf9GUOSlXp8LO+PaB0LN4=; b=hGH+xt8YM6MfVBTOFkj+wgvH8vWrTqvEHh3fl+cpGdIHHkdwNvI/YM/pSfV72EEG0F niyHILHjoMDr4j42O8o9nqNVPacj2QioGbvdckpMibmxFcbY+cZv+eQK6NbZtw6996EZ 6dTEbOa82Go9XjgVMpQQc8GFEtMrXf7UU7J9Njr7L7/oYwxhuBdcfAgpJVwDL+ct/y4S kkkP+Iw6cxniQdiYkM5vDp5rIzQdyx5Ogm1WDnJSTgUl6elsOLtQy50PX92Byfp+uXlN V3Ob9fCQtFCa67RzDGzBy6Dlo3vSZZ2CLlvACwlEoLYdEK6zkMGZJyMtXaHyS4WcJTe9 gK+A== X-Gm-Message-State: AOAM533miYrIWAWt63BrF03etakQsYmNX8zZP0YEqrP3fNRQmwbqjIm3 7esYd14LFuM6JUjawsKFEBvkCA3W72MTfs1ERRA= X-Google-Smtp-Source: ABdhPJx1GT91KNDBZjHUWKHcPIRM+ra8EU2Yq8lnKbobRNwnDfuWAey2AQlT0iL8qxQLiSQeQVCm+oQu4+d64+z8KqA= X-Received: by 2002:a05:6870:1605:b0:dd:a358:61b with SMTP id b5-20020a056870160500b000dda358061bmr3139822oae.134.1647518883459; Thu, 17 Mar 2022 05:08:03 -0700 (PDT) MIME-Version: 1.0 References: <838rtainhy.fsf@gnu.org> In-Reply-To: <838rtainhy.fsf@gnu.org> From: Philipp Stephani Date: Thu, 17 Mar 2022 13:07:52 +0100 Message-ID: Subject: Re: bug#54410: One cl-defgeneric in xref.el should be cl-defmethod To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 54410-done Cc: 54410-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Mi., 16. M=C3=A4rz 2022 um 04:29 Uhr schrieb Eli Zaretskii : > > > From: Philipp Stephani > > Date: Wed, 16 Mar 2022 00:09:23 +0100 > > > > Is the following patch good for the release branch? > > What problems are caused by the current code? I'm using Edebug for coverage instrumentation, and that only works right in an automated way if there are no duplicate instrumented symbols, because Edebug attaches coverage information to individual symbols. cl-defmethod takes care of this by generating additional symbols, but cl-defgeneric doesn't. > > In general, I'd prefer to leave the release branch alone at this time, > so we could release Emacs 28.1 soon. It seems quite ready. Fine with me, I've pushed it to master as commit 6ed3f04e5a3c8aee40a26805bb00cdd070eba319. ------------=_1647518942-32629-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 Mar 2022 23:09:33 +0000 Received: from localhost ([127.0.0.1]:49813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUGIG-0006AD-ML for submit@debbugs.gnu.org; Tue, 15 Mar 2022 19:09:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:39902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUGIF-0006A3-8Y for submit@debbugs.gnu.org; Tue, 15 Mar 2022 19:09:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUGIF-0007Ha-3f for bug-gnu-emacs@gnu.org; Tue, 15 Mar 2022 19:09:31 -0400 Received: from [2a00:1450:4864:20::62a] (port=33365 helo=mail-ej1-x62a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nUGID-0005Ha-JF for bug-gnu-emacs@gnu.org; Tue, 15 Mar 2022 19:09:30 -0400 Received: by mail-ej1-x62a.google.com with SMTP id pv16so836137ejb.0 for ; Tue, 15 Mar 2022 16:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version; bh=jJrWyVkF6JQomhaQSze4k1PeZzwYmpXFmVD6jWSU920=; b=mrwB+h17Xo17BhXKlZTY2+Fyg2kvhjYA6dqER3sn/N8lDKCKqC1cK0e9f5p5RetQ2S a5s97Zrg59r6BgvboIkwEOHk64boB4LfHXvSw9KzJ9qMIO6JAshZ7eR9Ab81xMH/i/4k wM8yF95bxEvwkd+u2wXFVqDDuPm1pyhUHVxsHRx4+iuLA66+PfPW+x9Ff9vi9QLY3ZSt 8hJ+06nTV4u5Tn1OjVJTLVa0po4i/55ZnKLRnYzRD0gCh0tRw1QI1sisAB4+01FfOt82 uo7SH7KLAF7OYc6g+WFnfODbcbLWL+VFkJ8/6Y21rHCk7Vtqmown5A087p+gXvYQezLz LRcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=jJrWyVkF6JQomhaQSze4k1PeZzwYmpXFmVD6jWSU920=; b=lZCjDbXW9dkRXGGvEb/VhrsHvj9k0XCB5GJa1gvvQpOfeLQGgbZN1AylipLy11C6Jn kEtlKgf2BMiFKR5hu2QyNLMczIkHwTnjDfqu5bx4aMzWWM2bcwQIMIBRNdBh3w3hb+lx gh0O+xM8Ob7dqazaotpbk9fMqC9XWwQcseyKrbIdzF1dmoetJw14TSMpo5VMGhPXhzoQ 0AYKmypGTkOqeeb5lZikucSNienA9D3dS8NTQ6APQjnyaTQmntI0QKq277mi9L0ClEz6 pbO4/8E2VLN5NjMZ0YgXGOKA7q2BAR8cyvuYk5Z2hSfHdZfbD8A/MDg0CcXFMQKeDQ2T obQw== X-Gm-Message-State: AOAM531qtFIrnY7iQ9lyVfpvUI9cugaZVADYNImDP+am7hXKcYHwn1mv miRrkD8YRmvq0YDCJU+qL7LmK3LzEUo= X-Google-Smtp-Source: ABdhPJzUnF+39sdElLpT5xxbI0KvXXnrAqwWKuF4XdOVl4bvIw/Y8Pe8Er4srqSiBSjyFuRlI3mlgw== X-Received: by 2002:a17:906:c048:b0:6ce:a6f5:b23a with SMTP id bm8-20020a170906c04800b006cea6f5b23amr24235353ejb.350.1647385767201; Tue, 15 Mar 2022 16:09:27 -0700 (PDT) Received: from phst ([2a02:2455:2a4:dc00:7dd1:b754:ae65:7605]) by smtp.gmail.com with ESMTPSA id m21-20020a17090677d500b006df766974basm162347ejn.3.2022.03.15.16.09.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Mar 2022 16:09:26 -0700 (PDT) From: Philipp Stephani To: bug-gnu-emacs@gnu.org Subject: One cl-defgeneric in xref.el should be cl-defmethod Date: Wed, 16 Mar 2022 00:09:23 +0100 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::62a (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=p.stephani2@gmail.com; helo=mail-ej1-x62a.google.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Tags: patch Is the following patch good for the release branch? In GNU Emacs 28.0.92 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.31, cairo version 1.16.0) of 2022-03-14 Repository revision: 8e7a3f21e00649bacc01be627edd45ff01b51a33 Repository branch: emacs-28 [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (p.stephani2[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (p.stephani2[at]gmail.com) 0.0 RCVD_IN_MSPIKE_H5 RBL: Excellent reputation (+5) [209.51.188.17 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. 1.5 SPOOFED_FREEMAIL No description available. 0.8 SPOOF_GMAIL_MID From Gmail but it doesn't seem to be... X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain Tags: patch Is the following patch good for the release branch? In GNU Emacs 28.0.92 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.31, cairo version 1.16.0) of 2022-03-14 Repository revision: 8e7a3f21e00649bacc01be627edd45ff01b51a33 Repository branch: emacs-28 Windowing system distributor 'The X.Org Foundation', version 11.0.12014000 System Description: Debian GNU/Linux rodete Configured using: 'configure --enable-gcc-warnings=warn-only --enable-gtk-deprecation-warnings --without-pop --with-mailutils --enable-checking=all --enable-check-lisp-object-type --with-modules 'CFLAGS=-O0 -ggdb3'' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=xref-defmethod.patch diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 2fd5e19237..aefee31897 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -220,7 +220,7 @@ xref-location-group "A match xref item describes a search result." length) -(cl-defgeneric xref-match-length ((item xref-match-item)) +(cl-defmethod xref-match-length ((item xref-match-item)) "Return the length of the match." (xref-match-item-length item)) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Liana Sebastian Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Falls Sie diese f=C3=A4lschlicherweise erhal= ten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, l=C3=B6sche= n Sie alle Kopien und Anh=C3=A4nge davon und lassen Sie mich bitte wissen, dass d= ie E-Mail an die falsche Person gesendet wurde. This e-mail is confidential. If you received this communication by mistake, please don=E2=80=99t forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. --=-=-=-- ------------=_1647518942-32629-1--