GNU bug report logs - #54410
One cl-defgeneric in xref.el should be cl-defmethod

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54410 in the body.
You can then email your comments to 54410 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: One cl-defgeneric in xref.el should be cl-defmethod
Date: Wed, 16 Mar 2022 00:09:23 +0100

[Message part 1 (text/plain, inline)]

Tags: patch

Is the following patch good for the release branch?



In GNU Emacs 28.0.92 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.31, cairo version 1.16.0)
 of 2022-03-14
Repository revision: 8e7a3f21e00649bacc01be627edd45ff01b51a33
Repository branch: emacs-28
Windowing system distributor 'The X.Org Foundation', version 11.0.12014000
System Description: Debian GNU/Linux rodete

Configured using:
 'configure --enable-gcc-warnings=warn-only
 --enable-gtk-deprecation-warnings --without-pop --with-mailutils
 --enable-checking=all --enable-check-lisp-object-type --with-modules
 'CFLAGS=-O0 -ggdb3''

[xref-defmethod.patch (text/patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Geschäftsführer: Paul Manicle, Liana Sebastian
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich.  Falls Sie diese fälschlicherweise erhalten haben
sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie
alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail
an die falsche Person gesendet wurde.

This e-mail is confidential.  If you received this communication by mistake,
please don’t forward it to anyone else, please erase all copies and
attachments, and please let me know that it has gone to the wrong person.

Message #8 received at 54410 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 54410 <at> debbugs.gnu.org
Subject: Re: bug#54410: One cl-defgeneric in xref.el should be cl-defmethod
Date: Wed, 16 Mar 2022 05:29:13 +0200

> From: Philipp Stephani <p.stephani2 <at> gmail.com>
> Date: Wed, 16 Mar 2022 00:09:23 +0100
> 
> Is the following patch good for the release branch?

What problems are caused by the current code?

In general, I'd prefer to leave the release branch alone at this time,
so we could release Emacs 28.1 soon.  It seems quite ready.

Message #11 received at 54410 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Eli Zaretskii <eliz <at> gnu.org>, Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 54410 <at> debbugs.gnu.org
Subject: Re: bug#54410: One cl-defgeneric in xref.el should be cl-defmethod
Date: Wed, 16 Mar 2022 14:14:38 +0200

On 16.03.2022 05:29, Eli Zaretskii wrote:
> What problems are caused by the current code?

I think it will cause no change in observable behavior, it's closer to 
the realm of better documentation.

The change should be very safe accordingly, though.

Message #14 received at 54410 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: p.stephani2 <at> gmail.com, 54410 <at> debbugs.gnu.org
Subject: Re: bug#54410: One cl-defgeneric in xref.el should be cl-defmethod
Date: Wed, 16 Mar 2022 14:31:39 +0200

> Date: Wed, 16 Mar 2022 14:14:38 +0200
> Cc: 54410 <at> debbugs.gnu.org
> From: Dmitry Gutov <dgutov <at> yandex.ru>
> 
> On 16.03.2022 05:29, Eli Zaretskii wrote:
> > What problems are caused by the current code?
> 
> I think it will cause no change in observable behavior, it's closer to 
> the realm of better documentation.

Thanks, but that's not exactly what I asked.

Message #17 received at 54410 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Philipp Stephani <p.stephani2 <at> gmail.com>,
 54410 <at> debbugs.gnu.org
Subject: Re: bug#54410: One cl-defgeneric in xref.el should be cl-defmethod
Date: Thu, 17 Mar 2022 12:01:34 +0100

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> I think it will cause no change in observable behavior, it's closer to
> the realm of better documentation.
>
> The change should be very safe accordingly, though.

I think it would be better to push it to master.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #20 received at 54410 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Philipp Stephani <p.stephani2 <at> gmail.com>, 54410 <at> debbugs.gnu.org
Subject: Re: bug#54410: One cl-defgeneric in xref.el should be cl-defmethod
Date: Thu, 17 Mar 2022 13:23:18 +0200

On 17.03.2022 13:01, Lars Ingebrigtsen wrote:
> I think it would be better to push it to master.

Fine with me.

Message #25 received at 54410-done <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 54410-done <at> debbugs.gnu.org
Subject: Re: bug#54410: One cl-defgeneric in xref.el should be cl-defmethod
Date: Thu, 17 Mar 2022 13:07:52 +0100

Am Mi., 16. März 2022 um 04:29 Uhr schrieb Eli Zaretskii <eliz <at> gnu.org>:
>
> > From: Philipp Stephani <p.stephani2 <at> gmail.com>
> > Date: Wed, 16 Mar 2022 00:09:23 +0100
> >
> > Is the following patch good for the release branch?
>
> What problems are caused by the current code?

I'm using Edebug for coverage instrumentation, and that only works
right in an automated way if there are no duplicate instrumented
symbols, because Edebug attaches coverage information to individual
symbols. cl-defmethod takes care of this by generating additional
symbols, but cl-defgeneric doesn't.

>
> In general, I'd prefer to leave the release branch alone at this time,
> so we could release Emacs 28.1 soon.  It seems quite ready.

Fine with me, I've pushed it to master as commit
6ed3f04e5a3c8aee40a26805bb00cdd070eba319.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.