From unknown Fri Jun 20 07:29:05 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#54369 <54369@debbugs.gnu.org> To: bug#54369 <54369@debbugs.gnu.org> Subject: Status: 28.0.92; [PATCH] Fix negated argument predicates in Eshell Reply-To: bug#54369 <54369@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:29:05 +0000 retitle 54369 28.0.92; [PATCH] Fix negated argument predicates in Eshell reassign 54369 emacs submitter 54369 Jim Porter severity 54369 normal tag 54369 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 13 01:34:26 2022 Received: (at submit) by debbugs.gnu.org; 13 Mar 2022 06:34:26 +0000 Received: from localhost ([127.0.0.1]:41511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTHoA-0000ye-Jo for submit@debbugs.gnu.org; Sun, 13 Mar 2022 01:34:26 -0500 Received: from lists.gnu.org ([209.51.188.17]:45780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTHo8-0000yU-1l for submit@debbugs.gnu.org; Sun, 13 Mar 2022 01:34:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTHo7-0008Ev-Px for bug-gnu-emacs@gnu.org; Sun, 13 Mar 2022 01:34:23 -0500 Received: from [2607:f8b0:4864:20::1036] (port=43661 helo=mail-pj1-x1036.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nTHo3-0005rA-70 for bug-gnu-emacs@gnu.org; Sun, 13 Mar 2022 01:34:23 -0500 Received: by mail-pj1-x1036.google.com with SMTP id z12-20020a17090ad78c00b001bf022b69d6so11718429pju.2 for ; Sat, 12 Mar 2022 22:34:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:subject:to:message-id:date:mime-version:content-language; bh=wiVvmuGeZPome4+pY//GyOAEZuedUDV2CBggqFUIVIQ=; b=iEiBA5OcCpYCiDth1zKD6Qphq6OPq5z1CYj85iQzZciAZlWITFuhC2p4zSbMhiwk/G JtuaE+LwqPLqmvNFXHJ9zE5/mAkxxfbm0kf+nI+u0mf8tfgEDOHbAlUbNs77i8FIDZ5S bUGDKHuZ3+bJxdDAeewyOKkkjD9+QgI9EaNEQfY7vIEp4PUSIKdsqNtxmnCUiNPzNzt3 2jxd9d2r0vZqJAKAROkdSsU2y6rHr5b4/EdVtxAQqKjTvYN89QZT5uvcZws7Aow+BjEj m8UuubIc9rfIRXsy3Y2AEUWHAbWI1NuZcyeEFJ9MOr4KtjsaE522sH7u16xihXutx0ys uLCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:subject:to:message-id:date:mime-version :content-language; bh=wiVvmuGeZPome4+pY//GyOAEZuedUDV2CBggqFUIVIQ=; b=OJ8RMTO2dMxe8eQdpadKq5OcVr/TtQ33fQeUiGydRv6/x9n2BqMqCdsPBSKGng0fye WbLj1hnMr/F3YtIQDLLcdftwfTB4LleImPT6klbJDBDR8Y1ZfJLyoQ+JbJfxiV8SjQbl FvRAXgbH0WzqA9olgowZ4oGmkYkTw1UxgM/QPU9Pd/xXrAjoNKEGigw144GwQo7Inv8l agBG/rEDqMGWWXulWuUN45+36wI38oOWi6xZ6wNibgXMOKawWPAQcg7QrUztqDVO9zv1 FCA5NkkmSk7WU29vE6O52vJtc7NFAV4uln0rk/IN154edmuxi8bGVed48xyy81n4pez2 AwQQ== X-Gm-Message-State: AOAM533r4GhGw4j9+mekbO/VuiFMJVf0W+p7MGlgn7nRaeO4OEe5+8tg Ac9LPhlUT8qPt3Sxf/UpjPEOfrDvUF0= X-Google-Smtp-Source: ABdhPJxWD2k6eaHWMTFD8tglXdy33AF2YlJahIR9SjMRVwKnm3XwnTHiFN2zjerqnUSLjlQQyJZNYw== X-Received: by 2002:a17:90a:da02:b0:1bf:3919:f2a with SMTP id e2-20020a17090ada0200b001bf39190f2amr29952616pjv.208.1647153257466; Sat, 12 Mar 2022 22:34:17 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id j9-20020a056a00234900b004f6fe0f4cb2sm16434456pfj.14.2022.03.12.22.34.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 12 Mar 2022 22:34:16 -0800 (PST) X-Mozilla-News-Host: news://news.gmane.org:119 From: Jim Porter Subject: 28.0.92; [PATCH] Fix negated argument predicates in Eshell To: bug-gnu-emacs@gnu.org Message-ID: Date: Sat, 12 Mar 2022 22:34:16 -0800 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------7798AA77D445BFD4B84413C4" Content-Language: en-US X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::1036 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::1036; envelope-from=jporterbugs@gmail.com; helo=mail-pj1-x1036.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------7798AA77D445BFD4B84413C4 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit From "emacs -Q --eval '(eshell)'": ~ $ echo *(^.) Lisp nesting exceeds ‘max-lisp-eval-depth’ On Emacs 27, this correctly prints a list of everything in the current directory *except* for regular files. ("*" matches all files, "()" specifies an argument predicate, "." says "match regular files", and "^" says "invert that logic".) I think this is due to the lexical binding change in 28. Attached is a patch to fix this. No unit tests right now, but I'm working on a patch for 29 with full unit tests for Eshell globs and argument predicates/modifiers. (I pulled this bit out of my branch for that, since it's a regression that should probably get fixed in 28.) Regarding the patch itself, I'm not sure if there's a cleaner way to do this; it feels like there should be, but this is the only way I could think of off-hand to fix it. --------------7798AA77D445BFD4B84413C4 Content-Type: text/plain; charset=UTF-8; name="0001-Fix-evaluation-of-negated-argument-predicates-in-Esh.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Fix-evaluation-of-negated-argument-predicates-in-Esh.pa"; filename*1="tch" RnJvbSAwOGMxZmQzNTQ5MGUyMDVhNzcwNmM5NGVhY2YxMjk2OGI4MjUzYzAyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFNhdCwgMTIgTWFyIDIwMjIgMjI6MTQ6MTkgLTA4MDAKU3ViamVjdDogW1BB VENIXSBGaXggZXZhbHVhdGlvbiBvZiBuZWdhdGVkIGFyZ3VtZW50IHByZWRpY2F0ZXMgaW4g RXNoZWxsCgoqIGxpc3AvZXNoZWxsL2VtLXByZWQuZWwgKGVzaGVsbC1hZGQtcHJlZC1mdW5j KTogTGV0LWJpbmQgJ3ByZWQnIHNvCnRoZSBsYW1iZGFzIHNlZSB0aGUgb3JpZ2luYWwgdmFs dWUuCi0tLQogbGlzcC9lc2hlbGwvZW0tcHJlZC5lbCB8IDEyICsrKysrKy0tLS0tLQogMSBm aWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9saXNwL2VzaGVsbC9lbS1wcmVkLmVsIGIvbGlzcC9lc2hlbGwvZW0tcHJlZC5lbApp bmRleCAyMTZjNzFmNTllLi45NzAzMjllMTJhIDEwMDY0NAotLS0gYS9saXNwL2VzaGVsbC9l bS1wcmVkLmVsCisrKyBiL2xpc3AvZXNoZWxsL2VtLXByZWQuZWwKQEAgLTM2MCwxMiArMzYw LDEyIEBAIGVzaGVsbC1wYXJzZS1tb2RpZmllcnMKIAogKGRlZnVuIGVzaGVsbC1hZGQtcHJl ZC1mdW5jIChwcmVkIGZ1bmNzIG5lZ2F0ZSBmb2xsb3cpCiAgICJBZGQgdGhlIHByZWRpY2F0 ZSBmdW5jdGlvbiBQUkVEIHRvIEZVTkNTLiIKLSAgKGlmIG5lZ2F0ZQotICAgICAgKHNldHEg cHJlZCAobGFtYmRhIChmaWxlKQotCQkgICAobm90IChmdW5jYWxsIHByZWQgZmlsZSkpKSkp Ci0gIChpZiBmb2xsb3cKLSAgICAgIChzZXRxIHByZWQgKGxhbWJkYSAoZmlsZSkKLQkJICAg KGZ1bmNhbGwgcHJlZCAoZmlsZS10cnVlbmFtZSBmaWxlKSkpKSkKKyAgKHdoZW4gbmVnYXRl CisgICAgKHNldHEgcHJlZCAobGV0ICgocHJlZCBwcmVkKSkKKyAgICAgICAgICAgICAgICAg KGxhbWJkYSAoZmlsZSkgKG5vdCAoZnVuY2FsbCBwcmVkIGZpbGUpKSkpKSkKKyAgKHdoZW4g Zm9sbG93CisgICAgKHNldHEgcHJlZCAobGV0ICgocHJlZCBwcmVkKSkKKyAgICAgICAgICAg ICAgICAgKGxhbWJkYSAoZmlsZSkgKGZ1bmNhbGwgcHJlZCAoZmlsZS10cnVlbmFtZSBmaWxl KSkpKSkpCiAgIChjb25zIHByZWQgZnVuY3MpKQogCiAoZGVmdW4gZXNoZWxsLXByZWQtdXNl ci1vci1ncm91cCAobW9kLWNoYXIgbW9kLXR5cGUgYXR0ci1pbmRleCBnZXQtaWQtZnVuYykK LS0gCjIuMjUuMQoK --------------7798AA77D445BFD4B84413C4-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 13 10:38:22 2022 Received: (at 54369) by debbugs.gnu.org; 13 Mar 2022 14:38:22 +0000 Received: from localhost ([127.0.0.1]:43097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTPMT-0004Gm-S1 for submit@debbugs.gnu.org; Sun, 13 Mar 2022 10:38:22 -0400 Received: from quimby.gnus.org ([95.216.78.240]:60074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTPMR-0004GR-Qu for 54369@debbugs.gnu.org; Sun, 13 Mar 2022 10:38:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BqbVXaXxy9oaeM7zzVlBem+/5bJs86azb56eT9vJCh4=; b=jQQJ8DX+Bl9E8AItOvdbEPZ0Tz bZSeHWtTYkWpr1ZtWdttBJrVaNnThnzmi4HC3Y9jZvIPtvMfCchcT2Txx/cnCC+C7aCCg+J4OhfJm fCT2a28Pqm+TQfDMR7379VmLXh+kMFJASUarTM92YyZoLJFL8vz3l43t6NSXBFZ+XfhM=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nTPMI-0003PV-M8; Sun, 13 Mar 2022 15:38:12 +0100 From: Lars Ingebrigtsen To: Jim Porter Subject: Re: bug#54369: 28.0.92; [PATCH] Fix negated argument predicates in Eshell References: Date: Sun, 13 Mar 2022 15:38:09 +0100 In-Reply-To: (Jim Porter's message of "Sat, 12 Mar 2022 22:34:16 -0800") Message-ID: <877d8xvrxq.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Jim Porter writes: > I think this is due to the lexical binding change in 28. Attached is a > patch to fix this. No unit tests right now, but I'm working on a patch > for 29 with full unit tests for Eshell globs and arg [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54369 Cc: 54369@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jim Porter writes: > I think this is due to the lexical binding change in 28. Attached is a > patch to fix this. No unit tests right now, but I'm working on a patch > for 29 with full unit tests for Eshell globs and argument > predicates/modifiers. (I pulled this bit out of my branch for that, > since it's a regression that should probably get fixed in 28.) Yup. Pushed to emacs-28 now. > Regarding the patch itself, I'm not sure if there's a cleaner way to > do this; it feels like there should be, but this is the only way I > could think of off-hand to fix it. It looks like the most obvious minimal way to fix this to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 13 10:38:25 2022 Received: (at control) by debbugs.gnu.org; 13 Mar 2022 14:38:25 +0000 Received: from localhost ([127.0.0.1]:43100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTPMX-0004H2-2A for submit@debbugs.gnu.org; Sun, 13 Mar 2022 10:38:25 -0400 Received: from quimby.gnus.org ([95.216.78.240]:60088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTPMV-0004GY-Od for control@debbugs.gnu.org; Sun, 13 Mar 2022 10:38:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Pgu8H6S0/NEQHWOE0cVrAbX7rP+ttJyPmcVz/W1sxjQ=; b=rk7gAe5Tcd4t9O5vEVf0CG2i/Z /pjNHicaD/tUMRhihQWaRcq2iDJL1okMHBfeAvtMn9MawnFOErOiY1IJx/UaWzUKXwIqJA2Wq4eGE 0kjz5PBr7wKNGT6KuU3PWoOQrpbwKzYCM7MLRk2xFS1R+J9i5G12495gMxcwL5smukU0=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nTPMO-0003Pd-09 for control@debbugs.gnu.org; Sun, 13 Mar 2022 15:38:17 +0100 Date: Sun, 13 Mar 2022 15:38:15 +0100 Message-Id: <875yohvrxk.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #54369 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 54369 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 54369 29.1 quit From unknown Fri Jun 20 07:29:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 11 Apr 2022 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator