GNU bug report logs - #54362
[PATCH] gnu: cl-find-port: Update to 20190601.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54362 in the body.
You can then email your comments to 54362 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: cl-find-port: Update to 20190601.
Date: Sat, 12 Mar 2022 18:18:08 -0500

* gnu/packages/lisp-xyz.scm (cl-find-port): Update to 20190601.
[version]: Use git-version function with date of commit.
---
 gnu/packages/lisp-xyz.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index fc18742e3c..53aa9c6ae5 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -5120,12 +5120,12 @@ (define-public cl-verbose
   (sbcl-package->cl-source-package sbcl-verbose))
 
 (define-public sbcl-find-port
-  (let ((commit "00c96a25af93a0f8681d34ec548861f2d7485478")
-        (revision "1"))
+  (let ((commit "811727f88d7f000623bf92fdb0e64678a7112a28")
+        (revision "2"))
     (package
       (name "sbcl-find-port")
       (build-system asdf-build-system/sbcl)
-      (version "0.1")
+      (version (git-version "20190601" revision commit))
       (home-page "https://github.com/eudoxia0/find-port")
       (source
        (origin
@@ -5136,7 +5136,7 @@ (define-public sbcl-find-port
          (file-name (git-file-name name version))
          (sha256
           (base32
-           "0d6dzbb45jh0rx90wgs6v020k2xa87mvzas3mvfzvivjvqqlpryq"))))
+           "1fw6q7d2bxxb7fqk548ylq8mx4sz95yc0q5h0rwd0mnqjrbwbari"))))
       (native-inputs
        (list sbcl-fiveam))
       (inputs
-- 
2.35.1

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: jgart <jgart <at> dismail.de>, jgart via Guix-patches via <guix-patches <at> gnu.org>,
 54362 <at> debbugs.gnu.org
Subject: Re: [bug#54362] [PATCH] gnu: cl-find-port: Update to 20190601.
Date: Sat, 12 Mar 2022 23:27:09 +0000

On 12 March 2022 23:18:08 UTC, jgart via Guix-patches via <guix-patches <at> gnu.org> wrote:
> (define-public sbcl-find-port
>-  (let ((commit "00c96a25af93a0f8681d34ec548861f2d7485478")
>-        (revision "1"))
>+  (let ((commit "811727f88d7f000623bf92fdb0e64678a7112a28")
>+        (revision "2"))

LGTM.

>-      (version "0.1")
>+      (version (git-version "20190601" revision commit))

Err... LNSGTM.  Why?  I can't find a justification for this upstream.

If there is one, please always add it as comment.

Otherwise, it should remain 0.1 but (indeed) with git-version which should have been there from the start.
Hi jgart,

Thanks!

T G-R

Sent on the go.  Excuse or enjoy my brevity.

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 54362 <at> debbugs.gnu.org, jgart via Guix-patches via <guix-patches <at> gnu.org>
Subject: Re: [bug#54362] [PATCH] gnu: cl-find-port: Update to 20190601.
Date: Sat, 12 Mar 2022 20:33:24 -0500

On Sat, 12 Mar 2022 23:27:09 +0000 Tobias Geerinckx-Rice <me <at> tobias.gr> wrote:
> If there is one, please always add it as comment.

Hi Tobias!

I'll make sure to add a comment in the future for packages that don't
have version numbers.

It seems like a fairly common practice in the common lisp community to
not make version releases though.

Do you need me to send a v2 with the comment?

> Otherwise, it should remain 0.1 but (indeed) with git-version which should have been there from the start.
> Hi jgart,

There's no mention of 0.1 in the current commit. Is it a Guix convention
to use 0.1 when we don't know the version of the package and only have
a particular commit?

all best,

jgart

Message #20 received at 54362 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: jgart <jgart <at> dismail.de>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, 54362 <at> debbugs.gnu.org
Subject: Re: [bug#54362] [PATCH] gnu: cl-find-port: Update to 20190601.
Date: Sun, 13 Mar 2022 08:37:34 +0000

[Message part 1 (text/plain, inline)]

jgart via Guix-patches via <guix-patches <at> gnu.org> skribis:

> There's no mention of 0.1 in the current commit. Is it a Guix convention
> to use 0.1 when we don't know the version of the package and only have
> a particular commit?

Hi,

In the "find-port.asd" file, the find-port system definition has a field
indicating ":version 0.1".

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 54362-done <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 54362-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: cl-find-port: Update to 20190601.
Date: Sun, 13 Mar 2022 04:53:03 -0400

[Message part 1 (text/plain, inline)]

I agree with T G-R. It should have been git-version from the beginning. 
Also, for packages with no releases, we usually start version and 
revision with "0", and increment revision by one for every update. Not 
sure why the version was started with "0.1", but lets keep it that way 
for now. :)

Pushed as 1a36fb51a8..f69727278b to master.

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #28 received at 54362 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 54362 <at> debbugs.gnu.org
Cc: Guillaume Le Vaillant <glv <at> posteo.net>,
 Raghav Gururajan <rg <at> raghavgururajan.name>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>, jgart <jgart <at> dismail.de>
Subject: [PATCH v2] gnu: cl-find-port: Update to 242cfc6.
Date: Sun, 13 Mar 2022 13:33:18 -0400

* gnu/packages/lisp-xyz.scm (cl-find-port): Update to 242cfc6.
[version]: Use git-version function with version stated in asd file.
---
Hi all,

Thanks for the review. It is much appreciated.

Here is a v2 of the requested changes.

Guillaume, thanks for pointing out the version number in the asd file.

That version number is from 7 years ago according to `git blame` but if
you think we should still use it that is fine with me. I think the author
is probably just not making version releases and just releasing commits.

all best,

jgart

 gnu/packages/lisp-xyz.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index fc18742e3c..b95466d93b 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -5120,12 +5120,12 @@ (define-public cl-verbose
   (sbcl-package->cl-source-package sbcl-verbose))
 
 (define-public sbcl-find-port
-  (let ((commit "00c96a25af93a0f8681d34ec548861f2d7485478")
-        (revision "1"))
+  (let ((commit "811727f88d7f000623bf92fdb0e64678a7112a28")
+        (revision "2"))
     (package
       (name "sbcl-find-port")
       (build-system asdf-build-system/sbcl)
-      (version "0.1")
+      (version (git-version "0.1" revision commit))
       (home-page "https://github.com/eudoxia0/find-port")
       (source
        (origin
@@ -5136,7 +5136,7 @@ (define-public sbcl-find-port
          (file-name (git-file-name name version))
          (sha256
           (base32
-           "0d6dzbb45jh0rx90wgs6v020k2xa87mvzas3mvfzvivjvqqlpryq"))))
+           "1fw6q7d2bxxb7fqk548ylq8mx4sz95yc0q5h0rwd0mnqjrbwbari"))))
       (native-inputs
        (list sbcl-fiveam))
       (inputs
-- 
2.35.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.