From unknown Wed Jun 18 23:06:15 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#54352 <54352@debbugs.gnu.org> To: bug#54352 <54352@debbugs.gnu.org> Subject: Status: [PATCH] services: dnsmasq: Add more options. Reply-To: bug#54352 <54352@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:06:15 +0000 retitle 54352 [PATCH] services: dnsmasq: Add more options. reassign 54352 guix-patches submitter 54352 Remco van 't Veer severity 54352 normal tag 54352 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 12 10:48:36 2022 Received: (at submit) by debbugs.gnu.org; 12 Mar 2022 15:48:36 +0000 Received: from localhost ([127.0.0.1]:40652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nT3yu-00058v-E1 for submit@debbugs.gnu.org; Sat, 12 Mar 2022 10:48:36 -0500 Received: from lists.gnu.org ([209.51.188.17]:55168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nT3ys-00058m-JQ for submit@debbugs.gnu.org; Sat, 12 Mar 2022 10:48:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nT3yr-0006N1-VG for guix-patches@gnu.org; Sat, 12 Mar 2022 10:48:34 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:43471) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nT3yp-0004fS-DA for guix-patches@gnu.org; Sat, 12 Mar 2022 10:48:33 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 7DE6C3201DA2; Sat, 12 Mar 2022 10:48:28 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sat, 12 Mar 2022 10:48:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=remworks.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm3; bh=/kXRW2Ioyy9eGbDbj+EfDDqJYqv+cmlIms5C+q M5SLE=; b=l5/UZ5PKMp/qH6s3D/5Drbz3J2wcNcT6+mD/DHhw36MeW4nLNfFFPe iod7DDDtUHqQvYFr3wX9URHYH+B/qGIO0U0R4botoVQNPNdLqNnIYH6oA5j5/UUb GgiWnauoEGcr19MaYGXmJdcPor7DsYxmD0a34XQthULCx8aa6fPNwl88EYYs7EF5 zfhup8M6QQK8KLEHMqqN+Tq9lVrBAw8fo2KAAn+9rCHESNihFDCPzhIxJsJLdaot Qejxjz9+9+QFBCi26A9lSKF/yOcaZRHxoRCQfjsJPm08zYnpfxHwLAWuVL30bIbm egRkhpo81DAaJxof6Ugwui3yIxSFU6qw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=/kXRW2 Ioyy9eGbDbj+EfDDqJYqv+cmlIms5C+qM5SLE=; b=Wc6YgvhSe39j+OXRtIM7IF BXt/XW+BJ6y6pWHAW+Xiqi4WvQtSoR/PdHXhRvAjVgC0LutwnuG2BbCvQ5z+MIQj 8N0msLUz+LnnvDY09UT09gJHY7QsNeTbdY45yvG9Is2PVGcyCVqZBOUhL9x0DKg9 9DHJCVIIfr0FBH2QyDp1SIqB4roVW3CojiIGt+UjqsDnktq0AOSLF5MGHHoVbZDr pNVVYH3XIhXQBzO7BQsgjIGJxJSUGR8Iwe3m5hAC6waxUGcMx8hZJmu25DuigXgo AeFz8X7brhXN//CMhjYlswfNfsQF/hI4HeAuop/O2j5TvDfX4lY53mzmyZejABGw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddvgedgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofggtgfgsehtkeertd ertdejnecuhfhrohhmpeftvghmtghouchvrghnucdkthcugggvvghruceorhgvmhgtohes rhgvmhifohhrkhhsrdhnvghtqeenucggtffrrghtthgvrhhnpeevfedugfefueelveeltd dtteehjefhvedvuefgueektdfhudefteekuedtgefhieenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrfihvsehfrghsthhmrghilhdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 12 Mar 2022 10:48:27 -0500 (EST) From: Remco van 't Veer To: guix-patches@gnu.org Subject: [PATCH] services: dnsmasq: Add more options. Date: Sat, 12 Mar 2022 16:48:13 +0100 Message-Id: <20220312154813.5538-1-remco@remworks.net> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=64.147.123.19; envelope-from=rwv@fastmail.com; helo=wout3-smtp.messagingengine.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: submit Cc: Remco van 't Veer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.2 (--) * gnu/services/dns.scm (): Add bogus-priv?, strict-order? and add-cpe-id options. (dnsmasq-shepherd-service): Pass bogus-priv, strict-order and add-cpe-id to the service. * doc/guix.texi (Guix Services): Document options added to dnsmasq. --- doc/guix.texi | 12 ++++++++++++ gnu/services/dns.scm | 20 +++++++++++++++++--- 2 files changed, 29 insertions(+), 3 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 4b71fb7010..136c199e58 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -28945,6 +28945,14 @@ The file to read the IP address of the upstream nameservers from. @item @code{no-resolv?} (default: @code{#f}) When true, don't read @var{resolv-file}. +@item @code{bogus-priv?} (default: @code{#f}) +When true, all reverse lookups for private IP ranges are answered with +"no such domain" rather than being forwarded upstream. + +@item @code{strict-order?} (default: @code{#f}) +When true, forces dnsmasq to try each query with each server strictly in +the order they appear in @var{servers}. + @item @code{servers} (default: @code{'()}) Specify IP address of upstream servers directly. @@ -28974,6 +28982,10 @@ disables caching. @item @code{negative-cache?} (default: @code{#t}) When false, disable negative caching. +@item @code{add-cpe-id} (default: @code{#f}) +If set, add an arbitrary identifying string to DNS queries which are +forwarded upstream. + @item @code{tftp-enable?} (default: @code{#f}) Whether to enable the built-in TFTP server. diff --git a/gnu/services/dns.scm b/gnu/services/dns.scm index 9b8603cc95..9f9b6c1a69 100644 --- a/gnu/services/dns.scm +++ b/gnu/services/dns.scm @@ -3,6 +3,7 @@ ;;; Copyright © 2018 Oleg Pykhalov ;;; Copyright © 2020 Pierre Langlois ;;; Copyright © 2021 Maxime Devos +;;; Copyright © 2022 Remco van 't Veer ;;; ;;; This file is part of GNU Guix. ;;; @@ -745,6 +746,10 @@ (define-record-type* (default "/etc/resolv.conf")) ;string (no-resolv? dnsmasq-configuration-no-resolv? (default #f)) ;boolean + (bogus-priv? dnsmasq-configuration-bogus-priv? + (default #f)) ;boolean + (strict-order? dnsmasq-configuration-strict-order? + (default #f)) ;boolean (servers dnsmasq-configuration-servers (default '())) ;list of string (addresses dnsmasq-configuration-addresses @@ -752,7 +757,9 @@ (define-record-type* (cache-size dnsmasq-configuration-cache-size (default 150)) ;integer (negative-cache? dnsmasq-configuration-negative-cache? - (default #t)) ;boolean + (default #t)) ;boolean + (add-cpe-id dnsmasq-configuration-add-cpe-id + (default #t)) ;string (tftp-enable? dnsmasq-configuration-tftp-enable? (default #f)) ;boolean (tftp-no-fail? dnsmasq-configuration-tftp-no-fail? @@ -781,8 +788,9 @@ (define dnsmasq-shepherd-service (($ package no-hosts? port local-service? listen-addresses - resolv-file no-resolv? servers - addresses cache-size negative-cache? + resolv-file no-resolv? bogus-priv? + strict-order? servers addresses cache-size + negative-cache? add-cpe-id tftp-enable? tftp-no-fail? tftp-single-port? tftp-secure? tftp-max tftp-mtu tftp-no-blocksize? @@ -809,6 +817,9 @@ (define dnsmasq-shepherd-service #$@(if no-resolv? '("--no-resolv") '()) + #$@(if bogus-priv? + '("--bogus-priv") + '()) #$@(map (cut format #f "--server=~a" <>) servers) #$@(map (cut format #f "--address=~a" <>) @@ -817,6 +828,9 @@ (define dnsmasq-shepherd-service #$@(if negative-cache? '() '("--no-negcache")) + #$@(if add-cpe-id + (list (format #f "--add-cpe-id=~a" add-cpe-id)) + '()) #$@(if tftp-enable? '("--enable-tftp") '()) -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 19 06:55:15 2022 Received: (at 54352) by debbugs.gnu.org; 19 Mar 2022 10:55:15 +0000 Received: from localhost ([127.0.0.1]:59137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVWjq-0006Xk-UA for submit@debbugs.gnu.org; Sat, 19 Mar 2022 06:55:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVWjp-0006XU-7d for 54352@debbugs.gnu.org; Sat, 19 Mar 2022 06:55:13 -0400 Received: from [2001:470:142:3::e] (port=59436 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVWjb-0002oN-S1; Sat, 19 Mar 2022 06:55:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=XERT+/Xa1+m7AW7bQ17guaOF5hklH0z3eiYk468Imhs=; b=kUpp/AIpbDSbH7YWZE5G fh8VfeTsSkvn/TasiOsO1wyVNFApxl1OpSuszYSh6YaMmf2U387FkFPYB4qVu1iyjC/QNjR8OB8qV We0YXTZNlDi1RH4HFD7fo/py10T8T6eUXhW2y+Q1wxxwEXkHVLuYCCcGXrsVGiDFYNO7MegKlxk6P jEmCDgxVriE2yOORz5zUdcun3ArVLVzq45a4XINvJyNAN1W64TqyqPZJpWq+nnpHuD4D6+t3d35oD 8F0IE49gxxmIIl4AEZTS4PrZUf3rpCKEFKq8uuk+KBVwCQw7nF5gA8ri3wEtkQ7OPTFNcdsUJadk3 naSdKFO5U4dYZQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:56173 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVWjW-0001gN-LY; Sat, 19 Mar 2022 06:54:58 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Remco van 't Veer Subject: Re: bug#54352: [PATCH] services: dnsmasq: Add more options. References: <20220312154813.5538-1-remco@remworks.net> Date: Sat, 19 Mar 2022 11:54:53 +0100 In-Reply-To: <20220312154813.5538-1-remco@remworks.net> (Remco van t. Veer's message of "Sat, 12 Mar 2022 16:48:13 +0100") Message-ID: <878rt6nreq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54352 Cc: 54352@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Remco van 't Veer skribis: > * gnu/services/dns.scm (): Add bogus-priv?, > strict-order? and add-cpe-id options. > (dnsmasq-shepherd-service): Pass bogus-priv, strict-order and add-cpe-id > to the service. > * doc/guix.texi (Guix Services): Document options added to dnsmasq. I don=E2=80=99t use dnsmasq, but overall that LGTM, and a welcome addition. Nitpick: > + (bogus-priv? dnsmasq-configuration-bogus-priv? > + (default #f)) ;boolean I=E2=80=99d rather avoid the abbreviation and use something more descriptiv= e, even if that doesn=E2=80=99t match the name used in the config file. Maybe something like =E2=80=98forward-private-reverse-lookup?=E2=80=99 (I=E2=80= =99m making it up based on the doc you wrote.) WDYT? > + (add-cpe-id dnsmasq-configuration-add-cpe-id > + (default #t)) ;string Maybe =E2=80=98additional-cpe-id=E2=80=99 or =E2=80=98extra-cpe-id=E2=80=99= or =E2=80=98cpe-id=E2=80=99? > (($ package > no-hosts? > port local-service? listen-addresses > - resolv-file no-resolv? servers > - addresses cache-size negative-cache? > + resolv-file no-resolv? bogus-priv? > + strict-order? servers addresses cache-si= ze > + negative-cache? add-cpe-id Not a blocker for this patch, but we should change that to =E2=80=98match-record=E2=80=99, which is less error-prone. Let me know what you think; you can send an updated patch if the suggestions make sense to you. Thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 07:43:06 2022 Received: (at 54352) by debbugs.gnu.org; 20 Mar 2022 11:43:06 +0000 Received: from localhost ([127.0.0.1]:32948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVtxi-0004yy-LE for submit@debbugs.gnu.org; Sun, 20 Mar 2022 07:43:06 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:43587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVtxg-0004yU-LO for 54352@debbugs.gnu.org; Sun, 20 Mar 2022 07:43:05 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 81DA65C014B; Sun, 20 Mar 2022 07:42:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 20 Mar 2022 07:42:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=remworks.net; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=rsmPg9PXtaMDnnzrMjS1nNl/UZ7K5PR3cZ/jIP 2AnRc=; b=Dbek8R9V7RW3sAlStZTIS6G6DvO1qrIOpKMQWZ0v4NBp2SOcbP/Px7 IumniMP2QlFc18zBNfyfVWjuMwvbQ37mQ7WidF51MuUdfDCRGElZgwDTS8pDo3J+ NBMFwFiFyRoeSwR0+HJUTinQorHI9FXeWQyPdPMcIK9EZEv+StlgXsueo5EYE/kB HSceuyUJVC7FpTriexWkunTvV1YlGCr8itBzaqL+RWM0qhVeAQu4FupJotiuwnT5 C5TAb6MIMMhfWcQqCud7qxryj35wroZ2EFMR7cUyqscDk+aCglPhoBlSwvlvR4Go p93feIYaPUVkgWj++nMsjntfy+t4d2jQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=rsmPg9PXtaMDnnzrM jS1nNl/UZ7K5PR3cZ/jIP2AnRc=; b=fBdyDqTGLeWvUASzQkkFenNwdp5GXtQaZ IiuKxRLeeYhDZs9YbTSJsBj7mRa6FkxsjGZ8rYVvJkNRw0lE6r1U4D6TUnXfmslu CEVC7dqkDOk51uSpKF/4rAi3Uu93EWe0pOTmUtqkXyiBUU75fjifj5oqn+/CxSS7 ZKbFmlicIvYAcen9TqPWSDdafXo4kKMaEVmIF798SFYlBaBEe3BpGdcMA2/XW6eM osa4SnoxYTN7RCn9Ci+UGatHkc691t7FdRh+GA/vJ3EK5qvVqeun4OklzB/B3vdh emA3Qkaoekj0WaJJE0oNyinljJ1FMEKngj5Qewl0WLSGE7E63c0sg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeguddgfeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvufgjfffkgggtsehttdertddtredtnecuhfhrohhmpeftvghmtgho uchvrghnucdkthcugggvvghruceorhgvmhgtohesrhgvmhifohhrkhhsrdhnvghtqeenuc ggtffrrghtthgvrhhnpeeuledvteevteehfeduvefhjeduvefgkeehledtgfegvdeugeff hfekieejkedtgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehrvghmtghosehrvghmfihorhhkshdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 20 Mar 2022 07:42:58 -0400 (EDT) References: <20220312154813.5538-1-remco@remworks.net> <878rt6nreq.fsf@gnu.org> User-agent: mu4e 1.6.10; emacs 27.2 From: Remco van 't Veer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#54352: [PATCH] services: dnsmasq: Add more options. In-reply-to: <878rt6nreq.fsf@gnu.org> Date: Sun, 20 Mar 2022 12:42:54 +0100 Message-ID: <877d8og88x.fsf@remworks.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54352 Cc: 54352@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Thank you Ludovic for your feedback! I've applied all of your suggestions and am especially happy about match-record because I had some trouble with match-lambda (did not realise at first order matters). I'll post a v2 immediately. Cheers, R. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 07:44:19 2022 Received: (at 54352) by debbugs.gnu.org; 20 Mar 2022 11:44:19 +0000 Received: from localhost ([127.0.0.1]:32954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVtys-00050t-U4 for submit@debbugs.gnu.org; Sun, 20 Mar 2022 07:44:19 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:48305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVtyr-00050h-Pz for 54352@debbugs.gnu.org; Sun, 20 Mar 2022 07:44:18 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id AA4B75C012F; Sun, 20 Mar 2022 07:44:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 20 Mar 2022 07:44:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=remworks.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm3; bh=qNp0BtpXt8uyuPTVUwePa4wsTHTC9K6/W5wxoB 3Znpg=; b=vtKUk/yNxD97YNC9QjEhij+UbPiiua31I+yX7eE8nqYL7SNG4JNL4K RcziGh700AzKcGEHxNdSdP9s1l766fb2mFZ2gVB7PqBhqghI9Fz9WdHgnVtIG+c3 10sl7Cah1t48v7h9MOgwovZ7EwbtNmISseMNvbc9ttKxC0KwuYrvqlamDF7OGKNS konJjWJfE4tJgeIsIfVjozfOIDgd3+uLVTNOgGNJO/SYRGqpLWFwDBhnS88PrBYs 4UeNyqOTxfvtaQOqvr8/aeueQhoEvgQWHQXAo9G2MkRYQOqSVPXRKljzX/kns4Yc LewQC5GRRU2qu6KY4R5hpsdMZQnwlOZw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=qNp0Bt pXt8uyuPTVUwePa4wsTHTC9K6/W5wxoB3Znpg=; b=QBRwKltfGGeT6MgSDJVHcl 7dvnlhK4ehJltXBXdBmb058iYb0SQSg0E5i1sKXwgbNLOcpDz+aTZTQh/D4boVHH 8BfN0FX8G59buyAsiANGybOdmiRbFBiJdkep8sR5v818iQvNrV/Zrrb7RgUpUVoV 4qOyoaa+LZWto98zCor8AMBBENfHwdX/yrGFyxUnLa9MUqLh6ku1XcPV+Em1NRb/ A2JnlBl7QK08m92qg2yCrFp5P7tEgU4spC4FlJ1bHqM7xhOaEzKogdNCkKXva82f MGaB4fIiLIl/8NERUiU1J+J4wIjXM9vpVEpeCgYxFQPVcJ8z5CxKVqGsx52cs+lw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeguddgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofggtgfgsehtkeertd ertdejnecuhfhrohhmpeftvghmtghouchvrghnucdkthcugggvvghruceorhgvmhgtohes rhgvmhifohhrkhhsrdhnvghtqeenucggtffrrghtthgvrhhnpeevfedugfefueelveeltd dtteehjefhvedvuefgueektdfhudefteekuedtgefhieenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrfihvsehfrghsthhmrghilhdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 20 Mar 2022 07:44:12 -0400 (EDT) From: Remco van 't Veer To: 54352@debbugs.gnu.org Subject: [PATCH v2] services: dnsmasq: Add more options. Date: Sun, 20 Mar 2022 12:44:05 +0100 Message-Id: <20220320114405.4702-1-remco@remworks.net> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 54352 Cc: Remco van 't Veer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) * gnu/services/dns.scm (): Add forward-private-reverse-lookup?, strict-order? and additional-cpe-id options. (dnsmasq-shepherd-service): Pass added options to dnsmasq. * doc/guix.texi (Guix Services): Document options added to dnsmasq. --- doc/guix.texi | 12 +++ gnu/services/dns.scm | 178 +++++++++++++++++++++++-------------------- 2 files changed, 109 insertions(+), 81 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 4b71fb7010..a769cd1e5b 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -28945,6 +28945,14 @@ The file to read the IP address of the upstream nameservers from. @item @code{no-resolv?} (default: @code{#f}) When true, don't read @var{resolv-file}. +@item @code{forward-private-reverse-lookup?} (default: @code{#t}) +When false, all reverse lookups for private IP ranges are answered with +"no such domain" rather than being forwarded upstream. + +@item @code{strict-order?} (default: @code{#f}) +When true, forces dnsmasq to try each query with each server strictly in +the order they appear in @var{servers}. + @item @code{servers} (default: @code{'()}) Specify IP address of upstream servers directly. @@ -28974,6 +28982,10 @@ disables caching. @item @code{negative-cache?} (default: @code{#t}) When false, disable negative caching. +@item @code{additional-cpe-id} (default: @code{#f}) +If set, add an arbitrary identifying string to DNS queries which are +forwarded upstream. + @item @code{tftp-enable?} (default: @code{#f}) Whether to enable the built-in TFTP server. diff --git a/gnu/services/dns.scm b/gnu/services/dns.scm index 9b8603cc95..5add843f32 100644 --- a/gnu/services/dns.scm +++ b/gnu/services/dns.scm @@ -3,6 +3,7 @@ ;;; Copyright © 2018 Oleg Pykhalov ;;; Copyright © 2020 Pierre Langlois ;;; Copyright © 2021 Maxime Devos +;;; Copyright © 2022 Remco van 't Veer ;;; ;;; This file is part of GNU Guix. ;;; @@ -745,6 +746,11 @@ (define-record-type* (default "/etc/resolv.conf")) ;string (no-resolv? dnsmasq-configuration-no-resolv? (default #f)) ;boolean + (forward-private-reverse-lookup? + dnsmasq-configuration-forward-private-reverse-lookup? + (default #t)) ;boolean + (strict-order? dnsmasq-configuration-strict-order? + (default #f)) ;boolean (servers dnsmasq-configuration-servers (default '())) ;list of string (addresses dnsmasq-configuration-addresses @@ -752,7 +758,9 @@ (define-record-type* (cache-size dnsmasq-configuration-cache-size (default 150)) ;integer (negative-cache? dnsmasq-configuration-negative-cache? - (default #t)) ;boolean + (default #t)) ;boolean + (additional-cpe-id dnsmasq-configuration-additional-cpe-id + (default #t)) ;string (tftp-enable? dnsmasq-configuration-tftp-enable? (default #f)) ;boolean (tftp-no-fail? dnsmasq-configuration-tftp-no-fail? @@ -776,86 +784,94 @@ (define-record-type* (tftp-unique-root dnsmasq-tftp-unique-root (default #f))) ;"" or "ip" or "mac" -(define dnsmasq-shepherd-service - (match-lambda - (($ package - no-hosts? - port local-service? listen-addresses - resolv-file no-resolv? servers - addresses cache-size negative-cache? - tftp-enable? tftp-no-fail? - tftp-single-port? tftp-secure? - tftp-max tftp-mtu tftp-no-blocksize? - tftp-lowercase? tftp-port-range - tftp-root tftp-unique-root) - (shepherd-service - (provision '(dnsmasq)) - (requirement '(networking)) - (documentation "Run the dnsmasq DNS server.") - (start #~(make-forkexec-constructor - '(#$(file-append package "/sbin/dnsmasq") - "--keep-in-foreground" - "--pid-file=/run/dnsmasq.pid" - #$@(if no-hosts? - '("--no-hosts") - '()) - #$(format #f "--port=~a" port) - #$@(if local-service? - '("--local-service") - '()) - #$@(map (cut format #f "--listen-address=~a" <>) - listen-addresses) - #$(format #f "--resolv-file=~a" resolv-file) - #$@(if no-resolv? - '("--no-resolv") - '()) - #$@(map (cut format #f "--server=~a" <>) - servers) - #$@(map (cut format #f "--address=~a" <>) - addresses) - #$(format #f "--cache-size=~a" cache-size) - #$@(if negative-cache? - '() - '("--no-negcache")) - #$@(if tftp-enable? - '("--enable-tftp") - '()) - #$@(if tftp-no-fail? - '("--tftp-no-fail") - '()) - #$@(if tftp-single-port? - '("--tftp-single-port") - '()) - #$@(if tftp-secure? - '("--tftp-secure?") - '()) - #$@(if tftp-max - (list (format #f "--tftp-max=~a" tftp-max)) - '()) - #$@(if tftp-mtu - (list (format #f "--tftp-mtu=~a" tftp-mtu)) - '()) - #$@(if tftp-no-blocksize? - '("--tftp-no-blocksize") - '()) - #$@(if tftp-lowercase? - '("--tftp-lowercase") - '()) - #$@(if tftp-port-range - (list (format #f "--tftp-port-range=~a" - tftp-port-range)) - '()) - #$@(if tftp-root - (list (format #f "--tftp-root=~a" tftp-root)) - '()) - #$@(if tftp-unique-root - (list - (if (> (length tftp-unique-root) 0) - (format #f "--tftp-unique-root=~a" tftp-unique-root) - (format #f "--tftp-unique-root"))) - '())) - #:pid-file "/run/dnsmasq.pid")) - (stop #~(make-kill-destructor)))))) +(define (dnsmasq-shepherd-service config) + (match-record config + (package + no-hosts? + port local-service? listen-addresses + resolv-file no-resolv? + forward-private-reverse-lookup? strict-order? + servers addresses cache-size negative-cache? + additional-cpe-id + tftp-enable? tftp-no-fail? + tftp-single-port? tftp-secure? + tftp-max tftp-mtu tftp-no-blocksize? + tftp-lowercase? tftp-port-range + tftp-root tftp-unique-root) + (shepherd-service + (provision '(dnsmasq)) + (requirement '(networking)) + (documentation "Run the dnsmasq DNS server.") + (start #~(make-forkexec-constructor + '(#$(file-append package "/sbin/dnsmasq") + "--keep-in-foreground" + "--pid-file=/run/dnsmasq.pid" + #$@(if no-hosts? + '("--no-hosts") + '()) + #$(format #f "--port=~a" port) + #$@(if local-service? + '("--local-service") + '()) + #$@(map (cut format #f "--listen-address=~a" <>) + listen-addresses) + #$(format #f "--resolv-file=~a" resolv-file) + #$@(if no-resolv? + '("--no-resolv") + '()) + #$@(if forward-private-reverse-lookup? + '() + '("--bogus-priv")) + #$@(map (cut format #f "--server=~a" <>) + servers) + #$@(map (cut format #f "--address=~a" <>) + addresses) + #$(format #f "--cache-size=~a" cache-size) + #$@(if negative-cache? + '() + '("--no-negcache")) + #$@(if additional-cpe-id + (list (format #f "--add-cpe-id=~a" additional-cpe-id)) + '()) + #$@(if tftp-enable? + '("--enable-tftp") + '()) + #$@(if tftp-no-fail? + '("--tftp-no-fail") + '()) + #$@(if tftp-single-port? + '("--tftp-single-port") + '()) + #$@(if tftp-secure? + '("--tftp-secure?") + '()) + #$@(if tftp-max + (list (format #f "--tftp-max=~a" tftp-max)) + '()) + #$@(if tftp-mtu + (list (format #f "--tftp-mtu=~a" tftp-mtu)) + '()) + #$@(if tftp-no-blocksize? + '("--tftp-no-blocksize") + '()) + #$@(if tftp-lowercase? + '("--tftp-lowercase") + '()) + #$@(if tftp-port-range + (list (format #f "--tftp-port-range=~a" + tftp-port-range)) + '()) + #$@(if tftp-root + (list (format #f "--tftp-root=~a" tftp-root)) + '()) + #$@(if tftp-unique-root + (list + (if (> (length tftp-unique-root) 0) + (format #f "--tftp-unique-root=~a" tftp-unique-root) + (format #f "--tftp-unique-root"))) + '())) + #:pid-file "/run/dnsmasq.pid")) + (stop #~(make-kill-destructor))))) (define (dnsmasq-activation config) #~(begin -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 07:56:31 2022 Received: (at 54352) by debbugs.gnu.org; 20 Mar 2022 11:56:31 +0000 Received: from localhost ([127.0.0.1]:32971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVuAh-0005L2-Gj for submit@debbugs.gnu.org; Sun, 20 Mar 2022 07:56:31 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:43468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVuAe-0005Kt-VP for 54352@debbugs.gnu.org; Sun, 20 Mar 2022 07:56:29 -0400 Received: from [192.168.100.254] ([188.189.229.90]) by baptiste.telenet-ops.be with bizsmtp id 8bwS2700q1xgCic01bwTln; Sun, 20 Mar 2022 12:56:27 +0100 Message-ID: Subject: Re: [bug#54352] [PATCH v2] services: dnsmasq: Add more options. From: Maxime Devos To: Remco van 't Veer , 54352@debbugs.gnu.org Date: Sun, 20 Mar 2022 12:56:22 +0100 In-Reply-To: <20220320114405.4702-1-remco@remworks.net> References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-vnMobDPWJIs/pL3Y9vQA" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647777387; bh=kw7rTbb6dgOvFiorFUu2BjHfTQUnRgQaLdQuqnR3DBI=; h=Subject:From:To:Date:In-Reply-To:References; b=mys4ijhxWIJRg+9+dK7wPCaMCJAfskj6Vf8DPV+paVZ4k0q/a+w32ChK+U6QO07ga VtsbqEbNk6JUAoeuR06f0OVv9zjiNHyPZUithI7R8zSni/l1lfCEK0S0WB2AryNHoA K7WMuO2tgNdSEyoxa/9g5T+aC7cLoIOuKjahw0LW7bOPs2HjlQ74x+jiL16k/IF3fF zmmGqDOPoqhd6oS5Z1ddwbZe7MGENUXEqsMVM88dnmSu6R6XBfeTFfWJ/FDSh7aMpa SFe9Y4H+Qpavwe+8HEgBhLREp8Z8URZLnJPnc59T+Qju2b7cNBdM+vnCZSLB2nujpp 9cM50yb6rfGsQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54352 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-vnMobDPWJIs/pL3Y9vQA Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 UmVtY28gdmFuICd0IFZlZXIgc2NocmVlZiBvcCB6byAyMC0wMy0yMDIyIG9tIDEyOjQ0IFsrMDEw MF06Cj4gK8KgIChmb3J3YXJkLXByaXZhdGUtcmV2ZXJzZS1sb29rdXA/Cj4gK8KgwqAgZG5zbWFz cS1jb25maWd1cmF0aW9uLWZvcndhcmQtcHJpdmF0ZS1yZXZlcnNlLWxvb2t1cD8KPiArwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGRlZmF1bHQgI3QpKcKgwqDCoMKgwqDC oCA7Ym9vbGVhbgo+ICvCoCAoc3RyaWN0LW9yZGVyP8KgwqDCoCBkbnNtYXNxLWNvbmZpZ3VyYXRp b24tc3RyaWN0LW9yZGVyPwo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCAoZGVmYXVsdCAjZikpwqDCoMKgwqDCoMKgIDtib29sZWFuCgpJdCB3b3VsZCBiZSBuaWNlIHRv IHZlcmlmeSB0aGF0IHRoZXNlIGFyZSwgaW4gZmFjdCwgYm9vbGVhbnMsCnVzaW5nIGZpZWxkIHNh bml0aXplcnMuICBTZWUsIGUuZy4sIGVuc3VyZS1zZXR1aWQtcHJvZ3JhbS1saXN0CmluIChnbnUg c3lzdGVtKS4KCkdyZWV0aW5ncywKTWF4aW1lLgo= --=-vnMobDPWJIs/pL3Y9vQA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjcWZhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7o2sAQCIonGEQ7nGNVYin0OzXbyJg3/W e/UazEIOzOusEgaqQgD/TvTo9n+lcCmlzrb3hR9fCYZFLYSyLNUSRrARqUWJaAc= =CiPN -----END PGP SIGNATURE----- --=-vnMobDPWJIs/pL3Y9vQA-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 08:22:11 2022 Received: (at 54352) by debbugs.gnu.org; 20 Mar 2022 12:22:11 +0000 Received: from localhost ([127.0.0.1]:33060 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVuZX-00060q-MC for submit@debbugs.gnu.org; Sun, 20 Mar 2022 08:22:11 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:38165) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVuZV-00060d-IG for 54352@debbugs.gnu.org; Sun, 20 Mar 2022 08:22:11 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id AFB7D32009E0; Sun, 20 Mar 2022 08:22:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 20 Mar 2022 08:22:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=remworks.net; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=opPrnJMp4TP2dRuIY3SgxRY8ZxP5zPggwUmRKa 3s818=; b=U/G/Xuqsm7+2RIZ38HtZ69lBmD3jDlcmPq8DMglEk1FJDL8dfBMtKp wgMlrqvc+WNd4+cRkkok4L3f7HtBcnRQzSZ3pOl4RsEIr4F/pidVBd2X4a89nw92 nx2lPuvmiLLB7akXz8ptJPX+IzrDvt8iFFUBcf/AAwSGLO9Wgqk6dpux+DN1f36W k6396NZ5vh6iCzY1vtLNhp3uNJ4T49Ot1LB0jH570j3hvtgvW9cPSnCjWJzybOZd BhqE/TpJQaa8cji1zCMW/fM0bvKARCEuWKy3shuSrvM42bsRcQJCQ0WRTqt0EO3+ KFncZUBA6S95A6E+gpkbrgKkeRDYR/ow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=opPrnJMp4TP2dRuIY 3SgxRY8ZxP5zPggwUmRKa3s818=; b=oooSLq4vhOR5UvRY/bc0skJHnMcybGLsX YogiOEpj7uZL8v/FtHlzKgqQ1Zj7miOmnfkYQOdAHcnmQMEOJNxTDruu45L4Pu1R m18MnrTyqvU1lWbHX9UZ8owkTfQvFk0A8nL6Z6nTICblXkOSiLVZnz82ZzpSx5pB hawKXuE9FOaVShREqsYF211VkD004PVV3yYVNW0oCe+1YMn9UNESqyI5Yff5feSt utX23UglM3VZ7hydRYC+PRAk7lrNTQuFOdWByAmiglx95Wf/cQq3/geta1JEGhEv EUlkgKs7qfgu4MI/YqeeruQgik3Ypboho1FrcocPwsweF7Rh51btQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeguddgfeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvufgjfffkgggtsehttdertddtredtnecuhfhrohhmpeftvghmtgho uchvrghnucdkthcugggvvghruceorhgvmhgtohesrhgvmhifohhrkhhsrdhnvghtqeenuc ggtffrrghtthgvrhhnpeeuledvteevteehfeduvefhjeduvefgkeehledtgfegvdeugeff hfekieejkedtgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehrvghmtghosehrvghmfihorhhkshdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 20 Mar 2022 08:22:02 -0400 (EDT) References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> User-agent: mu4e 1.6.10; emacs 27.2 From: Remco van 't Veer To: Maxime Devos Subject: Re: [bug#54352] [PATCH v2] services: dnsmasq: Add more options. In-reply-to: Date: Sun, 20 Mar 2022 13:22:00 +0100 Message-ID: <8735jcddav.fsf@remworks.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54352 Cc: 54352@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) 2022/03/20 12:56, Maxime Devos: > It would be nice to verify that these are, in fact, booleans, > using field sanitizers. See, e.g., ensure-setuid-program-list > in (gnu system). I agree but the same could be said about the other fields and types in this record, and those of other services. In this case, the names of the fields ending with "?" should be enough for somebody to realise this is a boolean, IMHO. The ";boolean" comments I've added are just me trying to blend in. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 08:31:12 2022 Received: (at 54352) by debbugs.gnu.org; 20 Mar 2022 12:31:12 +0000 Received: from localhost ([127.0.0.1]:33114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVuiG-0006H4-F9 for submit@debbugs.gnu.org; Sun, 20 Mar 2022 08:31:12 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:59948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVuiD-0006Gu-SW for 54352@debbugs.gnu.org; Sun, 20 Mar 2022 08:31:10 -0400 Received: from [192.168.100.254] ([188.189.229.90]) by laurent.telenet-ops.be with bizsmtp id 8cX22700G1xgCic01cX7KC; Sun, 20 Mar 2022 13:31:08 +0100 Message-ID: <25d571d30b3ea33ef2bdb7b09b28014c3f45a883.camel@telenet.be> Subject: Re: [bug#54352] [PATCH v2] services: dnsmasq: Add more options. From: Maxime Devos To: Remco van 't Veer Date: Sun, 20 Mar 2022 13:30:57 +0100 In-Reply-To: <8735jcddav.fsf@remworks.net> References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> <8735jcddav.fsf@remworks.net> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-UZMGllmheTEVSW189CpU" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647779468; bh=8X/R4wR/TApiJr/Au8KEHQT2vhshySvVHvbYicEKR1Q=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=h5Maqn8gsOAN3sbmoUMrzPtfGD+44owLxWKQhVEzsi+K7Im3eu+XLctZKi+U8Zsdk uTq0EcFmQrustByBviJze60FPOmLZcyih1NvIuQWCeZlfZRDjnB3zmSm0ZOLjpwUoX B4SgL7HfYnBQNFUTnlI8RdUr1rA5Tv56haOEFxm3zK9jZFdON8mOUTvvU06Glakz5+ /USnFQ5UbPPru82Ria56eijuwFpfI30gnmFpn4T+BkQkgpbWw3+Z57D+Xpc/00UD2T mQqREjl5eQ37zuviZiGfbQvLskYSb8lLm57wVszIT3RylOLVfldXnPji8iezc7MMPp uKB5RdnorPezA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54352 Cc: 54352@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-UZMGllmheTEVSW189CpU Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Remco van 't Veer schreef op zo 20-03-2022 om 13:22 [+0100]: > 2022/03/20 12:56, Maxime Devos: >=20 > > It would be nice to verify that these are, in fact, booleans, > > using field sanitizers.=C2=A0 See, e.g., ensure-setuid-program-list > > in (gnu system). >=20 > I agree but the same could be said about the other fields and types in > this record, and those of other services.=C2=A0 In the long-term, it would be nice to eventually add error checking to other services and fields as well. In the short-term, I would avoid making error handling worse. > In this case, the names of the fields ending with "?" should be > enough for somebody to realise this is a boolean, IMHO.=C2=A0 > The";boolean" comments I've added are just me trying to blend in. It's technically sufficient, but it does not make for nice error messages, see the thread at . In this particular case, there won't be an error message *at all*, due to how (if forward-private-reverse-lookup? ... ...) works. For example, consider the case where someone new to Guile and Guix sees =E2=80=98boolean=E2=80=99 in the documentation and then tries using "true" = and "false" (the strings): (dnsmasq-configuration (forward-private-reverse-lookup? "false")) Currently, this will silently do the wrong thing. Greetings, Maxime. --=-UZMGllmheTEVSW189CpU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjcegRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7rEZAP0cD2uSdoXB0vp01y9Z96ehr3wX uGcLbrOfwWm2L4O5gAD/duaPheEZvrqss7AT9cwfGFqYt2ae0JMgDTxSNNFSBQ0= =1+B2 -----END PGP SIGNATURE----- --=-UZMGllmheTEVSW189CpU-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 08:31:37 2022 Received: (at 54352) by debbugs.gnu.org; 20 Mar 2022 12:31:37 +0000 Received: from localhost ([127.0.0.1]:33124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVuif-0006Hv-9L for submit@debbugs.gnu.org; Sun, 20 Mar 2022 08:31:37 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:45284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVuie-0006Hn-6T for 54352@debbugs.gnu.org; Sun, 20 Mar 2022 08:31:36 -0400 Received: from [192.168.100.254] ([188.189.229.90]) by michel.telenet-ops.be with bizsmtp id 8cXa2700B1xgCic06cXayi; Sun, 20 Mar 2022 13:31:35 +0100 Message-ID: <962caf6373497ba4587aa4eacd7e21b332cdd3f4.camel@telenet.be> Subject: Re: [bug#54352] [PATCH v2] services: dnsmasq: Add more options. From: Maxime Devos To: Remco van 't Veer , 54352@debbugs.gnu.org Date: Sun, 20 Mar 2022 13:31:34 +0100 In-Reply-To: <20220320114405.4702-1-remco@remworks.net> References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-ISI6h87yoR1h9Qh/sTjZ" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647779495; bh=4C4Vh2KGuqzuFTaO3VBeBNTFcGpf5kPJGtJGjC8sRYQ=; h=Subject:From:To:Date:In-Reply-To:References; b=HQ5Ar/f9IMslfx3CFjMCuWSfjF3iMCZi82sS3zYlOj5VjEEjRJiXQqKi4TWqFg2iR Nlp0BzZu6cX6ikLaqz+NUeK/AnYQ9PKQ3h8Ijnaaj4hhdHRbOeN4Evnyjo8WZn8aZO 9O//SdqeR95d3whZDdMqVJMhjJW/9VJK8IJQLAXelPT4ZfefbkbLH46Qm5oP8iWOLm +558ay4rVccDp05zB615kEs5IwJcJTbyUOY0uptYi8pF+UwIsBxh5a0aR24R3jdD66 GUezE+Gb6sLVRgOgs9NuXcc1QWX52oTdq1d6fSVw2zgy8ZVL2a9cP13TwsClyVnyoO 5Q9T/PJfs8Ulw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54352 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-ISI6h87yoR1h9Qh/sTjZ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Remco van 't Veer schreef op zo 20-03-2022 om 12:44 [+0100]: > + (strict-order? dnsmasq-configuration-strict-order? > + (default #f)) ;boolean The field strict-order? appears to be unused. Greetings, Maxime. --=-ISI6h87yoR1h9Qh/sTjZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjcephccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7mx2AQCrjWmw33ReBUiUN/0xY4/xqXKt ya3kBSBDY0PZYju7hAD/TE4y9kDcqSVHg1Is9SivsaCheqneZK5VYsiZ7kpr/QI= =+L+0 -----END PGP SIGNATURE----- --=-ISI6h87yoR1h9Qh/sTjZ-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 08:32:52 2022 Received: (at 54352) by debbugs.gnu.org; 20 Mar 2022 12:32:52 +0000 Received: from localhost ([127.0.0.1]:33138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVujs-0006KH-0A for submit@debbugs.gnu.org; Sun, 20 Mar 2022 08:32:52 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:55552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVujq-0006K7-0B for 54352@debbugs.gnu.org; Sun, 20 Mar 2022 08:32:50 -0400 Received: from [192.168.100.254] ([188.189.229.90]) by albert.telenet-ops.be with bizsmtp id 8cYo270051xgCic06cYoTU; Sun, 20 Mar 2022 13:32:48 +0100 Message-ID: Subject: Re: [bug#54352] [PATCH v2] services: dnsmasq: Add more options. From: Maxime Devos To: Remco van 't Veer , 54352@debbugs.gnu.org Date: Sun, 20 Mar 2022 13:32:48 +0100 In-Reply-To: <20220320114405.4702-1-remco@remworks.net> References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-gDoBQTPRXnS2PigTq8L+" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647779568; bh=Ay2yblRLirUHdq1KMw6IPvgfdjc+mwiZZDo0KVgaQMI=; h=Subject:From:To:Date:In-Reply-To:References; b=fNj7HgWy2SScqu3lYK0Q7ULNsW5wqo5OQe3jFnnmF8FTv1SQhEGXXTf3mUz9T7cLw kYKiklelH1EkbX7cGCgAEyVDAKAv1GUdlO0LGA2nvDy9eqwUyZn+9gqVx5MtOy33yP 2Kf8SfgeIPoK1mGa+auuqTfaWgqOh1T//bYsy4qliuLNvfZRmokIZpwIyPcz22oI0/ HBYiZc4MhpXjVBeQW4rRhno0sOSVcoaIMwUA4smC4YYId3yqUuy8Qvn/HQNpguvnQU 3kB466zcwUbsNBnKgsSw3Z5HhEI326OGF3rP6ltVq6l4/TQLrXa13zpiQ6Uk5f89+y /S2JHp28IMEjA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54352 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-gDoBQTPRXnS2PigTq8L+ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Remco van 't Veer schreef op zo 20-03-2022 om 12:44 [+0100]: > +@item @code{additional-cpe-id} (default: @code{#f}) > +If set, add an arbitrary identifying string to DNS queries which are > +forwarded upstream. What is an =E2=80=98arbitrary identify string=E2=80=99 here? What does =E2= =80=98cpe=E2=80=99 mean?=20 How can I know if I need to set this, and how do I know what to set it to? Greetings, Maxime. --=-gDoBQTPRXnS2PigTq8L+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjce8BccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7kUZAQCtKbnGO/uoDBUuyeL0M2W5QZvl 6VJhBPOZSniJs6F70gEAsH2tRCMtWdLuBCJGYn6xJinS7exAjz95sTMJ7JADBg0= =sj72 -----END PGP SIGNATURE----- --=-gDoBQTPRXnS2PigTq8L+-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 08:36:35 2022 Received: (at 54352) by debbugs.gnu.org; 20 Mar 2022 12:36:35 +0000 Received: from localhost ([127.0.0.1]:33145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVunT-0006Pj-FA for submit@debbugs.gnu.org; Sun, 20 Mar 2022 08:36:35 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:51896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVunR-0006Pb-Gz for 54352@debbugs.gnu.org; Sun, 20 Mar 2022 08:36:33 -0400 Received: from [192.168.100.254] ([188.189.229.90]) by michel.telenet-ops.be with bizsmtp id 8ccX2700q1xgCic06ccYdS; Sun, 20 Mar 2022 13:36:32 +0100 Message-ID: <956761e46ca4fdd9fb77e3d85f5eaaa125145a57.camel@telenet.be> Subject: Re: [bug#54352] [PATCH v2] services: dnsmasq: Add more options. From: Maxime Devos To: Remco van 't Veer , 54352@debbugs.gnu.org Date: Sun, 20 Mar 2022 13:36:31 +0100 In-Reply-To: <20220320114405.4702-1-remco@remworks.net> References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-uzGANqFdsTzqZ55opnQJ" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647779792; bh=/As68/q+cRR192oMxon/7KiI0rq4oLBlAsE0eFbTgic=; h=Subject:From:To:Date:In-Reply-To:References; b=aZBBZDUk7Z17Tn9ldMy1928FJZxXT8wuaJL94NTeDsmknPyY+DMNI0eFeVUqgB0TR Zxymtt3/K0ci8eH4/TqPlTWrqy1SioDXJw1MGUs3sNmHC/e6klKHvi0WoiVwhL45mC zJpbNFVbX+FsaNIV7EQlN6b1Co5K3xHvvXk7uzte0+9/npj/lm2P7EhDkIf8AjhcLI l84lf3H5lqTdmVgPCvrBIHGXW6AehQsUxu6YXz85M+yETrOc1BKeWj1hlGlGR/gYH2 hE3TveTdazu/WPgYMCqYJbkMfBjbiZb3vks46WUnUcJcKXJ/5rmbHVhslO9W8SEiOY iVrvzKnsQA+VA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54352 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-uzGANqFdsTzqZ55opnQJ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Remco van 't Veer schreef op zo 20-03-2022 om 12:44 [+0100]: > +When true, forces dnsmasq to try each query with each server strictly in > +the order they appear in @var{servers}. Can be simplified to: When try, dnsmasq queries the servers in the same order as they appear in @var{server}. dnsmasq does this voluntarily on asking, there doesn't appear to be any forcing here. Also, what does =E2=80=98strict=E2=80=99 mean here? Is it like the differe= nce between <=3D and ) id 1nVv8w-0006wW-T1 for submit@debbugs.gnu.org; Sun, 20 Mar 2022 08:58:47 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:47935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVv8v-0006wJ-6G for 54352@debbugs.gnu.org; Sun, 20 Mar 2022 08:58:45 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 5C81C32005D8; Sun, 20 Mar 2022 08:58:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 20 Mar 2022 08:58:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=remworks.net; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=98cYYSyiROX/kTJHsm4V/QMjbDD9DmXVR5wdhj 4auQU=; b=uPU69eBn0a+/D3U5fjKzdYJSl5ncnDI5xLIZ5j/VhrYRAcd8ySgWrd 2Z9YLAKGcFSEvry2Ee/lN1vKxn5wdULzonZIB3uymxn+t6Q8mht3+aTns9KVb2q3 3BW2B4zN1v3YBzExqQPK3IgG+mW+yNSHmwOqGtwUwb8LpQvfQdgmRIcm1mIkb4Ut ffo0ngaHDVtiQEIDRYTttefSlEfLycW1p3O3psFEIqhkpG2r9kU1qkZuCo4lT8La F+Lk3aaloICOVVG7rWpGBMYL+zGdCTr48m+wzqoB0pmkeI6ygrMcXpqqHHPh2WNk OLbL1Dz0dE188UYM0nIvu2725Hq+eXmA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=98cYYSyiROX/kTJHs m4V/QMjbDD9DmXVR5wdhj4auQU=; b=oZJTcj5GRyNK0uRywrBTPgxsgIfr1C2/n x5ttMjYbEnmORp8GM8st9nFNHFWP404WNTC/na8wGJO5NW3bm/k2TptMev8MFUPJ QzJ3Lwlsqqar8Q+s73Qaf8Qim2AdupO5VEVvfvG5U2+d2wlMGMHT5EpCEgCtfgDY LEgmSMR0omkZIhmF/w9KfKr+4fXCjHAl4B5+tPh/EtdfigC4cxLObKdiXiu+Vn4/ H71UeFANVGs/TQf4QSSW1oycTDpvqUi0bUo3ZCDRo5vnkYlDI/ILGBv54XMHq7PB OcizixEWKI+HYNr71qQl1exCWA2OywCZN/bLJleI5cGzaZIXouthQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeguddggeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvufgjfffkgggtsehttdertddtredtnecuhfhrohhmpeftvghmtgho uchvrghnucdkthcugggvvghruceorhgvmhgtohesrhgvmhifohhrkhhsrdhnvghtqeenuc ggtffrrghtthgvrhhnpeeuledvteevteehfeduvefhjeduvefgkeehledtgfegvdeugeff hfekieejkedtgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehrvghmtghosehrvghmfihorhhkshdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 20 Mar 2022 08:58:38 -0400 (EDT) References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> <962caf6373497ba4587aa4eacd7e21b332cdd3f4.camel@telenet.be> User-agent: mu4e 1.6.10; emacs 27.2 From: Remco van 't Veer To: Maxime Devos Subject: Re: [bug#54352] [PATCH v2] services: dnsmasq: Add more options. In-reply-to: <962caf6373497ba4587aa4eacd7e21b332cdd3f4.camel@telenet.be> Date: Sun, 20 Mar 2022 13:58:37 +0100 Message-ID: <87r16wbx1e.fsf@remworks.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54352 Cc: 54352@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) 2022/03/20 13:31, Maxime Devos: > The field strict-order? appears to be unused. Oeps, I'll fix it. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 09:05:09 2022 Received: (at 54352) by debbugs.gnu.org; 20 Mar 2022 13:05:09 +0000 Received: from localhost ([127.0.0.1]:33165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVvF7-00077D-Iv for submit@debbugs.gnu.org; Sun, 20 Mar 2022 09:05:09 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:55805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVvF5-00076i-2T for 54352@debbugs.gnu.org; Sun, 20 Mar 2022 09:05:07 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 600FC3200A47; Sun, 20 Mar 2022 09:05:01 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 20 Mar 2022 09:05:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=remworks.net; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=Kb4dL5hCZoOEO0VPGlrfG8V54srNZOrbcndYpd C35RY=; b=rJbFftM4E+plyOMZoyFLGOR8l79/UjLRQwoQNHnU3IW97+91dELlY4 0NzKz+tD2qgYc4eOFw9pngM3xeL2G+vc8hSvKX/KyNEQ84QLypjgxST6mj1LrJcL bSpmJhDdrCwMPipBT5ujXfda1piCSUHNHsJdSBUsPOCS1o/CXYVZhiV41P6kjUhj GWFPkVXIEt3W7X+2tN3CxcN6001+gwi1Dn7XVasqHj33VQXc9BM+NSFwMXtlCsbe LuLcSC5NLax8t7njoRY7ACq3SeR68+UxXJ2tSUyen+HH8fb7oYB3p7Mlz7u16AtK usKt4HobeQImgKUhiqW4ngRj7E++ecrA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=Kb4dL5hCZoOEO0VPG lrfG8V54srNZOrbcndYpdC35RY=; b=lCFXV0qv6Fpid807mV5NYniyeUhBwHC/j ghP6cFk3IUYjVFcbPGN/whq64TFyhCpucINFQ4NzuO50D7xd2K46Cb9P8YydJHtL mj7N/Uz++BC9eoCsi7i/3TwHow9mWyJIvtKPiyWNa0Yj0BDvt1Dx248HU6d0Yiqo HjLtfY5WuezUBoaMix4aDVx8gPLu96ZTNAOb20oy1zDVsR4TYrqk41pLXBGgs/IL xTiceiW+IblVD8hKtwnSWAk152v6mu+pWHMC/JgFB+6+6qEyjLQlWzzY8z2x0xOZ 6DQzE1bAlEsA+jK+xvQSshsn0M9CNjv6jURW+lcKTxqqhlDECZtkQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeguddggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvufgjfffkgggtsehttdertddtredtnecuhfhrohhmpeftvghmtgho uchvrghnucdkthcugggvvghruceorhgvmhgtohesrhgvmhifohhrkhhsrdhnvghtqeenuc ggtffrrghtthgvrhhnpeeuledvteevteehfeduvefhjeduvefgkeehledtgfegvdeugeff hfekieejkedtgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehrvghmtghosehrvghmfihorhhkshdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 20 Mar 2022 09:05:00 -0400 (EDT) References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> <8735jcddav.fsf@remworks.net> <25d571d30b3ea33ef2bdb7b09b28014c3f45a883.camel@telenet.be> User-agent: mu4e 1.6.10; emacs 27.2 From: Remco van 't Veer To: Maxime Devos Subject: Re: [bug#54352] [PATCH v2] services: dnsmasq: Add more options. In-reply-to: <25d571d30b3ea33ef2bdb7b09b28014c3f45a883.camel@telenet.be> Date: Sun, 20 Mar 2022 14:04:58 +0100 Message-ID: <87mthkbwqt.fsf@remworks.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54352 Cc: 54352@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) 2022/03/20 13:30, Maxime Devos: > In the long-term, it would be nice to eventually add error checking to > other services and fields as well. In the short-term, I would avoid > making error handling worse. > [snip] > Currently, this will silently do the wrong thing. True, I'll add sanitize code for the boolean fields. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 09:15:49 2022 Received: (at 54352) by debbugs.gnu.org; 20 Mar 2022 13:15:49 +0000 Received: from localhost ([127.0.0.1]:33195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVvPR-0007NK-C2 for submit@debbugs.gnu.org; Sun, 20 Mar 2022 09:15:49 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:40245) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVvPP-0007Mq-8u for 54352@debbugs.gnu.org; Sun, 20 Mar 2022 09:15:48 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 3D5253200974; Sun, 20 Mar 2022 09:15:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 20 Mar 2022 09:15:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=remworks.net; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=vQKAz3BCVgUPzLAQrIatsgKEBRRXs2BTBPAYbi yCM9Y=; b=hDfWZ9NeLhRHof1VvJg1h1euLaXWFZY4SIArQcKZoRAJeRcuQHYuYt 1vaBo90M0qToRaOM5nau6uwkNcuVGN1K6FS7iRFOrFdPLG5q1lyOkwFIqmxRuH0N Sw0NhjMcyUHxmeEho0H2WFWoaNVhePON2pNXJ7acyS1qNNIYwlXfrqlktdno2QQP S2UKMc6+t2xCf6xUxMpy0IvEpfMFvGVj2gU+IbDj1QDjg2/BqKZmXIZ334CBF8Qt bG3udZCz3CzB3Nxjh+vYUR7Pw2eaHzWRvr9aZ4CYH1eKko4dR9+MJYEmYpvfQe/J 6v2FkmGGPnTAIxkl8Q5kWCLU9y+ke97w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=vQKAz3BCVgUPzLAQr IatsgKEBRRXs2BTBPAYbiyCM9Y=; b=DtwDlAjb0x3JdMBY24Ep6+MMwcRiNvtN8 +/uUsOep8PQg9OawKAyrHEBjMpjFlnDI6zyDHj0HUZcMPxVrovoC1JCv2Np/j94x 36n1Kly9ZRlLLxZ1QCjFM7ShPPgU55atHFxhU2qyN/Hd3LNwWte/F2VAicZ9aakD CxczmBH56ItmR8xGlsS1EfAzqY2P7lQwryMg5a52JexQcjiyt2Jx7edXB8+VGMon z4igdqBKjlJ2xmNUZWvgFZNyn7ypaEiOsKlBtNgX86D1HDCOTY32i7pPzGygeDHT W3exMgYNysmsuggp1PuuUeTbltnBCxV8hBE4O/uiK7SgIkemLXKjQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeguddghedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvufgjfffkgggtsehttdertddtredtnecuhfhrohhmpeftvghmtgho uchvrghnucdkthcugggvvghruceorhgvmhgtohesrhgvmhifohhrkhhsrdhnvghtqeenuc ggtffrrghtthgvrhhnpeeuledvteevteehfeduvefhjeduvefgkeehledtgfegvdeugeff hfekieejkedtgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehrvghmtghosehrvghmfihorhhkshdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 20 Mar 2022 09:15:40 -0400 (EDT) References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> <956761e46ca4fdd9fb77e3d85f5eaaa125145a57.camel@telenet.be> User-agent: mu4e 1.6.10; emacs 27.2 From: Remco van 't Veer To: Maxime Devos Subject: Re: [bug#54352] [PATCH v2] services: dnsmasq: Add more options. In-reply-to: <956761e46ca4fdd9fb77e3d85f5eaaa125145a57.camel@telenet.be> Date: Sun, 20 Mar 2022 14:15:38 +0100 Message-ID: <87ils8bw91.fsf@remworks.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54352 Cc: 54352@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) I totally agree with the naming suggestions and will apply them but what if somebody has been using dnsmasq before? In that case they will not recognize the options and which may cause confusion. I guess the answer to that is that guix should not propagate the wording mistakes made upstream? To help those with prior knowledge of dnsmasq, I could add a config-file field. WDYT? From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 09:16:16 2022 Received: (at 54352) by debbugs.gnu.org; 20 Mar 2022 13:16:16 +0000 Received: from localhost ([127.0.0.1]:33202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVvPs-0007PL-LL for submit@debbugs.gnu.org; Sun, 20 Mar 2022 09:16:16 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:36732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVvPq-0007P8-8V for 54352@debbugs.gnu.org; Sun, 20 Mar 2022 09:16:15 -0400 Received: from [192.168.100.254] ([188.189.229.90]) by michel.telenet-ops.be with bizsmtp id 8dGB2700H1xgCic06dGCR3; Sun, 20 Mar 2022 14:16:12 +0100 Message-ID: <4447df8b4a84d1a0300222b832712b45eaebb13d.camel@telenet.be> Subject: Re: [bug#54352] [PATCH v2] services: dnsmasq: Add more options. From: Maxime Devos To: Remco van 't Veer Date: Sun, 20 Mar 2022 14:16:04 +0100 In-Reply-To: <87v8w8bx2o.fsf@jomco.nl> References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> <87v8w8bx2o.fsf@jomco.nl> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-wg0Tiq+aon0BAnLLDjAQ" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647782172; bh=KsIPZ5PYvbIODmpln6/yjW2HzOsepF0WV4dpx05EXyE=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=XTmnQQr5syNsoDVhTC4hLtBB+mMehALch7vnokIX2dQ44+r3QkvkDrJ7bujTqVeUf vzz/suZbhLIDwi0CiNINins93Q5rUpHSiv06RoFn6/oLfFR998fXH4G+lOzlFDVngS 2sdsVcbzrTZoQbvIxq9B/W3jsCRkOcm6q20BcDUI6rXrgEePUPK4VnFooaI+/UwpFg hvuvAmmiqGqn9UJjyunIi7gvEh9ji4wabTBxgFOYJpUlYqWSyM55Q73eexO2sfdmTe mJs7wG3sL7+r3wzi8CWatwBwTvemadJ8cOJw8qfDJ3bcqd6DXzP6Rvn2iJKbNRViYn PP2348bN466ag== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54352 Cc: 54352@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-wg0Tiq+aon0BAnLLDjAQ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Remco van 't Veer schreef op zo 20-03-2022 om 13:57 [+0100]: > > What is an =E2=80=98arbitrary identify string=E2=80=99 here?=C2=A0 What= does =E2=80=98cpe=E2=80=99 mean? > > How can I know if I need to set this, and how do I know what to set > > it > > to? >=20 > I think it stands for "Common Platform Enumerator" but I am not > really sure.=C2=A0 It's used by DNS providers to identify the client so > they know for what account they are resolving.=C2=A0 Looking at the > dnsmasq code base this option used to be called "dns-client-id" which > is a lot clearer.=C2=A0 I could change it to this older name and describe > it as above.=C2=A0 WDYT? I'm not familiar enough with DNS to tell which name would be better. In any case, it seems like you have some material for a description here. Additionally, you could add a cross-reference to the relevant RFC+section number, if you can locate it. Greetings, Maxime. --=-wg0Tiq+aon0BAnLLDjAQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjcpFBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7kZdAP9hCSIbnBacfOs/pYfznE5D/KaC b20Mlr+M97M+PMWgIwD+Mv1oaqsz/GS4nu+kucHkAxOrO1p4mON1ef4m7hV0pQA= =X1YE -----END PGP SIGNATURE----- --=-wg0Tiq+aon0BAnLLDjAQ-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 09:17:51 2022 Received: (at 54352) by debbugs.gnu.org; 20 Mar 2022 13:17:51 +0000 Received: from localhost ([127.0.0.1]:33207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVvRP-0007SB-0N for submit@debbugs.gnu.org; Sun, 20 Mar 2022 09:17:51 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:53872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVvRN-0007S2-7z for 54352@debbugs.gnu.org; Sun, 20 Mar 2022 09:17:49 -0400 Received: from [192.168.100.254] ([188.189.229.90]) by laurent.telenet-ops.be with bizsmtp id 8dHn2700Z1xgCic01dHnyG; Sun, 20 Mar 2022 14:17:48 +0100 Message-ID: Subject: Re: [bug#54352] [PATCH v2] services: dnsmasq: Add more options. From: Maxime Devos To: Remco van 't Veer Date: Sun, 20 Mar 2022 14:17:47 +0100 In-Reply-To: <87ils8bw91.fsf@remworks.net> References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> <956761e46ca4fdd9fb77e3d85f5eaaa125145a57.camel@telenet.be> <87ils8bw91.fsf@remworks.net> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-Bjy+bsG2ckLs55r8Cl94" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647782268; bh=pA9n/MpE2wFAahhhQdf9e2Qn8xTpbGPpeV66ByValL0=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=eH7D2U783WKPx0nkBctZ41y8+SflgmKgGqP1jq8oLWyUh0g/6OIpLUhQQWR46oMyR TRhueHm0fA4gKjUeYsd4PaVl95SLzNyj2Jv2dp3a/bAYXvBI0xVdQ+wcjQOxq9ZFvA wP7/YvRS8amveOxWaHhXDnyyKAic/vI/2FbUTrwIPnqoAfRvthYl87kmiPu/+/a+sV 1h2BD2gjoc6dGVPqJTcr72dWrQKeXFAI249H5f1ZI+8Clk/67Y9CTZQfMxoAUXqqGM qHTlWXkkbHcWDPgyduGa9dIgEDIXWBuRqmchL/sXQq6ZAPownZSmxvjI8H+yWi4Ep9 4cqmuy5yIh0nw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54352 Cc: 54352@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-Bjy+bsG2ckLs55r8Cl94 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Remco van 't Veer schreef op zo 20-03-2022 om 14:15 [+0100]: > I totally agree with the naming suggestions and will apply them but what > if somebody has been using dnsmasq before?=C2=A0 In that case they will n= ot > recognize the options and which may cause confusion.=C2=A0 I guess the an= swer > to that is that guix should not propagate the wording mistakes made > upstream? Perhaps some lines like =E2=80=98This option corresponds to the --foo-bar command line option.=E2= =80=99 could be added? Greetings, Maxime. --=-Bjy+bsG2ckLs55r8Cl94 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjcpexccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7oIaAQCdkNBmEZfleUXRF7A2ple5Bkfj vGrzwuCDEruK6MPGXAD+Lvh/d5EHgshOpj5KdyS0mmB0auRYkRaOUrzVy3R+hAA= =YMdO -----END PGP SIGNATURE----- --=-Bjy+bsG2ckLs55r8Cl94-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 09:20:56 2022 Received: (at 54352) by debbugs.gnu.org; 20 Mar 2022 13:20:56 +0000 Received: from localhost ([127.0.0.1]:33224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVvUO-0007Xo-Dd for submit@debbugs.gnu.org; Sun, 20 Mar 2022 09:20:56 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:56822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVvUM-0007Xg-MW for 54352@debbugs.gnu.org; Sun, 20 Mar 2022 09:20:55 -0400 Received: from [192.168.100.254] ([188.189.229.90]) by laurent.telenet-ops.be with bizsmtp id 8dLt270081xgCic01dLtKs; Sun, 20 Mar 2022 14:20:53 +0100 Message-ID: <60e3ad2ee959a272fb6abbdbf3f07cc2a9abfe5e.camel@telenet.be> Subject: Re: [bug#54352] [PATCH v2] services: dnsmasq: Add more options. From: Maxime Devos To: Remco van 't Veer Date: Sun, 20 Mar 2022 14:20:52 +0100 In-Reply-To: <87ils8bw91.fsf@remworks.net> References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> <956761e46ca4fdd9fb77e3d85f5eaaa125145a57.camel@telenet.be> <87ils8bw91.fsf@remworks.net> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-7iJ+P12gXrGE2BXRMYjW" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647782453; bh=IL8gvF/RefFzOHm3lVAQQsYZKzELil2naLNcxzL1ucw=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=emmsoLW+OGIFIlD0HOcftbqcPl9Yw5jH7Inw/IlgRj8NTONZcd3FVcJQtGarMCP90 CtMbGaTBvzBoWwuwxQz3BowzHkM/dWxM7hGvTB+ga1TzAXobumYwwQ7VsuPgHJCm/q 3x8VyT3SrH6gFrcRIY7aGjlnUNFsaOzj2aFtsizwn+cS51InHtHiRpe3UGfARFkje2 42/qPCYl7+UCbYgvzu3u0vL3HbgWfQZVNxy7o8y945tUoLhg2lqnWH+D19WVHT3P96 NTXWDyGAG1nmOllzupwt5UrVnjP39Xs8y23yZk/HQDBfhtyVFyqyNovQDl0RQnB9GD 4g6LGP0fp87jg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54352 Cc: 54352@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-7iJ+P12gXrGE2BXRMYjW Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Remco van 't Veer schreef op zo 20-03-2022 om 14:15 [+0100]: > [...] I could add a config-file field.=C2=A0 WDYT? I don't think that's necessary but it's certainly an option. This raises some questions though: if something is specified in both the fields and the configuration file, what will dnsmasq use? Greetings, Maxime. --=-7iJ+P12gXrGE2BXRMYjW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjcqNBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7vATAP9XyPSg8jrg/nANX53p1vdd/0hh gigqWbSVgh0wxJKaCwEAk86btraMyhwvhBtwdn3mSQJzY8M+gBP4nRawNL3EagM= =5XtF -----END PGP SIGNATURE----- --=-7iJ+P12gXrGE2BXRMYjW-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 11:09:19 2022 Received: (at 54352) by debbugs.gnu.org; 20 Mar 2022 15:09:19 +0000 Received: from localhost ([127.0.0.1]:34949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVxBG-0002Kq-8U for submit@debbugs.gnu.org; Sun, 20 Mar 2022 11:09:19 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:60315) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVv8C-0006v1-BY for 54352@debbugs.gnu.org; Sun, 20 Mar 2022 08:58:01 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id F114C320094D; Sun, 20 Mar 2022 08:57:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 20 Mar 2022 08:57:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jomco.nl; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=mpXkYfZmEdEIlD hFLM4bAKlpqzPmp69TmfQaWMJx1us=; b=eM/S5Nyw77Ea2jXf9AMVrCuluyUhpV j/G4Ay7iwT29kEBMNI9YDzixmLnnlAWT2r7o0xSYPu9nouqU5IXg5KjRxjqK3KjY URl4lSKxrpoTeO5JYPnwyHDryc+kCm6N4KTOtxYeJhmgtejzfqAeb5t1wruXms1K +ahnR7vu/Y5tnG3VKjuzp7iMc/u02qnY7OWEI6b1jgmy/GQZt33M3ZKh10a7hXRG DNIfNpU5Ouuy0onIBmQXq+7U2Jq6xJYtvojSNoOM52WMQhPCNtVGPRs7DEeP7hVP 6u+eZ5zUnRYJliXdcZMKlUzjpv42zTCINg0qKy6M/Hk3/05yTdU+8slg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=mpXkYfZmEdEIlDhFLM4bAKlpqzPmp69TmfQaWMJx1 us=; b=B8nDcIIGO3Kw/dqVyypXnZ4JU4juZdtuybHaO2UL2YrXI6atORIxLTI9r 1fQ6yvNy3o5Prxxk5Wfwfsb3auNlWt17EDbo0HiVPccUKVd9gw6KRTHPQHoJxXO5 DL7lK4aVbSi0axWPro2xLtSf4mHT4t4E0xp0+2Naoha1FJ6YvC7ITt2mTMVLngvJ RvxKutsM9GSMI3lnXG8R7vZR8n1nciPvsWty9Oe5lNbnlrCZNgPHq7bjEysfC8Y1 UyZzlrFJpKZ6j8OttJUYG5zY9BXhp5V6i1wLAS6EwBbCfhd7ZyF3a/HuP3wyAIb7 OmRJzdjWNmEaWENExDPaPeOgybVAw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeguddggeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvufgjfffkgggtgfesthhqredttderjeenucfhrhhomheptfgvmhgt ohcuvhgrnhcukdhtucggvggvrhcuoehrvghmtghosehjohhmtghordhnlheqnecuggftrf grthhtvghrnhepheeggfehleefhefhvddutddtieejkeelfeeggfdvtefhkeegffekheet udefffetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprhgvmhgtohesjhhomhgtohdrnhhl X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 20 Mar 2022 08:57:52 -0400 (EDT) References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> User-agent: mu4e 1.6.10; emacs 27.2 From: Remco van 't Veer To: Maxime Devos Subject: Re: [bug#54352] [PATCH v2] services: dnsmasq: Add more options. In-reply-to: Date: Sun, 20 Mar 2022 13:57:51 +0100 Message-ID: <87v8w8bx2o.fsf@jomco.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54352 X-Mailman-Approved-At: Sun, 20 Mar 2022 11:09:17 -0400 Cc: 54352@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > What is an =E2=80=98arbitrary identify string=E2=80=99 here? What does = =E2=80=98cpe=E2=80=99 mean? > How can I know if I need to set this, and how do I know what to set it > to? I think it stands for "Common Platform Enumerator" but I am not really sure. It's used by DNS providers to identify the client so they know for what account they are resolving. Looking at the dnsmasq code base this option used to be called "dns-client-id" which is a lot clearer. I could change it to this older name and describe it as above. WDYT? From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 21 11:22:47 2022 Received: (at 54352) by debbugs.gnu.org; 21 Mar 2022 15:22:47 +0000 Received: from localhost ([127.0.0.1]:37892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWJrr-0002Jy-Fm for submit@debbugs.gnu.org; Mon, 21 Mar 2022 11:22:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWJrp-0002Jm-JC for 54352@debbugs.gnu.org; Mon, 21 Mar 2022 11:22:46 -0400 Received: from [2001:470:142:3::e] (port=44224 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWJrj-0007m6-7J; Mon, 21 Mar 2022 11:22:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=+wvuD6wR6lDXtgmXJezOw3nXkXOGFA2ugu2IjUXWeVY=; b=Rh8dpZvVP1VFo+JIvAyp OvIQvGTr/oJWK8KDxmWLyaLNBSbxO8Ysedqedk+Y/sfQnBf2RbgyaeGoJ+yGOMzwUD6uLghfce3PQ ba0xHdaKx51k9WMKxIoZklZOusQRvCdcH3hdq4+K+yqZrC/7RJqtUW2CAc5UHX2r4jUpN1Sa73LyX G7aSfEqTpwdcHGrQkNilGlUl07/jQg8+wGeLB7S9vG5VboRJPXS1oSG6VMlfGizX0oXHMfoVJFRfH ODjs7BVuk8vPYDA4Xy5BKYci4ppo5eoXlKL790+hLji2Q/pGyEZ1mYlvHBzAhbDLG42lwvkfrkO0n 5ygAWjUPjtNOZA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:54115 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWJri-0006Xw-RK; Mon, 21 Mar 2022 11:22:39 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxime Devos Subject: Re: bug#54352: [PATCH] services: dnsmasq: Add more options. References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> Date: Mon, 21 Mar 2022 16:22:36 +0100 In-Reply-To: (Maxime Devos's message of "Sun, 20 Mar 2022 12:56:22 +0100") Message-ID: <8735jbjpoj.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54352 Cc: 54352@debbugs.gnu.org, Remco van 't Veer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Maxime, Maxime Devos skribis: > Remco van 't Veer schreef op zo 20-03-2022 om 12:44 [+0100]: >> +=C2=A0 (forward-private-reverse-lookup? >> +=C2=A0=C2=A0 dnsmasq-configuration-forward-private-reverse-lookup? >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (default #t))=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 ;boolean >> +=C2=A0 (strict-order?=C2=A0=C2=A0=C2=A0 dnsmasq-configuration-strict-or= der? >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (default #f))=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 ;boolean > > It would be nice to verify that these are, in fact, booleans, > using field sanitizers. See, e.g., ensure-setuid-program-list > in (gnu system). I think this suggestion is beyond the scope of this review: we=E2=80=99ve n= ever used sanitizers like this before (or almost), and this particular piece of code doesn=E2=80=99t use them. Also, with the recent discussion about the introduction of contracts, I=E2=80=99d rather wait an use contracts everywhere once they=E2=80=99re av= ailable. Thoughts? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 21 14:36:45 2022 Received: (at 54352) by debbugs.gnu.org; 21 Mar 2022 18:36:45 +0000 Received: from localhost ([127.0.0.1]:38288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWMtZ-00023j-5n for submit@debbugs.gnu.org; Mon, 21 Mar 2022 14:36:45 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:57776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWMtX-00023a-Jp for 54352@debbugs.gnu.org; Mon, 21 Mar 2022 14:36:44 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by michel.telenet-ops.be with bizsmtp id 96ci270024UW6Th066cidJ; Mon, 21 Mar 2022 19:36:42 +0100 Message-ID: <2287729e13ea8689713cefe61e28abba9e817308.camel@telenet.be> Subject: Re: bug#54352: [PATCH] services: dnsmasq: Add more options. From: Maxime Devos To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Date: Mon, 21 Mar 2022 19:36:41 +0100 In-Reply-To: <8735jbjpoj.fsf_-_@gnu.org> References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> <8735jbjpoj.fsf_-_@gnu.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-sSG/NNMlYvSg1cQHB3Z5" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647887802; bh=GATs9xizJsK0vcXk+SJm6eqRKzH/974e/tsU9TGiL4E=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=ZbSQ2Y4JxCy/8KxqrRMLlcg+M+YxNU9eJJMHdLGl5W2gmuhijXd57K/2b0L5vcafe l4WRo4PDW+f+AeGCnVy+A4KyigrhbWhLvevL0ht6m3znoXf9tJ6E64xEaDo2HIeHz8 wyoK2CnmHFFpIYNsWBaJlCwaAaadb00y4BDMmTZ57rqoFHXRgAmmjM2+Fv4ON6KKaD unHLlybGGMx8WR9ZnZ5F9Na2wQzvh+KjDjQyFs3cUKt0p7OtG6YiTD5E1a2ktyBstL 3sI+pGsz6E+mtbYs7YNs/cB0K9ISbjYg2FPl9P/gRM2pcDAe1HyOg7YIoP0v4yMfZU fHMXbHt57Qyvw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54352 Cc: 54352@debbugs.gnu.org, Remco van 't Veer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-sSG/NNMlYvSg1cQHB3Z5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s schreef op ma 21-03-2022 om 16:22 [+0100]: > I think this suggestion is beyond the scope of this review: we=E2=80=99ve= never > used sanitizers like this before (or almost), and this particular piece > of code doesn=E2=80=99t use them. >=20 > Also, with the recent discussion about the introduction of contracts, > I=E2=80=99d rather wait an use contracts everywhere once they=E2=80=99re = available. Seems reasonable to me, given that the specifics weren't discussed yet, although _everywhere_ (for all procedures, records, ...) seems a bit much, unless you meant every field of the dnsmasq record. Greetings, Maxime. --=-sSG/NNMlYvSg1cQHB3Z5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjjFuRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7riyAP467NKyMBcT8gTFjtPHT/4blClG JLQfTZKajoDOOVamOQEA3unPRxZ7Hgq47GZD+WKOVw2tX8cHalndJry7fKRPGgE= =Z1db -----END PGP SIGNATURE----- --=-sSG/NNMlYvSg1cQHB3Z5-- From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 22 03:37:06 2022 Received: (at 54352) by debbugs.gnu.org; 22 Mar 2022 07:37:06 +0000 Received: from localhost ([127.0.0.1]:39073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWZ4k-0008Pj-Iv for submit@debbugs.gnu.org; Tue, 22 Mar 2022 03:37:06 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:44451) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWZ4i-0008PB-QN for 54352@debbugs.gnu.org; Tue, 22 Mar 2022 03:37:05 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 94C3F3200D53; Tue, 22 Mar 2022 03:36:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 22 Mar 2022 03:36:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=remworks.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=P/z5Q42yIMMkq7 RzbU4Cj5CmeerxwlDnKGe1mIUxfkE=; b=XM2kwmiKevh7iDleUY/qKKQOzHyvFo irk2WXe/+bUy4434vDf5f5uld945cZbsu7dtXYbLVIoBWP1+zRTgmb9+4QN8NaAn 6DLPvg2BfjR5fnFpGsVaJ/OokfHr5j73Ytdpb1gP43v2iGS2PLkXuml26nbC+Xnm tHVbb7rPLx/thPucbQnbfZl5nH1lG3KhFKrggXJMcx9LEWicBPPHRY22rKefp/v5 TtM3fZDvPuJ5wjn1PGfUUQEXxLm+uTq2ukpygC5m+afFxQsCtyxueSIsDj3nYM/0 3xXo7shr0mkwmRSOSZfyQUX303ThWDWBEyKuKiBOYXRv/pCOHglbpHkA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=P/z5Q42yIMMkq7RzbU4Cj5CmeerxwlDnKGe1mIUxf kE=; b=YGjRLiTex0Sh3vXsSVcTatGAsueaDlHE3WsIWWDJGN2Ucx1v+8ztcFJFB +hNS1rcgm4DjPnQ2VWudLEkQvYykSIIdAKDQYMOgvfCUgS+TvbWRBTBli56g0uQK zdkeSBdOnS6cV5H07vLaiQ4TYpMvdhd/y/dWj0ojtayTC9FpiWxCQpK48aYeffIf i1N89SwKzvtsDzsTKii9AIHwmT6Y9Qkbzm3CQ997955VvGOceUiEsOo4hqsCU6gZ nJIsdFphvcUqdfCEbSVlG1uJYmx8rD5aNw+exxk1jH0Qm7YUcqi8dscjAK9OI7OA Rhni8db2zAWvAUT6V+3yXVbmWTS7g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeggedguddtkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvffujgffkfggtgfgsehtqhertddtreejnecuhfhrohhmpeftvghm tghouchvrghnucdkthcugggvvghruceorhgvmhgtohesrhgvmhifohhrkhhsrdhnvghtqe enucggtffrrghtthgvrhhnpeefteefueefvddvheeltdffgeevheehgefggefgfeetuedv keekkeefvdfgiedufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehrvghmtghosehrvghmfihorhhkshdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 22 Mar 2022 03:36:57 -0400 (EDT) References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> <8735jbjpoj.fsf_-_@gnu.org> <2287729e13ea8689713cefe61e28abba9e817308.camel@telenet.be> User-agent: mu4e 1.6.10; emacs 27.2 From: Remco van 't Veer To: Maxime Devos Subject: Re: bug#54352: [PATCH] services: dnsmasq: Add more options. In-reply-to: <2287729e13ea8689713cefe61e28abba9e817308.camel@telenet.be> Date: Tue, 22 Mar 2022 08:36:54 +0100 Message-ID: <8735jabfqh.fsf@remworks.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54352 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 54352@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) 2022/03/21 19:36, Maxime Devos: > [[PGP Signed Part:Undecided]] > Ludovic Court=C3=A8s schreef op ma 21-03-2022 om 16:22 [+0100]: >> I think this suggestion is beyond the scope of this review: we=E2=80=99v= e never >> used sanitizers like this before (or almost), and this particular piece >> of code doesn=E2=80=99t use them. >> >> Also, with the recent discussion about the introduction of contracts, >> I=E2=80=99d rather wait an use contracts everywhere once they=E2=80=99re= available. > > Seems reasonable to me, given that the specifics weren't discussed yet, > although _everywhere_ (for all procedures, records, ...) seems a bit > much, unless you meant every field of the dnsmasq record. I can add something like the following: (define (assert-boolean value) (unless (false-if-exception (boolean? value)) (error-out (format #f "expected a boolean, got: ~s" value))) value) and use it to do (sanitize assert-boolean) on all boolean fields of dnsmasq but I agree with Ludo about this being a bigger issue which can be solved much more elegantly (including i18n and source location etc). In the above I borrowed error-out from knot in the same file which also doesn't do i18n and source locations. I'd like to leave it out because the codebase has plenty more unverified booleans and basic if-statements which go the unexpected route when passed a "false" string. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 22 03:40:35 2022 Received: (at 54352) by debbugs.gnu.org; 22 Mar 2022 07:40:35 +0000 Received: from localhost ([127.0.0.1]:39079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWZ87-0008UY-4X for submit@debbugs.gnu.org; Tue, 22 Mar 2022 03:40:35 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:33515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWZ85-0008UM-Cl for 54352@debbugs.gnu.org; Tue, 22 Mar 2022 03:40:33 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 7B5953201E09; Tue, 22 Mar 2022 03:40:27 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 22 Mar 2022 03:40:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=remworks.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=FLPq6P7VDr0SKv gQLnqJLy8vJ08QIJDCBuQ7Gk6W4ow=; b=bDVbqne0FdDXSzJiAJzh+Jk7cEDYD4 7mh+ck50CCcVi3cclyppL9lVmEFhD1gWknP+pGwdX6bIjbwbkOFoJyDY9bCb4gXY na8O/kbF/6DmeERLnbRKwe+Hqvg1VmLY8/loduCAzmQxQVks0zJHxWwzbHdqjOEH NX9QXyuzWKbCP16XGoQit/YbkKgZ3voibnJN0KI690SJteRGkvBXzHD9O2w86ywd C4AodEXUHOvENwi5tAkElLqPO43dEPxBmHU5jhBZk3/6ANvZFwRcpzVeYfK/KQ8D BVj/dzx9pL+37SGq47oe34ME4TRMpyz3PYx8LAgMJPnBqcHToriGDwRA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=FLPq6P7VDr0SKvgQLnqJLy8vJ08QIJDCBuQ7Gk6W4 ow=; b=ltOIHCg9eh0ZXeaxP0D9OxbZPye0QjL2wEA3Xq63GlgcjUIPshOcKBfcN s8kVVPYNSJavQTqUMS8n9vh7x+Q6v3gLEmDZXvWFQ/i5cNvizmEUe3whc40LHrDy 0SDvJxaZ+chj+23Fn1aFY1eNep4Mj4W9h7S7lJOehKUrsvufSZoVs1dn9tM+Quqn BZzjoMiTTqrC/iUC7b66H9aBL4Rvpom0/W9QcUXqGT4gdHy7lNH7I4z8g5Hp4tGU /cKsyGK6f/V2rhyAaM/7V3q6nXWi3NYfYEKpS0mHKvxAeCHQ1aW6b5df4X/vWa+r 5ExnOSr1UdINdwyh/w33TMw+RdgfA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeggedguddtlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvffujgffkfggtgfgsehtqhertddtreejnecuhfhrohhmpeftvghm tghouchvrghnucdkthcugggvvghruceorhgvmhgtohesrhgvmhifohhrkhhsrdhnvghtqe enucggtffrrghtthgvrhhnpeefteefueefvddvheeltdffgeevheehgefggefgfeetuedv keekkeefvdfgiedufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehrvghmtghosehrvghmfihorhhkshdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 22 Mar 2022 03:40:26 -0400 (EDT) References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> <956761e46ca4fdd9fb77e3d85f5eaaa125145a57.camel@telenet.be> <87ils8bw91.fsf@remworks.net> <60e3ad2ee959a272fb6abbdbf3f07cc2a9abfe5e.camel@telenet.be> User-agent: mu4e 1.6.10; emacs 27.2 From: Remco van 't Veer To: Maxime Devos Subject: Re: [bug#54352] [PATCH v2] services: dnsmasq: Add more options. In-reply-to: <60e3ad2ee959a272fb6abbdbf3f07cc2a9abfe5e.camel@telenet.be> Date: Tue, 22 Mar 2022 08:40:25 +0100 Message-ID: <87y212a106.fsf@remworks.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54352 Cc: 54352@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) 2022/03/20 14:20, Maxime Devos: > Remco van 't Veer schreef op zo 20-03-2022 om 14:15 [+0100]: >> [...] I could add a config-file field.=C2=A0 WDYT? > > I don't think that's necessary but it's certainly an option. > This raises some questions though: if something is specified > in both the fields and the configuration file, what will dnsmasq > use? Ah, good point. I'll prepare a new patch when it comes up and work it out then. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 22 03:48:47 2022 Received: (at 54352) by debbugs.gnu.org; 22 Mar 2022 07:48:47 +0000 Received: from localhost ([127.0.0.1]:39099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWZG3-0000IY-D0 for submit@debbugs.gnu.org; Tue, 22 Mar 2022 03:48:47 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:55001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWZG1-0000IM-TF for 54352@debbugs.gnu.org; Tue, 22 Mar 2022 03:48:46 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 14A793201E3E; Tue, 22 Mar 2022 03:48:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 22 Mar 2022 03:48:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=remworks.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=y3XH4ldwpc1xBh 99tvK7P9Sjz5IOLuNPCE24sVnAkJM=; b=kUxefRbOqGOIg6hcaAB5yGYXghll3E lQHkaHrN9KGaVPNQt2whX5FrD79LRDPvMoNLSWiifvRfIin5rDDvfRB11vGoi1yF 4WOwsa5hfJpYAy4hxzgwnmywMTXBn4tGQYV1U9LEbB+D/FyMhSNYjf4IxfvC3GYX myhu8uwlnOlPGWoO6cpC3FuP0l1QlSMeaBDXD91Yh1lmc2xQrMLn9HE9Mz83JfEY IvW4M/WzmxqCREsSO0poBfvVW49IMdvZ4H9nGr/4mvvGiS+d59gEp27kKm7bxoYK L/1QD4ds8nDbO6Wwj9DyxcrMQq0JCnHpMiTpzThO5UohYF/nz9E7fGFw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=y3XH4ldwpc1xBh99tvK7P9Sjz5IOLuNPCE24sVnAk JM=; b=NBEO/M0acVFfZ2gAexzp/7vKRRc4CdN5lDMQIYBLVSR034teWdaFZKlXH nwVIwp0hlaW4NfoBdDisTaob6kyPKQ+vVb0iJhQtjxYrRUEHvmJHA6jhMU0XGXXa XIEDkAYwdoWRJJDGmnR4wFWw5o4Xcag+ATZqQAxq4aA7PErQJgInqjQKgXvbJ49H 7UGOMJDMBEKycet/I/jKRfTkQmBFv6CmD30F/DrlcDLplyYxb9JqMk57iIvKovtH SI9azBfJTGygpiYc7HNY09ZkvUk+7mExLDZvA79xY2h5nJGF9Gb0T+CbfrRyM9Vs 9eK5yOfPcwMiIsl5qdv8mmCZUAd9Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeggedguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvffujgffkfggtgfgsehtqhertddtreejnecuhfhrohhmpeftvghm tghouchvrghnucdkthcugggvvghruceorhgvmhgtohesrhgvmhifohhrkhhsrdhnvghtqe enucggtffrrghtthgvrhhnpeefteefueefvddvheeltdffgeevheehgefggefgfeetuedv keekkeefvdfgiedufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehrvghmtghosehrvghmfihorhhkshdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 22 Mar 2022 03:48:38 -0400 (EDT) References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> <956761e46ca4fdd9fb77e3d85f5eaaa125145a57.camel@telenet.be> <87ils8bw91.fsf@remworks.net> User-agent: mu4e 1.6.10; emacs 27.2 From: Remco van 't Veer To: Maxime Devos Subject: Re: [bug#54352] [PATCH v2] services: dnsmasq: Add more options. In-reply-to: Date: Tue, 22 Mar 2022 08:48:37 +0100 Message-ID: <87tubqa0mi.fsf@remworks.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54352 Cc: 54352@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) 2022/03/20 14:17, Maxime Devos: > Perhaps some lines like > > =E2=80=98This option corresponds to the --foo-bar command line option.= =E2=80=99 > > could be added? I can't find any precedence in the guix manual about corresponding command line options like that, so let's not. Maybe it won't be confusing and it's pretty easy to find the service definition to find out. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 22 03:55:00 2022 Received: (at 54352) by debbugs.gnu.org; 22 Mar 2022 07:55:00 +0000 Received: from localhost ([127.0.0.1]:39105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWZM4-0000S6-2a for submit@debbugs.gnu.org; Tue, 22 Mar 2022 03:55:00 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:48423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWZM1-0000Rn-To for 54352@debbugs.gnu.org; Tue, 22 Mar 2022 03:54:58 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 1CEBB3200AC9; Tue, 22 Mar 2022 03:54:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 22 Mar 2022 03:54:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=remworks.net; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=tdWT+PIHG2QimXeL0zRcXPn/gG6xuXSWjYqvBk JAejM=; b=cviHVi0E+N0zsNnIpVcFcuBfPfJB7238NkGEIrV5Y4Tn7qfptkiSld 8jz1QTLWByeMoFs05CLwYmMCg3mBxM4TbvRJLrkyhv/dkBmBq89CLAODp85R0Vig sr+wQQsjdxjnpFrF/cBBsgOfKQ7XaGxRe+Cthpg4mXw3Nnz2phFvbsDCi69PVO9R v619XvNAn3xuKR8GYVYSi8YutoWfhDMD6P5T3OTMQgdPlaEgGkoCNoLlF4JHEg8w wQs67cZXRvXQFuTT24ccd15zRECYE9GWdLUKnktabJmp+cJZJqtRCKaJiRzFQ2lU VGLBEgcZrrwZO6z8z7uRyMlLb4bu9vuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=tdWT+PIHG2QimXeL0 zRcXPn/gG6xuXSWjYqvBkJAejM=; b=A/C56wl8PcAJk1En6iQhNtjCr7PX3q+1l xAn9Pm+2OOo1psaPjtfW0PDblRF3F1j8cnmqr6Brl4XBNGTSSJzyeBVra6WBJGrw ndUNUmM5r6ePsG6+BAU+i7hdBlyQAoLUGGjC9Z9/9yptv7Z5WHYNFJNhOWudMOnV 1P5wspfu8o0aV7AXT4yaJKCtQ4NM53//W3ymaz57CYMug+gF0gHgPNtkUPWF5FCV ox0jnS5iJcomHtFs/DhzFNNI2V9R/JLL1985QYLvBAWTledgyZnU1iyT1TCOQqz2 dutqr46Z8+omDlXyO6Hre0VtgaledjQqEHQc3v1GB8z9tPRzS9zeQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeggedgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvffujgffkfggtgesthdtredttdertdenucfhrhhomheptfgvmhgt ohcuvhgrnhcukdhtucggvggvrhcuoehrvghmtghosehrvghmfihorhhkshdrnhgvtheqne cuggftrfgrthhtvghrnhepueelvdetveetheefudevhfejudevgfekheeltdfggedvueeg fffhkeeijeektdegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomheprhgvmhgtohesrhgvmhifohhrkhhsrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 22 Mar 2022 03:54:50 -0400 (EDT) References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> <87v8w8bx2o.fsf@jomco.nl> <4447df8b4a84d1a0300222b832712b45eaebb13d.camel@telenet.be> User-agent: mu4e 1.6.10; emacs 27.2 From: Remco van 't Veer To: Maxime Devos Subject: Re: [bug#54352] [PATCH v2] services: dnsmasq: Add more options. In-reply-to: <4447df8b4a84d1a0300222b832712b45eaebb13d.camel@telenet.be> Date: Tue, 22 Mar 2022 08:54:49 +0100 Message-ID: <87pmmea0c6.fsf@remworks.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54352 Cc: 54352@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) 2022/03/20 14:16, Maxime Devos: > I'm not familiar enough with DNS to tell which name would be better. > In any case, it seems like you have some material for a description > here. Additionally, you could add a cross-reference to the relevant > RFC+section number, if you can locate it. Well, that was a bit of a challenge but I did find out it's a EDNS field, CPE stands for "Customer-premises Equipment" and that field is in an IANA unassigned range but, apparently, used by DNS providers to identify their clients/accounts. So what do you think about: If set, add a CPE (Customer-Premises Equipment) identifier to DNS queries which are forwarded upstream. I don't want to dwell on the unofficial status too much. Also, I changed the field name from additional-cpe-id to just cpe-id because "additional" seems a bit redundant. WDYT? From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 22 06:02:50 2022 Received: (at 54352) by debbugs.gnu.org; 22 Mar 2022 10:02:50 +0000 Received: from localhost ([127.0.0.1]:39229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWbLm-0005s2-0L for submit@debbugs.gnu.org; Tue, 22 Mar 2022 06:02:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWbLh-0005rj-7K for 54352@debbugs.gnu.org; Tue, 22 Mar 2022 06:02:48 -0400 Received: from [2001:470:142:3::e] (port=33622 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWbLY-0004fr-Um; Tue, 22 Mar 2022 06:02:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=fOBYOAfozZ79k+J9BqeDTpLyWBPvLUgHzKWXs1yVzhM=; b=R6Uy9H7UgX0JJ4+3gDyF U/lumKGY7NMBVAQo8djNnC10hIa2yY9LtxYFIWCvzXea0LP0ZocjE3Sh9siaUIw/NHtKLj0Sp6/j6 izQMlWaiMw03dxK9AmBbG2UVB559vyLmqa69QEvDJKVMtMR29SSed99d5k9oXKza/R/A7YE712VA4 eKfk+PRWxCsKYLwf4nirJGoirqyu0+RvHCfe8T1klqPxgBLLqzby5naQUQTPd6EXgVkh/vAA1bFn2 LwZgkLbFjZf+o8fViYbO6/AD7gDCEKcPW9JsphcyON+4rEhySGwKbOhoZj1Oliltj9sQwja2PYhrR aCEIvFQ9+X3Btw==; Received: from [193.50.110.177] (port=51484 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWbLT-0005f3-FI; Tue, 22 Mar 2022 06:02:35 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Remco van 't Veer Subject: Re: bug#54352: [PATCH] services: dnsmasq: Add more options. References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> <8735jbjpoj.fsf_-_@gnu.org> <2287729e13ea8689713cefe61e28abba9e817308.camel@telenet.be> <8735jabfqh.fsf@remworks.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 2 Germinal an 230 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 22 Mar 2022 11:02:29 +0100 In-Reply-To: <8735jabfqh.fsf@remworks.net> (Remco van t. Veer's message of "Tue, 22 Mar 2022 08:36:54 +0100") Message-ID: <87mthii9u2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54352 Cc: 54352@debbugs.gnu.org, Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Remco van 't Veer skribis: > 2022/03/21 19:36, Maxime Devos: > >> [[PGP Signed Part:Undecided]] >> Ludovic Court=C3=A8s schreef op ma 21-03-2022 om 16:22 [+0100]: >>> I think this suggestion is beyond the scope of this review: we=E2=80=99= ve never >>> used sanitizers like this before (or almost), and this particular piece >>> of code doesn=E2=80=99t use them. >>> >>> Also, with the recent discussion about the introduction of contracts, >>> I=E2=80=99d rather wait an use contracts everywhere once they=E2=80=99r= e available. >> >> Seems reasonable to me, given that the specifics weren't discussed yet, >> although _everywhere_ (for all procedures, records, ...) seems a bit >> much, unless you meant every field of the dnsmasq record. Sorry, I wasn=E2=80=99t clear. I mean, when we have contracts in Guix, we = can start using them =E2=80=9Ceverywhere=E2=80=9D in Guix, primarily for config= uration records. But we=E2=80=99re not there yet and how exactly we=E2=80=99ll get= there remains to be seen. > I can add something like the following: > > (define (assert-boolean value) > (unless (false-if-exception (boolean? value)) > (error-out (format #f "expected a boolean, got: ~s" value))) > value) > > and use it to do > > (sanitize assert-boolean) My suggestion is to just do nothing for the dnsmasq record; just leave a comment about the expected type next to it and in the manual, as is done for almost every other configuration record. Eventually we=E2=80=99ll turn that into contracts with good error reporting= , I hope, but that=E2=80=99s not something you can do right now. :-) Thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 23 03:07:53 2022 Received: (at 54352) by debbugs.gnu.org; 23 Mar 2022 07:07:53 +0000 Received: from localhost ([127.0.0.1]:42551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWv60-0001cm-K7 for submit@debbugs.gnu.org; Wed, 23 Mar 2022 03:07:53 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:35679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWv5y-0001cO-PC for 54352@debbugs.gnu.org; Wed, 23 Mar 2022 03:07:51 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id A58595C00E6; Wed, 23 Mar 2022 03:07:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 23 Mar 2022 03:07:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=remworks.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm3; bh=reY60N9VFg/Cn1a/LItwnVPHnI9UdKsKUZFCDv ZemEk=; b=PB+4E6YRM6XdXSJCw+/C2Zev/XBQZ/GnZMwBI1AbNPeBCaxCpuQudR 2t8a4yvPZWctB6DxBJHYs7gzOaUjYZ/dAROntRf5Wwky6VOQoPb8WH0Ie2ZpMtFI xzQRgkvY29uU83oNNk0lVXU+P6rI/iRX0ppaTpkcll1zKluepRHX5Q8XhpC7zhep 3DqaLDuv9GLtUrNAVZharHDnRyyf+1ifk3BidFgohpxcBsIDBuh3o1uey2UFBNxU OM+DU6X/S2oKsyEkidW3Czi4xFVmAypCRUafLi1xRvalOHTDxY2IlUJVrwEW0nMb PHp7WsFfD/Hgs9fMZKWVA0t8vqZlHx1w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=reY60N 9VFg/Cn1a/LItwnVPHnI9UdKsKUZFCDvZemEk=; b=Y2EnGEaYsY5Yv2gmKGVQcF A9y5Y5RGol6wn5qgzxffSQ6nPnufjLnKk41fPqyrfoJsK5IcRLJcpQMpBo82KeRH 0yj68rg3J7VHGOR0N3sH1om8Zp7grLkoBzJ9Yfxv33o0NY/5bC4gXCDrKlfLZ7VV nBVd85y6yuC9PhV0UT/d754AWSM5UCd5WpZ3uW18jRFVvAqtkgqDp+Fj/RDa5RIt vqkcUXcICpIUcQ9vXq0P3wEYGqvk+n3St7pSyr9SgejvocBSGSOdPOIeAkCe921V fJU3ACeiQv6Js1PH9zex5OuDS8HN0VazcCI7VwBeW5nMBjI1Z7rRuRE0sunzXoOg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudegiedguddtvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffogggtgfesthekre dtredtjeenucfhrhhomheptfgvmhgtohcuvhgrnhcukdhtucggvggvrhcuoehrvghmtgho sehrvghmfihorhhkshdrnhgvtheqnecuggftrfgrthhtvghrnhepveefudfgfeeuleevle dttdetheejhfevvdeugfeukedthfdufeetkeeutdeghfeinecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhifvhesfhgrshhtmhgrihhlrdgtoh hm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Mar 2022 03:07:44 -0400 (EDT) From: Remco van 't Veer To: 54352@debbugs.gnu.org Subject: [PATCH v3] services: dnsmasq: Add more options. Date: Wed, 23 Mar 2022 08:07:33 +0100 Message-Id: <20220323070733.5399-1-remco@remworks.net> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 54352 Cc: Remco van 't Veer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) * gnu/services/dns.scm (): Add forward-private-reverse-lookup?, strict-order? and cpe-id options. (dnsmasq-shepherd-service): Pass added options to dnsmasq and use match-record instead of match-lambda. * doc/guix.texi (Guix Services): Document options added to dnsmasq. --- Changes from v2 to v3: * renamed field additional-cpe-id to cpe-id * improved documentation of cpe-id * renamed field strict-order? to query-servers-in-order? doc/guix.texi | 13 +++ gnu/services/dns.scm | 183 ++++++++++++++++++++++++------------------- 2 files changed, 115 insertions(+), 81 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 44b0f9f1ea..e8ef4286be 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -100,6 +100,7 @@ Copyright @copyright{} 2021 Josselin Poiret@* Copyright @copyright{} 2021 Andrew Tropin@* Copyright @copyright{} 2021 Sarah Morgensen@* Copyright @copyright{} 2021 Josselin Poiret@* +Copyright @copyright{} 2022 Remco van 't Veer@* Permission is granted to copy, distribute and/or modify this document under the terms of the GNU Free Documentation License, Version 1.3 or @@ -28945,6 +28946,14 @@ The file to read the IP address of the upstream nameservers from. @item @code{no-resolv?} (default: @code{#f}) When true, don't read @var{resolv-file}. +@item @code{forward-private-reverse-lookup?} (default: @code{#t}) +When false, all reverse lookups for private IP ranges are answered with +"no such domain" rather than being forwarded upstream. + +@item @code{query-servers-in-order?} (default: @code{#f}) +When true, dnsmasq queries the servers in the same order as they appear +in @var{servers}. + @item @code{servers} (default: @code{'()}) Specify IP address of upstream servers directly. @@ -28974,6 +28983,10 @@ disables caching. @item @code{negative-cache?} (default: @code{#t}) When false, disable negative caching. +@item @code{cpe-id} (default: @code{#f}) +If set, add a CPE (Customer-Premises Equipment) identifier to DNS +queries which are forwarded upstream. + @item @code{tftp-enable?} (default: @code{#f}) Whether to enable the built-in TFTP server. diff --git a/gnu/services/dns.scm b/gnu/services/dns.scm index 9b8603cc95..a220b33f15 100644 --- a/gnu/services/dns.scm +++ b/gnu/services/dns.scm @@ -3,6 +3,7 @@ ;;; Copyright © 2018 Oleg Pykhalov ;;; Copyright © 2020 Pierre Langlois ;;; Copyright © 2021 Maxime Devos +;;; Copyright © 2022 Remco van 't Veer ;;; ;;; This file is part of GNU Guix. ;;; @@ -745,6 +746,12 @@ (define-record-type* (default "/etc/resolv.conf")) ;string (no-resolv? dnsmasq-configuration-no-resolv? (default #f)) ;boolean + (forward-private-reverse-lookup? + dnsmasq-configuration-forward-private-reverse-lookup? + (default #t)) ;boolean + (query-servers-in-order? + dnsmasq-configuration-query-servers-in-order? + (default #f)) ;boolean (servers dnsmasq-configuration-servers (default '())) ;list of string (addresses dnsmasq-configuration-addresses @@ -752,7 +759,9 @@ (define-record-type* (cache-size dnsmasq-configuration-cache-size (default 150)) ;integer (negative-cache? dnsmasq-configuration-negative-cache? - (default #t)) ;boolean + (default #t)) ;boolean + (cpe-id dnsmasq-configuration-cpe-id + (default #t)) ;string (tftp-enable? dnsmasq-configuration-tftp-enable? (default #f)) ;boolean (tftp-no-fail? dnsmasq-configuration-tftp-no-fail? @@ -776,86 +785,98 @@ (define-record-type* (tftp-unique-root dnsmasq-tftp-unique-root (default #f))) ;"" or "ip" or "mac" -(define dnsmasq-shepherd-service - (match-lambda - (($ package - no-hosts? - port local-service? listen-addresses - resolv-file no-resolv? servers - addresses cache-size negative-cache? - tftp-enable? tftp-no-fail? - tftp-single-port? tftp-secure? - tftp-max tftp-mtu tftp-no-blocksize? - tftp-lowercase? tftp-port-range - tftp-root tftp-unique-root) - (shepherd-service - (provision '(dnsmasq)) - (requirement '(networking)) - (documentation "Run the dnsmasq DNS server.") - (start #~(make-forkexec-constructor - '(#$(file-append package "/sbin/dnsmasq") - "--keep-in-foreground" - "--pid-file=/run/dnsmasq.pid" - #$@(if no-hosts? - '("--no-hosts") - '()) - #$(format #f "--port=~a" port) - #$@(if local-service? - '("--local-service") - '()) - #$@(map (cut format #f "--listen-address=~a" <>) - listen-addresses) - #$(format #f "--resolv-file=~a" resolv-file) - #$@(if no-resolv? - '("--no-resolv") - '()) - #$@(map (cut format #f "--server=~a" <>) - servers) - #$@(map (cut format #f "--address=~a" <>) - addresses) - #$(format #f "--cache-size=~a" cache-size) - #$@(if negative-cache? - '() - '("--no-negcache")) - #$@(if tftp-enable? - '("--enable-tftp") - '()) - #$@(if tftp-no-fail? - '("--tftp-no-fail") - '()) - #$@(if tftp-single-port? - '("--tftp-single-port") - '()) - #$@(if tftp-secure? - '("--tftp-secure?") - '()) - #$@(if tftp-max - (list (format #f "--tftp-max=~a" tftp-max)) - '()) - #$@(if tftp-mtu - (list (format #f "--tftp-mtu=~a" tftp-mtu)) - '()) - #$@(if tftp-no-blocksize? - '("--tftp-no-blocksize") - '()) - #$@(if tftp-lowercase? - '("--tftp-lowercase") - '()) - #$@(if tftp-port-range - (list (format #f "--tftp-port-range=~a" - tftp-port-range)) - '()) - #$@(if tftp-root - (list (format #f "--tftp-root=~a" tftp-root)) - '()) - #$@(if tftp-unique-root - (list - (if (> (length tftp-unique-root) 0) - (format #f "--tftp-unique-root=~a" tftp-unique-root) - (format #f "--tftp-unique-root"))) - '())) - #:pid-file "/run/dnsmasq.pid")) - (stop #~(make-kill-destructor)))))) +(define (dnsmasq-shepherd-service config) + (match-record config + (package + no-hosts? + port local-service? listen-addresses + resolv-file no-resolv? + forward-private-reverse-lookup? query-servers-in-order? + servers addresses + cache-size negative-cache? + cpe-id + tftp-enable? tftp-no-fail? + tftp-single-port? tftp-secure? + tftp-max tftp-mtu tftp-no-blocksize? + tftp-lowercase? tftp-port-range + tftp-root tftp-unique-root) + (shepherd-service + (provision '(dnsmasq)) + (requirement '(networking)) + (documentation "Run the dnsmasq DNS server.") + (start #~(make-forkexec-constructor + '(#$(file-append package "/sbin/dnsmasq") + "--keep-in-foreground" + "--pid-file=/run/dnsmasq.pid" + #$@(if no-hosts? + '("--no-hosts") + '()) + #$(format #f "--port=~a" port) + #$@(if local-service? + '("--local-service") + '()) + #$@(map (cut format #f "--listen-address=~a" <>) + listen-addresses) + #$(format #f "--resolv-file=~a" resolv-file) + #$@(if no-resolv? + '("--no-resolv") + '()) + #$@(if forward-private-reverse-lookup? + '() + '("--bogus-priv")) + #$@(if query-servers-in-order? + '("--strict-order") + '()) + #$@(map (cut format #f "--server=~a" <>) + servers) + #$@(map (cut format #f "--address=~a" <>) + addresses) + #$(format #f "--cache-size=~a" cache-size) + #$@(if negative-cache? + '() + '("--no-negcache")) + #$@(if cpe-id + (list (format #f "--add-cpe-id=~a" cpe-id)) + '()) + #$@(if tftp-enable? + '("--enable-tftp") + '()) + #$@(if tftp-no-fail? + '("--tftp-no-fail") + '()) + #$@(if tftp-single-port? + '("--tftp-single-port") + '()) + #$@(if tftp-secure? + '("--tftp-secure?") + '()) + #$@(if tftp-max + (list (format #f "--tftp-max=~a" tftp-max)) + '()) + #$@(if tftp-mtu + (list (format #f "--tftp-mtu=~a" tftp-mtu)) + '()) + #$@(if tftp-no-blocksize? + '("--tftp-no-blocksize") + '()) + #$@(if tftp-lowercase? + '("--tftp-lowercase") + '()) + #$@(if tftp-port-range + (list (format #f "--tftp-port-range=~a" + tftp-port-range)) + '()) + #$@(if tftp-root + (list (format #f "--tftp-root=~a" tftp-root)) + '()) + #$@(if tftp-unique-root + (list + (if (> (length tftp-unique-root) 0) + (format #f "--tftp-unique-root=~a" tftp-unique-root) + (format #f "--tftp-unique-root"))) + '())) + #:pid-file "/run/dnsmasq.pid")) + (stop #~(make-kill-destructor))))) (define (dnsmasq-activation config) #~(begin -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 23 03:09:14 2022 Received: (at 54352) by debbugs.gnu.org; 23 Mar 2022 07:09:14 +0000 Received: from localhost ([127.0.0.1]:42557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWv7K-0001go-9x for submit@debbugs.gnu.org; Wed, 23 Mar 2022 03:09:14 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:40889) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWv7I-0001gT-Qr for 54352@debbugs.gnu.org; Wed, 23 Mar 2022 03:09:13 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id C95EB5C00FE; Wed, 23 Mar 2022 03:09:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 23 Mar 2022 03:09:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=remworks.net; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=1b1BgKIKerKlZZA2/dEQ6c94j/LhqW616HNUFU SOD5o=; b=rCi2KKJxJvMCpbTHzyOjifpD7xvjYlIYgaXXeXEG+F4IJZYED5laKW tPYNjqzCuS3VuT8oYZawvAKMh3J/j1oAIeos/jLHYY/q2/sIS7ziuHZFU+x3adWi LGLo6Gy8x/sRd14FxgSQ/5YfbRbhVxb+zu842R3czxauDl8aqktyilsl2iK5Qv+s 9L8CalN1TXAKV3IRgyHSsadKPVuZc702so3A4k2K0PGb7pOuE0+MtDheFz/GYAGI CVmwHIfyhlTCuHUrE3AQy7dPc9jLIPzTpv7HbUQzqIT/LWmUTfGBquXIMhO94vXj BwKmjiXEbm36/sPkxC6y6w8WA78SreYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=1b1BgKIKerKlZZA2/ dEQ6c94j/LhqW616HNUFUSOD5o=; b=fp+jacYg3kAeinsznh/zAShEi7pNxISbB KQsEhoPmEgJAYHYlYBRy5ub7x6/Ibqqwy8mkz9VH1uaERELgguKhLw09wN0TybWT IU5ZcrSF0bZ/rSfZ0MBot0duXahG1BS7+U7LDvKvm3ufpCwtMMam+prwRBr3NgJr kbd4Ebd2ZFOxpns2BQR9jD/+6vStej+dHoOhCXqaqC4DXiDUy+Fs7UyPeoWrzThy Iyf5ug/9mlqBE/K6ay4ly1vbZw3buDfhazUP7UYbPf308r+psKIDM/FFQ3l7vD0G oqqy/x4yD2cr3+8gtq+RA1qFBYdMwF3JYo7G1q0zbk14fJD3S/yWQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudegiedguddtvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvffujgffkfggtgesthdtredttdertdenucfhrhhomheptfgvmhgt ohcuvhgrnhcukdhtucggvggvrhcuoehrvghmtghosehrvghmfihorhhkshdrnhgvtheqne cuggftrfgrthhtvghrnhepueelvdetveetheefudevhfejudevgfekheeltdfggedvueeg fffhkeeijeektdegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomheprhgvmhgtohesrhgvmhifohhrkhhsrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Mar 2022 03:09:07 -0400 (EDT) References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> <8735jbjpoj.fsf_-_@gnu.org> <2287729e13ea8689713cefe61e28abba9e817308.camel@telenet.be> <8735jabfqh.fsf@remworks.net> <87mthii9u2.fsf@gnu.org> User-agent: mu4e 1.6.10; emacs 27.2 From: Remco van 't Veer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#54352: [PATCH] services: dnsmasq: Add more options. In-reply-to: <87mthii9u2.fsf@gnu.org> Date: Wed, 23 Mar 2022 08:09:05 +0100 Message-ID: <877d8l9mcu.fsf@remworks.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54352 Cc: 54352@debbugs.gnu.org, Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Just posted a v3. Changes from v2 to v3: * renamed field additional-cpe-id to cpe-id * improved documentation of cpe-id * renamed field strict-order? to query-servers-in-order? R. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 24 07:22:42 2022 Received: (at 54352-done) by debbugs.gnu.org; 24 Mar 2022 11:22:42 +0000 Received: from localhost ([127.0.0.1]:46918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXLYA-0006bL-6a for submit@debbugs.gnu.org; Thu, 24 Mar 2022 07:22:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXLY8-0006b5-Bi for 54352-done@debbugs.gnu.org; Thu, 24 Mar 2022 07:22:40 -0400 Received: from [2001:470:142:3::e] (port=54124 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXLY2-0008IU-LL; Thu, 24 Mar 2022 07:22:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=mMSAO+su55086NBkLDzVdo/JjxM7nAInJwGvAGKH0QQ=; b=FMbOI8jhridJVZUTgjdJ XvBEgBcj1R+RT3nSa2C9vM/i8Zfw7hqOvfq7Xt0UdDIlCVUv8/BD6Xqrz0mQu1veunQADMIzgispA w7oTTHAnC0I/YtS3HkPbgTlPZcjPEwSlMaZdGsKNsHijGL1joExRuD3GRW5oBagLWS6FaDp2eoVW3 1H4nEYjFwkq/UgxlDvdBAoONCcig9Vf4GBJ9ju+KCPTZApqPFzhkCcD88mZhZrb5pJQsUEAqVZVBI TUcnUHVYhzd3WBRAbKQvfzDw2pT1IwUH7rvoE9i2gHR+NEZ0V2AZMKtprpEM4Pw0NPj6IzvY9ep1w LpIHFEbDMHlnSw==; Received: from [193.50.110.177] (port=51496 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXLY1-0008SA-MX; Thu, 24 Mar 2022 07:22:34 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Remco van 't Veer Subject: Re: bug#54352: [PATCH] services: dnsmasq: Add more options. References: <20220312154813.5538-1-remco@remworks.net> <20220323070733.5399-1-remco@remworks.net> Date: Thu, 24 Mar 2022 12:22:31 +0100 In-Reply-To: <20220323070733.5399-1-remco@remworks.net> (Remco van t. Veer's message of "Wed, 23 Mar 2022 08:07:33 +0100") Message-ID: <87sfr7d288.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54352-done Cc: 54352-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Remco van 't Veer skribis: > * gnu/services/dns.scm (): Add > forward-private-reverse-lookup?, strict-order? and cpe-id options. > (dnsmasq-shepherd-service): Pass added options to dnsmasq and use > match-record instead of match-lambda. > * doc/guix.texi (Guix Services): Document options added to dnsmasq. Applied, thank you! Ludo=E2=80=99. From unknown Wed Jun 18 23:06:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 21 Apr 2022 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator