Subject: Re: [bug#54351] [PATCH] gnu: Add emacs-xah-fly-keys.

From: Maxime Devos <[email-masked]>
Date: Sun, 13 Mar 2022 12:09:41 +0100

Jai Vetrivelan schreef op zo 13-03-2022 om 16:18 [+0530]:
> +(define-public emacs-xah-fly-keys
> +  (let ((commit "6e974bd21f2d42aaa6d0b331a162cb554085b72e"))
> +    (package
> +    (name "emacs-xah-fly-keys")
> +    (version "16.14.20220313004708")
> +    (source (origin
> +             (method git-fetch)
> +             (uri (git-reference
> +                   (url "https://github.com/xahlee/xah-fly-keys")
> +                   (commit commit)))

'commit' is only used in one place, so the 'let' binding is not
necessary here, you could write

(git-reference
  (url "https://github.com/xahlee/xah-fly-keys")
  (commit ""6e974bd21f2d42aaa6d0b331a162cb554085b72e"))

Greetings,
Maxime.