GNU bug report logs - #54346
persist-save doesn't persist variables when the value is set to the default

Previous Next

Full log

Message #23 received at 54346 <at> debbugs.gnu.org (full text, mbox):

From: Gulshan Singh <gsingh2011 <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 54346 <at> debbugs.gnu.org, Phillip Lord <phillip.lord <at> russet.org.uk>
Subject: Re: bug#54346: persist-save doesn't persist variables when the value
 is set to the default
Date: Mon, 20 Jun 2022 19:14:35 -0700

[Message part 1 (text/plain, inline)]

Hi,

It's been a few months since the last message here. I also directly sent
Phillip an email last week asking if he could take a look at my PR, but I
haven't received a response.

Do you know what's normally done in cases like this? Even if persist.el is
maintained externally, should we just merge my patch and close this bug if
we can't get a response from the maintainer?

On Mon, Apr 11, 2022 at 3:18 AM Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> Gulshan Singh <gsingh2011 <at> gmail.com> writes:
>
> > I cloned the upstream project [1] and created a merge request [2]
> > there. The fix deletes the persist file when it gets set back to the
> > default value, and it modifies a test to verify this behavior. I've
> > attached the same patch here (created with `git format-patch HEAD^`, I
> > haven't submitted a patch here before so let me know if this is the
> > correct way to do this).
>
> Yup; looks good.
>
> > I'm a little confused though, I see that on the externals/persist
> > branch [3] there is a commit that does not exist on the upstream
> > GitLab project. Why is this the case? Should I actually be making a
> > patch off of the externals/persist branch?
>
> That's my error -- I didn't check whether it persist was maintained
> externally before making that change.  So it should be merged upstream.
>
> Phillip?
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.