From unknown Wed Jun 18 23:11:19 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#54346 <54346@debbugs.gnu.org> To: bug#54346 <54346@debbugs.gnu.org> Subject: Status: persist-save doesn't persist variables when the value is set to the default Reply-To: bug#54346 <54346@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:11:19 +0000 retitle 54346 persist-save doesn't persist variables when the value is set = to the default reassign 54346 emacs submitter 54346 Gulshan Singh severity 54346 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 11 20:16:11 2022 Received: (at submit) by debbugs.gnu.org; 12 Mar 2022 01:16:11 +0000 Received: from localhost ([127.0.0.1]:38855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSqMd-0003Pn-2Q for submit@debbugs.gnu.org; Fri, 11 Mar 2022 20:16:11 -0500 Received: from lists.gnu.org ([209.51.188.17]:47140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSqMb-0003Pg-Bt for submit@debbugs.gnu.org; Fri, 11 Mar 2022 20:16:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSqMb-00080E-7r for bug-gnu-emacs@gnu.org; Fri, 11 Mar 2022 20:16:09 -0500 Received: from [2a00:1450:4864:20::52c] (port=39880 helo=mail-ed1-x52c.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nSqMZ-0007aV-2b for bug-gnu-emacs@gnu.org; Fri, 11 Mar 2022 20:16:08 -0500 Received: by mail-ed1-x52c.google.com with SMTP id g20so12898912edw.6 for ; Fri, 11 Mar 2022 17:16:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=3vc4zow5ouRIkK+34pDeFXV49ZrhEwguifj5ZC0tQ5M=; b=PjfgQctlLaTySjat8cYCXpEDCwOu1LqrLeEE2uI62NU3UedZvdytzVBc9XBFVqOVur IGJGeLLUb2ZQQFw8DRHzu9YCuiJ2Tn5/f2SKgzzkrlJagJhkOiDYnNn+r7wzNUeFLhH9 tJ7RvpGKXlcEkLnEXTdbVXLs9SwjcDH89pmdjXlKB103aa3iW2JpBFhTGEbgdeevB4OR 93fLZPFSWrdGUNLKP4UVyO8/c+JQr/lw/+z4moLMUSvFvFSRdoLRAhD4kFet4bbVPwwV G8ueEOuh8pCjPeb8kByzA9rQDGylLtR+kN6uHwxLzxPUMlwqt7Go3jZjK4GUBFi8V/iW AvZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=3vc4zow5ouRIkK+34pDeFXV49ZrhEwguifj5ZC0tQ5M=; b=qRwwUKWhOcn5njgFgIxntdG6bhjrSd++EDBhIFgrRn2pixgeNbXSco+6mhNNXWUiZm qF4549qWn1pBhUnP4OwZdPZCMtSNloecG2LWdQ82+mAmwmpoHEVviJny7QIKr6CjgehK fSDEbEqkH3viVKLa+gfeF5B2Y6O4MFTXBjk35CZKlEhxtZLqYqvSeUOxUxfzWi2gOwsX Mc2vyhzwJBJZIdivFoVGhU2XiUHRGCyOVZ8snQE+a4n9O79Thp5r2Qq8fD5JpcK14ew1 9t0BAqWUbjuBauBPZy1PpH9TyNvE0RZVa72jThSwjeGxkVEtf4eYrXQ+G5UKeRSLIbdd vpWA== X-Gm-Message-State: AOAM532VKkaRHrFsSVIImPxo4767eNpXEnaeuB2gXnbA51xu+5WpyqUz j3vtBIPX3MsU+mZtZILrUSHAhbFA6WkIZ64ckoVuly/2XRA= X-Google-Smtp-Source: ABdhPJxnUpSTBHAED65rhRMVUDI0yF9+mUugy9vRWEuYTsXPI2QFQ5RA2XaI7wVhYad1rmeoSOy5sbWmcy/VO+BYIgA= X-Received: by 2002:aa7:d1c8:0:b0:415:c61a:8ec8 with SMTP id g8-20020aa7d1c8000000b00415c61a8ec8mr11302025edp.390.1647047764930; Fri, 11 Mar 2022 17:16:04 -0800 (PST) MIME-Version: 1.0 From: Gulshan Singh Date: Fri, 11 Mar 2022 17:15:53 -0800 Message-ID: Subject: persist-save doesn't persist variables when the value is set to the default To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="000000000000f4f3c805d9fb3045" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::52c (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::52c; envelope-from=gsingh2011@gmail.com; helo=mail-ed1-x52c.google.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --000000000000f4f3c805d9fb3045 Content-Type: text/plain; charset="UTF-8" Calling (persist-save 'myvar) should persist the value of myvar to a file. However, it doesn't do this if the value of myvar is the same as the default value. See lines 135 and 136 of persist.el: https://git.savannah.gnu.org/cgit/emacs/elpa.git/tree/persist.el?h=externals/persist&id=2a2f83b4d63734ed48603008c813cfacd9e99404#n135 The intention here could have been that there's no need to persist the variable if the user doesn't change it from the default. But it leads to a bug in the following case: (require 'persist) (persist-defvar myvar nil "docstring") ; #1 (persist-save 'myvar) ; #2 (setq myvar "foo") (persist-save 'myvar) ; #3 (setq myvar nil) (persist-save 'myvar) ; #4 At #1, the value of myvar is not persisted, which is fine. If myvar was persisted in the past, that value would be loaded, otherwise (like in my case), it will be set to nil. At #2, explicitly calling persist-save does not persist myvar. This is unexpected, but still not a bug: the in-memory value of myvar (nil) is still equal to the default, and it is not persisted, so the next time the code runs the default will be loaded again. At #3, myvar is persisted. The value is now "foo", which is different from the default value of "nil". #4 is where the bug happens. The persisted value of myvar is "foo", but the in-memory value of myvar is nil. We *should* persist the new value here, so that on the next load of the symbol we get the latest value. However, because the current in-memory value is equal to the default value (nil), it's not persisted. The next time this code runs, it will load "foo" as the value of myvar instead of nil. One fix could be to remove the check to see if the value is set to the default. Another could be that if the value is set to the default, remove the persist file. System information from report-emacs-bug: In GNU Emacs 27.2 (build 1, x86_64-apple-darwin18.7.0, NS appkit-1671.60 Version 10.14.6 (Build 18G95)) of 2021-11-18 built on builder10-14.lan Windowing system distributor 'Apple', version 10.3.2113 System Description: macOS 12.2.1 Configured using: 'configure --with-ns '--enable-locallisppath=/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp' --with-modules' Configured features: NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES THREADS JSON PDUMPER GMP Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils persist ispell help-fns radix-tree cl-print debug backtrace help-mode easymenu find-func time-date subr-x cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 52205 6991) (symbols 48 6523 1) (strings 32 17870 1009) (string-bytes 1 596696) (vectors 16 10502) (vector-slots 8 132509 11576) (floats 8 27 44) (intervals 56 378 4) (buffers 1000 13)) --000000000000f4f3c805d9fb3045 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Calling (persist-save 'myvar) should persist the value= of myvar to a
file. However, it doesn't do this if the value of myv= ar is the same as
the default value. See lines 135 and 136 of persist.el= :
https://git.savannah.gnu.org/= cgit/emacs/elpa.git/tree/persist.el?h=3Dexternals/persist&id=3D2a2f83b4= d63734ed48603008c813cfacd9e99404#n135

The intention here could h= ave been that there's no need to persist the
variable if the user do= esn't change it from the default. But it leads
to a bug in the follo= wing case:

(require 'persist)
(persist-defvar myvar nil "= ;docstring") ; #1
(persist-save 'myvar) ; #2
(setq myvar &qu= ot;foo")
(persist-save 'myvar) ; #3
(setq myvar nil)
(per= sist-save 'myvar) ; #4

At #1, the value of myvar is not persiste= d, which is fine. If myvar
was persisted in the past, that value would b= e loaded, otherwise (like
in my case), it will be set to nil.

At = #2, explicitly calling persist-save does not persist myvar. This is
unex= pected, but still not a bug: the in-memory value of myvar (nil) is
still= equal to the default, and it is not persisted, so the next time
the cod= e runs the default will be loaded again.

At #3, myvar is persisted. = The value is now "foo", which is different
from the default va= lue of "nil".

#4 is where the bug happens. The persisted v= alue of myvar is "foo",
but the in-memory value of myvar is ni= l. We *should* persist the new
value here, so that on the next load of t= he symbol we get the latest
value. However, because the current in-memor= y value is equal to the
default value (nil), it's not persisted. The= next time this code runs,
it will load "foo" as the value of = myvar instead of nil.

One fix could be to remove the check to see if= the value is set to the
default. Another could be that if the value is = set to the default,
remove the persist file.

Syst= em information from report-emacs-bug:

In GNU Emacs 27.2 (build 1, x8= 6_64-apple-darwin18.7.0, NS appkit-1671.60 Version 10.14.6 (Build 18G95))=C2=A0of 2021-11-18 built on builder10-14.lan
Windowing system distrib= utor 'Apple', version 10.3.2113
System Description: =C2=A0macOS = 12.2.1

Configured using:
=C2=A0'configure --with-ns '--en= able-locallisppath=3D/Library/Application
=C2=A0Support/Emacs/${version}= /site-lisp:/Library/Application
=C2=A0Support/Emacs/site-lisp' --wit= h-modules'

Configured features:
NOTIFY KQUEUE ACL GNUTLS LIBX= ML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES
THREADS JSON PDUMPER GMP

= Important settings:
=C2=A0 value of $LANG: en_US.UTF-8
=C2=A0 locale-= coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor = modes in effect:
=C2=A0 tooltip-mode: t
=C2=A0 global-eldoc-mode: t=C2=A0 eldoc-mode: t
=C2=A0 electric-indent-mode: t
=C2=A0 mouse-wh= eel-mode: t
=C2=A0 tool-bar-mode: t
=C2=A0 menu-bar-mode: t
=C2=A0= file-name-shadow-mode: t
=C2=A0 global-font-lock-mode: t
=C2=A0 font= -lock-mode: t
=C2=A0 blink-cursor-mode: t
=C2=A0 auto-composition-mod= e: t
=C2=A0 auto-encryption-mode: t
=C2=A0 auto-compression-mode: t=C2=A0 line-number-mode: t
=C2=A0 transient-mark-mode: t

Load-p= ath shadows:
None found.

Features:
(shadow sort mail-extr emac= sbug message rmc puny dired dired-loaddefs
format-spec rfc822 mml mml-se= c password-cache epa derived epg epg-config
gnus-util rmail rmail-loadde= fs text-property-search seq byte-opt gv
bytecomp byte-compile cconv mm-d= ecode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailhe= ader sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils p= ersist ispell help-fns
radix-tree cl-print debug backtrace help-mode eas= ymenu find-func
time-date subr-x cl-loaddefs cl-lib tooltip eldoc electr= ic uniquify
ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-wi= n
ucs-normalize mule-util term/common-win tool-bar dnd fontset image
= regexp-opt fringe tabulated-list replace newcomment text-mode elisp-modelisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
= timer select scroll-bar mouse jit-lock font-lock syntax facemenu
font-co= re term/tty-colors frame minibuffer cl-generic cham georgian
utf-8-lang = misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms = cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyri= llic chinese composite charscript charprop
case-table epa-hook jka-cmpr-= hook help simple abbrev obarray
cl-preloaded nadvice loaddefs button fac= es cus-face macroexp files
text-properties overlay sha1 md5 base64 forma= t env code-pages mule
custom widget hashtable-print-readable backquote t= hreads kqueue cocoa ns
multi-tty make-network-process emacs)

Memo= ry information:
((conses 16 52205 6991)
=C2=A0(symbols 48 6523 1)
= =C2=A0(strings 32 17870 1009)
=C2=A0(string-bytes 1 596696)
=C2=A0(ve= ctors 16 10502)
=C2=A0(vector-slots 8 132509 11576)
=C2=A0(floats 8 2= 7 44)
=C2=A0(intervals 56 378 4)
=C2=A0(buffers 1000 13))
--000000000000f4f3c805d9fb3045-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 12 12:44:50 2022 Received: (at 54346) by debbugs.gnu.org; 12 Mar 2022 17:44:50 +0000 Received: from localhost ([127.0.0.1]:40763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nT5nO-0001pg-42 for submit@debbugs.gnu.org; Sat, 12 Mar 2022 12:44:50 -0500 Received: from quimby.gnus.org ([95.216.78.240]:51408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nT5nM-0001pU-EH for 54346@debbugs.gnu.org; Sat, 12 Mar 2022 12:44:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=te7HvyGjEwDTd9Y2SGdWKDglpt3ZFpXRVAByNiQ9QO0=; b=XT2n9t5GFgId7T8zPjsVvyzOAl A1c6AYxnjV2PUirRIMIUgvjWDiE5+L7PSwHNT7anKjYN2FBbWfy56xsjhiqgSSDIyLA8gZObWsZel 74EqVCDvTkiOSa569g2CAtRJ1E8GBak4V5sLwEbqWdpkC6v3mELpFTAsbR+h9mMKu8ak=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nT5nC-0001rd-3d; Sat, 12 Mar 2022 18:44:40 +0100 From: Lars Ingebrigtsen To: Gulshan Singh Subject: Re: bug#54346: persist-save doesn't persist variables when the value is set to the default References: Date: Sat, 12 Mar 2022 18:44:34 +0100 In-Reply-To: (Gulshan Singh's message of "Fri, 11 Mar 2022 17:15:53 -0800") Message-ID: <87r177ysjh.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Gulshan Singh writes: > One fix could be to remove the check to see if the value is set to the > default. Another could be that if the value is set to the default, > remove the persist file. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54346 Cc: Phillip Lord , 54346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Gulshan Singh writes: > One fix could be to remove the check to see if the value is set to the > default. Another could be that if the value is set to the default, > remove the persist file. I've added Phillip to the CCs, perhaps he has some comments. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 09 17:45:57 2022 Received: (at 54346) by debbugs.gnu.org; 9 Apr 2022 21:45:57 +0000 Received: from localhost ([127.0.0.1]:38837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ndIu5-0004r1-3x for submit@debbugs.gnu.org; Sat, 09 Apr 2022 17:45:57 -0400 Received: from mail-oa1-f43.google.com ([209.85.160.43]:37256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ndIu2-0004qo-MT for 54346@debbugs.gnu.org; Sat, 09 Apr 2022 17:45:55 -0400 Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-e2a00f2cc8so3859980fac.4 for <54346@debbugs.gnu.org>; Sat, 09 Apr 2022 14:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4hlxr3goi5EEPNRhl/jhtH+iKySqiaylSzeu/+5abq0=; b=F9jV67bMkhI6k9zyJs7eXLv0uoapyt24u7+rn/Vs7XyL9CdxSm/ElI66V+4/OegYtp lB6vyjdn9G/xxZR46tfy4eRIii5ZEMYcBl0QsDN1gJfacKVuk3IRFRm7frLidJ5GWrTC A8FWhD5MX7WZmTaYh718a0c0JFHUJK5wFi9xlrY2x9Y44SP4Lc9lR6BKv9CXPnzaNdWy qIxRQ4itmtY8FEyHWOmPzGrGnBD9o12k4vtcLFs3EwHtatw3PEmTVOCRwahmN1Wo9WHl WJlup0fqjUMtA5aH/lTCRbhJ4wZtyWLFGmJFXW1gw0mLwM0hr/RWbomN2RI2VuG9VJbY oYuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4hlxr3goi5EEPNRhl/jhtH+iKySqiaylSzeu/+5abq0=; b=zwqWbAMaHbOHLXDKmGLhB9mAhbMWKZ8vpYx8nd8Pd6B4WEg/cDz+zs2kIbHZ+9Dv7L cwy+gA2clJU6CSK2SvyZJKDFUMFH6kdPrQ6HVydzS/T0BxkknsR59JnPfo+9GYzC09zZ 8HHObf9lLdmT45mRm5HpEpn/v/sq8RQYNSHg+8ACuiNgNdA4f2qF2gjLyG1F3Qrc4i5d Kg4saYJymRWeRl7tDx2sdQfU+f3SMzLMaXZt5Oi6DN5N1wzz7HcKFxGuq+4utUqwFTtY inzXvGQ0aD5R2bLzaOfd7rDRhxIQDU7huyWGdc7iL6bQj44coTMvychWrZeOeH1mAcNs kK2g== X-Gm-Message-State: AOAM532drSnbZo0ZK+nSrJlOlGNrnKk3NCoGyoCRA5cg9PkTEhY6etEG 9ES4DkMNMt2f/MoIZY4/JBCizbxnA1sh9e0NjvU= X-Google-Smtp-Source: ABdhPJxB6HHT/5ImMllSc0zTZfHVWBnbRgSeGDZMjt3oYIs91G+NbmfdjWddwdbRz8ehmNVuwuUkbkVMdNfT8RI7UEg= X-Received: by 2002:a05:6870:6590:b0:e2:a532:6916 with SMTP id fp16-20020a056870659000b000e2a5326916mr2300788oab.261.1649540749178; Sat, 09 Apr 2022 14:45:49 -0700 (PDT) MIME-Version: 1.0 References: <87r177ysjh.fsf@gnus.org> In-Reply-To: <87r177ysjh.fsf@gnus.org> From: Gulshan Singh Date: Sat, 9 Apr 2022 14:45:38 -0700 Message-ID: Subject: Re: bug#54346: persist-save doesn't persist variables when the value is set to the default To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 54346 Cc: Phillip Lord , 54346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) If either of these solutions make sense, or if Phillip has any other suggestions, I'd be happy to make the fix myself if that would be easier. On Sat, Mar 12, 2022 at 9:44 AM Lars Ingebrigtsen wrote: > > Gulshan Singh writes: > > > One fix could be to remove the check to see if the value is set to the > > default. Another could be that if the value is set to the default, > > remove the persist file. > > I've added Phillip to the CCs, perhaps he has some comments. > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 10 08:17:41 2022 Received: (at 54346) by debbugs.gnu.org; 10 Apr 2022 12:17:41 +0000 Received: from localhost ([127.0.0.1]:39643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ndWVg-0004zs-Ub for submit@debbugs.gnu.org; Sun, 10 Apr 2022 08:17:41 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ndWVf-0004zf-Lw for 54346@debbugs.gnu.org; Sun, 10 Apr 2022 08:17:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EY/dwQB6h4LeG8zJ9VCRhJmX/hJHzZHhrcpSadbFXHE=; b=UTWMKnklj3Dj/dcEBnj3HjFkpw ZE5Yb60uSsuXZ8SgyOLC5Tis8DWxtrwtKYIlJcqeZe4l+BXFIEwjFkKeA5BsztL2adJGC1iQ/Zxgx xx2QdNiW2ttYziHESqM8vQDZ5mId9gEBHg69FTCYPtNpf1tu7g3fr6r4tgP4ikc+/r/Y=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndWVT-0006JD-Cy; Sun, 10 Apr 2022 14:17:32 +0200 From: Lars Ingebrigtsen To: Gulshan Singh Subject: Re: bug#54346: persist-save doesn't persist variables when the value is set to the default References: <87r177ysjh.fsf@gnus.org> X-Now-Playing: Arto Lindsay's _Salt_: =?utf-8?Q?=22Combust=C3=ADvel=22?= Date: Sun, 10 Apr 2022 14:17:26 +0200 In-Reply-To: (Gulshan Singh's message of "Sat, 9 Apr 2022 14:45:38 -0700") Message-ID: <87pmlpqgix.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Gulshan Singh writes: > If either of these solutions make sense, or if Phillip has any other > suggestions, I'd be happy to make the fix myself if that would be > easier. Yes, that'd be great (and post the patch here). Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54346 Cc: 54346@debbugs.gnu.org, Phillip Lord X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Gulshan Singh writes: > If either of these solutions make sense, or if Phillip has any other > suggestions, I'd be happy to make the fix myself if that would be > easier. Yes, that'd be great (and post the patch here). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 10 15:37:13 2022 Received: (at 54346) by debbugs.gnu.org; 10 Apr 2022 19:37:13 +0000 Received: from localhost ([127.0.0.1]:41553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nddN3-0006je-2k for submit@debbugs.gnu.org; Sun, 10 Apr 2022 15:37:13 -0400 Received: from mail-oi1-f179.google.com ([209.85.167.179]:41910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nddN1-0006jR-Ca for 54346@debbugs.gnu.org; Sun, 10 Apr 2022 15:37:11 -0400 Received: by mail-oi1-f179.google.com with SMTP id e189so13968426oia.8 for <54346@debbugs.gnu.org>; Sun, 10 Apr 2022 12:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K1K+I0QqeIwIZtPWzwrvHhV51a3qiqyyNjktqKr4KfM=; b=qz10AOs0RIyKZlZ7Mw4bki+SoHmNmy0rfeS6BBK/epaf/8c6pE/5KwsOp2jfFHHsax D0Re3Ih2xT0fKjeuiVWNy28ud0+Fwj/iVFQrUbuvu+RKOXKgecWpa/J3n1m1fqCVqfE0 44cFW8yF9n3qVNWeEJB+pM2XjByrTkVgc/HmDDiLPn6AbIxDirCjU6IL411wXIvWDokC ncBCky6lM92i13TPpjNy2rCO0bNH2uR1djXbsc6/oAQQiYHES2aLqkguHBFyzLb8MYoA p57NEcSDUfSn+G0ifrp4gfyNg/yNNYwhjWSZpOXdR/OFwvQNO3QRmhfJJUqrPcZ06GEx l21Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K1K+I0QqeIwIZtPWzwrvHhV51a3qiqyyNjktqKr4KfM=; b=g3nDwXEXZY+/AareOQiG3X4lWJnQXMsW47FFrPcznY+5elfd3F4BqQqS5UkeGZr+bk CQmvFPtCv+SunXLncHbQtoJ9p5yQ2PtKJbBW8RwdGYf8ISaYrn0TV65o9KQOjlgATYrZ spWZct0GzFndEQ+i22YgJ6PuTMp2jiy5vq5br1e8l4AU2pext9oJ8F1MdThUwgNXrVq0 Ld/A31HT1AWi6Qmgx0vLlc0XrzuwKcsp0GrTMF6tJyuktWf+fnxnGIgEmgjoBMFbHQb7 XlGgb6nlSucgD96MkduZ1Oq6Ts92vqzfG1whEc1RZ055H4Wh1ceGZaRwLGN+6J2XKAJ1 U2OQ== X-Gm-Message-State: AOAM530JVo08w9sTPYte3aj0bTYXYo1hhUNwBLLzXI4WjUy1JWAe2dEJ 6fCISBs1XQEMoZ5XPoL1xbP0SUfeVgkma/jVV7eXEZTZVHI= X-Google-Smtp-Source: ABdhPJwtcnkgqJBc/I8cGPEEIs6VxEDemujcPvQlsoCl4pOxczBrA5tp8AK2zHi456/5zJ8iwA0l7Vu1XNgQfx++Gq8= X-Received: by 2002:a05:6808:3094:b0:2f9:61ab:32fc with SMTP id bl20-20020a056808309400b002f961ab32fcmr4109506oib.261.1649619425560; Sun, 10 Apr 2022 12:37:05 -0700 (PDT) MIME-Version: 1.0 References: <87r177ysjh.fsf@gnus.org> <87pmlpqgix.fsf@gnus.org> In-Reply-To: <87pmlpqgix.fsf@gnus.org> From: Gulshan Singh Date: Sun, 10 Apr 2022 12:36:54 -0700 Message-ID: Subject: Re: bug#54346: persist-save doesn't persist variables when the value is set to the default To: Lars Ingebrigtsen Content-Type: multipart/mixed; boundary="000000000000e0251c05dc51f348" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 54346 Cc: 54346@debbugs.gnu.org, Phillip Lord X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --000000000000e0251c05dc51f348 Content-Type: text/plain; charset="UTF-8" Hi, I cloned the upstream project [1] and created a merge request [2] there. The fix deletes the persist file when it gets set back to the default value, and it modifies a test to verify this behavior. I've attached the same patch here (created with `git format-patch HEAD^`, I haven't submitted a patch here before so let me know if this is the correct way to do this). I'm a little confused though, I see that on the externals/persist branch [3] there is a commit that does not exist on the upstream GitLab project. Why is this the case? Should I actually be making a patch off of the externals/persist branch? [1] https://gitlab.com/phillord/persist/ [2] https://gitlab.com/phillord/persist/-/merge_requests/1 [3] https://git.savannah.gnu.org/cgit/emacs/elpa.git/log/?h=externals/persist On Sun, Apr 10, 2022 at 5:17 AM Lars Ingebrigtsen wrote: > > Gulshan Singh writes: > > > If either of these solutions make sense, or if Phillip has any other > > suggestions, I'd be happy to make the fix myself if that would be > > easier. > > Yes, that'd be great (and post the patch here). > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no --000000000000e0251c05dc51f348 Content-Type: application/octet-stream; name="0001-Delete-persist-file-when-symbol-is-set-to-default-va.patch" Content-Disposition: attachment; filename="0001-Delete-persist-file-when-symbol-is-set-to-default-va.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l1toih1n0 RnJvbSBiMDQ5NmE1YTg4NDhkMTEyMzNmMjQxZjZiNzhmMDBmMTUzNjQxMGQ2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdWxzaGFuIFNpbmdoIDxnc2luZ2gyMDExQGdtYWlsLmNvbT4K RGF0ZTogU3VuLCAxMCBBcHIgMjAyMiAxMjoxMzozMSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIERl bGV0ZSBwZXJzaXN0IGZpbGUgd2hlbiBzeW1ib2wgaXMgc2V0IHRvIGRlZmF1bHQgdmFsdWUKCi0t LQogcGVyc2lzdC5lbCAgICAgICAgICAgIHwgMjYgKysrKysrKysrKysrKystLS0tLS0tLS0tLS0K IHRlc3QvcGVyc2lzdC10ZXN0cy5lbCB8ICAzICsrKwogMiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNl cnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9wZXJzaXN0LmVsIGIvcGVy c2lzdC5lbAppbmRleCAwOTFlNDI4Li44YjY0NWVhIDEwMDY0NAotLS0gYS9wZXJzaXN0LmVsCisr KyBiL3BlcnNpc3QuZWwKQEAgLTEzMiwxOCArMTMyLDIwIEBAIHZhcmlhYmxlcyBwZXJzaXN0IGF1 dG9tYXRpY2FsbHkgd2hlbiBFbWFjcyBleGl0cy4iCiAgICh1bmxlc3MgKHBlcnNpc3QtLXBlcnNp c3RhbnQtcCBzeW1ib2wpCiAgICAgKGVycm9yIChmb3JtYXQKICAgICAgICAgICAgICJTeW1ib2wg JXMgaXMgbm90IHBlcnNpc3RhbnQiIHN5bWJvbCkpKQotICAodW5sZXNzIChlcXVhbCAoc3ltYm9s LXZhbHVlIHN5bWJvbCkKLSAgICAgICAgICAgICAgICAgKHBlcnNpc3QtZGVmYXVsdCBzeW1ib2wp KQotICAgIChsZXQgKChkaXItbG9jCi0gICAgICAgICAgIChmaWxlLW5hbWUtZGlyZWN0b3J5Ci0g ICAgICAgICAgICAocGVyc2lzdC0tZmlsZS1sb2NhdGlvbiBzeW1ib2wpKSkpCi0gICAgICAodW5s ZXNzIChmaWxlLWV4aXN0cy1wIGRpci1sb2MpCi0gICAgICAgIChta2RpciBkaXItbG9jKSkpCi0g ICAgKHdpdGgtdGVtcC1idWZmZXIKLSAgICAgIChwcmludCAoc3ltYm9sLXZhbHVlIHN5bWJvbCkg KGN1cnJlbnQtYnVmZmVyKSkKLSAgICAgICh3cml0ZS1yZWdpb24gKHBvaW50LW1pbikgKHBvaW50 LW1heCkKLSAgICAgICAgICAgICAgICAgICAgKHBlcnNpc3QtLWZpbGUtbG9jYXRpb24gc3ltYm9s KQotICAgICAgICAgICAgICAgICAgICBuaWwgJ3F1aWV0KSkpKQorICAobGV0ICgoc3ltYm9sLWZp bGUtbG9jIChwZXJzaXN0LS1maWxlLWxvY2F0aW9uIHN5bWJvbCkpKQorICAgIChpZiAoZXF1YWwg KHN5bWJvbC12YWx1ZSBzeW1ib2wpCisgICAgICAgICAgICAgICAocGVyc2lzdC1kZWZhdWx0IHN5 bWJvbCkpCisgICAgICAgICh3aGVuIChmaWxlLWV4aXN0cy1wIHN5bWJvbC1maWxlLWxvYykKKyAg ICAgICAgICAoZGVsZXRlLWZpbGUgc3ltYm9sLWZpbGUtbG9jKSkKKyAgICAgIChsZXQgKChkaXIt bG9jCisgICAgICAgICAgICAgKGZpbGUtbmFtZS1kaXJlY3Rvcnkgc3ltYm9sLWZpbGUtbG9jKSkp CisgICAgICAgICh1bmxlc3MgKGZpbGUtZXhpc3RzLXAgZGlyLWxvYykKKyAgICAgICAgICAobWtk aXIgZGlyLWxvYykpCisgICAgICAgICh3aXRoLXRlbXAtYnVmZmVyCisgICAgICAgICAgKHByaW50 IChzeW1ib2wtdmFsdWUgc3ltYm9sKSAoY3VycmVudC1idWZmZXIpKQorICAgICAgICAgICh3cml0 ZS1yZWdpb24gKHBvaW50LW1pbikgKHBvaW50LW1heCkKKyAgICAgICAgICAgICAgICAgICAgICAg IHN5bWJvbC1maWxlLWxvYworICAgICAgICAgICAgICAgICAgICAgICAgbmlsICdxdWlldCkpKSkp KQogCiAoZGVmdW4gcGVyc2lzdC1kZWZhdWx0IChzeW1ib2wpCiAgICJSZXR1cm4gdGhlIGRlZmF1 bHQgdmFsdWUgZm9yIFNZTUJPTC4iCmRpZmYgLS1naXQgYS90ZXN0L3BlcnNpc3QtdGVzdHMuZWwg Yi90ZXN0L3BlcnNpc3QtdGVzdHMuZWwKaW5kZXggOWZhNDA2Zi4uYjY2NDVhOSAxMDA2NDQKLS0t IGEvdGVzdC9wZXJzaXN0LXRlc3RzLmVsCisrKyBiL3Rlc3QvcGVyc2lzdC10ZXN0cy5lbApAQCAt NDQsNiArNDQsOSBAQAogICAgICAgICh3aXRoLXRlbXAtYnVmZmVyCiAgICAgICAgICAoaW5zZXJ0 LWZpbGUtY29udGVudHMgKHBlcnNpc3QtLWZpbGUtbG9jYXRpb24gc3ltKSkKICAgICAgICAgIChi dWZmZXItc3RyaW5nKSkpKQorICAgICAoc2V0IHN5bSAxMCkKKyAgICAgKHBlcnNpc3Qtc2F2ZSBz eW0pCisgICAgIChzaG91bGQtbm90IChmaWxlLWV4aXN0cy1wIChwZXJzaXN0LS1maWxlLWxvY2F0 aW9uIHN5bSkpKQogICAgICAoc2hvdWxkLWVycm9yCiAgICAgICAocGVyc2lzdC1zYXZlICdmcmVk KSkpKSkKIAotLSAKMi4zNS4xLjExNzguZzRmMTY1OWQ0NzYtZ29vZwoK --000000000000e0251c05dc51f348-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 11 06:18:19 2022 Received: (at 54346) by debbugs.gnu.org; 11 Apr 2022 10:18:19 +0000 Received: from localhost ([127.0.0.1]:42578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ndr7j-00010C-H8 for submit@debbugs.gnu.org; Mon, 11 Apr 2022 06:18:19 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ndr7i-0000zz-35 for 54346@debbugs.gnu.org; Mon, 11 Apr 2022 06:18:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KKUn26uZWrJChpePlZN5Thyi6xhVCJOyhAsP4pGgRxw=; b=EZ8yGV6tNIaehc366F/N9pBieU nmP7L7m17Q5BkgesdjgC9KSw9yH3JJ/whlBiG3Wrpi/LSdsDm4emtdcTaNuLTWzZAGz5iJPJJI02n 0ht669t9dTlaBcwQpj/AK1GOghgq8AEDMaJKre04c2za3aUmrM+qlUkKhNNEwQM6y5rg=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndr7Y-0001fH-9c; Mon, 11 Apr 2022 12:18:10 +0200 From: Lars Ingebrigtsen To: Gulshan Singh Subject: Re: bug#54346: persist-save doesn't persist variables when the value is set to the default References: <87r177ysjh.fsf@gnus.org> <87pmlpqgix.fsf@gnus.org> Date: Mon, 11 Apr 2022 12:18:01 +0200 In-Reply-To: (Gulshan Singh's message of "Sun, 10 Apr 2022 12:36:54 -0700") Message-ID: <87ee23diue.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Gulshan Singh writes: > I cloned the upstream project [1] and created a merge request [2] > there. The fix deletes the persist file when it gets set back to the > default value, and it modifies a test to verify this behavi [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54346 Cc: 54346@debbugs.gnu.org, Phillip Lord X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Gulshan Singh writes: > I cloned the upstream project [1] and created a merge request [2] > there. The fix deletes the persist file when it gets set back to the > default value, and it modifies a test to verify this behavior. I've > attached the same patch here (created with `git format-patch HEAD^`, I > haven't submitted a patch here before so let me know if this is the > correct way to do this). Yup; looks good. > I'm a little confused though, I see that on the externals/persist > branch [3] there is a commit that does not exist on the upstream > GitLab project. Why is this the case? Should I actually be making a > patch off of the externals/persist branch? That's my error -- I didn't check whether it persist was maintained externally before making that change. So it should be merged upstream. Phillip? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 20 22:14:57 2022 Received: (at 54346) by debbugs.gnu.org; 21 Jun 2022 02:14:58 +0000 Received: from localhost ([127.0.0.1]:58857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3TPt-0001ju-Jj for submit@debbugs.gnu.org; Mon, 20 Jun 2022 22:14:57 -0400 Received: from mail-oa1-f46.google.com ([209.85.160.46]:46728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3TPp-0001jd-BB for 54346@debbugs.gnu.org; Mon, 20 Jun 2022 22:14:56 -0400 Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-1013ecaf7e0so16629650fac.13 for <54346@debbugs.gnu.org>; Mon, 20 Jun 2022 19:14:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ndry1FqfOCIyiStH4FaK2SKvTKPszAzzcrA6fhogIcY=; b=e6RtCD1mHjNtyX1sYZijoBfNO5p8gC7Tz+30vQ/a6EGRzYbRqFDttTLitxLG1KDP2S /CTcB1aD9OwmyXGmFT1iwpA9dyggkUffNJhOa9ScO04HTEMlqf1SnbikFTwquEfbb19y 5Avpi/FjhW8MqQNU+A+g5CwmvJf3rzHjeclE5KqhFeqVpBpXjRv0SBsXRqefzVUafQBS D5MTq/m8nxFse1GLmMLXdJtev7Dlx6SpxX768O7cg21EG5L7ssXH0uuQANnxLqmz0iBn GSiEyQ71IUyruw2Zc0+HCUJL08PZEzO3t2qDTUP5BPTDVQTyBkUAdonOWNyOfYk8gttv ehVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ndry1FqfOCIyiStH4FaK2SKvTKPszAzzcrA6fhogIcY=; b=kROyzHXIMJXtbSxk1aeCXPDb51bLL6KtsW8YXPCRPZzVv6q/9CyvraCPLuQBCka5oz 6CJ6l8VgDccTQ9TMtCJSi2q6ewj39yz0SZffqrsy/Pnu5xUm/j1zW6YOg/10IS7XTnWO c0BPlw+DQ44wjohghbn/VqPAgnMtd/1lz/D7GrfhPSGQMay/AND5CYksyDXf4ylcue6o evNnfKfbUfSCHPnBa8EeUx42zrTTKy604B2su/v/4/K9tvjgajSzPNBYo4u3mbbd8mG+ +YTuIOqIPK6S8j9rbg+tKPWQdjZSqHUxTxsHjsZ8a4pOatQmh0eL1RKuX4HGjSt3byxX Jzpg== X-Gm-Message-State: AJIora+VQvJHUWJDm2Mw0equQXedhC+aPm+Vgcg4/hTc6ff3oYu+wg4Y AsoMeAA+JIuvn6v+pBT0zRURGp1jl3ymrzeM0jSm3aFW X-Google-Smtp-Source: AGRyM1vxffCa5X1NBoQQioak9s5U+SEtNzN7QOnHh2yTFxnVfFcnpetmBQG7EgzIPCivsa78iWwsDSKyhNvgSd7nGTc= X-Received: by 2002:a05:6871:91:b0:fe:1977:afb9 with SMTP id u17-20020a056871009100b000fe1977afb9mr13948106oaa.83.1655777686591; Mon, 20 Jun 2022 19:14:46 -0700 (PDT) MIME-Version: 1.0 References: <87r177ysjh.fsf@gnus.org> <87pmlpqgix.fsf@gnus.org> <87ee23diue.fsf@gnus.org> In-Reply-To: <87ee23diue.fsf@gnus.org> From: Gulshan Singh Date: Mon, 20 Jun 2022 19:14:35 -0700 Message-ID: Subject: Re: bug#54346: persist-save doesn't persist variables when the value is set to the default To: Lars Ingebrigtsen Content-Type: multipart/alternative; boundary="000000000000d61b9505e1ebc85b" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 54346 Cc: 54346@debbugs.gnu.org, Phillip Lord X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --000000000000d61b9505e1ebc85b Content-Type: text/plain; charset="UTF-8" Hi, It's been a few months since the last message here. I also directly sent Phillip an email last week asking if he could take a look at my PR, but I haven't received a response. Do you know what's normally done in cases like this? Even if persist.el is maintained externally, should we just merge my patch and close this bug if we can't get a response from the maintainer? On Mon, Apr 11, 2022 at 3:18 AM Lars Ingebrigtsen wrote: > Gulshan Singh writes: > > > I cloned the upstream project [1] and created a merge request [2] > > there. The fix deletes the persist file when it gets set back to the > > default value, and it modifies a test to verify this behavior. I've > > attached the same patch here (created with `git format-patch HEAD^`, I > > haven't submitted a patch here before so let me know if this is the > > correct way to do this). > > Yup; looks good. > > > I'm a little confused though, I see that on the externals/persist > > branch [3] there is a commit that does not exist on the upstream > > GitLab project. Why is this the case? Should I actually be making a > > patch off of the externals/persist branch? > > That's my error -- I didn't check whether it persist was maintained > externally before making that change. So it should be merged upstream. > > Phillip? > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no > --000000000000d61b9505e1ebc85b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

It's been a few months since th= e last message here. I also directly sent Phillip an email last week asking= if he could take a look at my PR, but I haven't received a response.
Do you know what's normally done in cases like this? Even if pers= ist.el is maintained externally, should we just merge my patch and close th= is bug if we can't get a response from the maintainer?

<= div class=3D"gmail_quote">
On Mon, Apr= 11, 2022 at 3:18 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:
Gulshan Singh <gsingh2011@gmail.com> writes:

> I cloned the upstream project [1] and created a merge request [2]
> there. The fix deletes the persist file when it gets set back to the > default value, and it modifies a test to verify this behavior. I'v= e
> attached the same patch here (created with `git format-patch HEAD^`, I=
> haven't submitted a patch here before so let me know if this is th= e
> correct way to do this).

Yup; looks good.

> I'm a little confused though, I see that on the externals/persist<= br> > branch [3] there is a commit that does not exist on the upstream
> GitLab project. Why is this the case? Should I actually be making a > patch off of the externals/persist branch?

That's my error -- I didn't check whether it persist was maintained=
externally before making that change.=C2=A0 So it should be merged upstream= .

Phillip?

--
(domestic pets only, the antidote for overdose, milk.)
=C2=A0 =C2=A0bloggy blog: http://lars.ingebrigtsen.no
--000000000000d61b9505e1ebc85b-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 21 06:50:04 2022 Received: (at 54346) by debbugs.gnu.org; 21 Jun 2022 10:50:04 +0000 Received: from localhost ([127.0.0.1]:59197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3bSO-0000Kt-3l for submit@debbugs.gnu.org; Tue, 21 Jun 2022 06:50:04 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3bSM-0000KI-2z for 54346@debbugs.gnu.org; Tue, 21 Jun 2022 06:50:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=t4TrWabedJS7PpeMrwO6qremfQynBnZ/oVz88qDZlmE=; b=HA5pX+M1rcY/tHqjvq6KQl0Kpa 2Jn7o0ZQSZBMQyCtsIBRdeLtdk7eJKSvNKtsWui+8NHgATmsPTDcczC5U091z4UXuHN0E+Olcwx5Y Tygx7TJEO/HTr/hLWZQjNoSOvBmEcp7cuPDsdzVa1xY+lxSPjY4Gn3Ti7Mdx5LqGy9AY=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o3bSB-0004Dp-W3; Tue, 21 Jun 2022 12:49:54 +0200 From: Lars Ingebrigtsen To: Gulshan Singh Subject: Re: bug#54346: persist-save doesn't persist variables when the value is set to the default References: <87r177ysjh.fsf@gnus.org> <87pmlpqgix.fsf@gnus.org> <87ee23diue.fsf@gnus.org> X-Now-Playing: Depeche Mode's _A Broken Frame_: "Notihing The fear" Date: Tue, 21 Jun 2022 12:49:51 +0200 In-Reply-To: (Gulshan Singh's message of "Mon, 20 Jun 2022 19:14:35 -0700") Message-ID: <87y1xqz3xs.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Gulshan Singh writes: > Do you know what's normally done in cases like this? Even if > persist.el is maintained externally, should we just merge my patch and > close this bug if we can't get a response from the maintainer? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54346 Cc: Phillip Lord , 54346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Gulshan Singh writes: > Do you know what's normally done in cases like this? Even if > persist.el is maintained externally, should we just merge my patch and > close this bug if we can't get a response from the maintainer? Yes, we can merge the patch. However, it doesn't seem to apply to the version we have in ELPA -- the upstream and the ELPA version have already diverged, apparently. Can you respin the patch against the version in GNU ELPA? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 21 20:56:02 2022 Received: (at 54346) by debbugs.gnu.org; 22 Jun 2022 00:56:02 +0000 Received: from localhost ([127.0.0.1]:33571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3of4-0003BA-4j for submit@debbugs.gnu.org; Tue, 21 Jun 2022 20:56:02 -0400 Received: from mail-oi1-f177.google.com ([209.85.167.177]:42829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3of1-0003Aq-Pl for 54346@debbugs.gnu.org; Tue, 21 Jun 2022 20:56:00 -0400 Received: by mail-oi1-f177.google.com with SMTP id l81so19240263oif.9 for <54346@debbugs.gnu.org>; Tue, 21 Jun 2022 17:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y7XluCWUcpomCfd70WEwr1SrYpG9fE09FSVsdvFL1Lo=; b=g2PFO1t2RB6F31synki2vB2hlV/cvCpm1so+ZB3EUr5Zxzc3sdZDqt1da+VYQRZt9Y VidNgDKc9Gbas3D/VBm2EP9cUJHCT32/DQkXt1kc7Qx7UtTIFkKEatjvhHLJY5HUTR2j vB6lRiIy7o24417NAbAR+XXA74At9Gw6CPTbaaltOggRy4h6+R6DKBngdnxtJ/lBbYqy m1lWlGUBzZNEfzbJe/KCkqGhoCu7c3ODZbq9tcD/JHpw4B0j7RO8zPzg832EEGapb1qc 2OaX6ykCjQaWhzz2NvOxYy/EeJAzEiMIGVPlrjRLzzys+NtkmpCWN2eDW3oBOXBydhqN j/RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y7XluCWUcpomCfd70WEwr1SrYpG9fE09FSVsdvFL1Lo=; b=jJ7sHLQinAOMs34p3VQDe3hRbl2rvPECHL74UTIs+mFGGiQc26qF6GEmHo3ma9HioM PjG5S3fW+pJdemIkV6z0YoxBqtbqESg3s6sKoGIAqWfMZLZPJMSviO75AK2B/25DRniS ENVug1CIYmXgxQVBDdcS3tBmz64Ava09qnjAw6AKaaXVmbBTlDDQlpiPsOxzdClKk4I6 3WPyxIGBKXea+6EAzZtmIaq6CX9SvEsBTY+07RbT3Qj++w9B7lmx5GxaQiwMsCVMtfg+ go+Ni+b42pzj5jP3nXLT2vRpY02pC2Zukh0t5VUkAoEZKlieQdUp0MQL5LTmKWUPGrwe xQBA== X-Gm-Message-State: AOAM530q9fMZYpIOaNE1KJR/g4QNwfoQXdulV7MqiDphpF0jDR2A5DGq c3ilWbrZcZEF/0oB9FTu8xRqcIB5cpq/GY8OOEw= X-Google-Smtp-Source: ABdhPJzuPFe0Srptrx22Xvnh3e1BSxQKm6q5ef/RVqM50j55sVEj92ql7nSpTKmd9UkeES/NjieiNoaJ8w/WTG8PJnQ= X-Received: by 2002:a05:6808:1247:b0:32c:2ba9:4fab with SMTP id o7-20020a056808124700b0032c2ba94fabmr21797209oiv.261.1655859353865; Tue, 21 Jun 2022 17:55:53 -0700 (PDT) MIME-Version: 1.0 References: <87r177ysjh.fsf@gnus.org> <87pmlpqgix.fsf@gnus.org> <87ee23diue.fsf@gnus.org> <87y1xqz3xs.fsf@gnus.org> In-Reply-To: <87y1xqz3xs.fsf@gnus.org> From: Gulshan Singh Date: Tue, 21 Jun 2022 17:55:42 -0700 Message-ID: Subject: Re: bug#54346: persist-save doesn't persist variables when the value is set to the default To: Lars Ingebrigtsen Content-Type: multipart/mixed; boundary="00000000000096217105e1fecca3" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 54346 Cc: Phillip Lord , 54346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --00000000000096217105e1fecca3 Content-Type: multipart/alternative; boundary="00000000000096217005e1fecca1" --00000000000096217005e1fecca1 Content-Type: text/plain; charset="UTF-8" Sure, the attached patch should work on the ELPA version. On Tue, Jun 21, 2022 at 3:50 AM Lars Ingebrigtsen wrote: > Gulshan Singh writes: > > > Do you know what's normally done in cases like this? Even if > > persist.el is maintained externally, should we just merge my patch and > > close this bug if we can't get a response from the maintainer? > > Yes, we can merge the patch. However, it doesn't seem to apply to the > version we have in ELPA -- the upstream and the ELPA version have > already diverged, apparently. > > Can you respin the patch against the version in GNU ELPA? > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no > --00000000000096217005e1fecca1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sure, the attached patch should work on the ELPA version.<= /div>
O= n Tue, Jun 21, 2022 at 3:50 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:
Gulshan Singh <gsingh2011@gmail.com> writes:

> Do you know what's normally done in cases like this? Even if
> persist.el is maintained externally, should we just merge my patch and=
> close this bug if we can't get a response from the maintainer?

Yes, we can merge the patch.=C2=A0 However, it doesn't seem to apply to= the
version we have in ELPA -- the upstream and the ELPA version have
already diverged, apparently.

Can you respin the patch against the version in GNU ELPA?

--
(domestic pets only, the antidote for overdose, milk.)
=C2=A0 =C2=A0bloggy blog: http://lars.ingebrigtsen.no
--00000000000096217005e1fecca1-- --00000000000096217105e1fecca3 Content-Type: application/octet-stream; name="0001-Delete-persist-file-when-symbol-is-set-to-default-va.patch" Content-Disposition: attachment; filename="0001-Delete-persist-file-when-symbol-is-set-to-default-va.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l4ovv40m0 RnJvbSA0ZjI3NzMzYzMyNmM1ZjI0NzY4ZmIwOWZkOGJlNDc0MmZkMTllM2JjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdWxzaGFuIFNpbmdoIDxnc2luZ2gyMDExQGdtYWlsLmNvbT4K RGF0ZTogVHVlLCAyMSBKdW4gMjAyMiAxNzozODo1OCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIERl bGV0ZSBwZXJzaXN0IGZpbGUgd2hlbiBzeW1ib2wgaXMgc2V0IHRvIGRlZmF1bHQgdmFsdWUKCi0t LQogcGVyc2lzdC5lbCAgICAgICAgICAgIHwgMzggKysrKysrKysrKysrKysrKysrKystLS0tLS0t LS0tLS0tLS0tLS0KIHRlc3QvcGVyc2lzdC10ZXN0cy5lbCB8ICAzICsrKwogMiBmaWxlcyBjaGFu Z2VkLCAyMyBpbnNlcnRpb25zKCspLCAxOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9wZXJz aXN0LmVsIGIvcGVyc2lzdC5lbAppbmRleCAzZDhkMWFmLi45NTBkZTNhIDEwMDY0NAotLS0gYS9w ZXJzaXN0LmVsCisrKyBiL3BlcnNpc3QuZWwKQEAgLTEzMiwyNCArMTMyLDI2IEBAIHZhcmlhYmxl cyBwZXJzaXN0IGF1dG9tYXRpY2FsbHkgd2hlbiBFbWFjcyBleGl0cy4iCiAgICh1bmxlc3MgKHBl cnNpc3QtLXBlcnNpc3RhbnQtcCBzeW1ib2wpCiAgICAgKGVycm9yIChmb3JtYXQKICAgICAgICAg ICAgICJTeW1ib2wgJXMgaXMgbm90IHBlcnNpc3RhbnQiIHN5bWJvbCkpKQotICAodW5sZXNzIChl cXVhbCAoc3ltYm9sLXZhbHVlIHN5bWJvbCkKLSAgICAgICAgICAgICAgICAgKHBlcnNpc3QtZGVm YXVsdCBzeW1ib2wpKQotICAgIChsZXQgKChkaXItbG9jCi0gICAgICAgICAgIChmaWxlLW5hbWUt ZGlyZWN0b3J5Ci0gICAgICAgICAgICAocGVyc2lzdC0tZmlsZS1sb2NhdGlvbiBzeW1ib2wpKSkp Ci0gICAgICAodW5sZXNzIChmaWxlLWV4aXN0cy1wIGRpci1sb2MpCi0gICAgICAgIChta2RpciBk aXItbG9jKSkpCi0gICAgKHdpdGgtdGVtcC1idWZmZXIKLSAgICAgIChsZXQgKHByaW50LWxldmVs Ci0JICAgIHByaW50LWxlbmd0aAotICAgICAgICAgICAgcHJpbnQtcXVvdGVkCi0gICAgICAgICAg ICAocHJpbnQtZXNjYXBlLWNvbnRyb2wtY2hhcmFjdGVycyB0KQotICAgICAgICAgICAgKHByaW50 LWVzY2FwZS1ub25hc2NpaSB0KQotICAgICAgICAgICAgKHByaW50LWNpcmNsZSB0KSkKLQkocHJp bnQgKHN5bWJvbC12YWx1ZSBzeW1ib2wpIChjdXJyZW50LWJ1ZmZlcikpKQotICAgICAgKHdyaXRl LXJlZ2lvbiAocG9pbnQtbWluKSAocG9pbnQtbWF4KQotICAgICAgICAgICAgICAgICAgICAocGVy c2lzdC0tZmlsZS1sb2NhdGlvbiBzeW1ib2wpCi0gICAgICAgICAgICAgICAgICAgIG5pbCAncXVp ZXQpKSkpCisgIChsZXQgKChzeW1ib2wtZmlsZS1sb2MgKHBlcnNpc3QtLWZpbGUtbG9jYXRpb24g c3ltYm9sKSkpCisgICAgKGlmIChlcXVhbCAoc3ltYm9sLXZhbHVlIHN5bWJvbCkKKyAgICAgICAg ICAgICAgIChwZXJzaXN0LWRlZmF1bHQgc3ltYm9sKSkKKyAgICAgICAgKHdoZW4gKGZpbGUtZXhp c3RzLXAgc3ltYm9sLWZpbGUtbG9jKQorICAgICAgICAgIChkZWxldGUtZmlsZSBzeW1ib2wtZmls ZS1sb2MpKQorICAgICAgKGxldCAoKGRpci1sb2MKKyAgICAgICAgICAgICAoZmlsZS1uYW1lLWRp cmVjdG9yeSBzeW1ib2wtZmlsZS1sb2MpKSkKKyAgICAgICAgKHVubGVzcyAoZmlsZS1leGlzdHMt cCBkaXItbG9jKQorICAgICAgICAgIChta2RpciBkaXItbG9jKSkKKyAgICAgICAgKHdpdGgtdGVt cC1idWZmZXIKKyAgICAgICAgICAobGV0IChwcmludC1sZXZlbAorICAgICAgICAgICAgICAgIHBy aW50LWxlbmd0aAorICAgICAgICAgICAgICAgIHByaW50LXF1b3RlZAorICAgICAgICAgICAgICAg IChwcmludC1lc2NhcGUtY29udHJvbC1jaGFyYWN0ZXJzIHQpCisgICAgICAgICAgICAgICAgKHBy aW50LWVzY2FwZS1ub25hc2NpaSB0KQorICAgICAgICAgICAgICAgIChwcmludC1jaXJjbGUgdCkp CisgICAgICAgICAgICAocHJpbnQgKHN5bWJvbC12YWx1ZSBzeW1ib2wpIChjdXJyZW50LWJ1ZmZl cikpKQorICAgICAgICAgICh3cml0ZS1yZWdpb24gKHBvaW50LW1pbikgKHBvaW50LW1heCkKKyAg ICAgICAgICAgICAgICAgICAgICAgIHN5bWJvbC1maWxlLWxvYworICAgICAgICAgICAgICAgICAg ICAgICAgbmlsICdxdWlldCkpKSkpKQogCiAoZGVmdW4gcGVyc2lzdC1kZWZhdWx0IChzeW1ib2wp CiAgICJSZXR1cm4gdGhlIGRlZmF1bHQgdmFsdWUgZm9yIFNZTUJPTC4iCmRpZmYgLS1naXQgYS90 ZXN0L3BlcnNpc3QtdGVzdHMuZWwgYi90ZXN0L3BlcnNpc3QtdGVzdHMuZWwKaW5kZXggOWZhNDA2 Zi4uYjY2NDVhOSAxMDA2NDQKLS0tIGEvdGVzdC9wZXJzaXN0LXRlc3RzLmVsCisrKyBiL3Rlc3Qv cGVyc2lzdC10ZXN0cy5lbApAQCAtNDQsNiArNDQsOSBAQAogICAgICAgICh3aXRoLXRlbXAtYnVm ZmVyCiAgICAgICAgICAoaW5zZXJ0LWZpbGUtY29udGVudHMgKHBlcnNpc3QtLWZpbGUtbG9jYXRp b24gc3ltKSkKICAgICAgICAgIChidWZmZXItc3RyaW5nKSkpKQorICAgICAoc2V0IHN5bSAxMCkK KyAgICAgKHBlcnNpc3Qtc2F2ZSBzeW0pCisgICAgIChzaG91bGQtbm90IChmaWxlLWV4aXN0cy1w IChwZXJzaXN0LS1maWxlLWxvY2F0aW9uIHN5bSkpKQogICAgICAoc2hvdWxkLWVycm9yCiAgICAg ICAocGVyc2lzdC1zYXZlICdmcmVkKSkpKSkKIAotLSAKMi4zNy4wLnJjMC4xMDQuZzA2MTE2MTFh OTQtZ29vZwoK --00000000000096217105e1fecca3-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 22 00:22:01 2022 Received: (at 54346) by debbugs.gnu.org; 22 Jun 2022 04:22:01 +0000 Received: from localhost ([127.0.0.1]:33682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3rsP-0000Ea-4D for submit@debbugs.gnu.org; Wed, 22 Jun 2022 00:22:01 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3rsN-0000EF-JX for 54346@debbugs.gnu.org; Wed, 22 Jun 2022 00:22:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=k9fv2UH8xZW5vTBUq96eGXngA6m47LKCXrVftg0dKpk=; b=DvV2z5uOP2erXEYEUBkuDvtIqC OBtK2wosV3wT9j2FvkJMo/nUyDXwmOHyyFlgbRuacgmXgdmeQdReqPoZSnerl+OZstV125nHkPuEk g1kEcCZt1QZe5eHzvrgzkjwJWvNoh8q1hcvpM3V6pYBFPYykC2eIuo89k1I8wJgGyN/0=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o3rsE-0006H5-FI; Wed, 22 Jun 2022 06:21:52 +0200 From: Lars Ingebrigtsen To: Gulshan Singh Subject: Re: bug#54346: persist-save doesn't persist variables when the value is set to the default References: <87r177ysjh.fsf@gnus.org> <87pmlpqgix.fsf@gnus.org> <87ee23diue.fsf@gnus.org> <87y1xqz3xs.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEXaixKce2Cwmkj/ //99tgMYAAAAAWJLR0QDEQxM8gAAAAlwSFlzAAALEgAACxIB0t1+/AAAAAd0SU1FB+YGFgQDJObc sBIAAAEASURBVCjPrdKxTsMwEAbgS9RISacMZGcAhj5Fli5MEeK3iCeElEr1UwSk7l2MgAkGo/qe kovtBCTW3nSfdL47JyY6exRD3835JeUjlQk1FR2tFlTtAroZ87c5z9l4HmO+Kt6123WhQ0kbVpZP qYw9YDhhtwf2fj4/laUO0ky7BVgb79XLlGcZ+HFt0cade30agC7BOAD3CRZThA0KbTHMdV/KYjsD CpA8IEOKB0H1H9qFMkEPSJMJBZRT06TbAO0VC64iWPGrw1FwHSBXjzCs+cOjjvCav90vZAqeBFYG yt5tc4g4aKvGpgnorbK6tc2f31eF7/5c0ucF0V195sfxAyqmZ7+Lo700AAAAWmVYSWZNTQAqAAAA CAAFARIAAwAAAAEAAQAAARoABQAAAAEAAABKARsABQAAAAEAAABSASgAAwAAAAEAAgAAAhMAAwAA AAEAAQAAAAAAAAAAAEgAAAABAAAASAAAAAEfUvc0AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTA2 LTIyVDA0OjAzOjM1KzAwOjAwG7XoFAAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wNi0yMlQwNDow MzozNSswMDowMGroUKgAAAAXdEVYdGV4aWY6WUNiQ3JQb3NpdGlvbmluZwAxrA+AYwAAAABJRU5E rkJggg== X-Now-Playing: Mice Parade's =?utf-8?Q?=5FLapap=E1=BB=8D=5F=3A?= "Finding Faces" Date: Wed, 22 Jun 2022 06:21:48 +0200 In-Reply-To: (Gulshan Singh's message of "Tue, 21 Jun 2022 17:55:42 -0700") Message-ID: <87mte5uy3n.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Gulshan Singh writes: > Sure, the attached patch should work on the ELPA version. Thanks; now pushed to GNU ELPA. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54346 Cc: Phillip Lord , 54346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Gulshan Singh writes: > Sure, the attached patch should work on the ELPA version. Thanks; now pushed to GNU ELPA. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 22 00:22:10 2022 Received: (at control) by debbugs.gnu.org; 22 Jun 2022 04:22:10 +0000 Received: from localhost ([127.0.0.1]:33685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3rsY-0000FB-Af for submit@debbugs.gnu.org; Wed, 22 Jun 2022 00:22:10 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3rsW-0000Ev-3w for control@debbugs.gnu.org; Wed, 22 Jun 2022 00:22:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AqqshjPsPksm6tMQYe2iZmWE4S6XkNFzXzW6NKeSRLo=; b=tKXkXqjsShUUEIDdp0QMczstwC wSJmEdH0hwt/Tpscm0u/udET018Sl3Zycpyhi+1MJ9imIeA+/pEQJu+gnB2y/pnrNW9VcuL4MAMDt yzBQGfai6ZnKL0einaqpFTyHdzewN9rYLk3ICWSZGNMv0TTlOOdyuj/opw3NVLUGqA68=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o3rsO-0006HQ-C0 for control@debbugs.gnu.org; Wed, 22 Jun 2022 06:22:02 +0200 Date: Wed, 22 Jun 2022 06:21:59 +0200 Message-Id: <87letpuy3c.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #54346 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 54346 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 54346 29.1 quit From unknown Wed Jun 18 23:11:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 20 Jul 2022 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator