GNU bug report logs - #54343
28.0.91; find-function goes to a wrong place for erc

Previous Next

Package: emacs;

Reported by: Lin Jian <jlin.dev <at> outlook.com>

Date: Fri, 11 Mar 2022 20:19:01 UTC

Severity: normal

Found in version 28.0.91

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "J.P." <jp <at> neverwas.me>
Cc: Lin Jian <jlin.dev <at> outlook.com>, 54343 <at> debbugs.gnu.org
Subject: bug#54343: 28.0.91; find-function goes to a wrong place for erc
Date: Sun, 13 Mar 2022 15:10:50 +0100
"J.P." <jp <at> neverwas.me> writes:

>   -cl-\\(?:defun\\|defmethod\\)\\|\
>   +cl-\\(?:defun\\|defgeneric\\|defmethod\\)\\|\
>
> appears to work in cursory testing.

Thanks.  So I've now added that in Emacs 29, too.  (But that regexp
there is the single worst thing I've seen in Emacs, so perhaps longer
term it would be nice if it was rewritten.  And perhaps the logic should
be "first look for these things, and if we don't find them, then look
for these other things".  That is, a priority thing.)

> Just a benign optimization involving some culling of redundant code in
> `erc--switch-to-buffer'. This email contains the latest version, with a
> slightly revised commit message:
>
>   https://lists.gnu.org/archive/html/bug-gnu-emacs/2022-01/msg02081.html

I think that makes sense?  But I haven't tested the patch.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 3 years and 71 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.