From unknown Tue Sep 09 21:43:39 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#54329 <54329@debbugs.gnu.org> To: bug#54329 <54329@debbugs.gnu.org> Subject: Status: 28.0.91; custom-prompt-customize-unsaved-options does not return nil Reply-To: bug#54329 <54329@debbugs.gnu.org> Date: Wed, 10 Sep 2025 04:43:39 +0000 retitle 54329 28.0.91; custom-prompt-customize-unsaved-options does not ret= urn nil reassign 54329 emacs submitter 54329 Sebastian Miele severity 54329 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 10 11:33:14 2022 Received: (at submit) by debbugs.gnu.org; 10 Mar 2022 16:33:14 +0000 Received: from localhost ([127.0.0.1]:35355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSLiz-0008S7-Dn for submit@debbugs.gnu.org; Thu, 10 Mar 2022 11:33:14 -0500 Received: from lists.gnu.org ([209.51.188.17]:37170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSLWB-00084d-Tz for submit@debbugs.gnu.org; Thu, 10 Mar 2022 11:20:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSLWB-0006MX-Ob for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2022 11:19:59 -0500 Received: from mout-p-102.mailbox.org ([80.241.56.152]:60350) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1nSLW8-0002bx-S3 for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2022 11:19:59 -0500 Received: from smtp102.mailbox.org (smtp102.mailbox.org [80.241.60.233]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4KDvR60HgDz9skl for ; Thu, 10 Mar 2022 17:19:46 +0100 (CET) From: Sebastian Miele DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=whxvd.name; s=MBO0001; t=1646929184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QT9/hNhlgbw7kgsM5jblT94F5YjNHfs9rwnuUCtdNwA=; b=WUlPwlEWBD0iz6bhLou3eBtffEB7DoL/dcwuWad4CkPo51ZcrveOSjwzyyVHY8V37dSVoC 149f6QgCDzRWOzVrw2k3Bj1/7irSEy/wyLaviCgOgnr1bpP++5pS1sksG91+nlewUpHM7v KG44mZDQZhHThNdREsnqrqjjM5H9lem89kdJOZYWeOpb5t07alhb3R8CovDWE98X4by4Vo EYKsTHzEAuQIlPq3w3V+iOX47entWD0UAkYuM1S9jjA/SvXYnh6v2uyzZVaHoH273LJeN8 aqkGWW5aFDpVC/VIvnXilnSArW+NpkitIiAPHI7VNT05ddsb0/4vZ4Ynvq90Bw== To: bug-gnu-emacs@gnu.org Subject: 28.0.91; custom-prompt-customize-unsaved-options does not return nil Date: Thu, 10 Mar 2022 17:19:07 +0100 Message-ID: <878rthhjae.fsf@whxvd.name> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=80.241.56.152; envelope-from=iota@whxvd.name; helo=mout-p-102.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 10 Mar 2022 11:33:12 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) In an emacs -Q, evaluate (add-hook 'kill-emacs-query-functions 'custom-prompt-customize-unsaved-options) (progn ;; Somthing like the following may be done, e.g., by ;; =E2=80=98activate-transient-input-method=E2=80=99: (setq default-transient-input-method "TeX") (customize-mark-as-set 'default-transient-input-method)) and hit C-x C-c. When asked about whether to examine the unsaved options, say yes. Expected: Emacs does not terminate, so that I can examine. Actual behavior: Emacs terminates. The following diff fixes this issue (and a documentation bug): diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el index c2ddaeb7b1..77840c4b65 100644 --- a/lisp/cus-edit.el +++ b/lisp/cus-edit.el @@ -1531,12 +1531,11 @@ customize-apropos-groups ;;;###autoload (defun custom-prompt-customize-unsaved-options () "Prompt user to customize any unsaved customization options. -Return non-nil if user chooses to customize, for use in +Return nil if user chooses to customize, for use in `kill-emacs-query-functions'." (not (and (custom-unsaved-options) (yes-or-no-p "Some customized options have not been saved; Exam= ine? ") - (customize-unsaved) - t))) + (prog1 t (customize-unsaved))))) ;;; Buffer. Best wishes, Sebastian Miele In GNU Emacs 28.0.91 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, c= airo version 1.17.4) of 2022-03-10 built on huette Repository revision: d184773c2e2a69bea9b96190c83727b4e7a16542 Repository branch: HEAD Windowing system distributor 'The X.Org Foundation', version 11.0.12101003 System Description: Arch Linux Configured using: 'configure --with-x-toolkit=3Dgtk3 --with-mailutils --with-cairo' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LC_CTYPE: de_DE.UTF-8 value of $LANG: C locale-coding-system: utf-8-unix Major mode: mu4e:main Minor modes in effect: vertico-mode: t global-git-commit-mode: t magit-auto-revert-mode: t shell-dirtrack-mode: t savehist-mode: t recentf-mode: t global-so-long-mode: t global-eldoc-mode: t show-paren-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t temp-buffer-resize-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t overwrite-mode: overwrite-mode-binary Load-path shadows: /home/w/usr/emacs/helpful/helpful hides /home/w/.config/emacs/usr/helpful-2= 0220220.2308/helpful /home/w/.config/emacs/usr/transient-20220307.2129/transient hides /home/w/u= sr/emacs/0/.0/lisp/transient Features: (shadow emacsbug macrostep-c cmacexp pulse xref dired-aux face-remap bug-reference cus-edit cus-start calc-map calc-stat calc-vec calc-ext calc-menu calc-aent calc calc-loaddefs rect calc-macs misearch multi-isearch tabify cal-move consult-org vc-git vc-dispatcher saveplace oc-basic disp-table ol-eww ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-search eieio-opt speedbar ezimage dframe ol-docview ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi whx-init::later mu4e mu4e-org mu4e-main mu4e-view mu4e-view-gnus gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum gnus-group gnus-undo gnus-start gnus-dbus dbus gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range gnus-win mu4e-view-common mu4e-headers mu4e-compose mu4e-context mu4e-draft mu4e-actions ido rfc2368 smtpmail sendmail mu4e-mark mu4e-proc mu4e-utils doc-view jka-compr image-mode exif mu4e-lists mu4e-message flow-fill mule-util hl-line mu4e-vars mu4e-meta apache-mode systemd pkgbuild-mode flymake-proc flymake project warnings cmake-font-lock cmake-mode rst gitignore-mode gitconfig-mode conf-mode gitattributes-mode sh-script executable lua-mode json-mode json-snatcher js cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs yaml-mode vcard css-mode smie sgml-mode facemenu eww url-queue shr kinsoku svg xml dom mm-url gnus nnheader markdown-mode color thingatpt tex-mode compile ob-shell org-bullets ox-odt rng-loc rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util ox-latex ox-icalendar org-agenda ox-html table ox-ascii ox-publish ox ace-window avy consult-vertico consult magit-bookmark bookmark orderless vertico magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func magit-diff smerge-mode diff diff-mode git-commit log-edit message rmc puny rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log magit-core magit-autorevert autorevert filenotify magit-margin magit-transient magit-process with-editor magit-mode magit-git magit-base magit-section crm diary-lib diary-loaddefs cal-iso helpful imenu trace edebug info-look f elisp-refs man dired dired-loaddefs descr-text tramp-sh tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat shell parse-time iso8601 ls-lisp server whx::safe-local whx-etc::0 whx::transient whx::arg whx::plist whx::list transient cl-extra whx::elpa whx-boot-lib::elpa whx-etc::org whx-etc::org-link whx-etc::org-password whx::password whx::pcase whx::walk org-element org-persist xdg org-id org-refile avl-tree generator whx-etc::org-hide cus-load org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete pcomplete comint ansi-color org-list org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-table ol org-keys oc org-compat advice org-macs org-loaddefs format-spec cal-menu calendar cal-loaddefs whx-etc::elisp whx::elisp whx::string s whx::feature dash debug backtrace find-func macrostep pp whx-etc::gc edmacro kmacro whx::binary-unit-prefix whx::bind whx::log whx::meta whx::cl whx::error whx-etc::session savehist recentf tree-widget wid-edit whx-etc::custom whx-etc::core-settings so-long noutline outline easy-mmode diminish no-littering whx-etc::modus-operandi whx-etc::modus-operandi-theme modus-operandi-theme whx::custom modus-themes time-date finder-inf geiser-impl help-fns radix-tree help-mode geiser-custom geiser-base ring package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source eieio eieio-core eieio-loaddefs password-cache json map url-vars seq byte-opt bytecomp byte-compile cconv whx-init::early whx-boot whx-boot::run-level whx-boot-etc::run-level cl-seq whx-boot-etc::packages whx-boot-etc::directories whx-boot::after-init-hook whx-boot-etc::core-settings whx-boot-lib::custom whx-boot-lib::fs-path subr-x whx-boot-lib::symbol whx-boot::session-type whx-boot::verbosity whx-boot-lib::log whx-boot::early-cmdline whx-boot-lib::string rx whx-boot-lib::feature whx-boot-lib::0 info whx-boot-lib::list whx-boot-lib::meta whx-boot-lib::pcase pcase whx-boot-lib::error cl-macs gv cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 796178 377838) (symbols 48 59796 95) (strings 32 239722 35837) (string-bytes 1 7038659) (vectors 16 93521) (vector-slots 8 2209654 370338) (floats 8 569 1111) (intervals 56 13204 6070) (buffers 992 26)) From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 10 12:09:58 2022 Received: (at 54329) by debbugs.gnu.org; 10 Mar 2022 17:09:58 +0000 Received: from localhost ([127.0.0.1]:35414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSMIY-00013b-5S for submit@debbugs.gnu.org; Thu, 10 Mar 2022 12:09:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSMIW-00013P-I3 for 54329@debbugs.gnu.org; Thu, 10 Mar 2022 12:09:57 -0500 Received: from [2001:470:142:3::e] (port=59620 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSMIR-00025N-5W; Thu, 10 Mar 2022 12:09:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=NlQqqCaH11hC1+DlLbxJSE5t461IRGP8FMfv1Lnh8oQ=; b=Y6KPHYUtCeUSQOeKEsUx 7sA0M50qWupU0ItqRqDbWSJ6Pmz9UaAZklDOag4VJ6vGj/ryailwwY7UYYk0Vp3XSwO4ivi09qMWk S5Hyd5gtCvEJL0dfI2oXy8d/AJV1gRrfMsU5eGgU+yhGGn9thZCX8WzfN6ROzXEeDR7Xb3f1AXT/0 LdADq3aX+Gy5dMXMIg++z/s0rDh7QVTO7JimyjayaxWQvUcAVqIuRkOGIQI2qBJKLDcYOsoLfl1oW Woe4TZ49pxwTdpmR3gamxYP67qz4YRhstWw8inopCuvBIX1stsFMDKDXD1SNv1bjg9vWCz2Ahi4ZJ 5t1KBkoA4Blf2A==; Received: from [87.69.77.57] (port=4412 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSMIQ-0002tz-Hg; Thu, 10 Mar 2022 12:09:50 -0500 Date: Thu, 10 Mar 2022 19:09:49 +0200 Message-Id: <835yolentu.fsf@gnu.org> From: Eli Zaretskii To: Sebastian Miele In-Reply-To: <878rthhjae.fsf@whxvd.name> (message from Sebastian Miele on Thu, 10 Mar 2022 17:19:07 +0100) Subject: Re: bug#54329: 28.0.91; custom-prompt-customize-unsaved-options does not return nil References: <878rthhjae.fsf@whxvd.name> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54329 Cc: 54329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Sebastian Miele > Date: Thu, 10 Mar 2022 17:19:07 +0100 > > In an emacs -Q, evaluate > > (add-hook 'kill-emacs-query-functions > 'custom-prompt-customize-unsaved-options) > > (progn > ;; Somthing like the following may be done, e.g., by > ;; ‘activate-transient-input-method’: > (setq default-transient-input-method "TeX") > (customize-mark-as-set 'default-transient-input-method)) > > and hit C-x C-c. When asked about whether to examine the unsaved > options, say yes. > > Expected: Emacs does not terminate, so that I can examine. > > Actual behavior: Emacs terminates. > > The following diff fixes this issue (and a documentation bug): > > diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el > index c2ddaeb7b1..77840c4b65 100644 > --- a/lisp/cus-edit.el > +++ b/lisp/cus-edit.el > @@ -1531,12 +1531,11 @@ customize-apropos-groups > ;;;###autoload > (defun custom-prompt-customize-unsaved-options () > "Prompt user to customize any unsaved customization options. > -Return non-nil if user chooses to customize, for use in > +Return nil if user chooses to customize, for use in If you want to prevent Emacs from terminating, you can simply return nil from your hook function. I see no reason to change the semantics of the return value for a single use case: this function was evidently assuming a different use case, and it exists in this shape long enough to prevent us to change its behavior in such a radical way. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 10 12:58:31 2022 Received: (at 54329) by debbugs.gnu.org; 10 Mar 2022 17:58:31 +0000 Received: from localhost ([127.0.0.1]:35451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSN3W-0002Ng-QS for submit@debbugs.gnu.org; Thu, 10 Mar 2022 12:58:31 -0500 Received: from mout-p-101.mailbox.org ([80.241.56.151]:34242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSN3U-0002NQ-Au for 54329@debbugs.gnu.org; Thu, 10 Mar 2022 12:58:28 -0500 Received: from smtp102.mailbox.org (smtp102.mailbox.org [80.241.60.233]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4KDxcs4Sq1z9skM; Thu, 10 Mar 2022 18:58:21 +0100 (CET) References: <878rthhjae.fsf@whxvd.name> <835yolentu.fsf@gnu.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=whxvd.name; s=MBO0001; t=1646935099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PDZqvvT6KuMdSic5l+bkjB5N7u1NCAqPQ0dphCnmIHQ=; b=LEjAfvu9o+ENM3ipnp/TnrO6r+FAdnJIFt41pKjbKO9X+noQufFbabsPhMq6q0BXfeqXHf yGlYg0Ed3vwTxS2gGAquyimFZoreNyd815mPFpUo9/MxvasdwzEQsULrjimWjoHNWsx6Z/ 99ofL1OJn20+ZzzZwWMHQoZj1KkZs8MEFXfTWJchBJs48Jh+pG7tTG4iIhqFYYbZ/X0MNS qpBireqLHwzLGIXy1iBN275Qe+pjo4B7SD62/AxCMoQg3Coz8zwUWzXc+IcTtcKdwjfJex ++ioec3xEKfFxwR3mFYVkHCw7FyAVCHnwq3DaAuMGJuJctABtIG+xXqZm/n9iw== From: Sebastian Miele To: Eli Zaretskii Subject: Re: bug#54329: 28.0.91; custom-prompt-customize-unsaved-options does not return nil Date: Thu, 10 Mar 2022 18:17:02 +0100 In-reply-to: <835yolentu.fsf@gnu.org> Message-ID: <87v8wlg05i.fsf@whxvd.name> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54329 Cc: 54329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Eli, Eli Zaretskii : > If you want to prevent Emacs from terminating, you can simply return > nil from your hook function. I see no reason to change the semantics > of the return value for a single use case: this function was evidently > assuming a different use case, and it exists in this shape long enough > to prevent us to change its behavior in such a radical way. This is not about me wanting to change the behavior of =E2=80=98custom-prompt-customize-unsaved-options=E2=80=99. It definitely i= s a bug in Emacs 28. The definition (defun custom-prompt-customize-unsaved-options () (not (and (custom-unsaved-options) (yes-or-no-p "Some customized options have not been saved; Ex= amine? ") (customize-unsaved) t))) seems to be unchanged from Emacs 27.2 to Emacs 28. However, in Emacs 27.2, it did work as I expect and as I understand the Emacs manual: Please note that any customizations you have not chosen to save for future sessions will be lost when you terminate Emacs. If you=E2=80=99d like to be prompted about unsaved customizations at termination time, add the following to your initialization file: (add-hook 'kill-emacs-query-functions 'custom-prompt-customize-unsaved-options) (For =E2=80=98custom-prompt-customize-unsaved-options=E2=80=99 to have a/th= e sensible meaning as a member of =E2=80=98kill-emacs-query-functions=E2=80=99, it mus= t return nil when there are unsaved options and the user answered "yes".) The reason that the behavior of =E2=80=98custom-prompt-customize-unsaved-options=E2=80=99 changed from vers= ion 27.2 to 28 almost certainly is the following: =E2=80=98custom-prompt-customize-unsaved-options=E2=80=99 calls =E2=80=98cu= stomize-unsaved=E2=80=99 which ends with call to =E2=80=98custom-buffer-create=E2=80=99. The defini= tion of =E2=80=98custom-buffer-create=E2=80=99 changed from Emacs 27.2 to Emacs 28.= In Emacs 27.2 it probably always returned non-nil. In Emacs 28 it always returns nil. However, the (and ...) form in =E2=80=98custom-prompt-customize-unsaved-options=E2=80=99 depends on =E2=80=98customize-unsaved=E2=80=99 to always return non-nil in order to be= correct. =E2=80=98custom-prompt-customize-unsaved-options=E2=80=99 always had the bu= g reported here. It just did not manifest before =E2=80=98custom-buffer-create=E2=80= =99 was changed from Emacs 27.2 to Emacs 28. Best wishes, Sebastian From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 10 13:29:48 2022 Received: (at 54329) by debbugs.gnu.org; 10 Mar 2022 18:29:48 +0000 Received: from localhost ([127.0.0.1]:35484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSNXn-0003FW-TE for submit@debbugs.gnu.org; Thu, 10 Mar 2022 13:29:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSNXl-0003FK-S2 for 54329@debbugs.gnu.org; Thu, 10 Mar 2022 13:29:47 -0500 Received: from [2001:470:142:3::e] (port=32802 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSNXf-00062Y-Vf; Thu, 10 Mar 2022 13:29:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=KEouRAakDqynvq0fmOr/Roo9fQf+P9sWUiRFEPwtpVU=; b=paRZ5zMrE5GjRn+rLCWx Zr147FaCp1hS+bQSukinv7dcwsicUpTCY6DZ1pkSWcZo1BCNw6IIjQqlhu22xI3/JJw2Spu4j4Pc/ dfTa5Inu0dBU68XhsCk+/Gol5aaa3XXk4jHXBKqxA55oT629DYUp8BsrkbYzp03KOZPweA/+xwGOw V48kzVsGZ9wWRdPDVbkhLeCoakqK2Di70tNxgNWqaozObptcgdKu+nkogVIsjHJtyuzyqf1+nrccJ gHqyxeV7x3Cd1DLJopZGC4Z1t4AF2pcAN8r5ERKBjVZT7i0WDe1eiARSTsO0F9Iwz1dOQ2Z2KbUu4 Th1SsYNsEmgY0g==; Received: from [87.69.77.57] (port=1590 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSNXf-0007L8-BM; Thu, 10 Mar 2022 13:29:39 -0500 Date: Thu, 10 Mar 2022 20:29:38 +0200 Message-Id: <83wnh1d5kd.fsf@gnu.org> From: Eli Zaretskii To: Sebastian Miele In-Reply-To: <87v8wlg05i.fsf@whxvd.name> (message from Sebastian Miele on Thu, 10 Mar 2022 18:17:02 +0100) Subject: Re: bug#54329: 28.0.91; custom-prompt-customize-unsaved-options does not return nil References: <878rthhjae.fsf@whxvd.name> <835yolentu.fsf@gnu.org> <87v8wlg05i.fsf@whxvd.name> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54329 Cc: 54329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Sebastian Miele > Cc: 54329@debbugs.gnu.org > Date: Thu, 10 Mar 2022 18:17:02 +0100 > > The reason that the behavior of > ‘custom-prompt-customize-unsaved-options’ changed from version 27.2 to > 28 almost certainly is the following: > > ‘custom-prompt-customize-unsaved-options’ calls ‘customize-unsaved’ > which ends with call to ‘custom-buffer-create’. The definition of > ‘custom-buffer-create’ changed from Emacs 27.2 to Emacs 28. In Emacs > 27.2 it probably always returned non-nil. In Emacs 28 it always > returns nil. > > However, the (and ...) form in > ‘custom-prompt-customize-unsaved-options’ depends on > ‘customize-unsaved’ to always return non-nil in order to be correct. > > ‘custom-prompt-customize-unsaved-options’ always had the bug reported > here. It just did not manifest before ‘custom-buffer-create’ was > changed from Emacs 27.2 to Emacs 28. Thanks, this was the information I missed. I installed a minor variation of your changes on the emacs-28 branch. Please take a look. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 10 13:57:04 2022 Received: (at 54329) by debbugs.gnu.org; 10 Mar 2022 18:57:04 +0000 Received: from localhost ([127.0.0.1]:35514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSNyB-00040t-QJ for submit@debbugs.gnu.org; Thu, 10 Mar 2022 13:57:03 -0500 Received: from mout-p-202.mailbox.org ([80.241.56.172]:45116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSNy9-00040D-AS for 54329@debbugs.gnu.org; Thu, 10 Mar 2022 13:57:03 -0500 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4KDywQ6T2wz9slV; Thu, 10 Mar 2022 19:56:54 +0100 (CET) References: <878rthhjae.fsf@whxvd.name> <835yolentu.fsf@gnu.org> <87v8wlg05i.fsf@whxvd.name> <83wnh1d5kd.fsf@gnu.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=whxvd.name; s=MBO0001; t=1646938612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Bb8pvcd5imnvNiZIjsIvQHinNkIea3YspSoSG8byp6w=; b=DcS40w6D6TtxvEml68b5/ADceIkVtNMQFvdzBvm9OGZMLYXCL2eSlyQ0W57Nwj0sHm5Dzf SektXUz+sOju1eLBPs/RR9U2S+z83TAY1DaPyJFde3Cww+4tLDGRFZ2BypknNXuC+RDasF MXOSGGcF2YL8SOCD1hndaWDooTNrmqIOOcdmtg9ZYcZsZQL1hjZglVLxKX2iGIDHg0z6BZ eHM6KnVtcQc9DdhzTTji301owDy8sj8QPuSEib0/i1lu7FSWVVm0MnB5xHSg/D9bYOm/VP rxBcHusllojIWhT5SfFopShNBmGv4TcngJoFP31FRLkk/cnXqrXUB3OFChFksw== From: Sebastian Miele To: Eli Zaretskii Subject: Re: bug#54329: 28.0.91; custom-prompt-customize-unsaved-options does not return nil Date: Thu, 10 Mar 2022 19:55:55 +0100 In-reply-to: <83wnh1d5kd.fsf@gnu.org> Message-ID: <87y21hab66.fsf@whxvd.name> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54329 Cc: 54329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii : > I installed a minor variation of your changes on the emacs-28 branch. > Please take a look. Thank you. Looks good and seems to work. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 10 14:56:16 2022 Received: (at 54329-done) by debbugs.gnu.org; 10 Mar 2022 19:56:16 +0000 Received: from localhost ([127.0.0.1]:35568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSOtU-0005dj-22 for submit@debbugs.gnu.org; Thu, 10 Mar 2022 14:56:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSOtS-0005dN-9A for 54329-done@debbugs.gnu.org; Thu, 10 Mar 2022 14:56:14 -0500 Received: from [2001:470:142:3::e] (port=34004 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSOtL-0002d1-61; Thu, 10 Mar 2022 14:56:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=srTCdd4ah6rb8nCR1yvNMdQ/PRH4V4HbHIM4HbWQn+I=; b=BtiNbKtbHX4r qeuTdAUWxsvqazhxKvgN5WQ7DPviMKNKTYijl8CNYnuxZi7iH+lyK853qnEl6RJGCM6D5KbC+b6nu QQFeNb8Leh1DcITQIfhMr2c+iqB+v7WQzYyI71Z2uK08BPuSvMRUg/DtuQnZBGs9IRiDiy2XIeaDF 7QQRfV5Py7nxvgfKEWHI4YZ6qHTu87zOOLdkaOMSAdwisMv9KEiFw3JXNMkKV6CsuKK0L1ZUquv2N fZfy0WgRlmR8ot25cIfz0tI0Hdn4jP8RvSSxAYhKjxLAaku9FfFMnDBXxeaFvDqEm0amcZvgHY184 yUnzsZFVvJ73lKJtyDDilg==; Received: from [87.69.77.57] (port=2863 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSOt9-0002Dm-Fl; Thu, 10 Mar 2022 14:56:06 -0500 Date: Thu, 10 Mar 2022 21:55:50 +0200 Message-Id: <83v8wld1kp.fsf@gnu.org> From: Eli Zaretskii To: Sebastian Miele In-Reply-To: <87y21hab66.fsf@whxvd.name> (message from Sebastian Miele on Thu, 10 Mar 2022 19:55:55 +0100) Subject: Re: bug#54329: 28.0.91; custom-prompt-customize-unsaved-options does not return nil References: <878rthhjae.fsf@whxvd.name> <835yolentu.fsf@gnu.org> <87v8wlg05i.fsf@whxvd.name> <83wnh1d5kd.fsf@gnu.org> <87y21hab66.fsf@whxvd.name> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54329-done Cc: 54329-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Sebastian Miele > Cc: 54329@debbugs.gnu.org > Date: Thu, 10 Mar 2022 19:55:55 +0100 > > Eli Zaretskii : > > I installed a minor variation of your changes on the emacs-28 branch. > > Please take a look. > > Thank you. Looks good and seems to work. Great, I'm therefore closing this bug. Thanks. From unknown Tue Sep 09 21:43:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 08 Apr 2022 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator