GNU bug report logs - #54328
[PATCH] Add emacs-org-remark-1.0.3

Previous Next

Full log

Message #8 received at 54328 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Алексей Дроздов
 <drozdov <at> portalenergy.tech>
Cc: 54328 <at> debbugs.gnu.org
Subject: Re: [bug#54328] [PATCH] Add emacs-org-remark-1.0.3
Date: Thu, 10 Mar 2022 18:28:46 +0100

Hello,

Алексей Дроздов <drozdov <at> portalenergy.tech> writes:

> Subject: [PATCH] Add emacs-org-remark-1.0.3

Thanks. Some comments follow.

First, our commit messages are somewhat normalized, so this should be:

   gnu: Add emacs-org-remark.

   * gnu/packages/emacs-xyz.scm (emacs-org-remark): New variable.

Note the message doesn't contain the version, but specify the exact name
of the variable being added.

> +(define-public emacs-org-remark
> +  (let ((commit "b2e632cf66c748951910bc493915759ee8a9c22c")
> +        (revision "0"))

You don't need to specify a revision since this pair matches an
un-tagged version bump.

> +    (package
> +      (name "emacs-org-remark")
> +      (version (git-version "1.0.3" revision commit))

Per above, this should be plain "1.0.3".

> +      (description "@code{emacs-org-remark} lets you highlight and annotate any text file with using Org mode.")

I think the name is Org-remark, not emacs-org-remark, which is the name
of the Guix variable.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.